Re: [ovs-dev] [PATCH net-next v2] selftests: openvswitch: retry instead of sleep

2024-07-11 Thread Ilya Maximets
t; --- > .../selftests/net/openvswitch/openvswitch.sh | 45 +++ > .../selftests/net/openvswitch/ovs-dpctl.py| 1 + > 2 files changed, 38 insertions(+), 8 deletions(-) Seem like we don't have a signal from CI for some reason yet, but I tested this locally and it seem to work fine. Either way it's a better way of doing things than sleep'n'hope. Reviewed-by: Ilya Maximets

Re: [ovs-dev] [PATCH v1] selftests: openvswitch: retry instead of sleep

2024-07-08 Thread Ilya Maximets
On 7/8/24 15:44, Adrian Moreno wrote: > There are a couple of places where the test script "sleep"s to wait for > some external condition to be met. > > This is error prone, specially in slow systems (identified in CI by > "KSFT_MACHINE_SLOW=yes"). > > To fix this, add a "ovs_wait" function that

Re: [PATCH net-next v7 10/10] selftests: openvswitch: add psample test

2024-07-01 Thread Ilya Maximets
elftests/net/openvswitch/openvswitch.sh | 115 +- > .../selftests/net/openvswitch/ovs-dpctl.py| 73 ++- > 2 files changed, 182 insertions(+), 6 deletions(-) This version seems to work correctly with and without arguments. Tested-by: Ilya Maximets

Re: [PATCH net-next v5 10/10] selftests: openvswitch: add emit_sample test

2024-06-26 Thread Ilya Maximets
it_sample word. This makes './openvswitch.sh emit_sample' to not run the test, because 'emit_sample' != 'emit_sample '. Best regards, Ilya Maximets.

Re: [PATCH net-next v2] net: ctnetlink: support filtering by zone

2024-02-02 Thread Ilya Maximets
efault zone. Is that correct or am I reading that wrong? If my observation is correct, then I don't think this functionality can actually be used by applications as it does something unexpected. Best regards, Ilya Maximets.