Re: [PATCH v3 5/7] perf test: Introduce storing logs for shell tests

On Mon, Jul 21, 2025 at 6:27 AM Jakub Brnak wrote: > > From: Veronika Molnarova > > Create temporary directories for storing log files for shell tests > that could help while debugging. The log files are necessary for > perftool testsuite test cases also. If the variable KEEP_TEST_LOGS > is set k

Re: [PATCH v1 12/13] tools headers: Sync compiler.h headers

On Mon, Mar 11, 2024 at 9:34 AM James Clark wrote: > > > > On 10/03/2024 02:05, Ian Rogers wrote: > > compiler.h - synced from include/linux/compiler.h, guards were > > added to definitions to avoid redefinition of macros > > in libc. ftrace, CONFIG_OBJTOOL a

Re: [PATCH v1 02/13] libbpf: Make __printf define conditional

On Mon, Mar 11, 2024 at 10:49 AM Andrii Nakryiko wrote: > > On Sat, Mar 9, 2024 at 6:05 PM Ian Rogers wrote: > > > > libbpf depends upon linux/err.h which has a linux/compiler.h > > dependency. In the kernel includes, as opposed to the tools version, > > l

[PATCH v1 13/13] tools headers: Rename noinline to __noinline

__noinline which is more consistent with other compiler attributes. [1] https://clang.llvm.org/docs/AttributeReference.html#noinline Reported-by: Christopher Di Bella Signed-off-by: Ian Rogers --- tools/include/linux/compiler_attributes.h | 4 ++-- tools/perf/arch/x86/tests/bp-modify.c | 4

[PATCH v1 12/13] tools headers: Sync compiler.h headers

one and so synchronizing with the kernel version was infeasible. types.h - remove __must_check definition that conflicts with compiler.h. Signed-off-by: Ian Rogers --- tools/include/asm-generic/bitops/non-atomic.h | 1 + tools/include/asm/rwonce.h| 63 +++ tools/include

[PATCH v1 11/13] tools headers: Sync linux/overflow.h

file drifts from the kernel's version. Signed-off-by: Ian Rogers --- tools/include/linux/overflow.h | 331 ++--- tools/perf/check-headers.sh| 1 + 2 files changed, 268 insertions(+), 64 deletions(-) diff --git a/tools/include/linux/overflow.h b/tools/in

[PATCH v1 10/13] asm-generic: Avoid transitive dependency for unaligned.h

unaligned.h uses types from linux/types.h such as u64, but doesn't directly import linux/types.h. This can cause breakages when the declarations of the types is reliant on a transitive dependency and the dependencies change. Add the missing header file to avoid this. Signed-off-by: Ian R

[PATCH v1 09/13] tools headers: Rewrite linux/atomic.h using C11's stdatomic.h

C code is compiled with the -std=gnu11 flag, it is possible to use stdatomic.h and move the build and other complications to the compiler/libc. Signed-off-by: Ian Rogers --- tools/arch/x86/include/asm/atomic.h | 84 -- tools/include/asm-generic/atomic-gcc.h| 95

[PATCH v1 08/13] perf arm-spe: Add missing linux/types.h include

u64 is used for various structs in arm-spe-decoder.h, while uint64_t is used in arm-spe-pkt-decoder.h. Avoid transitive dependencies bringing in linux/types.h and directly depend upon it in arm-spe-decoder.h. Fix arm-spe-decoder.c to use uint64_t, as the header file does. Signed-off-by: Ian

[PATCH v1 07/13] perf cacheline: Add missing linux/types.h include

u64 is used in this header for cl_address and cl_offset, so linux/types.h is necessary. Add to avoid compilation errors that aren't currently seen due to transitive dependencies. Signed-off-by: Ian Rogers --- tools/perf/util/cacheline.h | 1 + 1 file changed, 1 insertion(+) diff --git a/

[PATCH v1 06/13] perf debug: Add missing linux/types.h include

u64 is used in this header for eprintf_time and so linux/types.h is necessary. Add to avoid compilation errors that aren't currently seen due to transitive dependencies. Signed-off-by: Ian Rogers --- tools/perf/util/debug.h | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/perf

[PATCH v1 05/13] perf expr: Tidy up header guard

Make the header guard reflect the name of the file and add a comment to the terminating endif. Signed-off-by: Ian Rogers --- tools/perf/util/expr.h | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/tools/perf/util/expr.h b/tools/perf/util/expr.h index d4166b3eb654

[PATCH v1 04/13] perf expr: Add missing stdbool.h include

bool is used in this header and so stdbool.h is necessary. Add to avoid compilation errors that aren't currently seen due to transitive dependencies. Signed-off-by: Ian Rogers --- tools/perf/util/expr.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/perf/util/expr.h b/tools

[PATCH v1 03/13] libperf xyarray: Use correct stddef.h include

sys/types.h may not define both NULL and size_t used in this file. Change the dependency to the correct stddef.h one. Signed-off-by: Ian Rogers --- tools/lib/perf/include/internal/xyarray.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/lib/perf/include/internal

[PATCH v1 02/13] libbpf: Make __printf define conditional

icate definition compilation error when trying to update the tools/include/linux/compiler.h. Fix this by adding the missing ifndef. Signed-off-by: Ian Rogers --- tools/lib/bpf/libbpf.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/tools/lib/bpf/libbpf.c b/tools/lib/bpf/lib

[PATCH v1 01/13] tools bpf: Synchronize bpf.h with kernel uapi version

lude/uapi/linux/bpf_perf_event.h to the check-headers.sh script. Signed-off-by: Ian Rogers --- tools/include/uapi/linux/bpf.h | 1 + tools/perf/check-headers.sh| 3 +++ 2 files changed, 4 insertions(+) diff --git a/tools/include/uapi/linux/bpf.h b/tools/include/uapi/linux/bpf.h index 7f24d898efbb..754e

[PATCH v1 00/13] tools header compiler.h update

move to C11. Ian Rogers (13): tools bpf: Synchronize bpf.h with kernel uapi version libbpf: Make __printf define conditional libperf xyarray: Use correct stddef.h include perf expr: Add missing stdbool.h include perf expr: Tidy up header guard perf debug: Add missing linux/types.h in