Re: "stty sane" in kunit.py

2024-11-08 Thread Daniel Latypov
(resend, gmail decided to switch to html email :\) David would know best. As you probably saw, this was added in 021ed9f551da ("kunit: Run all KUnit tests through allyesconfig"). This was specifically for running on UML, _not_ QEMU. I vaguely remember it being along the lines of #1, but not what

Re: [PATCH v6] lib: add basic KUnit test for lib/math

2024-05-16 Thread Daniel Latypov
On Thu, May 16, 2024 at 3:19 AM Devarsh Thakkar wrote: > > Hi Daniel, Andy, > > On 16/04/21 23:34, Daniel Latypov wrote: > > Add basic test coverage for files that don't require any config options: > > * part of math.h (what seem to be the most commonly used ma

Re: [PATCH v2] Documentation: kunit: Clarify test filter format

2024-04-03 Thread Daniel Latypov
On Tue, Apr 2, 2024 at 5:51 AM Brendan Jackman wrote: > > It seems obvious once you know, but at first I didn't realise that the > suite name is part of this format. Document it and add some examples. > > Signed-off-by: Brendan Jackman Reviewed-by: Daniel Latypov Thanks

Re: [PATCH] Documentation: kunit: Clarify test filter format

2024-03-28 Thread Daniel Latypov
On Thu, Mar 28, 2024 at 7:20 AM 'Brendan Jackman' via KUnit Development wrote: > > It seems obvious once you know, but at first I didn't realise that the > suite name is part of this format. Document it and add example. > > Signed-off-by: Brendan Jackman > --- > Documentation/dev-tools/kunit/run

Re: [PATCH v3] kunit: tool: add ability to parse multiple files

2024-03-15 Thread Daniel Latypov
On Thu, Mar 7, 2024 at 2:29 PM Rae Moar wrote: > > Add ability to parse multiple files. Additionally add the > ability to parse all results in the KUnit debugfs repository. > > How to parse multiple files: > > ./tools/testing/kunit/kunit.py parse results.log results2.log > > How to parse all files

Re: [PATCH v2] kunit: tool: add ability to parse multiple files

2024-03-06 Thread Daniel Latypov
On Wed, Mar 6, 2024 at 2:30 PM Rae Moar wrote: > Note: looks like there's two small bugs w/ the stdin codepath. If both are addressed, it looks like stdin works again for me. > Changes since v1: > - Annotate type of parsed_files > - Add ability to input file name from stdin again > - Make for

Re: [PATCH] kunit: tool: add parsing of all files in directory

2024-02-22 Thread Daniel Latypov
On Thu, Feb 22, 2024 at 2:18 PM Rae Moar wrote: > > Add ability to parse all files within a directory. Additionally add the > ability to parse all results in the KUnit debugfs repository. Nice, I'd been hoping for this. It's enough to pull me back in for a bit :) > tools/testing/kunit/kunit.p

Re: [PATCH 2/9] lib/cmdline: Fix an invalid format specifier in an assertion msg

2024-02-22 Thread Daniel Latypov
. Someone else sees an error report from this test and needs to investigate. What message is easier to deal with? > in test 18 at -5 out of bound or > in test 18 at 18446744073709551611 out of bound Sure, I can eventually figure out what both messages mean, but it's a immediately obvi

Re: [PATCH 1/9] kunit: test: Log the correct filter string in executor_test

2024-02-21 Thread Daniel Latypov
sts for filtering attributes") > Signed-off-by: David Gow Reviewed-by: Daniel Latypov > --- > lib/kunit/executor_test.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/lib/kunit/executor_test.c b/lib/kunit/executor_test.c > index 22d4ee86dbed..3f7f

Re: [PATCH 3/3] MAINTAINERS: Require kunit core tests for framework changes

2023-11-20 Thread Daniel Latypov
On Wed, Nov 15, 2023 at 9:52 AM Nikolai Kondrashov wrote: > +kunit core > +-- > + > +:Summary: KUnit tests for the framework itself > +:Superset: kunit > +:Command: tools/testing/kunit/kunit.py run --kunitconfig lib/kunit Note: we'd want this to instead be ./tools/testing/kunit/run_chec

Re: [PATCH v2] list: test: potential dereference of null pointer

2023-09-22 Thread Daniel Latypov
On Fri, Sep 22, 2023 at 4:40 AM Ma Ke wrote: > > To avoid the failure of alloc, we could check the return value of > kmalloc() and kzalloc(). Thanks, that's a good point, some suggestions below. And also a question for David Gow whenever he sees this. > > Signed-off-by: Ma Ke > --- > lib/list-