Re: [PATCH] kselftest/arm64: Actually test SME vector length changes via sigreturn

2024-08-30 Thread Andre Przywara
P. Fixes: 4963aeb35a9e ("kselftest/arm64: signal: Add SME signal handling tests") Signed-off-by: Mark Brown Reviewed-by: Andre Przywara Tested-by: Andre Przywara Thanks, Andre. --- .../arm64/signal/testcases/fake_sigreturn_sme_change_vl.c | 14 +++--- 1 file changed, 7 insert

[PATCH v3] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-21 Thread Andre Przywara
stly copy&paste ones, let's consolidate the enumeration loop into one shared function, and just call that from each test. That should fix the above bugs, and prevent similar issues from happening again. Fixes: 4963aeb35a9e ("kselftest/arm64: signal: Add SME signal handling tests"

Re: [PATCH v2] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-21 Thread Andre Przywara
On Mon, 19 Aug 2024 13:57:21 +0100 Andre Przywara wrote: Hi, sorry, just realised I missed one include... > Currently a number of SVE/SME related tests have almost identical > functions to enumerate all supported vector lengths. However over time > the copy&pasted code has diver

[PATCH v2] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-19 Thread Andre Przywara
stly copy&paste ones, let's consolidate the enumeration loop into one shared function, and just call that from each test. That should fix the above bugs, and prevent similar issues from happening again. Fixes: 4963aeb35a9e ("kselftest/arm64: signal: Add SME signal handling tests"

Re: [PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers

2024-08-16 Thread Andre Przywara
On Fri, 16 Aug 2024 17:32:39 +0100 Mark Brown wrote: > On Fri, Aug 16, 2024 at 04:32:50PM +0100, Andre Przywara wrote: > > When printing the value of a pointer, we should not use an integer > > format specifier, but the dedicated "%p" instead. > > > > Fixes

Re: [PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask

2024-08-16 Thread Andre Przywara
On Fri, 16 Aug 2024 17:30:14 +0100 Mark Brown wrote: Hi Mark, thanks for having a look! > On Fri, Aug 16, 2024 at 04:32:48PM +0100, Andre Przywara wrote: > > When masking the return value of a prctl, which is clearly an "int", we > > use a uapi header provided mask,

[PATCH 3/8] kselftest/arm64: mte: use proper SKIP syntax

2024-08-16 Thread Andre Przywara
with tools expecting proper TAP syntax, as described in the TAP specification. Signed-off-by: Andre Przywara --- tools/testing/selftests/arm64/mte/mte_common_util.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/tools/testing/selftests/arm64/mte/mte_common_util.c b

[PATCH 4/8] kselftest/arm64: mte: use string literal for printf-style functions

2024-08-16 Thread Andre Przywara
ormat-security]" If we only want to print a constant string, we can just use a fixed "%s" format instead, and pass the string as an argument. Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory") Signed-off-by: Andre Przywara --- too

[PATCH 5/8] kselftest/arm64: mte: fix printf type warning about mask

2024-08-16 Thread Andre Przywara
the format string. While we could simply upgrade this to a "%lx", it sounds wrong to promote the "ret" variable, that is clearly an int. Downcast the mask instead, to keep the type correct. Fixes: e2d9642a5a51 ("kselftest/arm64: Add simple test for MTE prctl") Sign

[PATCH 2/8] kselftest/arm64: hwcap: fix f8dp2 cpuinfo name

2024-08-16 Thread Andre Przywara
The F8DP2 DPISA extension has a separate cpuinfo field, named accordingly. Change the erroneously placed name of "f8dp4" to "f8dp2". Fixes: 44d10c27bd75 ("kselftest/arm64: Add 2023 DPISA hwcap test coverage") Signed-off-by: Andre Przywara --- tools/testing/selftes

[PATCH 8/8] kselftest/arm64: mte: fix printf type warnings about longs

2024-08-16 Thread Andre Przywara
ixes: f3b2a26ca78d ("kselftest/arm64: Verify mte tag inclusion via prctl") Signed-off-by: Andre Przywara --- tools/testing/selftests/arm64/mte/check_tags_inclusion.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selftests/arm64/mte/check_tags_incl

[PATCH 7/8] kselftest/arm64: mte: fix printf type warnings about pointers

2024-08-16 Thread Andre Przywara
When printing the value of a pointer, we should not use an integer format specifier, but the dedicated "%p" instead. Fixes: e9b60476bea0 ("kselftest/arm64: Add utilities and a test to validate mte memory") Signed-off-by: Andre Przywara --- tools/testing/selftests/arm64/mte

[PATCH 0/8] kselftest/arm64: various compilation fixes

2024-08-16 Thread Andre Przywara
adjusts the output of the MTE tests when MTE is not available, so that tools parsing the TAP output don't get confused and report errors. The remaining patches are about wrong printf format specifiers. I grouped them by type of error, in patch 4-8. Please have a look! Cheers, Andre Andre Przywa

[PATCH 6/8] kselftest/arm64: mte: fix printf type warnings about __u64

2024-08-16 Thread Andre Przywara
it wouldn't match as well. Since we know the exact type of __u64, just use "%llx" here instead, to silence this warning. This also fixes a more severe typo: "$lx" is not a valid format specifier. Fixes: 191e678bdc9b ("kselftest/arm64: Log unexpected asynchronous MTE f

[PATCH 1/8] kselftest/arm64: signal: drop now redundant GNU_SOURCE definition

2024-08-16 Thread Andre Przywara
OURCE" redefined : note: this is the location of the previous definition Drop the definition in the arm64/signal Makefile. Fixes: cc937dad85ae ("selftests: centralize -D_GNU_SOURCE= to CFLAGS in lib.mk") Signed-off-by: Andre Przywara --- tools/testing/selftests/arm64/signal/Makefile |

Re: [PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-13 Thread Andre Przywara
On Tue, 13 Aug 2024 12:00:06 +0100 Mark Brown wrote: Hi broonie, > On Mon, Aug 12, 2024 at 03:09:24PM +0100, Andre Przywara wrote: > > > + /* Did we find the lowest supported VL? */ > > + if (use_sme && vq < sve_vq_from_vl(vl)) > > +

[PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-12 Thread Andre Przywara
stly copy&paste ones, let's consolidate the enumeration loop into one shared function, and just call that from each test. That should fix the above bugs, and prevent similar issues from happening again. Fixes: 4963aeb35a9e ("kselftest/arm64: signal: Add SME signal handling tests"