Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

2025-03-06 Thread Taehee Yoo
On Fri, Mar 7, 2025 at 10:35 AM Jakub Kicinski wrote: > Hi Jakub, Thanks a lot for the review! > On Thu, 6 Mar 2025 07:24:17 + Taehee Yoo wrote: > > + struct skb_shared_info sinfo = {0}; > > > + memcpy(&sinfo, xdp_get_shared_info_from_buff(&xdp), > > +siz

Re: [PATCH v2 net 1/6] eth: bnxt: fix truesize for mb-xdp-pass case

2025-03-06 Thread Jakub Kicinski
On Thu, 6 Mar 2025 07:24:17 + Taehee Yoo wrote: > + struct skb_shared_info sinfo = {0}; > + memcpy(&sinfo, xdp_get_shared_info_from_buff(&xdp), > +sizeof(struct skb_shared_info)); This may be a little expensive, struct skb_shared_info is 320B and we only r

Re: [PATCH net-next 1/2] selftests: net: fix error message in bpf_offload

2025-03-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Tue, 4 Mar 2025 15:32:03 -0800 you wrote: > We hit a following exception on timeout, nmaps is never set: > > Test bpftool bound info reporting (own ns)... > Traceback (most recent call last): > Fil

Re: [PATCH net-next v2 1/2] selftests: drv-net: add path helper for net/lib

2025-03-06 Thread Jakub Kicinski
On Thu, 6 Mar 2025 17:22:47 -0500 Willem de Bruijn wrote: > > +def lpath(self, path): > > +""" > > +Similar to rpath, but for files in net/lib TARGET. > > +""" > > +lib_dir = (Path(__file__).parent / "../../../../net/lib").resolve() > > +return (lib_dir /

Re: [PATCH net-next v2 1/2] selftests: drv-net: add path helper for net/lib

2025-03-06 Thread Willem de Bruijn
On Thu, Mar 6, 2025 at 12:12 PM Jakub Kicinski wrote: > > Looks like a lot of users of recently added env.rpath() actually > want to access stuff under net/lib. Add another helper. > > Signed-off-by: Jakub Kicinski Reviewed-by: Willem de Bruijn > diff --git a/tools/testing/selftests/drivers/ne

Re: [PATCH net-next v2 2/2] selftests: net: use the dummy bpf from net/lib

2025-03-06 Thread Willem de Bruijn
On Thu, Mar 6, 2025 at 3:56 PM Jakub Kicinski wrote: > > On Thu, 06 Mar 2025 14:35:09 -0500 Willem de Bruijn wrote: > > How does tools/testing/selftests/net/lib get compiled? > > The other subdirs of net are separate explicit targets in > > tools/testing/selftests/Makefile > > There is some magic

Re: [PATCH net-next v2 2/2] selftests: net: use the dummy bpf from net/lib

2025-03-06 Thread Jakub Kicinski
On Thu, 06 Mar 2025 14:35:09 -0500 Willem de Bruijn wrote: > How does tools/testing/selftests/net/lib get compiled? > The other subdirs of net are separate explicit targets in > tools/testing/selftests/Makefile There is some magic / hack at top level: # Networking tests want the net/lib target,

[PATCH net-next v2 2/2] selftests: net: use the dummy bpf from net/lib

2025-03-06 Thread Jakub Kicinski
Commit 29b036be1b0b ("selftests: drv-net: test XDP, HDS auto and the ioctl path") added an sample XDP_PASS prog in net/lib, so that we can reuse it in various sub-directories. Delete the old sample and use the one from the lib in existing tests. Acked-by: Stanislav Fomichev Signed-off-by: Jakub K

Re: [brauner-github:vfs.all 205/231] WARNING: modpost: vmlinux: section mismatch in reference: initramfs_test_cases+0x0 (section: .data) -> initramfs_test_extract (section: .init.text)

2025-03-06 Thread David Gow
On Wed, 5 Mar 2025 at 20:56, David Disseldorp wrote: > > On Wed, 5 Mar 2025 11:47:01 +1100, David Disseldorp wrote: > > > [cc'ing linux-kselftest and kunit-dev] > > > > Hi, > > > > On Wed, 5 Mar 2025 01:47:55 +0800, kernel test robot wrote: > > > > > tree: https://github.com/brauner/linux.git vf

Re: [PATCH v2 net 3/6] eth: bnxt: do not use BNXT_VNIC_NTUPLE unconditionally in queue restart logic

2025-03-06 Thread Somnath Kotur
On Thu, Mar 6, 2025 at 12:54 PM Taehee Yoo wrote: > > When a queue is restarted, it sets MRU to 0 for stopping packet flow. > MRU variable is a member of vnic_info[], the first vnic_info is default > and the second is ntuple. > Only when ntuple is enabled(ethtool -K eth0 ntuple on), vnic_info for