Re: [RFC v2] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-11-22 Thread Jakub Kicinski
On Fri, 22 Nov 2024 07:56:25 -0700 Shuah wrote: > > To me the dissonance between your admission that people don't CC the > > current list (IOW status quo isn't great) and the resistance to change > > is fairly apparent. But it is obviously your call. > My thinking is that people don't seem to CC

Re: [PATCH bpf 1/4] bpf, vsock: Fix poll() missing a queue

2024-11-22 Thread Luigi Leonardi
>When a verdict program simply passes a packet without redirection, sk_msg >is enqueued on sk_psock::ingress_msg. Add a missing check to poll(). > >Fixes: 634f1a7110b4 ("vsock: support sockmap") >Signed-off-by: Michal Luczaj >--- > net/vmw_vsock/af_vsock.c | 3 +++ > 1 file changed, 3 insertions(+)

Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

2024-11-22 Thread Luigi Leonardi
I spent some time checking and nobody but __sock_create (net/socket.c) and vsock_release can set sock->sk to NULL. I also ran checkpatch, everything LGTM. Thanks for the fix! Reviewed-by: Luigi Leonardi

Re: [RFC v2] MAINTAINERS: split kselftest entry into 'framework' and 'all'

2024-11-22 Thread Shuah
On 11/18/24 14:23, Jakub Kicinski wrote: On Mon, 18 Nov 2024 14:02:29 -0700 Shuah Khan wrote: Sorry for the delay, the responses to v1 weren't super positive but I keep thinking this would be very useful :) Or at the very least I find workflows@ very useful and informative as a maintainer. Post

Re: [PATCH bpf 3/4] bpf, vsock: Invoke proto::close on close()

2024-11-22 Thread Stefano Garzarella
On Thu, Nov 21, 2024 at 8:54 PM Michal Luczaj wrote: > > On 11/21/24 10:22, Stefano Garzarella wrote: > > On Mon, Nov 18, 2024 at 10:03:43PM +0100, Michal Luczaj wrote: > >> vsock defines a BPF callback to be invoked when close() is called. However, > >> this callback is never actually executed. A

Re: [PATCH bpf 0/4] bpf, vsock: Fix poll() and close()

2024-11-22 Thread Stefano Garzarella
On Fri, Nov 22, 2024 at 12:34 AM John Fastabend wrote: > > Stefano Garzarella wrote: > > On Wed, Nov 20, 2024 at 10:48:25PM -0800, John Fastabend wrote: > > >Michal Luczaj wrote: > > >> Two small fixes for vsock: poll() missing a queue check, and close() not > > >> invoking sockmap cleanup. > > >>