Re: [PATCH] selftests/bpf: Add valid flag to bpf_cookie selftest's res

2024-09-05 Thread Yuan Chen
What you said is reasonable,but it would confuse the test personnel, as there is no clear reminders. Is it possible to modify it to without SKIP,will give exact reminders when it is failed?

Re: [PATCH v3 1/7] iommu: Introduce a replace API for device pasid

2024-09-05 Thread Yi Liu
On 2024/9/6 12:33, Baolu Lu wrote: On 9/6/24 12:21 PM, Yi Liu wrote: On 2024/8/16 21:02, Jason Gunthorpe wrote: On Fri, Aug 16, 2024 at 05:43:18PM +0800, Yi Liu wrote: On 2024/7/18 16:27, Tian, Kevin wrote: From: Liu, Yi L Sent: Friday, June 28, 2024 5:06 PM @@ -3289,7 +3290,20 @@ static in

Re: [PATCH v3 1/7] iommu: Introduce a replace API for device pasid

2024-09-05 Thread Baolu Lu
On 9/6/24 12:21 PM, Yi Liu wrote: On 2024/8/16 21:02, Jason Gunthorpe wrote: On Fri, Aug 16, 2024 at 05:43:18PM +0800, Yi Liu wrote: On 2024/7/18 16:27, Tian, Kevin wrote: From: Liu, Yi L Sent: Friday, June 28, 2024 5:06 PM @@ -3289,7 +3290,20 @@ static int __iommu_set_group_pasid(struct iom

Re: [PATCH v3 1/7] iommu: Introduce a replace API for device pasid

2024-09-05 Thread Yi Liu
On 2024/8/16 21:02, Jason Gunthorpe wrote: On Fri, Aug 16, 2024 at 05:43:18PM +0800, Yi Liu wrote: On 2024/7/18 16:27, Tian, Kevin wrote: From: Liu, Yi L Sent: Friday, June 28, 2024 5:06 PM @@ -3289,7 +3290,20 @@ static int __iommu_set_group_pasid(struct iommu_domain *domain,

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Willem de Bruijn
Jakub Kicinski wrote: > On Thu, 05 Sep 2024 21:31:55 -0400 Willem de Bruijn wrote: > > > Packetdrill scripts are sensitive to timing. > > > On the dbg build, I just observe a flaky test. > > > > > > The tool takes --tolerance_usecs and --tolerance_percent arguments. > > > I may have to update ksft

Re: [PATCH v3] lib/math: Add int_pow test suite

2024-09-05 Thread Felipe Hernandez
On Mon, Aug 19, 2024 at 09:03:52PM -0400, Luis Felipe Hernandez wrote: > Adds test suite for integer based power function. > > Signed-off-by: Luis Felipe Hernandez > --- > Changes in v3: > - Fix compiler warning: explicitly define constant as unsigned int > - Add changes in patch revisions > Chang

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Jakub Kicinski
On Thu, 05 Sep 2024 21:31:55 -0400 Willem de Bruijn wrote: > > Packetdrill scripts are sensitive to timing. > > On the dbg build, I just observe a flaky test. > > > > The tool takes --tolerance_usecs and --tolerance_percent arguments. > > I may have to update ksft_runner.sh to increase one if a db

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Willem de Bruijn
Willem de Bruijn wrote: > Willem de Bruijn wrote: > > Jakub Kicinski wrote: > > > On Wed, 4 Sep 2024 23:07:03 -0400 Willem de Bruijn wrote: > > > > +++ b/tools/testing/selftests/net/packetdrill/config > > > > @@ -0,0 +1 @@ > > > > +CONFIG_TCP_MD5SIG=y > > > > > > Looks like this is not enough: >

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Willem de Bruijn
Willem de Bruijn wrote: > Jakub Kicinski wrote: > > On Wed, 4 Sep 2024 23:07:03 -0400 Willem de Bruijn wrote: > > > +++ b/tools/testing/selftests/net/packetdrill/config > > > @@ -0,0 +1 @@ > > > +CONFIG_TCP_MD5SIG=y > > > > Looks like this is not enough: > > > > # 1..2 > > # open tun device: No

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Willem de Bruijn
Jakub Kicinski wrote: > On Wed, 4 Sep 2024 23:07:03 -0400 Willem de Bruijn wrote: > > +++ b/tools/testing/selftests/net/packetdrill/config > > @@ -0,0 +1 @@ > > +CONFIG_TCP_MD5SIG=y > > Looks like this is not enough: > > # 1..2 > # open tun device: No such file or directory > # not ok 1 ipv4 > #

[PATCH net-next v2 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Willem de Bruijn
From: Willem de Bruijn Lay the groundwork to import into kselftests the over 150 packetdrill TCP/IP conformance tests on github.com/google/packetdrill. Florian recently added support for packetdrill tests in nf_conntrack, in commit a8a388c2aae49 ("selftests: netfilter: add packetdrill based conn

[PATCH net-next v2 1/2] selftests: support interpreted scripts with ksft_runner.sh

2024-09-05 Thread Willem de Bruijn
From: Willem de Bruijn Support testcases that are themselves not executable, but need an interpreter to run them. If a test file is not executable, but an executable file ksft_runner.sh exists in the TARGET dir, kselftest will run ./ksft_runner.sh ./$BASENAME_TEST Packetdrill may add hundr

[PATCH net-next v2 0/2] selftests/net: add packetdrill

2024-09-05 Thread Willem de Bruijn
From: Willem de Bruijn Lay the groundwork to import into kselftests the over 150 packetdrill TCP/IP conformance tests on github.com/google/packetdrill. 1/2: add kselftest infra for TEST_PROGS that need an interpreter 2/2: add the specific packetdrill tests Both can go through net-next, I imagi

Re: [PATCH net-next 2/2] selftests/net: integrate packetdrill with ksft

2024-09-05 Thread Jakub Kicinski
On Wed, 4 Sep 2024 23:07:03 -0400 Willem de Bruijn wrote: > +++ b/tools/testing/selftests/net/packetdrill/config > @@ -0,0 +1 @@ > +CONFIG_TCP_MD5SIG=y Looks like this is not enough: # 1..2 # open tun device: No such file or directory # not ok 1 ipv4 # open tun device: No such file or directory

Re: [PATCH] selftests/bpf: Add valid flag to bpf_cookie selftest's res

2024-09-05 Thread Andrii Nakryiko
On Wed, Sep 4, 2024 at 9:10 PM Yuan Chen wrote: > > From: Yuan Chen > > This patch identifies whether a test item is valid by adding a valid flag to > res. > > When we test the bpf_cookies/perf_event sub-test item of test_progs, there is > a > probability failure of the test item. In fact, this

[PATCH v2 net-next] wireguard: allowedips: Add WGALLOWEDIP_F_REMOVE_ME flag

2024-09-05 Thread Jordan Rife
With the current API the only way to remove an allowed IP is to completely rebuild the allowed IPs set for a peer using WGPEER_F_REPLACE_ALLOWEDIPS. In other words, if my current configuration is such that a peer has allowed IP IPs 192.168.0.2 and 192.168.0.3 and I want to remove 192.168.0.2 the ac

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Jason Xing
On Fri, Sep 6, 2024 at 12:41 AM Willem de Bruijn wrote: > > Jason Xing wrote: > > On Thu, Sep 5, 2024 at 10:46 PM Willem de Bruijn > > wrote: > > > > > > Jason Xing wrote: > > > > On Thu, Sep 5, 2024 at 9:45 PM Willem de Bruijn > > > > wrote: > > > > > > > > > > Jason Xing wrote: > > > > > > Fro

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > On Thu, Sep 5, 2024 at 10:46 PM Willem de Bruijn > wrote: > > > > Jason Xing wrote: > > > On Thu, Sep 5, 2024 at 9:45 PM Willem de Bruijn > > > wrote: > > > > > > > > Jason Xing wrote: > > > > > From: Jason Xing > > > > > > > > > > In the previous patch, we found things could

[PATCH net-next v2] selftests: return failure when timestamps can't be reported

2024-09-05 Thread Jason Xing
From: Jason Xing When I was trying to modify the tx timestamping feature, I found that running "./txtimestamp -4 -C -L 127.0.0.1" didn't reflect the error: I succeeded to generate timestamp stored in the skb but later failed to report it to the userspace (which means failed to put css into cmsg).

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 10:46 PM Willem de Bruijn wrote: > > Jason Xing wrote: > > On Thu, Sep 5, 2024 at 9:45 PM Willem de Bruijn > > wrote: > > > > > > Jason Xing wrote: > > > > From: Jason Xing > > > > > > > > In the previous patch, we found things could happen in the rx software > > > > times

Re: [PATCH net-next v4 2/4] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 10:45 PM Willem de Bruijn wrote: > > Jason Xing wrote: > > On Thu, Sep 5, 2024 at 9:38 PM Willem de Bruijn > > wrote: > > > > > > Jason Xing wrote: > > > > From: Jason Xing > > > > > > > > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the > > > > timestamps g

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > On Thu, Sep 5, 2024 at 9:45 PM Willem de Bruijn > wrote: > > > > Jason Xing wrote: > > > From: Jason Xing > > > > > > In the previous patch, we found things could happen in the rx software > > > timestamp. Here, we also noticed that, for rx hardware timestamp case, > > > it co

Re: [PATCH net-next v4 2/4] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > On Thu, Sep 5, 2024 at 9:38 PM Willem de Bruijn > wrote: > > > > Jason Xing wrote: > > > From: Jason Xing > > > > > > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the > > > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or > > > SOF_TIMESTAMPING_RX_

Re: [PATCH net-next v4 2/4] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 9:38 PM Willem de Bruijn wrote: > > Jason Xing wrote: > > From: Jason Xing > > > > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the > > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or > > SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the ti

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 9:45 PM Willem de Bruijn wrote: > > Jason Xing wrote: > > From: Jason Xing > > > > In the previous patch, we found things could happen in the rx software > > timestamp. Here, we also noticed that, for rx hardware timestamp case, > > it could happen when one process enables

Re: [PATCH net-next v4 1/4] net-timestamp: filter out report when setting SOF_TIMESTAMPING_SOFTWARE

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 9:37 PM Willem de Bruijn wrote: > > Jason Xing wrote: > > From: Jason Xing > > > > introduce a new flag SOF_TIMESTAMPING_OPT_RX_FILTER in the receive > > path. User can set it with SOF_TIMESTAMPING_SOFTWARE to filter > > out rx software timestamp report, especially after a

Re: [PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > From: Jason Xing > > In the previous patch, we found things could happen in the rx software > timestamp. Here, we also noticed that, for rx hardware timestamp case, > it could happen when one process enables the rx hardware timestamp > generating flag first, then another proce

Re: [PATCH net-next] selftests: return failure when timestamps can't be parsed

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 7:04 PM Jason Xing wrote: > > On Thu, Sep 5, 2024 at 5:16 AM Willem de Bruijn > wrote: > > > > Jason Xing wrote: > > > From: Jason Xing > > > > > > When I was trying to modify the tx timestamping feature, I found that > > > running "./txtimestamp -4 -C -L 127.0.0.1" didn't

Re: [PATCH net-next v4 2/4] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > From: Jason Xing > > SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the > timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or > SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time. > > So let us revise the doc here. > > Suggested-by: Willem de

Re: [PATCH net-next v4 1/4] net-timestamp: filter out report when setting SOF_TIMESTAMPING_SOFTWARE

2024-09-05 Thread Willem de Bruijn
Jason Xing wrote: > From: Jason Xing > > introduce a new flag SOF_TIMESTAMPING_OPT_RX_FILTER in the receive > path. User can set it with SOF_TIMESTAMPING_SOFTWARE to filter > out rx software timestamp report, especially after a process turns on > netstamp_needed_key which can time stamp every inc

Re: [PATCH net-next] selftests: return failure when timestamps can't be parsed

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 5:16 AM Willem de Bruijn wrote: > > Jason Xing wrote: > > From: Jason Xing > > > > When I was trying to modify the tx timestamping feature, I found that > > running "./txtimestamp -4 -C -L 127.0.0.1" didn't reflect the fact > > properly. > > Did not reflect what fact? Sorry

Re: [PATCH v5 06/30] arm64: context switch POR_EL0 register

2024-09-05 Thread Joey Gouly
On Wed, Sep 04, 2024 at 05:17:58PM +0100, Will Deacon wrote: > On Wed, Sep 04, 2024 at 01:55:03PM +0100, Joey Gouly wrote: > > On Wed, Sep 04, 2024 at 12:43:02PM +0100, Will Deacon wrote: > > > Right, there's quite a lot I need to do: > > > > > > - Uncorrupt your patches > > > - Fix the conflict i

Re: [PATCH net-next v4 4/4] rxtimestamp.c: add the test for SOF_TIMESTAMPING_OPT_RX_FILTER

2024-09-05 Thread Jason Xing
On Thu, Sep 5, 2024 at 3:18 PM Jason Xing wrote: > > From: Jason Xing > > Test when we use SOF_TIMESTAMPING_OPT_RX_FILTER with software > or hardware report flag. The expected result is no rx timestamp > report. > > Reviewed-by: Willem de Bruijn > Signed-off-by: Jason Xing > --- > tools/testin

[PATCH net-next v4 4/4] rxtimestamp.c: add the test for SOF_TIMESTAMPING_OPT_RX_FILTER

2024-09-05 Thread Jason Xing
From: Jason Xing Test when we use SOF_TIMESTAMPING_OPT_RX_FILTER with software or hardware report flag. The expected result is no rx timestamp report. Reviewed-by: Willem de Bruijn Signed-off-by: Jason Xing --- tools/testing/selftests/net/rxtimestamp.c | 11 +++ 1 file changed, 11 ins

[PATCH net-next v4 3/4] net-timestamp: extend SOF_TIMESTAMPING_OPT_RX_FILTER for hardware use

2024-09-05 Thread Jason Xing
From: Jason Xing In the previous patch, we found things could happen in the rx software timestamp. Here, we also noticed that, for rx hardware timestamp case, it could happen when one process enables the rx hardware timestamp generating flag first, then another process only setting SOF_TIMESTAMPI

[PATCH net-next v4 2/4] net-timestamp: correct the use of SOF_TIMESTAMPING_RAW_HARDWARE

2024-09-05 Thread Jason Xing
From: Jason Xing SOF_TIMESTAMPING_RAW_HARDWARE is a report flag which passes the timestamps generated by either SOF_TIMESTAMPING_TX_HARDWARE or SOF_TIMESTAMPING_RX_HARDWARE to the userspace all the time. So let us revise the doc here. Suggested-by: Willem de Bruijn Signed-off-by: Jason Xing -

[PATCH net-next v4 1/4] net-timestamp: filter out report when setting SOF_TIMESTAMPING_SOFTWARE

2024-09-05 Thread Jason Xing
From: Jason Xing introduce a new flag SOF_TIMESTAMPING_OPT_RX_FILTER in the receive path. User can set it with SOF_TIMESTAMPING_SOFTWARE to filter out rx software timestamp report, especially after a process turns on netstamp_needed_key which can time stamp every incoming skb. Previously, we fou

[PATCH net-next v4 0/4] net-timestamp: introduce a flag to filter out rx software and hardware report

2024-09-05 Thread Jason Xing
From: Jason Xing When one socket is set SOF_TIMESTAMPING_RX_SOFTWARE which means the whole system turns on the netstamp_needed_key button, other sockets that only have SOF_TIMESTAMPING_SOFTWARE will be affected and then print the rx timestamp information even without setting SOF_TIMESTAMPING_RX_S