Re: [PATCH] Kselftest: msg_oob.c: Fix warning for Incorrect Specifier

2024-08-12 Thread Kuniyuki Iwashima
From: David Hunter Date: Tue, 13 Aug 2024 01:59:57 -0400 > Change specifier to %p to correctly substitute type 'const void *'. A > specifer involved with a macro is causing a misleading warning to occur: You may want to run the test before/after the patch. This is the 3rd patch posted for this w

Re: [PATCH v4 3/4] ALSA: timer: Introduce virtual userspace-driven timers

2024-08-12 Thread Takashi Iwai
On Sun, 11 Aug 2024 22:23:36 +0200, Ivan Orlov wrote: > +static int snd_utimer_ioctl_create(struct file *file, > +struct snd_timer_uinfo __user *_utimer_info) > +{ > + struct snd_utimer *utimer; > + struct snd_timer_uinfo *utimer_info __free(kfree) = NULL; >

[PATCH] Kselftest: msg_oob.c: Fix warning for Incorrect Specifier

2024-08-12 Thread David Hunter
Change specifier to %p to correctly substitute type 'const void *'. A specifer involved with a macro is causing a misleading warning to occur: In file included from msg_oob.c:14: msg_oob.c: In function ???__recvpair???: ../../kselftest_harness.h:106:40: warning: format ???%s??? expects ar

Re: [PATCH 1/2] mm: Retry migration earlier upon refcount mismatch

2024-08-12 Thread Dev Jain
On 8/12/24 17:38, Dev Jain wrote: On 8/12/24 13:01, Huang, Ying wrote: Dev Jain writes: On 8/12/24 11:45, Huang, Ying wrote: Dev Jain writes: On 8/12/24 11:04, Huang, Ying wrote: Hi, Dev, Dev Jain writes: As already being done in __migrate_folio(), wherein we backoff if the folio

[PATCH v2] selftests/ftrace: Skip test for optimized probes on PowerPC if Secure Boot is enabled

2024-08-12 Thread Akanksha J N
Currently while accessing debugfs with Secure Boot enabled on PowerPC, it is causing the kprobe_opt_types.tc test to fail. Below is the snippet of the error: +++ grep kernel_clone /sys/kernel/debug/kprobes/list grep: /sys/kernel/debug/kprobes/list: Operation not permitted ++ PROBE= + '[' 2 -ne 0 '

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/13/24 00:57, Jakub Kicinski wrote: On Mon, 12 Aug 2024 20:10:39 +0100 Pavel Begunkov wrote: 1. Drivers need to be able to say "I support unreadable netmem". Failure to report unreadable netmem support should cause the netlink API to fail when the user tries to bind dmabuf/io uring memory.

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/13/24 01:15, Jakub Kicinski wrote: On Mon, 12 Aug 2024 20:04:41 +0100 Pavel Begunkov wrote: Also don't see the upside of the explicit "non-capable" flag, but I haven't thought of that. Is there any use? Or maybe I don't get what you're asking, I explained why to have that "PP_IGNORE_PROVI

Re: [PATCH v9 00/13] riscv: Add support for xtheadvector

2024-08-12 Thread Charlie Jenkins
On Fri, Aug 09, 2024 at 11:31:15PM +0100, Conor Dooley wrote: > On Tue, Aug 06, 2024 at 05:31:36PM -0700, Charlie Jenkins wrote: > > xtheadvector is a custom extension that is based upon riscv vector > > version 0.7.1 [1]. All of the vector routines have been modified to > > support this alternativ

Re: [PATCH] lib: Move KUnit tests into tests/ subdirectory

2024-08-12 Thread Steven Rostedt
On Sat, 20 Jul 2024 11:10:30 -0700 Kees Cook wrote: > Following from the recent KUnit file naming discussion[1], move all > KUnit tests in lib/ into lib/tests/. > > Link: https://lore.kernel.org/lkml/20240720165441.it.320-k...@kernel.org/ [1] > Signed-off-by: Kees Cook > --- Strong-Acked-by: S

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2024 20:04:41 +0100 Pavel Begunkov wrote: > >> Also don't see the upside of the explicit "non-capable" flag, > >> but I haven't thought of that. Is there any use? > > Or maybe I don't get what you're asking, I explained > why to have that "PP_IGNORE_PROVIDERS" on top of the flag >

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-12 Thread Reinette Chatre
Hi Shuah, On 8/12/24 3:49 PM, Shuah Khan wrote: On 8/9/24 02:45, Ilpo Järvinen wrote: Adding Maciej. On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: On 8/9/24 12:23 PM, Ilpo Järvinen wrote: On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: This test doesn't have support for other architectur

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Mon, 12 Aug 2024 20:10:39 +0100 Pavel Begunkov wrote: > > 1. Drivers need to be able to say "I support unreadable netmem". > > Failure to report unreadable netmem support should cause the netlink > > API to fail when the user tries to bind dmabuf/io uring memory. > > > > 2. Drivers need to be a

Re: [PATCH v4 2/2] selftests/resctrl: Adjust SNC support messages

2024-08-12 Thread Reinette Chatre
Hi Maciej, On 7/12/24 2:04 AM, Maciej Wieczor-Retman wrote: Resctrl selftest prints a message on test failure that Sub-Numa Clustering (SNC) could be enabled and points the user to check their BIOS settings. No actual check is performed before printing that message so it is not very accurate in

Re: [PATCH v4 1/2] selftests/resctrl: Adjust effective L3 cache size with SNC enabled

2024-08-12 Thread Reinette Chatre
Hi Maciej, On 7/12/24 2:04 AM, Maciej Wieczor-Retman wrote: Sub-NUMA Cluster divides CPUs sharing an L3 cache into separate NUMA nodes. Systems may support splitting into either two, three or four nodes. When SNC mode is enabled the effective amount of L3 cache available for allocation is divid

Re: [PATCH v2] selftests: fix relative rpath usage

2024-08-12 Thread Shuah Khan
On 8/12/24 10:56, Eugene Syromiatnikov wrote: The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the executable directory, which will lead in incorrect resolution when the test executables are run from elsewhere. Changing it t

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-12 Thread Shuah Khan
On 8/9/24 02:45, Ilpo Järvinen wrote: Adding Maciej. On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: On 8/9/24 12:23 PM, Ilpo Järvinen wrote: On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: This test doesn't have support for other architectures. Altough resctrl is supported on x86 and ARM, b

Re: [bpf-next 0/3] samples/bpf: Remove obsolete tracing-related tests

2024-08-12 Thread Andrii Nakryiko
On Sun, Aug 11, 2024 at 5:45 PM Daniel T. Lee wrote: > > The BPF tracing infrastructure has undergone significant evolution, > leading to the introduction of more robust and efficient APIs. > However, some of the existing tests in the samples/bpf directory have > not kept pace with these developme

Re: [PATCH] selftests: resctrl: ignore builds for unsupported architectures

2024-08-12 Thread Reinette Chatre
On 8/9/24 1:45 AM, Ilpo Järvinen wrote: Adding Maciej. On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: On 8/9/24 12:23 PM, Ilpo Järvinen wrote: On Fri, 9 Aug 2024, Muhammad Usama Anjum wrote: This test doesn't have support for other architectures. Altough resctrl is supported on x86 and A

Re: [PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

2024-08-12 Thread Kuniyuki Iwashima
From: Abhinav Jain Date: Tue, 13 Aug 2024 00:41:22 +0530 > Change the parameter expected_buf from (const void *) to (const char *) > in the function __recvpair() as per the feedback in v1. > Add Fixes tag as per feedback in v1. > > This change fixes the below warnings during test compilation: >

Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

2024-08-12 Thread Abhinav Jain
On Mon, 12 Aug 2024 11:39:44 -0700, Kuniyuki Iwashima wrote: > Fixes: tag is needed here (no space between SOB tag) Thank you, I have added it in v2 here: > I don't remember why I defined expected_buf as (void *), but more simple > fix would be the following ? > > ---8<--- > diff --git a/tools/

[PATCH net v2] selftest: af_unix: Fix kselftest compilation warnings

2024-08-12 Thread Abhinav Jain
Change the parameter expected_buf from (const void *) to (const char *) in the function __recvpair() as per the feedback in v1. Add Fixes tag as per feedback in v1. This change fixes the below warnings during test compilation: ``` In file included from msg_oob.c:14: msg_oob.c: In function ‘__recv

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 19:55, Mina Almasry wrote: On Mon, Aug 12, 2024 at 1:57 PM Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" direc

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 19:57, Pavel Begunkov wrote: On 8/12/24 18:57, Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" directly to core (v

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Pavel Begunkov
On 8/12/24 18:57, Jakub Kicinski wrote: On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: I think we're talking about 2 slightly different flags, AFAIU.> Pavel and I are suggesting the driver reports "I support memory providers" directly to core (via the queue-api or what not), and we che

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Mina Almasry
On Mon, Aug 12, 2024 at 1:57 PM Jakub Kicinski wrote: > > On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: > > > I think we're talking about 2 slightly different flags, AFAIU.> > > > Pavel and I are suggesting the driver reports "I support memory > > > providers" directly to core (via the

Re: [PATCH v1 1/1] selftests: net: af_unix: cast void* to char* in call to macro TH_LOG()

2024-08-12 Thread Kuniyuki Iwashima
From: Mirsad Todorovac Date: Mon, 12 Aug 2024 02:22:58 +0200 > GCC 13.2.0 reported warning about (void *) beeing used as a param where (char > *) is expected: > > In file included from msg_oob.c:14: > msg_oob.c: In function ‘__recvpair’: > ../../kselftest_harness.h:106:40: warning: format ‘%s’ e

Re: [PATCH net] selftest: af_unix: Fix kselftest compilation warnings

2024-08-12 Thread Kuniyuki Iwashima
From: Abhinav Jain Date: Sat, 10 Aug 2024 19:10:37 +0530 > Add proper type cast (char *) to the buffer being passed to TH_LOG > macro in __recvpair function. > > This change fixes the below warnings during test compilation: > > ``` > In file included from msg_oob.c:14: > msg_oob.c: In function ‘

Re: [PATCH net-next v18 07/14] memory-provider: dmabuf devmem memory provider

2024-08-12 Thread Jakub Kicinski
On Sun, 11 Aug 2024 22:51:13 +0100 Pavel Begunkov wrote: > > I think we're talking about 2 slightly different flags, AFAIU.> > > Pavel and I are suggesting the driver reports "I support memory > > providers" directly to core (via the queue-api or what not), and we > > check that flag directly in ne

Re: [PATCH v5 00/28] NT synchronization primitive driver

2024-08-12 Thread Elizabeth Figura
On Monday, 10 June 2024 11:58:48 CDT Elizabeth Figura wrote: > On Sunday, May 19, 2024 3:24:26 PM CDT Elizabeth Figura wrote: > > This patch series implements a new char misc driver, /dev/ntsync, which is > > used to implement Windows NT synchronization primitives. > > > > NT synchronization primi

[PATCH v2] selftests: fix relative rpath usage

2024-08-12 Thread Eugene Syromiatnikov
The relative RPATH ("./") supplied to linker options in CFLAGS is resolved relative to current working directory and not the executable directory, which will lead in incorrect resolution when the test executables are run from elsewhere. Changing it to $ORIGIN makes it resolve relative to the direc

Re: [PATCH v1 1/1] selftests: net: af_unix: cast void* to char* in call to macro TH_LOG()

2024-08-12 Thread Simon Horman
On Mon, Aug 12, 2024 at 02:22:58AM +0200, Mirsad Todorovac wrote: > GCC 13.2.0 reported warning about (void *) beeing used as a param where (char > *) is expected: nit: being > > In file included from msg_oob.c:14: > msg_oob.c: In function ‘__recvpair’: > ../../kselftest_harness.h:106:40: warni

[PATCH] kselftest/arm64: signal: fix/refactor SVE vector length enumeration

2024-08-12 Thread Andre Przywara
Currently a number of SVE/SME related tests have almost identical functions to enumerate all supported vector lengths. However over time the copy&pasted code has diverged, allowing some bugs to creep in: - fake_sigreturn_sme_change_vl reports a failure, not a SKIP if only one vector length is sup

Re: [PATCH 1/2] mm: Retry migration earlier upon refcount mismatch

2024-08-12 Thread Dev Jain
On 8/12/24 13:01, Huang, Ying wrote: Dev Jain writes: On 8/12/24 11:45, Huang, Ying wrote: Dev Jain writes: On 8/12/24 11:04, Huang, Ying wrote: Hi, Dev, Dev Jain writes: As already being done in __migrate_folio(), wherein we backoff if the folio refcount is wrong, make this check d

Re: [bpf-next 2/3] selftests/bpf: add rename tracepoint bench test

2024-08-12 Thread Jiri Olsa
On Mon, Aug 12, 2024 at 12:45:02AM +, Daniel T. Lee wrote: > In addition to migrating the tracepoint overhead test from sample/bpf > to selftest/bpf, this commit extends benchmarking test with rename > task. > > Since previous commit migrated tracepoint based on rename task, this > commit upda

Re: [bpf-next 1/3] selftests/bpf: migrate tracepoint overhead test to prog_tests

2024-08-12 Thread Jiri Olsa
On Mon, Aug 12, 2024 at 12:45:01AM +, Daniel T. Lee wrote: > As part of the cleanup of outdated test cases in sample/bpf, this > commit migrates test for tracepoint overhead to selftest prog_tests. > > The test_overhead in selftest/bpf focus on the 'raw_tracepoint' only, > and do not cover tra

Re: [PATCH net-next v2] selftests: net: py: support verbose printing, display executed commands

2024-08-12 Thread Petr Machata
Jakub Kicinski writes: > On Fri, 9 Aug 2024 14:36:17 +0200 Petr Machata wrote: >> > +env_level = env.get('VERBOSE') >> > +set_verbosity(env_level) >> > + >> >> Actually, the ksft_setup() here was merged last week, and I think that >> would be a better place to put this stuff. It alre

Re: [PATCH bpf-next v3 0/4] selftests/bpf: convert three other cgroup tests to test_progs

2024-08-12 Thread Alexis Lothoré
On 8/12/24 10:58, Alexis Lothoré (eBPF Foundation) wrote: > Hello, > this series brings a new set of test converted to the test_progs framework. > Since the tests are quite small, I chose to group three tests conversion in > the same series, but feel free to let me know if I should keep one series

[PATCH v2] selftest/powerpc/benchmark: remove requirement libc-dev

2024-08-12 Thread Madhavan Srinivasan
Currently exec-target.c file is linked as static and this post a requirement to install libc dev package to build. Without it, build-break when compiling selftest/powerpc/benchmark. CC exec_target /usr/bin/ld: cannot find -lc: No such file or directory collect2: error: ld returned 1 exit s

Re: [PATCH] kselftest/cgroup: Add missing newline in test_zswap.c

2024-08-12 Thread Shuah Khan
On 8/11/24 08:58, Mohammed Anees wrote: Missing change log Signed-off-by: Mohammed Anees --- tools/testing/selftests/cgroup/test_zswap.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/testing/selftests/cgroup/test_zswap.c b/tools/testing/selftests/cgroup/test_zsw

Re: [PATCH 1/2] mm: Retry migration earlier upon refcount mismatch

2024-08-12 Thread David Hildenbrand
On 12.08.24 07:35, Dev Jain wrote: On 8/11/24 14:38, David Hildenbrand wrote: On 11.08.24 08:06, Dev Jain wrote: On 8/11/24 00:22, David Hildenbrand wrote: On 10.08.24 20:42, Dev Jain wrote: On 8/9/24 19:17, David Hildenbrand wrote: On 09.08.24 12:31, Dev Jain wrote: As already being don

[PATCH bpf-next v3 4/4] selftests/bpf: convert test_skb_cgroup_id_user to test_progs

2024-08-12 Thread eBPF Foundation
test_skb_cgroup_id_user allows testing skb cgroup id retrieval at different levels, but is not integrated in test_progs, so it is not run automatically in CI. The test overlaps a bit with cgroup_skb_sk_lookup_kern, which is integrated in test_progs and test extensively skb cgroup helpers, but there

[PATCH bpf-next v3 3/4] selftests/bpf: add proper section name to bpf prog and rename it

2024-08-12 Thread eBPF Foundation
test_skb_cgroup_id_kern.c is currently involved in a manual test. In its current form, it can not be used with the auto-generated skeleton APIs, because the section name is not valid to allow libbpf to deduce the program type. Update section name to allow skeleton APIs usage. Also rename the progr

[PATCH bpf-next v3 2/4] selftests/bpf: convert test_cgroup_storage to test_progs

2024-08-12 Thread eBPF Foundation
test_cgroup_storage is currently a standalone program which is not run when executing test_progs. Convert it to the test_progs framework so it can be automatically executed in CI. The conversion led to the following changes: - converted the raw bpf program in the userspace test file into a dedicat

[PATCH bpf-next v3 1/4] selftests/bpf: convert get_current_cgroup_id_user to test_progs

2024-08-12 Thread eBPF Foundation
get_current_cgroup_id_user allows testing for bpf_get_current_cgroup_id() bpf API but is not integrated into test_progs, and so is not tested automatically in CI. Convert it to the test_progs framework to allow running it automatically. The most notable differences with the old test are the follow

[PATCH bpf-next v3 0/4] selftests/bpf: convert three other cgroup tests to test_progs

2024-08-12 Thread eBPF Foundation
Hello, this series brings a new set of test converted to the test_progs framework. Since the tests are quite small, I chose to group three tests conversion in the same series, but feel free to let me know if I should keep one series per test. The series focuses on cgroup testing and converts the fo

Re: [PATCH 1/2] mm: Retry migration earlier upon refcount mismatch

2024-08-12 Thread Huang, Ying
Dev Jain writes: > On 8/12/24 11:45, Huang, Ying wrote: >> Dev Jain writes: >> >>> On 8/12/24 11:04, Huang, Ying wrote: Hi, Dev, Dev Jain writes: > As already being done in __migrate_folio(), wherein we backoff if the > folio refcount is wrong, make this check during

Re: [PATCH bpf-next v2 4/4] selftests/bpf: convert test_skb_cgroup_id_user to test_progs

2024-08-12 Thread Alexis Lothoré
Hello Martin, On 8/10/24 01:53, Martin KaFai Lau wrote: > On 8/6/24 12:55 AM, Alexis Lothoré (eBPF Foundation) wrote: [...] >> +    SYS(fail, "ip link add dev %s type veth peer name %s", VETH_1, VETH_2); >> +    SYS(fail, "ip link set %s up", VETH_1); >> +    SYS(fail, "ip link set %s up", VETH_