Re: [PATCH net v3 2/2] skmsg: bugfix for sk_msg sge iteration

2024-07-15 Thread Geliang Tang
Hi John, On Mon, 2024-07-01 at 18:29 +0800, Geliang Tang wrote: > > > > > > > > Hello, > > > > > > > > > > > > > > > > On Mon, 2024-07-01 at 17:00 +0800, D. Wythe wrote: > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > On 6/28/24 1:47 PM, Geliang T

Re: [PATCH RFT v6 3/9] mm: Introduce ARCH_HAS_USER_SHADOW_STACK

2024-07-15 Thread Thiago Jung Bauermann
Hello, > diff --git a/mm/Kconfig b/mm/Kconfig > index b4cb45255a54..45416916dec1 100644 > --- a/mm/Kconfig > +++ b/mm/Kconfig > @@ -1249,6 +1249,12 @@ config IOMMU_MM_DATA > config EXECMEM > bool > > +config ARCH_HAS_USER_SHADOW_STACK > + bool > + help > + The architecture

Re: [PATCH] kselftest: missing arg in ptrace.c

2024-07-15 Thread Dev Jain
On 7/13/24 04:47, Remington Brasga wrote: The string passed to ksft_test_result_skip is missing the `type_name` Signed-off-by: Remington Brasga --- clang-tidy reported clang-diagnostic-format-insufficient-args warning on this line, so I am fixing it. tools/testing/selftests/arm64/abi/ptrac

Re: [PATCH v5 2/5] cgroup/pids: Make event counters hierarchical

2024-07-15 Thread xiujianfeng
Hi, Friendly ping, more comment as below. On 2024/7/3 14:59, xiujianfeng wrote: > > > On 2024/5/21 17:21, Michal Koutný wrote: >> The pids.events file should honor the hierarchy, so make the events >> propagate from their origin up to the root on the unified hierarchy. The >> legacy behavior re

Re: [PATCH v3] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Trevor Gross
On Mon, Jul 15, 2024 at 5:14 PM Michal Rostecki wrote: > diff --git a/rust/kernel/kunit.rs b/rust/kernel/kunit.rs > index 0ba77276ae7e..c08f9dddaa6f 100644 > --- a/rust/kernel/kunit.rs > +++ b/rust/kernel/kunit.rs > [...] > // SAFETY: FFI call without safety requirements. >

[PATCH v3] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Michal Rostecki
`CStr` became a part of `core` library in Rust 1.75. This change replaces the custom `CStr` implementation with the one from `core`. `core::CStr` behaves generally the same as the removed implementation, with the following differences: - It does not implement `Display` (but implements `Debug`). T

[PATCH v2] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Michal Rostecki
`CStr` became a part of `core` library in Rust 1.75. This change replaces the custom `CStr` implementation with the one from `core`. no need to keep the custom implementation. `core::CStr` behaves generally the same as the removed implementation, with the following differences: - It does not impl

Re: [PATCH v2 0/2] selftests/bpf: convert test_xdp_veth to test_progs framework

2024-07-15 Thread Stanislav Fomichev
On 07/15, Alexis Lothoré (eBPF Foundation) wrote: > Hello everyone, > > this small series is a first step in a larger effort aiming to help improve > eBPF selftests and the testing coverage in CI. It focuses for now on > test_xdp_veth.sh, a small test which is not integrated yet in test_progs. > T

Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers

2024-07-15 Thread David Finkel
[Fixing Shakeel's email address (I didn't notice it changed when comparing my previous "git send-email" commandline and get_mainainer.pl output)] On Mon, Jul 15, 2024 at 4:42 PM David Finkel wrote: > > Note: this is a simple rebase of a patch I sent a few months ago, > which received two acks bef

[PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers

2024-07-15 Thread David Finkel
This is a rebase of a patch I sent a few months ago, on which I received two acks, but the thread petered out: https://www.spinics.net/lists/cgroups/msg40602.html. I'm hoping that it can make it into the next LTS (and 6.11 if possible) Thank you, David Finkel Sr. Principal Software Engineer, Vi

Re: [PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers

2024-07-15 Thread David Finkel
Note: this is a simple rebase of a patch I sent a few months ago, which received two acks before the thread petered out: https://www.spinics.net/lists/cgroups/msg40602.html Thanks, On Mon, Jul 15, 2024 at 4:38 PM David Finkel wrote: > > Other mechanisms for querying the peak memory usage of eith

[PATCH] mm, memcg: cg2 memory{.swap,}.peak write handlers

2024-07-15 Thread David Finkel
Other mechanisms for querying the peak memory usage of either a process or v1 memory cgroup allow for resetting the high watermark. Restore parity with those mechanisms. For example: - Any write to memory.max_usage_in_bytes in a cgroup v1 mount resets the high watermark. - writing "5" to the

[PATCH v2] kselftest: cpufreq: Add RTC wakeup alarm

2024-07-15 Thread Shreeya Patel
Add RTC wakeup alarm for devices to resume after specific time interval. This improvement in the test will help in enabling this test in the CI systems and will eliminate the need of manual intervention for resuming back the devices after suspend/hibernation. Signed-off-by: Shreeya Patel --- Cha

Re: [PATCH v7 8/8] clk: Add KUnit tests for clks registered with struct clk_parent_data

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:44) > Test that clks registered with 'struct clk_parent_data' work as > intended and can find their parents. > > Cc: Christian Marangi > Cc: Brendan Higgins > Reviewed-by: David Gow > Cc: Rae Moar > Signed-off-by: Stephen Boyd > --- Applied to clk-next

Re: [PATCH v7 7/8] clk: Add KUnit tests for clk fixed rate basic type

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:43) > Test that the fixed rate basic type clk works as intended. > > Cc: Brendan Higgins > Cc: David Gow > Cc: Rae Moar > Signed-off-by: Stephen Boyd > --- Applied to clk-next

Re: [PATCH v7 6/8] clk: Add test managed clk provider/consumer APIs

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:42) > Unit tests are more ergonomic and simpler to understand if they don't > have to hoist a bunch of code into the test harness init and exit > functions. Add some test managed wrappers for the clk APIs so that clk > unit tests can write more code in the act

Re: [PATCH v7 5/8] platform: Add test managed platform_device/driver APIs

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:41) > Introduce KUnit resource wrappers around platform_driver_register(), > platform_device_alloc(), and platform_device_add() so that test authors > can register platform drivers/devices from their tests and have the > drivers/devices automatically be unregi

Re: [PATCH v7 4/8] of: Add a KUnit test for overlays and test managed APIs

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:40) > Test the KUnit test managed overlay APIs. Confirm that platform devices > are created and destroyed properly. This provides us confidence that the > test managed APIs work correctly and can be relied upon to provide tests > with fake platform devices and

Re: [PATCH v7 3/8] dt-bindings: vendor-prefixes: Add "test" vendor for KUnit and friends

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:39) > Add the vendor prefix "test" to reserve a vendor prefix for bindings > that are purely for testing device tree code. This allows test code to > write bindings that can be checked by the schema validator. > > Reviewed-by: Rob Herring > Reviewed-by: Davi

Re: [PATCH v7 2/8] of: Add test managed wrappers for of_overlay_apply()/of_node_put()

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:38) > Add test managed wrappers for of_overlay_apply() that automatically > removes the overlay when the test is finished. This API is intended for > use by KUnit tests that test code which relies on 'struct device_node's > and of_*() APIs. > > KUnit tests wi

Re: [PATCH v7 1/8] of/platform: Allow overlays to create platform devices from the root node

2024-07-15 Thread Stephen Boyd
Quoting Stephen Boyd (2024-07-10 13:12:37) > We'd like to apply overlays to the root node in KUnit so we can test > platform devices created as children of the root node. > > On some architectures (powerpc), the root node isn't marked with > OF_POPULATED_BUS. If an overlay tries to modify the root

Re: [PATCH-cgroup v2 4/5] cgroup/cpuset: Make cpuset.cpus.exclusive independent of cpuset.cpus

2024-07-15 Thread Waiman Long
On 7/15/24 11:56, Petr Malat wrote: Hi, I finally got some time to test this and it works exactly as we needed it to. Thanks a lot, Petr Thanks for the verification. Cheers, Longman On Mon, Jun 17, 2024 at 10:39:44AM -0400, Waiman Long wrote: The "cpuset.cpus.exclusive.effective" value i

Re: next-20240715: WARNING: at kernel/cpu.c:527 lockdep_assert_cpus_held (kernel/cpu.c:527 (discriminator 7) kernel/cpu.c:516 (discriminator 7))

2024-07-15 Thread Tejun Heo
Hello, On Mon, Jul 15, 2024 at 11:19:11PM +0530, Naresh Kamboju wrote: > The following kernel warnings are noticed on today's Linux next-20240715 tag > on the arm64 Raspberry Pi 4 Model B and x86_64 devices while booting. > > This is always reproducible: yes. > > GOOD

next-20240715: WARNING: at kernel/cpu.c:527 lockdep_assert_cpus_held (kernel/cpu.c:527 (discriminator 7) kernel/cpu.c:516 (discriminator 7))

2024-07-15 Thread Naresh Kamboju
The following kernel warnings are noticed on today's Linux next-20240715 tag on the arm64 Raspberry Pi 4 Model B and x86_64 devices while booting. This is always reproducible: yes. GOOD: next-20240712 BAD: next-20240715 Reported-by: Linux Kernel Functional Testing Warnin

[PATCH bpf-next] selftests/bpf: fexit_sleep: fix stack allocation for arm64

2024-07-15 Thread Puranjay Mohan
On ARM64 the stack pointer should be aligned at a 16 byte boundary or the SPAlignmentFault can occur. The fexit_sleep selftest allocates the stack for the child process as a character array, this is not guaranteed to be aligned at 16 bytes. Because of the SPAlignmentFault, the child process is kil

Re: [PATCH bpf] selftests/bpf: DENYLIST.aarch64: Remove fexit_sleep

2024-07-15 Thread Puranjay Mohan
Alexei Starovoitov writes: > On Mon, Jul 15, 2024 at 9:32 AM Puranjay Mohan wrote: >> >> >> Hi Daniel, Manu >> I was able to reproduce this issue on KVM and found the root cause for >> this hang! The other issue that we fixed is unrelated to this hang and >> doesn't occur on self hosted github r

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Mon, Jul 15, 2024 at 03:23:24PM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > Interesting - I was mainly developing on a system with multiple HDA > > cards and was getting fairly clearly unique names. > An AMD system usually has two HD-audio entries, and both are "HD-audio > Generic". Ri

Re: [PATCH bpf] selftests/bpf: DENYLIST.aarch64: Remove fexit_sleep

2024-07-15 Thread Alexei Starovoitov
On Mon, Jul 15, 2024 at 9:32 AM Puranjay Mohan wrote: > > > Hi Daniel, Manu > I was able to reproduce this issue on KVM and found the root cause for > this hang! The other issue that we fixed is unrelated to this hang and > doesn't occur on self hosted github runners as they use 48-bit VAs. > > Th

Re: [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors

2024-07-15 Thread Jakub Kicinski
On Mon, 15 Jul 2024 11:07:26 +0200 Matthieu Baerts wrote: > > Speaking of MPTCP tests - I added the connect test to ignored today. > > Too many failures :( > > Sorry for that, and thank you for having ignore it for the 'dbg' runner. > > This sudden regression looks strange. Our CI didn't catch

Re: Converting kselftest test modules to kunit

2024-07-15 Thread Kees Cook
On Mon, Jul 15, 2024 at 03:09:24PM +0500, Muhammad Usama Anjum wrote: > Hi Kees and All, > > There are several tests in kselftest subsystem which load modules to tests > the internals of the kernel. Most of these test modules are just loaded by > the kselftest, their status isn't read and reported

Re: [PATCH bpf] selftests/bpf: DENYLIST.aarch64: Remove fexit_sleep

2024-07-15 Thread Puranjay Mohan
Hi Daniel, Manu I was able to reproduce this issue on KVM and found the root cause for this hang! The other issue that we fixed is unrelated to this hang and doesn't occur on self hosted github runners as they use 48-bit VAs. The userspace test code has: #define STACK_SIZE (1024 * 1024)

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Michal Rostecki
On 15.07.24 17:56, Björn Roy Baron wrote: On Monday, July 15th, 2024 at 17:46, Michal Rostecki wrote: On 14.07.24 19:01, Björn Roy Baron wrote: On Sunday, July 14th, 2024 at 18:02, Michal Rostecki wrote: `CStr` became a part of `core` library in Rust 1.75, therefore there is no need to k

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Michal Rostecki
On 14.07.24 19:30, Miguel Ojeda wrote: Hi Michal, Thanks for the patch! Some notes below... On Sun, Jul 14, 2024 at 6:02 PM Michal Rostecki wrote: `CStr` became a part of `core` library in Rust 1.75, therefore there is no need to keep the custom implementation. It would depend on the diffe

Re: [PATCH-cgroup v2 4/5] cgroup/cpuset: Make cpuset.cpus.exclusive independent of cpuset.cpus

2024-07-15 Thread Petr Malat
Hi, I finally got some time to test this and it works exactly as we needed it to. Thanks a lot, Petr On Mon, Jun 17, 2024 at 10:39:44AM -0400, Waiman Long wrote: > The "cpuset.cpus.exclusive.effective" value is currently limited to a > subset of its "cpuset.cpus". This makes the exclusive CPUs d

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Björn Roy Baron
On Monday, July 15th, 2024 at 17:46, Michal Rostecki wrote: > On 14.07.24 19:01, Björn Roy Baron wrote: > > On Sunday, July 14th, 2024 at 18:02, Michal Rostecki > > wrote: > > > >> `CStr` became a part of `core` library in Rust 1.75, therefore there is > >> no need to keep the custom implement

Re: [PATCH] rust: str: Use `core::CStr`, remove the custom `CStr` implementation

2024-07-15 Thread Michal Rostecki
On 14.07.24 19:01, Björn Roy Baron wrote: On Sunday, July 14th, 2024 at 18:02, Michal Rostecki wrote: `CStr` became a part of `core` library in Rust 1.75, therefore there is no need to keep the custom implementation. `core::CStr` behaves generally the same as the removed implementation, with

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Takashi Iwai
On Mon, 15 Jul 2024 15:18:44 +0200, Mark Brown wrote: > > On Sat, Jul 13, 2024 at 08:46:43AM +0200, Takashi Iwai wrote: > > Mark Brown wrote: > > > OTOH, if the former is the problem, using longname won't help, > > either, rather it can be confusing. I noticed that the test output > > truncates

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Sat, Jul 13, 2024 at 08:46:43AM +0200, Takashi Iwai wrote: > Mark Brown wrote: > > Sure, but the genesis of this patch is that probe order isn't > > sufficiently stable and we want to avoid names based on it... using the > > ID will be more likely to work out stable than just pure probe order

Re: [PATCH] kselftest/alsa: Use card name rather than number in test names

2024-07-15 Thread Mark Brown
On Sat, Jul 13, 2024 at 09:35:36AM +0200, Jaroslav Kysela wrote: > On 12. 07. 24 20:19, Mark Brown wrote: > > Sure, but the genesis of this patch is that probe order isn't > > sufficiently stable and we want to avoid names based on it... using the > > ID will be more likely to work out stable tha

Re: [PATCH v2 2/2] selftests/bpf: integrate test_xdp_veth into test_progs

2024-07-15 Thread Simon Horman
On Mon, Jul 15, 2024 at 11:53:45AM +0200, Alexis Lothoré (eBPF Foundation) wrote: > test_xdp_veth.sh tests that XDP return codes work as expected, by bringing > up multiple veth pairs isolated in different namespaces, attaching specific > xdp programs to each interface, and ensuring that the whole

Re: [PATCH] selftests/net: fix gro.c compilation failure due to non-existent opt_ipproto_off

2024-07-15 Thread Greg Kroah-Hartman
On Fri, Jul 12, 2024 at 05:01:38PM -0700, John Hubbard wrote: > On 7/12/24 4:51 PM, John Hubbard wrote: > > Linux 6.6 does not have an opt_ipproto_off variable in gro.c at all (it > > was added in later kernel versions), so attempting to initialize one > > breaks the build. > > This is the first t

Re: [PATCH] kselftest: missing arg in ptrace.c

2024-07-15 Thread Dev Jain
On 7/13/24 04:47, Remington Brasga wrote: The string passed to ksft_test_result_skip is missing the `type_name` Signed-off-by: Remington Brasga Reviewed-by: Dev Jain

Re: [PATCH v4 2/2] selftests: Add a test mangling with uc_sigmask

2024-07-15 Thread Dev Jain
On 6/30/24 20:48, Oleg Nesterov wrote: I see nothing wrong, but perhaps this test can be simplified? Feel free to ignore. Say, On 06/27, Dev Jain wrote: +void handler_usr(int signo, siginfo_t *info, void *uc) +{ + int ret; + + /* +* Break out of infinite recursion caused

Re: [PATCH net-next] selftests: net: py: support verbose printing, display executed commands

2024-07-15 Thread Petr Machata
Mohsin Bashir writes: > Add verbosity support to show the commands executed while > running tests. Enable verbosity if either an environment > variable 'VERBOSE' is set to a non-zero number or it is defined > in a config file under driver tests as discussed here: > https://github.com/linux-netd

Converting kselftest test modules to kunit

2024-07-15 Thread Muhammad Usama Anjum
Hi Kees and All, There are several tests in kselftest subsystem which load modules to tests the internals of the kernel. Most of these test modules are just loaded by the kselftest, their status isn't read and reported to the user logs. Hence they don't provide benefit of executing those tests. I

[PATCH v2 2/2] selftests/bpf: integrate test_xdp_veth into test_progs

2024-07-15 Thread eBPF Foundation
test_xdp_veth.sh tests that XDP return codes work as expected, by bringing up multiple veth pairs isolated in different namespaces, attaching specific xdp programs to each interface, and ensuring that the whole chain allows to ping one end interface from the first one. The test runs well but is cur

[PATCH v2 1/2] selftests/bpf: update xdp_redirect_map prog sections for libbpf

2024-07-15 Thread eBPF Foundation
xdp_redirect_map.c is a bpf program used by test_xdp_veth.sh, which is not handled by the generic test runner (test_progs). To allow converting this test to test_progs, the corresponding program must be updated to allow handling it through skeletons generated by bpftool and libbpf. Update programs

[PATCH v2 0/2] selftests/bpf: convert test_xdp_veth to test_progs framework

2024-07-15 Thread eBPF Foundation
Hello everyone, this small series is a first step in a larger effort aiming to help improve eBPF selftests and the testing coverage in CI. It focuses for now on test_xdp_veth.sh, a small test which is not integrated yet in test_progs. The series is mostly about a rewrite of test_xdp_veth.sh to mak

Re: [PATCH net-next] selftests: mptcp: lib: fix shellcheck errors

2024-07-15 Thread Matthieu Baerts
Hi Jakub, On 14/07/2024 00:46, Jakub Kicinski wrote: > On Fri, 12 Jul 2024 12:00:15 +0200 Matthieu Baerts (NGI0) wrote: >> It looks like we missed these two errors recently: >> >> - SC2068: Double quote array expansions to avoid re-splitting elements. >> - SC2145: Argument mixes string and arr

Re: [PATCH 2/3] selftests/bpf: integrate test_xdp_veth into test_progs

2024-07-15 Thread Alexis Lothoré
Hello Stanislas, thanks for the review On 7/12/24 03:10, Stanislav Fomichev wrote: > On 07/11, Alexis Lothoré (eBPF Foundation) wrote: >> test_xdp_veth.sh tests that XDP return codes work as expected, by bringing >> up multiple veth pairs isolated in different namespaces, attaching specific >> xdp