Re: [PATCH][next] KVM: selftests: Fix spelling mistake "trigged" -> "triggered"

2024-03-07 Thread Anup Patel
On Fri, Mar 8, 2024 at 3:47 AM Oliver Upton wrote: > > Thanks for the fix Colin. Paolo/Anup, up to you how you want to play it, > I see the 6.9 PR is already out for riscv. > > Acked-by: Oliver Upton I can take this as a Linux-6.9-rcX fix if everyone is okay with it. Regards, Anup > > On Thu,

Re: [PATCH net-next v2 00/12] selftests: mptcp: share code and fix shellcheck warnings

2024-03-07 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Wed, 06 Mar 2024 10:42:49 +0100 you wrote: > This series cleans MPTCP selftests code. > > Patch 1 stops using 'iptables-legacy' if available, but uses 'iptables', > which is likely 'iptables-nft' behind. > > Pat

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-07 Thread David Wei
On 2024-03-04 18:01, Mina Almasry wrote: > From: Jakub Kicinski > > The page providers which try to reuse the same pages will > need to hold onto the ref, even if page gets released from > the pool - as in releasing the page from the pp just transfers > the "ownership" reference from pp to the pr

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-07 Thread Jakub Kicinski
On Mon, 4 Mar 2024 18:01:40 -0800 Mina Almasry wrote: > + if (!dev || !dev->netdev_ops) > + return -EINVAL; too defensive > + if (!dev->netdev_ops->ndo_queue_stop || > + !dev->netdev_ops->ndo_queue_mem_free || > + !dev->netdev_ops->ndo_queue_mem_alloc || > +

RE: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-07 Thread Song, Yoong Siang
On Thursday, March 7, 2024 9:39 PM, Kurt Kanzenbach wrote: >Hi Maciej, > >On Wed Mar 06 2024, Maciej Fijalkowski wrote: >> On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote: >>> - tstamp->skb = NULL; >>> + /* Copy the tx hardware timestamp into xdp metadata or skb */ >>> + if

Re: [RFC PATCH net-next v6 01/15] queue_api: define queue api

2024-03-07 Thread Jakub Kicinski
On Thu, 7 Mar 2024 18:08:24 -0800 Mina Almasry wrote: > On Thu, Mar 7, 2024 at 5:30 PM Jakub Kicinski wrote: > > On Mon, 4 Mar 2024 18:01:36 -0800 Mina Almasry wrote: > > > + * void *(*ndo_queue_mem_alloc)(struct net_device *dev, int idx); > > > + * Allocate memory for an RX queue. The memory

[PATCH v4 3/4] Documentation: adjust pstore backend related document

2024-03-07 Thread Yuanhe Shu
Pstore now supports multiple backends, adjust related document. Signed-off-by: Yuanhe Shu --- Documentation/ABI/testing/pstore| 8 Documentation/admin-guide/kernel-parameters.txt | 4 +++- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/Documentation/ABI/t

[PATCH v4 4/4] tools/testing: adjust pstore backend related selftest

2024-03-07 Thread Yuanhe Shu
Pstore now supports multiple backends, the module parameter pstore.backend varies from 'registered backend' to 'backends that are allowed to register' and a new entry /sys/module/pstore/loaded_backend is added to show which pstore backends are loaded at present. Adjust selftests to match the change

[PATCH v4 2/4] pstore: add a /sys/module entry for loaded backends

2024-03-07 Thread Yuanhe Shu
Introduce a /sys/module entry for loaded pstore backends which provide users and testcases with a standarized interface to retrieve information on which pstore backends are currently registered. Signed-off-by: Yuanhe Shu --- fs/pstore/inode.c| 38 ++ fs/ps

[PATCH v4 1/4] pstore: add multi-backend support

2024-03-07 Thread Yuanhe Shu
Currently, pstore supports only one backend open at a time. Specifically, due to the global variable "psinfo", pstore only accepts the first registered backend. If a new backend wants to register later, pstore will simply reject it and return an error. This design forced us to close existing backen

[PATCH v4 0/4] pstore: add multi-backend suuport

2024-03-07 Thread Yuanhe Shu
This is the 4th version of the patch set. In this patchset we aim to add pstore multi-backend support then user can register more than one pstore backend. Changes in v4: - Replace all rcu_read_lock with mutex - Move bif_oops_buf, max_compressed_size and pstore_dumper into pstore_info_list - add

Re: [RFC PATCH net-next v6 01/15] queue_api: define queue api

2024-03-07 Thread Mina Almasry
On Thu, Mar 7, 2024 at 5:30 PM Jakub Kicinski wrote: > > On Mon, 4 Mar 2024 18:01:36 -0800 Mina Almasry wrote: > > + * void *(*ndo_queue_mem_alloc)(struct net_device *dev, int idx); > > + * Allocate memory for an RX queue. The memory returned in the form of > > + * a void * can be passed to n

Re: [RFC PATCH net-next v6 14/15] net: add devmem TCP documentation

2024-03-07 Thread Jakub Kicinski
On Mon, 4 Mar 2024 18:01:49 -0800 Mina Almasry wrote: > +Intro > += > + > +Device memory TCP (devmem TCP) enables receiving data directly into device > +memory (dmabuf). The feature is currently implemented for TCP sockets. > + > + > +Opportunity > +--- > + > +A large amount of data tr

Re: [RFC PATCH net-next v6 01/15] queue_api: define queue api

2024-03-07 Thread Jakub Kicinski
On Mon, 4 Mar 2024 18:01:36 -0800 Mina Almasry wrote: > + * void *(*ndo_queue_mem_alloc)(struct net_device *dev, int idx); > + * Allocate memory for an RX queue. The memory returned in the form of > + * a void * can be passed to ndo_queue_mem_free() for freeing or to > + * ndo_queue_start to

Re: [PATCH] tools/testing/selftests/bpf/test_tc_tunnel.sh: Prevent client connect before server bind

2024-03-07 Thread Martin KaFai Lau
On 2/29/24 6:00 AM, Alessandro Carminati (Red Hat) wrote: In some systems, the netcat server can incur in delay to start listening. When this happens, the test can randomly fail in various points. This is an example error message: # ip gre none gso # encap 192.168.1.1 to 192.168.1.2, type

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 3:16 PM, Tony Luck wrote: > On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: >> Thank you for the example. I find that significantly easier to >> understand than a single number in a generic "nodes_per_l3_cache". >> Especially with potential confusion surroundi

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Tony Luck
On Thu, Mar 07, 2024 at 02:39:08PM -0800, Reinette Chatre wrote: > Thank you for the example. I find that significantly easier to > understand than a single number in a generic "nodes_per_l3_cache". > Especially with potential confusion surrounding inconsistent "nodes" > between allocation and moni

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-07 Thread Leonardo Brás
On Mon, 2024-03-04 at 18:45 -0300, Helen Koike wrote: > Hi Linus, > > Thank you for your reply and valuable inputs. > > On 01/03/2024 17:10, Linus Torvalds wrote: > > On Fri, 1 Mar 2024 at 02:27, Nikolai Kondrashov wrote: > > > > > > I agree, it's hard to imagine even a simple majority agreeing

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 1:14 PM, Luck, Tony wrote: >> Thinking about it even differently. The goal is to give information >> to userspace so we need to think about what would help user space? >> For example, what if there is a file in info that shows >> which CPUs are associated with each domain? >

[PATCH v3] kunit: tool: add ability to parse multiple files

2024-03-07 Thread Rae Moar
Add ability to parse multiple files. Additionally add the ability to parse all results in the KUnit debugfs repository. How to parse multiple files: ./tools/testing/kunit/kunit.py parse results.log results2.log How to parse all files in directory: ./tools/testing/kunit/kunit.py parse directory_

Re: [PATCH][next] KVM: selftests: Fix spelling mistake "trigged" -> "triggered"

2024-03-07 Thread Oliver Upton
Thanks for the fix Colin. Paolo/Anup, up to you how you want to play it, I see the 6.9 PR is already out for riscv. Acked-by: Oliver Upton On Thu, Mar 07, 2024 at 08:19:51AM +, Colin Ian King wrote: > There are spelling mistakes in __GUEST_ASSERT messages. Fix them. > > Signed-off-by: Colin

Re: [PATCH v2 02/31] ntsync: Introduce NTSYNC_IOC_CREATE_SEM.

2024-03-07 Thread Greg Kroah-Hartman
On Mon, Feb 19, 2024 at 04:38:04PM -0600, Elizabeth Figura wrote: > This corresponds to the NT syscall NtCreateSemaphore(). > > Semaphores are one of three types of object to be implemented in this driver, > the others being mutexes and events. > > An NT semaphore contains a 32-bit counter, and i

Re: [PATCH v1 0/3] selftests/timers/posix_timers: various cleanups

2024-03-07 Thread Thomas Gleixner
On Thu, Mar 07 2024 at 13:34, Edward Liaw wrote: >> Thanks for picking those up and moving them forward. Any particular >> reason why you didn't pick up the full set? > > I didn't know enough about the code to resolve some of the merges in the > full set. I had run into the issue with the test tim

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
> Thinking about it even differently. The goal is to give information > to userspace so we need to think about what would help user space? > For example, what if there is a file in info that shows > which CPUs are associated with each domain? Reinette, Interesting idea. That would save users fro

Re: [PATCH v1 0/3] selftests/timers/posix_timers: various cleanups

2024-03-07 Thread Thomas Gleixner
On Mon, Mar 04 2024 at 18:11, Edward Liaw wrote: > I'm sending some patches that were orignally in > https://lore.kernel.org/lkml/20230606132949.068951...@linutronix.de/ > to prevent the timer_distribution test from hanging and also fix some > format inconsistencies. Thanks for picking those up an

Re: [Test Failure Report] exec: Test failures in execveat

2024-03-07 Thread Kees Cook
On Thu, Mar 07, 2024 at 02:22:27PM +0500, Muhammad Usama Anjum wrote: > I've tested this patch. Still getting same failures. Okay, thanks for testing! What environment are you testing under? It would seem like some unexpected userspace conditions exist that the test isn't prepared for. (I was abl

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 9:57 AM, Luck, Tony wrote: >>> SNC2 enabled: >>> >>> $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache >>> 2 >>> >> >> This would be useful. I believe "SNC" is architecture specific? >> What if the file always exists and is named "nodes_per_l3_cache"? >> >> I assume th

Re: [PATCH v5 0/9] arm64: Support for 2023 DPISA extensions

2024-03-07 Thread Catalin Marinas
On Wed, 06 Mar 2024 23:14:45 +, Mark Brown wrote: > This series enables support for the data processing extensions in the > newly released 2023 architecture, this is mainly support for 8 bit > floating point formats. Most of the extensions only introduce new > instructions and therefore only r

[PATCH] selftests: x86: skip the tests if prerequisites aren't fulfilled

2024-03-07 Thread Muhammad Usama Anjum
Skip instead of failing when prerequisite conditions aren't fulfilled, such as invalid xstate values etc. This patch would make the tests show as skip when run by: make -C tools/testing/selftest/ TARGETS=x86 run_tests ... # timeout set to 45 # selftests: x86: amx_64 # # xstate cpuid: inv

[PATCH] selftests: x86: conform test to TAP format output

2024-03-07 Thread Muhammad Usama Anjum
Conform the layout, informational and status messages to TAP. No functional change is intended other than the layout of output messages. Signed-off-by: Muhammad Usama Anjum --- tools/testing/selftests/x86/vdso_restorer.c | 29 + 1 file changed, 12 insertions(+), 17 deletions(

Re: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test

2024-03-07 Thread Sean Christopherson
On Thu, Mar 07, 2024, Sean Christopherson wrote: > On Thu, Mar 07, 2024, Manali Shukla wrote: From: Manali Shukla > > > + xapic_enable(); > > + > > + icr_val = (APIC_DEST_SELF | APIC_INT_ASSERT | VINTR_VECTOR); > > + > > + for (i = 0; i < NUM_ITERATIONS; i++) { > > + xapic_write_r

Re: [PATCH v1 5/5] selftests: KVM: SVM: Add Idle HLT intercept test

2024-03-07 Thread Sean Christopherson
On Thu, Mar 07, 2024, Manali Shukla wrote: > From: Manali Shukla > > The Execution of the HLT instruction results in a VMEXIT. Hypervisor > observes pending V_INTR and V_NMI events just after the VMEXIT > generated by the HLT for the vCPU and causes VM entry to service the > pending events. The

Re: [PATCH 1/3] kci-gitlab: Introducing GitLab-CI Pipeline for Kernel Testing

2024-03-07 Thread Nicolas Dufresne
Le jeudi 29 février 2024 à 10:02 +0100, Maxime Ripard a écrit : > Hi Helen, > > Thanks for working on this > > On Wed, Feb 28, 2024 at 07:55:25PM -0300, Helen Koike wrote: > > This patch introduces a `.gitlab-ci` file along with a `ci/` folder, > > defininga basic test pipeline triggered by code

Re: [PATCH net-next v2 3/4] net: gro: set inner_network_header in receive phase

2024-03-07 Thread Eric Dumazet
On Thu, Mar 7, 2024 at 2:28 PM Richard Gobert wrote: > > This patch sets network_header and inner_network_header to their respective > values during the receive phase of GRO. This allows us to use > inner_network_header later on in GRO. network_header is already set in > dev_gro_receive and under

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
> > SNC2 enabled: > > > > $ cat /sys/fs/resctrl/info/L3_mon/ snc_nodes_per_l3_cache > > 2 > > > > This would be useful. I believe "SNC" is architecture specific? > What if the file always exists and is named "nodes_per_l3_cache"? > > I assume that the internals of handling more nodes per L3 cache s

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Reinette Chatre
Hi Tony, On 3/7/2024 9:18 AM, Luck, Tony wrote: >>> If so, what should it be named? "snc_ways" as a kernel variable was >>> later replaced by "snc_nodes_per_l3_cache". Is that a good filename? >> >> "snc_nodes_per_l3_cache" seems okay to me. >> >> And I understand that the file content would show

RE: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Luck, Tony
>>If so, what should it be named? "snc_ways" as a kernel variable was >>later replaced by "snc_nodes_per_l3_cache". Is that a good filename? > > "snc_nodes_per_l3_cache" seems okay to me. > > And I understand that the file content would show SNC mode and the presence or > absence of this file would

Re: [PATCH v4 5/7] arm64: Unconditionally call unflatten_device_tree()

2024-03-07 Thread Herve Codina
Hi, On Wed, 28 Feb 2024 10:26:47 -0600 Rob Herring wrote: ... > > > > > > Yes, that version unflattened the bootloader passed DT. Now within > > > unflatten_devicetree(), the bootloader DT is ignored if ACPI is > > > enabled and we unflatten an empty tree. That will prevent the kernel > > > get

Re: [PATCH v5 8/8] mm: huge_memory: enable debugfs to split huge pages to any order.

2024-03-07 Thread Zi Yan
On 26 Feb 2024, at 15:55, Zi Yan wrote: > From: Zi Yan > > It is used to test split_huge_page_to_list_to_order for pagecache THPs. > Also add test cases for split_huge_page_to_list_to_order via both > debugfs. > > Signed-off-by: Zi Yan > --- > mm/huge_memory.c | 34

Re: [PATCH v5 7/8] mm: thp: split huge page to any lower order pages

2024-03-07 Thread Zi Yan
On 26 Feb 2024, at 15:55, Zi Yan wrote: > From: Zi Yan > > To split a THP to any lower order pages, we need to reform THPs on > subpages at given order and add page refcount based on the new page > order. Also we need to reinitialize page_deferred_list after removing > the page from the split_que

Re: [PATCH v1 3/5] tools: Add KVM exit reason for the Idle HLT

2024-03-07 Thread Sean Christopherson
On Thu, Mar 07, 2024, Manali Shukla wrote: > From: Manali Shukla > > The Idle HLT intercept feature allows for the HLT instruction execution > by a vCPU to be intercepted by hypervisor only if there are no pending > V_INR and V_NMI events for the vCPU. The Idle HLT intercept will not be > trigger

Re: [RFC PATCH net-next v6 02/15] net: page_pool: create hooks for custom page providers

2024-03-07 Thread Pavel Begunkov
On 3/6/24 21:59, Mina Almasry wrote: On Wed, Mar 6, 2024 at 11:14 AM Pavel Begunkov wrote: On 3/6/24 17:04, Mina Almasry wrote: On Wed, Mar 6, 2024 at 6:30 AM Pavel Begunkov wrote: On 3/5/24 22:36, Mina Almasry wrote: ... To be honest, I think it makes sense for the TCP stack to be respons

Re: [xdp-hints] Re: [Intel-wired-lan] [PATCH iwl-next, v3 2/2] igc: Add Tx hardware timestamp request for AF_XDP zero-copy packet

2024-03-07 Thread Kurt Kanzenbach
Hi Maciej, On Wed Mar 06 2024, Maciej Fijalkowski wrote: > On Sun, Mar 03, 2024 at 04:32:25PM +0800, Song Yoong Siang wrote: >> -tstamp->skb = NULL; >> +/* Copy the tx hardware timestamp into xdp metadata or skb */ >> +if (tstamp->buffer_type == IGC_TX_BUFFER_TYPE_XSK) > > I believe th

[PATCH net-next v2 4/4] net: gro: move L3 flush checks to tcp_gro_receive

2024-03-07 Thread Richard Gobert
{inet,ipv6}_gro_receive functions perform flush checks (ttl, flags, iph->id, ...) against all packets in a loop. These flush checks are relevant only to tcp flows, and as such they're used to determine whether the packets can be merged later in tcp_gro_receive. These checks are not relevant to UDP

[PATCH net-next v2 3/4] net: gro: set inner_network_header in receive phase

2024-03-07 Thread Richard Gobert
This patch sets network_header and inner_network_header to their respective values during the receive phase of GRO. This allows us to use inner_network_header later on in GRO. network_header is already set in dev_gro_receive and under encapsulation inner_network_header is set. Signed-off-by: Richa

[PATCH net-next v2 2/4] selftests/net: add local address bind in vxlan selftest

2024-03-07 Thread Richard Gobert
Add local address bind support to existing udpgro_fwd.sh vxlan selftest, to ensure UDP socket lookup in GRO is working. Signed-off-by: Richard Gobert --- tools/testing/selftests/net/udpgro_fwd.sh | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/tools/testing/selftes

[PATCH net-next v2 1/4] net: gro: add p_off param in *_gro_complete

2024-03-07 Thread Richard Gobert
Commits a602456 ("udp: Add GRO functions to UDP socket") and 57c67ff ("udp: additional GRO support") introduce incorrect usage of {ip,ipv6}_hdr in the complete phase of gro. The functions always return skb->network_header, which in the case of encapsulated packets at the gro complete phase, is alwa

[PATCH net-next v2 0/4] net: gro: encapsulation bug fix and flush checks improvements

2024-03-07 Thread Richard Gobert
This series fixes a bug in the complete phase of UDP in GRO, in which socket lookup fails due to using network_header when parsing encapsulated packets. The fix is to pass p_off parameter in *_gro_complete. Next, inner_network_header is always set in the receive phase of GRO, this is then leverage

Re: [RFC PATCH net-next v6 05/15] netdev: support binding dma-buf to netdevice

2024-03-07 Thread Yunsheng Lin
On 2024/3/7 6:10, Mina Almasry wrote: ... > +static int netdev_restart_rx_queue(struct net_device *dev, int rxq_idx) > +{ > + void *new_mem; > + void *old_mem; > + int err; > + > + if (!dev || !dev->netdev_ops) > + return -EINVAL; >

Re: [PATCH 4/4] selftests/resctrl: Adjust SNC support messages

2024-03-07 Thread Maciej Wieczor-Retman
On 2024-03-06 at 21:54:02 +, Luck, Tony wrote: >> Figuring out if SNC is enabled is only one part of the problem, the >> other being whether the kernel supports it. As there is no easy >> interface that simply states SNC support in the kernel one can find that >> information by comparing L3 cac

Re: [Test Failure Report] exec: Test failures in execveat

2024-03-07 Thread Muhammad Usama Anjum
On 3/6/24 2:00 AM, Kees Cook wrote: > On Tue, Mar 05, 2024 at 07:20:27PM +0500, Muhammad Usama Anjum wrote: >> Hello, >> >> I've been running execveat (execveat.c) locally on v6.1 and next-20240228. >> It has flaky test case. There are some test cases which fail consistently. >> The comment (not ve

Re: [PATCH v3 0/2] selftests/vDSO: Fix errors on LoongArch

2024-03-07 Thread Tiezhu Yang
On 02/29/2024 05:13 PM, Tiezhu Yang wrote: Hi Shuah and Andrew, On 01/29/2024 04:27 PM, Tiezhu Yang wrote: On 12/27/2023 03:55 PM, Tiezhu Yang wrote: + Andrew Morton + Mark Brown On 12/13/2023 09:22 AM, Tiezhu Yang wrote: v3: Rebase on the next branch of linux-kselftest.git, modify t

[PATCH][next] KVM: selftests: Fix spelling mistake "trigged" -> "triggered"

2024-03-07 Thread Colin Ian King
There are spelling mistakes in __GUEST_ASSERT messages. Fix them. Signed-off-by: Colin Ian King --- tools/testing/selftests/kvm/aarch64/arch_timer.c | 2 +- tools/testing/selftests/kvm/riscv/arch_timer.c | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/tools/testing/selft