Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT test

2024-01-18 Thread Maciej Wieczór-Retman
Hello! On 2024-01-18 at 09:15:46 -0800, Reinette Chatre wrote: >Hi Maciej, > >On 1/18/2024 4:02 AM, Maciej Wieczór-Retman wrote: >> On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote: >>> On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote: On 2024-01-08 at 14:42:11 -0800, Reinette Chatre

Re: [PATCH] kunit: tool: Print UML command

2024-01-18 Thread David Gow
On Thu, 18 Jan 2024 at 23:14, Mickaël Salaün wrote: > > As for the Qemu command, print the command used to run tests with UML. > > Cc: Brendan Higgins > Cc: David Gow > Signed-off-by: Mickaël Salaün > --- Thanks: this will definitely be useful. Reviewed-by: David Gow Cheers, -- David smim

回复: [PATCH v4] selftests/move_mount_set_group:Make tests build with old libc

2024-01-18 Thread Huyadi
>On Thu, 11 Jan 2024 19:32:29 +0800, Hu Yadi wrote: >> Replace SYS_ with __NR_. Using the __NR_ >> notation, provided by UAPI, is useful to build tests on systems >> without the SYS_ definitions. >> >> Replace SYS_move_mount with __NR_move_mount >> >> Similar changes: commit 87129ef13603 ("se

Re: [PATCH net] selftests: bonding: Increase timeout to 1200s

2024-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by David S. Miller : On Wed, 17 Jan 2024 19:12:32 -0500 you wrote: > When tests are run by runner.sh, bond_options.sh gets killed before > it can complete: > > make -C tools/testing/selftests run_tests TARGETS="drivers/net/bonding" > [

[PATCH v4 4/4] selftest/bpf: Test a perf bpf program that suppresses side effects.

2024-01-18 Thread Kyle Huey
The test sets a hardware breakpoint and uses a bpf program to suppress the side effects of a perf event sample, including I/O availability signals, SIGTRAPs, and decrementing the event counter limit, if the ip matches the expected value. Then the function with the breakpoint is executed multiple ti

Re: [PATCH v3 4/4] selftest/bpf: Test a perf bpf program that suppresses side effects.

2024-01-18 Thread Kyle Huey
On Tue, Jan 2, 2024 at 2:49 PM Song Liu wrote: > > On Sun, Dec 10, 2023 at 8:56 PM Kyle Huey wrote: > > > > The test sets a hardware breakpoint and uses a bpf program to suppress the > > side effects of a perf event sample, including I/O availability signals, > > SIGTRAPs, and decrementing the ev

Re: Re: [PATCH] kunit: Mark filter_glob param as rw

2024-01-18 Thread Lucas De Marchi
On Thu, Jan 18, 2024 at 05:23:33PM -0500, Rae Moar wrote: On Thu, Jan 11, 2024 at 7:13 PM Lucas De Marchi wrote: By allowing the filter_glob parameter to be written to, it's possible to tweak the testsuites that will be executed on new module loads. This makes it easier to run specific tests w

Re: [PATCH] kunit: Mark filter_glob param as rw

2024-01-18 Thread Rae Moar
On Thu, Jan 11, 2024 at 7:13 PM Lucas De Marchi wrote: > > By allowing the filter_glob parameter to be written to, it's possible to > tweak the testsuites that will be executed on new module loads. This > makes it easier to run specific tests without having to reload kunit and > provides a way to

Re: [PATCH v7 36/39] selftests/arm64: Add GCS signal tests

2024-01-18 Thread Mark Brown
On Sat, Dec 16, 2023 at 11:12:37PM -0300, Thiago Jung Bauermann wrote: > Mark Brown writes: > > +/* This should be includable from some standard header, but which? */ > > +#ifndef SEGV_CPERR > > +#define SEGV_CPERR 10 > > +#endif > One suggestion is include/uapi/asm-generic/siginfo.h. It already

Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-18 Thread Yonghong Song
On 1/18/24 8:05 AM, Eduard Zingerman wrote: On Thu, 2024-01-18 at 17:58 +0200, Eduard Zingerman wrote: [...] here is how config for x86 CI is prepared: ./scripts/kconfig/merge_config.sh \ ./tools/testing/selftests/bpf/config \ ./tools/testing/selftests/bpf/config.vm \

Re: [PATCH v7 34/39] kselftest/arm64: Add a GCS test program built with the system libc

2024-01-18 Thread Mark Brown
On Thu, Dec 14, 2023 at 11:50:11PM -0300, Thiago Jung Bauermann wrote: > If I swap process_vm_readv() and process_vm_writev(), then the read > succeeds but the write fails: The writes are intended to fail, for security reasons we explicitly block this API for GCS pages. Given that process_vm_wri

Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT test

2024-01-18 Thread Reinette Chatre
Hi Maciej, On 1/18/2024 4:02 AM, Maciej Wieczór-Retman wrote: > On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote: >> On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote: >>> On 2024-01-08 at 14:42:11 -0800, Reinette Chatre wrote: On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote: >

Re: [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test

2024-01-18 Thread Jakub Kicinski
On Thu, 18 Jan 2024 17:04:25 + Dmitry Safonov wrote: > > Somewhat unrelated to these fixes but related to the tcp_ao selftests > > in general - could you please also add a config file so that it's > > easy to build a minimal kernel for running the tests? > > > > Something like: > > > > make

Re: [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test

2024-01-18 Thread Dmitry Safonov
On 1/18/24 16:51, Jakub Kicinski wrote: > On Thu, 18 Jan 2024 02:51:33 + Dmitry Safonov wrote: >> Two typo fixes, noticed by Mohammad's review. >> And a fix for an issue that got uncovered. > > Somewhat unrelated to these fixes but related to the tcp_ao selftests > in general - could you pleas

Re: [PATCH 0/3] selftests/net: A couple of typos fixes in key-management test

2024-01-18 Thread Jakub Kicinski
On Thu, 18 Jan 2024 02:51:33 + Dmitry Safonov wrote: > Two typo fixes, noticed by Mohammad's review. > And a fix for an issue that got uncovered. Somewhat unrelated to these fixes but related to the tcp_ao selftests in general - could you please also add a config file so that it's easy to buil

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-18 Thread Geert Uytterhoeven
Hi Mark, On Thu, Jan 18, 2024 at 4:27 PM Mark Rutland wrote: > On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > > Quoting Mark Rutland (2024-01-16 03:51:14) > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > > Call this function unconditionally so that we can

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-18 Thread Geert Uytterhoeven
Hi Mark, On Thu, Jan 18, 2024 at 4:23 PM Mark Rutland wrote: > On Tue, Jan 16, 2024 at 03:13:42PM +0100, Geert Uytterhoeven wrote: > > On Tue, Jan 16, 2024 at 12:51 PM Mark Rutland wrote: > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > > Call this function unconditional

Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-18 Thread Eduard Zingerman
On Thu, 2024-01-18 at 17:58 +0200, Eduard Zingerman wrote: [...] > here is how config for x86 CI is prepared: > > ./scripts/kconfig/merge_config.sh \ > ./tools/testing/selftests/bpf/config \ > ./tools/testing/selftests/bpf/config.vm \ > ./tools/testing/selftests/bpf/conf

Re: lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-18 Thread Eduard Zingerman
On Thu, 2024-01-18 at 19:58 +0800, Shung-Hsi Yu wrote: > Hi, > > Compilation of lsm_cgroup.c will fail if the vmlinux.h comes from a > kernel that does _not_ have CONFIG_PACKET=y. The reason is that the > definition of struct sockaddr_ll is not present in vmlinux.h and the > compiler will complain

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-18 Thread Mark Rutland
On Tue, Jan 16, 2024 at 05:27:18PM -0800, Stephen Boyd wrote: > Quoting Mark Rutland (2024-01-16 03:51:14) > > Hi Stephen, > > > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platforms that don

Re: [PATCH 1/6] arm64: Unconditionally call unflatten_device_tree()

2024-01-18 Thread Mark Rutland
On Tue, Jan 16, 2024 at 03:13:42PM +0100, Geert Uytterhoeven wrote: > Hi Mark, > > On Tue, Jan 16, 2024 at 12:51 PM Mark Rutland wrote: > > On Fri, Jan 12, 2024 at 12:07:44PM -0800, Stephen Boyd wrote: > > > Call this function unconditionally so that we can populate an empty DTB > > > on platform

[PATCH] kunit: tool: Print UML command

2024-01-18 Thread Mickaël Salaün
As for the Qemu command, print the command used to run tests with UML. Cc: Brendan Higgins Cc: David Gow Signed-off-by: Mickaël Salaün --- tools/testing/kunit/kunit_kernel.py | 1 + 1 file changed, 1 insertion(+) diff --git a/tools/testing/kunit/kunit_kernel.py b/tools/testing/kunit/kunit_ke

Re: [PATCH bpf-next] bpf: Allow setting SO_TIMESTAMPING* with bpf_setsockopt()

2024-01-18 Thread Jörn-Thorben Hinz
Hmm, after taking a new look at it today, I think my patch can be disregarded---at least for having a BPF program access *RX* *hardware* timestamps. (Sorry about the noise then.) When I looked into this a few months ago, I half-blindly followed Documentation/networking/timestamping.rst, afterwards

Re: [PATCH bpf-next] bpf: Allow setting SO_TIMESTAMPING* with bpf_setsockopt()

2024-01-18 Thread Willem de Bruijn
Jörn-Thorben Hinz wrote: > On Tue, 2024-01-16 at 10:17 -0500, Willem de Bruijn wrote: > > Jörn-Thorben Hinz wrote: > > > A BPF application, e.g., a TCP congestion control, might benefit > > > from or > > > even require precise (=hardware) packet timestamps. These > > > timestamps are > > > already

Re: [PATCH v4] selftests/move_mount_set_group:Make tests build with old libc

2024-01-18 Thread Christian Brauner
On Thu, 11 Jan 2024 19:32:29 +0800, Hu Yadi wrote: > Replace SYS_ with __NR_. Using the __NR_ > notation, provided by UAPI, is useful to build tests on systems without > the SYS_ definitions. > > Replace SYS_move_mount with __NR_move_mount > > Similar changes: commit 87129ef13603 ("selftests/lan

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-18 Thread Rob Herring
On Thu, Jan 18, 2024 at 2:46 AM Geert Uytterhoeven wrote: > > Hi Rob, > > On Wed, Jan 17, 2024 at 6:41 PM Rob Herring wrote: > > On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > > > Quoting Rob Herring (2024-01-15 12:32:30) > > > > On Fri, Jan 12, 2024 at 12:07:47PM -0800, Stephen

Re: [PATCH 3/8] iommufd: Support attach/replace hwpt per pasid

2024-01-18 Thread Jason Gunthorpe
On Thu, Jan 18, 2024 at 05:28:01PM +0800, Yi Liu wrote: > On 2024/1/17 20:56, Jason Gunthorpe wrote: > > On Wed, Jan 17, 2024 at 04:24:24PM +0800, Yi Liu wrote: > > > Above indeed makes more sense if there can be concurrent > > > attach/replace/detach > > > on a single pasid. Just have one doubt s

Re: [PATCH 00/15] KVM RISC-V report more ISA extensions through ONE_REG

2024-01-18 Thread Anup Patel
On Tue, Nov 28, 2023 at 8:24 PM Anup Patel wrote: > > This extends the KVM RISC-V ONE_REG interface to report more ISA extensions > namely: Zbz, scalar crypto, vector crypto, Zfh[min], Zihintntl, Zvfh[min], > and Zfa. > > This series depends upon the "riscv: report more ISA extensions through > hw

Re: [PATCH v2 4/4] selftests/resctrl: Add non-contiguous CBMs CAT test

2024-01-18 Thread Maciej Wieczór-Retman
On 2024-01-17 at 10:49:06 -0800, Reinette Chatre wrote: >Hi Maciej, > >On 1/17/2024 12:26 AM, Maciej Wieczór-Retman wrote: >> On 2024-01-08 at 14:42:11 -0800, Reinette Chatre wrote: >>> On 12/12/2023 6:52 AM, Maciej Wieczor-Retman wrote: > > + + if (sparse_masks != ((ecx >> 3) & 1))

lsm_cgroup.c selftest fails to compile when CONFIG_PACKET!=y

2024-01-18 Thread Shung-Hsi Yu
Hi, Compilation of lsm_cgroup.c will fail if the vmlinux.h comes from a kernel that does _not_ have CONFIG_PACKET=y. The reason is that the definition of struct sockaddr_ll is not present in vmlinux.h and the compiler will complain that is has an incomplete type. CLNG-BPF [test_maps] lsm_cgro

[PATCH v1] landlock: Add support for KUnit tests

2024-01-18 Thread Mickaël Salaün
Add the SECURITY_LANDLOCK_KUNIT_TEST option to enable KUnit tests for Landlock. The minimal required configuration is listed in the security/landlock/.kunitconfig file. Add an initial landlock_fs KUnit test suite with 7 test cases for filesystem helpers. These are related to the LANDLOCK_ACCESS_

Re: [PATCH net] selftests: bonding: Add more missing config options

2024-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 16 Jan 2024 10:49:26 -0500 you wrote: > As a followup to commit 03fb8565c880 ("selftests: bonding: add missing > build configs"), add more networking-specific config options which are > needed for bonding tests. > >

Re: [PATCH bpf-next] bpf: Allow setting SO_TIMESTAMPING* with bpf_setsockopt()

2024-01-18 Thread Jörn-Thorben Hinz
On Tue, 2024-01-16 at 10:17 -0500, Willem de Bruijn wrote: > Jörn-Thorben Hinz wrote: > > A BPF application, e.g., a TCP congestion control, might benefit > > from or > > even require precise (=hardware) packet timestamps. These > > timestamps are > > already available through __sk_buff.hwtstamp an

Re: [PATCH net] selftests: netdevsim: add a config file

2024-01-18 Thread patchwork-bot+netdevbpf
Hello: This patch was applied to netdev/net.git (main) by Paolo Abeni : On Tue, 16 Jan 2024 07:43:11 -0800 you wrote: > netdevsim tests aren't very well integrated with kselftest, > which has its advantages and disadvantages. But regardless > of the intended integration - a config file to know wh

Re: [PATCH net] selftests: netdevsim: add a config file

2024-01-18 Thread Paolo Abeni
On Wed, 2024-01-17 at 07:39 -0800, Jakub Kicinski wrote: > On Wed, 17 Jan 2024 10:32:19 +0100 Paolo Abeni wrote: > > > > I think something like the following should do: > > > > cd tools/testing/selftests > > make TARGETS="net drivers/net/bonding <...full relevant targets list>" > > O= install >

[PATCH] selftests/memfd: delete unused declarations

2024-01-18 Thread Greg Thelen
Commit 32d118ad50a5 ("selftests/memfd: add tests for F_SEAL_EXEC"): - added several unused 'nbytes' local variables Commit 6469b66e3f5a ("selftests: improve vm.memfd_noexec sysctl tests"): - orphaned 'newpid_thread_fn2()' forward declaration - orphaned 'join_newpid_thread()' forward declaration -

Re: [PATCH] selftests/hid: wacom: fix confidence tests

2024-01-18 Thread Benjamin Tissoires
On Wed, 17 Jan 2024 14:27:15 +0100, Benjamin Tissoires wrote: > The device is exported with a fuzz of 4, meaning that the `+ t` here > is removed by the fuzz algorithm, making those tests failing. > > Not sure why, but when I run this locally it was passing, but not in the > VM. > > > [...] App

Re: [PATCH 3/8] iommufd: Support attach/replace hwpt per pasid

2024-01-18 Thread Yi Liu
On 2024/1/17 20:56, Jason Gunthorpe wrote: On Wed, Jan 17, 2024 at 04:24:24PM +0800, Yi Liu wrote: Above indeed makes more sense if there can be concurrent attach/replace/detach on a single pasid. Just have one doubt should we add lock to protect the whole attach/replace/detach paths. In the att

Re: [PATCH 4/6] of: Create of_root if no dtb provided by firmware

2024-01-18 Thread Geert Uytterhoeven
Hi Rob, On Wed, Jan 17, 2024 at 6:41 PM Rob Herring wrote: > On Tue, Jan 16, 2024 at 05:18:15PM -0800, Stephen Boyd wrote: > > Quoting Rob Herring (2024-01-15 12:32:30) > > > On Fri, Jan 12, 2024 at 12:07:47PM -0800, Stephen Boyd wrote: > > > > diff --git a/drivers/of/Kconfig b/drivers/of/Kconfig

Re: [PATCH] selftests/hid: wacom: fix confidence tests

2024-01-18 Thread Benjamin Tissoires
On Wed, Jan 17, 2024 at 7:12 PM Jason Gerecke wrote: > > LGTM. Acked-by: Jason Gerecke Thanks! I'll add a: Fixes: b0fb904d074e ("HID: wacom: Add additional tests of confidence behavior") And send to Linus in the next round for 6.8 so we also fix the future for-6.9 branches Cheers, Benjamin