[PATCH 1/1] selftests/mm: include mman header to access MREMAP_DONTUNMAP identifier

2023-10-11 Thread Samasth Norway Ananda
Definition for MREMAP_DONTUNMAP not present in the selftest for mremap_dontunmap thus throwing an undeclared error when running make on mm. Fixes: 0183d777c29a ("selftests: mm: remove duplicate unneeded defines") Reported-by: Linux Kernel Functional Testing Closes: https://lore.kernel.org/linux-

Re: [PATCH v3 2/2] selftests/amd-pstate: Added option to provide perf binary path

2023-10-11 Thread Swapnil Sapkal
Hello Mario, On 10/7/2023 12:29 AM, Mario Limonciello wrote: On 10/3/2023 00:10, Swapnil Sapkal wrote: In selftests/amd-pstate, distro `perf` is used to capture `perf stat` while running microbenchmarks. Distro `perf` is not working with upstream kernel. Fixed this by providing an option to giv

Re: [PATCH v3 1/2] selftests/amd-pstate: Fix broken paths to run workloads in amd-pstate-ut

2023-10-11 Thread Swapnil Sapkal
Hello Mario, Thanks for reviewing. On 10/7/2023 12:35 AM, Mario Limonciello wrote: On 10/3/2023 00:10, Swapnil Sapkal wrote: In selftests/amd-pstate, tbench and gitsource microbenchmarks are used to compare the performance with different governors. In Current s/Current/current/ I will fix

Re: [RFC v3 0/2] CPU-Idle latency selftest framework

2023-10-11 Thread Aboorva Devarajan
On Mon, 2023-09-25 at 10:36 +0530, Aboorva Devarajan wrote: Gentle ping to check if there are any feedback or comments on this patch-set. Thanks Aboorva > On Mon, 2023-09-11 at 11:06 +0530, Aboorva Devarajan wrote: > > CC'ing CPUidle lists and maintainers, > > Patch Summary: > > The patchset

Re: [PATCH v6] selftests/clone3: Fix broken test under !CONFIG_TIME_NS

2023-10-11 Thread Tiezhu Yang
Cc: Andrew Morton On 08/17/2023 03:22 PM, Tiezhu Yang wrote: Hi Shuah, On 07/11/2023 05:13 PM, Tiezhu Yang wrote: When execute the following command to test clone3 under !CONFIG_TIME_NS: # make headers && cd tools/testing/selftests/clone3 && make && ./clone3 we can see the following error

Re: [PATCH v2 0/2] Modify vDSO selftests

2023-10-11 Thread Tiezhu Yang
Cc: Andrew Morton On 08/17/2023 03:20 PM, Tiezhu Yang wrote: Hi Shuah, On 07/11/2023 05:57 PM, Tiezhu Yang wrote: v2: Rebase on 6.5-rc1 and update the commit message Tiezhu Yang (2): selftests/vDSO: Add support for LoongArch selftests/vDSO: Get version and name for all archs tools/test

[PATCH net v2 4/4] selftests: openvswitch: Fix the ct_tuple for v4

2023-10-11 Thread Aaron Conole
The ct_tuple v4 data structure decode / encode routines were using the v6 IP address decode and relying on default encode. This could cause exceptions during encode / decode depending on how a ct4 tuple would appear in a netlink message. Caught during code review. Fixes: e52b07aa1a54 ("selftests:

[PATCH net v2 3/4] selftests: openvswitch: Skip drop testing on older kernels

2023-10-11 Thread Aaron Conole
Kernels that don't have support for openvswitch drop reasons also won't have the drop counter reasons, so we should skip the test completely. It previously wasn't possible to build a test case for this without polluting the datapath, so we introduce a mechanism to clear all the flows from a datapa

[PATCH net v2 1/4] selftests: openvswitch: Add version check for pyroute2

2023-10-11 Thread Aaron Conole
Paolo Abeni reports that on some systems the pyroute2 version isn't new enough to run the test suite. Ensure that we support a minimum version of 0.6 for all cases (which does include the existing ones). The 0.6.1 version was released in May of 2021, so should be propagated to most installations a

[PATCH net v2 0/4] selftests: openvswitch: Minor fixes for some systems

2023-10-11 Thread Aaron Conole
A number of corner cases were caught when trying to run the selftests on older systems. Missed skip conditions, some error cases, and outdated python setups would all report failures but the issue would actually be related to some other condition rather than the selftest suite. Address these indi

[PATCH net v2 2/4] selftests: openvswitch: Catch cases where the tests are killed

2023-10-11 Thread Aaron Conole
In case of fatal signal, or early abort at least cleanup the current test case. Fixes: 25f16c873fb1 ("selftests: add openvswitch selftest suite") Signed-off-by: Aaron Conole --- tools/testing/selftests/net/openvswitch/openvswitch.sh | 2 ++ 1 file changed, 2 insertions(+) diff --git a/tools/tes

Re: [PATCH v5 1/8] selftests: Add printf attribute to kselftest prints

2023-10-11 Thread Shuah
On 10/11/23 02:23, Maciej Wieczor-Retman wrote: Kselftest header defines multiple variadic functions that use printf along with other logic. There is no format checking for the variadic functions that use printing inside kselftest.h. Because of this the compiler won't be able to catch instances

Re: [PATCH 1/1] selftests: KVM: add test to print boottime wallclock

2023-10-11 Thread Maxim Levitsky
У вт, 2023-10-10 у 09:31 -0700, Dongli Zhang пише: > Hi Maxim, > > On 10/10/23 09:13, Maxim Levitsky wrote: > > У пт, 2023-10-06 у 10:57 -0700, Dongli Zhang пише: > > > As inspired by the discussion in [1], the boottime wallclock may drift due > > > to the fact that the masterclock (or host monoto

Re: [PATCH v3 0/3] selftests/hid: assorted fixes

2023-10-11 Thread Benjamin Tissoires
On Thu, 05 Oct 2023 17:55:31 +0200, Benjamin Tissoires wrote: > And this is the last(?) revision of this series which should now compile > with or without CONFIG_HID_BPF set. > > I had to do changes because [1] was failing > > Nick, I kept your Tested-by, even if I made small changes in 1/3. Feel

Re: [PATCH net 4/4] selftests: openvswitch: Fix the ct_tuple for v4

2023-10-11 Thread Aaron Conole
Paolo Abeni writes: > On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: >> Caught during code review. > > Since there are a few other small things, please additionally expand > this changelog briefly describing the addressed problem and it's > consequences. ACK. will fix in v2. Thanks Pao

Re: [PATCH net 3/4] selftests: openvswitch: Skip drop testing on older kernels

2023-10-11 Thread Aaron Conole
Paolo Abeni writes: > On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: >> Kernels that don't have support for openvswitch drop reasons also >> won't have the drop counter reasons, so we should skip the test >> completely. It previously wasn't possible to build a test case >> for this witho

Re: [PATCH net 1/4] selftests: openvswitch: Add version check for pyroute2

2023-10-11 Thread Aaron Conole
Paolo Abeni writes: > On Fri, 2023-10-06 at 11:12 -0400, Aaron Conole wrote: >> Paolo Abeni reports that on some systems the pyroute2 version isn't >> new enough to run the test suite. Ensure that we support a minimum >> version of 0.6 for all cases (which does include the existing ones). >> The

[PATCH v5 8/8] selftests/resctrl: Fix wrong format specifier

2023-10-11 Thread Maciej Wieczor-Retman
A long unsigned int variable is passed to the ksft_print_msg() and the format specifier used expects a variable of type int. Change the format specifier to match the passed variable. Signed-off-by: Maciej Wieczor-Retman Reviewed-by: Ilpo Järvinen Reviewed-by: Reinette Chatre --- Changelog v4:

[PATCH v5 7/8] selftests/mm: Substitute attribute with a macro

2023-10-11 Thread Maciej Wieczor-Retman
The mm selftest uses the printf attribute in its full form. Since the header file that uses it also includes kselftests.h it can use the macro defined there. Use __printf() included with kselftests.h instead of the full attribute. Fix a wrong format specifier in ksft_print_msg(). Signed-off-by:

[PATCH v5 6/8] selftests/kvm: Replace attribute with macro

2023-10-11 Thread Maciej Wieczor-Retman
The __printf() macro is used in many tools in the linux kernel to validate the format specifiers in functions that use printf. The kvm selftest uses it without putting it in a macro definition while it also imports the kselftests.h header. Use __printf() from kselftests.h instead of the full attri

[PATCH v5 5/8] selftests/sigaltstack: Fix wrong format specifier

2023-10-11 Thread Maciej Wieczor-Retman
The format specifier inside ksft printing function expects a long unsigned int but the passed variable is of unsigned int type. Fix the format specifier so it matches the passed variable. Signed-off-by: Maciej Wieczor-Retman Reviewed-by: Ilpo Järvinen --- Changelog v2: - Added Reviewed-by tag (

[PATCH v5 4/8] selftests/pidfd: Fix ksft print formats

2023-10-11 Thread Maciej Wieczor-Retman
Many calls to ksft print functions have format strings that don't match with other passed arguments. One call expects a string but doesn't provide any argument after the format string. Fix format specifiers so they match the passed variables. Add a missing variable to ksft_test_result_pass() insi

[PATCH v5 3/8] selftests/openat2: Fix wrong format specifier

2023-10-11 Thread Maciej Wieczor-Retman
Ksft_print_msg() inside test_openat2_flags() uses the wrong format specifier for printing test.how->flags variable. Change the format specifier to %llX so it matches the printed variable. Signed-off-by: Maciej Wieczor-Retman Reviewed-by: Ilpo Järvinen --- Changelog v2: - Added Reviewed-by tag (

[PATCH v5 2/8] selftests/cachestat: Fix print_cachestat format

2023-10-11 Thread Maciej Wieczor-Retman
The format specifier in printf() call expects long int variables and received long long int. Change format specifiers to long long int so they match passed variables. Signed-off-by: Maciej Wieczor-Retman Acked-by: Nhat Pham --- Changelog v2: - Added Acked-by tag (Nhat) tools/testing/selftests

[PATCH v5 1/8] selftests: Add printf attribute to kselftest prints

2023-10-11 Thread Maciej Wieczor-Retman
Kselftest header defines multiple variadic functions that use printf along with other logic. There is no format checking for the variadic functions that use printing inside kselftest.h. Because of this the compiler won't be able to catch instances of mismatched printf formats and debugging tests m

[PATCH v5 0/8] Add printf attribute to kselftest functions

2023-10-11 Thread Maciej Wieczor-Retman
kselftest.h declares many variadic functions that can print some formatted message while also executing selftest logic. These declarations don't have any compiler mechanism to verify if passed arguments are valid in comparison with format specifiers used in printf() calls. Attribute addition can m