It's more clear to use FIELD_SIZEOF instead of its implementation.
Signed-off-by: zhong jiang
---
net/batman-adv/distributed-arp-table.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/net/batman-adv/distributed-arp-table.c
b/net/batman-adv/distributed-arp-table.c
It's more clear to use FIELD_SIZEOF instead of its implementation.
Signed-off-by: zhong jiang
---
drivers/media/v4l2-core/v4l2-ioctl.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-ioctl.c
b/drivers/media/v4l2-core/v4l2-ioctl.c
index 51
It's more clear to use FIELD_SIZEOF instead of its implementation.
Signed-off-by: zhong jiang
---
drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/infiniband/hw/mlx5/mlx5_ib.h
b/drivers/infiniband/hw/mlx5/mlx5_ib.h
index c3
FIELD_SIZEOF() has implemented sizeof(). Hence use FIELD_SIZEOF
directly.
zhong jiang (3):
batman-adv: Use FIELD_SIZEOF directly
media: v4l2: Use FIELD_SIZEOF directly
IB/mlx5: Use FIELD_SIZEOF directly
drivers/infiniband/hw/mlx5/mlx5_ib.h | 2 +-
drivers/media/v4l2-core/v4l2-ioctl.c
On 2019/9/5 21:45, Kalle Valo wrote:
> zhong jiang writes:
>
>> Please ignore the patch. Because the hostap_proc.c is marked as 'obsolete'.
> You mean marked in the MAINTAINERS file? I don't see that as a problem,
> I can (and should) still apply any patches sub
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/micrel/ksz884x.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/micrel/ksz884x.c
b/drivers/net
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/usb/uvc/uvc_ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c
b
With the following help of Coccinelle. I find out some place can be replaced.
-(((x) + ((__divisor) / 2)) / (__divisor))
+ DIV_ROUND_CLOSEST(x,__divisor)
zhong jiang (4):
media: dvb-frontends: Use DIV_ROUND_CLOSEST directly to make it
readable
media: tuners/qm1d1c0042: Use
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/dvb-frontends/mt312.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/dvb-frontends/mt312.c
b/drivers/media/dvb
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/tuners/qm1d1c0042.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/qm1d1c0042.c
b/drivers/media/tuners
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
.../net/wireless/broadcom/brcm80211/brcmsmac/phy/phy_n.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/net
lbs_process_event do not need return value to cope with different
cases. And change functon return type to void.
Signed-off-by: zhong jiang
---
drivers/net/wireless/marvell/libertas/cmd.h | 2 +-
drivers/net/wireless/marvell/libertas/cmdresp.c | 5 +
2 files changed, 2 insertions(+), 5
brcms_c_set_mac do not need return value to cope with different
cases. And change functon return type to void.
Signed-off-by: zhong jiang
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/main.c | 5 +
1 file changed, 1 insertion(+), 4 deletions(-)
diff --git a/drivers/net/wireless
il4965_set_tkip_dynamic_key_info do not need return value to
cope with different ases. And change functon return type to void.
Signed-off-by: zhong jiang
---
drivers/net/wireless/intel/iwlegacy/4965-mac.c | 8 ++--
1 file changed, 2 insertions(+), 6 deletions(-)
diff --git a/drivers/net
With the help of Coccinelle, I find some place to use redundant
variable to store the return value, It is unnecessary. Just remove
it and make the funtion to be void.
zhong jiang (3):
brcmsmac: Remove unneeded variable and make function to be void
wlegacy: Remove unneeded variable and make
mlx5_unload_one do not need local variable to store different value,
Hence just remove it.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/mellanox/mlx5/core/main.c | 4 +---
1 file changed, 1 insertion(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/mellanox/mlx5/core/main.c
b
st_tty_open do not need local variable to store different value,
Hence just remove it.
Signed-off-by: zhong jiang
---
drivers/misc/ti-st/st_core.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/misc/ti-st/st_core.c b/drivers/misc/ti-st/st_core.c
index 7d9e23a
rts5260_card_power_on do not need local variable to store different value,
Hence just remove it.
Signed-off-by: zhong jiang
---
drivers/misc/cardreader/rts5260.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/misc/cardreader/rts5260.c
b/drivers/misc/cardreader
On 2019/9/13 1:45, Kalle Valo wrote:
> zhong jiang writes:
>
>> il4965_set_tkip_dynamic_key_info do not need return value to
>> cope with different ases. And change functon return type to void.
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/
On 2019/9/17 10:45, Jakub Kicinski wrote:
> On Wed, 4 Sep 2019 11:46:23 +0800, zhong jiang wrote:
>> Continue is not needed at the bottom of a loop.
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/net/ethernet/netronome/nfp/nfp_net_main.c | 4 +---
>
On 2019/9/17 10:43, Jakub Kicinski wrote:
> On Wed, 4 Sep 2019 10:39:10 +0800, zhong jiang wrote:
>> Use kzfree() instead of memset() + kfree().
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 9 +++--
>&
It's better to use memset_explicit() to replace memset() in crypto cases.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
b/driver
On 2019/9/17 17:59, Sergei Shtylyov wrote:
> Hello!
>
> On 17.09.2019 6:45, zhong jiang wrote:
>
>> It's better to use memset_explicit() to replace memset() in crypto cases.
>
>But you're using memzero_explicit() below?
Sorry, stupid Oops. I will repost. T
It's better to use memzero_explicit() to replace memset() in crypto cases.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c
b/driver
On 2019/9/18 2:11, Jakub Kicinski wrote:
> On Tue, 17 Sep 2019 22:44:22 +0800, zhong jiang wrote:
>> It's better to use memzero_explicit() to replace memset() in crypto cases.
>>
>> Signed-off-by: zhong jiang
> Thank you for the follow up! Your previous patch to use
In general, Use kzfree() to replace memset() + kfree() is feasible and
resonable. But It's btter to use memzero_explicit() to replace memset()
in crypto cases.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 9 ++---
1 file changed, 6 insertions(
In general, Use kzfree() to replace memset() + kfree() is feasible and
resonable. But It's better to use memzero_explicit() to replace memset()
in crypto cases.
Signed-off-by: zhong jiang
---
drivers/net/ethernet/intel/ixgbe/ixgbe_ipsec.c | 9 ++---
1 file changed, 6 insertions(
On 2019/9/18 10:36, zhong jiang wrote:
> In general, Use kzfree() to replace memset() + kfree() is feasible and
> resonable. But It's btter to use memzero_explicit() to replace memset()
> in crypto cases.
s/btter/better/, will repost. sorry for that.
Thanks,
zhong jiang
> Sig
On 2019/10/1 19:15, Sean Young wrote:
> Hi,
>
> On Fri, Sep 06, 2019 at 12:14:49AM +0800, zhong jiang wrote:
>> The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
>> but is perhaps more readable.
>>
>> Signed-off-by: zhong jiang
>> --
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/tuners/qm1d1c0042.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/tuners/qm1d1c0042.c
b/drivers/media/tuners
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/dvb-frontends/mt312.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/media/dvb-frontends/mt312.c
b
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/usb/uvc/uvc_ctrl.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/media/usb/uvc/uvc_ctrl.c b/drivers/media/usb
The kernel.h macro DIV_ROUND_CLOSEST performs the computation (x + d/2)/d
but is perhaps more readable.
Signed-off-by: zhong jiang
---
drivers/media/v4l2-core/v4l2-dv-timings.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/media/v4l2-core/v4l2-dv-timings.c
b
With the help of Coccinelle. I find some place that DIV_ROUND_CLOSEST
can replace it directly.
v1->v2:
patch 1: remove mt312_div() to use the DIV_ROUND_CLOSEST directly.
zhong jiang (4):
media: dvb-frontends: Use DIV_ROUND_CLOSEST directly to make it
readable
media: tuners/qm1d1c0
I hit the following error when compile the kernel.
drivers/iio/light/noa1305.o: In function `noa1305_probe':
noa1305.c:(.text+0x65): undefined reference to `__devm_regmap_init_i2c'
make: *** [vmlinux] Error 1
Signed-off-by: zhong jiang
---
drivers/iio/light/Kconfig | 1 +
1 file
r each function it appears in
Signed-off-by: zhong jiang
---
security/smack/smack.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/security/smack/smack.h b/security/smack/smack.h
index 62529f3..02b05a2 100644
--- a/security/smack/smack.h
+++ b/security/smack/smack.h
@@ -21,6 +21,7 @@
#i
CC sound/soc/sof/debug.o
drivers/firmware/broadcom/bcm47xx_nvram.c:151:30: note: format string is
defined here
pr_err("nvram on flash (%zu bytes) is bigger than the reserved space in
memory, will just copy the first %i bytes\n",
Signed-off-by: zhong jiang
---
drivers/firmware
`sdio_unregister_driver'
Signed-off-by: zhong jiang
---
drivers/staging/wfx/Kconfig | 3 ++-
drivers/staging/wfx/Makefile | 5 +++--
2 files changed, 5 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/wfx/Kconfig b/drivers/staging/wfx/Kconfig
index 9b8a1c7..4d045513 100644
--- a/dri
On 2019/10/11 12:26, Greg KH wrote:
> On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote:
>> I hit the following error when compile the kernel.
>>
>> drivers/staging/wfx/main.o: In function `wfx_core_init':
>> /home/z00352263/linux-next/linux-nex
ging/wfx/main.c:496: undefined
reference to `sdio_unregister_driver'
drivers/staging/wfx/main.o:(.debug_addr+0x1a8): undefined reference to
`sdio_register_driver'
drivers/staging/wfx/main.o:(.debug_addr+0x6f0): undefined reference to
`sdio_unregister_driver'
Signed-off-by: zhong j
unless you recognize the sender and know the
>> content is safe.
>>>
>>> On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote:
>>>> I hit the following error when compile the kernel.
>>>>
>>>> drivers/staging/wfx/main.o: In func
unless you recognize the sender and know the
>> content is safe.
>>>
>>> On Fri, Oct 11, 2019 at 11:02:19AM +0800, zhong jiang wrote:
>>>> I hit the following error when compile the kernel.
>>>>
>>>> drivers/staging/wfx/main.o: In func
On 2019/10/11 23:55, Jerome Pouiller wrote:
> On Friday 11 October 2019 17:51:29 CEST zhong jiang wrote:
> [...]
>> How about the following patch ?
>>
>> diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile
>> index 0d9c1ed..77d68b7 100644
>>
On 2019/10/12 0:16, Greg KH wrote:
> On Fri, Oct 11, 2019 at 11:51:16PM +0800, zhong jiang wrote:
>> On 2019/10/11 17:02, Greg KH wrote:
>>> On Fri, Oct 11, 2019 at 08:40:08AM +, Jerome Pouiller wrote:
>>>> On Friday 11 October 2019 06:26:16 CEST Greg KH wr
`sdio_unregister_driver'
Signed-off-by: zhong jiang
---
drivers/staging/wfx/Makefile | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/wfx/Makefile b/drivers/staging/wfx/Makefile
index 0d9c1ed..77d68b7 100644
--- a/drivers/staging/wfx/Makefile
+++ b/drivers
On 2019/10/12 1:03, Greg KH wrote:
> On Sat, Oct 12, 2019 at 12:34:07AM +0800, zhong jiang wrote:
>> I hit the following error when compile the kernel.
>>
>> drivers/staging/wfx/main.o: In function `wfx_core_init':
>> /home/z00352263/linux-next/linux-nex
`sdio_unregister_driver'
Signed-off-by: zhong jiang
---
v2->v3:
We'd better not use #ifdef in .c file to use IS_ENABLED instead.
v1->v2:
We should prefer to current dependencies rather than force to enable.
drivers/staging/wfx/Makefile | 2 +-
1 file changed, 1 insertio
On 2019/10/12 23:32, Greg KH wrote:
> On Sat, Oct 12, 2019 at 06:54:53PM +0800, zhong jiang wrote:
>> I hit the following error when compile the kernel.
>>
>> drivers/staging/wfx/main.o: In function `wfx_core_init':
>> /home/z00352263/linux-next/linux-nex
tate "Silicon Labs wireless chips WF200 and further"
> depends on MAC80211
> + depends on MMC || !MMC # do not allow WFX=y if MMC=m
> depends on (SPI || MMC)
> help
> This is a driver for Silicons Labs WFxxx series (WF200 and further)
>
>
It's better and clear. Thanks
sincerely,
zhong jiang
kfree() has taken null pointer into account. hence it is safe to remove
the unnecessary check.
Signed-off-by: zhong jiang
---
drivers/staging/rtl8723bs/core/rtw_xmit.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/drivers/staging/rtl8723bs/core/rtw_xmit.c
b/drivers
On 2019/10/17 8:49, Andrew Morton wrote:
> On Wed, 16 Oct 2019 17:07:44 +0800 zhong jiang wrote:
>
>>>> --- a/mm/gup.c~a
>>>> +++ a/mm/gup.c
>>>> @@ -1450,6 +1450,7 @@ static long check_and_migrate_cma_pages(
>>>> bool dr
tate "Silicon Labs wireless chips WF200 and further"
> depends on MAC80211
> + depends on MMC || !MMC # do not allow WFX=y if MMC=m
> depends on (SPI || MMC)
> help
> This is a driver for Silicons Labs WFxxx series (WF200 and further)
>
>
Hi, Jerome
It's better to understandable.
Could you send the patch or want to repost by me?
Thanks,
zhong jiang
The GCC complains the following case when compiling kernel.
drivers/power/supply/cpcap-charger.c:563:5: warning: symbol
'cpcap_charger_voltage_to_regval' was not declared. Should it be static?
Signed-off-by: zhong jiang
---
drivers/power/supply/cpcap-charger.c | 2 +-
1 file
plify rebinding mempolicies when
updating cpusets")
Signed-off-by: zhong jiang
---
mm/mempolicy.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index e3ab1d9..a60a3be 100644
--- a/mm/mempolicy.c
+++ b/mm/mempolicy.c
@@ -345,7 +
On 2019/5/27 20:23, Vlastimil Babka wrote:
> On 5/25/19 8:28 PM, Andrew Morton wrote:
>> (Cc Vlastimil)
> Oh dear, 2 years and I forgot all the details about how this works.
>
>> On Sat, 25 May 2019 15:07:23 +0800 zhong jiang wrote:
>>
>>> We bind an differ
hould drop out in time when fails to take the device_hotplug_lock.
Fixes: 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the
device_hotplug_lock")
Reported-by: Yang yingliang
Signed-off-by: zhong jiang
---
drivers/base/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
hould drop out in time when fails to take the device_hotplug_lock.
Fixes: 8df1d0e4a265 ("mm/memory_hotplug: make add_memory() take the
device_hotplug_lock")
Reported-by: Yang yingliang
Signed-off-by: zhong jiang
---
drivers/base/memory.c | 2 +-
1 file changed, 1 insertion(+), 1 delet
I am sorry, It is incorrect. please ignore the patch. I will resent it.
Thanks,
zhong jiang
On 2019/4/8 12:00, zhong jiang wrote:
> When adding the memory by probing memory block in sysfs interface, there is an
> obvious issue that we will unlock the device_hotplug_lock when fails to
Thanks,
zhong jiang
On 2018/12/4 23:43, syzbot wrote:
> syzbot has found a reproducer for the following crash on:
>
> HEAD commit:0072a0c14d5b Merge tag 'media/v4.20-4' of git://git.kernel..
> git tree: upstream
> console output: https://syzkaller.appspot.com/x/lo
On 2019/3/4 15:40, Dmitry Vyukov wrote:
> On Sun, Mar 3, 2019 at 5:19 PM zhong jiang wrote:
>> Hi, guys
>>
>> I also hit the following issue. but it fails to reproduce the issue by the
>> log.
>>
>> it seems to the case that we access the mm->owner a
On 2019/3/4 22:11, Dmitry Vyukov wrote:
> On Mon, Mar 4, 2019 at 3:00 PM zhong jiang wrote:
>> On 2019/3/4 15:40, Dmitry Vyukov wrote:
>>> On Sun, Mar 3, 2019 at 5:19 PM zhong jiang wrote:
>>>> Hi, guys
>>>>
>>>> I also hit the follo
On 2019/3/5 5:51, Matthew Wilcox wrote:
> On Mon, Mar 04, 2019 at 12:19:32AM +0800, zhong jiang wrote:
>> I also hit the following issue. but it fails to reproduce the issue by the
>> log.
>>
>> it seems to the case that we access the mm->owner and deference it will
On 2019/3/5 14:26, Dmitry Vyukov wrote:
> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>> On 2019/3/4 22:11, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 3:00 PM zhong jiang wrote:
>>>> On 2019/3/4 15:40, Dmitry Vyukov wrote:
>>>>> On S
On 2019/3/6 10:05, Andrea Arcangeli wrote:
> Hello everyone,
>
> [ CC'ed Mike and Peter ]
>
> On Tue, Mar 05, 2019 at 02:42:00PM +0800, zhong jiang wrote:
>> On 2019/3/5 14:26, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>>
On 2019/3/6 14:26, Mike Rapoport wrote:
> Hi,
>
> On Wed, Mar 06, 2019 at 01:53:12PM +0800, zhong jiang wrote:
>> On 2019/3/6 10:05, Andrea Arcangeli wrote:
>>> Hello everyone,
>>>
>>> [ CC'ed Mike and Peter ]
>>>
>>> On Tue, Mar 05,
On 2019/3/6 16:12, Peter Xu wrote:
> On Wed, Mar 06, 2019 at 03:41:06PM +0800, zhong jiang wrote:
>> On 2019/3/6 14:26, Mike Rapoport wrote:
>>> Hi,
>>>
>>> On Wed, Mar 06, 2019 at 01:53:12PM +0800, zhong jiang wrote:
>>>> On 2019/3/6 10:
On 2019/3/7 2:29, Andrea Arcangeli wrote:
> Hello Zhong,
>
> On Wed, Mar 06, 2019 at 09:07:00PM +0800, zhong jiang wrote:
>> The patch use call_rcu to delay free the task_struct, but It is possible to
>> free the task_struct
>> ahead of get_mem_cgroup_from_mm. is it rig
On 2019/3/6 10:05, Andrea Arcangeli wrote:
> Hello everyone,
>
> [ CC'ed Mike and Peter ]
>
> On Tue, Mar 05, 2019 at 02:42:00PM +0800, zhong jiang wrote:
>> On 2019/3/5 14:26, Dmitry Vyukov wrote:
>>> On Mon, Mar 4, 2019 at 4:32 PM zhong jiang wrote:
>>
platform_driver_register will set the .owner field. So it is safe
to remove the redundant assignment.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
drivers/staging/greybus/audio_codec.c| 1 -
drivers/staging/mt7621-eth/gsw_mt7621.c | 1 -
drivers
platform_driver_register will set the .owner field. So it is safe
to remove the redundant assignment.
The issue is detected with the help of Coccinelle.
Signed-off-by: zhong jiang
---
sound/soc/mediatek/mt2701/mt2701-wm8960.c | 1 -
sound/soc/mediatek/mt6797/mt6797-mt6351.c | 1 -
sound/soc
debugfs_remove_recursive has taken IS_ERR_OR_NULL into account. So just
remove the condition check before debugfs_remove_recursive.
Signed-off-by: zhong jiang
---
drivers/net/wireless/broadcom/brcm80211/brcmsmac/debug.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a
On 2018/9/4 0:59, Will Deacon wrote:
> On Thu, Aug 09, 2018 at 10:20:39PM +0800, zhong jiang wrote:
>> There are some extra semicolon in arm64 architecture. Just remove them.
> These are trivial but certainly not urgent, so I guess Catalin can pick
> them up for 4.20.
Thanks,
C
Fix the following compile warning:
rch/x86/kernel/cpu/common.c: In function 'syscall_init':
arch/x86/kernel/cpu/common.c:1534:6: warning: unused variable 'cpu'
[-Wunused-variable]
int cpu = smp_processor_id();
Signed-off-by: zhong jiang
---
arch/x86/kernel/cpu/common
ier = multiplier;
Signed-off-by: zhong jiang
---
drivers/hid/hid-logitech-hidpp.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/hid/hid-logitech-hidpp.c b/drivers/hid/hid-logitech-hidpp.c
index 5f0c080..83c43dd 100644
--- a/drivers/hid/hid-logitech-hidpp.c
+++ b/drivers/
On 2018/9/13 15:01, Benjamin Tissoires wrote:
> On Thu, Sep 13, 2018 at 6:04 AM zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/hid/hid-logitech-hidpp.c: In function ‘hi_res_scroll_enable’:
>> drivers/hid/hid-logitech-hidpp.c:2714:54: warnin
r.resolution_multiplier = multiplier;
Signed-off-by: zhong jiang
---
v1->v2:
According to Benjamin's suggestion, To initialize the value
and remove the duplicated assignement.
drivers/hid/hid-logitech-hidpp.c | 8 +++-
1 file changed, 3 insertions(+), 5 deletions(-)
diff --git a/dri
Fix the following compile warning:
kernel/sched/core.c: In function update_rq_clock_task:
kernel/sched/core.c:139:6: warning: unused variable steal [-Wunused-variable]
s64 steal = 0, irq_delta = 0;
Signed-off-by: zhong jiang
---
kernel/sched/core.c | 2 +-
1 file changed, 1 insertion
match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.
Signed-off-by: zhong jiang
---
drivers/gpu/drm/i2c/ch7006_drv.c | 14 +-
1 file changed, 5 insertions(+), 9 deletions(-)
diff --git a/drivers/gpu/drm/i2c
match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.
Signed-off-by: zhong jiang
---
drivers/bus/fsl-mc/fsl-mc-allocator.c | 14 +++---
1 file changed, 7 insertions(+), 7 deletions(-)
diff --git a/drivers/bus/fsl-mc
match_string() returns the index of an array for a matching string,
which can be used instead of open coded implementation.
Signed-off-by: zhong jiang
---
arch/arm/plat-orion/common.c | 11 ---
1 file changed, 4 insertions(+), 7 deletions(-)
diff --git a/arch/arm/plat-orion/common.c b
On 2018/9/15 0:43, Miguel Ojeda wrote:
> Hi Zhong,
>
> On Fri, Sep 14, 2018 at 4:49 PM, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> kernel/sched/core.c: In function ‘update_rq_clock_task’:
>> kernel/sched/core.c:139:6: warning: unused variab
match_string() returns the index of an array for a matching string,
which can be used intead of open coded implementation.
Signed-off-by: zhong jiang
---
mm/mempolicy.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/mm/mempolicy.c b/mm/mempolicy.c
index 2e76a8f
us a note to
> help improve the system]
>
> url:
> https://github.com/0day-ci/linux/commits/zhong-jiang/arm-common-use-match_string-helper-to-simplify-the-code/20180915-035510
> base: https://git.kernel.org/pub/scm/linux/kernel/git/arm/arm-soc.git
> for-next
> config: a
On 2018/9/22 0:22, Mark Brown wrote:
> On Fri, Sep 21, 2018 at 06:24:58PM +0800, zhong jiang wrote:
>> We include wait.h twice in q6adm.c. it is unnecessary. hence remove
>> it. Further, order the include files as alphabet.
> Please use subject lines matching the style for th
On 2018/9/26 2:20, Greg KH wrote:
> On Thu, Sep 20, 2018 at 01:04:02PM +0800, zhong jiang wrote:
>> delay.h and dma-mapping.h have duplicated include. hence just remove
>> redundant file.
>>
>> Signed-off-by: zhong jiang
>> ---
>> drivers/misc/genwqe/ca
dma-mapping.h and delay.h have included twice. It is unnecessary. Meanwhile,
Arrange header files in alphabetical sequence to improve readability.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff
+to maintainers
On 2018/8/18 18:49, zhong jiang wrote:
> debugfs_remove has taken null pointer into account. So it is safe
> to remove the check before debugfs_remove.
>
> Signed-off-by: zhong jiang
> ---
> drivers/acpi/custom_method.c | 3 +--
> 1 file changed, 1 inse
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong j
On 2018/9/30 10:17, Joe Perches wrote:
> On Sun, 2018-09-30 at 09:45 +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
>> but not used [-Wunused-function]
>>
Fix the following compile warning:
sound/soc/codecs/wm8731.c:575:12: warning: 'wm8731_request_supplies' defined
but not used [-Wunused-function]
sound/soc/codecs/wm8731.c:600:12: warning: 'wm8731_hw_init' defined but not
used [-Wunused-function]
Signed-off-by: zhong jiang
Kim
Cc: # 4.4.x
Signed-off-by: Andrew Morton
Signed-off-by: Linus Torvalds
Signed-off-by: zhong jiang
---
include/linux/slub_def.h | 3 ++-
mm/slub.c| 6 +++---
2 files changed, 5 insertions(+), 4 deletions(-)
diff --git a/include/linux/slub_def.h b/include/linux/slub_def
I find the following warning when compiling the kernel.
kernel/sched/psi.c:639:13: warning: 'rq' may be used uninitialized in this
function [-Wmaybe-uninitialized]
struct rq *rq;
Signed-off-by: zhong jiang
---
kernel/sched/psi.c | 2 +-
1 file changed, 1 insertion(+), 1 deletio
his function [-Wmaybe-uninitialized]
return ret < 0 ? 0 : le16_to_cpu(ent.len);
drivers/soc/qcom/cmd-db.c:269:24: warning: ent.addr may be used uninitialized
in this function [-Wmaybe-uninitialized]
addr = le32_to_cpu(ent.addr);
Signed-off-by: zhong jiang
---
drivers/soc/qcom/cmd-db
On 2018/9/19 16:47, Maxime Ripard wrote:
> On Tue, Sep 18, 2018 at 03:25:20PM +0800, zhong jiang wrote:
>> Fix the following compile warning:
>>
>> drivers/gpu/drm/sun4i/sun4i_tcon.c:1088: warning: 'has_lvds_alt' may be used
>> uninitialized in this fun
On 2018/9/19 17:52, zhong jiang wrote:
> FIELD_SIZEOF is defined as a macro to calculate the specified vaule.
> Therefore,
> We prefer to use the macro rather than calculating its vaule.
s/vaule/value . will resend .
Thanks,
zhong jiang
> Signed-off-by: zhong jiang
>
The function should return -EFAULT when copy_from_user fails. Even
though the caller does not distinguish them. but we should keep backward
compatibility.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 13 +++--
1 file changed, 7 insertions(+), 6 deletions(-)
diff
delay.h and dma-mapping.h have duplicated include. hence just remove
redundant file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_utils.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_utils.c b/drivers/misc/genwqe/card_utils.c
index f0961ec..3fcb9a2
module.h has duplicated include. hence just remove
redundant include file.
Signed-off-by: zhong jiang
---
drivers/misc/genwqe/card_base.c | 1 -
drivers/misc/genwqe/card_ddcb.c | 1 -
2 files changed, 2 deletions(-)
diff --git a/drivers/misc/genwqe/card_base.c b/drivers/misc/genwqe/card_base.c
kfree_skb has taken the null pointer into account. hence it is safe
to remove the redundant null pointer check before kfree_skb.
Signed-off-by: zhong jiang
---
drivers/infiniband/hw/cxgb4/cm.c | 3 +--
drivers/infiniband/hw/cxgb4/qp.c | 3 +--
2 files changed, 2 insertions(+), 4 deletions
201 - 300 of 437 matches
Mail list logo