Re: [PATCH 2/2] dma: k3dma: use devm_ioremap_resource() instead of devm_request_and_ioremap()

2013-09-01 Thread zhangfei
On 13-09-02 09:26 AM, Jingoo Han wrote: Use devm_ioremap_resource() because devm_request_and_ioremap() is obsoleted by devm_ioremap_resource(). Signed-off-by: Jingoo Han Thanks Jingoo for point out. Acked-by: Zhangfei Gao --- drivers/dma/k3dma.c |6 +++--- 1 file changed, 3

Re: [PATCH 6/7] k3dma: Fix occasional DMA ERR issue by using proper dma api

2016-07-20 Thread zhangfei
On 07/21/2016 11:53 AM, John Stultz wrote: After lots of debugging on an occasional DMA ERR issue, I realized that the desc structures which we point the dma hardware are being allocated out of regular memory. This means when we fill the desc structures, that data doesn't always get flushed out

Re: [PATCH 6/7] k3dma: Fix occasional DMA ERR issue by using proper dma api

2016-07-21 Thread zhangfei
On 07/21/2016 01:22 PM, John Stultz wrote: On Wed, Jul 20, 2016 at 9:26 PM, zhangfei wrote: On 07/21/2016 11:53 AM, John Stultz wrote: After lots of debugging on an occasional DMA ERR issue, I realized that the desc structures which we point the dma hardware are being allocated out of

Re: [PATCH] dmaengine: k3dma: fix off by one

2016-09-21 Thread zhangfei
On 2016年09月22日 04:16, Vincent Stehlé wrote: In k3_of_dma_simple_xlate(), the d->chans[] array has d->dma_requests elements so > should be >=. Fixes: 8e6152bc660e69f5 ("dmaengine: Add hisilicon k3 DMA engine driver") Signed-off-by: Vincent Stehlé Cc: Zhangfei Gao C

Re: [PATCH 09/10] dmaengine: k3dma: Use vchan_terminate_vdesc() instead of desc_free

2017-11-14 Thread zhangfei
On 2017年11月14日 22:32, Peter Ujfalusi wrote: To avoid race with vchan_complete, use the race free way to terminate running transfer. Implement the device_synchronize callback to make sure that the terminated descriptor is freed. CC: Zhangfei Gao Signed-off-by: Peter Ujfalusi Thanks Peter

Re: [PATCH 05/25] scsi: hisi_sas: allocate memories and create pools

2015-10-13 Thread zhangfei
Hi, Arnd On 10/12/2015 11:15 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:17 John Garry wrote: + interrupt_count = of_property_count_u32_elems(np, "interrupts"); + if (interrupt_count < 0) + goto err_out; + + if (of_property_read_u32(np, "#interrupt-c

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev = hisi_hba->pdev; + struct device *dev = &pdev->dev; + struct resource *res; + + res = pl

Re: [PATCH 07/25] scsi: hisi_sas: add ioremap for device HW

2015-10-13 Thread zhangfei
On 10/13/2015 08:20 PM, Arnd Bergmann wrote: On Tuesday 13 October 2015 17:47:02 zhangfei wrote: On 10/12/2015 11:21 PM, Arnd Bergmann wrote: On Monday 12 October 2015 23:20:19 John Garry wrote: +int hisi_sas_ioremap(struct hisi_hba *hisi_hba) +{ + struct platform_device *pdev

Re: [PATCH v7 0/5] scsi: ufs: add ufs driver code for Hisilicon Hi3660 SoC

2018-01-07 Thread zhangfei
Hi, Wei On 2018年01月06日 17:51, Li Wei wrote: This patchset adds driver support for UFS for Hi3660 SoC. It is verified on HiKey960 board. Usually here should list the change compared with the last change set, to make it easier to reviewer, who may pay more attention to the differences. For ex

Re: [PATCH] mmc: dw_mmc-k3: Fix DDR52 mode by setting required clock divisor

2018-04-04 Thread zhangfei
+ Hisilicon colleague On 2018年04月05日 08:51, Shawn Lin wrote: [+ Zhangfei Gao who added support for hi6220] On 2018/4/4 23:31, Ryan Grachek wrote: On Tue, Apr 3, 2018 at 6:31 AM, Shawn Lin <mailto:shawn@rock-chips.com>> wrote:     On 2018/3/30 2:24, oscardagrach wrote:     Need

Re: [PATCH 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-06-19 Thread zhangfei
Dear Mark On 06/18/2014 01:13 AM, Mark Rutland wrote: On Tue, Jun 17, 2014 at 08:58:00AM +0100, Zhangfei Gao wrote: From: Jiancheng Xue Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao --- .../devicetree

Re: [PATCH v2 2/2] phy: add hix5hd2-sata-phy driver

2014-07-02 Thread zhangfei
Hi, Kishon On 07/02/2014 07:26 PM, Kishon Vijay Abraham I wrote: diff --git a/drivers/phy/Kconfig b/drivers/phy/Kconfig index 16a2f06..782953d 100644 --- a/drivers/phy/Kconfig +++ b/drivers/phy/Kconfig @@ -109,6 +109,14 @@ config PHY_EXYNOS5250_SATA SATA 3.0 Gb/s, SATA 6.0 Gb/s speed

Re: [PATCH v2 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-06-26 Thread zhangfei
On 06/25/2014 09:32 PM, Arnd Bergmann wrote: On Wednesday 25 June 2014 20:41:26 zhangfei wrote: On 06/25/2014 08:16 PM, Arnd Bergmann wrote: On Wednesday 25 June 2014, Zhangfei Gao wrote: From: Jiancheng Xue Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. Signed

Re: [PATCH v2 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-06-26 Thread zhangfei
On 06/27/2014 04:53 AM, Arnd Bergmann wrote: On Thursday 26 June 2014 21:48:54 zhangfei wrote: Since you mention that this is a synopsys part, it may however be good to also define a compatible string for the generic device, to allow other SoCs to share this driver, and to make it easier

Re: [PATCH v2 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-06-25 Thread zhangfei
On 06/25/2014 08:16 PM, Arnd Bergmann wrote: On Wednesday 25 June 2014, Zhangfei Gao wrote: From: Jiancheng Xue Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao We have had a couple of PHY drivers that were

Re: [PATCH v2 4/9] ARM: dts: add dts files for hi3519-demb board

2015-12-07 Thread zhangfei
On 12/07/2015 02:37 PM, xuejiancheng wrote: As this seems to be a standard part, we can also think about making a high-level driver for in in drivers/soc rather than relying on the syscon driver which we tend to use more for one-off devices with random register layouts. Sorry. I didn't u

Re: [PATCH v2 02/32] devicetree: bindings: scsi: HiSi SAS

2015-10-27 Thread zhangfei
On 10/27/2015 10:39 PM, Mark Rutland wrote: On Tue, Oct 27, 2015 at 01:09:15PM +, John Garry wrote: On 26/10/2015 14:45, Mark Rutland wrote: On Mon, Oct 26, 2015 at 10:14:33PM +0800, John Garry wrote: Add devicetree bindings for HiSilicon SAS driver. Signed-off-by: John Garry --- ...

Re: [PATCH 07/19] clk: hix5hd2: Silence sparse warnings

2015-05-06 Thread zhangfei
On 05/06/2015 03:39 PM, Stephen Boyd wrote: drivers/clk/hisilicon/clk-hix5hd2.c:255:13: warning: symbol 'hix5hd2_clk_register_complex' was not declared. Should it be static? Cc: Zhangfei Gao Signed-off-by: Stephen Boyd Acked-by: Zhangfei Gao Thanks --- drivers/clk/his

Re: [PATCH hisi] Input: i2c_atmel_read() can be static

2014-12-21 Thread zhangfei
On 12/19/2014 09:56 AM, kbuild test robot wrote: drivers/input/touchscreen/atmel_mXT224E.c:460:5: sparse: symbol 'i2c_atmel_read' was not declared. Should it be static? drivers/input/touchscreen/atmel_mXT224E.c:496:5: sparse: symbol 'i2c_atmel_write' was not declared. Should it be static? dri

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-25 Thread zhangfei
On 02/23/2015 11:36 PM, Felipe Balbi wrote: Hi, On Sun, Feb 22, 2015 at 11:10:36AM +0800, zhangfei wrote: +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) +{ + struct usb_otg *otg = priv->phy.otg; + + if (!otg->gadget) + return; + +

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-26 Thread zhangfei
Hi, Roger On 02/24/2015 06:13 PM, Roger Quadros wrote: On Sat, Feb 21, 2015 at 11:03:05PM +0800, zhangfei wrote: +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) +{ +struct usb_otg *otg = priv->phy.otg; + +if (!otg->gadget) +return; + +

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-19 Thread zhangfei
Hi, Balbi On 02/18/2015 10:35 PM, Felipe Balbi wrote: On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: Hi, Kishon On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: Add usb phy controller for hi6220 platform Signed

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-20 Thread zhangfei
On 02/20/2015 12:38 PM, Felipe Balbi wrote: On Fri, Feb 20, 2015 at 11:07:21AM +0800, zhangfei wrote: Hi, Balbi On 02/18/2015 10:35 PM, Felipe Balbi wrote: On Wed, Feb 18, 2015 at 01:44:21PM +0800, zhangfei wrote: Hi, Kishon On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: Hi, On

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-20 Thread zhangfei
Hi, Balbi On 02/20/2015 10:41 PM, Felipe Balbi wrote: +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) +{ + struct usb_otg *otg = priv->phy.otg; + + if (!otg->gadget) + return; + + if (on) + usb_gadget_connect(otg->gadget); +

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-21 Thread zhangfei
Hi, Balbi On 02/21/2015 12:06 AM, Felipe Balbi wrote: Hi, On Fri, Feb 20, 2015 at 11:44:37PM +0800, zhangfei wrote: Hi, Balbi On 02/20/2015 10:41 PM, Felipe Balbi wrote: +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) +{ + struct usb_otg *otg = priv->phy.

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-21 Thread zhangfei
Hi, Balbi On 02/22/2015 12:21 AM, Felipe Balbi wrote: Hi, On Sat, Feb 21, 2015 at 11:03:05PM +0800, zhangfei wrote: +static void hi6220_start_peripheral(struct hi6220_priv *priv, bool on) +{ + struct usb_otg *otg = priv->phy.otg; + + if (!otg->gadget) +

Re: [PATCH] phy: hix5hd2-sata: Convert to use devm_ioremap_resource

2015-03-01 Thread zhangfei
On 03/02/2015 02:32 PM, Axel Lin wrote: devm_ioremap_resource() also has sanity check for the res argument which is missed in current code. I remember we can not use devm_ioremap_resource here, because the memory region is shared with sata controller. And devm_request_mem_region would fail.

Re: [PATCH] phy: hix5hd2-sata: Check return value of platform_get_resource

2015-03-02 Thread zhangfei
On 03/02/2015 04:10 PM, Axel Lin wrote: This prevent NULL pointer dereference if res is NULL. Signed-off-by: Axel Lin Acked-by: Zhangfei Gao Thanks --- This patch replaces [PATCH] phy: hix5hd2-sata: Convert to use devm_ioremap_resource, as zhangfei pinted out that the memory region is

Re: [PATCH v4 4/4] phy: add phy-hi6220-usb

2015-02-17 Thread zhangfei
Hi, Kishon On 02/18/2015 01:35 PM, Kishon Vijay Abraham I wrote: Hi, On Thursday 12 February 2015 01:07 PM, Zhangfei Gao wrote: Add usb phy controller for hi6220 platform Signed-off-by: Zhangfei Gao --- drivers/phy/Kconfig | 9 ++ drivers/phy/Makefile | 1 + drivers

Re: [PATCH 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-03-29 Thread zhangfei
On 03/30/2016 08:46 AM, Shawn Lin wrote: 在 2016/3/29 16:23, zhangfei 写道: More to think, Is it ok to match the behaviour of bootloader stage? My bootloader doesn't assert the reset pin of dw_mmc, so it seams if I want to fix you issue on kernel stage, I need a new round of assert-&

Re: [PATCH] ASoC: pxa: remove incorrect do_div() call

2015-11-23 Thread zhangfei
On 11/20/2015 05:32 PM, Arnd Bergmann wrote: The new optimized do_div implementation (now in asm-generic/next) exposes a glitch in the brownstone audio driver by producing a compile-time warning: sound/soc/pxa/brownstone.c: In function 'brownstone_wm8994_hw_params': sound/soc/pxa/brownstone.c:

Re: [PATCH v2 2/2] uacce: add uacce driver

2019-08-29 Thread zhangfei
Hi, Greg On 2019/8/28 下午11:22, Greg Kroah-Hartman wrote: On Wed, Aug 28, 2019 at 09:27:56PM +0800, Zhangfei Gao wrote: +struct uacce { + const char *drv_name; + const char *algs; + const char *api_ver; + unsigned int flags; + unsigned long qf_pg_start

Re: [PATCH v2 2/2] uacce: add uacce driver

2019-08-30 Thread zhangfei
Hi, Greg On 2019/8/29 下午5:54, Greg Kroah-Hartman wrote: On Thu, Aug 29, 2019 at 05:05:13PM +0800, zhangfei wrote: Hi, Greg On 2019/8/28 下午11:22, Greg Kroah-Hartman wrote: On Wed, Aug 28, 2019 at 09:27:56PM +0800, Zhangfei Gao wrote: +struct uacce { + const char *drv_name

Re: [PATCH v2 2/2] uacce: add uacce driver

2019-08-30 Thread zhangfei
Hi, Greg On 2019/8/29 下午5:54, Greg Kroah-Hartman wrote: On Thu, Aug 29, 2019 at 05:05:13PM +0800, zhangfei wrote: Hi, Greg On 2019/8/28 下午11:22, Greg Kroah-Hartman wrote: On Wed, Aug 28, 2019 at 09:27:56PM +0800, Zhangfei Gao wrote: +struct uacce { + const char *drv_name

Re: [PATCH 2/2] uacce: add uacce module

2019-08-21 Thread zhangfei
On 2019/8/21 下午5:17, Greg Kroah-Hartman wrote: On Wed, Aug 21, 2019 at 03:21:18PM +0800, zhangfei@foxmail.com wrote: Hi, Greg On 2019/8/21 上午12:59, Greg Kroah-Hartman wrote: On Tue, Aug 20, 2019 at 09:08:55PM +0800, zhangfei wrote: On 2019/8/15 下午10:13, Greg Kroah-Hartman wrote: On

Re: [PATCH v2 2/2] uacce: add uacce driver

2019-09-01 Thread zhangfei
Hi, Greg On 2019/8/30 下午10:54, zhangfei wrote: On 2019/8/28 下午11:22, Greg Kroah-Hartman wrote: On Wed, Aug 28, 2019 at 09:27:56PM +0800, Zhangfei Gao wrote: +struct uacce { +    const char *drv_name; +    const char *algs; +    const char *api_ver; +    unsigned int flags; +    unsigned

Re: [PATCH 2/2] uacce: add uacce module

2019-08-23 Thread zhangfei
Hi, Jonathan Thanks for your careful review and good suggestion. Sorry for late response, I am checking one detail. On 2019/8/16 上午12:54, Jonathan Cameron wrote: On Wed, 14 Aug 2019 17:34:25 +0800 Zhangfei Gao wrote: From: Kenneth Lee Uacce is the kernel component to support WarpDrive

Re: [PATCH 2/2] uacce: add uacce module

2019-08-24 Thread zhangfei
On 2019/8/20 下午10:33, Greg Kroah-Hartman wrote: On Tue, Aug 20, 2019 at 08:36:50PM +0800, zhangfei wrote: Hi, Greg On 2019/8/19 下午6:24, Greg Kroah-Hartman wrote: +static int uacce_create_chrdev(struct uacce *uacce) +{ + int ret; + + ret = idr_alloc(&uacce_idr, uacce,

Re: [PATCH v3 2/2] uacce: add uacce driver

2019-09-12 Thread zhangfei
Hi, Greg Thanks for the careful review. On 2019/9/4 下午8:50, Greg Kroah-Hartman wrote: On Tue, Sep 03, 2019 at 12:14:47PM +0800, Zhangfei Gao wrote: +/** + * uacce_wake_up - Wake up the process who is waiting this queue + * @q the accelerator queue to wake up + */ +void uacce_wake_up(struct

Re: [PATCH v3 2/2] uacce: add uacce driver

2019-09-12 Thread zhangfei
On 2019/9/4 下午8:38, Greg Kroah-Hartman wrote: On Tue, Sep 03, 2019 at 12:14:47PM +0800, Zhangfei Gao wrote: From: Kenneth Lee Uacce (Unified/User-space-access-intended Accelerator Framework) targets to provide Shared Virtual Addressing (SVA) between accelerators and processes. So

Re: [PATCH 2/2] uacce: add uacce module

2019-08-20 Thread zhangfei
Hi, Greg On 2019/8/19 下午6:24, Greg Kroah-Hartman wrote: +static int uacce_create_chrdev(struct uacce *uacce) +{ + int ret; + + ret = idr_alloc(&uacce_idr, uacce, 0, 0, GFP_KERNEL); + if (ret < 0) + return ret; + Shouldn't this function create the memory needed fo

Re: [PATCH 2/2] uacce: add uacce module

2019-08-20 Thread zhangfei
On 2019/8/19 下午6:22, Greg Kroah-Hartman wrote: On Mon, Aug 19, 2019 at 05:09:23PM +0800, zhangfei@foxmail.com wrote: Hi, Greg Thanks for your kind suggestion. On 2019/8/15 下午10:12, Greg Kroah-Hartman wrote: On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote: diff --git a

Re: [PATCH 2/2] uacce: add uacce module

2019-08-20 Thread zhangfei
On 2019/8/15 下午10:13, Greg Kroah-Hartman wrote: On Wed, Aug 14, 2019 at 05:34:25PM +0800, Zhangfei Gao wrote: +int uacce_register(struct uacce *uacce) +{ + int ret; + + if (!uacce->pdev) { + pr_debug("uacce parent device not set\n"); + r

Re: [PATCH 0/2] A General Accelerator Framework, WarpDrive

2019-08-20 Thread zhangfei
Hi, Jerome Thanks for your suggestion On 2019/8/16 上午1:04, Jerome Glisse wrote: On Wed, Aug 14, 2019 at 05:34:23PM +0800, Zhangfei Gao wrote: *WarpDrive* is a general accelerator framework for the user application to access the hardware without going through the kernel in data path

Re: [PATCH v5 2/3] uacce: add uacce driver

2019-10-15 Thread zhangfei
Hi, Jonathan On 2019/10/14 下午6:32, Jonathan Cameron wrote: On Mon, 14 Oct 2019 14:48:54 +0800 Zhangfei Gao wrote: From: Kenneth Lee Uacce (Unified/User-space-access-intended Accelerator Framework) targets to provide Shared Virtual Addressing (SVA) between accelerators and processes. So

Re: [PATCH v5 2/3] uacce: add uacce driver

2019-10-16 Thread zhangfei
On 2019/10/16 上午1:55, reg Kroah-Hartman wrote: On Tue, Oct 15, 2019 at 03:39:00PM +0800, zhangfei wrote: Hi, Jonathan On 2019/10/14 下午6:32, Jonathan Cameron wrote: On Mon, 14 Oct 2019 14:48:54 +0800 Zhangfei Gao wrote: From: Kenneth Lee Uacce (Unified/User-space-access-intended

Re: linux-next: build failure after merge of the slave-dma tree

2019-07-07 Thread zhangfei
Hi, Robin On 2019/7/8 上午9:22, Robin Gong wrote: Hi Stephen, That's caused by 'of_irq_count' NOT export to global symbol, and I'm curious why it has been here for so long since Zhangfei found it in 2015. https://patchwork.kernel.org/patch/7404681/ Hi Rob,

Re: [PATCH] scsi: hisi_sas: support deferred probe for v2 hw

2016-12-06 Thread zhangfei
Reviewed-by: Zhangfei Gao Thanks

Re: [RFC][PATCH 1/7] k3dma: Fix hisi burst clipping

2016-07-17 Thread zhangfei
On 07/16/2016 10:13 AM, John Stultz wrote: From: Andy Green Max burst len is a 4-bit field, but at the moment it's clipped with a 5-bit constant... reduce it to that which can be expressed Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc

Re: [RFC][PATCH 3/7] k3dma: Fix "nobody cared" message seen on any error

2016-07-17 Thread zhangfei
ror. This patch lets it handle the interrupt and keep the IRQ alive. Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc: Liam Girdwood Cc: Mark Brown Cc: Jaroslav Kysela Cc: Takashi Iwai Cc: Wei Xu Cc: Rob Herring Cc: Andy Green

Re: [RFC][PATCH 2/7] k3dma: Fix dma err offsets

2016-07-17 Thread zhangfei
On 07/16/2016 10:13 AM, John Stultz wrote: From: Andy Green The offsets for ERR1 and ERR2 are wrong actually. That's why you can never clear an error. Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc: Liam Girdwood Cc:

Re: [RFC][PATCH 4/7] k3dma: Add cyclic mode for audio

2016-07-17 Thread zhangfei
On 07/16/2016 10:13 AM, John Stultz wrote: From: Andy Green Currently the k3dma driver doesn't offer the cyclic mode necessary for handling audio. This patch adds it. Cc: Zhangfei Gao Cc: Jingoo Han Cc: Krzysztof Kozlowski Cc: Maxime Ripard Cc: Vinod Koul Cc: Dan Williams Cc:

Re: [PATCH 1/3] scsi: hisi_sas: service v2 hw CQ ISR with tasklet

2017-01-03 Thread zhangfei
processing to tasklet context. Each CQ will have its down tasklet. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Zhangfei Gao

Re: [PATCH 2/3] scsi: hisi_sas: lock sensitive regions when servicing CQ interrupt

2017-01-03 Thread zhangfei
), bitmap of currently allocated IPTT (in hisi_hba.slot_index_tags), and completion queue read pointer. As a solution, lock these elements with the hisi_hba.lock. Signed-off-by: John Garry Reviewed-by: Xiang Chen Reviewed-by: Zhangfei Gao

Re: [PATCH 3/3] scsi: hisi_sas: lock sensitive region in hisi_sas_slot_abort()

2017-01-03 Thread zhangfei
On 2017年01月03日 20:24, John Garry wrote: When we call hisi_sas_slot_task_free() we should grab the hisi_hba.lock, as hisi_sas_slot_task_free() accesses common hisi_hba elements. Function hisi_sas_slot_abort() is missing this, so add it. Signed-off-by: John Garry Reviewed-by: Zhangfei Gao

Re: [PATCH 2/3] hisi_sas: fix the inconsistent lock issue reported by CONFIG_PROVE_LOCKING

2016-06-05 Thread zhangfei
[] sas_discover_domain+0x4bc/0x564 [] process_one_work+0x1a0/0x3cc [] worker_thread+0x138/0x438 [] kthread+0xdc/0xf0 [] ret_from_fork+0x10/0x40 Signed-off-by: Wei Xu Signed-off-by: John Garry Reviewed-by: Zhangfei Gao

Re: [PATCH 1/3] hisi_sas: add v2 hw ACPI support

2016-06-05 Thread zhangfei
: Zhangfei Gao Thanks

Re: [PATCH 2/2] mmc: dw_mmc: add resets support to dw_mci_parse_dt()

2016-03-03 Thread zhangfei
On 03/03/2016 10:00 AM, Shawn Lin wrote: Hi Guodong, On 2016/3/3 9:33, Guodong Xu wrote: With this, user can add a 'resets' property into dw_mmc dts node, and when driver probe and parse_dt, it will call reset APIs to reset dw_mmc host controller. Please also refer to Documentation/devicetre

Re: [PATCH 2/2] mmc: dw_mmc: add resets support to dw_mmc

2016-03-29 Thread zhangfei
On 03/29/2016 10:22 AM, Shawn Lin wrote: + else if (IS_ERR(host->pdata)) { dev_err(host->dev, "platform data not available\n"); return -EINVAL; } @@ -3012,6 +3022

Re: [PATCH 15/17] ir-hix5hd2: drop the use of IRQF_NO_SUSPEND

2015-09-23 Thread zhangfei
On 09/21/2015 08:47 AM, Sudeep Holla wrote: This driver doesn't claim the IR transmitter to be wakeup source. It even disables the clock and the IR during suspend-resume cycle. This patch removes yet another misuse of IRQF_NO_SUSPEND. Cc: Mauro Carvalho Chehab Cc: Zhangfei Gao Cc: Pa

Re: [PATCH 15/17] ir-hix5hd2: drop the use of IRQF_NO_SUSPEND

2015-09-23 Thread zhangfei
On 09/23/2015 07:37 AM, Sudeep Holla wrote: On 23/09/15 15:26, zhangfei wrote: On 09/21/2015 08:47 AM, Sudeep Holla wrote: This driver doesn't claim the IR transmitter to be wakeup source. It even disables the clock and the IR during suspend-resume cycle. This patch removes yet an

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

2017-05-23 Thread zhangfei
Hi, Jarkko Would you mind give some suggestion? On 2017年05月23日 20:48, Rob Herring wrote: + compatible = "snps,designware-i2c"; These should have an SoC specific compatible. We directly use drivers/i2c/busses/i2c-designware-platdrv.c, do we still an soc specific compati

Re: [PATCH] dma: k3dma: Fix non-cyclic mode

2017-07-10 Thread zhangfei
Vinod Koul Cc: Dan Williams Cc: Zhangfei Gao Cc: dmaeng...@vger.kernel.org Signed-off-by: Antonio Borneo [jstultz: Expanded commit message a bit] Signed-off-by: John Stultz Acked-by: Zhangfei Gao Thanks

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

2017-05-22 Thread zhangfei
Hi, Rob Thanks for the review. On 2017年05月23日 08:39, Rob Herring wrote: On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote: From: Zhangfei Gao Add I2C nodes for Hi3660-hikey960. On HiKey960, I2C0, I2C7 is connected to Low Speed Expansion Connector. I2C1 is connected to ADV7535

Re: [PATCH 05/12] arm64: dts: Add I2C nodes for Hi3660

2017-05-22 Thread zhangfei
On 2017年05月23日 13:55, zhangfei wrote: Hi, Rob Thanks for the review. On 2017年05月23日 08:39, Rob Herring wrote: On Wed, May 17, 2017 at 04:37:38PM +0800, Guodong Xu wrote: From: Zhangfei Gao Add I2C nodes for Hi3660-hikey960. On HiKey960, I2C0, I2C7 is connected to Low Speed Expansion

Re: [PATCH v2 2/3] clk: hi3660: add clocks for video encoder, decoder and ISP

2017-06-13 Thread zhangfei
On 2017年05月26日 15:38, Guodong Xu wrote: From: Chen Jun This patch adds more clocks for hi3660, including: - video encoder and decoder - ISP (Image Signal Processing) Signed-off-by: Chen Jun Signed-off-by: Zhong Kaihua Signed-off-by: Guodong Xu Reviewed-by: Zhangfei Gao Acked-by

Re: [PATCH v2 1/3] clk: hi3660: fix wrong parent name of clk_mux_sysbus

2017-06-13 Thread zhangfei
On 2017年05月26日 15:38, Guodong Xu wrote: From: Chen Jun Parent name of clk_mux_sysbus is not correct. This patch fixes it. Signed-off-by: Chen Jun Signed-off-by: John Stultz Signed-off-by: Guodong Xu Acked-by: Zhangfei Gao

Re: [PATCH v2 3/3] clk: hi3660: Set PPLL2 to 2880M

2017-06-13 Thread zhangfei
On 2017年05月26日 15:38, Guodong Xu wrote: From: Zhong Kaihua Set PPLL2 to 2880M. With this patch, we saw better compatibility on various 1080p HDMI monitors. Signed-off-by: Zhong Kaihua Signed-off-by: Zheng Shaobo Acked-by: Zhangfei Gao

Re: [PATCH 1/8] hisi_sas: add internal abort core code

2016-08-20 Thread zhangfei
On 2016年08月10日 21:19, John Garry wrote: Add core code for internal abort functionality. The internal abort features allows the host controller to abort commands which are still active in the controller but have not yet been sent to the slave device. Typically a command only spends a relativel

Re: [PATCH 0/7 v4] K3DMA fixes for HiKey HDMI audio

2016-08-11 Thread zhangfei
On 08/09/2016 08:15 AM, John Stultz wrote: Here's another go at the k3dma fixes and cyclic mode patches needed to support audio on HiKey. New in v4: * Reworked patch set so fixes are applied first before features Let me know if there is any feedback or objections! thanks -john Cc: Zha

Re: [PATCH] dma: mmp_tdma: add multiple burst size support for 910-squ

2013-10-10 Thread zhangfei gao
On Wed, Oct 9, 2013 at 1:40 PM, Qiao Zhou wrote: > add multiple burst size support for 910-squ. > > Signed-off-by: Qiao Zhou > --- > drivers/dma/mmp_tdma.c | 25 - > 1 files changed, 24 insertions(+), 1 deletions(-) > > diff --git a/drivers/dma/mmp_tdma.c b/drivers/dma/

[PATCH] merge_config.sh: Add option to specify output dir

2012-12-02 Thread Zhangfei Gao
Provide a -O option to specify dir to put generated .config Then merge_config.sh does not need to be copied to target dir, for easy re-usage in other script Signed-off-by: Zhangfei Gao Tested-by: Jon Medhurst (Tixy) --- scripts/kconfig/merge_config.sh | 20 1 file

Re: [PATCH V2] dma: mmp_tdma: disable irq when disabling dma channel

2013-06-15 Thread zhangfei gao
On Sat, Jun 15, 2013 at 12:51 PM, Qiao Zhou wrote: > mask dma irq when disabling dma channel, so that interrupt status > will not be set and interrupt won't come again. > > Signed-off-by: Qiao Zhou Acked-by: Zhangfei Gao -- To unsubscribe from this list: send the line "un

答复: [RFC] a question about reuse hwpoison page in soft_offline_page()

2018-11-20 Thread Zhangfei (Tyler)
Hi Naoya Any Update on this issue?Is there a final conclusion on how to fix this issue? Thinks -邮件原件- 发件人: Naoya Horiguchi [mailto:n-horigu...@ah.jp.nec.com] 发送时间: 2018年7月23日 14:11 收件人: Zhangfei (Tyler) 抄送: Xiexiuqi ; 裘稀石(稀石) ; linux-mm ; linux-kernel ; zy.zhengyi

Re: [PATCH] uacce: fix some coding styles

2020-07-30 Thread Zhangfei Gao
On 2020/7/30 下午2:13, Kai Ye wrote: 1. delete some redundant code. 2. modify the module author information. Signed-off-by: Kai Ye Thanks Kai Acked-by: Zhangfei Gao Thanks

Re: [PATCH 0/2] Let pci_fixup_final access iommu_fwnode

2020-05-21 Thread Zhangfei Gao
Hi, Joerg On 2020/5/12 下午12:08, Zhangfei Gao wrote: Some platform devices appear as PCI but are actually on the AMBA bus, and they need fixup in drivers/pci/quirks.c handling iommu_fwnode. So calling pci_fixup_final after iommu_fwnode is allocated. For example: Hisilicon platform device need

Re: [PATCH] uacce: Use kobj_to_dev() instead of container_of()

2020-08-19 Thread Zhangfei Gao
On 2020/8/20 上午10:16, Tian Tao wrote: Use kobj_to_dev() instead of container_of() Signed-off-by: Tian Tao Reviewed-by: Zhou Wang Acked-by: Zhangfei Gao Thanks --- drivers/misc/uacce/uacce.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/misc/uacce

[PATCH] PCI: Add a quirk to enable SVA for HiSilicon chip

2021-01-11 Thread Zhangfei Gao
: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed-off-by: Zhou Wang --- Property dma-can-stall depends on patchset https://lore.kernel.org/linux-iommu/20210108145217.2254447-1-jean-phili...@linaro.org/ drivers/pci/quirks.c | 25 + 1 file changed, 25 insertions(+) diff

Re: [PATCH] PCI: Add a quirk to enable SVA for HiSilicon chip

2021-01-13 Thread Zhangfei Gao
Hi, Bjorn Thanks for the suggestion. On 2021/1/13 上午1:02, Bjorn Helgaas wrote: On Tue, Jan 12, 2021 at 02:49:52PM +0800, Zhangfei Gao wrote: HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices can not support tlp and have to

Re: [PATCH] mmc: dw_mmc-k3: use the correct HiSilicon copyright

2021-03-31 Thread Zhangfei Gao
On Tue, Mar 30, 2021 at 2:46 PM Hao Fang wrote: > > s/Hisilicon/HiSilicon/g. > It should use capital S, according to > https://www.hisilicon.com/en/terms-of-use. > > Signed-off-by: Hao Fang Thanks for the fix. Acked-by: Zhangfei Gao > --- > drivers/mmc/host/dw_m

Re: [PATCH v2] dmaengine: k3dma: use the correct HiSilicon copyright

2021-04-01 Thread Zhangfei Gao
On 2021/4/1 下午7:50, Hao Fang wrote: s/Hisilicon/HiSilicon/g. It should use capital S, according to the official website. Signed-off-by: Hao Fang Thanks for the patch. Acked-by:  Zhangfei Gao --- V2: -remove the terms of use link. --- drivers/dma/k3dma.c | 4 ++-- 1 file changed, 2

[PATCH v3 0/3] PCI: Add a quirk to enable SVA for HiSilicon chip

2021-03-08 Thread Zhangfei Gao
kernel.org/linux-pci/20210112170230.GA1838341@bjorn-Precision-5520/ Zhangfei Gao (3): PCI: PASID can be enabled without TLP prefix PCI: Add a quirk to set pasid_no_tlp for HiSilicon chips PCI: Set dma-can-stall for HiSilicon chips drivers/pci/ats.c| 2 +- drive

[PATCH v3 1/3] PCI: PASID can be enabled without TLP prefix

2021-03-08 Thread Zhangfei Gao
-by: Bjorn Helgaas Signed-off-by: Zhangfei Gao --- drivers/pci/ats.c | 2 +- include/linux/pci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index 793d381..88f981b 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -380,7 +38

[PATCH v3 2/3] PCI: Add a quirk to set pasid_no_tlp for HiSilicon chips

2021-03-08 Thread Zhangfei Gao
HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices have PASID capability though not supporting TLP. Add a quirk to set pasid_no_tlp for these devices. Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed

[PATCH v3 3/3] PCI: Set dma-can-stall for HiSilicon chips

2021-03-08 Thread Zhangfei Gao
/20210302092644.2553014-1-jean-phili...@linaro.org/ Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed-off-by: Zhou Wang --- drivers/pci/quirks.c | 13 + 1 file changed, 13 insertions(+) diff --git a/drivers/pci/quirks.c b/drivers/pci/quirks.c index 873d27f..b866cdf 100644

Re: [PATCH v2 3/3] PCI: set dma-can-stall for HiSilicon chip

2021-03-08 Thread Zhangfei Gao
Hi, Krzysztof On 2021/3/8 上午1:54, Krzysztof Wilczyński wrote: Hi, [...] Property dma-can-stall depends on patchset https://lore.kernel.org/linux-iommu/20210108145217.2254447-1-jean-phili...@linaro.org/ [...] If you plan to post another version of this patch to include the above link into the

[PATCH v2 0/3] PCI: Add a quirk to enable SVA for HiSilicon chip

2021-01-18 Thread Zhangfei Gao
x-pci/20210112170230.GA1838341@bjorn-Precision-5520/ Zhangfei Gao (3): PCI: PASID can be enabled without TLP prefix PCI: Add a quirk to set pasid_no_tlp for HiSilicon chip PCI: set dma-can-stall for HiSilicon chip drivers/pci/ats.c| 2 +- drivers/pci/quirks.c | 27 ++

[PATCH v2 1/3] PCI: PASID can be enabled without TLP prefix

2021-01-18 Thread Zhangfei Gao
-by: Bjorn Helgaas Signed-off-by: Zhangfei Gao --- drivers/pci/ats.c | 2 +- include/linux/pci.h | 1 + 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/pci/ats.c b/drivers/pci/ats.c index e36d601..b67b1b1 100644 --- a/drivers/pci/ats.c +++ b/drivers/pci/ats.c @@ -386,7 +38

[PATCH v2 3/3] PCI: set dma-can-stall for HiSilicon chip

2021-01-18 Thread Zhangfei Gao
HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices can support SVA via SMMU stall feature, by setting dma-can-stall for ACPI platforms. Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed-off-by: Zhou Wang

[PATCH v2 2/3] PCI: Add a quirk to set pasid_no_tlp for HiSilicon chip

2021-01-18 Thread Zhangfei Gao
HiSilicon KunPeng920 and KunPeng930 have devices appear as PCI but are actually on the AMBA bus. These fake PCI devices have PASID capability though not supporting TLP. Add a quirk to set pasid_no_tlp for these devices. Signed-off-by: Zhangfei Gao Signed-off-by: Jean-Philippe Brucker Signed

Re: [PATCH 15/28] dmaengine: k3dma: use DMA_COMPLETE for dma completion status

2013-10-17 Thread zhangfei gao
On Thu, Oct 17, 2013 at 12:28 AM, Vinod Koul wrote: > Signed-off-by: Vinod Koul > CC: Zhangfei Gao Thanks Vinod Acked-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH 16/28] dmaengine: mmp_tdma: use DMA_COMPLETE for dma completion status

2013-10-17 Thread zhangfei gao
On Thu, Oct 17, 2013 at 12:28 AM, Vinod Koul wrote: > Signed-off-by: Vinod Koul > CC: Zhangfei Gao Thanks Vinod Acked-by: Zhangfei Gao -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordo

Re: [PATCH v2] dma: mmp_tdma: add multiple burst size support for 910-squ

2013-10-11 Thread zhangfei gao
On Fri, Oct 11, 2013 at 9:07 AM, Qiao Zhou wrote: > add multiple burst size support for 910-squ. > > Signed-off-by: Qiao Zhou Acked-by: Zhangfei Gao Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@v

Re: [PATCH 1/9] i2c: i2c-designware-platdrv: replace platform_driver_probe to support deferred probing

2013-10-13 Thread zhangfei gao
o have that, so the > devices it supports won't get lost in a deferred probe. > > Signed-off-by: Wolfram Sang > Cc: Zhangfei Gao Acked-by: Zhangfei Gao Thanks -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord..

[PATCH v3 2/2] phy: add hix5hd2-sata-phy driver

2014-07-03 Thread Zhangfei Gao
From: Jiancheng Xue Add hix5hd2-sata-phy driver on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao --- drivers/phy/Kconfig|8 ++ drivers/phy/Makefile |1 + drivers/phy/phy-hix5hd2-sata.c | 192

[PATCH v3 0/2] phy: add hix5hd2-sata-phy driver

2014-07-03 Thread Zhangfei Gao
v3: Suggested by Kishon Change binding doc name to hix5hd2-phy.txt Add HAS_IOMEM depends, and change include file sequence v2: Suggested by Mark Remove hisilicon,reg-init and init the register in phy-hix5hd2-sata.c Change property name accordingly. Jiancheng Xue (2): Documentation: Document His

[PATCH v3 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-07-03 Thread Zhangfei Gao
From: Jiancheng Xue Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao --- .../devicetree/bindings/phy/hix5hd2-phy.txt| 22 1 file changed, 22 insertions(+) create mode 100644

[PATCH 1/2] Documentation: Document Hisilicon hix5hd2 sata PHY

2014-06-17 Thread Zhangfei Gao
From: Jiancheng Xue Add necessary binding documentation SATA PHY on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao --- .../devicetree/bindings/phy/hix5hd2-sata-phy.txt | 26 1 file changed, 26 insertions(+) create mode 100644

[PATCH 2/2] phy: add hix5hd2-sata-phy driver

2014-06-17 Thread Zhangfei Gao
From: Jiancheng Xue Add hix5hd2-sata-phy driver on Hisilicon hix5hd2 soc. Signed-off-by: Jiancheng Xue Signed-off-by: Zhangfei Gao --- drivers/phy/Kconfig|8 ++ drivers/phy/Makefile |1 + drivers/phy/phy-hix5hd2-sata.c | 192

[PATCH 0/2] phy: add hix5hd2-sata-phy driver

2014-06-17 Thread Zhangfei Gao
Jiancheng Xue (2): Documentation: Document Hisilicon hix5hd2 sata PHY phy: add hix5hd2-sata-phy driver .../devicetree/bindings/phy/hix5hd2-sata-phy.txt | 26 +++ drivers/phy/Kconfig|8 + drivers/phy/Makefile |1 + drive

  1   2   >