[PATCH 1/2] genirq: Provide an accessor for IRQ_PER_CPU flag.

2012-07-30 Thread y
From: Chris Smith Adds an accessor function, irq_is_per_cpu(), for the flag IRQ_PER_CPU. This is useful if you have an IRQ that is per-cpu in some hardware implementations, and not in others (example: ARM PMU Interrupts), and you want to handle both cases. Signed-off-by: Chris Smith --- inclu

[PATCH 2/2] arm: pmu: add support for per-cpu PMU interrupts.

2012-07-30 Thread y
From: Chris Smith We have systems where the PMU interrupts are PPIs, and so per-cpu. This patch adds support for per-cpu PMU interrupts to the perf event code. Note that because the dev_id passed to request_percpu_irq has to be percpu data, we now pass cpu_hw_events as the dev_id rather than arm

[PATCH 1/1] ktime: Use macro NSEC_PER_USEC instead of a magic number

2013-05-06 Thread y
From: Liu Ying We've got the macro NSEC_PER_USEC defined in header file include/linux/time.h. To make the code decent, this patch replaces the magic number 1000 to convert bewteen a time value in microseconds and one in nanoseconds with the macro NSEC_PER_USEC. Signed-off-by: Liu Ying Cc: David

[PATCH 2/3] charger-manager: Fix bug when check dropped voltage after fullbatt event

2012-11-22 Thread y
From: Chanwoo Choi This patch check difference value between current voltage of battery and desc->fullbatt_uV whether positve or negative number. If difference value is negative number when current voltage of battery is larger than desc->fullbatt_uV, charger-manager return immediately because bat

[PATCH 3/3] charger-manager: Split _probe funtion for code clean

2012-11-22 Thread y
From: Chanwoo Choi This patch split _probe function for readability because _probe function is longer than 400 line. Signed-off-by: Chanwoo Choi Signed-off-by: Myungjoo Ham Signed-off-by: Kyungmin Park --- drivers/power/charger-manager.c | 279 +++ 1 file

[PATCH 1/2] fs: fix code-formatting issues in inotify

2015-01-16 Thread y
From: Stefan Haun Fix code-formatting warnings from script/checkpatch.pl; multiple instances of WARNING: line over 80 characters CHECK: No space is necessary after a cast CHECK: Alignment should match open parenthesis WARNING: quoted string split across lines CHECK: Blank lines aren't necessary

[PATCH 2/2] fs: fix checkpatch code warnings for inotify

2015-01-16 Thread y
From: Stefan Haun ./fs/notify/inotify/inotify.h:23: CHECK: extern prototypes should be avoided in .h files ./fs/notify/inotify/inotify.h:25: CHECK: extern prototypes should be avoided in .h files Removed extrn keywords; the matter, however, seems to be an open debate. ./fs/notif

[PATCH] charger-manager: Fix checking of wrong return type

2014-03-17 Thread y
From: Chanwoo Choi This patch fix minor issue about checking wrong return type. The of_cm_parse_desc() return ERR_PTR(errnor number) when some error happen in this function. But, charger_manager_probe() has only checked whether desc is NULL or not. If of_cm_parse_desc() returns ERR_PTR(-ENOMEM),

[PATCH] mtd: gpmi: make blockmark swapping optional

2014-03-19 Thread y
From: Lothar Waßmann With a flash-based BBT there is no reason to move the Factory Bad Block Marker from the data area buffer (to where it is mapped by the GPMI NAND controller) to the OOB buffer. Thus, make this feature configurable via DT. This is required for the Ka-Ro electronics platforms.

[PATCH] cpufreq: exynos: Fix build error of no type of module_init

2014-01-22 Thread y
From: Krzysztof Kozlowski Add missing include to fix build error: drivers/cpufreq/exynos-cpufreq.c:292:1: warning: data definition has no type or storage class [enabled by default] drivers/cpufreq/exynos-cpufreq.c:292:1: error: type defaults to ‘int’ in declaration of ‘module_init’ [-Werror=imp

[PATCH v3 1/6] i2c: s3c2410: Handle i2c sys_cfg register in i2c driver

2014-05-10 Thread y
From: Pankaj Dubey Let's handle i2c interrupt re-configuration in i2c driver. This will help us in removing some soc specific checks from machine files. Since only Exynos5250, and Exynos5420 need to do this, added syscon based phandle to i2c device nodes of respective SoC DT files. Also handle sa

[PATCH v3 5/6] soc: samsung: exynos-chipid: Add Exynos Chipid driver support

2014-05-10 Thread y
SAMSUNG Soc drivers +# +config EXYNOS_CHIPID + tristate "Support Exynos CHIPID" + default y + select SOC_BUS + depends on ARCH_EXYNOS || ARM64 + help + If you say Y here you get support for the Exynos CHIP id. diff --git a/drivers/soc/samsung/Makefile b/drivers/s

[PATCH v3 4/6] ARM: EXYNOS: Remove unused header inclusion from hotplug.c

2014-05-10 Thread y
From: Pankaj Dubey This patch removed "plat/cpu.h" inclusion from hotplug.c as it is not required. Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/hotplug.c |2 -- 1 file changed, 2 deletions(-) diff --git a/arch/arm/mach-exynos/hotplug.c b/arch/arm/mach-exynos/hotplug.c index 0243ef

[PATCH v3 6/6] ARM: EXYNOS: Refactoring to remove soc_is_exynos macros from exynos

2014-05-10 Thread y
From: Pankaj Dubey This patch enables chipid driver for ARCH_EXYNOS and refactors machine code as well as exynos cpufreq driver code for using chipid driver for identification of SoC ID and SoC rev. This patch also updates DT binding information in exynos4 and exynos5 dtsi file. As to differenti

[PATCH v3 3/6] ARM: EXYNOS: Remove soc_is_exynos4/5 from exynos.c

2014-05-10 Thread y
From: Pankaj Dubey This patch removes usage of soc_is_exynos4/5 from exynos.c. For this we need to separate machine descriptors for exynos4 and exynos5. While doing this patch does some consolidation also. CC: Russell King CC: Thomas Abraham Signed-off-by: Pankaj Dubey --- arch/arm/mach-exyn

[PATCH v3 0/6] Introducing Exynos ChipId driver

2014-05-10 Thread y
From: Pankaj Dubey This patch series attempts to get rid of soc_is_exynos macros and eventually with the help of this series we can probably get rid of CONFIG_SOC_EXYNOS in near future. Each Exynos SoC has ChipID block which can give information about SoC's product Id and revision number.

[PATCH v3 2/6] ARM: EXYNOS: Remove i2c sys configuration related code

2014-05-10 Thread y
From: Pankaj Dubey Since all these code has been moved into i2c driver, now we can safely remove them from machine files. CC: Russell King Signed-off-by: Pankaj Dubey --- arch/arm/mach-exynos/exynos.c | 38 +-- arch/arm/mach-exynos/include/mach/map.h |

[PATCHv2 5/5] ARM: dts: Fix wrong compatible string of Exynos3250 RTC dt node

2014-08-11 Thread y
From: Chanwoo Choi This patch fix wrong compatible string of Exynos3250 RTC (Real-Time Clock) dt node. The RTC of Exynos3250 must need additional source clock (XrtcXTI). Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park --- arch/arm/boot/dts/exynos3250.dtsi | 2 +- 1 file changed, 1 inserti

[PATCHv2 0/5] rtc: s3c: Refactoring s3c-rtc driver and support Exynos3250 RTC

2014-08-11 Thread y
From: Chanwoo Choi This patchset clean up codes to improve readability as following and support the RTC of Exynos3250 SoC. - Remove global variables and then use new s3c_rtc structure - Remove warn message with checking checkpatch script - Use variant structure according to SoC type instead of le

[PATCHv2 1/5] rtc: s3c: Define s3c_rtc structure to remove global variables.

2014-08-11 Thread y
From: Chanwoo Choi This patch define s3c_rtc structure including necessary variables for S3C RTC device instead of global variables. This patch improves the readability by removing global variables. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park --- drivers/rtc/rtc-s3c.c | 448 ++

[PATCHv2 4/5] rtc: s3c: Add support for RTC of Exynos3250 SoC

2014-08-11 Thread y
From: Chanwoo Choi This patch add support for RTC of Exynos3250 SoC. The Exynos3250 needs source clock(32.768KHz) for RTC block. If source clock of RTC is registerd on clock list of common clk framework, Exynos RTC drvier have to control this clock. Clock list for s3c-rtc device: - rtc : CLK_RTC

[PATCHv2 2/5] rtc: s3c: Remove warning message when checking coding style with checkpatch script

2014-08-11 Thread y
From: Chanwoo Choi This patch remove warning message when checking codeing style with checkpatch script and reduce un-necessary i2c read operation on s3c_rtc_enable. WARNING: line over 80 characters #406: FILE: drivers/rtc/rtc-s3c.c:406: + if ((readw(info->b

[PATCHv2 3/5] rtc: s3c: Add s3c_rtc_data structure to use variant data instead of s3c_cpu_type

2014-08-11 Thread y
From: Chanwoo Choi This patch add s3c_rtc_data structure to variant data according to SoC type. The s3c_rtc_data structure includes some functions to control RTC operation and specific data dependent on SoC type. Signed-off-by: Chanwoo Choi Acked-by: Kyungmin Park --- drivers/rtc/rtc-s3c.c |

[PATCH] staging: lustre: remove IOC_LIBCFS_PING_TEST ioctl

2015-11-06 Thread y
From: James Simmons The ioctl IOC_LIBCFS_PING_TEST has not been used in ages. The recent nidstring changes which moved all the nidstring operations from libcfs to the LNet layer but this ioctl code was still using an nidstring operation that was causing an circular dependency loop between libcfs

[PATCH] Documentation: add support for V4L touch devices

2016-07-18 Thread y
is composed of an array of +horizontal and vertical conductors (alternatively called rows/columns, X/Y +lines, or tx/rx). Mutual Capacitance measured is at the nodes where the +conductors cross. Alternatively, Self Capacitance measures the signal from each +column and row independently. + +A touch

[PATCH 1/1] sched.h header file not required for compilation

2015-06-25 Thread y
From: Namit Gupta Signed-off-by: Namit Gupta --- drivers/oprofile/cpu_buffer.h |1 - 1 file changed, 1 deletion(-) diff --git a/drivers/oprofile/cpu_buffer.h b/drivers/oprofile/cpu_buffer.h index e1d097e..0106bb8 100644 --- a/drivers/oprofile/cpu_buffer.h +++ b/drivers/oprofile/cpu_buffer

Re: [PATCH 0/6] ARM: shmobile: kzm9d-reference: migrate to common clock framework with DT

2013-10-03 Thread takasi-y
Hi, > Documentation and implementation in one patch, > and dts in other patch, are normal style IMO That's strange! Considering the nature of DT, it must be wrong. ... was what I thought at first, but you are right. I found 3/4 (1021 in 1365) of commits (new + change - typo fix) under Documentat

Re: [PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively

2013-10-03 Thread takasi-y
Hi Laurent, > While I agree with this patch, I believe the use of the HAVE_MACH_CLKDEV > configuration option to select whether to compile core.o in is a bit of an > abuse. Well, yes, indeed. It does not mean having include/mach/clkdev.h, but means somewhat such like !COMMON_CLK. # I think ther

Re: [PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT

2013-10-03 Thread takasi-y
ter. # easier :) > > +ifeq ($(CONFIG_COMMON_CLK), y) > > +obj-$(CONFIG_ARCH_EMEV2) += clk-emev2.o > > +endif > > I don't think you would need the above ifeq/endif wrapper if you only > used CONFIG_ARCH_SHMOBILE_MULTI above. Right. Anyway, because you have make kzm9d-reference t

Re: [RFC/PATCH 4/4] block: Add URGENT request notification support to CFQ scheduler

2013-07-11 Thread Santosh Y
On Thu, Jul 11, 2013 at 6:31 PM, Tanya Brokhman wrote: > When the scheduler reports to the block layer that there is an urgent > request pending, the device driver may decide to stop the transmission > of the current request in order to handle the urgent one. This is done > in order to reduce the

Subject: [PATCH] md: avoid deadlock when raid5 array has unack badblocks during md_stop_writes.

2013-09-09 Thread y b
When raid5 hit a fresh badblock, this badblock will flagged as unack badblock until md_update_sb is called. But md_stop/reboot/md_set_readonly will avoid raid5d call md_update_sb in md_check_recovery, the badblock will always be unack, so raid5d thread enter a infinite loop and never can unregister

Re: Subject: [PATCH] md: avoid deadlock when raid5 array has unack badblocks during md_stop_writes.

2013-09-10 Thread y b
5c0 Sep 10 15:16:28 localhost kernel: [ 480.854481] [] ? handle_mm_fault+0x17d/0x920 2013/9/10, NeilBrown : > On Tue, 10 Sep 2013 13:00:52 +0800 y b wrote: > >> When raid5 hit a fresh badblock, this badblock will flagged as unack >> badblock until md_update_sb is called. >&g

[PATCH v2 0/3] ARM: shmobile: kzm9d: migrate to common clock framework with DT

2013-10-07 Thread takasi-y
This patch series makes kzm9d to move to new clk implementation based on the common clock framework and device tree, when configured as a part of multi-platform. These patches do not remove sh-clkfwk version, even on emev2. Non multi-platform configuration still uses sh-clkfwk. Should be applie

[PATCH v2 1/3] clk: emev2: Add support for emev2 SMU clocks with DT

2013-10-07 Thread takasi-y
Device tree clock binding document for EMMA Mobile EV2 SMU, And Common clock framework based implementation of it. Following nodes are defined to describe clock tree. - renesas,emev2-smu - renesas,emev2-smu-clkdiv - renesas,emev2-smu-gclk These bindings are designed manually based on 19UH0037EJ10

[PATCH v2 2/3] ARM: shmobile: emev2: Add clock tree description in DT

2013-10-07 Thread takasi-y
Add minimum clock tree description to .dts file. This provides same set of clocks as current sh-clkfwk version .c code does. Signed-off-by: Takashi Yoshii --- arch/arm/boot/dts/emev2.dtsi | 84 1 file changed, 84 insertions(+) diff --git a/arch/arm/b

[PATCH v2 3/3] ARM: shmobile: kzm9d: Use common clock framework

2013-10-07 Thread takasi-y
Use common clock framework version of clock drivers/clk/shmobile/clk-emev2.c instead of sh-clkfwk version arch/arm/mach-shmobile/clock-emev2.c when it is configured as a part of multi-platform. Signed-off-by: Takashi Yoshii --- arch/arm/mach-shmobile/board-kzm9d-reference.c | 5 ++--- 1 file c

[PATCH 5/6] clk: emev2: Add support for emev2 SMU clocks with DT

2013-09-23 Thread takasi-y
000 0x38>; interrupts = <0 11 0>; + clocks = <&usib_u3_sclk>; + clock-names = "sclk"; }; gpio0: gpio@e005 { diff --git a/drivers/clk/Makefile b/drivers/clk/Makefile index 7b11106..3e64ac4 100644 --- a/drivers/clk/

[PATCH 6/6] ARM: shmobile: kzm9d-reference: Use common clock framework

2013-09-23 Thread takasi-y
Use common clock framework version of clock drivers/clk/shmobile/clk-emev2.c instead of sh-clkfwk version arch/arm/mach-shmobile/clock-emev2.c kzm9d(without -reference) still uses sh-clkfwk version. Because two of that framework can not live in one kernel binary, there will be SoCs and Boards t

[PATCH 2/6] serial8250-em: convert to clk_prepare/unprepare

2013-09-23 Thread takasi-y
From: Shinya Kuribayashi Add calls to clk_prepare and unprepare so that EMMA Mobile EV2 can migrate to the common clock framework. Signed-off-by: Shinya Kuribayashi [takashi.yoshii...@renesas.com: edited for conflicts] Signed-off-by: Takashi Yoshii --- drivers/tty/serial/8250/8250_em.c | 6 ++

[PATCH 1/6] clocksource: em_sti: convert to clk_prepare/unprepare

2013-09-23 Thread takasi-y
From: Shinya Kuribayashi Add calls to clk_prepare and unprepare so that EMMA Mobile EV2 can migrate to the common clock framework. Signed-off-by: Shinya Kuribayashi --- drivers/clocksource/em_sti.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/clocksource/em_s

[PATCH 3/6] sh: clkfwk: Select sh-/common- clkfwk alternatively

2013-09-23 Thread takasi-y
Make sh clock framework core depend on HAVE_MACH_CLKDEV, and set it - y on sh for backward compatibility - !CONFIG_COMMON_CLK on sh-mobile This is a preparation for migration to common clock framework from sh clock framework on sh-mobile. Signed-off-by: Takashi Yoshii --- arch/arm/Kconfig

[PATCH 4/6] ARM: shmobile: emev2: Define SMU clock DT bindings

2013-09-23 Thread takasi-y
Device tree clock binding document for EMMA Mobile EV2 SMU. Following nodes are defined to describe clock tree. - renesas,emev2-smu - renesas,emev2-smu-clkdiv - renesas,emev2-smu-gclk These bindings are designed manually based on 19UH0037EJ1000_SMU : System Management Unit User's Manual Signed-o

Re: [PATCH V2] scsi: ufs: add support for query requests

2013-04-21 Thread Santosh Y
> + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) > + * @hba - UFS hba > + * @lrb - pointer to local reference block > + */ > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb > *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > + if (!l

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-14 Thread Santosh Y
On Fri, Jun 14, 2013 at 1:10 PM, Sujit Reddy Thumma wrote: > On 6/13/2013 10:03 AM, Sujit Reddy Thumma wrote: >>> >>> static struct scsi_host_template ufshcd_driver_template = { >>> @@ -1771,8 +2064,8 @@ int ufshcd_init(struct device *dev, struct >>> ufs_hba **hba_handle, >>> /* Configu

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-14 Thread Santosh Y
On Thu, Jun 13, 2013 at 10:06 AM, Sujit Reddy Thumma wrote: > On 6/12/2013 11:04 AM, Santosh Y wrote: >>> >>> >>> /** >>> + * ufshcd_query_request() - API for issuing query request to the >>> device. >>> + * @hba: ufs

Re: [PATCH 1/2] scsi: ufs: Add support for sending NOP OUT UPIU

2013-06-11 Thread Santosh Y
> +/* > + * ufshcd_wait_for_register - wait for register value to change > + * @hba - per-adapter interface > + * @reg - mmio register offset > + * @mask - mask to apply to read register value > + * @val - wait condition > + * @interval_us - polling interval in microsecs > + * @timeout_ms - timeout

Re: [PATCH 2/2] scsi: ufs: Set fDeviceInit flag to initiate device initialization

2013-06-11 Thread Santosh Y
> > /** > + * ufshcd_query_request() - API for issuing query request to the device. > + * @hba: ufs driver context > + * @query: params for query request > + * @descriptor: buffer for sending/receiving descriptor > + * @retries: number of times to try executing the command > + * > + * All n

Re: [PATCH 14/29] drivers/scsi/ufs/ufshcd-pltfrm.c: simplify use of devm_ioremap_resource

2013-08-14 Thread Santosh Y
On Wed, Aug 14, 2013 at 2:41 PM, Julia Lawall wrote: > > From: Julia Lawall > > Remove unneeded error handling on the result of a call to > platform_get_resource when the value is passed to devm_ioremap_resource. > > A debugging statement in the error-handling code is removed as well, as it > doe

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
linux-...@vger.kernel.org is for UFS filesystem. > The API for submitting a query request is ufs_query_request() in > ufs_core.c. This function is responsible for: This can be part of ufshcd.c which is actually the core file, no need to create a new core file for the function. > + > +#define UFS

Re: scsi: ufs: add support for query requests

2013-04-10 Thread Santosh Y
> > This can be done inside the following if condition i.e. if > (hba->query.descriptor != NULL). > and change the condition to if (!hba->query.descriptor). > I meant to write if (hba->query.descriptor)...:-) -- ~Santosh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" i

Re: [PATCH 1/1] scsi: ufs: Generalize UFS Interconnect Layer (UIC) command support

2013-05-02 Thread Santosh Y
> -static inline void > -ufshcd_send_uic_command(struct ufs_hba *hba, struct uic_command *uic_cmnd) > +static int ufshcd_send_uic_command(struct ufs_hba *hba, > + struct uic_command *uic_cmnd, int retries) > { > + int err = 0; > + unsigned long flags; > + > + if (un

Re: [PATCH 1/1] scsi: ufs: Add support for sending NOP OUT UPIU

2013-05-02 Thread Santosh Y
> + > +/** > + * ufshcd_validate_dev_connection() - Check device connection status > + * @hba: per-adapter instance > + * > + * Send NOP OUT UPIU and wait for NOP IN response to check whether the > + * device Transport Protocol (UTP) layer is ready after a reset. > + * If the UTP layer at the devic

Re: [PATCH V4] scsi: ufs: add support for query requests

2013-05-02 Thread Santosh Y
> + > +/** > + * ufshcd_compose_upiu - form UFS Protocol Information Unit(UPIU) > + * @hba - UFS hba > + * @lrb - pointer to local reference block > + */ > +static int ufshcd_compose_upiu(struct ufs_hba *hba, struct ufshcd_lrb *lrbp) > +{ > + u32 upiu_flags; > + int ret = 0; > + > +

Re: [PATCH V2] scsi: ufs: Add fDeviceInit set flag during initialization

2013-05-08 Thread Santosh Y
rnings mentioned by Dan in the previous mail. Re-base it on Seungwon's V4 patch series and you can add my Acked-by: Santosh Y > + "%s: NULL pointer hba = %p, query = %p response = > %p\n", > +

Re: [PATCH] scsi: megaraid: check kzalloc

2013-05-23 Thread Santosh Y
On Fri, May 24, 2013 at 7:52 AM, Libo Chen wrote: > > we should check kzalloc, avoid to hit oops > > Signed-off-by: Libo Chen > --- > drivers/scsi/megaraid.c |4 > 1 files changed, 4 insertions(+), 0 deletions(-) > > diff --git a/drivers/scsi/megaraid.c b/drivers/scsi/megaraid.c > index

kernel panic when called usb_control_msg()

2012-08-02 Thread y b
Hi, kernel panic when called usb_control_msg(), like this: usb_control_msg(serial->dev, usb_sndctrlpipe(serial->dev, 0), XR_SET_REG, USB_DIR_OUT | USB_TYPE_VENDOR, value, regnum | (block << 8), NULL, 0, 5000) The kernel's version is 2.6.33_rc4, but I think it will happen in lastest statable vers

class_device_create() and the mode of the device file in /dev.

2007-05-22 Thread Y Khan
, is there anyway of achieving this in 2.6. -Y Building a website is a piece of cake. Yahoo! Small Business gives you all the tools to get online. http://smallbusiness.yahoo.com/webhosting - To

Re: class_device_create() and the mode of the device file in /dev.

2007-05-23 Thread Y Khan
nges to udev/kernel for this if people think that this is also desired by others. -Y You snooze, you lose. Get messages ASAP with AutoCheck in the all-new Yahoo! Mail Beta. http://advision.webev

Re: [PATCH net-next 4/6] net: hns3: add support for set_link_ksettings

2017-11-05 Thread lipeng (Y)
On 2017/11/4 3:52, Florian Fainelli wrote: On 11/02/2017 09:18 PM, Lipeng wrote: From: Fuyun Liang This patch adds set_link_ksettings support for ethtool cmd. Signed-off-by: Fuyun Liang Signed-off-by: Lipeng --- drivers/net/ethernet/hisilicon/hns3/hns3pf/hns3_ethtool.c | 11 +++

Re: [PATCH NET 3/3] net: hns: add configuration constraints for 1000M half

2018-08-26 Thread lipeng (Y)
On 2018/8/26 2:07, Andrew Lunn wrote: This patch is a  theoretical protect, and the problem does not really happen. I think you really get the point, do you think we need this patch? I think it is not needed. And if it was needed, it would indicate there is a bug somewhere else. Hi, Andrew

Re: [PATCH net-next 00/11] add some new features and fix some bugs

2018-01-11 Thread lipeng (Y)
On 2018/1/12 1:07, David Miller wrote: From: Peng Li Date: Thu, 11 Jan 2018 19:45:55 +0800 This patchset adds some new features and fixes some bugs: [patch 1/11] adds ethtool_ops.get_channels support for VF. [patch 2/11] removes TSO config command from VF driver. [patch 3/11] adds ethtool_op

Re: [PATCH net-next 3/5] net: hns3: add ethtool -p support for phy device

2018-01-18 Thread lipeng (Y)
On 2018/1/18 22:25, Andrew Lunn wrote: +static int hclge_set_led_status_phy(struct phy_device *phydev, int value) +{ + int ret, cur_page; + + mutex_lock(&phydev->lock); + + ret = phy_read(phydev, HCLGE_PHY_PAGE_REG); + if (ret < 0) + goto out; + else

Re: [PATCH net-next 06/20] net: hns3: Modify the update period of packet statistics

2018-01-05 Thread lipeng (Y)
On 2018/1/5 22:54, Andrew Lunn wrote: --- a/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c +++ b/drivers/net/ethernet/hisilicon/hns3/hns3_enet.c @@ -1126,6 +1126,7 @@ static int hns3_nic_set_features(struct net_device *netdev, { struct hns3_nic_priv *priv = netdev_priv(netdev);

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 9:54, David Miller wrote: From: Jakub Kicinski Date: Mon, 8 Jan 2018 17:50:21 -0800 Oh, I only noticed this extra misleading comment now. Unless each queue has a netdev, I don't see how these are per-queue. If it isn't per-queue I want this change reverted. [patch 12/20 ] add

Re: [PATCH net-next 12/20] net: hns3: Add packet statistics of netdev

2018-01-08 Thread lipeng (Y)
On 2018/1/9 11:06, David Miller wrote: From: "lipeng (Y)" Date: Tue, 9 Jan 2018 10:48:04 +0800 So I think it is OK if you can revert [patch 12/20 ]("net: hns3: Add packet statistics of netdev"). I think it is OK if you send the revert patch, which is what I am asking

Re: possible deadlock in perf_event_detach_bpf_prog

2018-04-08 Thread Y Song
On Thu, Mar 29, 2018 at 2:18 PM, Daniel Borkmann wrote: > On 03/29/2018 11:04 PM, syzbot wrote: >> Hello, >> >> syzbot hit the following crash on upstream commit >> 3eb2ce825ea1ad89d20f7a3b5780df850e4be274 (Sun Mar 25 22:44:30 2018 +) >> Linux 4.16-rc7 >> syzbot dashboard link: >> https://syz

Re: [PATCH net-next 00/23] net: hns3: HNS3 bug fixes & code improvements

2018-03-08 Thread lipeng (Y)
On 2018/3/8 13:00, David Miller wrote: Sorry, this is way too large of a patch series. Please keep your series to about a dozen or so changes. Anything longer puts an unreasonable burdon upon patch reviewers, and such a large series will often make it so that nearly all reviewers are discoura

Re: [PATCH bpf] bpf: allocate local storage buffers using GFP_ATOMIC

2018-11-16 Thread Y Song
On Wed, Nov 14, 2018 at 6:01 PM Roman Gushchin wrote: > > Naresh reported an issue with the non-atomic memory allocation of > cgroup local storage buffers: > > [ 73.047526] BUG: sleeping function called from invalid context at > /srv/oe/build/tmp-rpb-glibc/work-shared/intel-corei7-64/kernel-sour

Re: [PATCH 2/4] net/bpf: refactor freeing of executable allocations

2018-11-18 Thread Y Song
On Sun, Nov 18, 2018 at 3:55 PM Ard Biesheuvel wrote: > > On Sat, 17 Nov 2018 at 23:47, Y Song wrote: > > > > On Sat, Nov 17, 2018 at 6:58 PM Ard Biesheuvel > > wrote: > > > > > > All arch overrides of the __weak bpf_jit_free() amount to the same &

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-25 Thread Y Song
On Fri, May 25, 2018 at 8:21 AM, Alban Crequy wrote: > On Wed, May 23, 2018 at 4:34 AM Y Song wrote: > >> I did a quick prototyping and the above interface seems working fine. > > Thanks! I gave your kernel patch & userspace program a try and it works for > me on cgroup-

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-14 Thread Y Song
On Sun, May 13, 2018 at 10:33 AM, Alban Crequy wrote: > From: Alban Crequy > > bpf_get_current_cgroup_ino() allows BPF trace programs to get the inode > of the cgroup where the current process resides. > > My use case is to get statistics about syscalls done by a specific > Kubernetes container.

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
lirc daemon. > > +config BPF_RAWIR_EVENT > + bool "Support for eBPF programs attached to lirc devices" > + depends on BPF_SYSCALL > + depends on RC_CORE=y > + depends on LIRC > + help > + Allow attaching eBPF progra

Re: [PATCH v3 2/2] bpf: add selftest for rawir_event type program

2018-05-17 Thread Y Song
t; +} > + > +char _license[] SEC("license") = "GPL"; > diff --git a/tools/testing/selftests/bpf/test_rawir_event_user.c > b/tools/testing/selftests/bpf/test_rawir_event_user.c > new file mode 100644 > index ..c3d7f2c68033 > --- /dev/null > +++ b/tools/testing/selftests/bpf/test_rawir_event_user.c > @@ -0,0 +1,130 @@ > +// SPDX-License-Identifier: GPL-2.0 > +// test ir decoder > +// > +// Copyright (C) 2018 Sean Young > + > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > +#include > + > +#include "bpf_util.h" > +#include > +#include > + > +int main(int argc, char **argv) > +{ > + struct bpf_object *obj; > + int ret, lircfd, progfd, mode; > + int testir = 0x1dead; > + u32 prog_ids[10], prog_flags[10], prog_cnt; > + > + if (argc != 2) { > + printf("Usage: %s /dev/lircN\n", argv[0]); Most people probably not really familiar with lircN device. It would be good to provide more information about how to enable this, e.g., CONFIG_RC_CORE=y CONFIG_BPF_RAWIR_EVENT=y CONFIG_RC_LOOPBACK=y .. Thanks!

Re: [PATCH v3 1/2] media: rc: introduce BPF_PROG_RAWIR_EVENT

2018-05-17 Thread Y Song
On Thu, May 17, 2018 at 2:45 PM, Sean Young wrote: > Hi, > > Again thanks for a thoughtful review. This will definitely will improve > the code. > > On Thu, May 17, 2018 at 10:02:52AM -0700, Y Song wrote: >> On Wed, May 16, 2018 at 2:04 PM, Sean Young wro

Re: [PATCH v4 1/3] bpf: bpf_prog_array_copy() should return -ENOENT if exclude_prog not found

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: > This makes is it possible for bpf prog detach to return -ENOENT. > > Signed-off-by: Sean Young Acked-by: Yonghong Song

Re: [PATCH v4 2/3] media: rc: introduce BPF_PROG_LIRC_MODE2

2018-05-18 Thread Y Song
e lirc daemon. > > +config BPF_LIRC_MODE2 > + bool "Support for eBPF programs attached to lirc devices" > + depends on BPF_SYSCALL > + depends on RC_CORE=y > + depends on LIRC > + help > + Allow attaching eBPF progra

Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
sample as passed into > + * the program. > + * > + * The *protocol* is the decoded protocol number (see > + * **enum rc_proto** for some predefined values). > + * > + * This helper is only available is the kernel was compiled with >

Re: [PATCH v4 3/3] bpf: add selftest for lirc_mode2 type program

2018-05-18 Thread Y Song
On Fri, May 18, 2018 at 1:17 PM, Y Song wrote: > On Fri, May 18, 2018 at 7:07 AM, Sean Young wrote: >> This is simple test over rc-loopback. >> >> Signed-off-by: Sean Young > > Acked-by: Yonghong Song Just one minor thing. You need to add "test_lirc_mode2_user

Re: [PATCH net-next] net: hns3: Config NIC port speed same as that of optical module

2019-01-02 Thread lipeng (Y)
On 2019/1/1 9:22, dann frazier wrote: On Mon, Nov 26, 2018 at 06:43:00PM +, Salil Mehta wrote: From: Peng Li Port 0/1 of HiP08 supports 10G and 25G. This patch adds a change to configure NIC port speed same as that of optical module(SFP/QFSP). Driver gets the optical module speed and s

Re: [RFC PATCH v3 1/2] KVM: arm64: Move CMOs from user_mem_abort to the fault handlers

2021-04-08 Thread wangyanan (Y)
Hi Alex, On 2021/4/7 23:31, Alexandru Elisei wrote: Hi Yanan, On 3/26/21 3:16 AM, Yanan Wang wrote: We currently uniformly permorm CMOs of D-cache and I-cache in function user_mem_abort before calling the fault handlers. If we get concurrent guest faults(e.g. translation faults, permission fau

Re: [RFC PATCH v3 2/2] KVM: arm64: Distinguish cases of memcache allocations completely

2021-04-08 Thread wangyanan (Y)
On 2021/4/7 23:35, Alexandru Elisei wrote: Hi Yanan, On 3/26/21 3:16 AM, Yanan Wang wrote: With a guest translation fault, the memcache pages are not needed if KVM is only about to install a new leaf entry into the existing page table. And with a guest permission fault, the memcache pages are

Re: [PATCH v4 1/2] KVM: arm64: Move CMOs from user_mem_abort to the fault handlers

2021-04-09 Thread wangyanan (Y)
Hi Quentin, On 2021/4/9 16:08, Quentin Perret wrote: Hi Yanan, On Friday 09 Apr 2021 at 11:36:51 (+0800), Yanan Wang wrote: diff --git a/arch/arm64/kvm/hyp/pgtable.c b/arch/arm64/kvm/hyp/pgtable.c +static void stage2_invalidate_icache(void *addr, u64 size) +{ + if (icache_is_aliasing())

[PATCH RESEND v0] arm64: dts: Add APM X-Gene standby GPIO controller DTS entries

2015-06-16 Thread Y Vo
Add standby domain gpio controller for APM X-Gene SoC platform. Signed-off-by: Y Vo --- arch/arm64/boot/dts/apm/apm-storm.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi

[PATCH v0] arm64: dts: Add poweroff button device node for APM X-Gene platform

2015-06-16 Thread Y Vo
This patch adds poweroff button device node to support poweroff feature on APM X-Gene Mustang platform. Signed-off-by: Y Vo --- arch/arm64/boot/dts/apm/apm-mustang.dts | 11 +++ 1 files changed, 11 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/apm/apm-mustang.dts b

[PATCH v0] arm64: dts: Add APM X-Gene standby GPIO controller DTS entries

2015-06-04 Thread Y Vo
Add standby domain gpio controller for APM X-Gene SoC platform. Signed-off-by: Y Vo --- arch/arm64/boot/dts/apm/apm-storm.dtsi | 13 + 1 files changed, 13 insertions(+), 0 deletions(-) diff --git a/arch/arm64/boot/dts/apm/apm-storm.dtsi b/arch/arm64/boot/dts/apm/apm-storm.dtsi

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-22 Thread Y Song
anosleep cgid = 106b2 ^C[yhs@localhost tools]$ The kernel and user space cgid matches. Will provide a formal patch later. On Mon, May 21, 2018 at 5:24 PM, Y Song wrote: > On Mon, May 21, 2018 at 9:26 AM, Alexei Starovoitov > wrote: >> On Sun, May 13, 2018 at 07:33:18PM +0200,

Re: [PATCH] [RFC] bpf: tracing: new helper bpf_get_current_cgroup_ino

2018-05-22 Thread Y Song
On Tue, May 22, 2018 at 8:35 PM, Alexei Starovoitov wrote: > On Tue, May 22, 2018 at 08:33:24PM -0700, Y Song wrote: >> + struct cgroup *cgrp = task_dfl_cgroup(current); >> + if (!cgrp) >> + return -EINVAL; > > why this check is needed? No

Re: [PATCH v1 1/4] media: rc: introduce BPF_PROG_IR_DECODER

2018-05-14 Thread Y Song
@@ config IR_IMON_DECODER >remote control and you would like to use it with a raw IR >receiver, or if you wish to use an encoder to transmit this IR. > > +config IR_BPF_DECODER > + bool "Enable IR raw decoder using BPF" > + depends

Re: [PATCH v1 2/4] media: bpf: allow raw IR decoder bpf programs to be used

2018-05-14 Thread Y Song
On Mon, May 14, 2018 at 2:10 PM, Sean Young wrote: > This implements attaching, detaching, querying and execution. The target > fd has to be the /dev/lircN device. > > Signed-off-by: Sean Young > --- > drivers/media/rc/ir-bpf-decoder.c | 191 ++ > drivers/media/rc/lir

Re: [PATCH v1 3/4] media: rc bpf: move ir_raw_event to uapi

2018-05-14 Thread Y Song
On Mon, May 14, 2018 at 2:11 PM, Sean Young wrote: > The context provided to a BPF_PROG_RAWIR_DECODER is a struct ir_raw_event; > ensure user space has a a definition. > > Signed-off-by: Sean Young > --- > include/media/rc-core.h| 19 +-- > include/uapi/linux/bpf_rcdev.h

Re: [PATCH v1 4/4] samples/bpf: an example of a raw IR decoder

2018-05-14 Thread Y Song
Makefile > +++ b/samples/bpf/Makefile > @@ -44,6 +44,7 @@ hostprogs-y += xdp_monitor > hostprogs-y += xdp_rxq_info > hostprogs-y += syscall_tp > hostprogs-y += cpustat > +hostprogs-y += grundig_decoder > > # Libbpf dependencies > LIBBPF := ../../tools/lib/bpf/bpf.o ../../t

Re: [RFC PATCH 0/4] KVM: arm64: Improve efficiency of stage2 page table

2021-02-23 Thread wangyanan (Y)
Hi Alex, On 2021/2/23 23:55, Alexandru Elisei wrote: Hi Yanan, I wanted to review the patches, but unfortunately I get an error when trying to apply the first patch in the series: Applying: KVM: arm64: Move the clean of dcache to the map handler error: patch failed: arch/arm64/kvm/hyp/pgtable.

Re: [RFC PATCH 0/4] KVM: arm64: Improve efficiency of stage2 page table

2021-02-24 Thread wangyanan (Y)
On 2021/2/25 1:20, Alexandru Elisei wrote: Hi, On 2/24/21 2:35 AM, wangyanan (Y) wrote: Hi Alex, On 2021/2/23 23:55, Alexandru Elisei wrote: Hi Yanan, I wanted to review the patches, but unfortunately I get an error when trying to apply the first patch in the series: Applying: KVM

Re: [PATCH 03/15] KVM: selftests: Align HVA for HugeTLB-backed memslots

2021-02-24 Thread wangyanan (Y)
Hi Sean, On 2021/2/11 7:06, Sean Christopherson wrote: Align the HVA for HugeTLB memslots, not just THP memslots. Add an assert so any future backing types are forced to assess whether or not they need to be aligned. Cc: Ben Gardon Cc: Yanan Wang Cc: Andrew Jones Cc: Peter Xu Cc: Aaron Lew

Re: [PATCH 04/15] KVM: selftests: Force stronger HVA alignment (1gb) for hugepages

2021-02-25 Thread wangyanan (Y)
On 2021/2/11 7:06, Sean Christopherson wrote: Align the HVA for hugepage memslots to 1gb, as opposed to incorrectly assuming all architectures' hugepages are 512*page_size. For x86, multiplying by 512 is correct, but only for 2mb pages, e.g. systems that support 1gb pages will never be able to

Re: [RFC PATCH 1/2] KVM: selftests: Add a macro to get string of vm_mem_backing_src_type

2021-02-09 Thread wangyanan (Y)
On 2021/2/10 1:35, Sean Christopherson wrote: On Tue, Feb 09, 2021, Ben Gardon wrote: On Tue, Feb 9, 2021 at 3:21 AM wangyanan (Y) wrote: On 2021/2/9 2:13, Ben Gardon wrote: On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: Add a macro to get string of the backing source memory type, so

Re: [RFC PATCH 2/2] KVM: selftests: Add a test for kvm page table code

2021-02-09 Thread wangyanan (Y)
On 2021/2/10 1:38, Ben Gardon wrote: On Mon, Feb 8, 2021 at 11:22 PM wangyanan (Y) wrote: Hi Ben, On 2021/2/9 4:29, Ben Gardon wrote: On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: This test serves as a performance tester and a bug reproducer for kvm page table code (GPA->HPA mappi

Re: [RFC PATCH 2/2] KVM: selftests: Add a test for kvm page table code

2021-02-10 Thread wangyanan (Y)
On 2021/2/10 1:57, Ben Gardon wrote: On Tue, Feb 9, 2021 at 1:43 AM wangyanan (Y) wrote: On 2021/2/9 4:29, Ben Gardon wrote: On Mon, Feb 8, 2021 at 1:08 AM Yanan Wang wrote: This test serves as a performance tester and a bug reproducer for kvm page table code (GPA->HPA mappings), so

Re: [PATCH][next] net: hns3: Fix uninitialized return from function

2021-02-17 Thread lipeng (Y)
在 2021/2/10 23:26, Colin King 写道: From: Colin Ian King Currently function hns3_reset_notify_uninit_enet is returning the contents of the uninitialized variable ret. Fix this by removing ret (since it is no longer used) and replace it with a return of the literal value 0. you can not remov

Re: [RFC PATCH 2/2] KVM: selftests: Add a test for kvm page table code

2021-02-08 Thread wangyanan (Y)
Hi Vitaly, On 2021/2/8 18:21, Vitaly Kuznetsov wrote: Yanan Wang writes: This test serves as a performance tester and a bug reproducer for kvm page table code (GPA->HPA mappings), so it gives guidance for people trying to make some improvement for kvm. The function guest_code() is designed t

  1   2   3   4   5   6   7   8   9   10   >