Re: [PATCH v2] watchdog: Add a device managed API for watchdog_register_device()

2016-07-17 Thread Wim Van Sebroeck
dog.h > @@ -180,4 +180,7 @@ extern int watchdog_init_timeout(struct watchdog_device > *wdd, > extern int watchdog_register_device(struct watchdog_device *); > extern void watchdog_unregister_device(struct watchdog_device *); > > +/* devres register variant */ > +int devm_watchdog_register_device(struct device *dev, struct watchdog_device > *); > + > #endif /* ifndef _LINUX_WATCHDOG_H */ > -- > 2.7.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [RFC 1/3] watchdog: change watchdog_need_worker logic

2016-07-17 Thread Wim Van Sebroeck
ve(wdd) && watchdog_hw_running(wdd)); > } > > static long watchdog_next_keepalive(struct watchdog_device *wdd) > @@ -107,7 +111,7 @@ static long watchdog_next_keepalive(struct > watchdog_device *wdd) > unsigned int hw_heartbeat_ms; > > virt_timeout = wd_data->last_keepalive + msecs_to_jiffies(timeout_ms); > - hw_heartbeat_ms = min(timeout_ms, wdd->max_hw_heartbeat_ms); > + hw_heartbeat_ms = min_not_zero(timeout_ms, wdd->max_hw_heartbeat_ms); > keepalive_interval = msecs_to_jiffies(hw_heartbeat_ms / 2); > > if (!watchdog_active(wdd)) > -- > 2.5.0 > Kind regards, Wim.

Re: [PATCH] watchdog: pcwd: Utilize the module_isa_driver macro

2016-07-17 Thread Wim Van Sebroeck
isa_driver); > - pr_info("Watchdog Module Unloaded\n"); > -} > - > -module_init(pcwd_init_module); > -module_exit(pcwd_cleanup_module); > +module_isa_driver(pcwd_isa_driver, PCWD_ISA_NR_CARDS); > > MODULE_AUTHOR("Ken Hollis , " > "Wim Van Sebroeck "); > -- > 2.7.3 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 0/3] watchdog, sbsa_gwdt: Update SBSA watchdog with the new infrastructure of watchdog.

2016-07-17 Thread Wim Van Sebroeck
gt; 2 files changed, 5 insertions(+), 3 deletions(-) > > -- > 2.5.5 > These patches have been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH V2] watchdog: f71808e_wdt: Add F81866 support

2016-07-17 Thread Wim Van Sebroeck
ind(int sioaddr) > case SIO_F81865_ID: > watchdog.type = f81865; > break; > + case SIO_F81866_ID: > + watchdog.type = f81866; > + break; > default: > pr_info("Unrecognized Fintek device: %04x\n", > (unsigned int)devid); > -- > 1.9.1 > This patch has been added to linux-watchog-next. Kind regards, Wim.

Re: [PATCH V4] watchdog: max77620: Add support for watchdog timer

2016-07-17 Thread Wim Van Sebroeck
watchdog registration failed: %d\n", ret); > + return ret; > + } > + > + return 0; > +} > + > +static int max77620_wdt_remove(struct platform_device *pdev) > +{ > + struct max77620_wdt *wdt = platform_get_drvdata(pdev); > + > + max77620_wdt_stop(&wdt->wdt_dev); > + watchdog_unregister_device(&wdt->wdt_dev); > + > + return 0; > +} > + > +static struct platform_device_id max77620_wdt_devtype[] = { > + { .name = "max77620-watchdog", }, > + { }, > +}; > + > +static struct platform_driver max77620_wdt_driver = { > + .driver = { > + .name = "max77620-watchdog", > + }, > + .probe = max77620_wdt_probe, > + .remove = max77620_wdt_remove, > + .id_table = max77620_wdt_devtype, > +}; > + > +module_platform_driver(max77620_wdt_driver); > + > +MODULE_DESCRIPTION("Max77620 watchdog timer driver"); > + > +module_param(nowayout, bool, 0); > +MODULE_PARM_DESC(nowayout, "Watchdog cannot be stopped once started " > + "(default=" __MODULE_STRING(WATCHDOG_NOWAYOUT) ")"); > + > +MODULE_AUTHOR("Laxman Dewangan "); > +MODULE_LICENSE("GPL v2"); > -- > 2.1.4 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] watchdog: drop redundant 'default n' option for WATCHDOG_SYSFS

2016-07-17 Thread Wim Van Sebroeck
ion through sysfs" > - default n > help > Say Y here if you want to enable watchdog device status read through > sysfs attributes. > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 1/2] watchdog: ziirave_wdt: Correct I2C device id to fix module autoloading.

2016-07-17 Thread Wim Van Sebroeck
id[] = { > - { "ziirave-wdt", 0 }, > + { "rave-wdt", 0 }, > { } > }; > MODULE_DEVICE_TABLE(i2c, ziirave_wdt_id); > -- > 2.1.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH v3 0/3] watchdog: Add Amlogic Meson GXBB Watchdog Timer driver

2016-07-17 Thread Wim Van Sebroeck
cetree/bindings/watchdog/meson-gxbb-wdt.txt > create mode 100644 drivers/watchdog/meson_gxbb_wdt.c > > -- > 2.7.0 > This patches have been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 1/3] watchdog: bcm2835_wdt: constify _ops and _info structures

2016-07-17 Thread Wim Van Sebroeck
WDIOF_KEEPALIVEPING, > .identity = "Broadcom BCM2835 Watchdog timer", > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 2/3] watchdog: bcm2835_wdt: remove redundant ->set_timeout callback

2016-07-17 Thread Wim Van Sebroeck
, > - .set_timeout = bcm2835_wdt_set_timeout, > .get_timeleft = bcm2835_wdt_get_timeleft, > }; > > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [RFC 1/3] watchdog: change watchdog_need_worker logic

2016-07-17 Thread Wim Van Sebroeck
Hi Guenter, > On 07/17/2016 12:24 PM, Wim Van Sebroeck wrote: > >Hi Rasmus, > > > >>If the driver indicates that the watchdog is running, the framework > >>should feed it until userspace opens the device, regardless of whether > >>the driver has set max

Re: [RFC 1/3] watchdog: change watchdog_need_worker logic

2016-07-17 Thread Wim Van Sebroeck
_device *wdd) > @@ -107,7 +111,7 @@ static long watchdog_next_keepalive(struct > watchdog_device *wdd) > unsigned int hw_heartbeat_ms; > > virt_timeout = wd_data->last_keepalive + msecs_to_jiffies(timeout_ms); > - hw_heartbeat_ms = min(timeout_ms, wdd->max_hw_heartbeat_ms); > + hw_heartbeat_ms = min_not_zero(timeout_ms, wdd->max_hw_heartbeat_ms); > keepalive_interval = msecs_to_jiffies(hw_heartbeat_ms / 2); > > if (!watchdog_active(wdd)) > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v4.9 merge window

2016-10-12 Thread Wim Van Sebroeck
ned-off-by: Vladimir Zapolskiy Reviewed-by: Guenter Roeck Reviewed-by: Wolfram Sang Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 2accf320786210db92f36866cc71fa894f510a4a Author: Wolfram Sang Date: Fri Oct 7 15:41:38 2016 +0300 watchdog: softdog:

Re: [GIT PULL REQUEST] watchdog - v4.9 merge window

2016-10-12 Thread Wim Van Sebroeck
Hi Linus, It's an old server with only 512Mb RAM. I'm in the progress off replacing it (in another datacenter). Meanwhile I'll restart git-daemon. Sorry, Wim. > On Wed, Oct 12, 2016 at 11:35 AM, Wim Van Sebroeck wrote: > > Hi Linus, > > > > Please pull fro

Re: [PATCH v5] watchdog: ziirave_wdt: Add support to upload the firmware.

2016-10-08 Thread Wim Van Sebroeck
t; firmware upload or the firmware verification fails then we print and > error message and exit. > > Signed-off-by: Enric Balletbo i Serra This patch was added to linux-watchdog-next almost 2 weeks ago. Kind regards, Wim.

Re: [PATCH] watchdog-asm9260: Delete owner assignment

2016-10-08 Thread Wim Van Sebroeck
tch was added to linux-watchdog-next almost 2 weeks ago. Kind regards, Wim.

Re: [PATCH 10/19] watchdog: bindings: Remove obsolete platforms from dt doc.

2016-10-08 Thread Wim Van Sebroeck
2 weeks ago. Kind regards, Wim.

Re: [PATCH] watchdog: hpwdt: add support for iLO5

2016-10-08 Thread Wim Van Sebroeck
> Signed-off-by: Brian Boylston > --- This patch was added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] watchdog: iTCO_wdt: constify iTCO_wdt_pm structure

2016-10-08 Thread Wim Van Sebroeck
Hi Julia, > iTCO_wdt_pm, of type struct dev_pm_ops, is never modified, so declare it as > const. > > Done with the help of Coccinelle. > > Signed-off-by: Julia Lawall This patch and your constify watchdog_ops structures were added to linux-watchdog-next almost 2 weeks ago. Kind regards, Wim.

Re: [PATCH] watchdog: rt2880_wdt: Remove assignment of dev pointer

2016-10-08 Thread Wim Van Sebroeck
880_wdt.o' failed > > Fix this by removing the assignment. > > Fixes: 0254e953537c > Signed-off-by: Matt Redfearn > --- This patch and a similar patch from Guenter regarding mt7621_wdt was added to linux-watchdog-next almost 2 weeks ago. Kind regards, Wim.

Re: linux-next: unable to fetch the watchdog tree

2016-11-14 Thread Wim Van Sebroeck
Hi Stephen, This has been fixed. Thanks for notifying me about it. Kind regards, Wim. > Hi Wim, > > For the past few days (nearly a week, sorry) fetching the watchdog tree > (git://www.linux-watchdog.org/linux-watchdog-next.git#master) has > resulted in a hung connection. &g

Re: Stopping watchdog in watchdog driver remove functions

2017-01-01 Thread Wim Van Sebroeck
also results in a reboot of the system). if WDIOF_MAGICCLOSE is not being used then closing the watchdog device means that the driver needs to stop the watchdog. Kind regards and happy new year to you all, Wim.

[GIT PULL REQUEST] watchdog - v4.10 merge window

2016-12-23 Thread Wim Van Sebroeck
following patches: * Add da9062/61 watchdog driver * Add Loongson1 SoC watchdog driver * Add IT8620E watchdog device * module load /uload fixes for bcm7083_wdt, max77620_wdt and jz4740 * intel-mid_wdt fixes * and other fixes and cleanups Greetings, Wim.

Re: [GIT PULL REQUEST] watchdog - v4.10 merge window

2016-12-24 Thread Wim Van Sebroeck
; >it over and there's nothing surprising to that person either. > > > > Ok, point taken. Guess Wim should have asked me to send the pull request. Yep, co-maintainership is not well defined I guess. I will sent out a new pull-request with the necessary info in it. Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v4.10 merge window

2016-12-24 Thread Wim Van Sebroeck
,bcm7038-wdt Signed-off-by: Javier Martinez Canillas Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck For completeness, I added the overal diff below. Greetings, Wim. diff --git a/MAINTAINER

Re: linux-next: unable to fetch the watchdog tree

2016-12-05 Thread Wim Van Sebroeck
Hi Stephen, Yes, I am setting up a new server. Kind regards, Wim. > Hi Wim, > > On Tue, 22 Nov 2016 09:49:19 +1100 Stephen Rothwell > wrote: > > > > On Mon, 14 Nov 2016 16:26:16 +0100 Wim Van Sebroeck wrote: > > > > > > This has be

Re: [PATCH 1/1] watchdog: pcipcwd_show_card_info: wrong format string

2016-11-06 Thread Wim Van Sebroeck
b() returns a char on some architectures, meaning it is signed, > meaning it _could_ return a negative number if the version number is 128 > or above. I don't want to risk us reporting version number -128.-110 just > to make compilers happy. I couldn't have said this better myself :-) version info is indeed to be consider as an unsigned int. Kind regards, Wim.

Re: [PATCH 1/3] watchdog: ts4800: add hardware dependency

2016-03-04 Thread Wim Van Sebroeck
Hi Jean, > The Technologic Systems TS-4800 is an i.MX515 board, so its drivers > are useless unless building a SOC_IMX51 kernel, except for build > testing purposes. > > Signed-off-by: Jean Delvare > Cc: Damien Riegel > Cc: Rob Herring > Cc: Guenter Roeck

Re: [PATCH v2] watchdog: w83627hf: Added NCT6102D support.

2016-03-04 Thread Wim Van Sebroeck
cr_wdt_timeout = NCT6102D_WDT_TIMEOUT; > + cr_wdt_control = NCT6102D_WDT_CONTROL; > + cr_wdt_csr = NCT6102D_WDT_CSR; > + break; > case 0xff: > ret = -ENODEV; > break; > @@ -422,6 +437,7 @@ static int __init wdt_init(void) > "NCT6779", > "NCT6791", > "NCT6792", > + "NCT6102", > }; > > wdt_io = 0x2e; > -- > 2.6.2 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] watchdog: orion: Depend on 32-bit ARM

2016-03-04 Thread Wim Van Sebroeck
|| ARCH_MVEBU > + depends on ARM > select WATCHDOG_CORE > help > Say Y here if to include support for the watchdog timer > -- > 2.7.1 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH for-4.5] watchdog/rc32434_wdt: fix ioctl error handling

2016-03-04 Thread Wim Van Sebroeck
through */ > case WDIOC_GETTIMEOUT: > - return copy_to_user(argp, &timeout, sizeof(int)); > + return copy_to_user(argp, &timeout, sizeof(int)) ? -EFAULT : 0; > default: > return -ENOTTY; > } > -- > MST Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] Rename "trigger" reset reason "hw watchdog"

2016-03-04 Thread Wim Van Sebroeck
LL, "illegal configuration", > "illegal instruction", "illegal trap", > "unknown"}; > -- > 2.1.4 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] watchdog: Add 'action' and 'data' parameters to restart handler callback

2016-03-04 Thread Wim Van Sebroeck
= wdd->ops->restart(wdd); > + ret = wdd->ops->restart(wdd, action, data); > if (ret) > return NOTIFY_BAD; > > diff --git a/include/linux/watchdog.h b/include/linux/watchdog.h > index 537e84e2592a..f1fccc7aea68 100644 > --- a/include/linux/watchdog.h > +++ b/include/linux/watchdog.h > @@ -47,7 +47,7 @@ struct watchdog_ops { > unsigned int (*status)(struct watchdog_device *); > int (*set_timeout)(struct watchdog_device *, unsigned int); > unsigned int (*get_timeleft)(struct watchdog_device *); > - int (*restart)(struct watchdog_device *); > + int (*restart)(struct watchdog_device *, unsigned long, void *); > long (*ioctl)(struct watchdog_device *, unsigned int, unsigned long); > }; > > -- > 2.5.0 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH v8] watchdog: Add watchdog timer support for the WinSystems EBC-C384

2016-03-04 Thread Wim Van Sebroeck
4_wdt_device = platform_device_alloc(MODULE_NAME, -1); > + if (!ebc_c384_wdt_device) > + return -ENOMEM; > + > + err = platform_device_add(ebc_c384_wdt_device); > + if (err) > + goto err_platform_device; > + > + err = platform_driver_probe(&ebc_c384_wdt_driver, ebc_c384_wdt_probe); > + if (err) > + goto err_platform_driver; > + > + return 0; > + > +err_platform_driver: > + platform_device_del(ebc_c384_wdt_device); > +err_platform_device: > + platform_device_put(ebc_c384_wdt_device); > + return err; > +} > + > +static void __exit ebc_c384_wdt_exit(void) > +{ > + platform_device_unregister(ebc_c384_wdt_device); > + platform_driver_unregister(&ebc_c384_wdt_driver); > +} > + > +module_init(ebc_c384_wdt_init); > +module_exit(ebc_c384_wdt_exit); > + > +MODULE_AUTHOR("William Breathitt Gray "); > +MODULE_DESCRIPTION("WinSystems EBC-C384 watchdog timer driver"); > +MODULE_LICENSE("GPL v2"); > +MODULE_ALIAS("platform:" MODULE_NAME); > -- > 2.4.10 > Patch added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH v14 0/4] Watchdog: introduce ARM SBSA watchdog driver

2016-03-04 Thread Wim Van Sebroeck
ode in amd-seattle-soc.dtsi > Watchdog: introduce ARM SBSA watchdog driver > > .../devicetree/bindings/watchdog/sbsa-gwdt.txt | 31 ++ > Documentation/watchdog/watchdog-parameters.txt | 7 + > arch/arm64/boot/dts/amd/amd-seattle-soc.dtsi | 8 + > arch/arm64/boot/dts/arm/foundation-v8.dts | 7 + > drivers/watchdog/Kconfig | 20 + > drivers/watchdog/Makefile | 1 + > drivers/watchdog/sbsa_gwdt.c | 408 > + > 7 files changed, 482 insertions(+) > create mode 100644 Documentation/devicetree/bindings/watchdog/sbsa-gwdt.txt > create mode 100644 drivers/watchdog/sbsa_gwdt.c > > -- > 2.5.0 > Patchset added to linux-watchdog-next. Kind regards, Wim.

Re: [RFC PATCH] watchdog: s3c2410_wdt: Add max and min timeout values

2016-03-06 Thread Wim Van Sebroeck
7,6 +580,9 @@ static int s3c2410wdt_probe(struct platform_device *pdev) > return ret; > } > > + wdt->wdt_device.min_timeout = 1; > + wdt->wdt_device.max_timeout = s3c2410wdt_max_timeout(wdt->clock); > + > ret = s3c2410wdt_cpufreq_register(wdt); > if (ret < 0) { > dev_err(dev, "failed to register cpufreq\n"); > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 5/6] watchdog: atlas7_wdt: test clock rate to avoid division by 0

2016-03-06 Thread Wim Van Sebroeck
; wdt->clk = clk; > atlas7_wdd.min_timeout = 1; > atlas7_wdd.max_timeout = UINT_MAX / wdt->tick_rate; > -- > 2.7.0 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH v2] watchdog: tangox_wdt: test clock rate to avoid division by 0

2016-03-06 Thread Wim Van Sebroeck
dev_info(&pdev->dev, "SMP86xx/SMP87xx watchdog registered\n"); > > return 0; > + > + err: > + clk_disable_unprepare(dev->clk); > + return err; > } > > static int tangox_wdt_remove(struct platform_device *pdev) > -- > 2.7.0 > Patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-06 Thread Wim Van Sebroeck
> warning message. Reason is that it will now stop early, while there > may still be a substantial amount of time for keepalives from user space > to arrive. If such keepalives arrive late (for example if user space > is configured to send keepalives just a few seconds before the watchdog > times out), the message would just be noise and not provide any value. Patches 1 till 7 of this series has been added to linux-watchdog-next. Kind regards, Wim.

Re: [patch] watchdog: pnx833x_wdt: fix typo in MODULE_PARM_DESC

2016-03-06 Thread Wim Van Sebroeck
was never the case. Wonder if anyone ever noticed. > The correct fix would be to use something like > module_param_named(timeout, pnx833x_wdt_timeout, int, 0); > but of course that would change the ABI. On the other side, > 'timeout' is the documented module param

Re: [PATCH v8 0/10] watchdog: Add support for keepalives triggered by infrastructure

2016-03-07 Thread Wim Van Sebroeck
Hi Guenter, > Hi Wim, > > On Sun, Mar 06, 2016 at 11:49:56AM +0100, Wim Van Sebroeck wrote: > > Hi Guenter, > > > > > The watchdog infrastructure is currently purely passive, meaning > > > it only passes information from user space to drivers and vice ver

Re: linux-next: manual merge of the watchdog tree with the arm-soc tree

2016-03-07 Thread Wim Van Sebroeck
he tree once you picked it up. Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v4.6 Merge Window

2016-03-19 Thread Wim Van Sebroeck
n to avoid use-after-free problems. Fixes: e6c71e84e4c0 ("watchdog: Introduce WDOG_HW_RUNNING flag") Reported-by: Dan Carpenter Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 11d7aba9ceb726d86aaaca3eb5f7d79de38989c5 Author: Guenter Roeck Date

Re: [PATCH v8] watchdog: ts4800: add driver for TS-4800 watchdog

2015-12-23 Thread Wim Van Sebroeck
the phandle to the syscon node. > > > > Signed-off-by: Damien Riegel > > Acked-by: Rob Herring > > Reviewed-by: Guenter Roeck > > Hi Guenter, > > > You have reviewed this patch but not picked it up in your tree. Shall I > expect Wim to pick it up direc

Re: [PATCH v3] sp5100_tco: Add AMD Mullins platform support

2015-12-27 Thread Wim Van Sebroeck
/* End of list */ > }; > MODULE_DEVICE_TABLE(pci, sp5100_tco_pci_tbl); This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More ma

Re: [PATCH 1/2] sp5100_tco: fix the device check for SB800 and later chipsets

2015-12-27 Thread Wim Van Sebroeck
_ACPI_MMIO_EN+0, SB800_IO_PM_INDEX_REG); > val = val << 8 | inb(SB800_IO_PM_DATA_REG); > - } else { > - /* Read SBResource_MMIO from PCI config(PCI_Reg: 9Ch) */ > - pci_read_config_dword(sp5100_tco_pci, > - SP51

Re: [PATCH 2/2] sp5100_tco: Add AMD Carrizo platform support

2015-12-27 Thread Wim Van Sebroeck
> 1.9.1 > This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] watchdog: dw_wdt: fix signedness bug in dw_wdt_top_in_seconds()

2015-12-27 Thread Wim Van Sebroeck
cles is 2 ^ (16 + i) and the watchdog counts down. >*/ > - return (1 << (16 + top)) / clk_get_rate(dw_wdt.clk); > + return (1U << (16 + top)) / clk_get_rate(dw_wdt.clk); > } > > static int dw_wdt_get_top(void) > -- > 2.6.4 > Patch is

Re: [PATCH 09/10] watchdog: cadence_wdt: use to_platform_device()

2015-12-27 Thread Wim Van Sebroeck
struct platform_device, dev); > + struct platform_device *pdev = to_platform_device(dev); > struct cdns_wdt *wdt = platform_get_drvdata(pdev); > > ret = clk_prepare_enable(wdt->clk); > -- > 2.5.0 > > Patch added to linux-watchdog-next. Kind reg

Re: [PATCH v4 1/2] watchdog: imx2_wdt: add external reset support via 'ext-reset-output' dt prop

2015-12-28 Thread Wim Van Sebroeck
;, maybe ? > > >>> > > >>> > > >>> Hi Guenter, > > >>> > > >>> I don't see why a vendor prefix is necessary - its a feature of the > > >>> IMX6 watchdog supported by this driver to be able to trigger an &g

Re: [PATCH v8] watchdog: ts4800: add driver for TS-4800 watchdog

2015-12-28 Thread Wim Van Sebroeck
+ ts4800_wdt_stop(wdd); > + > + ret = watchdog_register_device(wdd); > + if (ret) { > + dev_err(&pdev->dev, > + "failed to register watchdog device\n"); > + return ret; > + } > + > + platform_set_drvd

Re: [PATCH v4] watchdog: add support for Sigma Designs SMP86xx/SMP87xx

2015-12-28 Thread Wim Van Sebroeck
rm_get_drvdata(pdev); > + > + tangox_wdt_stop(&dev->wdt); > + clk_disable_unprepare(dev->clk); > + > + unregister_restart_handler(&dev->restart); > + watchdog_unregister_device(&dev->wdt); > + > + return 0; > +} > + > +static const struct of_device_id tangox_wdt_dt_ids[] = { > + { .compatible = "sigma,smp8642-wdt" }, > + { .compatible = "sigma,smp8759-wdt" }, > + { } > +}; > +MODULE_DEVICE_TABLE(of, tangox_wdt_dt_ids); > + > +static struct platform_driver tangox_wdt_driver = { > + .probe = tangox_wdt_probe, > + .remove = tangox_wdt_remove, > + .driver = { > + .name = "tangox-wdt", > + .of_match_table = tangox_wdt_dt_ids, > + }, > +}; > + > +module_platform_driver(tangox_wdt_driver); > + > +MODULE_AUTHOR("Mans Rullgard "); > +MODULE_DESCRIPTION("SMP86xx/SMP87xx Watchdog driver"); > +MODULE_LICENSE("GPL"); > -- > 2.6.3 > This patch (together with the addition of the DT properties patch) has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v2 0/5] watchdog: Do not use 'dev' from watchdog_device in watchdog drivers

2015-12-28 Thread Wim Van Sebroeck
ropped or changed to use the parent device. > One driver sets the variable during initialization to the watchdog > driver's parent device, which is wrong and was removed. > > v2: Use parent device for dev_XXX messages instead of pr_XXX. This patchset has been added to li

Re: [PATCH] MAINTAINERS: Add Guenter Roeck as reviewer of watchdog drivers

2015-12-28 Thread Wim Van Sebroeck
3..b1e3da7dc393 100644 > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -11602,6 +11602,7 @@ F:drivers/input/tablet/wacom_serial4.c > > WATCHDOG DEVICE DRIVERS > M: Wim Van Sebroeck > +R: Guenter Roeck > L: linux-watch...@vger.kernel.org > W: http://www.lin

Re: [PATCH v2 0/6] watchdog: Replace driver based refcounting

2015-12-29 Thread Wim Van Sebroeck
nst > parallel device removal in the driver core code, and file access > functions won't be called before the function returns. > Remove previously added message "watchdog still running". It wasn't > there before, and we should avoid user visible changes. &g

[PATCH] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
, and am not sure what to do about it. Signed-off-by: Wim de With --- drivers/staging/gdm72xx/gdm_wimax.c | 17 + drivers/staging/gdm72xx/wm_ioctl.h | 7 ++- 2 files changed, 19 insertions(+), 5 deletions(-) diff --git a/drivers/staging/gdm72xx/gdm_wimax.c b/drivers/st

Re: [PATCH] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On 10-12-2015 10:37, Dan Carpenter wrote: > On Thu, Dec 10, 2015 at 10:11:12AM +0100, Wim de With wrote: >> @@ -482,8 +483,16 @@ static int gdm_wimax_ioctl(struct net_device *dev, >> struct ifreq *ifr, int cmd) >> /* NOTE: gdm_update

[PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
This fixes the sparse warnings about dereferencing a userspace pointer. Once I updated the sparse annotations, I noticed a bug in gdm_wimax_ioctl() where we pass a user space pointer to gdm_update_fsm() which dereferences it. I fixed this. Signed-off-by: Wim de With --- drivers/staging/gdm72xx

Re: [PATCH v2] staging: gdm72xx: add userspace data struct

2015-12-10 Thread Wim de With
On Thu, Dec 10, 2015 at 02:44:45PM +, One Thousand Gnomes wrote: > (except that you mean sizeof(struct fsm_s) and it doesn't compile at the > moment! Oops, sloppy mistake. > data_s can just be modified to be __user. All uses of it follow that > rule. What do you mean? The data still needs to

[PATCH v3] staging: gdm72xx: add userspace data struct

2015-12-11 Thread Wim de With
This fixes the sparse warnings about dereferencing a userspace pointer. Once I updated the sparse annotations, I noticed a bug in gdm_wimax_ioctl() where we pass a user space pointer to gdm_update_fsm() which dereferences it. I fixed this. Signed-off-by: Wim de With --- drivers/staging/gdm72xx

[GIT PULL REQUEST] watchdog - v4.5-rc Fixes

2016-02-04 Thread Wim Van Sebroeck
5 23:24:14 2016 +0100 watchdog: Fix dependencies for !HAS_IOMEM archs Not every arch has io memory. So, unbreak the build by fixing the dependencies. Signed-off-by: Richard Weinberger Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Se

[GIT PULL REQUEST] watchdog - v5.8 Merge window

2020-06-03 Thread Wim Van Sebroeck
/watchdog/arm_smc_wdt.c Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v5.10 Merge window

2020-10-21 Thread Wim Van Sebroeck
| 8 +- 15 files changed, 374 insertions(+), 48 deletions(-) create mode 100644 Documentation/devicetree/bindings/watchdog/toshiba,visconti-wdt.yaml create mode 100644 drivers/watchdog/visconti_wdt.c Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v4.12-rc1 Fixes

2017-05-20 Thread Wim Van Sebroeck
db730dc208 ("watchdog: bcm281xx: Watchdog Driver") Signed-off-by: Eric Anholt Reviewed-by: Florian Fainelli Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 07441a7dd11f6855bcf55fbbfc6abba42258b2c6 Author: Wei Yongjun Date

[GIT PULL REQUEST] watchdog - v4.13-rc1 Merge Window

2017-07-11 Thread Wim Van Sebroeck
nter Roeck Signed-off-by: Wim Van Sebroeck commit e7bf02895f06c0603af800c4bfce3ca4ede9147d Author: Keiji Hayashibara Date: Wed Jun 14 16:53:44 2017 +0900 watchdog: uniphier: add UniPhier watchdog driver Add a watchdog driver for Socionext UniPhier series SoC. Note that the tim

Re: [v6,3/3] watchdog: introduce CONFIG_WATCHDOG_OPEN_TIMEOUT

2017-07-11 Thread Wim Van Sebroeck
> > permanent update of the kernel command line. > > > > Signed-off-by: Rasmus Villemoes > > Wim, any thoughts on making this configurable ? I used to be opposed to it, > but it does seem to make some sense to me now after thinking about it. I will look at it later this week. Kind regards, Wim.

Re: [PATCH V4] PCI: Add Extended Tags quirk for Broadcom HT2100 Root Port

2017-07-12 Thread Wim ten Have
l devices we've already > enumerated, and all devices we'll enumerate in the future are handled in > pci_configure_device(). > > Reported-by: Wim ten Have > Link: https://bugzilla.redhat.com/show_bug.cgi?id=1467674 > Fixes: 60db3a4d8cc9 ("PCI: Enable PCIe Extended

Re: [PATCH V4 0/3] add UniPhier watchdog support

2017-07-06 Thread Wim Van Sebroeck
you tell me the current state of this series? > > > > > >I will pick up 3/3. (It should have been sent to ARM-SoC ML, though.) > > > >I had sent my PRs for v4.13 before Rob acked the DT binding. > >Please look forward to v4.14. > > > > 1/3 and 2/3 are in -next, so they should be be included in Wim's pull > request > for 4.13. That's correct. Kind regards, Wim.

Re: [PATCH V2] PCI: Do not enable extended tags on pre-dated (v1.x) systems

2017-07-07 Thread Wim ten Have
On Fri, 7 Jul 2017 11:01:16 -0400 Sinan Kaya wrote: > Hi Wim, > > On 7/7/2017 10:53 AM, Sinan Kaya wrote: > > According to extended tags ECN document, all PCIe receivers are expected > > to support extended tags support. It should be safe to enable extended > >

[GIT PULL REQUEST] watchdog - v4.16 merge window

2018-02-05 Thread Wim Van Sebroeck
og: xen_wdt: use the watchdog subsystem watchdog: xen_wdt: remove info message and version number Rasmus Villemoes (1): watchdog: gpio_wdt: set WDOG_HW_RUNNING in gpio_wdt_stop Tomas Winkler (1): watchdog: mei_wdt: don't use of variable length array Wim Van Sebroeck (1

[GIT PULL REQUEST] watchdog - v4.16 merge window

2018-02-07 Thread Wim Van Sebroeck
xen_wdt: remove info message and version number Rasmus Villemoes (1): watchdog: gpio_wdt: set WDOG_HW_RUNNING in gpio_wdt_stop Tomas Winkler (1): watchdog: mei_wdt: don't use of variable length array Wim Van Sebroeck (1): Change my E-mail address. .../bindings/watchdog/co

Re: [GIT PULL REQUEST] watchdog - v4.15 Fixes

2017-12-25 Thread Wim Van Sebroeck
scumbag place that allows spammers and scammers > and thus the addresses end up being on some blacklist. > > Also, all of these commits were committed less than an hour before > sending me the pull request, so I question the kind of testing they > got.. > > Linu

[GIT PULL REQUEST] watchdog - v4.15 Fixes

2017-12-17 Thread Wim Van Sebroeck
Hi Linus, here are 4 fixes for the watchdog device drivers. Please pull. Kind regards, Wim. The following changes since commit f3b5ad89de16f5d42e8ad36fbdf85f705c1ae051: Merge tag 'for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/rdma/rdma (2017-12-16 13:43:08 -

[GIT PULL REQUEST] watchdog - v4.14-rc1 Merge Window

2017-09-13 Thread Wim Van Sebroeck
off-by: Arvind Yadav Reviewed-by: Guenter Roeck Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 05ce42fff3afb2904647f6a88c6dc613b5a2793a Author: Arvind Yadav Date: Wed Aug 23 22:04:08 2017 +0530 watchdog: sp805: constify amba_id amba_id are not s

Re: linux-next: manual merge of the drivers-x86 tree with the watchdog tree

2017-05-03 Thread Wim Van Sebroeck
umber of external merges to a minimum - which > > > > > is > > > > > becoming increasingly difficult lately for some reason). > > > > > > > > Sorry for not being in doubt, I just decided that Ack from Guenter > > > > means that d

<    1   2   3   4   5