Re: [GIT PULL REQUEST] watchdog - v3.12-rc4 Fixes

2013-10-13 Thread Wim Van Sebroeck
Hi Guenter, > Looks like the diffs don't match the description. > Are those possibly the diffs from your previous pull request ? >From a 3.6 pull request to be precisely :-( I use the old mail as template and apparently forgot to change the diff... The correct diff here below

Re: [PATCH v3 1/8] watchdog: w83627hf: Convert to watchdog infrastructure

2013-10-28 Thread Wim Van Sebroeck
G_TIMEOUT) "."); > > -static bool nowayout = WATCHDOG_NOWAYOUT; > -module_param(nowayout, bool, 0); > -MODULE_PARM_DESC(nowayout, > - "Watchdog cannot be stopped once started (default=" > - __MODULE_STRING(WATCHDOG_NO

Re: [PATCH v4] watchdog: w83627hf: Convert to watchdog infrastructure

2013-10-28 Thread Wim Van Sebroeck
the entire series. Let me review the other patches still before we do any re-sending. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [PATCH 0/3] watchdog: dw_wdt: common clock framework and devicetree support

2013-10-29 Thread Wim Van Sebroeck
2 files changed, 36 insertions(+), 13 deletions(-) > create mode 100644 > Documentation/devicetree/bindings/watchdog/snps-dw-apb-wdt.txt patches 1 and 2 have been added to linux-watchdog-next. Patch 3 has been replaced with Dinh Nguyen's patch (watchdog: dw: Enable OF support for DW watch

Re: [PATCH] imx2_wdt: expose module alias for loading from device-tree

2013-10-29 Thread Wim Van Sebroeck
l */ } > }; > +MODULE_DEVICE_TABLE(of, imx2_wdt_dt_ids); > > static struct platform_driver imx2_wdt_driver = { > .remove = __exit_p(imx2_wdt_remove), This has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscri

Re: [PATCH V2 03/35] watchdog: use dev_get_platdata()

2013-10-29 Thread Wim Van Sebroeck
deletions(-) This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] documentation/devicetree: Move DT bindigns from gpio to watchdog

2013-10-29 Thread Wim Van Sebroeck
> Cc: Pawel Moll > Cc: Mark Rutland > Cc: Stephen Warren > Cc: Ian Campbell > Cc: Rob Landley > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > --- > .../bindings/{gpio => watchdog}/men-a021-wdt.txt |0 > 1 file changed, 0 insertions(+), 0 deletions(-

Re: [PATCH 8/9] watchdog: sp805_wdt: Remove unnecessary amba_set_drvdata()

2013-10-29 Thread Wim Van Sebroeck
) > > Signed-off-by: Michal Simek This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.or

Re: [PATCH v5 0/4] watchdog: at91sam9_wdt: handle already configured wdt

2013-10-29 Thread Wim Van Sebroeck
/boot/dts/at91sam9g45.dtsi |5 + > arch/arm/boot/dts/at91sam9n12.dtsi |5 + > arch/arm/boot/dts/at91sam9x5.dtsi |5 + > arch/arm/boot/dts/kizbox.dts |6 + > arch/arm/boot/dts/sama5d3.dtsi |

Re: [PATCH] watchdog: Get rid of MODULE_ALIAS_MISCDEV statements

2013-10-29 Thread Wim Van Sebroeck
ed as a dependency) can't even be unloaded! > > If defining char-major-10-130 is needed then it should happen in > user-space. > > Signed-off-by: Jean Delvare > Cc: Wim Van Sebroeck > Cc: Stephen Warren > Cc: Mike Frysinger > Cc: Wan ZongShun > Cc: Ben D

Watchdog patches - overview.

2013-10-29 Thread Wim Van Sebroeck
] Documentation/watchdog: Update node name in samsung-wdt example So if something is still missing: please let it know. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo inf

Re: Watchdog patches - overview.

2013-10-29 Thread Wim Van Sebroeck
t; [PATCH] Documentation/watchdog: Update node name in samsung-wdt example And also: [PATCH v3] Enhanced support for MPC8xx/8xxx watchdog And the winbond mfd patches from Guenter and Myself. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH v5 0/4] watchdog: at91sam9_wdt: handle already configured wdt

2013-10-29 Thread Wim Van Sebroeck
gt; long the timer has been running. > > I'll send a new patch fixing those issues. > I hope it won't bother you :-(. No problem :-). Just sent me the fixes when they are ready. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: Watchdog patches - overview.

2013-10-29 Thread Wim Van Sebroeck
gt; 2) patches that I am reviewing or are on my radar: > > w83627hf-patches > > Orion-patches > > f81865_gpio.c > > [PATCH V2 0/4] Add watchdog DT nodes and parse it to read PMU registers > > addresses (Exynos+s3c2410_wdt) > > [PATCH v4 4/4] ARM: bcm4760:

Re: Watchdog patches - overview.

2013-10-29 Thread Wim Van Sebroeck
nk that such enhancements > should really start with a conversion to the watchdog infrastructure. > That is just my personal opinion, of course. I think the enhancement might be worthwhile, but not in it's present form. I agree that it would be nice to have the conversion also, but it&#

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-07-29 Thread Wim Van Sebroeck
enabled\n"); > > > + > > > + return 0; > > > + > > > +err_free_leds: > > > + dev_err(&pdev->dev, "failed to register LED device\n"); > > > + > > > + for (i = i - 1; i >= 0; i--) >

Re: [PATCH] Documentation: fix a typo in watchdog-api.txt

2014-07-29 Thread Wim Van Sebroeck
0 seconds, the pretimout will go off in 50 > > pretimeout > > Please correct that word also and then resend. Also resend to: > triv...@kernel.org > Can take this one through the linux-watchdog tree also. Kind regards, Wim. -- To unsubscrib

Re: [PATCH v6 0/4] Introduce MEN 14F021P00 BMC driver series

2014-09-25 Thread Wim Van Sebroeck
>> On Wed, Sep 24, 2014 at 03:48:29PM +0100, Lee Jones wrote: > > > >> > Guenter, Bryan, Wim, > > > >> > > > > >> > The following changes since commit > > > >> > 52addcf9d6669fa439387610bc65c92fa0980

Re: [PATCH 3/4] watchdog: add driver for Ricoh RN5T618 watchdog

2014-09-28 Thread Wim Van Sebroeck
+static unsigned int heartbeat = -1; > + > +module_param(heartbeat, int, 0); > +MODULE_PARM_DESC(heartbeat, "Initial watchdog heartbeat in seconds"); 1) this is actually a timeout value and not the same as the heartbeat of the watchdog device. So I prefer this also to be called a

Re: [PATCH 3/4] watchdog: add driver for Ricoh RN5T618 watchdog

2014-09-28 Thread Wim Van Sebroeck
; > +#define DRIVER_NAME "rn5t618-wdt" > > + > > +static bool nowayout = WATCHDOG_NOWAYOUT; > > +static unsigned int heartbeat = -1; > > + > > +module_param(heartbeat, int, 0); > > +MODULE_PARM_DESC(heartbeat, "Initial watchdog heartbea

Re: [PATCH v3] watchdog: add driver for Ricoh RN5T618 watchdog

2014-09-28 Thread Wim Van Sebroeck
Hi Beniamino, You have my Acked-by or Signbed-off-by on this one. I believe this goes via the mfd tree. Kind regards, Wim. > This adds a driver for the watchdog timer available in Ricoh RN5T618 > PMIC. The device supports a programmable expiration time of 1, 8, 32 > or 128 seconds. &g

Re: [PATCH v3] watchdog: add driver for Ricoh RN5T618 watchdog

2014-09-29 Thread Wim Van Sebroeck
the first place and > > > > b) why anyone would think this should go in through MFD? > > > > > > > > > > Hi Lee, > > > > > > from a previous mail [1] I (wrongly) assumed that this was going > > > through the MFD tree. If this is

Re: [PATCH] watchdog: kempld-wdt: Use the correct value when configuring the prescaler with the watchdog

2014-05-26 Thread Wim Van Sebroeck
_WDT_STAGE_CFG(stage->id), stage_cfg); > kempld_write32(pld, KEMPLD_WDT_STAGE_TIMEOUT(stage->id), > stage_timeout); This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH 3/3] watchdog: via_wdt: replace del_timer by del_timer_sync

2014-05-26 Thread Wim Van Sebroeck
+++ b/drivers/watchdog/via_wdt.c > @@ -232,7 +232,7 @@ err_out_disable_device: > static void wdt_remove(struct pci_dev *pdev) > { > watchdog_unregister_device(&wdt_dev); > - del_timer(&timer); > + del_timer_sync(&timer); > iounmap(wdt_mem); > rele

Re: [PATCHv5 0/2] imx2-wdt: Add regmap-mmio support

2014-05-26 Thread Wim Van Sebroeck
> watchdog: imx2_wdt: convert to use regmap API. > > drivers/watchdog/Kconfig| 1 + > drivers/watchdog/imx2_wdt.c | 62 > +++-- > 2 files changed, 39 insertions(+), 24 deletions(-) both patches have been added to linux-watchdog-next.

Re: [PATCH] watchdog: iop_wdt only builds for mach-iop13xx

2014-05-26 Thread Wim Van Sebroeck
13xx. > > This clarifies the dependency in Kconfig to avoid randconfig > build errors. It is unlikely that anyone will ever miss support > for this driver on the ancient iop3xx platforms, so we don't > need to bother trying to fix it properly. > > Signed-off-by: Arnd Bergmann

Re: [PATCH 1/2] watchdog: w83627hf_wdt: Add early_disable module parameter

2014-05-26 Thread Wim Van Sebroeck
outb(cr_wdt_timeout, wdog->timeout); > + } > } > > /* set second mode & disable keyboard turning off watchdog */ Has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] watchdog: Remove drivers for W83697HF and W83697UG

2014-05-26 Thread Wim Van Sebroeck
(-) > delete mode 100644 drivers/watchdog/w83697hf_wdt.c > delete mode 100644 drivers/watchdog/w83697ug_wdt.c > Has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a mess

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
Hi Maxime, > > > Guenter, since you seem to be the only responsive, may I suggest that > > > you start merging patches and do a pull request to either Wim or Linus > > > directly during the merge window? > > > > > I had prepared a pull request for Wim l

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
r. Add the restart hook to the watchdog driver, > > > > > > to be able to > > > > > > remove it from the machine code eventually. > > > > > > > > > > > > Signed-off-by: Maxime Ripard > > > > > > Acked-by: Arnd Berg

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-06-23 Thread Wim Van Sebroeck
liably > > >through the watchdog tree, I guess I should just start merging the > > >patches through mine? > > > > > > > You can not really blame Wim here. > > > > In this case, I suspect the major reason for not accepting the patch > > is that I tried to p

Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

2014-02-03 Thread Wim Van Sebroeck
t; > Signed-off-by: Richard Weinberger Patch added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordo

Re: [PATCH] watchdog,dw: Add dependency on HAS_IOMEM

2014-02-03 Thread Wim Van Sebroeck
> said archs. No, next in terms of a couple of days testing also. This will go out before 3.14-rc2 is there. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PULL REQUEST] watchdog - v3.13-rc3 Fixes

2013-12-09 Thread Wim Van Sebroeck
Signed-off-by: Alan Cox Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Partially-Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=53991 commit 9539210e17dc09ea1472076c297d461c7507a5bb Author: Guenter Roeck Date: Tue Nov 19 13:26:17 2013 -0800 watc

Re: [PATCH v8] watchdog: Add MOXA ART watchdog driver

2013-10-26 Thread Wim Van Sebroeck
> > Signed-off-by: Jonas Jensen Added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info

Re: [RFC 02/23] watchdog: omap_wdt: raw read and write endian fix

2013-11-17 Thread Wim Van Sebroeck
Signed-off-by: Taras Kondratiuk This was added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v4] watchdog: w83627hf: Convert to watchdog infrastructure

2013-11-17 Thread Wim Van Sebroeck
ret = register_reboot_notifier(&wdt_notifier); > if (ret != 0) { > @@ -364,28 +248,25 @@ static int __init wdt_init(void) > goto unreg_regions; > } > > - ret = misc_register(&wdt_miscdev); > - if (ret != 0) { > - pr_err("cannot register miscdev on minor=%d (err=%d)\n", > -WATCHDOG_MINOR, ret); > + ret = watchdog_register_device(&wdt_dev); > + if (ret) > goto unreg_reboot; > - } > > pr_info("initialized. timeout=%d sec (nowayout=%d)\n", > - timeout, nowayout); > + wdt_dev.timeout, nowayout); > > -out: > return ret; > + > unreg_reboot: > unregister_reboot_notifier(&wdt_notifier); > unreg_regions: > release_region(wdt_io, 1); > - goto out; > + return ret; > } > > static void __exit wdt_exit(void) > { > - misc_deregister(&wdt_miscdev); > + watchdog_unregister_device(&wdt_dev); > unregister_reboot_notifier(&wdt_notifier); > release_region(wdt_io, 1); > } > @@ -396,4 +277,3 @@ module_exit(wdt_exit); > MODULE_LICENSE("GPL"); > MODULE_AUTHOR("Pádraig Brady "); > MODULE_DESCRIPTION("w83627hf/thf WDT driver"); > -MODULE_ALIAS_MISCDEV(WATCHDOG_MINOR); I will add this patch with above two small corrections to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PULL REQUEST] watchdog - v3.12 merge window

2013-11-18 Thread Wim Van Sebroeck
registers. Request memory region only when needed, and use request_muxed_region(). This lets other devices (hwmon, gpio) use the same region. Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit ac461103c57ac46cd6778f1fd0352ff0e4a2d38e Author: Guenter Roeck Date: Sat

[GIT PULL REQUEST] watchdog - Fixes for v3.14-rc2

2014-02-08 Thread Wim Van Sebroeck
t-in.o: In function `dw_wdt_drv_probe': drivers/watchdog/dw_wdt.c:302: undefined reference to `devm_ioremap_resource' Signed-off-by: Richard Weinberger Signed-off-by: Wim Van Sebroeck For completeness, I added the overal diff be

Re: [PATCH v5 0/5] Update Davinci watchdog driver

2013-12-26 Thread Wim Van Sebroeck
watchdog tree ? > >> Do let me know if you want us to prepare a git branch > >> to pull from. > >> > > ping.. > > > I haven't heard anything on this yet from you Wim. > > Guenter, > I have seen you actively reviewing the $subject patch serie

Re: [PATCH v5 0/2] watchdog: bcm281xx: Watchdog Driver

2013-12-28 Thread Wim Van Sebroeck
ef CONFIG_BCM_KONA_WDT_DEBUG ... static void bcm_kona_wdt_debug_init(struct bcm_kona_wdt *wdt) { wdt->debugfs = bcm_kona_wdt_debugfs_init(wdt, &bcm_kona_wdt_wdd); } ... #else /* !CONFIG_BCM_KONA_WDT_DEBUG */ static void bcm_kona

[GIT PULL REQUEST] watchdog - v3.17-rc1 merge window

2014-08-05 Thread Wim Van Sebroeck
estart code and the watchdog driver. Add the restart hook to the watchdog driver, to be able to remove it from the machine code eventually. Signed-off-by: Maxime Ripard Acked-by: Arnd Bergmann Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Se

Re: [PATCH v3 3/3] drivers/leds/leds-menf21bmc: introduce MEN 14F021P00 BMC LED driver

2014-08-08 Thread Wim Van Sebroeck
> On 08/08/2014 12:49 AM, Andreas Werner wrote: > >On Wed, Jul 30, 2014 at 06:57:46AM -0700, Guenter Roeck wrote: > >>On 07/30/2014 01:08 AM, Andreas Werner wrote: > >>>On Tue, Jul 29, 2014 at 02:47:08PM -0700, Guenter Roeck wrote: > >>>>On 07/29/201

Re: [PATCH v2 1/6] wdt: sunxi: Move restart code to the watchdog driver

2014-08-02 Thread Wim Van Sebroeck
over to the new restart system. Anyone objections? Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 52/54] MAINTAINERS: Add file patterns for watchdog device tree bindings

2016-05-23 Thread Wim Van Sebroeck
Hi Geert, > Submitters of device tree binding documentation may forget to CC > the subsystem maintainer if this is missing. > > Signed-off-by: Geert Uytterhoeven > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: linux-watch...@vger.kernel.org > --- > Please apply

[GIT PULL REQUEST] watchdog - v4.7 Merge Window

2016-05-25 Thread Wim Van Sebroeck
rget to CC the subsystem maintainer if this is missing. Signed-off-by: Geert Uytterhoeven Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck Cc: linux-watch...@vger.kernel.org commit ae67643edc6edcab41d8d5d35cb796416b253a01 Author: William Breathitt Gray Date: Wed

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
watchdog: imx2: Convert to use infrastructure triggered > keepalives") > Signed-off-by: Guenter Roeck > --- > drivers/watchdog/watchdog_dev.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/watchdog/watchdog_dev.c b/drivers/watchdog/watchdog_dev.c > index e2c5abbb45ff..3595cffa24ea 100644 > --- a/drivers/watchdog/watchdog_dev.c > +++ b/drivers/watchdog/watchdog_dev.c > @@ -736,7 +736,6 @@ static int watchdog_release(struct inode *inode, struct > file *file) > watchdog_ping(wdd); > } > > - cancel_delayed_work_sync(&wd_data->work); > watchdog_update_worker(wdd); > > /* make sure that /dev/watchdog can be re-opened */ > -- > 2.5.0 > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] sp5100_tco: properly check for new register layouts

2016-05-14 Thread Wim Van Sebroeck
10 insertions(+), 5 deletions(-) > This patch has been added to linux-watchdog-next. Kind regards, Wim.

Re: [PATCH] watchdog: qcom: Report reboot reason

2016-05-14 Thread Wim Van Sebroeck
(+), 1 deletion(-) This patch has been added into linux-watchdog-next. Kind regards, Wim.

Re: [PATCH 2/5] watchdog: octeon: Handle the FROZEN hot plug notifier actions.

2016-05-14 Thread Wim Van Sebroeck
e it whenever the CPU goes > back online. As a result, the suspended state is no longer a special > case that leaves the watchdog active. > > Cc: Wim Van Sebroeck > Cc: Guenter Roeck > Cc: linux-watch...@vger.kernel.org > Signed-off-by: Richard Cochran > --- > dr

Re: [PATCH] watchdog: core: Fix circular locking dependency

2016-05-14 Thread Wim Van Sebroeck
Hi Guenter, > On 05/14/2016 10:07 AM, Guenter Roeck wrote: > >Hi Wim, > > > >On 05/14/2016 09:41 AM, Wim Van Sebroeck wrote: > >>Hi Guenter, > >> > >>>lockdep reports the following circular locking dependency. > >>> > > >

Re: [PATCH] watchdog: remove error message when unable to allocate watchdog device

2016-05-14 Thread Wim Van Sebroeck
a) > return -ENOMEM; > - } > > if (heartbeat < 1 || heartbeat > MAX_HEARTBEAT) > heartbeat = DEFAULT_HEARTBEAT; > -- > 2.7.4 > This patch was added to linux-watchdog-next. Kind Regards, Wim.

Re: [PATCH 1/2] watchdog: cpwd: Use setup_timer()

2016-05-14 Thread Wim Van Sebroeck
> + setup_timer(&cpwd_timer, cpwd_brokentimer, (unsigned long)p); > cpwd_timer.expires = WD_BTIMEOUT; > > pr_info("PLD defect workaround enabled for model %s\n", > -- > 1.9.1 > This patch was added to linux-watchdog-next. Kind Regards, Wim.

Re: [PATCH 2/2] watchdog: shwdt: Use setup_timer()

2016-05-14 Thread Wim Van Sebroeck
etup_timer(&wdt->timer, sh_wdt_ping, (unsigned long)wdt); > wdt->timer.expires = next_ping_period(clock_division_ratio); > > dev_info(&pdev->dev, "initialized.\n"); > -- > 1.9.1 > This patch was added to linux-watchdog-next. Kind Regards, Wim.

Re: [PATCH] Documentation: Add ebc-c384_wdt watchdog-parameters.txt entry

2016-05-14 Thread Wim Van Sebroeck
. (1<=timeout<=3600, default=TBD) > -- > 2.7.3 > This patch was added to linux-watchdog-next. Kind Regards, Wim.

Re: [RFC/RFT PATCH] watchdog: Move watchdog device creation to watchdog_dev.c

2015-12-07 Thread Wim Van Sebroeck
ee to have sysfs code in watchdog_dev.c . It belongs in watchdog_sysfs.c imho. If someone has a better idea, I'll be glad to listen to it and see what the benefits are. But I want a clean system for excluding both /dev/ (current watchdog_dev.c) and/or sysfs (watchdog_sysfs.c) in the future. Off-course the current behaviour is to have the /dev/ interface and have the option to add sysfs attributes. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC/RFT PATCH] watchdog: Move watchdog device creation to watchdog_dev.c

2015-12-15 Thread Wim Van Sebroeck
Hi Guenter, > On 12/14/2015 12:44 PM, Wim Van Sebroeck wrote: > >On Sun, Dec 13, 2015 at 10:24:35PM -0800, Guenter Roeck wrote: > > > >>On 12/13/2015 02:02 PM, Damien Riegel wrote: > >>>On Mon, Dec 07, 2015 at 09:41:03PM +0100, Wim Van Sebroeck wrote: > >

Re: [RFC/RFT PATCH] watchdog: Move watchdog device creation to watchdog_dev.c

2015-12-15 Thread Wim Van Sebroeck
Hi Pratyush, > On 15/12/2015:06:56:50 PM, Guenter Roeck wrote: > > On 12/14/2015 12:44 PM, Wim Van Sebroeck wrote: > > >On Sun, Dec 13, 2015 at 10:24:35PM -0800, Guenter Roeck wrote: > > > > > >>On 12/13/2015 02:02 PM, Damien Riegel wrote: > > >>

[GIT PULL REQUEST] watchdog - v4.4-rc3 Fixes

2015-11-27 Thread Wim Van Sebroeck
en setting watchdog mode. Add it to mtk_wdt_stop function, so that the watchdog can be stopped (e.g. during suspend). Signed-off-by: Nicolas Boichat Acked-by: Matthias Brugger Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroec

Re: [RFC/RFT PATCH] watchdog: Move watchdog device creation to watchdog_dev.c

2015-12-14 Thread Wim Van Sebroeck
On Sun, Dec 13, 2015 at 10:24:35PM -0800, Guenter Roeck wrote: > On 12/13/2015 02:02 PM, Damien Riegel wrote: > >On Mon, Dec 07, 2015 at 09:41:03PM +0100, Wim Van Sebroeck wrote: > >>Hi All, > >> > >>>On 12/07/2015 08:15 AM, Damien Riegel wrote: > &g

Re: [GIT PULL REQUEST] watchdog - v4.3-rc1 merge window

2015-09-09 Thread Wim Van Sebroeck
to pull. I just restarted the git-daemon. You should be able to pull again. Thanks for reporting it. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kerne

Re: [GIT PULL REQUEST] watchdog - v4.3-rc1 merge window

2015-09-09 Thread Wim Van Sebroeck
> fatal: read error: Connection reset by peer > > Sorry for not mentioning it earlier. The tree hasn't changed since 1.5 weeks, so on content level nothing has changed. Thanks, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body

[PATCH] staging: lustre: add __user attributes to llite/file.c

2015-12-08 Thread Wim de With
/file.c:2483:36:expected void const [noderef] * drivers/staging/lustre/lustre/llite/file.c:2483:36:got void * It simply casts pointers to __user pointers in most cases, and changes a few pointers to __user pointers. Signed-off-by: Wim de With --- drivers/staging/lustre/lustre/llite

Re: [PATCH v3 0/2] watchdog: driver for BCM7038 and newer chips.

2015-10-27 Thread Wim Van Sebroeck
100644 drivers/watchdog/bcm7038_wdt.c Patches added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] watchdog_dev: Use device tree alias for naming watchdogs

2015-10-27 Thread Wim Van Sebroeck
gt; + } > + > + if (id < 0) > + id = ida_simple_get(&watchdog_ida, 0, MAX_DOGS, GFP_KERNEL); > + > if (id < 0) > return id; > wdd->id = id; > -- > 2.1.0 > Added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v7 1/9] watchdog: Introduce hardware maximum timeout in watchdog core

2016-02-28 Thread Wim Van Sebroeck
irst patch of the series. This patch can be used even without the other patches. I also like the WDOG_HW_RUNNING flag. But I would split the patch that adds this into 2 patches: * a patch that adds the WDOG_HW_RUNNING flag * and a patch that makes the stop function optional. Thanks in advance, Wi

Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384

2016-02-28 Thread Wim Van Sebroeck
; gives 300 t = 300 -> gives 300 t = 301 -> gives 360 t = 15299 -> gives 15300 t = 15300 -> gives 15300 t = 15301 -> gives 15360 So I am also for going late. Kind regards, Wim.

Re: [PATCH v3] watchdog: Add watchdog timer support for the WinSystems EBC-C384

2016-02-28 Thread Wim Van Sebroeck
Hi Guenter, > On 02/28/2016 06:07 AM, Wim Van Sebroeck wrote: > >>>+static int ebc_c384_wdt_set_timeout(struct watchdog_device *wdev, > >>>unsigned t) > >>>+{ > >>>+ /* resolution is in minutes for timeouts greater than 255 seconds */ > &

[GIT PULL REQUEST] watchdog - v3.18 Merge window

2014-10-20 Thread Wim Van Sebroeck
t This patch removes the magic value used for rebooting the board. This value is useless and leads to a static checker warning as reported by Dan Carpenter. Signed-off-by: Carlo Caione Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Se

[PATCH] Staging: unisys: fix function declaration format in visorchipset.c

2015-05-18 Thread Wim de With
This is a patch that fixes the function declarations in visorbus/visorchipset.c by removing newlines after the function return type Signed-off-by: Wim de With --- drivers/staging/unisys/visorbus/visorchipset.c | 225 ++--- 1 file changed, 85 insertions(+), 140 deletions

Re: [PATCH] Staging: unisys: fix function declaration format in visorchipset.c

2015-05-18 Thread Wim de With
On 18-5-2015 12:45, Jes Sorensen wrote: > Wim de With writes: >> This is a patch that fixes the function declarations in >> visorbus/visorchipset.c by removing newlines after the function return >> type > > This patch doesn't fix things, it makes things worse! >

[PATCH] staging: dgnc: fix line length over 80 chars in dgnc_sysfs.c

2015-05-20 Thread Wim de With
This patch fixes most of the lines over 80 characters long in dgnc_sysfs.c. I couldn't find a way to break line 202-207 in a sensible way. If there is a way, let me know. Signed-off-by: Wim de With --- drivers/staging/dgnc/dgnc_sysfs.c | 110 +- 1

Re: [PATCH 22/28] watchdog: drop owner assignment from platform_drivers

2014-12-22 Thread Wim Van Sebroeck
Hi Wolfram, > This platform_driver does not need to set an owner, it will be populated by > the > driver core. > > Signed-off-by: Wolfram Sang Added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH 0/3] arm: msm: Use timer DT node for qcom watchdog config

2015-03-27 Thread Wim Van Sebroeck
++-- > 3 files changed, 41 insertions(+), 10 deletions(-) This patchset has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [PATCH] watchdog: cadence: Remove Kconfig dependency on ARCH

2015-03-27 Thread Wim Van Sebroeck
;Cadence Watchdog Timer" > - depends on ARM > select WATCHDOG_CORE > help > Say Y here if you want to include support for the watchdog This patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "

[GIT PULL REQUEST] watchdog - v4.0-rc5 Fixes

2015-03-27 Thread Wim Van Sebroeck
f-by: James Hogan Cc: Ezequiel Garcia Cc: Naidu Tellapati Cc: Jude Abraham Cc: linux-watch...@vger.kernel.org Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit a629c08fdb98ebb184d745553af9dda4f05941bf Author: James Hogan Date: Fri Feb 20 23:45:44 2015 +0

Re: [PATCH 21/27] watchdog: bcm281xx: Remove use of seq_printf return value

2015-03-27 Thread Wim Van Sebroeck
"Current: %d s / %d (%#x) ticks\n" > +"Busy count: %lu\n", > +res, wdt->resolution, > +ctl_sec, ctl, ctl, > +cur_sec, cur, cur, > +

Re: [PATCH] watchdog: imx2: Constify struct regmap_config and watchdog_ops

2015-02-02 Thread Wim Van Sebroeck
Hi Krzysztof, > The regmap_config struct may be const because it is not modified by the > driver and regmap_init() accepts pointer to const. Make struct > watchdog_ops const as well. > > Signed-off-by: Krzysztof Kozlowski Patch added to linux-watchdog-next. Kind regar

Re: [PATCH] watchdog: hpwdt: Fix initialization message in hpwdt.c

2015-02-02 Thread Wim Van Sebroeck
Timer Driver: NMI decoding initialized, > allow kernel dump: ON (default = 0/OFF)<= > > This "default = 0/OFF" message may confuse users. > Fix it as "default = 1/ON". > > Signed-off-by: Masanari Iida Patch has been added to linux-watchdog-next.

Re: [PATCH v5 0/2] ARM: mediatek: Add watchdog driver

2015-02-02 Thread Wim Van Sebroeck
og/mtk-wdt.txt > create mode 100644 drivers/watchdog/mtk_wdt.c > Both patches have been added to linux-watchdog-next. I made a small change: I removed the .owner field in the platform_driver struct. This is now normally set by the core. Kind regards, Wim. -- To unsubscribe from this list

Re: [PATCH v4] gpio_wdt: Add "always_running" feature to GPIO watchdog

2015-02-03 Thread Wim Van Sebroeck
ed" member keeps > track of whether a timeout must also cause a reset. > > Signed-off-by: Mike Looijmans Patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to maj

Re: [PATCH] watchdog: w83627hf_wdt: Add support for NCT6791 and NCT6792

2015-02-03 Thread Wim Van Sebroeck
Hi Guenter, > The watchdog functionality in both chips is almost identical to NCT6779. > > Signed-off-by: Guenter Roeck Patch has been added to linux-watchdog-next. Thanks for all the other reviews again. Kind regards, Wim. -- To unsubscribe from this list: send the line "uns

Re: [PATCH v3 1/2] watchdog: dw_wdt: pat the watchdog before enabling it

2015-02-03 Thread Wim Van Sebroeck
gt; so it's a good idea to also pat the watchdog manually. > > Signed-off-by: Doug Anderson Patch has been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v3 2/2] watchdog: dw_wdt: Try to get a 30 second watchdog by default

2015-02-03 Thread Wim Van Sebroeck
This patch should be considered a bit of a stopgap solution. > > Signed-off-by: Doug Anderson > Reviewed-by: Guenter Roeck This one has also been added to linux-watchdog-next. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

Re: [PATCH_V3 0/2] watchdog: jz4740: Add DT support

2015-02-03 Thread Wim Van Sebroeck
ndings/watchdog/ingenic,jz4740-wdt.txt | 12 > > drivers/watchdog/jz4740_wdt.c| 10 ++ > 2 files changed, 22 insertions(+) > create mode 100644 > Documentation/devicetree/bindings/watchdog/ingenic,jz4740-wdt.txt Both patches have been

[GIT PULL REQUEST] watchdog - v3.19 merge window

2014-12-18 Thread Wim Van Sebroeck
ult] In file included from drivers/watchdog/imx2_wdt.c:38:0: include/linux/watchdog.h:104:20: note: expected 'struct watchdog_device *' but argument is of type 'struct watchdog_device **' Reported-by: Olof's autobuilder Signed-off-by: Fabio Estevam Reviewed

[GIT PULL REQUEST] watchdog - v3.20 or 4.00 Merge window

2015-02-17 Thread Wim Van Sebroeck
cture using the same SoC bus driver (bcma) as BCM47XX but based on ARM instead of MIPS. Signed-off-by: Rafał Miłecki Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 6b96c72279cd73c1a03e97265548ce067128203a Author: Zubair Lutfullah Kakakhel Date: Tue Feb

Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter

2015-06-30 Thread Wim Van Sebroeck
> http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/ > > I see a patch has already been posted to arm-kernel but not > Cc'd to all originally involved so figured I'd mention it. It's fixed. The reason why we din't catch it was because of interference with 

[GIT PULL REQUEST] watchdog - v4.2 merge window

2015-07-01 Thread Wim Van Sebroeck
h also does not change the behavior if the parameter is not given. Signed-off-by: Lars Poeschel Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 5e53c8ed813d6100d2cebbf83f2192b201f70772 Author: Jean-Baptiste Theou Date: Tue Jun 9 09:55:03 2015 -0700 wat

[GIT PULL REQUEST] watchdog - v4.4 Merge window

2015-11-09 Thread Wim Van Sebroeck
or timeout values in kerneldoc Signed-off-by: Wolfram Sang Reviewed-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 80220fa72b917c64675f3ba4008d2c5a7b50b281 Author: Wolfram Sang Date: Tue Nov 3 09:00:15 2015 +0100 watchdog: include: fix some typos Sig

[GIT PULL REQUEST] watchdog - v4.3-rc3 Fixes

2015-09-30 Thread Wim Van Sebroeck
for TCO on Intel Sunrisepoint") Reviewed-by: Matt Fleming Cc: Lee Jones Signed-off-by: Guenter Roeck Signed-off-by: Wim Van Sebroeck commit 898e6861ff7cfc9f539b57859a27fbd1fe4298ae Author: Noralf Trønnes Date: Wed Jun 17 16:04:04 2015 +0200 watchdog: bcm2835: Fix po

[GIT PULL REQUEST] watchdog - v5.4 Merge window

2019-09-27 Thread Wim Van Sebroeck
4 drivers/watchdog/imx7ulp_wdt.c delete mode 100644 drivers/watchdog/ks8695_wdt.c delete mode 100644 drivers/watchdog/nuc900_wdt.c -------- Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v5.3 Merge window

2019-07-17 Thread Wim Van Sebroeck
ion/watchdog/watchdog-parameters.txt rename Documentation/watchdog/{watchdog-pm.txt => watchdog-pm.rst} (92%) rename Documentation/watchdog/{wdt.txt => wdt.rst} (68%) Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v5.0-rc Fixes

2019-01-19 Thread Wim Van Sebroeck
changed, 6 insertions(+), 4 deletions(-) Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v5.2 Merge window

2019-05-13 Thread Wim Van Sebroeck
chdog/xen_wdt.c | 18 +- drivers/watchdog/ziirave_wdt.c | 6 +- drivers/watchdog/zx2967_wdt.c | 37 +-- 99 files changed, 1490 insertions(+), 1537 deletions(-) create mode 100644 Documentation/devicetree/bindings/watchdog/fsl-imx-sc-wdt.txt create mode 100644 drivers/watchdog/bd70528_wdt.c create mode 100644 drivers/watchdog/imx_sc_wdt.c Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v5.1 Merge window

2019-03-10 Thread Wim Van Sebroeck
| 19 ++ 16 files changed, 437 insertions(+), 13 deletions(-) create mode 100644 Documentation/watchdog/mlx-wdt.txt create mode 100644 drivers/watchdog/mlx_wdt.c Kind regards, Wim.

Re: [PATCH] watchdog: w83627hf_wdt: Support NCT6796D, NCT6797D, NCT6798D

2018-10-02 Thread Wim Van Sebroeck
On Sun, Sep 23, 2018 at 06:54:11AM -0700, Guenter Roeck wrote: > The watchdog controller on NCT6796D, NCT6797D, and NCT6798D is compatible > with the wtachdog controller on other Nuvoton chips. > > Signed-off-by: Guenter Roeck Reviewed-by: Wim Van Sebroeck > --- >

[GIT PULL REQUEST] watchdog - v4.19-rc2

2018-09-01 Thread Wim Van Sebroeck
19-rc2 tag Fabrizio Castro (1): dt-bindings: watchdog: renesas-wdt: Document r8a774a1 support Documentation/devicetree/bindings/watchdog/renesas-wdt.txt | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) Kind regards, Wim.

[GIT PULL REQUEST] watchdog - v4.18 Merge window

2018-06-11 Thread Wim Van Sebroeck
Hi Linus, Please pull the watchdog changes for the v4.18 release cycle. This series contains: * renesas_wdt: Add support for the R8A77965 WDT and R-Car Gen2 * renesas-wdt: Remove R-Car M2-W ES2.x from blacklist * watchdog: Simplify getting .drvdata * sp805: Add restart handler * hpwdt: Claim NMIs

[GIT PULL REQUEST] watchdog - v4.17-rc2 patches

2018-04-20 Thread Wim Van Sebroeck
| 2 +- drivers/watchdog/w83977f_wdt.c | 2 +- drivers/watchdog/wafer5823wdt.c | 2 +- 6 files changed, 15 insertions(+), 6 deletions(-) Kind regards, Wim.

<    1   2   3   4   5   >