Linux and iptables

2008-01-06 Thread willem
Hello, I have a kubuntu system with a firestarter Firewall. I did purchase a Sweex router. This router has also a firewall. If I connect the router then i have two Firewalls. The result is that no visitor from outside can visit my wiki's, because they have to pass 2 Firewalls. How can I disable

Re: git guidance

2007-11-28 Thread willem
Dave Quigley wrote: On Wed, 2007-11-28 at 16:57 +0100, Tilman Schmidt wrote: Dave Quigley schrieb: There is a project listed on the kernel.org git page called guilt. I find it very useful. It is much more responsive than stgit and it actually has a git backend which quilt does not. On

can we discuss

2018-07-28 Thread willem

[PATCH] wrong stat of NTFS volume in linux-kernel 2.4.0

2001-01-07 Thread Willem Dekker
syslog. (printk) Willem Dekker Patch to adapt super.c of the ntfs filesystem. On a stock linux 2.4.0 kernel. >>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>>

Re: PATCH: ide-scsi.c to allow claiming of Onstream drives

2000-09-13 Thread Willem Riede
es not try to support these drives and fails due to the drive particulars. Since SCSI, USB and IDE versions of these drives exist, patching st is more appropriate than ide-scsi. Regards. Willem Riede. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] Please read the FAQ at http://www.tux.org/lkml/

Re: [CHECKER] null bugs in 2.4.4 and 2.4.4-ac8

2001-05-24 Thread Willem Riede
t; Error ---> > SRpnt->sr_sense_buffer[13] == 2) { > printk(KERN_ERR "osst%d: Volume overflow in write >error recovery\n", dev); > vfree((void *)buffer); >

Re: [CHECKER] null bugs in 2.4.4 and 2.4.4-ac8

2001-05-24 Thread Willem Riede
Junfeng Yang wrote: > > On Thu, 24 May 2001, Willem Riede wrote: > > > Dawson Engler wrote: > > > > > > Hi All, > > > > > > Enclosed are 103 potential errors where code gets a pointer from a > > > possibly-failing routine (kmalloc, etc

RE: NCQ support NVidia NForce4 (CK804) SATAII

2005-08-14 Thread Willem Riede
to (politely) to support the case? I don't understand your reluctance in this case (I do for your graphics processors) - it's not as if adding this function to sata_nv would expose your crown jewels - you write yourself that next time you'd use a different (better) interface... Re

Re: [2.6 patch] drivers/scsi/osst.c: make code static

2005-03-22 Thread Willem Riede
On 03/22/2005 09:28:07 AM, Adrian Bunk wrote: > This patch makes needlessly global code static. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> James, I agree with this, can you put it in BK, please? Signed-off-by: Willem Riede <[EMAIL PROTECTED]> > --- > >

Re: [2.6 patch] drivers/scsi/osst.c: remove unused code

2005-03-23 Thread Willem Riede
id use it moved to os_scsi_tape_flush() recently. James, could you make this change in BK too, please? Signed-off-by: Willem Riede <[EMAIL PROTECTED]> > --- linux-2.6.12-rc1-mm1-full/drivers/scsi/osst.c.old 2005-03-22 > 21:04:36.0 +0100 > +++ linux-2.6.12-rc1-mm1-full/d

Re: osst & ide-2.2.19 conflict?

2001-06-23 Thread Willem Riede
* CONFIG_BLK_DEV_IDETAPE */ > > Any reason for this to stay in the ide patch, or is it now obsolete? > It is obsolete, and can safely be removed. Success. Willem Riede. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: LANANA: To Pending Device Number Registrants

2001-05-16 Thread Willem Konynenberg
in /proc/sys/dev or thereabout. The big advantage of this approach is basically that we can continue to use the good old device nodes in the filesystem as we have done for the last 30 years, with all the advantages, but without the major/minor number allocation troubles. Hmm, this all sound

Re: [PATCH v9 net-next 2/7] net: add low latency socket poll

2013-06-05 Thread Willem de Bruijn
from the socket code. >> sysctl_net_ll_poll controls how many microseconds to poll. >> Default is zero (disabled). >> Individual protocol support will be added by subsequent patches. >> >> Signed-off-by: Alexander Duyck >> Signed-off-by: Jesse Brandeburg >&g

Re: [PATCH v10 net-next 2/6] net: add low latency socket poll

2013-06-10 Thread Willem de Bruijn
net/ipv4/proc.c |1 >> net/socket.c |6 ++ >> 12 files changed, 208 insertions(+), 2 deletions(-) >> create mode 100644 include/net/ll_poll.h > > Acked-by: Eric Dumazet > Tested-by: Willem de Bruijn Per Eliezer's request, I

Re: [PATCH v10 net-next 1/6] net: add napi_id and hash

2013-06-10 Thread Willem de Bruijn
s changed, 88 insertions(+), 0 deletions(-) > > Signed-off-by: Eric Dumazet > Tested-by: Willem de Bruijn (per Eliezer's request) -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH v10 net-next 3/6] udp: add low latency socket poll support

2013-06-10 Thread Willem de Bruijn
;> Signed-off-by: Eliezer Tamir >> --- >> >> net/core/datagram.c |4 >> net/ipv4/udp.c |6 +- >> net/ipv6/udp.c |6 +- >> 3 files changed, 14 insertions(+), 2 deletions(-) > > Acked-by: Eric Dumazet > Tested

Re: [PATCH v10 net-next 4/6] tcp: add low latency socket poll support.

2013-06-10 Thread Willem de Bruijn
recvmsg(), when there is no data in the socket we busy-poll. >> This is a good example of how to add busy-poll support to more protocols. >> >> Signed-off-by: Alexander Duyck >> Signed-off-by: Jesse Brandeburg >> Signed-off-by: Eliezer Tamir >> --- > > Ac

Re: [PATCH v3 net-next 3/4] ixgbe: Add support for ndo_ll_poll

2013-05-21 Thread Willem de Bruijn
her drivers to do something similar >>> in order to enable support for CONFIG_INET_LL_RX_POLL >> >> >> I am not sure, > > > Willem ported this to , his > feedback was that it was not a major effort. The core ndo_ll_poll implementation is generally a

Re: [PATCH v3 net-next 0/4] net: low latency Ethernet device polling

2013-05-21 Thread Willem de Bruijn
>> 2. How is the logic aware of RSS and RFS? >> >> With TCP sockets, the driver knows the specific ring it need to poll so >> this should be mapped and provide the best latency. > > > This code is blissfully oblivious of RFS and RSS, it only assumes that the > packets for a socket are likely to con

Re: status of kernel memory debugging?

2005-07-30 Thread Willem de Bruijn
be interesting to see what valgrind reports once (if?) the kernel gets a good grinding. Willem - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > tun now use flow caches based automatic queue steering method. This > may not suffice all user cases. To extend it to be able to use more > flow steering policy, this patch abstracts flow steering logic into > tun_steering_ops, then we can decla

Re: [PATCH net-next V2 2/3] tun: introduce ioctls to set and get steering policies

2017-11-01 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > This patch introduces new ioctl for change packet steering policy for > tun. Only automatic flow steering is supported, more policies will > come. > > Signed-off-by: Jason Wang > --- > drivers/net/tun.c | 35 +

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

2017-10-25 Thread Willem de Bruijn
On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote: > I have uploaded the VM core dump [1]. And I don’t know if these logs are > helpful in the case of > failing to get the C reproducer currently. > > [1] https://github.com/dotweiba/skb_clone_atomic_inc_bug/blob/master/vmcore.gz Thanks. So this woul

Re: v4.14-rc3/arm64 DABT exception in atomic_inc() / __skb_clone()

2017-10-25 Thread Willem de Bruijn
On Wed, Oct 25, 2017 at 2:24 PM, Willem de Bruijn wrote: > On Sat, Oct 21, 2017 at 9:56 PM, Wei Wei wrote: >> I have uploaded the VM core dump [1]. And I don’t know if these logs are >> helpful in the case of >> failing to get the C reproducer currently. >> &g

Re: [PATCH net-next V2 1/3] tun: abstract flow steering logic

2017-11-03 Thread Willem de Bruijn
On Thu, Nov 2, 2017 at 12:51 PM, Jason Wang wrote: > > > On 2017年11月02日 11:45, Michael S. Tsirkin wrote: >> >> On Thu, Nov 02, 2017 at 11:43:48AM +0800, Jason Wang wrote: >>> >>> >>> On 2017年11月02日 09:11, Willem de Bruijn wrote: >>>

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

2017-11-03 Thread Willem de Bruijn
On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: > This patch introduces an eBPF based queue selection method based on > the flow steering policy ops. Userspace could load an eBPF program > through TUNSETSTEERINGEBPF. This gives much more flexibility compare > to simple but hard coded policy in

Re: [PATCH net-next V2 3/3] tun: add eBPF based queue selection method

2017-11-03 Thread Willem de Bruijn
On Fri, Nov 3, 2017 at 5:56 PM, Willem de Bruijn wrote: > On Tue, Oct 31, 2017 at 7:32 PM, Jason Wang wrote: >> This patch introduces an eBPF based queue selection method based on >> the flow steering policy ops. Userspace could load an eBPF program >> through TUNSETSTEERING

Re: [PATCH net-next V2 2/2] tun: allow to attach ebpf socket filter

2018-01-05 Thread Willem de Bruijn
On Fri, Jan 5, 2018 at 4:54 AM, Jason Wang wrote: > This patch allows userspace to attach eBPF filter to tun. This will > allow to implement VM dataplane filtering in a more efficient way > compared to cBPF filter by allowing either qemu or libvirt to > attach eBPF filter to tun. > > Signed-off-by

Re: general protection fault in skb_segment

2018-01-16 Thread Willem de Bruijn
On Tue, Jan 2, 2018 at 12:23 PM, Willem de Bruijn wrote: >> Actually, changes just to inet_gso_segment and ipv6_gso_segment >> will suffice: >> >>bool udpfrag = false, fixedid = false, gso_partial, encap; >> struct sk_buff *segs = ERR_PTR(-EINVAL);

Re: [RFC] net;sched: Try to find idle cpu for RPS to handle packets

2018-09-27 Thread Willem de Bruijn
On Wed, Sep 19, 2018 at 12:02 PM Kirill Tkhai wrote: > > On 19.09.2018 18:49, Eric Dumazet wrote: > > On Wed, Sep 19, 2018 at 8:41 AM Kirill Tkhai wrote: > >> > >> On 19.09.2018 17:55, Eric Dumazet wrote: > >>> On Wed, Sep 19, 2018 at 5:29 AM Kirill Tkhai wrote: > > Many workloads have

Re: [PATCH] move smp_rmb() after load of status

2018-07-08 Thread Willem de Bruijn
> @@ -394,25 +394,30 @@ static void __packet_set_status(struct packet_sock *po, > void *frame, int status) > static int __packet_get_status(struct packet_sock *po, void *frame) > { > union tpacket_uhdr h; > - > - smp_rmb(); > + int status; > > h.raw = frame; >

Re: KASAN: use-after-free Read in ipv6_gso_pull_exthdrs

2018-07-08 Thread Willem de Bruijn
On Fri, Jul 6, 2018 at 6:16 PM Willem de Bruijn wrote: > > On Fri, Jul 6, 2018 at 1:55 PM syzbot > wrote: > > > > syzbot has found a reproducer for the following crash on: > > > > HEAD commit:70ba5b6db96f ipv4: Return EINVAL when ping_group_range sys.. &g

Re: KASAN: use-after-free Read in ipv6_gso_pull_exthdrs

2018-07-08 Thread Willem de Bruijn
On Sun, Jul 8, 2018 at 6:58 PM Willem de Bruijn wrote: > > On Fri, Jul 6, 2018 at 6:16 PM Willem de Bruijn > wrote: > > > > On Fri, Jul 6, 2018 at 1:55 PM syzbot > > wrote: > > > > > > syzbot has found a reproducer for the following crash on:

[PATCH] checkpatch: validate Fixes tags

2018-05-30 Thread Willem de Bruijn
From: Willem de Bruijn Apply commit syntax validation to Fixes tags: Remove the existing exclusion match on " !~ /\bfixes ..." and generalize keyword match to "[Cc]ommit|Fixes:". Unlike commit tags, fixes tags must take up an entire line and may not have line breaks. When

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: > From: Eric Dumazet > Date: Fri, 18 May 2018 08:30:43 -0700 > >> We probably need to revert Willem patch >> (7ce875e5ecb8562fd44040f69bda96c999e38bbc) > > Is it really valid to reach ip_recv_err with an ipv6 so

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: >> From: Eric Dumazet >> Date: Fri, 18 May 2018 08:30:43 -0700 >> >>> We probably need to revert Willem patch >>> (7ce875e5ecb8562fd44040f69bd

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: >>> From: Eric Dumazet >>> Date: Fri, 18 May 2018 08:30:43 -0700 >>> >&

Re: WARNING in ip_recv_error

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 1:09 PM, Willem de Bruijn >> wrote: >>> On Fri, May 18, 2018 at 11:44 AM, David Miller wrote: >>>> From: Eric

Re: WARNING in __static_key_slow_dec

2018-05-18 Thread Willem de Bruijn
On Fri, May 18, 2018 at 4:03 AM, DaeRyong Jeong wrote: > We report the crash: WARNING in __static_key_slow_dec > > This crash has been found in v4.8 using RaceFuzzer (a modified > version of Syzkaller), which we describe more at the end of this > report. > Even though v4.8 is the relatively old ve

Re: [PATCH v2 8/8] socket: Update timestamping Documentation

2018-12-12 Thread Willem de Bruijn
On Tue, Dec 11, 2018 at 3:31 PM Deepa Dinamani wrote: > > With the new y2038 safe timestamping options added, update the > documentation to reflect the changes. > > Signed-off-by: Deepa Dinamani Thanks for adding documentation. Acked-by: Willem de Bruijn One suggestion below i

Re: [PATCH v2 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-12-12 Thread Willem de Bruijn
On Tue, Dec 11, 2018 at 3:30 PM Deepa Dinamani wrote: > > Add SO_TIMESTAMP_NEW and SO_TIMESTAMPNS_NEW variants of > socket timestamp options. > These are the y2038 safe versions of the SO_TIMESTAMP_OLD > and SO_TIMESTAMPNS_OLD for all architectures. > > Note that the format of scm_timestamping.ts[

Re: [PATCH v2 7/8] socket: Add SO_TIMESTAMPING_NEW

2018-12-12 Thread Willem de Bruijn
On Tue, Dec 11, 2018 at 3:30 PM Deepa Dinamani wrote: > > Add SO_TIMESTAMPING_NEW variant of socket timestamp options. > This is the y2038 safe versions of the SO_TIMESTAMPING_OLD > for all architectures. > > Signed-off-by: Deepa Dinamani > Cc: ch...@zankel.net > Cc: fenghua...@intel.com > Cc: r.

Re: [PATCH v2 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-12-12 Thread Willem de Bruijn
> This did not address yet the previous comments on consistency and > unnecessary code churn. > > The existing logic to differentiate SO_TIMESTAMP from SO_TIMESTAMPNS > in both tcp_recv_timestamp and __sock_recv_timestamp is > > if (sock_flag(sk, SOCK_RCVTSTAMP)) { > if (sock_flag(sk, SOCK_

Re: [PATCH v2 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-12-15 Thread Willem de Bruijn
On Fri, Dec 14, 2018 at 8:07 PM Deepa Dinamani wrote: > > > > diff --git a/arch/alpha/include/uapi/asm/socket.h > > > b/arch/alpha/include/uapi/asm/socket.h > > > index 00e45c80e574..352e3dc0b3d9 100644 > > > --- a/arch/alpha/include/uapi/asm/socket.h > > > +++ b/arch/alpha/include/uapi/asm/socke

Re: [PATCH v2 6/8] socket: Add SO_TIMESTAMP[NS]_NEW

2018-12-15 Thread Willem de Bruijn
> 3 reasons for not doing this: > > 1. We do not want to break userspace. If we move this to > linux/socket.h all the userspace programs now have to include > linux/socket.h or get this definition through a new libc. > 2. All the socket options are together in the file asm/socket.h. It > doesn't se

Re: [PATCH net-next v3 0/4] net: mitigate retpoline overhead

2018-12-16 Thread Willem de Bruijn
On Sun, Dec 16, 2018 at 2:19 PM David Miller wrote: > > From: Paolo Abeni > Date: Sun, 16 Dec 2018 19:55:40 +0100 > > > Again, I messed it! I'm really sorry to waste everybody's time. > > I was unable to give proper coverage with different configs. I tested > > vs.: > > > > CONFIG_IPV6=ymn > > CO

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Willem de Bruijn
On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote: > > +Willem > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Christian Borntraeger wrote: > > Folks, > > > > I got this warning today. I cant tell when and why this happened, so I do > > not know yet how to repr

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Willem de Bruijn
On Thu, Dec 20, 2018 at 9:16 AM Ido Schimmel wrote: > > On Thu, Dec 20, 2018 at 09:04:25AM -0500, Willem de Bruijn wrote: > > On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote: > > > > > > +Willem > > > > > > On Thu, Dec 20, 2018 at 08:45:40AM +

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Willem de Bruijn
On Thu, Dec 20, 2018 at 9:34 AM Willem de Bruijn wrote: > > On Thu, Dec 20, 2018 at 9:16 AM Ido Schimmel wrote: > > > > On Thu, Dec 20, 2018 at 09:04:25AM -0500, Willem de Bruijn wrote: > > > On Thu, Dec 20, 2018 at 6:15 AM Ido Schimmel wrote: > > > > >

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-20 Thread Willem de Bruijn
On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote: > > On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: > > On 20.12.2018 10:12, Ido Schimmel wrote: > > > +Willem > > > > > > On Thu, Dec 20, 2018 at 08:45:40AM +0100, Ch

Re: 4.20-rc6: WARNING: CPU: 30 PID: 197360 at net/core/flow_dissector.c:764 __skb_flow_dissect

2018-12-21 Thread Willem de Bruijn
On Fri, Dec 21, 2018 at 1:45 AM Christian Borntraeger wrote: > > > > On 20.12.2018 18:23, Willem de Bruijn wrote: > > On Thu, Dec 20, 2018 at 11:17 AM Ido Schimmel wrote: > >> > >> On Thu, Dec 20, 2018 at 03:09:22PM +0100, Christian Borntraeger wrote: >

Re: [PATCH v3 0/8] net: y2038-safe socket timestamps

2019-01-08 Thread Willem de Bruijn
On Mon, Jan 7, 2019 at 10:29 PM Deepa Dinamani wrote: > > The series introduces new socket timestamps that are > y2038 safe. > > The time data types used for the existing socket timestamp > options: SO_TIMESTAMP, SO_TIMESTAMPNS and SO_TIMESTAMPING > are not y2038 safe. The series introduces SO_TIM

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 7:07 AM syzbot wrote: > > Hello, > > syzbot found the following crash on: > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of git://git.kern.. > git tree: upstream > console output: https://syzkaller.appspot.com/x/log.txt?x=12245d8f40 > kernel config:

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 1:39 PM Willem de Bruijn wrote: > > On Thu, Jan 3, 2019 at 7:07 AM syzbot > wrote: > > > > Hello, > > > > syzbot found the following crash on: > > > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of gi

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-03 Thread Willem de Bruijn
On Thu, Jan 3, 2019 at 2:07 PM Stefano Brivio wrote: > > On Thu, 3 Jan 2019 12:01:29 -0800 > Eric Dumazet wrote: > > > On 01/03/2019 05:07 AM, syzbot wrote: > > > Hello, > > > > > > syzbot found the following crash on: > > > > > > HEAD commit:195303136f19 Merge tag 'kconfig-v4.21-2' of > > >

Re: kernel panic: stack is corrupted in udp4_lib_lookup2

2019-01-04 Thread Willem de Bruijn
> > > > > > > On Thu, Jan 3, 2019 at 10:54 PM Stefano Brivio > > > > wrote: > > > > > > > > > > On Thu, 3 Jan 2019 15:15:06 -0600 > > > > > Willem de Bruijn wrote: > > > > > > > > > > &g

Re: [PATCH net-next v3 1/3] vsock/virtio: use skb_frag_*() helpers

2023-12-21 Thread Willem de Bruijn
Mina Almasry wrote: > Minor fix for virtio: code wanting to access the fields inside an skb > frag should use the skb_frag_*() helpers, instead of accessing the > fields directly. This allows for extensions where the underlying > memory is not a page. > > Signed-off-by: Mina Almasry > > --- > >

Re: [PATCH net-next v3 3/3] net: add netmem_ref to skb_frag_t

2023-12-21 Thread Willem de Bruijn
Mina Almasry wrote: > Use netmem_ref instead of page in skb_frag_t. Currently netmem_ref > is always a struct page underneath, but the abstraction allows efforts > to add support for skb frags not backed by pages. > > There is unfortunately 1 instance where the skb_frag_t is assumed to be > a bio_

Re: [PATCH net-next 2/2] tun: AF_XDP Rx zero-copy support

2024-01-24 Thread Willem de Bruijn
Yunjian Wang wrote: > Now the zero-copy feature of AF_XDP socket is supported by some > drivers, which can reduce CPU utilization on the xdp program. > This patch set allows tun to support AF_XDP Rx zero-copy feature. > > This patch tries to address this by: > - Use peek_len to consume a xsk->desc

Re: [PATCH net-next v2 3/3] tun: AF_XDP Tx zero-copy support

2024-03-01 Thread Willem de Bruijn
Maciej Fijalkowski wrote: > On Wed, Feb 28, 2024 at 07:05:56PM +0800, Yunjian Wang wrote: > > This patch set allows TUN to support the AF_XDP Tx zero-copy feature, > > which can significantly reduce CPU utilization for XDP programs. > > Why no Rx ZC support though? What will happen if I try rxdrop

Re: [PATCH RFC 0/4] virtio-net: add tx-hash, rx-tstamp, tx-tstamp and tx-time

2023-12-18 Thread Willem de Bruijn
Steffen Trumtrar wrote: > This series tries to pick up the work on the virtio-net timestamping > feature from Willem de Bruijn. > > Original series > Message-Id: 20210208185558.995292-1-willemdebruijn.ker...@gmail.com > Subject: [PATCH RFC v2 0/4] virtio-net: add

Re: [PATCH RFC 0/4] virtio-net: add tx-hash, rx-tstamp, tx-tstamp and tx-time

2023-12-19 Thread Willem de Bruijn
Jason Wang wrote: > On Tue, Dec 19, 2023 at 12:36 AM Willem de Bruijn > wrote: > > > > Steffen Trumtrar wrote: > > > This series tries to pick up the work on the virtio-net timestamping > > > feature from Willem de Bruijn. > > > > > > Origina

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-06 Thread Willem de Bruijn
Sean Anderson wrote: > Padding is not included in UDP and TCP checksums. Therefore, reduce the > length of the checksummed data to include only the data in the IP > payload. This fixes spurious reported checksum failures like > > rx: pkt: sport=33000 len=26 csum=0xc850 verify=0xf9fe > pkt: bad csu

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/6/24 22:05, Willem de Bruijn wrote: > > Sean Anderson wrote: > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the > >> length of the checksummed data to include only the data in the IP > >> payload. This fixes

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Eric Dumazet wrote: > On Mon, Sep 9, 2024 at 5:02 PM Sean Anderson wrote: > > > > On 9/6/24 22:05, Willem de Bruijn wrote: > > > Sean Anderson wrote: > > >> Padding is not included in UDP and TCP checksums. Therefore, reduce the > > >> length of

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-09 Thread Willem de Bruijn
Jakub Kicinski wrote: > On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > > > This seems to be a bug in the driver. > > > > > > A call to skb_put_padto(skb, ETH_ZLEN) should be added. > > > > In which case this test detecting it may be nic

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/9/24 21:01, Willem de Bruijn wrote: > > Jakub Kicinski wrote: > >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: > >> > > This seems to be a bug in the driver. > >> > > > >> > > A call to sk

Re: [PATCH net] selftests: net: csum: Fix checksums for packets with non-zero padding

2024-09-10 Thread Willem de Bruijn
Sean Anderson wrote: > On 9/10/24 13:42, Willem de Bruijn wrote: > > Sean Anderson wrote: > >> On 9/9/24 21:01, Willem de Bruijn wrote: > >> > Jakub Kicinski wrote: > >> >> On Mon, 09 Sep 2024 13:26:42 -0400 Willem de Bruijn wrote: >

Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

2024-09-12 Thread Willem de Bruijn
On Thu, Sep 12, 2024 at 2:31 AM Anders Roxell wrote: > > Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") > Signed-off-by: Anders Roxell This target is automatically built for targets that depend on it. See the commit that introduced it, b86761ff6374. +++ b/tools/testing/selftest

Re: [PATCH] selftests: Makefile: add missing 'net/lib' to targets

2024-09-15 Thread Willem de Bruijn
On Sun, Sep 15, 2024 at 8:45 AM Anders Roxell wrote: > > On Thu, 12 Sept 2024 at 17:23, Jakub Kicinski wrote: > > > > On Thu, 12 Sep 2024 08:31:18 +0200 Anders Roxell wrote: > > > Fixes: 1d0dc857b5d8 ("selftests: drv-net: add checksum tests") > > > Signed-off-by: Anders Roxell > > > --- > > > t

Re: [PATCH net] packet: bail out of packet_snd() if L2 header creation fails

2015-01-11 Thread Willem de Bruijn
7;t affect result"). >> >> Fixes: 9c7077622dd9 ("packet: make packet_snd fail on len smaller than l2 >> header") >> Signed-off-by: Christoph Jaeger >> --- > > Nice catch ! > > Acked-by: Eric Dumazet > Indeed. I'm responsible for

Re: [PATCH 2/2] af_packet: pass checksum validation status to the user

2015-03-19 Thread Willem de Bruijn
On Thu, Mar 19, 2015 at 4:01 AM, Alexander Drozdov wrote: > Introduce TP_STATUS_CSUM_VALID tp_status flag to tell the > af_packet user that at least the transport header checksum > has been already validated. This changes the interface slightly. Processes should be treating this previously unused

Re: [PATCH 2/2] af_packet: pass checksum validation status to the user

2015-03-19 Thread Willem de Bruijn
On Thu, Mar 19, 2015 at 2:08 PM, Alexander Drozdov wrote: > On Thu, 19 Mar 2015 11:29:32 -0400, Willem de Bruijn > wrote: >> >> On Thu, Mar 19, 2015 at 4:01 AM, Alexander Drozdov >> wrote: >>> >>> Introduce TP_STATUS_CSUM_VALID tp_status flag to tel

Re: [PATCH 2/2] af_packet: pass checksum validation status to the user

2015-03-20 Thread Willem de Bruijn
On Fri, Mar 20, 2015 at 2:46 AM, Alexander Drozdov wrote: > > On 19.03.2015 21:50:03 +0300 Willem de Bruijn wrote: >> >> On Thu, Mar 19, 2015 at 2:08 PM, Alexander Drozdov >> wrote: >>> >>> On Thu, 19 Mar 2015 11:29:32 -0400, Willem de Bruijn >>&

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-22 Thread Willem de Bruijn
>>> I think the bigger issues as you've pointed out are the cost of >>> the additional spin lock and should the additional state be >>> stored in-band (fewer cache lines) or out-of band (less risk of >>> breaking due to unpredictable application behavior). >> >> We don't need the spinlock if cleari

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-22 Thread Willem de Bruijn
On Tue, May 22, 2018 at 10:12 AM, Jon Rosen (jrosen) wrote: > On Monday, May 21, 2018 2:17 PM, Jon Rosen (jrosen) wrote: >> On Monday, May 21, 2018 1:07 PM, Willem de Bruijn >> wrote: >>> On Mon, May 21, 2018 at 8:57 AM, Jon Rosen (jrosen) >>> wrote: > >

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-23 Thread Willem de Bruijn
On Wed, May 23, 2018 at 7:54 AM, Jon Rosen (jrosen) wrote: >> > For the ring, there is no requirement to allocate exactly the amount >> > specified by the user request. Safer than relying on shared memory >> > and simpler than the extra allocation in this patch would be to allocate >> > extra shad

Re: WARNING in ip_recv_error

2018-05-23 Thread Willem de Bruijn
On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn wrote: > On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn >> wrote: >>> On Fri, May 18, 2018 at 2:44 PM, Willem de Bruijn >>> wrote: >>>

Re: [PATCH v2] packet: track ring entry use using a shadow ring to prevent RX ring overrun

2018-05-23 Thread Willem de Bruijn
On Wed, May 23, 2018 at 11:29 AM, Jon Rosen (jrosen) wrote: > > >> -Original Message----- >> From: Willem de Bruijn [mailto:willemdebruijn.ker...@gmail.com] >> Sent: Wednesday, May 23, 2018 9:37 AM >> To: Jon Rosen (jrosen) >> Cc: David S. Miller ;

Re: WARNING in ip_recv_error

2018-05-23 Thread Willem de Bruijn
On Wed, May 23, 2018 at 11:40 AM, Willem de Bruijn wrote: > On Sun, May 20, 2018 at 7:13 PM, Willem de Bruijn > wrote: >> On Fri, May 18, 2018 at 2:59 PM, Willem de Bruijn >> wrote: >>> On Fri, May 18, 2018 at 2:46 PM, Willem de Bruijn >>> wrote: >>>

Re: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

2018-04-04 Thread Willem de Bruijn
On Tue, Apr 3, 2018 at 11:55 PM, Jon Rosen wrote: > Fix PACKET_RX_RING bug for versions TPACKET_V1 and TPACKET_V2 which > casues the ring to get corrupted by allowing multiple kernel threads > to claim ownership of the same ring entry, Mark the ring entry as > already being used within the spin_lo

Re: [RFC PATCH] packet: mark ring entry as in-use inside spin_lock to prevent RX ring overrun

2018-04-04 Thread Willem de Bruijn
>> >One issue with the above proposed change to use TP_STATUS_IN_PROGRESS >> >is that the documentation of the tp_status field is somewhat >> >inconsistent. In some places it's described as TP_STATUS_KERNEL(0) >> >meaning the entry is owned by the kernel and !TP_STATUS_KERNEL(0) >>

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-23 Thread Willem de Bruijn
On Tue, Feb 23, 2021 at 8:48 AM Balazs Nemeth wrote: > > On Mon, 2021-02-22 at 11:39 +0800, Jason Wang wrote: > > > > On 2021/2/19 10:55 下午, Willem de Bruijn wrote: > > > On Fri, Feb 19, 2021 at 3:53 AM Jason Wang > > > wrote: > > > > >

Re: [PATCH/v2] bpf: add bpf_skb_adjust_room flag BPF_F_ADJ_ROOM_ENCAP_L2_ETH

2021-02-10 Thread Willem de Bruijn
ncap L2 type and set the inner_protocol > as ETH_P_TEB. > > Suggested-by: Willem de Bruijn > Signed-off-by: huangxuesen > Signed-off-by: chengzhiyong > Signed-off-by: wangli Thanks, this is exactly what I meant. Acked-by: Willem de Bruijn One small point regarding Signed-off-by

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 1:12 PM Jason A. Donenfeld wrote: > > Hi Netdev & Willem, > > I've received a report of stack corruption -- via the stack protector > check -- in icmp_send. I was sent a vmcore, and was able to extract > the OOPS from there. However, I've be

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote: > > Hi Willem, > > On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn > wrote: > > A vmlinux image might help. I couldn't find one for this kernel. > > https://data.zx2c4.com/icmp_send-crash-e03b4a42-70

Re: possible stack corruption in icmp_send (__stack_chk_fail)

2021-02-17 Thread Willem de Bruijn
On Wed, Feb 17, 2021 at 6:18 PM Jason A. Donenfeld wrote: > > On 2/18/21, Willem de Bruijn wrote: > > On Wed, Feb 17, 2021 at 5:56 PM Jason A. Donenfeld wrote: > >> > >> Hi Willem, > >> > >> On Wed, Feb 17, 2021 at 11:27 PM Willem de Bruijn &

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-18 Thread Willem de Bruijn
On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote: > > For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't > set) based on the type in the virtio net hdr, but the skb could contain > anything since it could come from packet_snd through a raw socket. If > there is a mismatch

Re: [PATCH] net: check if protocol extracted by virtio_net_hdr_set_proto is correct

2021-02-19 Thread Willem de Bruijn
On Fri, Feb 19, 2021 at 3:53 AM Jason Wang wrote: > > > On 2021/2/18 11:50 下午, Willem de Bruijn wrote: > > On Thu, Feb 18, 2021 at 10:01 AM Balazs Nemeth wrote: > >> For gso packets, virtio_net_hdr_set_proto sets the protocol (if it isn't > >> set) based

Re: [PATCH] rtlwifi: rtl8192se: remove redundant initialization of variable rtstatus

2021-01-28 Thread Willem de Bruijn
esses-Coverity: ("Unused value") > Signed-off-by: Colin Ian King (for netdrv) Acked-by: Willem de Bruijn

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 2:56 PM Sven Van Asbroeck wrote: > > From: Sven Van Asbroeck > > Multi-buffer packets enable us to use rx ring buffers smaller than > the mtu. This will allow us to change the mtu on-the-fly, without > having to stop the network interface in order to re-size the rx > ring

Re: [PATCH net-next v1 2/6] lan743x: support rx multi-buffer packets

2021-01-29 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 6:03 PM Sven Van Asbroeck wrote: > > Hoi Willem, thanks a lot for reviewing this patch, much appreciated !! > > On Fri, Jan 29, 2021 at 5:11 PM Willem de Bruijn > wrote: > > > > > +static struct sk_buff * > > > +lan743x_rx_trim_sk

Re: [Patch v2 net-next 2/7] octeontx2-af: Add new CGX_CMD to get PHY FEC statistics

2021-01-30 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 4:53 AM Hariprasad Kelam wrote: > > Hi Willem, > > > -Original Message- > > From: Willem de Bruijn > > Sent: Thursday, January 28, 2021 1:50 AM > > To: Hariprasad Kelam > > Cc: Network Development ; LKML > ker

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-30 Thread Willem de Bruijn
On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > > The channel stop and suspend paths both call __gsi_channel_stop(), > which quiesces channel activity, disables NAPI, and (on other than > SDM845) stops the channel. Similarly, the start and resume paths > share __gsi_channel_start(), which sta

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > > On 1/30/21 9:25 AM, Willem de Bruijn wrote: > > On Fri, Jan 29, 2021 at 3:29 PM Alex Elder wrote: > >> > >> The channel stop and suspend paths both call __gsi_channel_stop(), > >> which quiesces channel

Re: [net-next 00/14] Add Marvell CN10K support

2021-01-31 Thread Willem de Bruijn
On Sat, Jan 30, 2021 at 12:04 PM Geetha sowjanya wrote: > > The current admin function (AF) driver and the netdev driver supports > OcteonTx2 silicon variants. The same OcteonTx2's Resource Virtualization Unit > (RVU) > is carried forward to the next-gen silicon ie OcteonTx3, with some changes >

Re: [Patch v3 net-next 0/7] ethtool support for fec and link configuration

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 8:11 AM Hariprasad Kelam wrote: > > This series of patches add support for forward error correction(fec) and > physical link configuration. Patches 1&2 adds necessary mbox handlers for fec > mode configuration request and to fetch stats. Patch 3 registers driver > callbacks

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-01-31 Thread Willem de Bruijn
On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > > On 1/31/21 8:52 AM, Willem de Bruijn wrote: > > On Sat, Jan 30, 2021 at 11:29 PM Alex Elder wrote: > >> > >> On 1/30/21 9:25 AM, Willem de Bruijn wrote: > >>> On Fri, Jan 29, 2021 at 3:29 PM Alex El

Re: [PATCH net-next 9/9] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Willem de Bruijn
On Mon, Feb 1, 2021 at 9:35 AM Alex Elder wrote: > > On 1/31/21 7:36 PM, Willem de Bruijn wrote: > > On Sun, Jan 31, 2021 at 10:32 AM Alex Elder wrote: > >> > >> On 1/31/21 8:52 AM, Willem de Bruijn wrote: > >>> On Sat, Jan 30, 2021 at 11:29 PM Alex Elde

Re: [PATCH net-next v2 0/7] net: ipa: don't disable NAPI in suspend

2021-02-01 Thread Willem de Bruijn
n separate > steps (patches). Now both are moved around together in patch 5 and > 6, which eliminates the need for the final (NAPI-only) patch. > > I won't repeat the patch summaries provided in v1: > https://lore.kernel.org/netdev/20210129202019.2099259-1-el...@linaro.org/ > >

  1   2   3   4   5   6   >