Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-11-30 Thread wangrongwei
Hi, Will Thanks for your reply! There are absolutely privileged registers, and seriously expose the interface directly! However, these interfaces (/dev/cpu//msr) need permissions to access, so there should be few security issues. In addition, it may be due to my unclear description above. This

Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-11-30 Thread wangrongwei
Hi We have validate this driver in vm and physical machine, and works fine. Actually, we used existing interfaces to realize this driver, likes aarch64_insn_read and aarch64_insn_patch_text. These existing intefaces had validated a CPU. > 2020年12月1日 上午2:05,Marc Zyngier 写道: > > On 2020-11-30 1

Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-11-30 Thread wangrongwei
Hi, Boris, Thank your advice very much! Indeed, I have read the commit message, and it seems that writes data to a system register may cause many problems. Actually, we have taken this into account. In the current version, we have separated the read and write functions to the system registers in

Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-11-30 Thread wangrongwei
Hi, Will Thanks for your reply! There are absolutely privileged registers, and seriously expose the interface directly! However, these interfaces (/dev/cpu//msr) need permissions to access, so there should be few security issues. In addition, it may be due to my unclear description above. This

Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-12-01 Thread wangrongwei
> 2020年12月1日 下午4:12,Marc Zyngier 写道: > > On 2020-12-01 03:09, wangrongwei wrote: >> Hi >> We have validate this driver in vm and physical machine, and works fine. > > But what does "work fine" mean? None of these system registers are supposed > to

Re: [PATCH 0/3] arm64:msr: Add MSR driver

2020-12-01 Thread wangrongwei
> 2020年12月1日 下午7:26,Borislav Petkov 写道: > > On Tue, Dec 01, 2020 at 11:44:52AM +0800, wangrongwei wrote: >> Indeed, I have read the commit message, and it seems that writes data >> to a system register may cause many problems. Actually, we have taken >> this i