On Tue, Aug 30, 2005 at 04:28:46PM -0700, Andrew Morton wrote:
> Sure, but all that copying-and-pasting really sucks. I'm sure there's some
> way of providing the slightly different semantics from the same codebase?
Careful - you've almost reinvented the concept of library, which would
violate an
drivers/char/ipmi/ipmi_poweroff.c::proc_write_chassctrl()
a) does sscanf on userland pointer
b) does sscanf on array that is not guaranteed to have NUL in it
c) interprets input in incredibly cretinous way:
if strings doesn't start with a decimal number => as if it was "0".
On Thu, Sep 01, 2005 at 04:19:34PM +0200, Arjan van de Ven wrote:
> > +/* Endian functions */
>
> e again why??
> Why is this a compiletime hack?
> Either you care about either-endian on disk, at which point it has to be
> a runtime thing, or you make the on disk layout fixed endian, at which
On Thu, Sep 01, 2005 at 11:41:42AM -0500, Corey Minyard wrote:
> Indeed, this function is badly written. In rewriting, I couldn't find a
> nice function for reading integers from userspace, and the proc_dointvec
> stuff didn't seem terribly suitable. So I wrote my own general
> function, which I
On Thu, Sep 01, 2005 at 05:17:38PM -0700, Andrew Morton wrote:
> Andrew Morton <[EMAIL PROTECTED]> wrote:
> >
> > Can I assume that the five m68k patches can be split apart from the five
> > patches which dink with task_struct? ie: if the task_struct patches go in
> > later, does anything bad happ
d when we enter that block...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-uml-checker/drivers/atm/zatm.c RC13-zatm/drivers/atm/zatm.c
--- RC13-uml-checker/drivers/atm/zatm.c 2005-09-02 03:33:39.0 -0400
+++ RC13-zatm/drivers/atm/zatm.c2005-09-02 03:34:19.
More stuff that got exposed to sparc32 build due to inclusion of
drivers/char/Kconfig in arch/sparc/Kconfig needs to be excluded.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-zatm/drivers/char/Kconfig RC13-mxser-sparc32/drivers/char/Kconfig
--- RC13-zatm/drivers/char/K
A bunch of gratitious includes of asm/segment.h (outside of arch/*, at that)
had been missed by removals.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-s390-phy/drivers/isdn/hisax/hisax.h
RC13-segment/drivers/isdn/hisax/hisax.h
--- RC13-s390-phy/drivers/isdn/hisax/h
drivers/net/phy/phy.c is broken on s390; it uses enable_irq() and friends
and these do not exist on s390. Marked as broken for now.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-mxser-sparc32/drivers/net/phy/Kconfig
RC13-s390-phy/drivers/net/phy/Kconfig
--- RC13-mxser-s
u64 is not uintptr_t; unsigned long is...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-segment/drivers/net/s2io.c RC13-s2io-u64/drivers/net/s2io.c
--- RC13-segment/drivers/net/s2io.c 2005-09-02 03:33:39.0 -0400
+++ RC13-s2io-u64/drivers/net/s2io.c2005-09-02
On Fri, Sep 02, 2005 at 01:03:43PM -0700, David S. Miller wrote:
> From: Alan Cox <[EMAIL PROTECTED]>
> Subject: Re: [PATCH] more of sparc32 dependencies fallout
> Date: Fri, 02 Sep 2005 21:24:08 +0100
>
> > On Gwe, 2005-09-02 at 20:12 +0100, [EMAIL PROTECTED] wrote:
> > > config MOXA_SMARTIO
> >
,
so for now I'd say that it's usable.
Current patchset is on ftp.linux.org.uk/pub/people/viro/ -
patch-2.6.13-git3-bird1.bz2 is combined patch, patchset/* is the splitup.
Long description of patches is in patchset/set*, short log is in the end of
this posting. Current build
- there will be
> > much more stuff to merge.
>
> > Current patchset is on ftp.linux.org.uk/pub/people/viro/ -
> > patch-2.6.13-git3-bird1.bz2 is combined patch, patchset/* is the splitup.
> > Long description of patches is in patchset/set*, short log is in the end
ted patchset in the same place:
ftp.linux.org.uk:/pub/people/viro/patchset/
ftp.linux.org.uk:/pub/people/viro/patch-2.6.13-git5-bird1.bz2
Old splitup had been moved to patchset-RC13-git3.
Changes:
* F6-zatm and B40-mxser-sparc32 merged upstream
* jd1--jd9 are partially
- there will be
> > much more stuff to merge.
>
> > Current patchset is on ftp.linux.org.uk/pub/people/viro/ -
> > patch-2.6.13-git3-bird1.bz2 is combined patch, patchset/* is the splitup.
> > Long description of patches is in patchset/set*, short log is in the end
With several more patches (mostly - sparse regression fixing); same place,
ftp.linux.org.uk/pub/people/viro/{patch-2.6.13-git5-bird2.bz,patchset}
Added:
* O4-dm9000 missed s/u32/pm_message_t/ (dm9000)
* S20-wdt __user annotations (booke_wdt.c
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-mga/arch/ppc/syslib/ocp.c
RC13-git5-ppc44x-pm/arch/ppc/syslib/ocp.c
--- RC13-git5-mga/arch/ppc/syslib/ocp.c 2005-08-28 23:09:40.0 -0400
+++ RC13-git5-ppc44x-pm/arch/ppc/syslib/ocp.c 2005-09-05 16:41:17.0
sunsu had been broken by ->stop_tx/->start_tx API changes.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-sata_qstor/drivers/serial/sunsu.c
RC13-git5-sunsu/drivers/serial/sunsu.c
--- RC13-git5-sata_qstor/drivers/serial/sunsu.c 2005-09-05 07:05:15.0
-0
e - just s/ARCH_MAY_HAVE_PC_FDC/your_prefered_name/g in the patch
below...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-rio/arch/alpha/Kconfig RC13-git5-floppy/arch/alpha/Kconfig
--- RC13-git5-rio/arch/alpha/Kconfig2005-08-28 23:09:39.0 -0400
+++ RC13-git5-floppy/ar
RCH_HAS_GEN_RTC and have
it set in arch/*/Kconfig for architectures that know what to do with this
stuff - for something supposedly generic the list of architectures where
it doesn't work is getting too long...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-serial/
llows:
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-uml-user/arch/um/Makefile-i386
RC13-git5-stubs/arch/um/Makefile-i386
--- RC13-git5-uml-user/arch/um/Makefile-i3862005-08-28 23:09:40.0
-0400
+++ RC13-git5-stubs/arch/um/Makefile-i386 2005-
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-sunsu/sound/arm/aaci.c RC13-git5-aaci/sound/arm/aaci.c
--- RC13-git5-sunsu/sound/arm/aaci.c2005-08-28 23:09:50.0 -0400
+++ RC13-git5-aaci/sound/arm/aaci.c 2005-09-05 16:41:09.0 -0400
@@ -821,7
On Mon, Sep 05, 2005 at 06:51:41PM -0700, David S. Miller wrote:
> Admittedly, the whole RTC situation is quite a mess I have to
> agree.
>
> To make the problem worse, we have two sets of RTC ioctls
> which userland makes use of on Sparc. The older ones which
> the SBUS RTC driver exported and s
On Mon, Sep 05, 2005 at 07:15:35PM -0700, Eugene Surovegin wrote:
> Identical fix is already in -mm
Then it really should go upstream; obvious fixes like that are not
something that needs filtration...
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a mes
On Tue, Sep 06, 2005 at 12:52:34PM +0200, Roman Zippel wrote:
> I'm not really a big fan of such dummy symbols, those whole point is to
> only enable dependencies, but are otherwise unsused.
> The basic problem is similiar to selects, that one has to grep the whole
> Kconfig to find out what modi
On Tue, Sep 06, 2005 at 05:05:33PM +0200, Roman Zippel wrote:
> Hi,
>
> On Tue, 6 Sep 2005 [EMAIL PROTECTED] wrote:
>
> > We could go for your "allow" form, but what else would need it? USB gadget
> > stuff with its "must have at most one low-level driver, high-level drivers
> > should be allowe
On Tue, Sep 06, 2005 at 07:53:49PM +0200, Frank van Maarseveen wrote:
> While I have access to /proc/, readlink fails with EACCES on
>
> /proc//exe
> /proc//cwd
> /proc//root
>
> even when I own though it runs with a different effective/saved/fs
> uid such as the X server. This
On Tue, Sep 06, 2005 at 02:42:02PM -0400, linux-os (Dick Johnson) wrote:
> I think
... and we have clear winner for the most incredible statement made on l-k.
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
On Tue, Sep 06, 2005 at 08:50:41PM +0200, Frank van Maarseveen wrote:
> On Tue, Sep 06, 2005 at 06:57:37PM +0100, [EMAIL PROTECTED] wrote:
> > On Tue, Sep 06, 2005 at 07:53:49PM +0200, Frank van Maarseveen wrote:
> > > While I have access to /proc/, readlink fails with EACCES on
> > >
> > > /pro
elf_aux is userland code; it uses symbol (ELF_CLASS) that doesn't exist in
userland headers; pulled into kernel-offsets.h, switched elf_aux to using it.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git5-base/arch/um/include/common-offsets.h
current/arch/um/inc
ftp.linux.org.uk/pub/peole/viro/patch-2.6.13-git7-brid1.bz2,
its splitup is in usual place and logs are in logs/*/*log19.
Added:
S26-ppc64-sparseCHECKFLAGS on ppc64 got broken
C40-elf_class bogus symbol used in elf_aux.c
C41-xfs XFS ___ENDIAN -Wundef warnings
O5-m68k
All uses of ADDRLEN are comparisons with 64 (it's an address width).
added define to 32 (again, we only care about comparisons with 64)
if not defined.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-ncr5380/drivers/net/hamachi.c
RC13-git7-hamachi/drivers/ne
NDEBUG and NDEBUG_ABORT are almost always used as integers in NCR5380; added
define to 0 if they are not defined, switched lone ifdef NDEBUG into if.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-smc-undef/drivers/scsi/NCR5380.c
RC13-git7-ncr5380/drivers/scsi/NCR
CARD_... in hisax are all used with #if; CARD_FN_ENTERNOW_PCI lacks define
to 0 if corresponding config option is not set.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-uml-mem/drivers/isdn/hisax/hisax.h
RC13-git7-hisax/drivers/isdn/hisax/hisax.h
--- RC13-git7-u
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-ppc64-sparse/arch/um/kernel/mem.c
RC13-git7-uml-mem/arch/um/kernel/mem.c
--- RC13-git7-ppc64-sparse/arch/um/kernel/mem.c 2005-08-28 23:09:40.0
-0400
+++ RC13-git7-uml-mem/arch/um/kernel/mem.c 2005-09-07
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-xfs/arch/ia64/hp/sim/simserial.c
RC13-git7-simserial/arch/ia64/hp/sim/simserial.c
--- RC13-git7-xfs/arch/ia64/hp/sim/simserial.c 2005-08-28 23:09:39.0
-0400
+++ RC13-git7-simserial/arch/ia64/hp/sim/simserial.c
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-hisax/drivers/net/smc91x.h
RC13-git7-smc-undef/drivers/net/smc91x.h
--- RC13-git7-hisax/drivers/net/smc91x.h2005-08-28 23:09:44.0
-0400
+++ RC13-git7-smc-undef/drivers/net/smc91x.h2005-09-07
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-hamachi/drivers/scsi/NCR53c406a.c
RC13-git7-ncr53c406/drivers/scsi/NCR53c406a.c
--- RC13-git7-hamachi/drivers/scsi/NCR53c406a.c 2005-08-28 23:09:45.0
-0400
+++ RC13-git7-ncr53c406/drivers/scsi/NCR53c406a.c 2
Now that asm-powerpc/* is using ifdefs on __powerpc64__ we need to add it
to CHECKFLAGS on ppc64.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-simserial/arch/ppc64/Makefile
RC13-git7-ppc64-sparse/arch/ppc64/Makefile
--- RC13-git7-simserial/arch/ppc64/Makefile 2
On Thu, Sep 08, 2005 at 04:16:24PM +0100, Christoph Hellwig wrote:
> On Thu, Sep 08, 2005 at 05:03:58PM +0200, Jan Beulich wrote:
> > (Note: Patch also attached because the inline version is certain to get
> > line wrapped.)
> >
> > Debugging and maintenance support code occasionally needs to know
On Thu, Sep 08, 2005 at 05:37:13PM +0100, Alan Cox wrote:
> On Iau, 2005-09-08 at 17:45 +0200, Jan Beulich wrote:
> > >The only general, usable strnicmp safe for general kernel use would be
> > a
> > >full all singing all dancing UTF-8 symbol aware arbitary locale
> > >implementation. And that we *
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
> From: Linus Torvalds <[EMAIL PROTECTED]>
> Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
>
> > Mistakes happen, and the way you fix them is not to pull a tantrum, but
> > tell people that they are idiots and they broke something, and
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/arch/ppc64/kernel/iomap.c
current/arch/ppc64/kernel/iomap.c
--- RC13-git8-base/arch/ppc64/kernel/iomap.c2005-06-17 15:48:29.0
-0400
+++ current/arch/ppc64/kernel/iomap.c 2005-09-08 23:53:33.0
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/arch/s390/Makefile current/arch/s390/Makefile
--- RC13-git8-base/arch/s390/Makefile 2005-06-17 15:48:29.0 -0400
+++ current/arch/s390/Makefile 2005-09-08 23:53:33.0 -0400
@@ -19,6 +19,7 @@
void * is not the same as void *...
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/fs/bio.c current/fs/bio.c
--- RC13-git8-base/fs/bio.c 2005-09-08 10:17:39.0 -0400
+++ current/fs/bio.c2005-09-08 23:53:33.0 -0400
@@ -683,7
Removed gratitious includes of asm/serial.h in synklinkmp and ip2main.
Allows to remove the rest of "broken on sparc32" in drivers/char - this
stuff doesn't break the build anymore. Since it got zero testing, it almost
certainly won't work there, though...
Signed-off
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/acpi/blacklist.c
current/drivers/acpi/blacklist.c
--- RC13-git8-base/drivers/acpi/blacklist.c 2005-09-08 23:42:49.0
-0400
+++ current/drivers/acpi/blacklist.c2005-09-09 11:28:44.0
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-m68k-hardirq/arch/um/kernel/skas/include/uaccess-skas.h
RC13-git7-uml-user/arch/um/kernel/skas/include/uaccess-skas.h
--- RC13-git7-m68k-hardirq/arch/um/kernel/skas/include/uaccess-skas.h
2005-06-17 15:48:29.0
Passes -m64 to sparse on uml/amd64, tells sparse to stay out of
USER_OBJS.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-stubs/arch/um/Makefile-x86_64
RC13-git7-uml-checker/arch/um/Makefile-x86_64
--- RC13-git7-stubs/arch/um/Makefile-x86_64 2005-09-05
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/arch/i386/kernel/sigframe.h
current/arch/i386/kernel/sigframe.h
--- RC13-git8-base/arch/i386/kernel/sigframe.h 2005-06-17 15:48:29.0
-0400
+++ current/arch/i386/kernel/sigframe.h 2005-09-08 23:53:33.0
On Fri, Sep 09, 2005 at 06:18:14PM +0200, Andreas Schwab wrote:
> [EMAIL PROTECTED] writes:
>
> > void * is not the same as void *...
>
> IMHO it should.
... and indeed it should. My apologies - that's a combination of
sparse bug and me being very low on coffee...
FWIW, looks like we are los
On Fri, Sep 09, 2005 at 06:19:02PM +0200, Eric Piel wrote:
> 09/09/2005 06:07 PM, [EMAIL PROTECTED] wrote/a ??crit:
> >Signed-off-by: Al Viro <[EMAIL PROTECTED]>
> >
> >diff -urN RC13-git8-base/drivers/acpi/blacklist.c
> >current/drivers/acpi/blacklist.c
&
> fs/bio.c:686:15: warning: incorrect type in assignment (different address
> spaces)
> fs/bio.c:686:15:expected void [noderef] *iov_base
> fs/bio.c:686:15:got void [noderef] *
> from the first form (cast to __user void *). Lovely...
>
> OK, I think I know what's going on there, will fix
On Fri, Sep 09, 2005 at 06:55:52PM +0200, Roman Zippel wrote:
> Hi,
>
> On Fri, 9 Sep 2005 [EMAIL PROTECTED] wrote:
>
> > Sigh... It should be left as #if, of course, but I suspect that cleaner
> > way to
> > deal with that would be (in Kconfig)
> >
> > config ACPI_BLACKLIST_YEAR
> > i
On Fri, Sep 09, 2005 at 06:29:38PM +0100, [EMAIL PROTECTED] wrote:
> > fs/bio.c:686:15: warning: incorrect type in assignment (different address
> > spaces)
> > fs/bio.c:686:15:expected void [noderef] *iov_base
> > fs/bio.c:686:15:got void [noderef] *
> > from the first form (cast to __use
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/char/ipmi/ipmi_devintf.c
current/drivers/char/ipmi/ipmi_devintf.c
--- RC13-git8-base/drivers/char/ipmi/ipmi_devintf.c 2005-09-08
10:17:39.0 -0400
+++ current/drivers/char/ipmi/ipmi_devintf.c2
* iomem pointers marked as such
* several direct dereferencings of such pointers replaced with
read[bw]().
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/char/epca.c current/drivers/char/epca.c
--- RC13-git8-base/drivers/char/epca.c 2005-09
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/ieee1394/video1394.c
current/drivers/ieee1394/video1394.c
--- RC13-git8-base/drivers/ieee1394/video1394.c 2005-08-28 23:09:41.0
-0400
+++ current/drivers/ieee1394/video1394.c2005-09-08
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/input/evdev.c current/drivers/input/evdev.c
--- RC13-git8-base/drivers/input/evdev.c2005-09-08 10:17:39.0
-0400
+++ current/drivers/input/evdev.c 2005-09-08 23:53:33.0 -0400
@@
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/md/md.c current/drivers/md/md.c
--- RC13-git8-base/drivers/md/md.c 2005-08-28 23:09:43.0 -0400
+++ current/drivers/md/md.c 2005-09-08 23:53:33.0 -0400
@@ -2087,7 +2087,7 @@
re
.g.
when normal pointer is cast to __iomem one - that caught a lot of crap in
drivers). casts from unsigned long are still OK, so's cast from 0, so's
__force cast, of course.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff --git a/evaluate.c b/evaluate.c
--- a/evaluate.c
+++ b/ev
envctrl doesn't need unistd.h; moreover, since it declares errno static
gcc4 gets very unhappy about including unistd.h.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-m68k-8390/drivers/sbus/char/bbc_envctrl.c
RC13-git7-envctrl/drivers/sbus/char/bb
We get regular portability bugs when somebody decides to include
linux/irq.h into a driver instead of asm/irq.h. It's almost always a
wrong thing to do and, in fact, causes immediate breakage on e.g. arm.
Here's what I'm going to do:
* check current includes of linux/irq.h; e.g. i
gt;
> make C=1 CHECK="sparse -Wbitwise"
> or
> make C=1
Or patch below and use make C=1 CF=-Wbitwise...
Allows to add to sparse arguments without mutilating makefiles - just
pass CF= and they will be added to CHECKFLAGS.
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git8-base/drivers/scsi/qla2xxx/qla_dbg.c
current/drivers/scsi/qla2xxx/qla_dbg.c
--- RC13-git8-base/drivers/scsi/qla2xxx/qla_dbg.c 2005-08-28
23:09:45.0 -0400
+++ current/drivers/scsi/qla2xxx/qla_dbg.c 2005-09
Signed-off-by: Al Viro <[EMAIL PROTECTED]>
diff -urN RC13-git7-s2io-u64/drivers/scsi/ch.c
RC13-git7-scsi-ch/drivers/scsi/ch.c
--- RC13-git7-s2io-u64/drivers/scsi/ch.c2005-08-28 23:09:45.0
-0400
+++ RC13-git7-scsi-ch/drivers/scsi/ch.c 2005-09-07 13:55:19.0
On Wed, Nov 28, 2012 at 11:15:12AM -0800, Linus Torvalds wrote:
> No, this is crap.
>
> We don't introduce random hooks like this just because the block layer
> has shit-for-brains and cannot be bothered to do things right.
>
> The fact is, the whole locking in the block layer open routine is
> t
On Thu, Nov 29, 2012 at 01:20:37AM +0100, Peter Huewe wrote:
> - itpm = (probe == 0) ? 0 : 1;
> + itpm = (probe == 0) ? false : true;
Charming. Not that original had been better, but...
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body
size, when we have it in the buffer-head that we have to touch
> *anyway*).
>
> Comments? Again, untested.
>
> And I notice that Al Viro hasn't been cc'd, which is sad, since he's
> been involved in much of fs/block_dev.c.
>
> Al - this is an independent patc
On Thu, Nov 29, 2012 at 06:25:19AM +, Al Viro wrote:
> Umm... set_blocksize() is calling kill_bdev(), which does
> truncate_inode_pages(mapping, 0). What's going to happen to data in
> the dirty pages? IO in progress is not the only thing to worry about...
Note that
On Wed, Nov 28, 2012 at 10:37:27PM -0800, Linus Torvalds wrote:
> On Wed, Nov 28, 2012 at 10:30 PM, Al Viro wrote:
> >
> > Note that sync_blockdev() a few lines prior to that is good only if we
> > have no other processes doing write(2) (or dirtying the mmapped pages,
>
On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote:
> Maarten Lankhorst writes:
>
> >> Could you try the following patch? This should report what directories
> >> cannot be renamed because one of them is a mount point and it gives some
> >> real insight into what is going on.
> >
On Thu, Nov 29, 2012 at 08:06:12PM +, Al Viro wrote:
> On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote:
> > Maarten Lankhorst writes:
> >
> > >> Could you try the following patch? This should report what directories
> > >> cannot be
On Thu, Nov 29, 2012 at 08:53:34PM +, Al Viro wrote:
> On Thu, Nov 29, 2012 at 08:06:12PM +, Al Viro wrote:
> > On Tue, Sep 25, 2012 at 04:29:58AM -0700, Eric W. Biederman wrote:
> > > Maarten Lankhorst writes:
> > >
> > > >> Could you try the
On Thu, Nov 29, 2012 at 11:16:59AM -0800, Patrick McLean wrote:
> With 3.6-rc1 and up, when using a (dracut) initramfs with a read-only
> nfs root, all accesses to /proc. /sys and /dev return EBUSY.
See "[PATCH] Revert "__d_unalias() should refuse to move mountpoints"
thread. If you have a conven
On Thu, Nov 29, 2012 at 09:30:34PM +, Al Viro wrote:
> + if (d_invalidate(dentry) != 0) {
> + WARN_ON(1);
> + goto out;
> + }
> dput(dentry);
>
On Thu, Nov 29, 2012 at 02:06:22PM -0800, Patrick McLean wrote:
> I have a trivial reproducer and am happy to help debug in any way that
> I can. That patch seems to fix the problem, and produces these
> warnings in dmesg:
>
> [3.306483] dracut: Switching root
> [4.324378] systemd-udevd[5
On Thu, Nov 29, 2012 at 02:53:13PM -0800, Patrick McLean wrote:
> On 29/11/12 02:21 PM, Al Viro wrote:
> > On Thu, Nov 29, 2012 at 02:06:22PM -0800, Patrick McLean wrote:
> >
> >> I have a trivial reproducer and am happy to help debug in any way that
> >> I
On Thu, Nov 29, 2012 at 04:19:51PM -0800, Patrick McLean wrote:
> >> [8.821584] FH(0)]
> >> [8.821586] FH(36)[01 00 07 01 89 00 00 00 00 00 00 00 e1 21 fe c4 9e
> >> 38 44 dc bf 1b d5 95 d6 76 d6 d9 a7 3c 1b 80 33 38 e3 62]
> >> [8.821601] filename: proc
> >
> > *whoa*
> >
> > So we
On Thu, Nov 29, 2012 at 04:57:19PM -0800, Patrick McLean wrote:
> > Interesting... Server-side that should've been produced by
> > encode_entryplus_baggage(), which looks like failing compose_entry_fh()...
> > which has explicit
> > if (d_mountpoint(dchild))
> > goto out;
>
On Thu, Nov 29, 2012 at 05:54:02PM -0800, Patrick McLean wrote:
> > Very interesting. Do you have anything mounted on the corresponding
> > directories on server? The picture looks like you are getting empty
> > fhandles in readdir+ respons for exactly the same directories that happen
> > to
On Fri, Nov 16, 2012 at 02:58:46PM -0500, Eric Paris wrote:
> On Mon, Nov 12, 2012 at 11:57 AM, Pavel Roskin wrote:
> > Quoting Eric Paris :
> >
> >> OMG this +1 -1 stuff is nuts...
>
> Ping, Al.
>
> int iterate_fd(struct files_struct *files, unsigned n,
> [snip]
> while (!res && n < fdt
On Fri, Nov 30, 2012 at 03:40:34AM +, Al Viro wrote:
> The bug is real, but Pavel's patch is all wrong. The problem is in the
> argument; we should pass descriptor number, not descriptor + 1. And fixing
> that (in iterator_fd() itself) makes all callbacks work as they oug
On Fri, Oct 26, 2012 at 11:14:41AM -0200, Carlos Maiolino wrote:
> Hi,
>
> On Thu, Oct 25, 2012 at 05:08:19PM +0530, Abhijit Pawar wrote:
> > Hi,
> > set_anon_super is called by many filesystems. Some call directly and
> > some call through the wrapper. Many of them in the wrapper's call to
> > th
On Thu, Nov 29, 2012 at 06:33:53PM -0800, Patrick McLean wrote:
> Excellent, thanks. Is there any chance this will make it to 3.7? Also we
> might want to cc stable@ on this as well since it is a regression in 3.6.
Definitely. I've dropped that into vfs.git#for-linus and vfs.git#for-next
and to
On Fri, Nov 30, 2012 at 11:10:02AM +0530, Abhijit Pawar wrote:
> > Because we want it to be a valid sget() callback. I doubt that this
> > optimization is worth doing, though - might even micro-pessimize the things
> > on architectures where all arguments are passed in registers.
> >
> Al,
>
On Mon, Mar 18, 2013 at 04:39:36PM +0100, Jan Kara wrote:
> IMO the deadlock is real. In freeze_super() we wait for all writers to
> the filesystem to finish while blocking beginning of any further writes. So
> we have a deadlock scenario like:
>
> THREAD1 THREAD2
On Mon, Mar 18, 2013 at 09:53:34PM +, Al Viro wrote:
> On Mon, Mar 18, 2013 at 04:39:36PM +0100, Jan Kara wrote:
> > IMO the deadlock is real. In freeze_super() we wait for all writers to
> > the filesystem to finish while blocking beginning of any further writes. So
> &g
On Mon, Mar 18, 2013 at 11:01:03PM +, Al Viro wrote:
> I'm looking at the existing callers and I really wonder if we ought to
> push sb_start_write() from ->splice_write()/->aio_write()/etc. into the
> callers.
>
> Something like file_start_write()/file_end_wr
On Tue, Mar 19, 2013 at 03:00:53PM +, David Howells wrote:
> MIPS's siginfo handling has been broken since this commit:
>
> commit 574c4866e33d648520a8bd5bf6f573ea6e554e88
> Author: Al Viro
> Date: Sun Nov 25 22:24:19 2012 -0500
> consoli
On Tue, Mar 19, 2013 at 11:29:41AM +0100, Miklos Szeredi wrote:
> Copy up is a once-in-a-lifetime event for an object. Optimizing it is
> way down in the list of things to do. I'd drop splice in a jiffy if
> it's in the way.
What makes you think that write is any better? Same deadlock there -
On Tue, Mar 19, 2013 at 07:32:42PM +0100, Miklos Szeredi wrote:
> > * victim is negative => create a whiteout
> > * victim is a directory, parent opaque => rmdir
> > * victim is a non-directory, parent opaque => unlink
> > * victim is positive, parent _not_ opaque =
On Tue, Mar 19, 2013 at 09:25:43PM +0100, Jan Kara wrote:
> > BTW, having sb_start_write() buried in individual ->splice_write() is
> > asking for trouble; could you describe the rules for that? E.g. where
> > does it nest wrt filesystem-private locks? XFS iolock, for example...
> Generally, th
On Tue, Mar 19, 2013 at 09:38:31PM +, Al Viro wrote:
> On Tue, Mar 19, 2013 at 09:25:43PM +0100, Jan Kara wrote:
> > > BTW, having sb_start_write() buried in individual ->splice_write() is
> > > asking for trouble; could you describe the rules for that? E.g. wher
On Tue, Mar 19, 2013 at 10:10:32PM +, Al Viro wrote:
> OK, it's going to be an interesting series - aforementioned tentative patch
> was badly incomplete ;-/
The interesting question is how far do we want to lift that. ->aio_write()
part is trivial - see vfs.git#experimenta
On Wed, Mar 20, 2013 at 03:47:53PM +0300, Dan Carpenter wrote:
> The original code here needs to broken up into functions so it isn't
> squashed up against the 80 character limit.
I'd say what needs to be done to the original code...
Observation 1:
if (foo) {
A /* two lines */
} else {
On Wed, Mar 20, 2013 at 09:08:03PM +0530, Shankar Brahadeeswaran wrote:
> Hi Greg, Dan,
>
> Few days back I posted a patch to fix a dead lock issue in the ashmem
> driver that got merged in staging-next branch
> https://lkml.org/lkml/2013/2/20/429
>
> I'm seeing that there exists another path in
On Wed, Mar 20, 2013 at 09:26:54AM -0700, Joe Perches wrote:
> Add Al's comments in from https://lkml.org/lkml/2013/3/20/345
> +Tip 7:
> +Code flow is down, not across...
That one is a lovely improvement on what I actually said. google
"down, not across" for context...
--
To unsubscribe from thi
On Wed, Mar 20, 2013 at 03:41:08PM -0400, George Spelvin wrote:
> Sorry for being so very late to the party, but rather than messing
> with xattrs, why not just have a specific file (say, default /.whiteout,
> but selectable via a mount option) and links to it are counted as
> whiteout entries?
>
On Wed, Mar 20, 2013 at 08:52:22PM +0100, Jan Kara wrote:
> > do_bio_filebacked(), with some ugliness between that and callsite. Note,
> > BTW, that we have a pair of possible vfs_fsync() calls in there; how do
> > those
> > interact with freeze?
> Freezing code takes care that all dirty data i
1 - 100 of 7630 matches
Mail list logo
