Re: [RESEND] rsi: Remove stack VLA usage

2018-03-13 Thread tcharding
On Mon, Mar 12, 2018 at 09:46:06AM +, Kalle Valo wrote: > tcharding wrote: > > > The kernel would like to have all stack VLA usage removed[1]. rsi uses > > a VLA based on 'blksize'. Elsewhere in the SDIO code maximum block size > > is defined using

Re: Hashed pointer issues

2018-05-01 Thread tcharding
On Mon, Apr 30, 2018 at 05:12:05PM +, Linus Torvalds wrote: > On Mon, Apr 30, 2018 at 10:06 AM Randy Dunlap wrote: > > On 04/30/2018 10:01 AM, Linus Torvalds wrote: > > > > > > No kernel command line needed in practice any more. That's assuming any > > > kernel developer will have an IvyBridge

Re: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option

2018-05-01 Thread tcharding
On Wed, May 02, 2018 at 01:02:34AM +, Linus Torvalds wrote: > On Tue, May 1, 2018 at 4:34 PM Tobin C. Harding wrote: > > > > This option should NOT be enabled on production kernels. > > I think with your fixes to get_random_bytes_arch(), it's perfectly fine to > use on production kernels (a

Re: [PATCH 3/3] vsprintf: Add use-early-random-bytes cmd line option

2018-05-01 Thread tcharding
On Tue, May 01, 2018 at 09:45:07PM -0400, Steven Rostedt wrote: > On Wed, 2 May 2018 11:27:58 +1000 > tcharding wrote: > > > On Wed, May 02, 2018 at 01:02:34AM +, Linus Torvalds wrote: > > > On Tue, May 1, 2018 at 4:34 PM Tobin C. Harding wrote: > > > &g

[PATCH 0/4] drivers: staging: checkpatch fixes

2016-04-17 Thread tcharding
drivers/staging/android/ion/ion.c produces 2 warnings and 29 checks. This patch set fixes both warnings and all but 4 of the checks. All except the last patch are trivial. Signed-off-by: tcharding --- Patch 1/4 is whitespace only. This is my first Linux kernel patch. thanks tcharding (4

[PATCH 2/4] drivers: staging: fix line length

2016-04-17 Thread tcharding
drivers/staging/android/ion/ion.c checkpatch produces line over 80 character warnings. This patch is whitespace only and fixes these warnings. Signed-off-by: tcharding --- drivers/staging/android/ion/ion.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/drivers

[PATCH 1/4] drivers: staging: fix parameter alignment

2016-04-17 Thread tcharding
drivers/staging/android/ion/ion.c checkpatch produces alignment checks. This patch is whitespace only and fixes these checks. Signed-off-by: tcharding --- drivers/staging/android/ion/ion.c | 64 +++ 1 file changed, 32 insertions(+), 32 deletions(-) diff

[PATCH 3/4] drivers: staging: remove comparison to NULL

2016-04-17 Thread tcharding
drivers/staging/android/ion/ion.c checkpatch produces 'Comparison to NULL could be written ...' checks. This patch replaces comparison to NULL with !var as suggested by checkpatch. Signed-off-by: tcharding --- drivers/staging/android/ion/ion.c | 6 +++--- 1 file changed, 3 insert

[PATCH 4/4] drivers: staging: remove BUG_ON

2016-04-17 Thread tcharding
drivers/staging/android/ion/ion.c calls BUG_ON in places where WARN_ON will suffice. This patch replaces two such occurences. Two other occurences remain. Signed-off-by: tcharding --- Changing the remaining two BUG_ON's causes changes to the programm logic. This is my first patch set t