http://10468.diljcancb.com/?M_OROxgqRkn9yMg80709
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
nfig __initdata = {
> - .get_pendown_state = ads7846_get_pendown_state,
> + .gpio_pendown = (GPIO_PORTD | 25),
Please use IMX_GPIO_NR(4, 25) instead. Otherwise this looks ok.
Eric, ok with you?
Sascha
--
Pengutronix e.K. |
Signed-off-by: Silviu-Mihai Popescu
Acked-by: Sascha Hauer
Sascha
> ---
> drivers/staging/imx-drm/ipu-v3/ipu-dp.c |1 -
> 1 file changed, 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> b/drivers/staging/imx-drm/ipu-v3/ipu-dp.c
> index 26aecaf..11
returned frequency he can request a different one.
> And he's eventually happy with the return value he calls
> clk_set_rate() requesting the frequency clk_round_rate() returned.
> Always rounding down seems a bit odd to me.
>
> Another issue
eliably provide a reference to the clock in the device tree.
There is an established way of providing clocks in the devicetree using
the clocks/clock-names properties. Wouldn't it be better using this
for OMAP aswell?
Sascha
--
Pengutronix e.K. |
d are two users of this interface, a i2c master driver
and a watchdog driver.
Comments very appreciated.
Sascha
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kerne
This driver provides a I2C bus driver for the CGEB interface
found on some Congatec x86 modules. No devices are registered
on the bus, the user has to do this via the i2c device /sys
interface.
Signed-off-by: Sascha Hauer
---
drivers/i2c/busses/Kconfig |7 ++
drivers/i2c/busses
This driver provides support for the CGEB watchdog found on some
Congatec x86 modules.
Signed-off-by: Sascha Hauer
---
drivers/watchdog/Kconfig | 10 ++
drivers/watchdog/Makefile |1 +
drivers/watchdog/congatec_cgeb_watchdog.c | 161
The Congatec CGEB is a BIOS interface found on some Congatec x86
modules. It provides access to on board peripherals like I2C busses
and watchdogs. This driver contains the basic support for accessing
the CGEB interface and registers the child devices.
Signed-off-by: Sascha Hauer
---
arch/x86
Eric,
Any comment to this one? It looks like an obvious bugfix, but since this
is quite old and was never noticed I wonder if there's something else
wrong aswell?
Sascha
On Fri, Mar 22, 2013 at 01:15:02AM +0100, Paul Bolle wrote:
> Commit 2d66c7803595da0d4bcd949825d598575f5de9e6 ("
On Sun, Mar 31, 2013 at 10:59:47PM +0800, Axel Lin wrote:
> We can test PWMF_ENABLED bit to know if pwm is enabled or not.
> Thus remove enabled field from struct imx_chip.
>
> Signed-off-by: Axel Lin
Looks good.
Acked-by: Sascha Hauer
Sascha
> ---
> drivers/pw
On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote:
> 2013/2/12 Sascha Hauer :
> > --
>
> There seems to be a problem:
>
> Mar 26 16:11:25 OT kernel: [ 80.207514] cgeb-watchdog
> cgeb-watchdog.0: registered
> Mar 26 16:11:38 OT watchdog[2519]: stoppi
On Tue, Mar 26, 2013 at 07:33:31AM -0700, Guenter Roeck wrote:
> On Tue, Mar 26, 2013 at 11:16:35AM +0100, Christian Gmeiner wrote:
> > 2013/2/12 Sascha Hauer :
> > > This driver provides support for the CGEB watchdog found on some
> > > Congatec x86 modules.
> &
On Wed, Apr 03, 2013 at 08:30:00AM -0700, Guenter Roeck wrote:
> On Wed, Apr 03, 2013 at 05:09:52PM +0200, Sascha Hauer wrote:
> [ ... ]
>
> > >
> > > On a side note, if the driver supports devicetree, it might make sense to
> > > call
> > > wa
D
data to 1) pick display timings 2) pick the right power sequence that
fits the panel found in EDID. You can't archieve 2) by hardcoding the
panel in the devicetree.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions
I'm worried about this aswell. I think platform_driver_probe shouldn't
be used anymore. Even if a driver does not explicitly make use of
-EPROBE_DEFER, it leaks in very quickly if a driver for example uses a
regulator and just returns the error value from regulator_get.
Sascha
--
Pengut
t the following patch.
It makes further changes and cleanups easier.
Also, I have a second patch here which consistently switches the pwm to
use the ipg clock for its output instead of the per clock. This
eliminates the use of another cpu_is_*. The patch is not rea
On Sun, Aug 26, 2012 at 09:48:11AM +0800, Wei Yongjun wrote:
> From: Wei Yongjun
>
> From: Wei Yongjun
Applied, thanks
Sascha
>
> Remove duplicated include.
>
> Signed-off-by: Wei Yongjun
> ---
> arch/arm/mach-imx/clk-imx21.c | 1 -
> 1 file changed, 1 dele
cleanups easier:
https://lkml.org/lkml/2012/8/28/24
Simililarly, we should probably introduce a imx_pwm_[en|dis]able_v[12]
Then, the pwm core already makes sure that pwm_enable/disable are called
only once, so the if (imx->clk_enabled) in pwm_enable/disable is
unnecessary.
Sascha
>
&
even when the SoC is in low power modes.
This patch requests both clocks and enables the ipg clock for accessing
registers and the peripheral clock to actually turn on the pwm.
Signed-off-by: Philipp Zabel
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 33
The pwm core makes sure that pwm_enable/disable are called only
once. Still keep the enabled state since we will need it in
pwm_config.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers
We used to enable/disable the pwm only by switching the
clock on or off. Instead, use the dedicated register bits.
These differ on different SoCs, so introduce a SoC specific
function for this.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 48
To make the code more flexible.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 145 -
1 file changed, 82 insertions(+), 63 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 2a0b353..38270f4 100644
--- a
should be no need to keep compatibility for platform
based boards.
Hopefully this series fixes the issues mentioned by Benoît. It has been
tested on an i.MX53 only.
Sascha
Philipp Zabel (3):
pwm i.MX: add devicetree support
From: Philipp Zabel
Signed-off-by: Philipp Zabel
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 25 +++--
1 file changed, 19 insertions(+), 6 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index a689144..dfc1bae 100644
--- a/drivers/pwm
in low power modes.
Use the always running clock also on i.MX25.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index dfc1bae..3834f475 100644
--- a/drivers/pwm/pwm
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 3fc4ae8..a689144 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -270,17 +270,7 @@ static
Signed-off-by: Sascha Hauer
Conflicts:
arch/arm/mach-imx/clk-imx51-imx53.c
---
arch/arm/boot/dts/imx53.dtsi| 14 ++
arch/arm/mach-imx/clk-imx51-imx53.c |4
2 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts
From: Philipp Zabel
Signed-off-by: Philipp Zabel
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 25 ++---
1 file changed, 22 insertions(+), 3 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 308ab51..dce2acb 100644
--- a/drivers/pwm
nes the clock "mxc_nand".
The driver generally works on i.MX53, only some pieces are missing. I
just resent the corresponding series and put you on Cc.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http:
On Fri, Aug 31, 2012 at 05:45:49AM +0800, Shawn Guo wrote:
> On Tue, Aug 28, 2012 at 01:48:15PM +0200, Sascha Hauer wrote:
> > Hi All,
> >
> > The following patches are an overdue work on the i.MX pwm driver.
> >
> > - introduce SoC specific functions to m
On Fri, Aug 31, 2012 at 06:32:20AM +0800, Shawn Guo wrote:
> On Tue, Aug 28, 2012 at 01:48:23PM +0200, Sascha Hauer wrote:
> > Signed-off-by: Sascha Hauer
> >
> > Conflicts:
> > arch/arm/mach-imx/clk-imx51-imx53.c
>
> Yeah, I know you have sorted out confl
e NAND_CMD_PARAM:
> host->devtype_data->send_cmd(host, command, true);
> mxc_do_addr_cycle(mtd, column, page_addr);
> host->devtype_data->send_read_param(host);
> - host->buf_start = column;
> +
;
> Signed-off-by: Arnd Bergmann
> Cc: "David S. Miller"
> Cc: net...@vger.kernel.org
> Cc: Sascha Hauer
Acked-by: Sascha Hauer
> ---
> arch/arm/mach-netx/nxdb500.c |2
> +-
> arch/arm/mach-netx/nxdkn.c
;
> Signed-off-by: Arnd Bergmann
> Cc: Sascha Hauer
> Cc: Russell King
> Cc: Vinod Koul
> Cc: Dan Williams
> Cc: "Ben Dooks (embedded platforms)"
> Cc: "Wolfram Sang (embedded platforms)"
> Cc: Mauro Carvalho Chehab
> Cc: Chris Ball
> Cc: D
On Tue, Sep 11, 2012 at 04:40:43PM +0200, Thierry Reding wrote:
> On Mon, Sep 10, 2012 at 10:59:35AM +0200, Sascha Hauer wrote:
> > From: Philipp Zabel
> >
> > At the same time remove platform based support. No user for
> > this driver has made it into mainline so far,
t; drivers with the DT data? =)
I have this concern aswell, that's why I'm sceptical about this patch
set. But what are the alternatives? Adding power code to the drivers and
thus adding board specific code to them is backwards.
Sascha
--
Pengutronix e.K. |
On Thu, Sep 13, 2012 at 10:03:27AM +0300, Tomi Valkeinen wrote:
> On Thu, 2012-09-13 at 09:00 +0200, Sascha Hauer wrote:
> > On Thu, Sep 13, 2012 at 09:54:09AM +0300, Tomi Valkeinen wrote:
> > > On Thu, 2012-09-13 at 15:36 +0900, Alex Courbot wrote:
> > > > On Thurs
On Thu, Sep 13, 2012 at 09:29:20AM +0200, Thierry Reding wrote:
> On Thu, Sep 13, 2012 at 10:03:27AM +0300, Tomi Valkeinen wrote:
> > On Thu, 2012-09-13 at 09:00 +0200, Sascha Hauer wrote:
> > > On Thu, Sep 13, 2012 at 09:54:09AM +0300, Tomi Valkeinen wrote:
> > > &g
ead.
>
> While at it, also fix the clock error handling code.
>
> Signed-off-by: Fabio Estevam
Acked-by: Sascha Hauer
> -
> Changes since v1:
> - Fix clock error handling
> drivers/w1/masters/mxc_w1.c | 10 +-
> 1 file changed, 5 insertions(+), 5 deleti
devicetrees may have the linux,stdout-path property to specify the
console. This patch adds support to the i.MX serial driver for this.
Signed-off-by: Sascha Hauer
---
I was originally looking for a more generic way to handle this, but
since a struct console has no device associated to it, it&#
On Thu, Oct 04, 2012 at 07:44:45AM -0500, Rob Herring wrote:
> On 10/04/2012 05:39 AM, Sascha Hauer wrote:
> > devicetrees may have the linux,stdout-path property to specify the
> > console. This patch adds support to the i.MX serial driver for this.
> >
> >
off-by: Thierry Reding
> Cc: Shawn Guo
> Cc: Sascha Hauer
> Cc: Philipp Zabel
> Cc: "Benoît Thébaudeau"
> Cc: Stephen Warren
Acked-by: Sascha Hauer
> ---
> Documentation/devicetree/bindings/pwm/imx-pwm.txt| 2 +-
> Documentation/d
This adds a helper function to match the linux,stdout-path property
against a struct device and adds support for this property to the i.MX
serial driver.
Sascha
Sascha Hauer (3):
serial_core: Add helper for matching against
devicetrees may have a linux,stdout-path property in the chosen
node describing the console device. This adds a helper function
to match a device against this property so a driver can call
add_preferred_console for a matching device.
Signed-off-by: Sascha Hauer
---
drivers/tty/serial
devicetrees may have the linux,stdout-path property to specify the
console. This patch adds support to the i.MX serial driver for this.
Signed-off-by: Sascha Hauer
---
drivers/tty/serial/imx.c |3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty
Traditionally console support is optional for serial drivers. This
makes it non optional for the i.MX driver since it's not worth
asking questions for a feature virtually every user of this driver
wants to have.
Signed-off-by: Sascha Hauer
---
drivers/tty/serial/Kconfig |
ps://github.com/weiyj/dpatch)
>
> Signed-off-by: Wei Yongjun
Applied, thanks
Sascha
> ---
> arch/arm/mach-imx/clk-gate2.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/arch/arm/mach-imx/clk-gate2.c b/arch/arm/mach-imx/clk-gate2.c
> index 3c1b8ff.
t;, "ipg",
> MXC_CCM_CCGR4, 8);
> + clk[can2_serial_gate] = imx_clk_gate2("can2_serial_gate", "can_sel",
> MXC_CCM_CCGR4, 6);
> + clk[can2_ipg_gate] = imx_clk_gate2("can2_ipg_gate", "ipg",
> MXC_CCM_CCGR4, 8);
This doesn&#x
generic for serial
devices.
Sascha Hauer (3):
OF: Add helper for matching against linux,stdout-path
serial: i.MX: Make console support non optional
serial: i.MX: evaluate linux,stdout-path property
drivers/of
devicetrees may have the linux,stdout-path property to specify the
console. This patch adds support to the i.MX serial driver for this.
Signed-off-by: Sascha Hauer
---
drivers/tty/serial/imx.c |4
1 file changed, 4 insertions(+)
diff --git a/drivers/tty/serial/imx.c b/drivers/tty
Traditionally console support is optional for serial drivers. This
makes it non optional for the i.MX driver since it's not worth
asking questions for a feature virtually every user of this driver
wants to have.
Signed-off-by: Sascha Hauer
---
drivers/tty/serial/Kconfig |
devicetrees may have a linux,stdout-path property in the chosen
node describing the console device. This adds a helper function
to match a device against this property so a driver can call
add_preferred_console for a matching device.
Signed-off-by: Sascha Hauer
---
drivers/of/Kconfig
On Fri, Jul 27, 2012 at 01:47:51PM -0300, Fabio Estevam wrote:
> Adapt clocks to the new i.mx clock framework and fix the following warning:
>
> Cc: Theodore Ts'o
> Cc: Herbert Xu
> Cc:
> Signed-off-by: Fabio Estevam
Both:
Acked-by: Sascha Hauer
Sascha
&
On Thu, Oct 18, 2012 at 06:06:08PM +0200, Roland Stigge wrote:
> This patch enables support for i.MX53 in addition to i.MX25 by enabling the
> driver on ARCH_MXC generally.
>
> Signed-off-by: Roland Stigge
Acked-by: Sascha Hauer
> ---
> drivers/rtc/Kconfig |2 +-
&g
On Thu, Oct 18, 2012 at 06:06:09PM +0200, Roland Stigge wrote:
> This patch adds device tree support to the rtc-imxdi driver.
>
> Signed-off-by: Roland Stigge
Acked-by: Sascha Hauer
> ---
> Documentation/devicetree/bindings/rtc/imxdi-rtc.txt | 17 +
>
d-off-by: Roland Stigge
Applied, thanks
Sascha
> ---
> arch/arm/mach-imx/clk-imx51-imx53.c |1 +
> 1 file changed, 1 insertion(+)
>
> --- linux-2.6.orig/arch/arm/mach-imx/clk-imx51-imx53.c
> +++ linux-2.6/arch/arm/mach-imx/clk-imx51-imx53.c
> @@ -467,6 +467,7
@@
> +/*
> + * Copyright 2012 Philippe Reynes
> + * Copyright 2012 Armadeus Systems
> + *
> + * Based on code which is: Copyright 2012 Sascha Hauer, Pengutronix
> + *
> + * The code contained herein is licensed under the GNU General Public
> + * License. You may obtain a copy of the
On Thu, Oct 25, 2012 at 01:28:33PM +0200, Roland Stigge wrote:
> This patch fixes watchdog support after devicetree switch for imx53
>
> Signed-off-by: Roland Stigge
Applied, thanks
Sascha
>
> ---
> arch/arm/mach-imx/Kconfig |1 +
> 1 file changed, 1 insertion(+)
&g
On Thu, Oct 25, 2012 at 01:26:39PM +0200, Roland Stigge wrote:
> This patch supplements pinctl support on i.MX53.
>
> Signed-off-by: Roland Stigge
Acked-by: Sascha Hauer
Shawn, probably better when you take this patch as it's quite likely
that you collect other patches to this
Roland,
Do you have updates on this one? I think this patch is wrong, specifying
the clock rate in the devicetree is only for PowerPC, so I think this
needs further investigation.
Sascha
On Thu, Oct 25, 2012 at 01:26:40PM +0200, Roland Stigge wrote:
> This patch fixes CAN clocking on i.M
On Tue, Oct 30, 2012 at 07:55:44PM +, Philippe Reynes wrote:
>
>
> Hi Sascha,
> >> + osc26m {
>
> >> + compatible = "fsl,imx-osc26m", "fixed-clock";
> >> + clock-frequency = <33554432>;
>
>
gt; @@ -41,7 +41,6 @@ struct imx_drm_device {
> struct list_headencoder_list;
> struct list_headconnector_list;
> struct mutexmutex;
> - int references;
Nack. We need the
On Wed, Aug 28, 2013 at 11:39:11AM -0300, Fabio Estevam wrote:
> On Wed, Aug 28, 2013 at 2:27 AM, Sascha Hauer wrote:
>
> > Nack. We need the references to prevent that encoders/connectors are
> > (de)registered while the device is active. Simply dropping this code is
> &g
On Wed, Aug 28, 2013 at 05:10:16PM -0300, Fabio Estevam wrote:
> On Wed, Aug 28, 2013 at 3:54 PM, Sascha Hauer wrote:
>
> > Do the open/close callbacks work?
>
> The 'open' callback maps to the generic 'drm_open', so we cannot use it.
We could replace t
quot;fsl,imx6q-uart".
>
> This patch rewrites the match code, and make it to check the compatible
> in the order set by the DTS file.
Why don't you set the matching order in the driver the way you want it
to be, i.e.:
{ .compatible = "fsl,imx6q-uar
On Tue, Jul 09, 2013 at 03:46:34PM +0800, Huang Shijie wrote:
> 于 2013年07月09日 15:05, Sascha Hauer 写道:
> >Why don't you set the matching order in the driver the way you want it
> >to be, i.e.:
> >
> > { .compatible = "fsl,imx6q-uart", ...
y cycle.
Note there's also support for inverted PWMs in the PWM framework
provided your hardware supports this.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137
iguring the iomux before the PWM driver takes over, then the pinctrl
should be done from the client drivers (pwm_backlight, pwm_led), not
from the pwm driver and not from the pinctrl framework before
initializing the clients.
So NACK to this complex pinctrl setup in this pwm driver.
Sascha
--
P
ers/pwm/pwm-fsl-ftm.c
>
> This looks pretty good to me. I noticed that you didn't Cc Sascha who
> commented on this a lot. Can you please resend with him Cc'ed to make
> sure he sees this version of the series?
I'm alr
pinctrl-9 = <&pinctrl_pwm0_ch4_idle>;
> + pinctrl-10 = <&pinctrl_pwm0_ch5_active>;
> + pinctrl-11 = <&pinctrl_pwm0_ch5_idle>;
> + pinctrl-12 = <&pinctrl_pwm0_ch6_a
+ struct resource *res;
> +
> + fpc = devm_kzalloc(&pdev->dev, sizeof(*fpc), GFP_KERNEL);
You don't have to output a message when kzalloc fails, but still you
should check for the result and return an error if necessary.
With this fixed:
Reviewed-by: Sascha Hauer
Sasch
On Wed, Sep 04, 2013 at 07:04:39AM +0200, Michael Opdenacker wrote:
> This flag is a NOOP since 2.6.35 and can be removed.
>
> This is an update for 3.11 of a patch already sent for 3.10
>
> Signed-off-by: Michael Opdenacker
(added shawn to Cc)
Acked-by: Sascha Hauer
Sascha
imx_drm_add_encoder(struct drm_encoder *encoder,
>
> mutex_lock(&imxdrm->mutex);
>
> - if (imxdrm->references) {
> - ret = -EBUSY;
> - goto err_busy;
> - }
...here...
> mutex_lock(&imxdrm->mutex);
>
&g
sure all submodules for
> encoders/crtcs
> + are fully loaded before the drm driver is registered.
We can't know when all submodules are registered and really I think this
is not necessary. The driver will use the components available during
open time. When being opened no components wi
device
which is in use you better do not add/remove components.
Again: The imx-drm driver does *not* do hotplugging. It will *not* add
or remove components when the device is opened. The code you remove
exactly makes (or made before Daniels patch) that sure.
Sascha
--
Pengutronix e.K.
On Fri, Aug 30, 2013 at 01:08:14PM -0300, Fabio Estevam wrote:
> Hi Sascha,
>
> On Thu, Aug 29, 2013 at 3:37 PM, Sascha Hauer wrote:
> > It's not about the module refcount. It's only that a on a drm device
> > which is in use you better do not add/remove compone
;
> + pinctrl-0 = <&pinctrl_pwm0_ch0_active>;
> + pinctrl-1 = <&pinctrl_pwm0_ch0_idle>;
> + pinctrl-2 = <&pinctrl_pwm0_ch1_active>;
> + pinctrl-3 = <&pinctrl_pwm0_ch1_idle>;
> +
oose memory here and in fsl_pwm_disable aswell.
> + pins_state = pinctrl_lookup_state(fpc->pinctrl,
> + statename);
> + /* enable pins to be muxed in and configured */
> + if (!IS_ERR(pins_state)) {
> + ret = pinctrl_select_state(fpc->p
On Mon, Sep 02, 2013 at 01:21:18PM +0530, Sachin Kamat wrote:
> kfree on a NULL pointer is a no-op. Null pointer check is
> not necessary.
>
> Signed-off-by: Sachin Kamat
> Cc: Sascha Hauer
Acked-by: Sascha Hauer
Sascha
> ---
> drivers/dma/imx-dma.c |6 ++
.
>
> Instead of manually keeping the references in the imx-drm driver, let's use
> drm->open_count.
>
> After this patch, lvds panel is functional on a mx6qsabrelite board.
>
> Signed-off-by: Fabio Estevam
> ---
> This one s
; > this was mentioned before.
> >
> Yes.
> Actully this property is located in board level dts file.
> I have added and requested all the channels in SoC level dtsi file,
> and in board level dts file to tell the customer the limitation, I
> think is much safter and better.
W
;
> I think I may move the 'available' field to the PWM driver data struct.
You simply don't need the available field. You don't need to track
whether they are available. If a user enables a pwm which is not routed
out of the SoC (disabled in the iomux) simply nothin
eclared. Should it be static?
>
> Signed-off-by: Fabio Estevam
Acked-by: Sascha Hauer
Sascha
> ---
> drivers/staging/imx-drm/imx-ldb.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/staging/imx-drm/imx-ldb.c
> b/drivers/staging/imx-d
ses like this.
If you misconfigure your iomux then usually unexptected things happen.
That is not the problem of the PWM driver, but the problem of the one
writing the devicetree. The kernel will print a message for conflicting
iomux settings. That should be hint enough to fix it.
Sascha
--
> use of the deprecated APIs.
>
> Cc: Sascha Hauer
> Cc: Anatolij Gustschin
> Signed-off-by: Ulf Hansson
Acked-by: Sascha Hauer
Sascha
> ---
> drivers/mmc/host/mxcmmc.c | 12 ++--
> 1 file changed, 2 insertions(+), 10 deletions(-)
>
> diff --git a/dr
the use of the deprecated APIs.
>
> Cc: Sascha Sommer
> Signed-off-by: Ulf Hansson
> ---
> drivers/mmc/host/sdricoh_cs.c |3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/drivers/mmc/host/sdricoh_cs.c
> b/drivers/mmc/host/sdricoh_cs.c index 50adbd1..b7e3057 10
ch series is based on linux-next and has been tested on Vybrid VF610
> Tower board using device tree.
Looks good to me now. Thanks for fixing.
For the series:
Reviewed-by: Sascha Hauer
Sascha
--
Pengutronix e.K. | |
In
of later. Now you remove the
__init annotations from these probe functions. Wouldn't it be better to
convert the drivers to regular platform_driver_register instead?
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions
On Mon, Sep 23, 2013 at 05:20:18PM +0200, Johan Hovold wrote:
> On Mon, Sep 23, 2013 at 04:50:29PM +0200, Sascha Hauer wrote:
> > On Mon, Sep 23, 2013 at 04:27:25PM +0200, Johan Hovold wrote:
> > > Deferred probing cannot be used with platform_driver_probe as by the
> > &
even when the SoC is in low power modes.
This patch requests both clocks and enables the ipg clock for accessing
registers and the peripheral clock to actually turn on the pwm.
Signed-off-by: Philipp Zabel
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 33
We used to enable/disable the pwm only by switching the
clock on or off. Instead, use the dedicated register bits.
These differ on different SoCs, so introduce a SoC specific
function for this.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 48
The pwm core makes sure that pwm_enable/disable are called only
once. Still keep the enabled state since we will need it in
pwm_config.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 25 +++--
1 file changed, 11 insertions(+), 14 deletions(-)
diff --git a/drivers
From: Philipp Zabel
At the same time remove platform based support. No user for
this driver has made it into mainline so far, so all we break
is out of tree stuff.
Signed-off-by: Philipp Zabel
Signed-off-by: Sascha Hauer
---
Documentation/devicetree/bindings/pwm/imx-pwm.txt | 17
Signed-off-by: Sascha Hauer
---
arch/arm/boot/dts/imx53.dtsi| 14 ++
arch/arm/mach-imx/clk-imx51-imx53.c |4
2 files changed, 18 insertions(+)
diff --git a/arch/arm/boot/dts/imx53.dtsi b/arch/arm/boot/dts/imx53.dtsi
index cd37165..18b9fc3 100644
--- a/arch/arm
To make the code more flexible.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 145 -
1 file changed, 82 insertions(+), 63 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 2a0b353..38270f4 100644
--- a
in low power modes.
Use the always running clock also on i.MX25.
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c |7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index af77045..b234288 100644
--- a/drivers/pwm/pwm
Philipp Zabel (2):
pwm i.MX: add devicetree support
pwm i.MX: fix clock lookup
Sascha Hauer (6):
pwm i.MX: factor out SoC specific functions
pwm i.MX: remove unnecessary if in pwm_[en|dis]able
pwm i.MX: add functions to enable/disable pwm.
pwm i.MX: Use
Signed-off-by: Sascha Hauer
---
drivers/pwm/pwm-imx.c | 12 +---
1 file changed, 1 insertion(+), 11 deletions(-)
diff --git a/drivers/pwm/pwm-imx.c b/drivers/pwm/pwm-imx.c
index 3fc4ae8..a689144 100644
--- a/drivers/pwm/pwm-imx.c
+++ b/drivers/pwm/pwm-imx.c
@@ -270,17 +270,7 @@ static
ill include it in the next
round.
Sascha
--
Pengutronix e.K. | |
Industrial Linux Solutions | http://www.pengutronix.de/ |
Peiner Str. 6-8, 31137 Hildesheim, Germany | Phone: +49-5121-206917-0|
Amtsgericht Hil
1 - 100 of 1212 matches
Mail list logo
