Re: [RFC PATCH 0/2] sched: Load Balancing using Per-entity-Load-tracking

2012-10-18 Thread preeti
would be a good candidate for load-balancing. Latency > would be affected as mentioned earlier. > Exactly.idle_time == spare_cpu_cycles == less cpu_utilization.I hope i am not wrong in drawing this equivalence.if thats the case then the same explanation as above holds good here too. &

Re: [RFC PATCH 0/2] sched: Load Balancing using Per-entity-Load-tracking

2012-10-18 Thread preeti
r very few spare cycles in the last > schedule period would be a good candidate for load-balancing. Latency > would be affected as mentioned earlier. > Exactly.idle_time == spare_cpu_cycles == less cpu_utilization.I hope i am not wrong in drawing this equivalence.if thats the case then the s

Re: [discussion]sched: a rough proposal to enable power saving in scheduler

2012-08-15 Thread preeti
e busy and capable cpus within a small range try to handle the existing load. Regards Preeti -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.

Re: [RFC PATCH 2/2] sched:Pick the apt busy sched group during load balancing

2012-10-11 Thread preeti
>busiest due to the following loads > that it calculates. > > SCHED_GRP1:2048 > SCHED_GRP2:4096 > > Load calculator would probably qualify SCHED_GRP1 as the candidate > for sd->busiest due to the following loads that it calculates > > SCHED_GRP1:3200 > SCHED_GRP2:1156

Re: [RFC PATCH 0/2] sched: Load Balancing using Per-entity-Load-tracking

2012-10-15 Thread preeti
loaded sched groups does not mean too few tasks. Thank you Regards Preeti -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FA

Re: linux-next: comment on pm tree commit

2012-07-09 Thread preeti
eview and build >> testing this went through (the above should produce warnings since they >> are non void returning functions with no return statements). > > Thanks for reporting this, I tried to fix a build issue in the original patch I apologise for not having taken care

Re: [RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-25 Thread Preeti Murthy
stderr, "Error joining thread %d\n", i); exit(1); } } printf("%u records/s\n", (unsigned int) (((double) records_read)/diff_time)); } int main() { start_threads(); return 0; } Regards Preeti U Murthy -- To unsubscribe from this li

Re: [patch 02/16] sched: maintain per-rq runnable averages

2012-10-28 Thread Preeti Murthy
differently if it is >1. Thank you Regards Preeti U Murthy On Thu, Aug 23, 2012 at 7:44 PM, wrote: > From: Ben Segall > > Since runqueues do not have a corresponding sched_entity we instead embed a > sched_avg structure directly. > > Signed-off-by: Ben Segall >

Re: [PATCH] cpuidle: Measure idle state durations with monotonic clock

2012-11-15 Thread Preeti Murthy
can opine about this issue if possible and needed. Reviewed-by: Preeti U Murthy Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majord

Re: [RFC PATCH 2/3] sched: power aware load balance,

2012-11-06 Thread Preeti Murthy
ur patchset to evacuate nearly idle towards nearly busy groups,but by using PJT's metric to make the decision. What do you think? Regards Preeti U Murthy On Tue, Nov 6, 2012 at 6:39 PM, Alex Shi wrote: > This patch enabled the power aware consideration in load balance. > > As mentioned

Re: [RFC PATCH 2/3] sched: power aware load balance,

2012-11-11 Thread Preeti Murthy
Hi Alex I apologise for the delay in replying . On Wed, Nov 7, 2012 at 6:57 PM, Alex Shi wrote: > On 11/07/2012 12:37 PM, Preeti Murthy wrote: >> Hi Alex, >> >> What I am concerned about in this patchset as Peter also >> mentioned in the previous discussion of your ap

[PATCH] RTIC: selinux: ARM64: Move selinux_state to a separate page

2021-02-16 Thread Preeti Nagar
e, we plan to move more security-related kernel assets to this page to enhance protection. Signed-off-by: Preeti Nagar --- The RFC patch reviewed available at: https://lore.kernel.org/linux-security-module/1610099389-28329-1-git-send-email-pna...@codeaurora.org/ --- include/asm-generic/vmlinux.lds.h

Re: [PATCH 1/3] tracing/mm: Don't trace kmem_cache_free on offline cpus

2015-04-29 Thread Preeti Murthy
_ARGS(call_site, ptr) > + TP_ARGS(call_site, ptr), > + > + TP_CONDITION(cpu_online(smp_processor_id())) > ); > > TRACE_EVENT(mm_page_free, Reviewed-by: Preeti U Murthy Regards Preeti U Murthy > -- > 1.9.3 > > -- > To unsubscribe from this list: s

Re: [PATCH 2/3] tracing/mm: Don't trace mm_page_free on offline cpus

2015-04-29 Thread Preeti Murthy
VENT(mm_page_free, > +TRACE_EVENT_CONDITION(mm_page_free, > > TP_PROTO(struct page *page, unsigned int order), > > TP_ARGS(page, order), > > + TP_CONDITION(cpu_online(smp_processor_id())), > + > TP_STRUCT__entry( > __field(uns

Re: [PATCH 2/3] tracing/mm: Don't trace mm_page_free on offline cpus

2015-04-29 Thread Preeti Murthy
On Wed, Apr 29, 2015 at 2:36 PM, Preeti Murthy wrote: > Ccing Paul, > > On Tue, Apr 28, 2015 at 9:21 PM, Shreyas B. Prabhu > wrote: >> Since tracepoints use RCU for protection, they must not be called on >> offline cpus. trace_mm_page_free can be called on an offline

Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus

2015-04-29 Thread Preeti Murthy
__field(int,migratetype ) > + ), > + > + TP_fast_assign( > + __entry->pfn= page ? page_to_pfn(page) : -1UL; > + __entry->order = order; > + __entry->migratetype= m

Re: [PATCH 3/3] tracing/mm: Don't trace mm_page_pcpu_drain on offline cpus

2015-04-29 Thread Preeti Murthy
>> Lets do this. Push the current changes as is, and when I get around to >> adding a DEFINE_EVENT_PRINT_CONDITION(), we can modify that code to use >> it. >> > Okay, sure. Looks good then. Reviewed-by: Preeti U Murthy > > Thanks, > Shreyas > -- To unsu

[RFC PATCH] selinux: ARM64: Move selinux_state to a separate page

2021-01-08 Thread Preeti Nagar
s and comments on the idea and the changes in the patch. Signed-off-by: Preeti Nagar --- include/asm-generic/vmlinux.lds.h | 10 ++ include/linux/init.h | 4 security/Kconfig | 10 ++ security/selinux/hooks.c | 4 4 files change

[RFC PATCH v2] selinux: security: Move selinux_state to a separate page

2021-01-08 Thread Preeti Nagar
s and comments on the idea and the changes in the patch. Signed-off-by: Preeti Nagar --- include/asm-generic/vmlinux.lds.h | 10 ++ include/linux/init.h | 4 security/Kconfig | 10 ++ security/selinux/hooks.c | 4 4 files change

Re: [PATCH 1/4] sched/rt: Sum number of all children tasks in hierarhy at rt_nr_running

2014-03-18 Thread Preeti Murthy
for every rq in the hierarchy. But you would never dequeue a sched_entity if it has more than 1 task in it. The granularity of enqueue and dequeue of sched_entities is one task at a time. You can extend this to enqueue and dequeue of a sched_entity only if it has just one task in its queue. Regards

Re: [PATCH 4/4] sched: Revert commit 4c6c4e38c4e9

2014-03-19 Thread Preeti Murthy
On Sat, Mar 15, 2014 at 3:45 AM, Kirill Tkhai wrote: > This reverts commit 4c6c4e38c4e9 [sched/core: Fix endless loop in > pick_next_task()], which is not necessary after [sched/rt: Substract number > of tasks of throttled queues from rq->nr_running] Reviewed-by: Preeti U Murthy &g

Re: [PATCH] sched: Calculate effective load even if local weight is 0

2014-01-12 Thread Preeti Murthy
below restored check will be relevant. Without the below check the difference in the loads of the wake affine CPU and the prev_cpu can get messed up. Thanks Regards Preeti U Murthy > task_numa_compare since commit fb13c7ee (sched/numa: Use a system-wide > search to find swap/migrati

Re: [Query]: hrtimers: why don't we consider hrtimers in get_next_timer_interrupt()

2014-04-23 Thread Preeti Murthy
the hrtimer list since its a part and parcel of the timer wheel events. Regards Preeti U Murthy > > When hres_active isn't set, we run hrtimer handlers from timer > handlers, which means that timers would be sufficient in finding > the next event and we don't need to check fo

Re: [PATCH] sched: Do not stop cpu in set_cpus_allowed_ptr() if task is not running

2014-09-15 Thread Preeti Murthy
Hi Kirill, Which tree is this patch based on? __migrate_task() does a double_rq_lock/unlock() today in mainline, doesn't it? I don't however see that in your patch. Regards Preeti U Murthy On Fri, Sep 12, 2014 at 4:33 PM, Kirill Tkhai wrote: > > If a task is queued but not runn

Re: [PATCH 1/3] sched, balancing: Update rq->max_idle_balance_cost whenever newidle balance is attempted

2014-04-27 Thread Preeti Murthy
uldn't it be: if (time_after(jiffies, this_rq->next_balance) || time_after(this_rq->next_balance, next_balance)) this_rq->next_balance = next_balance; Besides this: Reviewed-by: Preeti U Murthy Regards Preeti U Murthy On Sat, Apr 26, 2014 at 1:24 AM, Jason L

Re: [PATCH 5/6] sched: remove remaining power to the CPU

2014-05-16 Thread Preeti Murthy
Hi Nicolas, You might want to change the subject. s/sched: remove remaining power to the CPU/ sched: remove remaining usage of cpu *power* . The subject has to explicitly specify in some way that it is a change made to the terminology. Regards Preeti U Murthy On Thu, May 15, 2014 at 2:27 AM

Re: [PATCH] sched: fix exec_start/task_hot on migrated tasks

2014-05-16 Thread Preeti Murthy
sk of the destination rq during migration be better? This would be the closest we could come to estimating the amount of time the task has run on this new cpu while deciding task_hot or not no? Regards Preeti U Murthy > > Thanks! -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT Pull] timer fixes for 3.14

2014-02-17 Thread Preeti Murthy
CAST_ENTER again, the pending mask is cleared and hence should not trigger a WARN_ON(). Thanks Regards Preeti U Murthy On Sun, Feb 16, 2014 at 12:51 AM, Thomas Gleixner wrote: > Linus, > > please pull the latest timers-urgent-for-linus git tree from: > >git://git.kernel.org/

Re: [PATCH RFC/TEST] sched: make sync affine wakeups work

2014-05-04 Thread Preeti Murthy
on a different NUMA node. Looks to me that the problem lies here and not in the wake_affine() and select_idle_siblings(). Regards Preeti U Murthy > > -- > All rights reversed > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a mess

Re: [PATCH 1/2] nohz: use seqlock to avoid race on idle time stats

2014-03-24 Thread Preeti Murthy
for my understanding. Thanks! Regards Preeti U Murthy On 3/24/14, Hidetoshi Seto wrote: > + * Known bug: Return value is not monotonic in case if @last_update_time > + * is NULL and therefore update is not performed. Because it includes > + * cputime which is not determined idle or i

Re: [RFC PATCH 0/2] sched: proposal for idlestat scheduler benchmarking tool

2014-03-25 Thread Preeti Murthy
given duration will be of use. Having said that, a tool that gives the running power efficiency image of my system would be more useful in the long run. Regards Preeti U Murthy On Tue, Mar 25, 2014 at 1:35 AM, Zoran Markovic wrote: > Conclusions from Energy Aware Scheduling sessions at the lat

Re: [Query]: tick-sched: why don't we stop tick when we are running idle task?

2014-04-14 Thread Preeti Murthy
tick_sched_timer dies along with the hotplugged out CPU since there is no need for it any more. Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.

Re: [RESEND PATCH V5 0/8] remove cpu_load idx

2014-05-06 Thread Preeti Murthy
d update it to reflect the right cpu load average? Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please rea

Re: Is it ok for deferrable timer wakeup the idle cpu?

2014-01-28 Thread Preeti Murthy
t domain which does not seem like the right thing to do. Having said the above, the fix that Viresh has proposed along with the nohz_full condition that Frederick added looks to solve this problem. But just a thought on if there is scope to improve this part of the cpufreq code. What do you all thin

Re: [GIT PULL timers] Timer-wheel bandaids^Wcommits

2014-01-29 Thread Preeti Murthy
well be *non-deferrable* timers in the list" s/non-deferrable/deferrable. Thanks Regards Preeti U Murthy On Thu, Jan 30, 2014 at 5:09 AM, Paul E. McKenney wrote: > Hello, Ingo, > > This pull request contains latency bandaids^Woptimizations to the > timer-wheel code that are u

Re: [RFC PATCH 3/3] idle: store the idle state index in the struct rq

2014-01-31 Thread Preeti Murthy
e idle states in the higher indexed states although it should have halted if the idle states' were ordered according to their target residency.. The same holds for exit_latency. Hence I think this patch would make sense only with additional information like exit_latency or target_residency is

Re: [Update][PATCH 2/2] clocksource: Make clocksource register functions void

2014-02-10 Thread Preeti Murthy
Hi Yijing, For the powerpc part: Acked-by: Preeti U Murthy On Mon, Feb 10, 2014 at 7:28 AM, Yijing Wang wrote: > Currently, clocksource_register() and __clocksource_register_scale() > functions always return 0, it's pointless, make functions void. > And remove the dead code

Re: [PATCH V2 2/3] sched: Fix race in idle_balance()

2014-02-10 Thread Preeti Murthy
_mask right? Any other case would trigger load balancing on the same cpu, but we are preempt_disabled and interrupt disabled at this point. Thanks Regards Preeti U Murthy On Fri, Feb 7, 2014 at 4:40 AM, Daniel Lezcano wrote: > The scheduler main function 'schedule()' checks if there

Re: [PATCH V2 3/3] sched: Move idle_stamp up to the core

2014-02-10 Thread Preeti Murthy
ance() as idle > time. Should not this be "such that we *do not* measure the duration of idle_balance() as idle time?" Thanks Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH V2 1/5] sched: idle: cpuidle: Check the latency req before idle

2014-10-27 Thread Preeti Murthy
in addition to your check on the latency_req == 0. If not, you can fall through to the regular path of calling into the cpuidle driver. The scheduler can query the cpuidle_driver structure anyway. What do you think? Regards Preeti U Murthy -- To unsubscribe from this list: send the line

Re: [PATCH 2/5] sched: idle: Get the next timer event and pass it the cpuidle framework

2014-10-27 Thread Preeti Murthy
ou might want to include this change in the previous patch itself. > + * @next_timer_event: the duration until the timer expires > * > * Returns the index of the idle state. > */ Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel"

Re: [PATCH V2 3/5] cpuidle: idle: menu: Don't reflect when a state selection failed

2014-10-28 Thread Preeti Murthy
- data->last_state_idx = index; > - if (index >= 0) > - data->needs_update = 1; > + data->needs_update = 1; Why is the last_state_idx not getting updated ? Regards Preeti U Murthy -- To unsubscribe from this list: send the line "u

Re: [nohz] 2a16fc93d2c: kernel lockup on idle injection

2014-12-17 Thread Preeti Murthy
Hi Thomas, On Tue, Dec 16, 2014 at 6:19 PM, Thomas Gleixner wrote: > On Tue, 16 Dec 2014, Preeti U Murthy wrote: >> As far as I can see, the primary purpose of tick_nohz_irq_enter()/exit() >> paths was to take care of *tick stopped* cases. >> >> Before handling inter

Re: [RFC PATCH 0/5] enable runnable load avg in load balance

2012-11-26 Thread Preeti U Murthy
The differences between the above two scenarios include: 1.Reduced latency for Task1 in CASE2,which is the right task to be moved in the above scenario. 2.Even though in the former case CPU2 is relieved of one task,its of no use if Task3 is going to sleep most of the time.This might result in

Re: [RFC PATCH 0/5] enable runnable load avg in load balance

2012-11-26 Thread Preeti U Murthy
Hi, On 11/27/2012 11:44 AM, Alex Shi wrote: > On 11/27/2012 11:08 AM, Preeti U Murthy wrote: >> Hi everyone, >> >> On 11/27/2012 12:33 AM, Benjamin Segall wrote: >>> So, I've been trying out using the runnable averages for load balance in >>> a few ways,

Re: [patch v5 14/15] sched: power aware load balance

2013-03-19 Thread Preeti U Murthy
er even though they degrade with time and sgs->utils accounts for them. Therefore, for core1 and core2, the sgs->utils will be slightly above 100 and the above condition will fail, thus failing them as candidates for group_leader,since threshold_util will be 200. This phenomenon is seen for bal

Re: [patch v5 14/15] sched: power aware load balance

2013-03-21 Thread Preeti U Murthy
Hi Alex, On 03/21/2013 01:13 PM, Alex Shi wrote: > On 03/20/2013 12:57 PM, Preeti U Murthy wrote: >> Neither core will be able to pull the task from the other to consolidate >> the load because the rq->util of t2 and t4, on which no process is >> running, continue to show

Re: [patch v5 14/15] sched: power aware load balance

2013-03-21 Thread Preeti U Murthy
On 03/21/2013 02:57 PM, Alex Shi wrote: > On 03/21/2013 04:41 PM, Preeti U Murthy wrote: >>>> >> Yes, I did find this behaviour on a 2 socket, 8 core machine very >> consistently. >> >> rq->util cannot go to 0, after it has begun accumulating load right?

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-02 Thread Preeti U Murthy
ription. Ok,take the example of a runqueue with 2 task groups,each with 10 tasks.Same as your previous example. Can you explain how your patch ensures that all 20 tasks get to run atleast once in a sched_period? Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 4/5] sched: don't consider upper se in sched_slice()

2013-04-03 Thread Preeti U Murthy
Hi Joonsoo, On 04/04/2013 06:12 AM, Joonsoo Kim wrote: > Hello, Preeti. > > So, how about extending a sched_period with rq->nr_running, instead of > cfs_rq->nr_running? It is my quick thought and I think that we can ensure > to run atleast once in this extending sched_per

Re: [patch v5 09/15] sched: add power aware scheduling in fork/exec/wake

2013-02-24 Thread Preeti U Murthy
up task.The first time the forked task gets a chance to update the load itself,it needs to reflect full utilization.In __update_entity_runnable_avg both runnable_avg_period and runnable_avg_sum get equally incremented for a forked task since it is runnable.Hence where is the chance for the l

Re: [patch v5 02/15] sched: set initial load avg of new forked task

2013-02-24 Thread Preeti U Murthy
s and migrated wake ups have load updates to do.Forked tasks just got created,they have no load to "update" but only to "create". This I feel is rightly done in sched_fork by this patch. So ideally I dont think we should have any comment here.It does not sound relevant. >*

Re: [patch v5 09/15] sched: add power aware scheduling in fork/exec/wake

2013-02-24 Thread Preeti U Murthy
he utilisation is accumulated faster by making the update window smaller. 2.Balance on nr->running only if you detect burst wakeups. Alex, you had released a patch earlier which could detect this right? Instead of balancing on nr_running all the time, why not balance on it only if burst wakeups are detected. By doing so you ensure that nr_running as a metric for load balancing is used when it is right to do so and the reason to use it also gets well documented. Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch v5 02/15] sched: set initial load avg of new forked task

2013-02-27 Thread Preeti U Murthy
ed tasks. >> enqueue_task_fair->update_entity_load_avg() during the second >> iteration.But __update_entity_load_avg() in update_entity_load_avg() >> > > When goes 'enqueue_task_fair->update_entity_load_avg()' during the > second iteration. the se is changed. > That

Re: [patch v4 07/18] sched: set initial load avg of new forked task

2013-02-19 Thread Preeti U Murthy
se, 0); } - /* -* set the initial load avg of new task same as its load -* in order to avoid brust fork make few cpu too heavier -*/ - if (flags & ENQUEUE_NEWTASK) - se->avg.load_avg_contrib = se->load.weight; cfs_rq->

Re: [patch v5 06/15] sched: log the cpu utilization at rq

2013-02-20 Thread Preeti U Murthy
heduler and the usage of per entity load tracking can be done without considering the real time tasks? Regards Preeti U Murthy > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch v5 06/15] sched: log the cpu utilization at rq

2013-02-20 Thread Preeti U Murthy
with what is the right metric to use here. Refer to this discussion:https://lkml.org/lkml/2012/10/29/448 Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

[RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-25 Thread Preeti U Murthy
With_Patchset Without_patchset - Average_number_of_migrations 046 Average_number_of_records/s 9,71,114 9,45,158 With more memory intensive workloads, a higher difference in the number of migrations is seen without any

[RFC PATCH 04/13] sched:Decide group_imb using PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters for deciding a sched group's imbalance status which are calculated using the per entity load tracking are used. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/kernel/

[RFC PATCH 06/13] sched: Changing find_busiest_queue to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters which decide the busiest cpu in the chosen sched group calculated using PJT's metric are used Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 13 + 1 file changed, 9 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/

[RFC PATCH 08/13] sched: Some miscallaneous changes in load_balance

2012-10-25 Thread Preeti U Murthy
Modify certain decisions in load_balance to use the imbalance amount as calculated by the PJT's metric. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c |5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index bd

[RFC PATCH 11/13] sched: Modify find_idlest_group to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters introduced to perform this function which are calculated using PJT's metrics and its helpers. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 14 ++ 1 file changed, 10 insertions(+), 4 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/

[RFC PATCH 02/13] sched:Pick the apt busy sched group during load balancing

2012-10-25 Thread Preeti U Murthy
e a balance between the loads of the group and the number of tasks running on the group to decide the busiest group in the sched_domain. This means we will need to use the PJT's metrics but with an additional constraint. Signed-off-by: Preeti U Murthy --- kernel/sch

[RFC PATCH 10/13] sched: Modify fix_small_imbalance to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters which aid in taking the decisions in fix_small_imbalance which are calculated using PJT's metric are used. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 54 +++ 1 file changed, 33 insertions(+), 21 dele

[RFC PATCH 09/13] sched: Modify check_asym_packing to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Make appropriate modifications in check_asym_packing to reflect PJT's metric. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c |2 ++ 1 file changed, 2 insertions(+) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index 68a6b1d..3b18f5f 100644 --- a/kernel/sched/fair.c

[RFC PATCH 12/13] sched: Modify find_idlest_cpu to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters introduced to perform this function which are calculated using PJT's metrics and its helpers. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c |8 +--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/f

[RFC PATCH 13/13] sched: Modifying wake_affine to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters introduced to perform this function which are calculated using PJT's metrics and its helpers. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 34 +++--- 1 file changed, 15 insertions(+), 19 deletions(-) diff --git a/kernel/

[RFC PATCH 07/13] sched: Change move_tasks to use PJT's metric

2012-10-25 Thread Preeti U Murthy
Make decisions based on PJT's metrics and the dependent metrics about which tasks to move to reduce the imbalance. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/

[RFC PATCH 03/13] sched:Decide whether there be transfer of loads based on the PJT's metric

2012-10-25 Thread Preeti U Murthy
rent sched group is capable of pulling tasks upon itself. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 33 + 1 file changed, 25 insertions(+), 8 deletions(-) diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c index aafa3c1..67a916d 100644 --- a/ke

[RFC PATCH 05/13] sched:Calculate imbalance using PJT's metric

2012-10-25 Thread Preeti U Murthy
Additional parameters which decide the amount of imbalance in the sched domain calculated using PJT's metric are used. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 36 +++- 1 file changed, 23 insertions(+), 13 deletions(-) diff --git a/kernel/

[RFC PATCH 01/13] sched:Prevent movement of short running tasks during load balancing

2012-10-25 Thread Preeti U Murthy
eshold.The call should be taken if the tasks can afford to be throttled. This is why an additional metric has been included,which can determine how long we can tolerate tasks not being moved even if the load is low. Signed-off-by: Preeti U Murthy --- kernel/sched/fair.c | 16 ++

Re: [RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-25 Thread Preeti U Murthy
ter *busy * gp. *End Result: Better candidates for lb* Rest of the patches: now that we have our busy sched group,let us load balance with the aid of the new metric. *End Result: Hopefully a more sensible movement of loads* This is how I build the picture. Regards Preeti -- To unsubscribe from t

Re: [RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-25 Thread Preeti U Murthy
ffected although there is less load on GP1.If yes it is a better *busy * gp. *End Result: Better candidates for lb* Rest of the patches: now that we have our busy sched group,let us load balance with the aid of the new metric. *End Result: Hopefully a more sensible movement of loads

Re: [RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-26 Thread Preeti U Murthy
On 10/26/2012 05:59 PM, Peter Zijlstra wrote: > On Thu, 2012-10-25 at 23:42 +0530, Preeti U Murthy wrote: > firstly, cfs_rq is the wrong place for a per-cpu load measure, secondly > why add another load field instead of fixing the one we have? Hmm..,rq->load.weight is the place. >

Re: [RFC PATCH 00/13] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-10-26 Thread Preeti U Murthy
rmance of > those. > > Having two parallel load metrics is really not something that we > should tolerate for too long. > > Thanks, > > Ingo > Right Ingo.I will incorporate this approach and post out very soon. Thank you Regards Preeti -- To unsubsc

Re: [RFC][PATCH 0/9] sched: Power scheduler design proposal

2013-07-11 Thread Preeti U Murthy
Secondly, I think we should spend more time on when to make a call to the frequency driver in your patchset regarding the change in the frequency of the CPU, the scheduler wishes to request. The reason being, the whole effort of integrating the knowledge of cpu frequency statistics into the sched

Re: [PATCH 1/2] tick: broadcast: Deny per-cpu clockevents from being broadcast sources

2013-09-13 Thread Preeti U Murthy
Hi Soren, On 09/13/2013 09:53 PM, Sören Brinkmann wrote: > Hi Preeti, > Thanks for the explanation but now I'm a little confused. That's a lot of > details and I'm lacking the in depth knowledge to fully understand > everything. > > Is it correct to say, that

[PATCH V3 0/6] cpuidle/ppc: Enable broadcast support for deep idle states

2013-09-10 Thread Preeti U Murthy
vatsa S. Bhat and Vaidyanathan Srinivasan for all their comments and suggestions so far. --- Preeti U Murthy (4): cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines cpuidle/ppc: Add basic infrastructure to support the broadcast framework on ppc c

[PATCH V3 1/6] powerpc: Free up the IPI message slot of ipi call function (PPC_MSG_CALL_FUNC)

2013-09-10 Thread Preeti U Murthy
available). So, implement the functionality of PPC_MSG_CALL_FUNC using PPC_MSG_CALL_FUNC_SINGLE itself and release its IPI message slot, so that it can be used for something else in the future, if desired. Signed-off-by: Srivatsa S. Bhat Signed-off-by: Preeti U Murthy --- arch/powerpc/include

[PATCH V3 3/6] cpuidle/ppc: Split timer_interrupt() into timer handling and interrupt handling routines

2013-09-10 Thread Preeti U Murthy
routines performed during regular interrupt handling and __timer_interrupt(), which takes care of running local timers and collecting time related stats. Now on a broadcast ipi, call __timer_interrupt(). Signed-off-by: Preeti U Murthy --- arch/powerpc/kernel/time.c | 69

[PATCH V3 2/6] powerpc: Implement broadcast timer interrupt as an IPI message

2013-09-10 Thread Preeti U Murthy
sa S. Bhat [Changelog modified by pre...@linux.vnet.ibm.com] Signed-off-by: Preeti U Murthy --- arch/powerpc/include/asm/smp.h |3 ++- arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/smp.c | 19 +++ arch/powerpc/kernel/time.c

[PATCH V3 4/6] cpuidle/ppc: Add basic infrastructure to support the broadcast framework on ppc

2013-09-10 Thread Preeti U Murthy
being woken up from the broadcast ipi, set the decrementers_next_tb to now before calling __timer_interrupt(). Signed-off-by: Preeti U Murthy --- arch/powerpc/Kconfig|1 + arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/time.c | 69 +++

[PATCH V3 5/6] cpuidle/ppc: Introduce the deep idle state in which the local timers stop

2013-09-10 Thread Preeti U Murthy
above cycle repeats. Protect the region of nomination,de-nomination and check for existence of broadcast cpu with a lock to ensure synchronization between them. [1] tick_handle_oneshot_broadcast() or tick_handle_periodic_broadcast(). Signed-off-by: Preeti U Murthy --- arch/powerpc/include/asm/t

[PATCH V3 6/6] cpuidle/ppc: Nominate new broadcast cpu on hotplug of the old

2013-09-10 Thread Preeti U Murthy
was about to fire on it. Therefore the newly nominated broadcast cpu should set the broadcast hrtimer on itself to expire immediately so as to not miss wakeups under such scenarios. Signed-off-by: Preeti U Murthy --- arch/powerpc/include/asm/time.h |1 + arch/powerpc/kernel/time.c

Re: [PATCH 1/2] tick: broadcast: Deny per-cpu clockevents from being broadcast sources

2013-09-13 Thread Preeti U Murthy
Hi Soren, On 09/13/2013 03:50 PM, Preeti Murthy wrote: > Hi, > > So the patch that Daniel points out http://lwn.net/Articles/566270/ , > enables broadcast functionality > without using an external global clock device. It uses one of the per cpu > clock devices to en

Re: [RFC v2 PATCH 2.1] sched: Use Per-Entity-Load-Tracking metric for load balancing

2012-12-03 Thread Preeti U Murthy
sched: Use Per-Entity-Load-Tracking metric for load balancing From: Preeti U Murthy Currently the load balancer weighs a task based upon its priority,and this weight consequently gets added up to the weight of the run queue that it is on.It is this weight of the runqueue that sums up to a

Re: [RFC v2 PATCH 0/2] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-12-04 Thread Preeti U Murthy
printf("%u records/s\n", (unsigned int) (((double) records_read)/diff_time)); } int main() { start_threads(); return 0; } END WORKLOAD Regards Preeti U Murthy -- To unsubscribe from this list: sen

Re: weakness of runnable load tracking?

2012-12-05 Thread Preeti U Murthy
good idea. It is true that we need to bring in nr_running somewhere.Let me now go through your suggestions on where to include nr_running and get back on this.I had planned on including nr_running while selecting the busy group in update_sd_lb_stats,but select_task_rq_fair is yet another place to do t

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
} > > /* Now try balancing at a lower domain level of new_cpu */ > cpu = new_cpu; > Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 02/18] sched: fix find_idlest_group mess logical

2012-12-10 Thread Preeti U Murthy
to, at that level of sched domain.Which is fair enough. So now the question is under such a circumstance which is the idlest group so far.It is the group containing this_cpu,i.e.this_group.After this sd->child is chosen which is nothing but this_group(sd hierarchy moves towards the cpu it belongs

Re: [PATCH 02/18] sched: fix find_idlest_group mess logical

2012-12-10 Thread Preeti U Murthy
Hi Alex, On 12/11/2012 10:59 AM, Alex Shi wrote: > On 12/11/2012 01:08 PM, Preeti U Murthy wrote: >> Hi Alex, >> >> On 12/10/2012 01:52 PM, Alex Shi wrote: >>> There is 4 situations in the function: >>> 1, no task allowed group; >>> so min_load

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-10 Thread Preeti U Murthy
On 12/11/2012 10:58 AM, Alex Shi wrote: > On 12/11/2012 12:23 PM, Preeti U Murthy wrote: >> Hi Alex, >> >> On 12/10/2012 01:52 PM, Alex Shi wrote: >>> It is impossible to miss a task allowed cpu in a eligible group. >> >> The one thing I am concerned

Re: [PATCH 07/18] sched: compute runnable load avg in cpu_load and cpu_avg_load_per_task

2012-12-11 Thread Preeti U Murthy
>cfs.runnable_load_avg / nr_running; rq->cfs.runnable_load_avg is u64 type.you will need to typecast it here also right? how does this division work? because the return type is unsigned long. > > return 0; > } > Regards Preeti U Murthy -- To unsubscribe from this list:

Re: [PATCH 08/18] sched: consider runnable load average in move_tasks

2012-12-11 Thread Preeti U Murthy
= task_h_load(p); > + load = task_h_load_avg(p); > > if (sched_feat(LB_MIN) && load < 16 && > !env->sd->nr_balance_failed) > goto next; > Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 01/18] sched: select_task_rq_fair clean up

2012-12-11 Thread Preeti U Murthy
On 12/11/2012 05:23 PM, Alex Shi wrote: > On 12/11/2012 02:30 PM, Preeti U Murthy wrote: >> On 12/11/2012 10:58 AM, Alex Shi wrote: >>> On 12/11/2012 12:23 PM, Preeti U Murthy wrote: >>>> Hi Alex, >>>> >>>> On 12/10/2012 01:52 PM, Alex Shi wr

Re: [patch 02/16] sched: maintain per-rq runnable averages

2012-11-07 Thread Preeti U Murthy
On 10/29/2012 11:08 PM, Benjamin Segall wrote: > Preeti Murthy writes: > >> Hi Paul, Ben, >> >> A few queries regarding this patch: >> >> 1.What exactly is the significance of introducing sched_avg structure >> for a runqueue? If I have >>un

sched: Consequences of integrating the Per Entity Load Tracking Metric into the Load Balancer

2013-01-01 Thread Preeti U Murthy
ur suggestions.This will greatly help take the right steps here on, in achieving the correct integration. Thank you Regards Preeti U Murthy -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

Re: sched: Consequences of integrating the Per Entity Load Tracking Metric into the Load Balancer

2013-01-03 Thread Preeti U Murthy
Hi Mike, Thank you very much for your feedback.Considering your suggestions,I have posted out a proposed solution to prevent select_idle_sibling() from becoming a disadvantage to normal load balancing,rather aiding it. **This patch is *without* the enablement of the per entity load tracking m

[RFC v2 PATCH 0/2] sched: Integrating Per-entity-load-tracking with the core scheduler

2012-11-15 Thread Preeti U Murthy
r Zijlstra and Ingo Molnar for their valuable feedback on v1 of the RFC which was the foundation for this version. PATCH[1/2] Aims at enabling usage of Per-Entity-Load-Tracking for load balacing PATCH[2/2] The crux of the patchset lies here. --- Preeti U Murthy (2): sched: Revert

[RFC v2 PATCH 1/2] sched: Revert temporary FAIR_GROUP_SCHED dependency for load-tracking

2012-11-15 Thread Preeti U Murthy
Now that we need the per-entity load tracking for load balancing, trivially revert the patch which introduced the FAIR_GROUP_SCHED dependence for load tracking. Signed-off-by: Preeti U Murthy --- include/linux/sched.h |7 +-- kernel/sched/core.c |7 +-- kernel/sched/fair.c

  1   2   3   4   5   6   7   >