[PATCH 2/2] sc16is7xx: Fix for "Unexpected interrupt: 8"

2018-09-12 Thread Phil Elwell
eaded interrupt handler). See: https://github.com/raspberrypi/linux/issues/2529 Signed-off-by: Phil Elwell --- drivers/tty/serial/sc16is7xx.c | 28 1 file changed, 28 insertions(+) diff --git a/drivers/tty/serial/sc16is7xx.c b/drivers/tty/serial/sc16is7xx.c index 47b4115.

RE: [PATCH v4 2/3] pinctrl: renesas: Renesas RZ/N1 pinctrl driver

2018-09-24 Thread Phil Edworthy
Hi Geert, On 24 September 2018 12:59 Geert Uytterhoeven wrote: > On Wed, Sep 19, 2018 at 4:24 PM Phil Edworthy wrote: > > This provides a pinctrl driver for the Renesas RZ/N1 device family. > > > > Based on a patch originally written by Michel Pollet at Renesas. > &

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Phil Reid
get is a different buffer so should be ok. But that raises the question of does it need to be? 'buffer' could be 12 bytes long and just shuffle Z then Y. Do the unused bytes need to be zeroed? or does libiio mask them anyway? -- Regards Phil Reid

Re: [PATCH 2/2] iio: magnetometer: Add driver support for PNI RM3100

2018-09-25 Thread Phil Reid
On 26/09/2018 9:49 AM, Song Qiang wrote: On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote: On 25/09/2018 9:30 PM, Jonathan Cameron wrote: +static irqreturn_t rm3100_trigger_handler(int irq, void *p) +{ + struct iio_poll_func *pf = p; + struct iio_dev *indio_dev = pf

Re: [PATCH v3 3/3] iio: magnetometer: Add driver support for PNI RM3100

2018-10-02 Thread Phil Reid
spi_driver(rm3100_driver); + +MODULE_AUTHOR("Song Qiang "); +MODULE_DESCRIPTION("PNI RM3100 3-axis magnetometer spi driver"); +MODULE_LICENSE("GPL v2"); diff --git a/drivers/iio/magnetometer/rm3100.h b/drivers/iio/magnetometer/rm3100.h new file mode 100644 index 000

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
On 20/09/2018 9:13 PM, Song Qiang wrote: PNI RM3100 magnetometer is a high resolution, large signal immunity magnetometer, composed of 3 single sensors and a processing chip. PNI is currently not in the vendors list, so this is also adding it. In the subject: Isn't the RM3100 a 3axis mag. The

Re: [PATCH] iio: magnetometer: Add support for PNI RM3100 9-axis magnetometer

2018-09-20 Thread Phil Reid
+#define RM_W_REG_START RM_REG_POLL +#define RM_W_REG_END RM_REG_REV_ID +#define RM_R_REG_START RM_REG_POLL +#define RM_R_REG_END RM_REG_HSHAKE +#define RM_V_REG_START RM_REG_MX2 +#define RM_V_REG_END RM_REG_HSHAKE + +/* Built-In Self Test reigister. */ +#define RM_REG_BIST0x33 + +struct rm3100_data { + struct device *dev; + struct regmap *regmap; + struct completion measuring_done; + bool use_interrupt; + + int conversion_time; + + /* To protect consistency of every measurement and sampling +* frequency change operations. +*/ + struct mutex lock; +}; + +extern const struct regmap_access_table rm3100_readable_table; +extern const struct regmap_access_table rm3100_writable_table; +extern const struct regmap_access_table rm3100_volatile_table; + +int rm3100_common_probe(struct device *dev, struct regmap *regmap, int irq); +int rm3100_common_remove(struct device *dev); + +#endif /* RM3100_CORE_H */ -- Regards Phil Reid

[PATCH v5 1/2] clk: Add of_clk_get_by_name_optional() function

2018-08-31 Thread Phil Edworthy
Quite a few drivers get an optional clock, e.g. a clock required to access peripheral's registers that is always enabled on some devices. This function behaves the same as of_clk_get_by_name() except that it will return NULL instead of -ENOENT. Signed-off-by: Phil Edworthy --- v5: - Simpl

[PATCH v5 0/2] clk: Add functions to get optional clocks

2018-08-31 Thread Phil Edworthy
Quite a few drivers get an optional clock, e.g. a bus clock required to access peripheral's registers that is always enabled on some devices. Phil Edworthy (2): clk: Add of_clk_get_by_name_optional() function clk: Add functions to get optional clocks drivers/clk/clk-devres.c

[PATCH v5 2/2] clk: Add functions to get optional clocks

2018-08-31 Thread Phil Edworthy
: Phil Edworthy --- v5: - No changes. v4: - No changes. v3: - No changes. --- drivers/clk/clk-devres.c | 18 -- drivers/clk/clkdev.c | 17 +++-- include/linux/clk.h | 29 + 3 files changed, 60 insertions(+), 4 deletions(-) diff

RE: [PATCH v5 1/2] clk: Add of_clk_get_by_name_optional() function

2018-09-03 Thread Phil Edworthy
Hi Stephen, On 01 September 2018 03:46, Stephen Boyd wrote: > Quoting Phil Edworthy (2018-08-31 07:07:22) > > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index > > 9ab3db8..4adb99e 100644 > > --- a/drivers/clk/clkdev.c > > +++ b/drivers/clk/cl

RE: [PATCH v5 1/2] clk: Add of_clk_get_by_name_optional() function

2018-09-03 Thread Phil Edworthy
Hi Stephen, On 03 September 2018 10:33 Phil Edworthy wrote: > On 01 September 2018 03:46, Stephen Boyd wrote: > > Quoting Phil Edworthy (2018-08-31 07:07:22) > > > diff --git a/drivers/clk/clkdev.c b/drivers/clk/clkdev.c index > > > 9ab3db8..4adb99e 100644 >

Re: [PATCH v4 1/2] power: supply: sbs-battery: don't assume MANUFACTURER_DATA formats

2018-06-10 Thread Phil Reid
. [1] http://www.ti.com/lit/er/sluu265a/sluu265a.pdf Signed-off-by: Brian Norris Reviewed-by: Guenter Roeck Acked-by: Rhyland Klein Reviewed-by: Phil Reid --- v2: * don't stub out POWER_SUPPLY_PROP_PRESENT from sbs_data[] * use if/else instead of switch/case v3: * pull 'retur

Re: [PATCH] i2c: octeon: Prevent error message on bus error

2018-03-02 Thread Phil Pokorny
current? Similar set of issues there. Multiple people have now tested them and reported they resolve issues with IPMI SSIF on ThunderX2 platforms. Thanks, Phil P. -- Philip Pokorny, RHCE Chief Technology Officer PENGUIN COMPUTING, Inc www.penguincomputing.com Changing the world through technical innovation

[PATCH] irqchip: Add support for Renesas RZ/N1 GPIO interrupt multiplexer

2018-04-23 Thread Phil Edworthy
d, so there is nothing to do in this driver when an interrupt is received, other than tell the corresponding GPIO block. Signed-off-by: Phil Edworthy --- .../interrupt-controller/renesas,rzn1-mux.txt | 85 ++ drivers/irqchip/Kconfig| 10 ++ drivers/ir

Re: [PATCHv2 4/4] gpio: Remove VLA from stmpe driver

2018-03-18 Thread Phil Reid
rq(int irq, void *dev) } } + kfree(status); return IRQ_HANDLED; } -- Regards Phil Reid

Re: [RESEND PATCH v1 6/6] i2c: i2c-stm32f7: Implement I2C recovery mechanism

2018-03-19 Thread Phil Reid
ct platform_device *pdev) { struct device_node *np = pdev->dev.of_node; @@ -1879,6 +1904,7 @@ static int stm32f7_i2c_probe(struct platform_device *pdev) adap->algo = &stm32f7_i2c_algo; adap->dev.parent = &pdev->dev; adap->dev.of_node = pdev->dev.of_node; + adap->bus_recovery_info = &stm32f7_i2c_recovery_info; init_completion(&i2c_dev->complete); -- Regards Phil

[PATCH v3 0/3] lan78xx: Read configuration from Device Tree

2018-04-19 Thread Phil Elwell
reading the MAC address and LED modes from Device Tree. v3: - Move LED setting into PHY driver. v2: - Use eth_platform_get_mac_address. - Support up to 4 LEDs, and move LED mode constants into dt-bindings header. - Improve bindings document. - Remove EEE support. Phil Elwell (3): lan78xx: Read MAC

[PATCH v3 3/3] dt-bindings: Document the DT bindings for lan78xx

2018-04-19 Thread Phil Elwell
a bindings file. Signed-off-by: Phil Elwell --- .../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++ MAINTAINERS| 1 + 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip

[PATCH v3 2/3] lan78xx: Read LED states from Device Tree

2018-04-19 Thread Phil Elwell
available. Signed-off-by: Phil Elwell --- MAINTAINERS | 1 + drivers/net/phy/microchip.c | 25 ++ drivers/net/usb/lan78xx.c | 32 - include/dt-bindings/net/microchip-lan7

[PATCH v3 0/3] lan78xx: Read configuration from Device Tree

2018-04-19 Thread Phil Elwell
reading the MAC address and LED modes from Device Tree. v3: - Move LED setting into PHY driver. v2: - Use eth_platform_get_mac_address. - Support up to 4 LEDs, and move LED mode constants into dt-bindings header. - Improve bindings document. - Remove EEE support. Phil Elwell (3): lan78xx: Read MAC

[PATCH v3 1/3] lan78xx: Read MAC address from DT if present

2018-04-19 Thread Phil Elwell
There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell

[PATCH resend v3 1/3] lan78xx: Read MAC address from DT if present

2018-04-19 Thread Phil Elwell
There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell

[PATCH resend v3 3/3] dt-bindings: Document the DT bindings for lan78xx

2018-04-19 Thread Phil Elwell
a bindings file. Signed-off-by: Phil Elwell --- .../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++ MAINTAINERS| 1 + 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip

[PATCH resend v3 0/3] lan78xx: Read configuration from Device Tree

2018-04-19 Thread Phil Elwell
EEE support. Phil Elwell (3): lan78xx: Read MAC address from DT if present lan78xx: Read LED states from Device Tree dt-bindings: Document the DT bindings for lan78xx .../devicetree/bindings/net/microchip,lan78xx.txt | 54 MAINTAINERS

[PATCH resend v3 2/3] lan78xx: Read LED states from Device Tree

2018-04-19 Thread Phil Elwell
available. Signed-off-by: Phil Elwell --- MAINTAINERS | 1 + drivers/net/phy/microchip.c | 25 ++ drivers/net/usb/lan78xx.c | 32 - include/dt-bindings/net/microchip-lan7

[PATCH v4 1/3] lan78xx: Read MAC address from DT if present

2018-04-19 Thread Phil Elwell
There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell

[PATCH v4 3/3] dt-bindings: Document the DT bindings for lan78xx

2018-04-19 Thread Phil Elwell
a bindings file. Signed-off-by: Phil Elwell Reviewed-by: Andrew Lunn --- .../devicetree/bindings/net/microchip,lan78xx.txt | 54 ++ MAINTAINERS| 1 + 2 files changed, 55 insertions(+) create mode 100644 Documentation/devicetree

[PATCH v4 0/3] lan78xx: Read configuration from Device Tree

2018-04-19 Thread Phil Elwell
. Phil Elwell (3): lan78xx: Read MAC address from DT if present lan78xx: Read LED states from Device Tree dt-bindings: Document the DT bindings for lan78xx .../devicetree/bindings/net/microchip,lan78xx.txt | 54 MAINTAINERS| 2

[PATCH v4 2/3] lan78xx: Read LED states from Device Tree

2018-04-19 Thread Phil Elwell
available. Signed-off-by: Phil Elwell Reviewed-by: Andrew Lunn --- MAINTAINERS | 1 + drivers/net/phy/microchip.c | 25 ++ drivers/net/usb/lan78xx.c | 32 - include/dt-bindings/net

RE: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-13 Thread Phil Edworthy
Hi Hoan, On 13 April 2018 17:37 Hoan Tran wrote: > On Fri, Apr 13, 2018 at 1:51 AM, Phil Edworthy wrote: > > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > > per GPIO in port A, but the driver currently only supports 1 interrupt. > > See the DesignWare

Re: [PATCHv4] gpio: Remove VLA from gpiolib

2018-04-14 Thread Phil Reid
On 14/04/2018 05:10, Laura Abbott wrote: On 04/12/2018 05:39 PM, Phil Reid wrote: On 12/04/2018 16:38, Linus Walleij wrote: On Wed, Apr 11, 2018 at 3:03 AM, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
} -static inline void gpiod_set_raw_array_value_cansleep(unsigned int array_size, +static inline int gpiod_set_raw_array_value_cansleep(unsigned int array_size, struct gpio_desc **desc_array, int *value_array) { /* GPIO can never have been

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
G'day Laura, One more comment. On 16/04/2018 12:41, Phil Reid wrote: G'day Laura, On 14/04/2018 05:24, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla. Using a kmalloc array is the easy

Re: [PATCHv5] gpio: Remove VLA from gpiolib

2018-04-15 Thread Phil Reid
On 16/04/2018 13:19, Phil Reid wrote: G'day Laura, One more comment. On 16/04/2018 12:41, Phil Reid wrote: G'day Laura, On 14/04/2018 05:24, Laura Abbott wrote: The new challenge is to remove VLAs from the kernel (see https://lkml.org/lkml/2018/3/7/621) to eventually turn on -Wvla

Re: [PATCH 4/4] dt-bindings: Document the DT bindings for lan78xx

2018-04-17 Thread Phil Elwell
On 16/04/2018 20:22, Rob Herring wrote: > On Thu, Apr 12, 2018 at 02:55:36PM +0100, Phil Elwell wrote: >> The Microchip LAN78XX family of devices are Ethernet controllers with >> a USB interface. Despite being discoverable devices it can be useful to >> be able to configure

RE: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-17 Thread Phil Edworthy
Hi Rob, On 16 April 2018 21:03 Rob Herring wrote: > On Fri, Apr 13, 2018 at 09:51:12AM +0100, Phil Edworthy wrote: > > The DesignWare GPIO IP can be configured for either 1 interrupt or 1 > > per GPIO in port A, but the driver currently only supports 1 interrupt. > &g

[PATCH v4] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-17 Thread Phil Edworthy
s, it will get as many interrupts as specified in the DT 'interrupts' property. It doesn't do anything clever with the different interrupts, it just calls the same handler used for single interrupt hardware. Signed-off-by: Phil Edworthy --- One point to mention is that I have made

RE: [PATCH v5] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-09 Thread Phil Edworthy
Hi Andy, On 05 May 2018 11:49 Andy Shevchenko wrote: > On Thu, Apr 26, 2018 at 7:19 PM, Phil Edworthy wrote: > > Sotty fo a late response. Consider follow up fixes for below. > > > if (!pp->irq_shared) { > > + int i; > > + > > +

[PATCH] USB: rndis: Fix for handling garbled messages

2018-05-10 Thread Phil Edworthy
From: Michel Pollet A message can be forged to crash the stack; here we make sure we don't completely break the system if this occurs Signed-off-by: Michel Pollet --- drivers/usb/gadget/function/rndis.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/drivers/usb/gadget/function/rndis.c

[PATCH] serial: 8250_dw: Fix runtime PM handling

2018-05-10 Thread Phil Edworthy
When using kgdb, you get an abort when accessing the UART registers. This is because the driver has already entered runtime PM and so turned off the bus clock needed to access the registers. To fix this, set the capability indicating Runtime PM is active while idle. Signed-off-by: Phil Edworthy

[PATCH v6] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-05-11 Thread Phil Edworthy
s, it will get as many interrupts as specified in the DT 'interrupts' property. It doesn't do anything clever with the different interrupts, it just calls the same handler used for single interrupt hardware. Signed-off-by: Phil Edworthy Reviewed-by: Rob Herring Acked-by: Lee Jones

[PATCH v2 0/3] lan78xx: Read configuration from Device Tree

2018-04-18 Thread Phil Elwell
reading the MAC address and LED modes from Device Tree. v2: - Use eth_platform_get_mac_address. - Support up to 4 LEDs, and move LED mode constants into dt-bindings header. - Improve bindings document. - Remove EEE support. Phil Elwell (3): lan78xx: Read MAC address from DT if present lan78xx

[PATCH v2 3/3] dt-bindings: Document the DT bindings for lan78xx

2018-04-18 Thread Phil Elwell
a bindings file. Signed-off-by: Phil Elwell --- .../devicetree/bindings/net/microchip,lan78xx.txt | 44 ++ MAINTAINERS| 1 + 2 files changed, 45 insertions(+) create mode 100644 Documentation/devicetree/bindings/net/microchip

[PATCH v2 1/3] lan78xx: Read MAC address from DT if present

2018-04-18 Thread Phil Elwell
There is a standard mechanism for locating and using a MAC address from the Device Tree. Use this facility in the lan78xx driver to support applications without programmed EEPROM or OTP. At the same time, regularise the handling of the different address sources. Signed-off-by: Phil Elwell

[PATCH v2 2/3] lan78xx: Read LED states from Device Tree

2018-04-18 Thread Phil Elwell
available. Signed-off-by: Phil Elwell --- MAINTAINERS | 1 + drivers/net/usb/lan78xx.c| 35 include/dt-bindings/net/microchip-78xx.h | 21 +++ 3 files changed, 57 insertions(+) create mode 100644

RE: [PATCH v3] gpio: dwapb: Add support for 1 interrupt per port A GPIO

2018-04-19 Thread Phil Edworthy
Hi Hoan On 18 April 2018 08:03 Hoan Tran wrote: > On Fri, Apr 13, 2018 at 9:47 AM, Phil Edworthy wrote: > > On 13 April 2018 17:37 Hoan Tran wrote: > >> On Fri, Apr 13, 2018 at 1:51 AM, Phil Edworthy wrote: > >> > The DesignWare GPIO IP can be configured for eith

Re: [PATCH 2/2] power: supply: add sbs-charger driver

2016-11-22 Thread Phil Reid
{ .compatible = "sbs,sbs-charger" }, + { }, +}; +MODULE_DEVICE_TABLE(of, sbs_dt_ids); +#endif + +static const struct i2c_device_id sbs_id[] = { + { "sbs-charger", 0 }, + { } +}; +MODULE_DEVICE_TABLE(i2c, sbs_id); + +static struct i2c_driver sbs_driver = { + .probe

Re: [PATCH 2/2] power: supply: add sbs-charger driver

2016-11-22 Thread Phil Reid
On 23/11/2016 09:06, Phil Reid wrote: G'day Nicola, On 22/11/2016 02:04, Nicola Saenz Julienne wrote: This adds support for sbs-charger compilant chips as defined here: http://sbs-forum.org/specs/sbc110.pdf You may want to look at the series: power: supply: sbs-manager add driver.

Re: [PATCH v2] stmmac: CSR clock configuration fix

2016-12-22 Thread Phil Reid
r_mask) - << priv->hw->mii.clk_csr_shift); + value |= (priv->clk_csr << priv->hw->mii.clk_csr_shift) + & priv->hw->mii.clk_csr_mask; if (priv->plat->has_gmac4) value |= MII_GMAC4_WRITE; -- Regards Phil Reid

Re: [PATCH v2] stmmac: CSR clock configuration fix

2016-12-22 Thread Phil Reid
On 22/12/2016 23:47, Joao Pinto wrote: Hello Phil, Às 3:42 PM de 12/22/2016, Phil Reid escreveu: G'day Joao, On 22/12/2016 20:38, Joao Pinto wrote: When testing stmmac with my QoS reference design I checked a problem in the CSR clock configuration that was impossibilitating th

Re: [PATCH v2] stmmac: CSR clock configuration fix

2016-12-22 Thread Phil Reid
G'day Joao, On 23/12/2016 01:06, Joao Pinto wrote: Às 4:57 PM de 12/22/2016, Phil Reid escreveu: On 22/12/2016 23:47, Joao Pinto wrote: Hello Phil, Às 3:42 PM de 12/22/2016, Phil Reid escreveu: G'day Joao, On 22/12/2016 20:38, Joao Pinto wrote: When testing stmmac with my QoS

[PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high

2017-02-17 Thread Phil Reid
before the irq was disabled as faulty. It looks like handle_level_irq should be used in this situation instead of handle_simple_irq. Signed-off-by: Phil Reid --- drivers/gpio/gpio-altera.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/gpio/gpio-altera.c b/drivers

Re: [PATCH 1/1] gpio: altera: Use handle_level_irq when configured as a level_high

2017-02-17 Thread Phil Reid
On 17/02/2017 17:23, Andy Shevchenko wrote: On Fri, Feb 17, 2017 at 11:12 AM, Phil Reid wrote: When a threaded irq handler is chained attached to one of the gpio pins when configure for level irq the altera_gpio_irq_leveL_high_handler does not mask the interrupt while being handled by the

[PATCH v2 1/1] gpio: altera: Use handle_level_irq when configured as a level_high

2017-02-19 Thread Phil Reid
before the irq was disabled as faulty. handle_level_irq should be used in this situation instead of handle_simple_irq. In gpiochip_irqchip_add set default handler to handle_bad_irq as per Documentation/gpio/driver.txt. Then set the correct handler in the set_type callback. Signed-off-by: Phil Reid

Re: [PATCH 2/2] iproute2: add support for invisible qdisc dumping

2017-02-27 Thread Phil Sutter
rr, " tc qdisc show [ dev STRING ] [ ingress | clsact > | invisible ]\n"); Doesn't look like these are mutually exclusive. Therefore I would suggest fixing the syntax to: | + fprintf(stderr, " tc qdisc show [ dev STRING ] [ ingress | clsact ] [ invisible ]\n"); Cheers, Phil

Re: [PATCH] gpio: pca953x: Fix pca953x_gpio_set_multiple() on 64-bit

2016-03-12 Thread Phil Reid
set_multiple to allow multiple bits to be set in one write.") Signed-off-by: Geert Uytterhoeven Acked-by: Phil Reid --- Untested, found by code inspection. This bug was introduced in v4.5-rc1, but unless Linus (the other one ;-) will make a v4.5-rc8, it's probably too late

Re: [PATCH] gpio: pca953x: Use correct u16 value for register word write

2016-03-29 Thread Phil Reid
reg << 1, *(u16 *)val); I don't think this is safe for systems that don't support unaligned memory access. break; case PCA957X_TYPE: ret = i2c_smbus_write_byte_data(chip->client, reg << 1, -- Regards Phil Reid

Re: [PATCH] gpio: pca953x: Use correct u16 value for register word write

2016-03-29 Thread Phil Reid
On 29/03/2016 10:39 PM, Alexander Stein wrote: You missed CC'ing Phil (Added for this post) On Tuesday 29 March 2016 20:53:58, Yong Li wrote: Thanks for your comment, I think I can change it to val[0] | (val[1] << 8), is it okay ? Mh, currently there is only one caller (device_p

Re: [PATCH] pinctrl-bcm2835: Fix cut-and-paste error in "pull" parsing

2016-03-01 Thread Phil Elwell
On 01/03/2016 01:30, Eric Anholt wrote: > From: Phil Elwell > > The DT bindings for pinctrl-bcm2835 allow both the function and pull > to contain either one entry or one per pin. However, an error in the > DT parsing can cause failures if the number of pulls differs from the > n

kthreads: sporadic NULL pointer dereference in exit_creds()

2015-08-12 Thread Phil Sutter
if ((err = kthread_stop(tsk[i]))) pr_warn("%s: kthread_stop failed for thread %d: %d\n", __func__, i, err); } kfree(tsk); printk(KERN_INFO "%s: test run ended\n", __func__); return 0; } static void __exit exit_kthread_

[PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
r during rehash") although not explicitly tested. Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash") Signed-off-by: Phil Sutter --- lib/rhashtable.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/lib/rhashtable.c b/lib/rhashtable.c index a

[PATCH v2] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
r during rehash") although not explicitly tested. Fixes: eddee5ba ("rhashtable: Fix walker behaviour during rehash") Signed-off-by: Phil Sutter --- Changes since v1: - Use simplified solution suggested by Herbert Xu. --- lib/rhashtable.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [PATCH] rhashtable: fix for resize events during table walk

2015-07-06 Thread Phil Sutter
On Mon, Jul 06, 2015 at 09:30:40PM +0800, Herbert Xu wrote: > On Mon, Jul 06, 2015 at 02:01:42PM +0200, Phil Sutter wrote: > > diff --git a/lib/rhashtable.c b/lib/rhashtable.c > > index a60a6d3..e36b94b 100644 > > --- a/lib/rhashtable.c > > +++ b/lib/rhashtable.c &

RE: [PATCH v2] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-07 Thread Phil Edworthy
Hi Shimoda-san, On 06 July 2015 08:18, Shimoda-san wrote: > Hi Phil-san, > > Thank you very much for the patch! > > > Sent: Thursday, July 02, 2015 5:06 PM > < snip > > > +/* VBUS change IRQ handler */ > > +static irqreturn_t gpio_vbus_irq(int

RE: [PATCH v3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Phil Edworthy
Hi Shimoda-san, On 06 July 2015 08:28, Shimoda-san wrote: > Hi Phil-san, > > > Sent: Thursday, July 02, 2015 7:27 PM > > > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of VBUS. > > > > Signed-off-by: P

RE: [PATCH v3] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Phil Edworthy
Hi Laurent, On 06 July 2015 09:20, Laurent wrote: > Hi Phil, > > Thank you for the patch. Thanks for your review! > On Thursday 02 July 2015 11:26:33 Phil Edworthy wrote: > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of

[PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-07 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- v5: - Avoid race when vbus_is_indirect may or may not be read before the phy has called vbus_session. In doing so, the changes have also been isolated to

[PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-07 Thread Phil Edworthy
. Note: the R-Car USB PHY only allows this Host/Function switching on channel 0. This has been tested on a r8a7791 based Koelsch board, which uses a MAX3355 device to supply vbus power when needed. Signed-off-by: Phil Edworthy --- v3: - Do not call usb_gadget_vbus_disconnect will a NULL ptr

[PATCH v4] ARM: shmobile: koelsch: make USB0 perform Host/Function switching

2015-07-07 Thread Phil Edworthy
Both USB Host (pci0) and Function (USBHS) drivers are enabled. The USB PHY driver determines which IP block should be connected based on vbus and id signals read via gpios. Note that switch SW5 and SW6 on Koelsch board needs to be set to position 3 for this to work. Signed-off-by: Phil Edworthy

RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-13 Thread Phil Edworthy
Hi Sergei, On 10 July 2015 17:36, Sergei wrote: > Hello. > > On 07/07/2015 02:55 PM, Phil Edworthy wrote: > > > Instead of statically selecting the PHY connection to either the > > USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > > dts to speci

RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-13 Thread Phil Edworthy
Hi Sergei, On 13 July 2015 11:17, Sergei wrote: > Hello. > > On 7/13/2015 12:04 PM, Phil Edworthy wrote: > > >>> Instead of statically selecting the PHY connection to either the > >>> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > >

RE: [PATCH v5] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-13 Thread Phil Edworthy
Hi Laurent, On 09 July 2015 02:03, Laurent wrote: > Hi Phil, > > On Wednesday 08 July 2015 08:08:27 Phil Edworthy wrote: > > On 08 July 2015 00:08, Laurent wrote: > > > On Tuesday 07 July 2015 12:52:43 Phil Edworthy wrote: > > > > These changes allow a PHY dr

[PATCH v6] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-13 Thread Phil Edworthy
These changes allow a PHY driver to trigger a VBUS interrupt and to provide the value of VBUS. Signed-off-by: Phil Edworthy --- v6: - Rename vbus_indirect_value to vbus_active v5: - Avoid race when vbus_is_indirect may or may not be read before the phy has called vbus_session. In doing

RE: [PATCH v6] usb: renesas_usbhs: Allow an OTG PHY driver to provide VBUS

2015-07-13 Thread Phil Edworthy
Hi Laurent, On 13 July 2015 16:51, Laurent wrote: > Hi Phil, > > Thank you for the patch. > > On Monday 13 July 2015 16:30:18 Phil Edworthy wrote: > > These changes allow a PHY driver to trigger a VBUS interrupt and > > to provide the value of VBUS. > > > &g

RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-13 Thread Phil Edworthy
Hi Sergei, On 13 July 2015 17:37, Sergei wrote: > On 07/13/2015 06:02 PM, Phil Edworthy wrote: > > >>>>> Instead of statically selecting the PHY connection to either the > >>>>> USBHS (Function) or PCI0 (Host) IP blocks, this change allows the > >

RE: [PATCH v3] phy: rcar-gen2 usb: Add Host/Function switching for USB0

2015-07-13 Thread Phil Edworthy
Hi Sergei, On 13 July 2015 18:10, Sergei wrote: > On 07/13/2015 07:55 PM, Phil Edworthy wrote: > > >>>>>>> Instead of statically selecting the PHY connection to either the > >>>>>>> USBHS (Function) or PCI0 (Host) IP blocks, this change allow

[PATCH nf] netfilter: nfnetlink: correctly validate length of batch messages

2016-02-02 Thread phil . turnbull
From: Phil Turnbull If nlh->nlmsg_len is zero then an infinite loop is triggered because 'skb_pull(skb, msglen);' pulls zero bytes. The calculation in nlmsg_len() underflows if 'nlh->nlmsg_len < NLMSG_HDRLEN' which bypasses the length validation and will later trig

RE: [Resend: PATCH v2 0/3] Fix rcar-pcie for arm64

2015-12-10 Thread Phil Edworthy
Hi Bjorn, On 09 December 2015 17:00, Bjorn Helgaas wrote: > On Thu, Nov 26, 2015 at 08:32:43AM +0000, Phil Edworthy wrote: > > HI Bjorn, > > > > On 25 November 2015 16:41, Bjorn Helgaas wrote: > > > Hi Phil, > > > > > > On Wed, Nov 25, 2015 at 03

RE: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar

2015-12-18 Thread Phil Edworthy
l_timeout() makes it easy, we > should better be safe than sorry. I haven't see that one before, very handy! Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://

RE: [PATCH 2/4] PCI: rcar: Support runtime PM link state L1 handling in pcie-rcar

2015-12-21 Thread Phil Edworthy
rm > /sys/power/pm_test echo N > /sys/module/printk/parameters/console_suspend echo mem > /sys/power/state Thanks Phil -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: WANTED new maintainer for Linux/md (and mdadm)

2015-12-21 Thread Phil Turmel
oviding excellent support. I'd particularly like to > high-light Phil Turmel who is very forthcoming with excellent advice, > but he is certainly not the only one who deserves a lot of thanks. > So "Thank you" to everyone who answers questions on linux-raid. You are ve

Re: Bisected Regression 4.3.5 => 4.4.1 booting HP ZBook in EFI mode

2016-02-05 Thread Phil Turmel
On 02/05/2016 05:29 PM, Greg Kroah-Hartman wrote: > On Fri, Feb 05, 2016 at 04:48:52PM -0500, Phil Turmel wrote: >> I'm stumped as to how that powerpc patch can affect my x86 laptop, an >> HP ZBook 17 w/ i7 processor & nouveau graphics, but it certainly >> does

Re: Bisected Regression 4.3.5 => 4.4.1 booting HP ZBook in EFI mode

2016-02-05 Thread Phil Turmel
nfig matched the originals I started with. So I cleaned my tree and started over building v4.3.5 then v4.4.1. They both booted. So I can no longer reproduce this. Sorry for the noise. Phil

Re: [RFC][PATCH] sched: Better document ttwu()

2020-07-02 Thread Phil Auld
re going to wake up a thread waiting for CONDITION we >* need to ensure that CONDITION=1 done by the caller can not be > - * reordered with p->state check below. This pairs with mb() in > - * set_current_state() the waiting thread does. > + * reordered with p->state

Re: [RFC PATCH 00/13] Core scheduling v5

2020-06-30 Thread Phil Auld
ore-scheduling and just > use that for tagging. (No need to even have a tag file, just adding/removing > to/from CGroup will tag). > ... this could be an interesting approach. Then the cookie could still be the cgroup address as is and there would be no need for the prctl. At least so it s

[PATCH] Sched: Add a tracepoint to track rq->nr_running

2020-06-19 Thread Phil Auld
acepoints are added to add_nr_running() and sub_nr_running() which are in kernel/sched/sched.h. Since sched.h includes trace/events/tlb.h via mmu_context.h we had to limit when CREATE_TRACE_POINTS is defined. Signed-off-by: Phil Auld CC: Qais Yousef CC: Ingo Molnar CC: Peter Zijlstra CC: Vincen

Re: [PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-05 Thread Phil Chang
n-Kuang Hu wrote: > Hi, Phil: > > Phil Chang 於 2020年10月4日 週日 下午1:51寫道: > > > > Certain SoCs need to support large amount of reserved memory > > regions, especially to follow the GKI rules from Google. > > In MTK new SoC requires more than 68 regions of reserved m

[PATCH] [PATCH] of_reserved_mem: Increase the number of reserved regions

2020-10-03 Thread Phil Chang
ff-by: Joe Liu Signed-off-by: YJ Chiang Signed-off-by: Alix Wu Signed-off-by: Phil Chang --- drivers/of/of_reserved_mem.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/of_reserved_mem.c b/drivers/of/of_reserved_mem.c index 46b9371c8a33..595f0741dcef 100644

Re: [PATCH 2/4] i2c: at91: implement i2c bus recovery

2020-08-25 Thread Phil Reid
On 25/08/2020 21:28, Wolfram Sang wrote: Hi Phil, yes, this thread is old but a similar issue came up again... On Fri, Oct 25, 2019 at 09:14:00AM +0800, Phil Reid wrote: So at the beginning of a new transfer, we should check if SDA (or SCL?) is low and, if it's true, only then we s

Re: [PATCH] sched/fair: Remove the force parameter of update_tg_load_avg()

2020-09-25 Thread Phil Auld
_load_avg(cfs_rq, false); > + update_tg_load_avg(cfs_rq); > propagate_entity_cfs_rq(se); > } > > @@ -10805,7 +10804,7 @@ static void attach_entity_cfs_rq(struct sched_entity > *se) > /* Synchronize entity with its cfs_rq */ > update_load_avg(cfs_rq, se, sched_feat(ATTACH_AGE_LOAD) ? 0 : > SKIP_AGE_LOAD); > attach_entity_load_avg(cfs_rq, se); > - update_tg_load_avg(cfs_rq, false); > + update_tg_load_avg(cfs_rq); > propagate_entity_cfs_rq(se); > } > > -- > 2.17.1 > LGTM, Reviewed-by: Phil Auld --

Re: [PATCH RFC] sched: Add a per-thread core scheduling interface

2020-05-28 Thread Phil Auld
On Thu, May 28, 2020 at 07:01:28PM +0200 Peter Zijlstra wrote: > On Sun, May 24, 2020 at 10:00:46AM -0400, Phil Auld wrote: > > On Fri, May 22, 2020 at 05:35:24PM -0400 Joel Fernandes wrote: > > > On Fri, May 22, 2020 at 02:59:05PM +0200, Peter Zijlstra wrote: > > >

Re: [PATCH RFC] sched: Add a per-thread core scheduling interface

2020-05-28 Thread Phil Auld
On Thu, May 28, 2020 at 02:17:19PM -0400 Phil Auld wrote: > On Thu, May 28, 2020 at 07:01:28PM +0200 Peter Zijlstra wrote: > > On Sun, May 24, 2020 at 10:00:46AM -0400, Phil Auld wrote: > > > On Fri, May 22, 2020 at 05:35:24PM -0400 Joel Fernandes wrote: > > > > On F

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
it doesn't jump to the label then se must be NULL for the loop to terminate. The final loop is a NOP if se is NULL. The check wasn't protecting that. Otherwise still > Reviewed-by: Phil Auld Cheers, Phil > Signed-off-by: Vincent Guittot > --- > > v2 changes: > -

Re: [PATCH v2] sched/fair: fix unthrottle_cfs_rq for leaf_cfs_rq list

2020-05-13 Thread Phil Auld
the same pattern as > enqueue_task_fair(). This fixes a problem already faced with the latter and > add an optimization in the last for_each_sched_entity loop. > > Reported-by Tao Zhou > Reviewed-by: Phil Auld > Signed-off-by: Vincent Guittot > --- > > v2 changes: > - R

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > > > Hi Vincent, > > > > On Wed, May 13, 2020 at 02:33:35PM +0200 Vincent Guittot wrote: > > > enqueue_task_fair jumps to enqueue_

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > > > On Wed, May 13, 2020 at 03:10:28PM +0200 Vincent Guittot wrote: > > > On Wed, 13 May 2020 at 14:45, Phil Auld wrote: > > > > > > >

Re: [PATCH v2] sched/fair: enqueue_task_fair optimization

2020-05-13 Thread Phil Auld
On Wed, May 13, 2020 at 03:25:29PM +0200 Vincent Guittot wrote: > On Wed, 13 May 2020 at 15:18, Phil Auld wrote: > > > > On Wed, May 13, 2020 at 03:15:53PM +0200 Vincent Guittot wrote: > > > On Wed, 13 May 2020 at 15:13, Phil Auld wrote: > > > > > > &g

Re: netfilter: does the API break or something else ?

2020-05-14 Thread Phil Sutter
Hi, On Wed, May 13, 2020 at 11:20:35PM +0800, Xiubo Li wrote: > Recently I hit one netfilter issue, it seems the API breaks or something > else. Just for the record, this was caused by a misconfigured kernel. Cheers, Phil

Re: [PATCH RFC] sched: Add a per-thread core scheduling interface

2020-05-24 Thread Phil Auld
ch as well. Nothing would happen to the tagged task as they were added to the cgroup. They'd keep their explicitly assigned tags and everything should "just work". There are other reasons to be in a cpu cgroup together than just the core scheduling tag. There are a few other edge cases, like if you are in a cgroup, but have been tagged explicitly with sched_setattr and then get untagged (presumably by setting 0) do you get the cgroup tag or just stay untagged? I think based on per-task winning you'd stay untagged. I supposed you could move out and back in the cgroup to get the tag reapplied (Or maybe the cgroup interface could just be reused with the same value to re-tag everyone who's untagged). Cheers, Phil > thanks, > > - Joel > --

<    1   2   3   4   5   6   7   8   >