Since the way the Synopsys GPIO interrupts are stored has changed, this
driver needs to be updated in line with the changes.
Signed-off-by: Phil Edworthy
---
v2:
- New patch in v2 to fix the only other user of struct dwapb_port_property.
---
drivers/mfd/intel_quark_i2c_gpio.c | 3 ++-
1 file
Hi Geert,
On 13 April 2018 09:20 Geert Uytterhoeven wrote:
> On Fri, Apr 13, 2018 at 10:08 AM, Phil Edworthy wrote:
> > Since the way the Synopsys GPIO interrupts are stored has changed,
> > this driver needs to be updated in line with the changes.
> >
> > S
s, it will
get as many interrupts as specified in the DT 'interrupts' property.
It doesn't do anything clever with the different interrupts, it just calls
the same handler used for single interrupt hardware.
Signed-off-by: Phil Edworthy
---
One point to mention is that I have made
On 23/03/2018 05:43, Laura Abbott wrote:
On 03/18/2018 06:29 PM, Phil Reid wrote:
On 16/03/2018 02:00, Laura Abbott wrote:
The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)
This patch replaces a VLA with an appropriate call to kmalloc_array.
Signed
On 08/04/2018 12:28, Stefan Wahren wrote:
> Hi Geert,
>
> [add Phil]
>
>> Geert Uytterhoeven hat am 8. April 2018 um 11:05
>> geschrieben:
>>
>>
>> If CONFIG_RASPBERRYPI_FIRMWARE=n:
>>
>> drivers/gpio/gpio-raspberrypi-exp.c: In functio
Hi Rob,
On 09 April 2018 20:20 Rob Herring wrote:
> On Wed, Mar 28, 2018 at 03:22:30PM +0100, Phil Edworthy wrote:
> > The DesignWare GPIO IP can be configured for either 1 or 32
> > interrupts, but the driver currently only supports 1 interrupt. See
> > the DesignWare
h the link is up), rendering the interface unusable.
Fix this issue by removing the lan78xx_reset call from lan78xx_open.
Fixes: 92571a1aae40 ("lan78xx: Connect phy early")
Signed-off-by: Phil Elwell
---
drivers/net/usb/lan78xx.c | 4
1 file changed, 4 deletions(-)
diff --g
Hi Rob,
On 10 April 2018 07:24 Phil Edworthy wrote:
> On 09 April 2018 20:20 Rob Herring wrote:
> > On Wed, Mar 28, 2018 at 03:22:30PM +0100, Phil Edworthy wrote:
[...]
> > > +- interrupt-mask : a 32-bit bit mask that specifies which interrupts
> > > +in the list
>
Hi Nisar,
On 10/04/2018 15:16, nisar.sa...@microchip.com wrote:
> Thanks Phil, for identifying the issues.
>
>> -ret = lan78xx_reset(dev);
>> -if (ret < 0)
>> -goto done;
>> -
>> phy_start(net->phydev);
>>
>>
Hi Geert,
On 10 April 2018 15:29 Geert Uytterhoeven wrote:
> On Tue, Apr 10, 2018 at 4:23 PM, Phil Edworthy wrote:
> > On 10 April 2018 07:24 Phil Edworthy wrote:
> >> On 09 April 2018 20:20 Rob Herring wrote:
> >> > On Wed, Mar 28, 2018 at 03:22:3
50);
+ msleep(50);
gpio_set_value(gpio, 1);
- mdelay(20);
+ msleep(20);
dev->current_page = 0xff;
}
Would that also imply gpio_set_value could be gpio_set_value_cansleep?
--
Regards
Phil Reid
From: Michel Pollet
Enable specified clocks from DTS, if any.
Signed-off-by: Michel Pollet
---
drivers/gpio/gpio-dwapb.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index b0704a8..56c58b5 100644
--- a/drivers/gpio/gpio-dwapb.c
status);
return IRQ_HANDLED;
}
Doing this in an irq handler seems wrong.
Perhaps better if a buffer is pre-allocated in stmpe_gpio
--
Regards
Phil Reid
en tested on the Renesas RZ/ND-DB board with the RZ/N1 SoC. The
Arasan IP in this device is version 1.39a and uses a max SD clock of 50MHz and
does not support DDR modes.
Signed-off-by: Phil Edworthy
---
v2:
- Changed commit msg to detail the cards that fail.
- Provided the IP version and further
Hi Andy,
On 13 March 2018 16:36, Andy Shevchenko wrote:
> On Mon, Mar 12, 2018 at 8:30 PM, Phil Edworthy
> wrote:
> > Enable an optional bus clock provided by DT.
>
> FWIW,
> Reviewed-by: Andy Shevchenko
Thanks!
> (Assuming it has been tested on clock-less cases)
On 14/03/2018 09:16, Laura Abbott wrote:
On 03/13/2018 05:18 PM, Laura Abbott wrote:
On 03/13/2018 02:13 AM, Phil Reid wrote:
On 10/03/2018 08:10, Laura Abbott wrote:
The new challenge is to remove VLAs from the kernel
(see https://lkml.org/lkml/2018/3/7/621)
This patch replaces a VLA with
On 26/09/2018 4:09 PM, Song Qiang wrote:
On Wed, Sep 26, 2018 at 10:30:34AM +0800, Phil Reid wrote:
On 26/09/2018 9:49 AM, Song Qiang wrote:
On Tue, Sep 25, 2018 at 10:36:54PM +0800, Phil Reid wrote:
On 25/09/2018 9:30 PM, Jonathan Cameron wrote:
+static irqreturn_t rm3100_trigger_handler
mple.
- Change the way the functions are defined so it is easy to check
against the hardware numbering.
v2:
- Change to generic rzn1 family driver, instead of device specific.
- Review comments fixed.
- Fix error handling during probe
Phil Edworthy (3):
dt-bindings: pinctrl: renes
The Renesas RZ/N1 device family PINCTRL node description.
Based on a patch originally written by Michel Pollet at Renesas.
Signed-off-by: Phil Edworthy
Reviewed-by: Jacopo Mondi
---
v6:
- Instead of combining the pin nr and func into a single element, use
a pair of 8-bit elements.
v5
This provides a pinctrl driver for the Renesas RZ/N1 device family.
Based on a patch originally written by Michel Pollet at Renesas.
Signed-off-by: Phil Edworthy
Reviewed-by: Jacopo Mondi
---
v6:
- Instead of combining the pin nr and func into a single element, use
a pair of 8-bit elements
This provides a pinctrl driver for the Renesas R9A06G032 SoC
Based on a patch originally written by Michel Pollet at Renesas.
Signed-off-by: Phil Edworthy
---
v6:
- No changes.
v5:
- No changes.
v4:
- No changes.
v3:
- No changes.
v2:
- Add "renesas,rzn1-pinctrl" compatibl
Hi Geert,
On 23 November 2018 09:41 Geert Uytterhoeven wrote:
> Subject: Re: [PATCH] pinctrl: rzn1: Fix check for used MDIO bus
> On Mon, Nov 19, 2018 at 5:18 PM Phil Edworthy wrote:
> > This fixes the check for unused mdio bus setting and the following
> > static checker war
interrupt-controller"
Signed-off-by: Phil Edworthy
---
arch/arm/boot/dts/ox820.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/ox820.dtsi b/arch/arm/boot/dts/ox820.dtsi
index 085bbd33eadc..3a17ab4e7c2f 100644
--- a/arch/arm/boot/dts/ox820.dtsi
+++
interrupt-controller"
Signed-off-by: Phil Edworthy
---
arch/arm/boot/dts/alpine.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm/boot/dts/alpine.dtsi b/arch/arm/boot/dts/alpine.dtsi
index 731df7a8c4e6..533c876497ff 100644
--- a/arch/arm/boot/dts/alpine.dtsi
interrupt-controller"
Signed-off-by: Phil Edworthy
---
arch/arm64/boot/dts/al/alpine-v2.dtsi | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/arch/arm64/boot/dts/al/alpine-v2.dtsi
b/arch/arm64/boot/dts/al/alpine-v2.dtsi
index 5b7bef684256..6f35bab10e9d 100644
--- a/arch
Hi Andy,
On 20 November 2018 10:39 Andy Shevchenko wrote:
> On Mon, Nov 19, 2018 at 02:12:59PM +0000, Phil Edworthy wrote:
> > This adds clk_get_optional() and devm_clk_get_optional() functions to
> > get optional clocks.
> > They behave the same as (devm_)clk_get except wh
The sub-nodes should not be called gpio-controller, but simply gpio.
Signed-off-by: Phil Edworthy
---
Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/bindings/gpio/snps-dwapb-gpio.txt
b
clk_prepare_enable, etc to be called on the returned reference
without additional checks.
Signed-off-by: Phil Edworthy
Reviewed-by: Andy Shevchenko
---
v8:
- Remove else clause
v7:
- Instead of messing with the core functions, simply wrap them for the
_optional() versions. By putting clk_get_optional
Hi Simon,
On 22 November 2018 14:09 Simon Horman wrote:
> On Mon, Nov 19, 2018 at 04:18:38PM +0000, Phil Edworthy wrote:
> > This fixes the check for unused mdio bus setting and the following
> > static checker warning:
> > drivers/pinctrl/pinctrl-rzn1.c:198 rzn1_pinctrl_md
Hi Stephen,
On 30 November 2018 09:09 Stephen Boyd wrote:
> Quoting Phil Edworthy (2018-11-20 06:14:45)
> > This adds clk_get_optional() and devm_clk_get_optional() functions to
> > get optional clocks.
> > They behave the same as (devm_)clk_get except where there is no c
Hi Rob,
On 17 November 2018 14:33 Rob Herring wrote:
> On Tue, Nov 13, 2018 at 01:09:09PM +0000, Phil Edworthy wrote:
> > Add device binding documentation for the Renesas RZ/N1 GPIO interrupt
> > multiplexer.
> >
> > Signed-off-by: Phil Edworthy
> > ---
>
e that fixes the error code, and
then
adds clk_get_optional() like above, it will make more sense.
btw, do we need to add of_clk_get_by_name_optional()? I only added it as a
counterpart to of_clk_get_by_name(), but it may not be needed.
Thanks
Phil
Hi Uwe,
On 19 November 2018 10:46 Uwe Kleine-König wrote:
> On Mon, Nov 19, 2018 at 10:41:42AM +0000, Phil Edworthy wrote:
> > On 16 November 2018 16:11 Uwe Kleine-König wrote:
> > > On Fri, Nov 16, 2018 at 05:01:28PM +0100, Uwe Kleine-König wrote:
> > > > Other
Hi Uwe,
On 19 November 2018 12:58 Uwe Kleine-König wrote:
> On Mon, Nov 19, 2018 at 12:53:46PM +0000, Phil Edworthy wrote:
> > On 19 November 2018 10:46 Uwe Kleine-König wrote:
> > > On Mon, Nov 19, 2018 at 10:41:42AM +, Phil Edworthy wrote:
> > &g
clk_prepare_enable, etc to be called on the returned reference
without additional checks.
Signed-off-by: Phil Edworthy
---
v7:
- Instead of messing with the core functions, simply wrap them for the
_optional() versions. By putting clk_get_optional() inline in the header
file, we can get rid of the
ing of_get_child_count()
Reported-by: Dan Carpenter
Signed-off-by: Phil Edworthy
---
v2:
- Don't rely on rely on the implicit typecast from -1 to uint
---
drivers/pinctrl/pinctrl-rzn1.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/pinctrl/pinctrl-rzn1.c b/d
Hi Andy,
On 03 December 2018 13:31 Andy Shevchenko wrote:
> On Mon, Dec 03, 2018 at 11:13:08AM +0000, Phil Edworthy wrote:
> > It's not immediately obvious from the code that failure to get a clock
> > provider can return either -ENOENT or -EINVAL. Therefore, add a
> >
clk_prepare_enable, etc to be called on the returned reference
without additional checks.
Signed-off-by: Phil Edworthy
Reviewed-by: Andy Shevchenko
---
v9:
- Add brackets after devm_clk_get so people know it's a function.
- Add kernel doc for clk_get_optional().
v8:
- Remove else clause
v7:
- In
t's a function.
- Add kernel doc for clk_get_optional().
Phil Edworthy (2):
clk: Add comment about __of_clk_get_by_name() error values
clk: Add (devm_)clk_get_optional() functions
drivers/clk/clk-devres.c | 11 +++
drivers/clk/clkdev.c | 6 ++
include/linux/clk.h
It's not immediately obvious from the code that failure to get a
clock provider can return either -ENOENT or -EINVAL. Therefore, add
a comment to highlight this.
Signed-off-by: Phil Edworthy
---
drivers/clk/clkdev.c | 6 ++
1 file changed, 6 insertions(+)
diff --git a/drivers/clk/clk
r feedback came afterwards.
However, in my haste I managed to drop the changes made to dwapb_port_property
struct. This patch includes those missing changes.
Signed-off-by: Phil Edworthy
---
include/linux/platform_data/gpio-dwapb.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git
: dwapb: Rework support for 1 interrupt per port
> A GPIO")
> Signed-off-by: Dan Carpenter
Thanks for the patch, I had already noticed the mistake and sent a patch.
Thanks
Phil
> diff --git a/include/linux/platform_data/gpio-dwapb.h
> b/include/linux/platform_data/gpio-dwapb.h
>
EFER;
+ }
+
IANAE, but normally the return pattern for devm_regulator_get_optional
if (!IS_ERR(reg)) {
regulator_enable ...
} else {
ret = PTR_ERR(reg);
if (ret != -ENODEV)
return ret;
}
--
Regards
Phil
ev, indio_dev);
+ err = devm_iio_device_register(&client->dev, indio_dev);
+ if (!err)
+ return 0;
+
+disable_regulators:
+ if (!IS_ERR(chip->vdd_reg))
+ regulator_disable(chip->vdd_reg);
+ if (!IS_ERR(chip->vdda_reg))
+ regulator_disable(chip->vdda_reg);
+
+ return err;
}
[snip]
--
Regards
Phil
G'day Anson,
Just pulled up the datasheet for this chip.
The absolute max for Vdda is speced as Vddd +/-0.5
With a note that Vdda should be externally shorted to Vddd.
On 11/12/2018 11:43 am, Anson Huang wrote:
Hi, Phil
Best Regards!
Anson Huang
-Original Message-
From: Phil
nk we
should just
use one regulator vdd, then it will be much easier for the driver, what do you
think?
Yes I think that makes sense.
--
Regards
Phil
s is part of a longer, untested, series to remove semaphores
> > from the kernel, please review as such before applying.
> > ---
> > lib/test_rhashtable.c | 28
> > 1 file changed, 16 insertions(+), 12 deletions(-)
>
> This was created
I believe that's a different issue, though. The
kernel
allows this setting and should handle it better than it currently does. The
proposed
patch fixes it so that all the tasks make progress (even if not much progress)
rather
than having some starve at the back of the list.
Cheers,
Ph
eeds to be fixed - and at first sight the quota
> > of 1000 looks very
> > low - could we improve the arithmetics perhaps?
> >
> > A low quota of 1000 is used because there's many VMs or containers
> > provisioned on the system
> > that is trig
d, so there is nothing to do in this driver when an interrupt
is received, other than tell the corresponding GPIO block.
Signed-off-by: Phil Edworthy
---
v2:
- Use interrupt-map to allow the GPIO controller info to be specified
as part of the irq.
- Renamed struct and funcs from 'girq&
The SPI configuration state includes an SPI_NO_CS flag that disables
all CS line manipulation, for applications that want to manage their
own chip selects. However, this flag is ignored by the GPIO CS code
in the SPI framework.
Correct this omission with a trivial patch.
Signed-off-by: Phil
From: "Phil Auld"
sched/fair: Avoid throttle_list starvation with low cfs quota
With a very low cpu.cfs_quota_us setting, such as the minimum of 1000,
distribute_cfs_runtime may not empty the throttled_list before it runs
out of runtime to distribute. In that case, due to the c
ret);
return ret;
}
- gpio_direction_input(chip->busy_pin);
The busy pin doesn't exist on the ad7818.
Which the driver claims to support in the id table:
> static const struct spi_device_id ad7816_id[] = {
>{ "ad7816", 0 },
>{ "ad7817", 0 },
>{ "ad7818", 0 },
>{}
> };
See:
https://www.analog.com/media/en/technical-documentation/data-sheets/AD7817_7818.pdf
Page 9.
indio_dev->name = spi_get_device_id(spi_dev)->name;
indio_dev->dev.parent = &spi_dev->dev;
Also should the pin names be documented in a device tree binding doc?
--
Regards
Phil Reid
Hi Greg,
On 18/09/2018 14:02, Greg Kroah-Hartman wrote:
> On Wed, Sep 12, 2018 at 03:31:55PM +0100, Phil Elwell wrote:
>> The SC16IS752 is a dual-channel device. The two channels are largely
>> independent, but the IRQ signals are wired together as an open-drain,
>> active
The driver requires an undocumented clock property, so detail it.
Add documentation for a separate bus clock.
Signed-off-by: Phil Edworthy
---
Documentation/devicetree/bindings/i2c/i2c-designware.txt | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/Documentation
The Synopsys I2C Controller has a bus clock, but typically SoCs hide this away.
However, on some SoCs you need to explicity enable the bus clock in order to
access the registers.
Therefore, enable an optional bus clock specified by DT.
Signed-off-by: Phil Edworthy
---
drivers/i2c/busses/i2c
: Phil Edworthy
---
drivers/clk/clk-devres.c | 11 +++
drivers/clk/clkdev.c | 11 +++
include/linux/clk.h | 27 +++
3 files changed, 49 insertions(+)
diff --git a/drivers/clk/clk-devres.c b/drivers/clk/clk-devres.c
index d854e26..63295d9 100644
--- a
Hi Russell,
On 18 July 2018 14:19, Geert Uytterhoeven wrote:
> On Wed, Jul 18, 2018 at 3:02 PM Russell King - ARM Linux wrote:
> > On Wed, Jul 18, 2018 at 01:57:38PM +0100, Phil Edworthy wrote:
> > > Behaves the same as (devm_)clk_get except where there is no clock
> >
ould mean this stays as it was but this
change makes sense as you have written it too.
Cheers,
Phil
>
> No functional changes were intended.
>
> [1]
> https://lore.kernel.org/lkml/20240506100509.gl40...@noisy.programming.kicks-ass.net/
>
> Signed-off-by: Qais Y
On Wed, May 15, 2024 at 10:32:38AM +0200 Peter Zijlstra wrote:
> On Tue, May 14, 2024 at 07:58:51PM -0400, Phil Auld wrote:
> >
> > Hi Qais,
> >
> > On Wed, May 15, 2024 at 12:41:12AM +0100 Qais Yousef wrote:
> > > rt_task() checks if a task has RT priority.
On Wed, May 15, 2024 at 01:06:13PM +0100 Qais Yousef wrote:
> On 05/15/24 07:20, Phil Auld wrote:
> > On Wed, May 15, 2024 at 10:32:38AM +0200 Peter Zijlstra wrote:
> > > On Tue, May 14, 2024 at 07:58:51PM -0400, Phil Auld wrote:
> > > >
> > > > Hi Qais
see: http://bugzilla.kernel.org/show_bug.cgi?id=9073
--
Philippe Bourcierhttp://bourcier.philippe.online.fr/
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo
ne
memmap=nn!ss syntax it adds
a type 12 region to the e820 map and so you would want this support.
If you have a motherboard with UEFI support for NVDIMM's that would be
the recommended
configuration.
Phil P.
--
Philip Pokorny, RHCE
Chief Technology Officer
PENGUIN COMPUTING, Inc
www.penguinc
On Tue, Apr 28, 2015 at 3:58 PM, Andy Lutomirski wrote:
> On Tue, Apr 28, 2015 at 3:21 PM, Phil Pokorny
> wrote:
>> On Tue, Apr 28, 2015 at 2:04 PM, Andy Lutomirski wrote:
>>> On Tue, Apr 28, 2015 at 11:25 AM, Dan Williams
>>> wrote:
>>>> +config ND
These changes allow a PHY driver to trigger a VBUS interrupt and
to provide the value of VBUS.
Signed-off-by: Phil Edworthy
---
drivers/usb/renesas_usbhs/common.h | 2 ++
drivers/usb/renesas_usbhs/mod.c| 3 +++
drivers/usb/renesas_usbhs/mod_gadget.c | 38
.
Note: the R-Car USB PHY only allows this Host/Function switching
on channel 0.
This has been tested on a r8a7791 based Koelsch board, which uses
a MAX3355 device to supply vbus power when needed.
Signed-off-by: Phil Edworthy
---
drivers/phy/phy-rcar-gen2.c | 269
Both USB Host (pci0) and Function (USBHS) drivers are enabled.
The USB PHY driver determines which IP block should be connected
based on vbus and id signals read via gpios.
Signed-off-by: Phil Edworthy
---
arch/arm/boot/dts/r8a7791-koelsch.dts | 7 ---
1 file changed, 4 insertions(+), 3
This patch set adds support for USB Host/Function switching using external
gpios to get the vbus and id signals.
I am aware that the dt binding for the USB phy will need updating, but wanted
to get this patch set out first to see whether this is the best way to
implement this.
Phil
Phil
Hi Linus,
On 23 May 2018 09:29, Linus Walleij wrote:
> On Fri, May 11, 2018 at 10:31 AM, Phil Edworthy wrote:
>
> > The DesignWare GPIO IP can be configured for either 1 interrupt or 1
> > per GPIO in port A, but the driver currently only supports 1 interrupt.
> > See th
t_irq().
Signed-off-by: Phil Edworthy
---
drivers/gpio/gpio-dwapb.c | 53 ---
1 file changed, 22 insertions(+), 31 deletions(-)
diff --git a/drivers/gpio/gpio-dwapb.c b/drivers/gpio/gpio-dwapb.c
index 7dcd06b..15b4154 100644
--- a/drivers/gpio/gpio-dwapb.c
Hi Simon,
On 23 May 2018 10:12 Simon Horman wrote:
> On Wed, May 23, 2018 at 09:52:44AM +0100, Phil Edworthy wrote:
> > Treat DT and ACPI the same as much as possible. Note that we can't use
> > platform_get_irq() to get the DT interrupts as they are in the port
> > sub-
Hi Andy,
On 30 March 2018 22:26 Andy Shevchenko wrote:
> On Wed, Mar 28, 2018 at 5:22 PM, Phil Edworthy wrote:
> > The DesignWare GPIO IP can be configured for either 1 or 32
> > interrupts,
>
> 1 to 32, or just a choice between two?
Just a choice of 1 or 32.
Note that
AC voltage to set output current is also a distinct possibility.
--
Regards
Phil Reid
et as many interrupts as specified in the DT 'interrupts' property.
It doesn't do anything clever with the different interrupts, it just calls
the same handler used for single interrupt hardware.
Signed-off-by: Phil Edworthy
---
Note: There are a few lines over 80 chars, but thi
os > MAX_GPIOS) {
+ dev_err(&pdev->dev, "Need to increase maximum GPIO number\n");
+ return -EINVAL;
+ }
+
stmpe_gpio = kzalloc(sizeof(*stmpe_gpio), GFP_KERNEL);
if (!stmpe_gpio)
return -ENOMEM;
FWIW
Reviewed-by: Phil Reid
--
Regards
Phil Reid
Hi,
On 28 March 2018 15:23, Phil Edworthy wrote:
> The DesignWare GPIO IP can be configured for either 1 or 32 interrupts,
> but the driver currently only supports 1 interrupt. See the DesignWare
> DW_apb_gpio Databook description of the 'GPIO_INTR_IO' parameter.
>
&g
s, it will
get as many interrupts as specified in the DT 'interrupts' property.
It doesn't do anything clever with the different interrupts, it just calls
the same handler used for single interrupt hardware.
ACPI companion code provided by Hoan Tran . This was tested
on X-Gene by H
Hi Rob,
On 01 May 2018 14:29 Rob Herring wrote:
> On Mon, Apr 23, 2018 at 02:33:06PM +0100, Phil Edworthy wrote:
> > On RZ/N1 devices, there are 3 Synopsys DesignWare GPIO blocks each
> > configured to have 32 interrupt outputs, so we have a total of 96 GPIO
> > interru
ti_battery_presence_and_health()
return 0;
}
@@ -941,7 +976,10 @@ MODULE_DEVICE_TABLE(i2c, sbs_id);
static const struct of_device_id sbs_dt_ids[] = {
{ .compatible = "sbs,sbs-battery" },
- { .compatible = "ti,bq20z75" },
+ {
+ .compatible = "ti,bq20z75",
+ .data = (void *)SBS_FLAGS_TI_BQ20Z75,
+ },
{ }
};
MODULE_DEVICE_TABLE(of, sbs_dt_ids);
--
Regards
Phil Reid
g. gpio-74x164 driven from spi-gpio,
where I can extend the chain to increase the level of recursion arbitrarily).
I think a config option for FASTPATH_NGPIO is preferable.
As I've mentioned ARCH_NR_GPIOS is much greater than any chip->ngpio on
my platform.
It's at least one order of magnitude, almost 2.
--
Regards
Phil Reid
,
+static inline int gpiod_set_raw_array_value_cansleep(unsigned int array_size,
struct gpio_desc **desc_array,
int *value_array)
{
/* GPIO can never have been requested */
WARN_ON(1);
+ return 0;
}
static inline int gpiod_set_debounce(struct gpio_desc *desc, unsigned debounce)
G'day Laura,
Looks good to me.
Reviewed-by: Phil Reid
--
Regards
Phil Reid
iod_timer never takes longer
than period
would be good but I'm not sure what that would be and we still have this
potential forever
loop.
Below is the bandaid version.
Thoughts?
Cheers,
Phil
---
diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
index 310d0637fe4b..33e556
On Tue, Apr 09, 2019 at 03:05:27PM +0200 Peter Zijlstra wrote:
> On Tue, Apr 09, 2019 at 08:48:16AM -0400, Phil Auld wrote:
> > Hi Ingo, Peter,
> >
> > On Wed, Apr 03, 2019 at 01:38:39AM -0700 tip-bot for Phil Auld wrote:
> > > Commit-ID: 06ec5d30e8d57b820d44df6
On Tue, Apr 09, 2019 at 03:05:27PM +0200 Peter Zijlstra wrote:
> On Tue, Apr 09, 2019 at 08:48:16AM -0400, Phil Auld wrote:
> > Hi Ingo, Peter,
> >
> > On Wed, Apr 03, 2019 at 01:38:39AM -0700 tip-bot for Phil Auld wrote:
> > > Commit-ID: 06ec5d30e8d57b820d44df6
Hi Sasha,
On Tue, Apr 16, 2019 at 08:32:09AM -0700 tip-bot for Phil Auld wrote:
> Commit-ID: 2e8e19226398db8265a8e675fcc0118b9e80c9e8
> Gitweb:
> https://git.kernel.org/tip/2e8e19226398db8265a8e675fcc0118b9e80c9e8
> Author: Phil Auld
> AuthorDate: Tue, 19 Mar 2019
ifdef CONFIG_SCHED_CORE
> + int tagged;
> +#endif
> +
> #ifdef CONFIG_FAIR_GROUP_SCHED
> /* schedulable entities of this group on each CPU */
> struct sched_entity **se;
> --
> 2.17.1
>
Since CPU0 never goes through the cpu
takes the third arguement 'bool on_same_rq'?
>
Fwiw, I find the two names easier to read than a boolean flag. Could still
be wrapped to a single implementation I suppose.
An enum to control cpu or core would be more readable, but probably overkill...
Cheers,
Phil
> Thanks
--
On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wrote:
> On Mon, Mar 11, 2019 at 10:44:25AM -0700 bseg...@google.com wrote:
> > Letting it spin for 100ms and then only increasing by 6% seems extremely
> > generous. If we went this route I'd probably say "after loo
as suggested by Ben Segall
.
Signed-off-by: Phil Auld
Cc: Ben Segall
Cc: Ingo Molnar
Cc: Peter Zijlstra (Intel)
---
Note: This is against v5.0 as suggested by the documentation. It won't apply to
5.0+ due to
the change to raw_spin_lock_irqsave. I can respin as needed.
kernel/
On Wed, Mar 13, 2019 at 10:44:09AM -0700 bseg...@google.com wrote:
> Phil Auld writes:
>
> > On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wrote:
> >> On Mon, Mar 11, 2019 at 10:44:25AM -0700 bseg...@google.com wrote:
> >> > Letting it spin for 100ms and
On Wed, Mar 13, 2019 at 01:26:51PM -0700 bseg...@google.com wrote:
> Phil Auld writes:
>
> > On Wed, Mar 13, 2019 at 10:44:09AM -0700 bseg...@google.com wrote:
> >> Phil Auld writes:
> >>
> >> > On Mon, Mar 11, 2019 at 04:25:36PM -0400 Phil Auld wr
On Fri, Mar 15, 2019 at 11:11:50AM +0100 Peter Zijlstra wrote:
> On Wed, Mar 13, 2019 at 11:08:26AM -0400, Phil Auld wrote:
> > diff --git a/kernel/sched/fair.c b/kernel/sched/fair.c
> > index 310d0637fe4b..90cc67bbf592 100644
> > --- a/kernel/sched/fair.c
> >
edge case that this approach will make the problem go away. The only
alternative we
came up with to reduce the time taken in unthrottle involved a fair bit of
complexity
added to the every day code paths. And might not help if the children all had
their
own quota/period settings active.
Thou
On Fri, Mar 15, 2019 at 11:11:50AM +0100 Peter Zijlstra wrote:
> On Wed, Mar 13, 2019 at 11:08:26AM -0400, Phil Auld wrote:
...
> Computers _suck_ at /100. And since you're free to pick the constant,
> pick a power of two, computers love those.
>
> > +
> > +
On Fri, Mar 15, 2019 at 05:03:47PM +0100 Peter Zijlstra wrote:
> On Fri, Mar 15, 2019 at 11:30:42AM -0400, Phil Auld wrote:
>
> > In my defense here, all the fair.c imbalance pct code also uses 100 :)
>
> Yes, I know, I hate on that too ;-) Just never got around to fixing
>
On Fri, Mar 15, 2019 at 04:59:33PM +0100 Peter Zijlstra wrote:
> On Fri, Mar 15, 2019 at 09:51:25AM -0400, Phil Auld wrote:
> > On Fri, Mar 15, 2019 at 11:33:57AM +0100 Peter Zijlstra wrote:
> > > On Fri, Mar 15, 2019 at 11:11:50AM +0100, Peter Zijlstra wrote:
> > >
Hi Ingo, Peter,
On Wed, Apr 03, 2019 at 01:38:39AM -0700 tip-bot for Phil Auld wrote:
> Commit-ID: 06ec5d30e8d57b820d44df6340dcb25010d6d0fa
> Gitweb:
> https://git.kernel.org/tip/06ec5d30e8d57b820d44df6340dcb25010d6d0fa
> Author: Phil Auld
> AuthorDate: Tue, 19 Mar 2019
On Tue, Apr 09, 2019 at 03:05:27PM +0200 Peter Zijlstra wrote:
> On Tue, Apr 09, 2019 at 08:48:16AM -0400, Phil Auld wrote:
> > Hi Ingo, Peter,
> >
> > On Wed, Apr 03, 2019 at 01:38:39AM -0700 tip-bot for Phil Auld wrote:
> > > Commit-ID: 06ec5d30e8d57b820d44df6
sed if
> + * _every_ other avenue has been traveled.
> + **/
> +
> void cpuset_cpus_allowed_fallback(struct task_struct *tsk)
> {
> rcu_read_lock();
> - do_set_cpus_allowed(tsk, task_cs(tsk)->effective_cpus);
> + do_set_cpus_allowed(tsk, is_in_v2_mode() ?
> + task_cs(tsk)->cpus_allowed : cpu_possible_mask);
> rcu_read_unlock();
>
> /*
> --
> 2.18.1
>
Fwiw,
Acked-by: Phil Auld
--
ipset IMHO.
Unlike nft monitor, auditd is not designed to be disabled "at will". So
turning it off for performance-critical workloads is no option.
Cheers, Phil
201 - 300 of 731 matches
Mail list logo
