From: Miguel Ojeda
Some of you have noticed the past few weeks and months that
a serious attempt to bring a second language to the kernel was
being forged. We are finally here, with an RFC that adds support
for Rust to the Linux kernel.
This cover letter is fairly long, since there are quite a
From: Miguel Ojeda
Rust symbols can become quite long due to namespacing introduced
by modules, types, traits, generics, etc.
Increasing to 255 is not enough in some cases, and therefore
we need to introduce 2-byte lengths to the symbol table. We call
these "big" symbols.
In orde
From: Miguel Ojeda
Rust symbols can become quite long due to namespacing introduced
by modules, types, traits, generics, etc. For instance, for:
pub mod my_module {
pub struct MyType;
pub struct MyGenericType(T);
pub trait MyTrait {
fn my_method() ->
From: Miguel Ojeda
To support Rust under GCC-built kernels, we need to save the flags that
would have been passed if the kernel was being compiled with Clang.
The reason is that bindgen -- the tool we use to generate Rust bindings
to the C side of the kernel -- relies on libclang to parse C
From: Miguel Ojeda
Rust provides `compiler_builtins` as a port of LLVM's `compiler-rt`.
Since we do not need the vast majority of them, we avoid the
dependency by providing our own crate.
We also need a helpers C source file to contain some forwarders
to C macros and inlined functions. Fo
From: Miguel Ojeda
This commit includes also the `Kconfig` entries related to Rust,
the Rust configuration printer, the target definition files,
the version detection script and a few other bits.
In the future, we will likely want to generate the target files
on the fly via a script.
With this
From: Miguel Ojeda
Now that all the shared Rust infrastructure is in, we export all
the symbols reusing the `EXPORT_SYMBOL_GPL` macro from C. The lists
of symbols are generated on the fly when compiling the crates.
There are three main sets of symbols to distinguish:
- The ones from the
From: Miguel Ojeda
Implements the `module!` macro that is used by Rust modules
to easily declare the equivalent information to the `MODULE_*`
macros in C modules, e.g.:
module! {
type: RustMinimal,
name: b"rust_minimal",
author: b"Rust for Lin
From: Miguel Ojeda
Most of the documentation for Rust is written within the source code
itself, as it is idiomatic for Rust projects. This applies to both
the shared infrastructure at `rust/` as well as any other Rust module
(e.g. drivers) written across the kernel.
These documents are general
From: Miguel Ojeda
The `kernel` crate currently includes all the abstractions that wrap
kernel features written in C.
These abstractions call the C side of the kernel via the generated
bindings with the `bindgen` tool. Modules developed in Rust should
never call the bindings themselves.
In the
From: Miguel Ojeda
These abstractions are work in progress. They are needed for
the next commit, which is the one intended to be reviewed.
Co-developed-by: Alex Gaynor
Signed-off-by: Alex Gaynor
Co-developed-by: Geoffrey Thomas
Signed-off-by: Geoffrey Thomas
Co-developed-by: Finn Behrens
may look like.
Signed-off-by: Wedson Almeida Filho
Signed-off-by: Miguel Ojeda
---
drivers/android/Kconfig | 7 +
drivers/android/Makefile| 2 +
drivers/android/allocation.rs | 252
drivers/android/context.rs | 80 +++
drivers/android/defs.rs
From: Miguel Ojeda
A set of Rust modules that showcase how Rust modules look like
and how to use the abstracted kernel features.
At the moment we also use them as poor man's tests in our CI.
However, we plan to implement a proper testing framework.
The semaphore sample comes with a C ve
From: Miguel Ojeda
Miguel, Alex and Wedson will be maintaining the Rust support.
Co-developed-by: Alex Gaynor
Signed-off-by: Alex Gaynor
Co-developed-by: Wedson Almeida Filho
Signed-off-by: Wedson Almeida Filho
Signed-off-by: Miguel Ojeda
---
MAINTAINERS | 14 ++
1 file
On Jan 24, 2008 2:44 AM, Dave Young <[EMAIL PROTECTED]> wrote:
>
> On Wed, Jan 23, 2008 at 02:06:43PM -0800, Andrew Morton wrote:
> > > On Mon, 21 Jan 2008 18:53:18 +0100 "Miguel Ojeda" <[EMAIL PROTECTED]>
> > > wrote:
> > > Booting 2.
d about what people are trying to accomplish here...
>
I think we all are trying to give ideas to improve the current logging API.
If something works, it's great; but it doesn't mean that it can't be
improved, right?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote:
> On Friday 05 October 2007 2:01:08 am Miguel Ojeda wrote:
> >
> > I think we all are trying to give ideas to improve the current logging API.
> >
> > If something works, it's great; but it doesn'
On 10/6/07, Stephen Hemminger <[EMAIL PROTECTED]> wrote:
> On Sat, 6 Oct 2007 01:01:10 +0200
> "Miguel Ojeda" <[EMAIL PROTECTED]> wrote:
>
> > On 10/5/07, Rob Landley <[EMAIL PROTECTED]> wrote:
> > > On Friday 05 October 2007 2:01:08 am Miguel Oj
s SCSI scanning" is
enabled.
Should not be -at least- a way to disable it?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at ht
On Jan 30, 2008 6:48 AM, Dave Young <[EMAIL PROTECTED]> wrote:
>
> On Jan 25, 2008 9:27 AM, Dave Young <[EMAIL PROTECTED]> wrote:
> >
> > On Jan 25, 2008 12:32 AM, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
> > >
> > > On Jan 24, 2008 2:44 AM, Da
or obsolete in 2.6 linux.
>
> And I have noticed even if I commented _syscall0 macro, I do not get
> any errors so no body is using it , then why _syscall0 is in kernel
> header files and what is the substitute of _syscall0.
Well, if you look at
http://lxr.linux.no/ident?i=_syscall0
it seem
ple.c
> + - cfag12864b LCD userspace example program.
> +ks0108
> + - documentation for the ks0108 LCD controller driver.
>
>
>
Thank you for the patch.
Signed-off-by: Miguel Ojeda <[EMAIL PROTECTED]>
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To uns
; LAPB module
> L: [EMAIL PROTECTED]
>
Thank you for the patch.
Signed-off-by: Miguel Ojeda <[EMAIL PROTECTED]>
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a
> P: Johannes Berg
>
I think you could add also:
+F: Documentation/auxdisplay/cfag12864bfb
as you did at the ks0108 driver entry.
Thank you for the patch.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-ke
>
Although for now drivers/auxdisplay/ only supports 2*ks0108-controlled
LCDs like cfag12864b or similar,
> +F: include/linux/cfag12864b.h
it is not really just about cfag12864b (although it could be OK to
point to some header file at all).
Thank you for the patch.
--
Miguel Ojeda
http:/
AINTAINERS
> @@ -1160,6 +1160,8 @@ M:[EMAIL PROTECTED]
> L: linux-kernel@vger.kernel.org
> W: http://auxdisplay.googlepages.com/
> S: Maintained
> +F: drivers/auxdisplay/cfag12864b.c
> +F: include/linux/cfag12864b.h
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
&g
On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > I think you could add also:
> > +F: Documentation/auxdisplay/cfag12864bfb
>
> This is what I have now:
>
> CFAG12864BFB LCD FRAMEBUFFER DRIVER
&g
On 8/17/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> On Fri, 2007-08-17 at 06:37 +0200, Miguel Ojeda wrote:
> > On 8/16/07, Joe Perches <[EMAIL PROTECTED]> wrote:
> > > On Thu, 2007-08-16 at 11:16 +0200, Miguel Ojeda wrote:
> > > > I think you coul
MACK is useful for sensitivity, integrity, and a variety
+ of other madatory security schemes.
+ If you are unsure how to answer this question, answer N.
+
change:
+ of other madatory security schemes.
to:
+ of other mandatory security schemes.
--
On 12/21/06, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Wed, 20 Dec 2006 15:10:00 +0100
Miguel Ojeda Sandonis <[EMAIL PROTECTED]> wrote:
> Andrew, another one for drivers-add-lcd-support saga. Thanks you.
This patch appears to be against some private tree of yours, not agai
t-update10.patch.draft
Signed-off-by: Miguel Ojeda Sandonis <[EMAIL PROTECTED]>
---
diff --git a/drivers/auxdisplay/cfag12864b.c b/drivers/auxdisplay/cfag12864b.c
index 889583d..cb44cb4 100644
--- a/drivers/auxdisplay/cfag12864b.c
+++ b/drivers/auxdisplay/cfag12864b.c
@@ -312,6 +312,17 @@ E
), are there fair chances to get samples of devices to
work with?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kern
f a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
As I'm not an expert in any kind of device, so I would like to join
for any device which its type has not been assigned to any person yet
(w
Andrew, Daniel who reported the crash has tested this patch and says that it
works fine avoiding it, so you can merge.
drivers-add-lcd-support-fix-crash-when-built-in-and-no-parport-present.patch
Signed-off-by: Miguel Ojeda Sandonis <[EMAIL PROTECTED]>
---
diff --git a/drivers/auxd
On 2/11/07, Frederik Deweerdt <[EMAIL PROTECTED]> wrote:
On Sat, Feb 10, 2007 at 08:45:26PM +0100, Miguel Ojeda wrote:
> When I was testing some stuff at 2.6.20-rc6-mm3 I found this at dmesg
> multiple times.
>
Could you try this hotfix
http://kernel.org/pub/linux/kernel/people/a
On 2/13/07, Andrew Morton <[EMAIL PROTECTED]> wrote:
On Sat, 10 Feb 2007 20:51:23 +0100 Miguel Ojeda <[EMAIL PROTECTED]>
wrote:
> Andrew, Daniel who reported the crash has tested this patch and says that
it works fine avoiding it, so you can merge.
>
>
drivers-add-lcd-s
e solution looks hacky (I said that I was waiting for a
better solution), and also I think it should be checked by the kernel
at boot like modprobe does; but I don't know any other solution. Any
ideas?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this lis
ree work, without any kind
of feedback. Some others don't care, but they could in the future, as
it is their code, and that is your risk.
PD: Please don't top post.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscrib
ling. Especially when these Kernel
Isn't there a big difference between "use GPL code" and "modify GPL
code, link closed modules to it & redistribute everything as
binaries"?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this lis
On 2/16/07, Scott Preece <[EMAIL PROTECTED]> wrote:
On 2/15/07, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
> Stupid, maybe. But some people just don't want closed-source
> projects/companies like yours using their free work, without any kind
> of feedback. Some others don
rt" message.
Will check.
Thanks for the warning,
Miguel
(forgot to reply to all).
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo in
o export a function at ks0108.c like
ks0108_inited() that would return if the module was properly inited or
not. Is there any better solution?
Regards,
Miguel
On 2/1/07, Miguel Ojeda <[EMAIL PROTECTED]> wrote:
On 1/7/07, Daniel Walker <[EMAIL PROTECTED]> wrote:
> (forgot to
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote:
On Thu, 2007-02-01 at 16:16 +0100, Miguel Ojeda wrote:
> The problem is easy:
>
> ks0108_init() prints the error message and exit with -EINVAL, so the
> module isn't loaded properly.
>
> However, cfag12864b_init
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote:
On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote:
> >
> >
>
> Well, I use the word "module" for both cases: When I modprobe
> cfag12864b, if ks0108 fails, it doesn't get linked. So I thought
On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote:
On Thu, 2007-02-01 at 18:39 +0100, Miguel Ojeda wrote:
> On 2/1/07, Daniel Walker <[EMAIL PROTECTED]> wrote:
> > On Thu, 2007-02-01 at 18:13 +0100, Miguel Ojeda wrote:
> >
> > > >
> > > >
>
should do with Miguel?
I sent a email already. The details will be hammered out.
Right back from exams and with lots of spare time :)
I got your patch, so I'm going to try your patch and exchange all the
"platform_device_*" stuff with your display class and move ks0108,
cfa
i * 1024, cpu1, cpu2);
as it's quite OK to have no spaces in "i*1024", just to indicate
precedence of arithmetic ops. But the good bits dominate in this patch
so lets have it and i'll undo the bad ones.
Ok, I will take care of that for future whitespace cleanups, as I see
t
probe_edid(struct display_device *dev, void *devdata);
+
+#define to_display_device(obj) container_of(obj, struct display_device,
class_dev)
+
+#endif
diff -urN -X fbdev-2.6/Documentation/dontdiff linus-2.6/MAINTAINERS
fbdev-2.6/MAINTAINERS
--- linus-2.6/MAINTAINERS 2006-12-04 04:11:
On 12/6/06, Miguel Ojeda Sandonis <[EMAIL PROTECTED]> wrote:
Ok, here is the patch (against git7+displayclass) which moves auxdisplay/*
to video/display/* and start using the display class.
It is just a draft, but there isn't much code changed from -mm2.
- I would remove "st
ll be able to try again in some hours.
Anyway, the problem is probably at cfag12864bfb.c (as it was almost
the only file I modified from -mm2); but I can't tell where the
problem is as I tried just a few times.
Please review cfag12864bfb_init/_exit to check if your code/class is
intended to be u
=
[ 1593.770931] Code: c0 8d 54 24 08 8d 4c 24 1c 89 4c 24 1c 89 4c 24
20 8b 4c 24 38 89 0c 24 89 e9 8b 44 24 04 e8 3f ff ff ff 83 c4 24 5b
5e 5f 5d c3 ff 08 79 05 e8 1b 01 00 00 c3 f0 ff 00 7f 05 e8 34
00 00 00
[ 1593.770973] EIP: [] mutex_lock+0x0/0xb SS:ESP 0068:e2ae7f48
[ 1593.770979
(\1\[0\]\)" *
but we already have, from "include/linux/kernel.h":
#define ARRAY_SIZE(x) (sizeof(x) / sizeof((x)[0]))
Maybe *(x) instead of (x)[0]?
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-k
e modular (easier understanding, scalability...), so
anyone can easily add a new way to control the LCD without worring
about other unrelated stuff the code.
And while you are there (in the Kconfig file), please change
(hertzs) to (hertz).
Thanks again.
--
Miguel Ojeda
http://maxextreme.googlepages
A,
so people that expects only their primary video/ displays may be
confused if it appears at such section. So we decided to go away from
video/. Maybe we can change the description, as right now it only
refers to front panel lcds.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
not just lcds
or "front panels".
So finally we will have usual-primary fbdevs and video drivers at
"drivers/video/*", and all the other stuff at "drivers/display/*" or
some similar place.
Is that a good suggestion?
[*] I saw fbdevs like "Arc Monochorme LCD board
Trivial patch, against -rc6. Please apply, thanks.
---
CREDITS:
- Summarize 3 lines into one.
- Add webpage.
MAINTAINERS:
- Add auxdisplay drivers/tree webpages.
CREDITS |7 +++
MAINTAINERS |4
2 files changed, 7 insertions(+), 4 deletions(-)
Signed-off-by: Miguel Ojeda
Trivial patch, against -rc6. I don't know if anyone has fixed this by now.
---
drivers/video/Kconfig:
- Spelling: "Frambuffer hardware support"
drivers/video/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Signed-off-by: Miguel Ojeda Sandonis <[EMAIL PR
"Trivial patch, against -rc6. I don't know if anyone has fixed this by now."
Resend comment: Still present in -rc7.
---
drivers/video/Kconfig:
- Spelling: "Frambuffer hardware support"
drivers/video/Kconfig |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
Si
he body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel"
.6.21-rc7 functioniert?
?
The only big difference I see is that you did not set CONFIG_PREEMPT.
However, that should not matter. Any other general options are almost
the same.
(please CC linux-kernel)
thanks,
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
-
To unsubscribe from
On 4/22/07, oliver pinter <[EMAIL PROTECTED]> wrote:
I have CC the kernel
Did you?
and the result is:
your'e config : failed smp
your'e config + power managment : ok
Interesting, can anyone tell me why does not SMP work without Power
Managment? Should it be that way?
Trivial patch, against -rc6. Please apply, thanks.
---
CREDITS:
- Summarize 3 lines into one.
- Add webpage.
MAINTAINERS:
- Add auxdisplay drivers/tree webpages.
CREDITS |7 +++
MAINTAINERS |4
2 files changed, 7 insertions(+), 4 deletions(-)
Signed-off-by: Miguel Ojeda
. It seems the problem is ACPI, however, should not
it be noted in some way? Maybe at Documentation/smp.txt, maybe at the
help section at CONFIG_SMP, maybe a "depends on ..."
Or maybe CONFIG_SMP should enable some bits of the ACPI code needed to
detect such additional cores.
--
Miguel Ojed
at way, the code could be patched, updated and cleaned over the time
(without firing up people), it could be tested without pain, people
would send more bug reports and every work would be centralized.
Reiser4 would get much more attention.
--
Miguel Ojeda
http://maxextreme.googlepages.com/index.htm
On Sun, Aug 5, 2018 at 3:38 AM, Joe Perches wrote:
> On Wed, 2018-08-01 at 19:54 +0200, Miguel Ojeda wrote:
>> From the GCC manual:
>>
>> The nonstring variable attribute specifies that an object or member
>> declaration with type array of char or pointer to char is int
On Sun, Aug 5, 2018 at 11:14 AM, Miguel Ojeda
wrote:
> On Sun, Aug 5, 2018 at 3:38 AM, Joe Perches wrote:
>> On Wed, 2018-08-01 at 19:54 +0200, Miguel Ojeda wrote:
>>> From the GCC manual:
>>>
>>> The nonstring variable attribute specifies that an object or me
On Fri, Jun 22, 2018 at 12:07 PM, Geert Uytterhoeven
wrote:
> Submitters of device tree binding documentation may forget to CC
> the subsystem maintainer if this is missing.
>
> Signed-off-by: Geert Uytterhoeven
Acked-by: Miguel Ojeda
Thanks,
Miguel
> ---
> v3:
> - Upd
Hi Joe,
On Sun, Aug 26, 2018 at 8:50 PM, Joe Perches wrote:
> On Sun, 2018-08-26 at 19:57 +0200, Miguel Ojeda wrote:
>> Instead of using version checks per-compiler to define (or not) each
>> attribute,
>> use __has_attribute to test for them, following the cleanup s
Hi Nick,
On Mon, Aug 27, 2018 at 7:43 PM, Nick Desaulniers
wrote:
> On Sun, Aug 26, 2018 at 10:58 AM Miguel Ojeda
> wrote:
>>
>> Instead of using version checks per-compiler to define (or not) each
>> attribute,
>> use __has_attribute to test for them, foll
Hi Nick,
On Mon, Aug 27, 2018 at 7:48 PM, Nick Desaulniers
wrote:
> On Mon, Aug 27, 2018 at 10:43 AM Nick Desaulniers
>> > +
>> > +/*
>> > + * Optional attributes: your compiler may or may not support them.
>> > + *
>> > + * To check for them, we use __has_attribute, which is supported on gcc
>>
Hi,
On Tue, Aug 28, 2018 at 3:57 PM, Richard Fitzgerald
wrote:
> Reviewed-by: Richard Fitzgerald
>
> A maintainer for MAINTAINERS would help avoid these problems, which will
> tend to happen when changes to the file go through many trees.
>
A year ago Linus committed 7683e9e52 ("Properly alphab
Hi Nick,
On Tue, Aug 28, 2018 at 7:05 PM, Nick Desaulniers
wrote:
> On Tue, Aug 28, 2018 at 8:10 AM Miguel Ojeda
> wrote:
>>
>> I addressed that in the email I sent afterwards:
>>
>> """
>> Note that:
>> - assume_aligned came with gcc
Hi Nick,
Actually, to acknowledge the comments to the other email...
On Tue, Aug 28, 2018 at 6:53 PM, Nick Desaulniers
wrote:
> On Tue, Aug 28, 2018 at 8:04 AM Miguel Ojeda
> wrote:
>>
>> Hi Nick,
>>
>> On Mon, Aug 27, 2018 at 7:43 PM, Nick Desaulniers
>>
Hi Kishon,
On Tue, Aug 14, 2018 at 2:53 PM, Kishon Vijay Abraham I wrote:
> Hi,
>
> On Tuesday 14 August 2018 06:19 PM, Ramon Fried wrote:
>> Hi.
>> I recently saw that the PCI endpoint API only supports outbound memory
>> mapping: (AXI -> PCI) through the map_addr op.
>> Why inbound mapping is m
Hi all,
On Fri, Aug 24, 2018 at 1:31 AM, Joe Perches wrote:
> On Thu, 2018-08-23 at 16:12 -0700, Nick Desaulniers wrote:
>> On Thu, Aug 23, 2018 at 2:19 PM Joe Perches wrote:
>> >
>> > On Thu, 2018-08-23 at 14:03 -0700, Nick Desaulniers wrote:
>> > > Not this case; it's how we get gnu89 semantic
ed an x86 allmodconfig for a while with gcc 8.2.0 and 4.6.4.
Cc: Eli Friedman
Cc: Christopher Li
Cc: Kees Cook
Cc: Ingo Molnar
Cc: Geert Uytterhoeven
Cc: Arnd Bergmann
Cc: Greg Kroah-Hartman
Cc: Masahiro Yamada
Cc: Joe Perches
Cc: Dominique Martinet
Cc: Nick Desaulniers
Cc: Linus Torvalds
Hi,
A couple of extra notes on my patch.
On Sun, Aug 26, 2018 at 7:57 PM, Miguel Ojeda
wrote:
> +/*
> + * Optional attributes: your compiler may or may not support them.
> + *
> + * To check for them, we use __has_attribute, which is supported on gcc >= 5,
> + * clang >=
Hi Geert, Martin, all,
On Mon, Jul 30, 2018 at 8:46 AM, Geert Uytterhoeven
wrote:
> Below is the list of build error/warning regressions/improvements in
> v4.18-rc7[1] compared to v4.17[2].
There are quite some -Wstringop-* warnings, so here is some
information that may be useful and/or save tim
As discussed in https://lkml.org/lkml/2018/6/25/877
Signed-off-by: Miguel Ojeda
---
MAINTAINERS | 5 +
1 file changed, 5 insertions(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 0fe4228f78cb..2352788d6852 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -3514,6 +3514,11 @@ M: Dave
Hi Martin,
On Tue, Jul 31, 2018 at 9:59 PM, Martin Sebor wrote:
>
> Thanks for pointing this out!
>
Thanks to *you* for doing all the work behind this!
> The first two calls are diagnosed because GCC uses the size
> of the destination array as the size of the accessed object
> (it would be inva
Hi Geert,
On Wed, Aug 1, 2018 at 8:56 AM, Geert Uytterhoeven wrote:
> Hi Miguel,
>
> On Mon, Jul 30, 2018 at 6:05 PM Miguel Ojeda
> wrote:
>> On Mon, Jul 30, 2018 at 8:46 AM, Geert Uytterhoeven
>> wrote:
>> > Below is the list of build error/warning regressions
Hi Jason,
On Tue, Jul 31, 2018 at 4:59 AM, Jason Gunthorpe wrote:
> On Mon, Jul 30, 2018 at 06:24:31PM +0200, Miguel Ojeda wrote:
>> As discussed in https://lkml.org/lkml/2018/6/25/877
>>
>> Signed-off-by: Miguel Ojeda
>> ---
>> MAINTAINERS | 5 +
ill Deacon
Cc: Greg Kroah-Hartman
Cc: David Rientjes
Cc: Martin Sebor
Cc: Arnd Bergmann
Signed-off-by: Miguel Ojeda
---
Re-sending this since a few months have passed, Martin has improved
GCC's feature and warnings are appearing in Geert's build bot.
Added an example in the second patch as
Let gcc know it is not meant to be NUL-terminated by annotating with
the new __nonstring variable attribute; and remove the comment since it
conveys the same information.
Cc: Willy Tarreau
Cc: Geert Uytterhoeven
Cc: Martin Sebor
Signed-off-by: Miguel Ojeda
---
drivers/auxdisplay/panel.c | 7
On Wed, Aug 1, 2018 at 8:47 PM, Kees Cook wrote:
> On Wed, Aug 1, 2018 at 10:58 AM, Miguel Ojeda
> wrote:
>> Let gcc know it is not meant to be NUL-terminated by annotating with
>> the new __nonstring variable attribute; and remove the comment since it
>> conveys the sa
On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote:
> On 03/09/2018 04:07 PM, Andrew Morton wrote:
>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote:
>>
>>> When max() is used in stack array size calculations from literal values
>>> (e.g. "char foo[max(sizeof(struct1), sizeof(struct2))]", the
On Sat, Mar 10, 2018 at 7:10 AM, Miguel Ojeda
wrote:
> On Sat, Mar 10, 2018 at 4:11 AM, Randy Dunlap wrote:
>> On 03/09/2018 04:07 PM, Andrew Morton wrote:
>>> On Fri, 9 Mar 2018 12:05:36 -0800 Kees Cook wrote:
>>>
>>>> When max() is used in stack arra
On Sat, Mar 10, 2018 at 5:30 PM, Linus Torvalds
wrote:
> On Sat, Mar 10, 2018 at 7:33 AM, Kees Cook wrote:
>>
>> Alright, I'm giving up on fixing max(). I'll go back to STACK_MAX() or
>> some other name for the simple macro. Bleh.
>
> Oh, and I'm starting to see the real problem.
>
> It's not tha
On Sat, Mar 10, 2018 at 6:51 PM, Linus Torvalds
wrote:
>
> So in *historical* context - when a compiler didn't do variable length
> arrays at all - the original semantics of C "constant expressions"
> actually make a ton of sense.
>
> You can basically think of a constant expression as something t
ngFormat.html
https://clang.llvm.org/docs/ClangFormatStyleOptions.html
Cc: Randy Dunlap
Cc: Andy Whitcroft
Cc: Joe Perches
Cc: Jonathan Corbet
Cc: Andrew Morton
Signed-off-by: Miguel Ojeda
---
.clang-format | 107
Walleij
Cc: Randy Dunlap
Signed-off-by: Miguel Ojeda
---
drivers/auxdisplay/arm-charlcd.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/auxdisplay/arm-charlcd.c b/drivers/auxdisplay/arm-charlcd.c
index b3176ee92b90..dde180995582 100644
--- a/drivers/auxdisplay/arm-charlcd.c
+++ b
Commit 7005b58458e4beecaf5efacb872c456bc7d3541a ("Staging: add lcd-panel
driver") introduced the panel driver, which is now in
drivers/auxdisplay.
Cc: Willy Tarreau
Cc: Jonathan Corbet
Signed-off-by: Miguel Ojeda
---
Documentation/{misc-devices => auxdisplay}/lcd-panel-cgram.tx
t;>> wrote:
>>> > On Sat, Feb 17, 2018 at 8:39 PM, Miguel Ojeda
>>> > wrote:
>>> > > Cc: Willy Tarreau
>>> > > Cc: Geert Uytterhoeven
>>> > > Cc: Linus Walleij
>>> > > Cc: Robin van der Gracht
>>> > > Cc: Paul Burton
>>> > > Signed-off-by: Miguel Ojeda
>>> > > ---
Pinging Paul Burton in a couple of emails more...
Cheers,
Miguel
On Tue, Mar 6, 2018 at 12:23 AM, Sai Praneeth Prakhya
wrote:
> From: Sai Praneeth
>
> When a process requests the kernel to execute any efi_runtime_service(),
> the requested efi_runtime_service (represented as an identifier) and its
> arguments are packed into a struct named efi_runtime_work and
On Mon, Mar 5, 2018 at 8:05 PM, Martin Sebor wrote:
> On 03/02/2018 10:36 AM, Miguel Ojeda wrote:
>>
>> On Thu, Mar 1, 2018 at 10:57 AM, Arnd Bergmann wrote:
>>>
>>> On Mon, Feb 19, 2018 at 1:01 AM, Miguel Ojeda
>>> wrote:
>>>>
>>>
\
> - (void) (&min1 == &min2);\
> - min1 < min2 ? min1 : min2; })
> +#define __is_constant(x) \
> + (sizeof(int) == sizeof(*(1 ? ((void*)((long)(x) * 0l)) : (int*)1)))
I think Linus suggested __is_constant, but
On Tue, Mar 27, 2018 at 1:24 PM, Linus Walleij wrote:
> On Tue, Mar 13, 2018 at 12:59 AM, Miguel Ojeda
> wrote:
>
>> There was a missing first line and a missing member,
>> which gave a warning under W=1:
>>
>> CC drivers/auxdisplay/arm-charlcd.o
>>
On Wed, Apr 11, 2018 at 7:37 PM, Randy Dunlap wrote:
> On 04/11/2018 09:24 AM, David Howells wrote:
>
>> diff --git a/security/lock_down.c b/security/lock_down.c
>> new file mode 100644
>> index ..f35ffdd096ad
>> --- /dev/null
>> +++ b/security/lock_down.c
>> @@ -0,0 +1,65 @@
>> +/* Lo
Hi Linus,
Please pull these fixes and cleanups for auxdisplay.
They are recently rebased -- I am not on my main computer.
Cheers,
Miguel Ojeda
The following changes since commit 0adb32858b0bddf4ada5f364a84ed60b196dbcda:
Linux 4.16 (2018-04-01 14:20:27 -0700)
are available in the git
1 - 100 of 835 matches
Mail list logo
