Re: [PATCH v3] net: macb: restart tx after tx used bit read

2018-12-17 Thread Nicolas.Ferre
On 17/12/2018 at 11:02, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > On some platforms (currently detected only on SAMA5D4) TX might stuck > even the pachets are still present in DMA memories and TX start was > issued for them. This happens due to race condition between MACB driver >

Re: [PATCH] regulator: mcp16502: Use #ifdef CONFIG_PM_SLEEP around mcp16502_suspend/resume_noirq

2018-12-21 Thread Nicolas.Ferre
On 20/12/2018 at 14:14, Axel Lin wrote: > mcp16502_suspend/resume_noirq is only used by SET_NOIRQ_SYSTEM_SLEEP_PM_OPS > when CONFIG_PM_SLEEP is defined. > So use #ifdef CONFIG_PM_SLEEP instead CONFIG_SUSPEND guard. > > Signed-off-by: Axel Lin I'm not against this patch and don't know the habits

[PATCH] ARM: dts: at91: sama5d2/trivial: fix letter case for etm hex address

2021-04-08 Thread nicolas.ferre
From: Nicolas Ferre Fix the etm node hex address to lower case for matching regexp specification and removing the additional warning that looks like: arch/arm/boot/dts/at91-sama5d2_ptc_ek.dt.yaml: /: 'etm@73C000' does not match any of the regexes: '@(0|[1-9a-f][0-9a-f]*)$', '^[^@]+$', 'pinctrl-[

Re: [PATCH 0/8] ARM: at91/dt: update to existing drivers for the sam9x60 SoC

2019-02-06 Thread Nicolas.Ferre
All, On 16/01/2019 at 10:57, Nicolas Ferre wrote: > Hi, > > This series collects some little modifications to DT bindings and associated > drivers changes for supporting the upcoming SAM9X60 SoC. > > I took the advantage of this series for fixing some of the leftovers in DT > bindings for reset

Re: [PATCH] regulator: mcp16502: Include linux/gpio/consumer.h to fix build error

2019-01-28 Thread Nicolas.Ferre
On 27/01/2019 at 09:51, Axel Lin wrote: > Fix below build error: > drivers/regulator/mcp16502.c: In function ‘mcp16502_gpio_set_mode’: > drivers/regulator/mcp16502.c:135:3: error: implicit declaration of function > ‘gpiod_set_value’; did you mean ‘gpio_set_value’? > [-Werror=implicit-function-dec

Re: [PATCH 2/3] dmaengine: at_xdmac: enhance channel errors handling in tasklet

2019-04-03 Thread Nicolas.Ferre
Vinod, Thanks for your review, I'm preparing v2. On 11/02/2019 at 12:58, Vinod Koul wrote: > On 05-02-19, 12:03, Nicolas Ferre wrote: >> Complement the identification of errors with stoping the channel and >> dumping the descriptor that led to the error case. >> >> Signed-off-by: Nicolas Ferre >

Re: [PATCH v2 1/3] dmaengine: at_xdmac: remove BUG_ON macro in tasklet

2019-04-03 Thread Nicolas.Ferre
Vinod, Please disregard this series: I'm sending a v3 right now. Sorry for the noise. Best regards, Nicolas On 03/04/2019 at 12:09, Nicolas Ferre wrote: > Even if this case shouldn't happen when controller is properly programmed, > it's still better to avoid dumping a kernel Oops for this. >

Re: [PATCH 1/4] ARM: dts: sama5d{2,4}: use SPDX-License-Identifier

2019-04-03 Thread Nicolas.Ferre
On 03/04/2019 at 18:22, Alexandre Belloni wrote: > The X11 license text [1] is explicitly for the X Consortium and has a > couple of extra clauses. The MIT license text [2] is actually what the > current DT files claim. > > [1] https://spdx.org/licenses/X11.html > [2] https://spdx.org/licenses/MIT

Re: [PATCH 1/3] net: ethernet: add support for PCS and 2.5G speed

2019-02-26 Thread Nicolas.Ferre
$subject should begin with "net: macb: " Parshuram, Sorry but NACK on the series. David, This patch series seem pretty intrusive, so I would like that you wait for my explicit ACK before applying even next versions of it. More comments below... On 25/02/2019 at 18:21, Florian Fainelli wrote

Re: [PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

2019-02-26 Thread Nicolas.Ferre
On 25/02/2019 at 22:25, Alexandre Belloni wrote: > Make the driver OF only as since AVR32 has been removed from the kernel, > there are only OF enabled platform using it. > > Signed-off-by: Alexandre Belloni It looks good to me: Acked-by: Nicolas Ferre Thanks Alexandre. Best regards, Nicola

[PATCH] ARM: dts: at91-sama5d27_som1: fix phy address to 7

2021-02-17 Thread nicolas.ferre
From: Claudiu Beznea Fix the phy address to 7 for Ethernet PHY on SAMA5D27 SOM1. No connection established if phy address 0 is used. The board uses the 24 pins version of the KSZ8081RNA part, KSZ8081RNA pin 16 REFCLK as PHYAD bit [2] has weak internal pull-down. But at reset, connected to PD09

[PATCH] ARM: dts: at91: sam9x60: fix mux-mask for PA7 so it can be set to A, B and C

2021-02-18 Thread nicolas.ferre
From: Federico Pellegrin According to the datasheet PA7 can be set to either function A, B or C (see table 6-2 of DS60001579D). The previous value would permit just configuring with function C. Signed-off-by: Federico Pellegrin Fixes: 1e5f532c2737 ("ARM: dts: at91: sam9x60: add device tree for

[PATCH 2/3] ARM: configs: at91: DT/ATAG defconfig modifications

2021-02-05 Thread nicolas.ferre
From: Nicolas Ferre As all AT91 platforms are converted to DT for a long time, adapt the defconfigs by: - removing legacy CONFIG_ATAGS as a DT will always be provided; - removing the CONFIG_ARM_APPENDED_DTB option on SAMA5 devices as the vast majority of systems will use a DT-aware bootloader o

[PATCH 3/3] ARM: configs: at91_dt_defconfig: add useful helper options

2021-02-05 Thread nicolas.ferre
From: Nicolas Ferre Add GPIO, SPI and I2C options that were missing from the at91_dt_defconfig whereas they were in sama5_defconfig. It unifies all AT91 defconfigs with same set of useful options. Signed-off-by: Nicolas Ferre --- arch/arm/configs/at91_dt_defconfig | 3 +++ 1 file changed, 3 in

[PATCH 1/3] ARM: configs: sama5_defconfig: update and remove unneeded options

2021-02-05 Thread nicolas.ferre
From: Nicolas Ferre Kconfig options are not present anymore or selected by default: remove them from sama5_defconfig. No change to kernel compilation expected. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 11 --- 1 file changed, 11 deletions(-) diff --git a/arch

[PATCH 0/7] ARM: configs: at91: updates to defconfigs

2021-03-29 Thread nicolas.ferre
From: Nicolas Ferre Hi, I collected some of the defconfig modifications that we carry in our vendor tree for some time. They are interesting for both users and validation process as most are part of validation plans or CI. Don't hesitate to indicate missing pieces to add to this serries. The

[PATCH 1/7] ARM: configs: at91: sama5: MCP16502 regulator as built-in

2021-03-29 Thread nicolas.ferre
From: Nicolas Ferre This regulator is needed by several SoC or external peripherals on different boards, providing required power rails. Make it built-in to match usual use-cases. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 delet

[PATCH 2/7] ARM: configs: at91: sama5: PIOBU as built-in

2021-03-29 Thread nicolas.ferre
From: Razvan Stefanescu Include as built-in as it's used by multiple boards. Signed-off-by: Razvan Stefanescu [nicolas.fe...@microchip.com: adap to newer kernel] Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 5/7] ARM: configs: at91: Add mtd tests as modules

2021-03-29 Thread nicolas.ferre
From: Nicolas Ferre Add MTD tests as they are used in CI and for validation plan. Signed-off-by: Nicolas Ferre --- arch/arm/configs/at91_dt_defconfig | 1 + arch/arm/configs/sama5_defconfig | 1 + 2 files changed, 2 insertions(+) diff --git a/arch/arm/configs/at91_dt_defconfig b/arch/arm/c

[PATCH 3/7] ARM: configs: at91: sama5: Enable LAN78XX as module

2021-03-29 Thread nicolas.ferre
From: Razvan Stefanescu Include this driver as the USB-Ethernet chip is present on SAMA5D2-ICP board. Signed-off-by: Razvan Stefanescu [nicolas.fe...@microchip.com: update commit subject and message] Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 in

[PATCH 7/7] ARM: configs: at91: Modernize UBI defconfig part

2021-03-29 Thread nicolas.ferre
From: Nicolas Ferre UBI_GLUEBI is not so common and UBI_FASTMAP is used for several years. Make them part of a modernization of UBI defconfig options. Signed-off-by: Nicolas Ferre --- arch/arm/configs/at91_dt_defconfig | 2 +- arch/arm/configs/sama5_defconfig | 2 +- 2 files changed, 2 inser

[PATCH 6/7] ARM: configs: at91: Add USB Video webcam class

2021-03-29 Thread nicolas.ferre
From: Nicolas Ferre USB webcams are used during validation process, add them as modules. Signed-off-by: Nicolas Ferre --- arch/arm/configs/at91_dt_defconfig | 2 ++ arch/arm/configs/sama5_defconfig | 2 ++ 2 files changed, 4 insertions(+) diff --git a/arch/arm/configs/at91_dt_defconfig b/a

[PATCH 4/7] ARM: configs: at91: sama5: Add audio MIKROE PROTO board

2021-03-29 Thread nicolas.ferre
From: Codrin Ciubotariu Add this board as a module as it's useful for testing audio on multiple AT91 boards. Signed-off-by: Codrin Ciubotariu [nicolas.fe...@microchip.com: adap to newer kernel] Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertio

[GIT PULL] ARM: at91: dt for 5.13

2021-04-07 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here is first batch of dt changes for 5.13. Please pull. Thanks, best regards, Nicolas The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) are available in the Git repository at: git://

[GIT PULL] ARM: at91: soc for 5.13

2021-04-01 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, One single patch for now on our SoC branch. Stakeholders agreed to make it travel with at91 -> arm-soc. Thanks, best regards, Nicolas The following changes since commit a38fd8748464831584a19438cbb3082b5a2dab15: Linux 5.12-rc2 (2021-03-05 17:33:41 -0800) ar

[GIT PULL] ARM: at91: defconfig for 5.13

2021-04-01 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here are the defconfig changes for 5.13 which is bigger than usual for aligning with options that we use frequently and some changes which will be beneficial for CI. There is an update with savedefconfig included, tell me if you prefer the PR without this first pa

[PATCH] ARM: dts: at91: change the key code of the gpio key

2021-04-02 Thread nicolas.ferre
From: Ludovic Desroches Having a button code and not a key code causes issues with libinput. udev won't set ID_INPUT_KEY. If it is forced, then it causes a bug within libinput. Signed-off-by: Ludovic Desroches Signed-off-by: Nicolas Ferre --- arch/arm/boot/dts/at91-sam9x60ek.dts | 3

[PATCH] ARM: dts: at91: sama5d2: add ETB and ETM unit name

2021-04-02 Thread nicolas.ferre
From: Nicolas Ferre Add unit address to the ETB and ETM nodes. It also allow us to get rid of the warnings: ../arch/arm/boot/dts/sama5d2.dtsi:43.6-57.4: Warning (unit_address_vs_reg): /etb: node has a reg or ranges property, but no unit name ../arch/arm/boot/dts/sama5d2.dtsi:59.6-73.4: Warning (

[PATCH] ARM: dts: at91: sama5d2: fix CAN message ram offset and size

2020-12-03 Thread nicolas.ferre
From: Nicolas Ferre CAN0 and CAN1 instances share the same message ram configured at 0x21 on sama5d2 Linux systems. According to current configuration of CAN0, we need 0x1c00 bytes so that the CAN1 don't overlap its message ram: 64 x RX FIFO0 elements => 64 x 72 bytes 32 x TXE (TX Event FIFO)

[PATCH v2] ARM: dts: at91: sam9x60: fix mux-mask to match product's datasheet

2021-03-10 Thread nicolas.ferre
From: Nicolas Ferre Fix the whole mux-mask table according to datasheet for the sam9x60 product. Too much functions for pins were disabled leading to misunderstandings when enabling more peripherals or taking this table as an example for another board. Take advantage of this fix to move the mux-

[GIT PULL] ARM: at91: fixes for 5.12

2021-03-10 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here are some fixes for 5.12. It's not regression vs. previous revision, this is why I send them early in the cycle. I based my branch on top of 5.12-rc2 because I noticed that your "master" branch was pointing to it (and of course the "-dontuse" suffix from Linus

[PATCH] ARM: dts: at91: sam9x60: fix mux-mask to match product's datasheet

2021-03-08 Thread nicolas.ferre
From: Nicolas Ferre Fix the whole mux-mask table according to datasheet for the sam9x60 product. Too much functions for pins were disabled leading to misunderstandings when enabling more peripherals or taking this table as an example for another board. Signed-off-by: Nicolas Ferre Fixes: 1e5f5

[GIT PULL] ARM: at91: soc for 5.12

2021-01-22 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, I'm taking back the lead on sending the pull-requests for AT91 and hope that I didn't loose the knowledge in the meantime. Tell me if there's something I'm missing. Thanks a lot to Alexandre who kept our flow steady and very predictable during all those years! He

[GIT PULL] ARM: at91: defconfig for 5.12

2021-01-22 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here are the defconfig changes for 5.12 which contains the removal of old wrapper code that we called tclib. No such config option to be used anymore in next kernel. Thanks, best regards, The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5

[GIT PULL] ARM: at91: dt for 5.12

2021-01-22 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here is the first batch of dt changes for 5.12. As for the SoC PR, I plan to do another one by mid-next-week. Tell me if it's fine with you. Thanks, best regards, The following changes since commit 5c8fe583cce542aa0b84adc939ce85293de36e5e: Linux 5.11-rc1 (202

[PATCH] ARM: configs: at91_dt_defconfig: add ov7740 module

2021-02-05 Thread nicolas.ferre
From: Nicolas Ferre Add OV7740 as a module as it's useful testing camera sensors on sam9x60ek for instance. Unify with sama5_defconfig as well. Signed-off-by: Nicolas Ferre --- arch/arm/configs/at91_dt_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/at91_dt_defco

[PATCH] ARM: configs: sama5_defconfig: add QSPI driver

2021-02-08 Thread nicolas.ferre
From: Nicolas Ferre Add Quad SPI driver to the sama5 defconfig. This driver is needed for sama5d2 SoC. Signed-off-by: Nicolas Ferre --- arch/arm/configs/sama5_defconfig | 1 + 1 file changed, 1 insertion(+) diff --git a/arch/arm/configs/sama5_defconfig b/arch/arm/configs/sama5_defconfig index

[GIT PULL] ARM: at91: defconfig for 5.12 #2

2021-02-08 Thread nicolas.ferre
From: Nicolas Ferre Arnd, Olof, Here is the second batch of defconfig changes for 5.12. Thanks, best regards, Nicolas The following changes since commit 00a1aa475f507454fab82f02c6230c8fb2312a12: ARM: configs: multi_{v5,v7}: remove ATMEL_TCLIB (2021-01-02 14:06:48 +0100) are available in

[PATCH] ARM: dts: at91-sama5d27_wlsom1: add i2c recovery

2021-01-17 Thread nicolas.ferre
From: Nicolas Ferre Add the i2c gpio pinctrls to support the i2c bus recovery on this board. Signed-off-by: Nicolas Ferre Reviewed-by: Codrin Ciubotariu --- arch/arm/boot/dts/at91-sama5d27_wlsom1.dtsi | 22 +++-- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/a

Re: [PATCH v3] MAINTAINERS: Add Kamel Bouhara as TCB counter driver maintainer

2020-11-23 Thread Nicolas.Ferre
On 21/11/2020 at 19:58, William Breathitt Gray wrote: > Acked-by: Kamel Bouhara > Signed-off-by: William Breathitt Gray > --- > Changes in v3: >- Reorder entries to match preferred MAINTAINERS ordering > > MAINTAINERS | 7 +++ > 1 file changed, 7 insertions(+) > > diff --git a/MAIN

Re: [PATCH][next] can: at91_can: mark expected switch fall-throughs

2019-02-11 Thread Nicolas.Ferre
On 08/02/2019 at 19:44, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch > cases where we are expecting to fall through. > > Notice that, in this particular case, the /* fall through */ > comments are placed at the bottom of the case statement, which > is

Re: [PATCH] video: fbdev: atmel_lcdfb: drop AVR and platform_data support

2019-03-18 Thread Nicolas.Ferre
On 25/02/2019 at 22:25, Alexandre Belloni wrote: > Make the driver OF only as since AVR32 has been removed from the kernel, > there are only OF enabled platform using it. > > Signed-off-by: Alexandre Belloni In case it's needed: Acked-by: Nicolas Ferre > --- > drivers/video/fbdev/Kconfig

Re: [PATCH v2] clk: at91: fix programmable clock for sama5d2

2019-03-19 Thread Nicolas.Ferre
Stephen, Thanks for the review On 18/03/2019 at 20:54, Stephen Boyd wrote: > Quoting Nicolas Ferre (2019-03-18 03:50:45) >> From: Matthias Wieloch >> >> The prescaler formula of the programmable clock has changed for sama5d2. >> Update >> the driver accordingly. >> >> Fixes: a2038077de9a ("clk:

Re: [PATCH] MAINTAINERS: Update path to tcb_clksrc.c

2019-08-23 Thread Nicolas.Ferre
On 14/08/2019 at 11:08, Alexandre Belloni wrote: > External E-Mail > > > On 13/08/2019 08:11:23+, Nicolas Ferre wrote: >> On 13/08/2019 at 08:10, Denis Efremov wrote: >>> Update MAINTAINERS record to reflect the filename change >>> from tcb_clksrc.c to timer-atmel-tcb.c >>> >>> Cc: Nicolas Fe

Re: Status of Subsystems - MICROCHIP SAMA5D2-COMPATIBLE PIOBU GPIO

2019-08-23 Thread Nicolas.Ferre
Sebastian, On 20/08/2019 at 15:27, Sebastian Duda wrote: > Hello Andrei, > > in my master thesis, I'm using the association of subsystems to > maintainers/reviewers and its status given in the MAINTAINERS file. > During the research I noticed that there are several subsystems without > a status i

Re: [PATCH] clk: at91: allow 24 Mhz clock as input for PLL

2019-09-11 Thread Nicolas.Ferre
On 11/09/2019 at 08:39, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > The PLL input range needs to be able to allow 24 Mhz crystal as input > Update the range accordingly in plla characteristics struct > > Signed-off-by: Eugen Hristev Acked-by: Nicolas Ferre Thanks Eugen! Best rega

Re: [PATCH] clk: at91: sam9x60: fix programmable clock

2019-09-24 Thread Nicolas.Ferre
On 24/09/2019 at 12:39, Eugen Hristev - M18282 wrote: > From: Eugen Hristev > > The prescaler mask for sam9x60 must be 0xff (8 bits). > Being set to 0, means that we cannot set any prescaler, thus the > programmable clocks do not work (except the case with prescaler 0) > Set the mask accordingly

Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000

2019-08-20 Thread Nicolas.Ferre
On 20/08/2019 at 11:10, Andreas Schwab wrote: > External E-Mail > > > On Aug 13 2019, Paul Walmsley wrote: > >> Dave, Nicolas, >> >> On Mon, 22 Jul 2019, Yash Shah wrote: >> >>> On Fri, Jul 19, 2019 at 5:36 PM wrote: On 19/07/2019 at 13:10, Yash Shah wrote: > Update the compatibi

Re: [PATCH net v3] net: macb: fix an issue about leak related system resources

2020-05-03 Thread Nicolas.Ferre
On 03/05/2020 at 14:32, Dejin Zheng wrote: > A call of the function macb_init() can fail in the function > fu540_c000_init. The related system resources were not released > then. use devm_platform_ioremap_resource() to replace ioremap() > to fix it. > > Fixes: c218ad559020ff9 ("macb: Add support f

[PATCH v3 3/7] net: macb: fix macb_get/set_wol() when moving to phylink

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Keep previous function goals and integrate phylink actions to them. phylink_ethtool_get_wol() is not enough to figure out if Ethernet driver supports Wake-on-Lan. Initialization of "supported" and "wolopts" members is done in phylink function, no need to keep them in calling

[PATCH v3 2/7] net: macb: mark device wake capable when "magic-packet" property present

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Change the way the "magic-packet" DT property is handled in the macb_probe() function, matching DT binding documentation. Now we mark the device as "wakeup capable" instead of calling the device_init_wakeup() function that would enable the wakeup source. For Ethernet WoL, ena

[PATCH v3 7/7] net: macb: Add WoL interrupt support for MACB type of Ethernet controller

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Handle the Wake-on-Lan interrupt for the Cadence MACB Ethernet controller. As we do for the GEM version, we handle of WoL interrupt in a specialized interrupt handler for MACB version that is positionned just between suspend() and resume() calls. Cc: Claudiu Beznea Cc: Harin

[PATCH v3 6/7] net: macb: WoL support for GEM type of Ethernet controller

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Adapt the Wake-on-Lan feature to the Cadence GEM Ethernet controller. This controller has different register layout and cannot be handled by previous code. We disable completely interrupts on all the queues but the queue 0. Handling of WoL interrupt is done in another interrup

[PATCH v3 4/7] net: macb: fix macb_suspend() by removing call to netif_carrier_off()

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre As we now use the phylink call to phylink_stop() in the non-WoL path, there is no need for this call to netif_carrier_off() anymore. It can disturb the underlying phylink FSM. Fixes: 7897b071ac3b ("net: macb: convert to phylink") Cc: Claudiu Beznea Cc: Harini Katakam Cc: An

[PATCH v3 0/7] net: macb: Wake-on-Lan magic packet fixes and GEM handling

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Hi, Here is the 3rd series to fix WoL magic-packet on the current macb driver. I also add, in the second part of this series the feature to GEM types of IPs. Please tell me if they should be separated; but the two last patches cannot go without the 5 fixes first ones. MACB an

[PATCH v3 5/7] net: macb: fix call to pm_runtime in the suspend/resume functions

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre The calls to pm_runtime_force_suspend/resume() functions are only relevant if the device is not configured to act as a WoL wakeup source. Add the device_may_wakeup() test before calling them. Fixes: 3e2a5e153906 ("net: macb: add wake-on-lan support via magic packet") Cc: Clau

[PATCH v3 1/7] net: macb: fix wakeup test in runtime suspend/resume routines

2020-05-04 Thread nicolas.ferre
From: Nicolas Ferre Use the proper struct device pointer to check if the wakeup flag and wakeup source are positioned. Use the one passed by function call which is equivalent to &bp->dev->dev.parent. It's preventing the trigger of a spurious interrupt in case the Wake-on-Lan feature is used. Fi

Re: [PATCH] ARM: configs: at91: unselect PIT

2019-10-10 Thread Nicolas.Ferre
On 09/10/2019 at 21:48, Alexandre Belloni wrote: > The PIT is not required anymore to successfully boot and may actually harm > in case preempt-rt is used because the PIT interrupt is shared. > Disable it so the TCB clocksource is used. > > Signed-off-by: Alexandre Belloni Acked-by: Nicolas Fer

Re: [PATCH] USB: host: ohci-at91: Remove unused variable regs in at91_stop_hc

2019-10-14 Thread Nicolas.Ferre
On 11/10/2019 at 20:59, Nathan Chancellor wrote: > drivers/usb/host/ohci-at91.c:118:28: warning: unused variable 'regs' > [-Wunused-variable] > struct ohci_regs __iomem *regs = hcd->regs; >^ > 1 warning generated. > > Fixes: 9c4567fa0a44 ("USB: host: oh

Re: [PATCH] clk: at91: fix at91sam9x5 peripheral clock number

2019-02-20 Thread Nicolas.Ferre
On 19/02/2019 at 17:51, Alexandre Belloni wrote: > nck() looks at the last id in an array and unfortunately, > at91sam9x35_periphck has a sentinel, hence the id is 0 and the calculated Well, the logic for all other SoC clk files is to not have such a sentinel and deal differently with this type o

Re: [PATCH] clk: at91: fix at91sam9x5 peripheral clock number

2019-02-20 Thread Nicolas.Ferre
On 20/02/2019 at 11:29, Alexandre Belloni wrote: > On 20/02/2019 10:20:28+, Nicolas Ferre wrote: >> On 19/02/2019 at 17:51, Alexandre Belloni wrote: >>> nck() looks at the last id in an array and unfortunately, >>> at91sam9x35_periphck has a sentinel, hence the id is 0 and the calculated >> >>

Re: [PATCH] clk: at91: fix at91sam9x5 peripheral clock number

2019-02-20 Thread Nicolas.Ferre
On 19/02/2019 at 17:51, Alexandre Belloni wrote: > nck() looks at the last id in an array and unfortunately, > at91sam9x35_periphck has a sentinel, hence the id is 0 and the calculated > number of peripheral clocks is 1 instead of a maximum of 31. > > Fixes: 1eabdc2f9dd8 ("clk: at91: add at91sam9x

Re: [PATCH] clk: at91: fix masterck name

2019-02-20 Thread Nicolas.Ferre
On 08/02/2019 at 16:53, nicolas.fe...@microchip.com wrote: > On 08/02/2019 at 15:40, Alexandre Belloni wrote: >> The master clock is actually named masterck earlier in the driver. Having >> "mck" in the parent list means that it can never be selected. >> >> Fixes: 1eabdc2f9dd8 ("clk: at91: add at91

Re: [PATCH] clk: at91: fix masterck name

2019-02-08 Thread Nicolas.Ferre
On 08/02/2019 at 15:40, Alexandre Belloni wrote: > The master clock is actually named masterck earlier in the driver. Having > "mck" in the parent list means that it can never be selected. > > Fixes: 1eabdc2f9dd8 ("clk: at91: add at91sam9x5 PMCs driver") > Fixes: a2038077de9a ("clk: at91: add sama

Re: [PATCH 2/8] dt-bindings: arm: atmel: add new sam9x60 reset controller binding

2019-01-22 Thread Nicolas.Ferre
Hi Rob, On 22/01/2019 at 02:07, Rob Herring wrote: > On Wed, Jan 16, 2019 at 10:57:38AM +0100, Nicolas Ferre wrote: >> Update the Reset Controller's binding to add new SoC compatibility string. >> >> Signed-off-by: Nicolas Ferre >> --- >> Documentation/devicetree/bindings/arm/atmel-sysregs.txt

Re: [PATCH 4/8] net/macb: bindings doc/trivial: fix documentation for sama5d3 10/100 interface

2019-01-22 Thread Nicolas.Ferre
Hi Rob, On 22/01/2019 at 02:10, Rob Herring wrote: > On Wed, Jan 16, 2019 at 10:57:40AM +0100, Nicolas Ferre wrote: >> This removes a line left while adding the correct compatibility string for >> sama5d3 10/100 interface. Now use the "atmel,sama5d3-macb" string. >> >> Signed-off-by: Nicolas Ferre

Re: [PATCH v4 2/2] spi-atmel: support inter-word delay

2019-01-29 Thread Nicolas.Ferre
On 29/01/2019 at 09:38, Jonas Bonn wrote: > If the SPI slave requires an inter-word delay, configure the DLYBCT > register accordingly. > > Tested on a SAMA5D2 board (derived from SAMA5D2-Xplained reference > board). > > Signed-off-by: Jonas Bonn > CC: Nicolas Ferre > CC: Mark Brown > CC: Alex

Re: [PATCH] can: mark expected switch fall-throughs

2019-01-30 Thread Nicolas.Ferre
On 29/01/2019 at 19:06, Gustavo A. R. Silva wrote: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > This patch fixes the following warnings: > > drivers/net/can/peak_canfd/peak_pciefd_main.c:668:3: warning: this statement > may

Re: [PATCH v5 2/2] spi-atmel: support inter-word delay

2019-01-30 Thread Nicolas.Ferre
On 29/01/2019 at 21:55, Jonas Bonn wrote: > If the SPI slave requires an inter-word delay, configure the DLYBCT > register accordingly. > > Tested on a SAMA5D2 board (derived from SAMA5D2-Xplained reference > board). > > Signed-off-by: Jonas Bonn > CC: Nicolas Ferre > CC: Mark Brown > CC: Alex

Re: [PATCH 05/18] macb_main: pass struct device to DMA API functions

2019-02-01 Thread Nicolas.Ferre
On 01/02/2019 at 09:47, Christoph Hellwig wrote: > The DMA API generally relies on a struct device to work properly, and > only barely works without one for legacy reasons. Pass the easily > available struct device from the platform_device to remedy this. > > Signed-off-by: Christoph Hellwig Ac

Re: [PATCH 6/8] power: reset: at91-reset: add support for sam9x60 SoC

2019-01-24 Thread Nicolas.Ferre
Hi Sebastian, On 23/01/2019 at 19:34, Sebastian Reichel wrote: > Hi, > > On Wed, Jan 16, 2019 at 10:57:42AM +0100, Nicolas Ferre wrote: >> Add support for additional reset causes and the proper compatibility >> string for sam9x60 SoC. The restart function is the same as the samx7. >> >> Signed-of

Re: [PATCH 8/8] net: macb: add sam9x60-macb compatibility string

2019-01-25 Thread Nicolas.Ferre
Hi David, On 16/01/2019 at 10:57, Nicolas Ferre wrote: > Add a new compatibility string for this product. It's using > at91sam9260-macb layout but has a newer hardware revision: it's safer > to use its own string. > > Signed-off-by: Nicolas Ferre I'm thinking of pushing this patch with the othe

Re: [PATCH] net: macb: Apply RXUBR workaround only to versions with errata

2019-01-25 Thread Nicolas.Ferre
On 24/01/2019 at 14:38, Harini Katakam wrote: > The interrupt handler contains a workaround for RX hang applicable > to Zynq and AT91 only. Subsequent versions do not need this AT91RM9200 only. It's not the case for other AT91 SoCs (reading errata list for them). That being said I have to add a

Re: [PATCH v2 1/4] ARM: dts: sama5d{2,4}: use SPDX-License-Identifier

2019-04-04 Thread Nicolas.Ferre
On 03/04/2019 at 22:52, Alexandre Belloni wrote: > External E-Mail > > > The X11 license text [1] is explicitly for the X Consortium and has a > couple of extra clauses. The MIT license text [2] is actually what the > current DT files claim. > > [1] https://spdx.org/licenses/X11.html > [2] https

Re: [PATCH 1/5] dt-bindings: arm: atmel: add bindings for PIT64B

2019-04-01 Thread Nicolas.Ferre
On 14/03/2019 at 17:26, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add device tree bindings for PIT64B timer. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.txt | 7 +++ > 1 file changed, 7 insertion

Re: [PATCH 2/5] clocksource/drivers/timer-microchip-pit64b: add Microchip PIT64B support

2019-04-01 Thread Nicolas.Ferre
On 14/03/2019 at 17:26, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add driver for Microchip PIT64B timer. Timer could be used in continuous > mode or oneshot mode. The hardware has 2x32 bit registers for period > emulating a 64 bit timer. The LSB_PR and MSB_PR registers are used to

Re: [PATCH 4/5] MAINTAINERS: add myself as maintainer

2019-04-01 Thread Nicolas.Ferre
On 14/03/2019 at 17:26, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add myself as maintainer for Microchip timers and clocksource > drivers. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre Thanks Claudiu! > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+)

Re: [PATCH 5/5] MAINTAINERS: add timer-microchip-pit64c.c

2019-04-01 Thread Nicolas.Ferre
On 14/03/2019 at 17:26, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add timer-microchip-pit64b.c as maintained file. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/MAINTAINERS b/MAINTAIN

Re: [PATCH 3/5] MAINTAINERS: change section name to be more generic

2019-04-01 Thread Nicolas.Ferre
On 14/03/2019 at 17:26, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Change Microchip timers section name to be more generic. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > MAINTAINERS | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [PATCH] net: macb: Change interrupt and napi enable order in open

2019-05-07 Thread Nicolas.Ferre
On 07/05/2019 at 16:29, Harini Katakam wrote: > External E-Mail > > > Current order in open: > -> Enable interrupts (macb_init_hw) > -> Enable NAPI > -> Start PHY > > Sequence of RX handling: > -> RX interrupt occurs > -> Interrupt is cleared and interrupt bits disabled in handler > -> NAPI is s

Re: [PATCH] MAINTAINERS: Update path to tcb_clksrc.c

2019-08-13 Thread Nicolas.Ferre
On 13/08/2019 at 08:10, Denis Efremov wrote: > Update MAINTAINERS record to reflect the filename change > from tcb_clksrc.c to timer-atmel-tcb.c > > Cc: Nicolas Ferre Acked-by: Nicolas Ferre But, while you're at it, I would add another line: see below... > Cc: Alexandre Belloni > Cc: linux-ar

Re: [PATCH 1/2] net: macb: Fix compilation on systems without COMMON_CLK

2019-06-24 Thread Nicolas.Ferre
On 24/06/2019 at 08:16, Palmer Dabbelt wrote: > External E-Mail > > > The patch to add support for the FU540-C000 added a dependency on > COMMON_CLK, but didn't express that via Kconfig. This fixes the build > failure by adding CONFIG_MACB_FU540, which depends on COMMON_CLK and > conditionally e

Re: [PATCH 2/2] net: macb: Kconfig: Rename Atmel to Cadence

2019-06-24 Thread Nicolas.Ferre
On 24/06/2019 at 08:16, Palmer Dabbelt wrote: > External E-Mail > > > When touching the Kconfig for this driver I noticed that both the > Kconfig help text and a comment referred to this being an Atmel driver. > As far as I know, this is a Cadence driver. The fix is just Indeed: was written and

Re: [PATCH 1/2] net: macb: Fix compilation on systems without COMMON_CLK

2019-06-24 Thread Nicolas.Ferre
On 24/06/2019 at 11:57, Palmer Dabbelt wrote: > External E-Mail > > > On Mon, 24 Jun 2019 02:40:21 PDT (-0700), nicolas.fe...@microchip.com wrote: >> On 24/06/2019 at 08:16, Palmer Dabbelt wrote: >>> External E-Mail >>> >>> >>> The patch to add support for the FU540-C000 added a dependency on >>>

Re: [PATCH 1/2] net/macb: bindings doc: add sifive fu540-c000 binding

2019-06-24 Thread Nicolas.Ferre
On 23/05/2019 at 22:50, Rob Herring wrote: > On Thu, May 23, 2019 at 6:46 AM Yash Shah wrote: >> >> Add the compatibility string documentation for SiFive FU540-C >> interface. >> On the FU540, this driver also needs to read and write registers in a >> management IP block that monitors or drive

Re: [PATCH 2/2] net: macb: Kconfig: Rename Atmel to Cadence

2019-06-24 Thread Nicolas.Ferre
On 24/06/2019 at 11:57, Palmer Dabbelt wrote: > External E-Mail > > > On Mon, 24 Jun 2019 02:49:16 PDT (-0700), nicolas.fe...@microchip.com wrote: >> On 24/06/2019 at 08:16, Palmer Dabbelt wrote: >>> External E-Mail >>> >>> >>> When touching the Kconfig for this driver I noticed that both the >>>

Re: [PATCH net] net: macb: do not copy the mac address if NULL

2019-06-24 Thread Nicolas.Ferre
On 21/06/2019 at 17:26, Antoine Tenart wrote: > This patch fixes the MAC address setup in the probe. The MAC address > retrieved using of_get_mac_address was checked for not containing an > error, but it may also be NULL which wasn't tested. Fix it by replacing > IS_ERR with IS_ERR_OR_NULL. > > Fi

Re: [PATCH net-next] net: macb: use NAPI_POLL_WEIGHT

2019-06-24 Thread Nicolas.Ferre
On 21/06/2019 at 17:28, Antoine Tenart wrote: > Use NAPI_POLL_WEIGHT, the default NAPI poll() weight instead of > redefining our own value (which turns out to be 64 as well). > > Signed-off-by: Antoine Tenart Acked-by: Nicolas Ferre > --- > drivers/net/ethernet/cadence/macb_main.c | 2 +- >

Re: [PATCH v2 1/2] net: macb: Kconfig: Make MACB depend on COMMON_CLK

2019-06-25 Thread Nicolas.Ferre
On 25/06/2019 at 10:48, Palmer Dabbelt wrote: > commit c218ad559020 ("macb: Add support for SiFive FU540-C000") added a > dependency on the common clock framework to the macb driver, but didn't > express that dependency in Kconfig. As a result macb now fails to > compile on systems without COMMON_

Re: [PATCH v2 2/2] net: macb: Kconfig: Rename Atmel to Cadence

2019-06-25 Thread Nicolas.Ferre
On 25/06/2019 at 10:48, Palmer Dabbelt wrote: > The help text makes it look like NET_VENDOR_CADENCE enables support for > Atmel devices, when in reality it's a driver written by Atmel that > supports Cadence devices. This may confuse users that have this device > on a non-Atmel SoC. > > The fix i

Re: [RESEND][PATCH] clk: at91: generated: Truncate divisor to GENERATED_MAX_DIV + 1

2019-07-03 Thread Nicolas.Ferre
On 25/06/2019 at 11:10, Codrin Ciubotariu wrote: > In clk_generated_determine_rate(), if the divisor is greater than > GENERATED_MAX_DIV + 1, then the wrong best_rate will be returned. > If clk_generated_set_rate() will be called later with this wrong > rate, it will return -EINVAL, so the generate

Re: [PATCH v2] ARM: configs: Remove useless UEVENT_HELPER_PATH

2019-06-06 Thread Nicolas.Ferre
On 04/06/2019 at 10:14, Krzysztof Kozlowski wrote: > Remove the CONFIG_UEVENT_HELPER_PATH because: > 1. It is disabled since commit 1be01d4a5714 ("driver: base: Disable > CONFIG_UEVENT_HELPER by default") as its dependency (UEVENT_HELPER) was > made default to 'n', > 2. It is not recommende

Re: [PATCH 1/3] macb: bindings doc: update sifive fu540-c000 binding

2019-07-19 Thread Nicolas.Ferre
On 19/07/2019 at 13:10, Yash Shah wrote: > As per the discussion with Nicolas Ferre, rename the compatible property > to a more appropriate and specific string. > LINK: https://lkml.org/lkml/2019/7/17/200 > > Signed-off-by: Yash Shah Acked-by: Nicolas Ferre > --- > Documentation/devicetree/b

Re: [PATCH 2/3] macb: Update compatibility string for SiFive FU540-C000

2019-07-19 Thread Nicolas.Ferre
On 19/07/2019 at 13:10, Yash Shah wrote: > Update the compatibility string for SiFive FU540-C000 as per the new > string updated in the binding doc. > Reference: https://lkml.org/lkml/2019/7/17/200 Maybe referring to lore.kernel.org is better: https://lore.kernel.org/netdev/caj2_jofevzqat0yprg4hem

Re: [PATCH] ARM: dts: at91: Fix typo in ISC_D0 on PC9

2019-03-11 Thread Nicolas.Ferre
On 11/03/2019 at 08:57, David Engraf wrote: > The function argument for the ISC_D0 on PC9 was incorrect. According to > the documentation it should be 'C' aka 3. > > Signed-off-by: David Engraf Reviewed-by: Nicolas Ferre Fixes: 7f16cb676c00 ("ARM: at91/dt: add sama5d2 pinmux") Cc: # v4.4+ >

Re: [PATCH v2 3/3] dt-bindings: arm: atmel: add binding for SAM9X60 shutdown controller

2019-02-21 Thread Nicolas.Ferre
On 21/02/2019 at 14:45, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add documentation for SAM9X60 shutdown controller. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre Thanks Claudiu. Regards, Nicolas > --- > Documentation/devicetree/bindings/arm/atmel-sysregs.tx

Re: [PATCH] regulator: mcp16502: Remove module version

2019-02-25 Thread Nicolas.Ferre
On 24/02/2019 at 07:41, Axel Lin wrote: > The module version is unlikely to be updated, use kernel version should be > enough. > > Signed-off-by: Axel Lin Acked-by: Nicolas Ferre > --- > drivers/regulator/mcp16502.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/regulator/m

Re: [PATCH 1/6] rtc: at91sam9: drop platform_data support

2019-03-21 Thread Nicolas.Ferre
On 20/03/2019 at 13:40, Alexandre Belloni wrote: > ARCH_AT91 is DT only for a while, drop platform data support. > > Signed-off-by: Alexandre Belloni For the whole series: Acked-by: Nicolas Ferre > --- > drivers/rtc/Kconfig| 2 +- > drivers/rtc/rtc-at91sam9.c | 44 +++

Re: [PATCH 2/3] power: reset: at91-poweroff: add support for SAM9X60

2019-02-18 Thread Nicolas.Ferre
On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add support for SAM9X60 shutdown controller. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > drivers/power/reset/at91-sama5d2_shdwc.c | 11 +++ > 1 file changed, 11 insertions(+) >

Re: [PATCH 1/3] power: reset: at91-poweroff: add RTT wakeup capability

2019-02-18 Thread Nicolas.Ferre
On 14/02/2019 at 12:24, Claudiu Beznea - M18063 wrote: > From: Claudiu Beznea > > Add RTT wakeup capability. > > Signed-off-by: Claudiu Beznea Acked-by: Nicolas Ferre > --- > drivers/power/reset/at91-sama5d2_shdwc.c | 14 ++ > 1 file changed, 14 insertions(+) > > diff --git a

  1   2   >