Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

2017-08-17 Thread msuchanek
On Thu, 17 Aug 2017 22:14:30 +0200 Michal Suchanek wrote: > Remove quotes from argument value only if there is qoute on both > sides. > > Signed-off-by: Michal Suchanek > --- > arch/powerpc/kernel/fadump.c | 6 ++ > lib/cmdline.c| 7 ++- > 2 files changed, 4 insertions(

Re: [RFT PATCH] tpm: ibmvtpm: simplify crq initialization and document crq format

2017-08-17 Thread msuchanek
ping? On Fri, 24 Feb 2017 20:35:16 +0100 Michal Suchanek wrote: > The crq is passed in registers and is the same on BE and LE hosts. > However, current implementation allocates a structure on-stack to > represent the crq, initializes the members swapping them to BE, and > loads the structure swa

Re: [PATCH v2 0/9] Serial slave device bus

2017-01-19 Thread msuchanek
On 2017-01-16 23:54, Rob Herring wrote: Here's a new version of the serdev bus support with all the review feedback so far incorporated. I've left it named serdev for now pending any further votes one way or the other, but I did rename the sysfs visible portions to "serial". There's still some

Re: ibmvtpm byteswapping inconsistency

2017-01-27 Thread msuchanek
Hello, On 2017-01-27 21:32, Tyrel Datwyler wrote: On 01/27/2017 11:58 AM, Benjamin Herrenschmidt wrote: On Fri, 2017-01-27 at 10:02 -0800, Tyrel Datwyler wrote: The problem is that we are packing an in-memory structure into 2 registers and it's expected that this structure is laid out in the r

Re: [PATCH v7 3/4] lib/cmdline.c Remove quotes symmetrically.

2017-08-24 Thread msuchanek
On Thu, 24 Aug 2017 21:02:47 +1000 Michael Ellerman wrote: > Michal Suchanek writes: > > > Remove quotes from argument value only if there is qoute on both > > sides. > > > > Signed-off-by: Michal Suchanek > > --- > > arch/powerpc/kernel/fadump.c | 6 ++ > > lib/cmdline.c|

Re: [PATCH v7 4/4] boot/param: add pointer to next argument to unknown parameter callback

2017-08-24 Thread msuchanek
On Thu, 24 Aug 2017 21:04:51 +1000 Michael Ellerman wrote: > Michal Suchanek writes: > > > The fadump parameter processing re-does the logic of next_arg quote > > stripping to determine where the argument ends. Pass pointer to the > > next argument instead to make this more robust. > > > > Sign

Re: [tpmdd-devel] [PATCH] tpm: improve tpm_tis send() performance by ignoring burstcount

2017-08-13 Thread msuchanek
Hello, On Fri, 11 Aug 2017 17:32:12 -0400 Ken Goldman wrote: > On 8/9/2017 5:00 PM, Peter Huewe wrote: > > > > Since we are the linux kernel, we do have to care for legacy > > devices. And a system with LPC, PS2Mouse on SuperIO and a TPM are > > not that uncommon. > > > > And heck, we even hav