[PATCH 2/2] cgroup map files: Use cgroup map for memcontrol stats file

2008-02-19 Thread menage
Remove the seq_file boilerplate used to construct the memcontrol stats map, and instead use the new map representation for cgroup control files Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 30 ++ 1 file changed, 6 insertions(+), 24 del

[PATCH 1/2] cgroup map files: Add cgroup map data type

2008-02-19 Thread menage
Adds a new type of supported control file representation, a map from strings to u64 values. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup.h | 19 +++ kernel/cgroup.c| 59 - 2 files chang

[PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups

2008-02-19 Thread menage
f-by: Paul Menage <[EMAIL PROTECTED]> -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[PATCH 2/2] ResCounter: Use read_uint in memory controller

2008-02-21 Thread menage
Update the memory controller to use read_uint for its limit/usage/failcnt control files, calling the new res_counter_read_uint() function. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-)

[PATCH 0/2] ResCounter: Add res_counter_read_uint and use it in memory cgroup

2008-02-21 Thread menage
that calls res_counter_read_uint(). Signed-off-by: Paul Menage <[EMAIL PROTECTED]> -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please

[PATCH 1/2] ResCounter: Add res_counter_read_uint()

2008-02-21 Thread menage
Adds a function for returning the value of a resource counter member, in a form suitable for use in a cgroup read_uint control file method. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/res_counter.h |1 + kernel/res_counter.c|5 + 2 files chan

[PATCH 1/2] cgroup map files: Add cgroup map data type

2008-02-21 Thread menage
Adds a new type of supported control file representation, a map from strings to u64 values. The map type is printed in a similar format to /proc/meminfo or /proc//status, i.e. "$key: $value\n" Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux

[PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups

2008-02-21 Thread menage
ly - less boilerplate required in cgroup subsystems - simplifies transition to a future efficient cgroups binary API Signed-off-by: Paul Menage <[EMAIL PROTECTED]> -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECT

[PATCH 2/2] cgroup map files: Use cgroup map for memcontrol stats file

2008-02-21 Thread menage
Remove the seq_file boilerplate used to construct the memcontrol stats map, and instead use the new map representation for cgroup control files Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 30 ++ 1 file changed, 6 insertions(+), 24 del

[PATCH 06/10] CGroup API files: Add cgroup map data type

2008-02-23 Thread menage
Adds a new type of supported control file representation, a map from strings to u64 values. Each map entry is printed as a line in a similar format to /proc/vmstat, i.e. "$key $value\n" Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup.h | 19 +

[PATCH 00/10] CGroup API files: Various cleanup to CGroup control files

2008-02-23 Thread menage
le and the fact that some write_u64()-based control files are now more forgiving of additional whitespace at the end of their input. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messag

[PATCH 02/10] CGroup API files: Add res_counter_read_u64()

2008-02-23 Thread menage
Adds a function for returning the value of a resource counter member, in a form suitable for use in a cgroup read_u64 control file method. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/res_counter.h |5 - kernel/res_counter.c|5 + 2 files chan

[PATCH 04/10] CGroup API files: Strip all trailing whitespace in cgroup_write_u64

2008-02-23 Thread menage
This removes the need for people to remember to pass the -n flag to echo when writing values to cgroup control files. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/cgroup.c |5 + 1 file changed, 1 insertion(+), 4 deletions(-) Index: cgroup-2.6.25-rc2-mm1/kernel/cg

[PATCH 08/10] CGroup API files: Drop mem_cgroup_force_empty()

2008-02-23 Thread menage
This function isn't needed - a NULL pointer in the cftype read function will result in the same EINVAL response to userspace. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 14 -- 1 file changed, 14 deletions(-) Index: cgroup-2.6.25-rc2-mm1/mm/m

[PATCH 07/10] CGroup API files: Use cgroup map for memcontrol stats file

2008-02-23 Thread menage
Remove the seq_file boilerplate used to construct the memcontrol stats map, and instead use the new map representation for cgroup control files Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 30 ++ 1 file changed, 6 insertions(+), 24 del

[PATCH 05/10] CGroup API files: Update cpusets to use cgroup structured file API

2008-02-23 Thread menage
Many of the cpusets control files are simple integer values, which don't require the overhead of memory allocations for reads and writes. Move the handlers for these control files into cpuset_read_u64() and cpuset_write_u64(). Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kern

[PATCH 09/10] CGroup API files: Move "releasable" to cgroup_debug subsystem

2008-02-23 Thread menage
the "releasable" file to the cgroup_debug subsystem. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup.h | 11 +++ kernel/cgroup.c| 23 --- kernel/cgroup_debug.c | 12 +++- 3 files changed, 22 insertions(+),

[PATCH 10/10] CGroup API files: Make CGROUP_DEBUG default to off

2008-02-23 Thread menage
The cgroup debug subsystem isn't generally useful for users. It should default to "n". Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- init/Kconfig |1 + 1 file changed, 1 insertion(+) Index: cgroup-2.6.25

[PATCH 01/10] CGroup API files: Rename read/write_uint methods to read_write_u64

2008-02-23 Thread menage
Several people have justifiably complained that the "_uint" suffix is inappropriate for functions that handle u64 values, so this patch just renames all these functions and their users to have the suffic _u64. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux

[PATCH 03/10] CGroup API files: Use read_u64 in memory controller

2008-02-23 Thread menage
Update the memory controller to use read_u64 for its limit/usage/failcnt control files, calling the new res_counter_read_u64() function. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 15 ++- 1 file changed, 6 insertions(+), 9 deletions(-) Index:

[PATCH 02/10] Task Containers(V11): Add tasks file interface

2007-07-20 Thread menage
This patch adds the per-directory "tasks" file for containerfs mounts; this allows the user to determine which tasks are members of a container by reading a container's "tasks", and to move a task into a container by writing its pid to its "tasks". Signed-of

[PATCH 05/10] Task Containers(V11): Add procfs interface

2007-07-20 Thread menage
This patch adds: /proc/containers - general system info /proc/*/container - per-task container membership info Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- fs/proc/base.c|7 ++ include/linux/container.h |2 kernel/container.c

[PATCH 06/10] Task Containers(V11): Shared container subsystem group arrays

2007-07-20 Thread menage
many tasks share the same container assignments, this reduces overall space usage and keeps the size of the task_struct down (three pointers added to task_struct compared to a non-containers kernel, no matter how many subsystems are registered). Signed-off-by: Paul Menage <[EM

[PATCH 10/10] Task Containers(V11): Simple task container debug info subsystem

2007-07-20 Thread menage
This example subsystem exports debugging information as an aid to diagnosing refcount leaks, etc, in the container framework. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |4 + init/Kconfig | 10 kernel/Ma

[PATCH 04/10] Task Containers(V11): Add container_clone() interface.

2007-07-20 Thread menage
This patch adds support for container_clone(), a way to create new containers intended to be used for systems such as namespace unsharing. A new subsystem callback, post_clone(), is added to allow subsystems to automatically configure cloned containers. Signed-off-by: Paul Menage <[EM

[PATCH 03/10] Task Containers(V11): Add fork()/exit() hooks

2007-07-20 Thread menage
This patch adds the necessary hooks to the fork() and exit() paths to ensure that new children inherit their parent's container assignments, and that exiting processes release reference counts on their containers. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/

[PATCH 09/10] Task Containers(V11): Example CPU accounting subsystem

2007-07-20 Thread menage
ed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/cpu_acct.h | 14 ++ init/Kconfig |7 + kernel/Makefile |1 kernel/cpu_acct.c

[PATCH 00/10] Task Containers(V11): Introduction

2007-07-20 Thread menage
-getdelays-to-become-containerstats-aware.patch containers-implement-subsys-post_clone.patch containers-implement-namespace-tracking-subsystem-v3.patch Signed-off-by: Paul Menage <[EMAIL PROTECTED]> -- - To unsubscribe from this list: send the line "unsubscribe linux-ker

[PATCH 07/10] Task Containers(V11): Automatic userspace notification of idle containers

2007-07-20 Thread menage
; containers that need to have their release agents invoked by the workqueue task are linked on to a list. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h | 11 - kernel/container.c| 425 +- 2 files change

[PATCH 0/7] containers (V7): Generic Process Containers

2007-02-12 Thread menage
ting resource management systems is substantially reduced, since it doesn't need to provide process grouping/containment, hence improving their chances of getting into the kernel Signed-off-by: Paul Menage <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe

[PATCH 4/7] containers (V7): Simple CPU accounting container subsystem

2007-02-12 Thread menage
This demonstrates how to use the generic container subsystem for a simple resource tracker that counts the total CPU time used by all processes in a container, during the time that they're members of the container. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux

[PATCH 5/7] containers (V7): Resource Groups over generic containers

2007-02-12 Thread menage
This patch provides the RG core and numtasks controller as container subsystems, intended as an example of how to implement a more complex resource control system over generic process containers. The changes to the core involve primarily removing the group management, task membership and configfs s

[PATCH 7/7] containers (V7): Container interface to nsproxy subsystem

2007-02-12 Thread menage
When a task enters a new namespace via a clone() or unshare(), a new container is created and the task moves into it. Developed by Serge Hallyn <[EMAIL PROTECTED]>, adapted by Paul Menage <[EMAIL PROTECTED]> --- include/linux/nsproxy.h |6 ++ init/Kconfig|9

[PATCH 6/7] containers (V7): BeanCounters over generic process containers

2007-02-12 Thread menage
This patch implements the BeanCounter resource control abstraction over generic process containers. It contains the beancounter core code, plus the numfiles resource counter. It doesn't currently contain any of the memory tracking code or the code for switching beancounter context in interrupts. C

[PATCH 1/7] containers (V7): Generic container system abstracted from cpusets code

2007-02-12 Thread menage
subsystem. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- Documentation/containers.txt | 229 +++ fs/proc/base.c |7 include/linux/container.h| 96 +++ include/linux/sched.h|5 init/Kconfig |9 init/main.c

[PATCH 0/6] Multi-hierarchy Process Containers

2006-11-17 Thread menage
ller in conjunction with the UBC memory controller - the additional kernel footprint of any of the competing resource management systems is substantially reduced, since it doesn't need to provide process grouping/containment, hence improving their chances of getting into the kernel S

[PATCH 3/6] Add generic multi-subsystem API to containers

2006-11-17 Thread menage
This patch removes all cpuset-specific knowlege from the container system, replacing it with a generic API that can be used by multiple subsystems. Cpusets is adapted to be a container subsystem. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- Documentation/containers.txt

[PATCH 4/6] Simple CPU accounting container subsystem

2006-11-17 Thread menage
This demonstrates how to use the generic container subsystem for a simple resource tracker that counts the total CPU time used by all processes in a container, during the time that they're members of the container. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux

[PATCH 5/6] Extension to container system to allow fork/exit callbacks

2006-11-17 Thread menage
This patch adds fork/exit callbacks to container subsystems, and ensures that every registered container has received one fork callback for each task running int the system, and one exit callback for each task that exited since it was registered. Since the fork/exit path is performance sensitive,

[PATCH 6/6] Resource Groups over generic containers

2006-11-17 Thread menage
This patch provides the RG core and numtasks controller as container subsystems, intended as an example of how to implement a more complex resource control system over generic process containers. The changes to the core involve primarily removing the group management, task membership and configfs s

[PATCH 1/6] Generic container system abstracted from cpusets code

2006-11-17 Thread menage
subsystem. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- Documentation/containers.txt | 229 +++ fs/proc/base.c |7 include/linux/container.h| 96 +++ include/linux/sched.h|5 init/Kconfig |9 init/main.c

[PATCH 05/10] Containers(V10): Add container_clone() interface

2007-05-29 Thread menage
This patch adds support for container_clone(), a speculative interface to creating new containers intended to be used for systems such as namespace unsharing. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h |2 kernel/container.c

[PATCH 08/10] Containers(V10): Share css_group arrays between tasks with same container memberships

2007-05-29 Thread menage
many tasks share the same container assignments, this reduces overall space usage and keeps the size of the task_struct down (three pointers added to task_struct compared to a non-containers kernel, no matter how many subsystems are registered). Signed-off-by: Paul Menage <[EM

[PATCH 04/10] Containers(V10): Add fork/exit hooks

2007-05-29 Thread menage
This patch adds the necessary hooks to the fork() and exit() paths to ensure that new children inherit their parent's container assignments, and that exiting processes release reference counts on their containers. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/

[PATCH 03/10] Containers(V10): Add tasks file interface

2007-05-29 Thread menage
This patch adds the per-directory "tasks" file for containerfs mounts; this allows the user to determine which tasks are members of a container by reading a container's "tasks", and to move a task into a container by writing its pid to its "tasks". Signed-of

[PATCH 06/10] Containers(V10): Add procfs interface

2007-05-29 Thread menage
This patch adds: /proc/containers - general system info /proc/*/container - per-task container membership info Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- fs/proc/base.c |7 ++ kernel/container.c | 128 + 2 files change

[PATCH 00/10] Containers(V10): Generic Process Containers

2007-05-29 Thread menage
nal kernel footprint of any of the competing resource management systems is substantially reduced, since it doesn't need to provide process grouping/containment, hence improving their chances of getting into the kernel Signed-off-by: Paul Menage <[EMAIL PROTECTED]> - To unsubscribe from

[PATCH 09/10] Containers(V10): Simple debug info subsystem

2007-05-29 Thread menage
This example subsystem exports debugging information as an aid to diagnosing refcount leaks, etc, in the container framework. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |4 + init/Kconfig | 10 kernel/Ma

[PATCH 02/10] Containers(V10): Example CPU accounting subsystem

2007-05-29 Thread menage
ed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/cpu_acct.h | 14 ++ init/Kconfig |7 + kernel/Makefile |1 kernel/cpu_acct.c

[PATCH 10/10] Containers(V10): Support for automatic userspace release agents

2007-05-29 Thread menage
Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h | 15 + kernel/container.c| 364 ++ kernel/cpuset.c |5 3 files changed, 348 insertions(+), 36 deletions(-) Index: container-2.6.22-rc2-mm1/incl

[PATCH 0/7] Containers (V8): Generic Process Containers

2007-04-06 Thread menage
it doesn't need to provide process grouping/containment, hence improving their chances of getting into the kernel Signed-off-by: Paul Menage <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL P

[PATCH 6/7] Containers (V8): BeanCounters over generic process containers

2007-04-06 Thread menage
+ kmem_cache_free(filp_cachep, f); + return NULL; } EXPORT_SYMBOL(get_empty_filp); Index: container-2.6.20-new/include/linux/fs.h === --- container-2.6.20-new.orig/include/linux/fs.h +++ container-2.6.20-new/include/linux/

[PATCH 4/7] Containers (V8): Simple CPU accounting container subsystem

2007-04-06 Thread menage
ed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/cpu_acct.h | 14 ++ init/Kconfig |7 + kernel/Makefile |1 kernel/cpu_acct.c

[PATCH 1/7] Containers (V8): Generic container system abstracted from cpusets code

2007-04-06 Thread menage
subsystem. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- Documentation/containers.txt | 229 +++ fs/proc/base.c |7 include/linux/container.h| 96 +++ include/linux/sched.h|5 init/Kconfig |9 init/main.c

[PATCH 7/7] Containers (V8): Container interface to nsproxy subsystem

2007-04-06 Thread menage
new containers, etc. When a task enters a new namespace via a clone() or unshare(), a new container is created and the task moves into it. Developed by Serge Hallyn <[EMAIL PROTECTED]>, adapted by Paul Menage <[EMAIL PROTECTED]> Signed-off-by: Paul Menage <[EMAIL PROTECTED]>

[PATCH 5/7] Containers (V8): Resource Groups over generic containers

2007-04-06 Thread menage
This patch provides the RG core and numtasks controller as container subsystems, intended as an example of how to implement a more complex resource control system over generic process containers. The changes to the core involve primarily removing the group management, task membership and configfs s

[PATCH 5/9] Containers (V9): Add container_clone() interface

2007-04-27 Thread menage
This patch adds support for container_clone(), a speculative interface to creating new containers intended to be used for systems such as namespace unsharing. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h |2 kernel/container.c

[PATCH 0/9] Containers (V9): Generic Process Containers

2007-04-27 Thread menage
systems is substantially reduced, since it doesn't need to provide process grouping/containment, hence improving their chances of getting into the kernel Signed-off-by: Paul Menage <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in

[PATCH 3/9] Containers (V9): Add tasks file interface

2007-04-27 Thread menage
This patch adds the per-directory "tasks" file for containerfs mounts; this allows the user to determine which tasks are members of a container by reading a container's "tasks", and to move a task into a container by writing its pid to its "tasks". Signed-of

[PATCH 9/9] Containers (V9): Simple debug info subsystem

2007-04-27 Thread menage
This example subsystem exports debugging information as an aid to diagnosing refcount leaks, etc, in the container framework. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |4 + init/Kconfig | 10 kernel/Ma

[PATCH 4/9] Containers (V9): Add fork/exit hooks

2007-04-27 Thread menage
This patch adds the necessary hooks to the fork() and exit() paths to ensure that new children inherit their parent's container assignments, and that exiting processes release reference counts on their containers. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/

[PATCH 6/9] Containers (V9): Add procfs interface

2007-04-27 Thread menage
This patch adds: /proc/containers - general system info /proc/*/container - per-task container membership info Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- fs/proc/base.c |7 ++ kernel/container.c | 128 + 2 files change

[PATCH 2/9] Containers (V9): Example CPU accounting subsystem

2007-04-27 Thread menage
ed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container_subsys.h |6 + include/linux/cpu_acct.h | 14 ++ init/Kconfig |7 + kernel/Makefile |1 kernel/cpu_acct.c

[PATCH 8/9] Containers (V9): Share css_group arrays between tasks with same container memberships

2007-04-27 Thread menage
signments, this reduces overall space usage and keeps the size of the task_struct down (only one pointer added to task_struct compared to a non-containers kernel). Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/container.h | 35 ++ include/linux/sched.h | 30

Re: [RFC] Default child of a cgroup

2008-01-31 Thread Paul Menage
On Jan 30, 2008 6:40 PM, Srivatsa Vaddagiri <[EMAIL PROTECTED]> wrote: > > Here are some questions that arise in this picture: > > 1. What is the relationship of the task-group in A/tasks with the >task-group in A/a1/tasks? In otherwords do they form siblings >of the same parent A? I'd arg

Re: [RFC] Default child of a cgroup

2008-02-01 Thread Paul Menage
On Jan 31, 2008 11:58 PM, Peter Zijlstra <[EMAIL PROTECTED]> wrote: > > Is there a restriction in CFS that stops a given group from > > simultaneously holding tasks and sub-groups? If so, couldn't we change > > CFS to make it possible rather than enforcing awkward restrictions on > > cgroups? > > I

[PATCH] Add MS_BIND_FLAGS mount flag

2008-02-12 Thread Paul Menage
From: Paul Menage <[EMAIL PROTECTED]> Add a new mount() flag, MS_BIND_FLAGS. MS_BIND_FLAGS indicates that a bind mount should take its per-mount flags from the arguments passed to mount() rather than from the source mountpoint. This flag allows you to create a bind mount with the desir

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Thu, Feb 14, 2008 at 12:30 AM, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > For recursive bind mounts, only the root of the tree being bound > > inherits the per-mount flags from the mount() arguments; sub-mounts > > inherit their per-mount flags from the source tree as usual. > > This is r

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Wed, Feb 13, 2008 at 10:02 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > I think this concept is reasonable, but I don't think MS_BIND_FLAGS > is a descriptive name for this flag. MS_EXPLICIT_FLAGS might be better > but still isn't optimal. > MS_BIND_FLAGS_OVERRIDE ? Paul -- To unsu

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
[ cc: linux-fsdevel ] On Thu, Feb 14, 2008 at 7:22 AM, Paul Menage <[EMAIL PROTECTED]> wrote: > On Wed, Feb 13, 2008 at 10:02 PM, Christoph Hellwig <[EMAIL PROTECTED]> wrote: > > > > I think this concept is reasonable, but I don't think MS_BIND_FLAGS > >

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Thu, Feb 14, 2008 at 8:03 AM, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > The "flags" argument could be the same as for regular mount, and > > contain the mnt_flags - so the extra argument could maybe usefully be > > a "mnt_flags_mask", to indicate which flags we actually care about > > ov

Re: [PATCH] Add MS_BIND_FLAGS mount flag

2008-02-14 Thread Paul Menage
On Thu, Feb 14, 2008 at 9:31 AM, Miklos Szeredi <[EMAIL PROTECTED]> wrote: > > I deliberately not used the MS_* flags, which is currently a messy mix > of things with totally different meanings. > > Does this solve all the issues? We should add a size parameter either in the mount_params or as

[PATCH] Add linux-fsdevel to VFS entry in MAINTAINERS

2008-02-14 Thread Paul Menage
Add linux-fsdevel to the VFS entry in MAINTAINERS Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- MAINTAINERS |1 + 1 file changed, 1 insertion(+) Index: 2.6.24-mm1-bindflags/MAINTAINERS === --- 2.6.24-mm1-bindflag

[RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-15 Thread Paul Menage
ed control files. This will reduce the chance of future control files clashing with user-provided names. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup.h | 21 +++ kernel/cgroup.c| 133 ++--- 2 files changed

[RFC][PATCH 5/7] CGroup API: Use read_uint in memory controller

2008-02-15 Thread Paul Menage
Update the memory controller to use read_uint for its limit/usage/failcnt control files, calling the new res_counter_read_uint() function. This allows the files to show up as u64 rather than string in the cgroup.api file. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c

[RFC][PATCH 6/7] CGroup API: Use descriptions for memory controller API files

2008-02-15 Thread Paul Menage
This patch adds descriptions to the memory controller API files to indicate that the usage/limit are in bytes; the names of the control files can then be simplified to usage/limit. Also removes the unnecessary mem_force_empty_read() function Signed-off-by: Paul Menage <[EMAIL PROTEC

[RFC][PATCH 0/7] CGroup API: More structured API for CGroups control files

2008-02-15 Thread Paul Menage
This set of patches makes the Control Groups API more structured and self-describing. 1) Allows control files to be associated with data types such as "u64", "string", "map", etc. These types show up in a new cgroup.api file in each cgroup directory, along with a user-readable string. Files that

[RFC][PATCH 3/7] CGroup API: Use cgroup map for memcontrol stats file

2008-02-15 Thread Paul Menage
Remove the seq_file boilerplate used to construct the memcontrol stats map, and instead use the new map representation for cgroup control files Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- mm/memcontrol.c | 30 ++ 1 file changed, 6 insertions(+), 24 del

[RFC][PATCH 2/7] CGroup API: Add cgroup map data type

2008-02-15 Thread Paul Menage
Adds a new type of supported control file representation, a map from strings to u64 values. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/cgroup.h | 19 +++ kernel/cgroup.c| 61 - 2 files chang

[RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

2008-02-15 Thread Paul Menage
"u64" rather than "string" in the cgroup.api file. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/cpuset.c | 158 +--- 1 file changed, 83 insertions(+), 75 deletions(-) Index: cgrou

[RFC][PATCH 4/7] CGroup API: Add res_counter_read_uint()

2008-02-15 Thread Paul Menage
Adds a function for returning the value of a resource counter member, in a form suitable for use in a cgroup read_uint control file method. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- include/linux/res_counter.h |1 + kernel/res_counter.c|5 + 2 files chan

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-16 Thread Paul Menage
On Feb 16, 2008 2:07 AM, Balbir Singh <[EMAIL PROTECTED]> wrote: > Paul Menage wrote: > > Hi, Paul, > > Do we need to use a cgroup.api file? Why not keep up to date documentation and > get users to use that. I fear that, cgroup.api will not be kept up-to-date, >

Re: [RFC][PATCH 0/7] CGroup API: More structured API for CGroups control files

2008-02-16 Thread Paul Menage
On Feb 16, 2008 1:31 AM, Li Zefan <[EMAIL PROTECTED]> wrote: > > I don't quite catch what you mean. Cgoup does support write-only/read-only > files. For a write-only file, just set .write and .write_uint to be NULL, > similar for a read-only file. > > Do I miss something? > I suppose we could infe

Re: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

2008-02-17 Thread Paul Menage
like a good idea to me. Thanks for this. > > Signed-off-by: Paul Jackson <[EMAIL PROTECTED]> > Cc: Paul Menage <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> > > --- > kernel/cgroup.c |5 + > 1 file changed, 1 insertion(+), 4 dele

Re: [RFC][PATCH 7/7] CGroup API: Update cpusets to use cgroup structured file API

2008-02-17 Thread Paul Menage
On Feb 17, 2008 9:28 AM, Paul Jackson <[EMAIL PROTECTED]> wrote: > > I'm figuring it would be easiest if you just threw this > little change into your hopper for the bigger changes > you're making OK, will do. Paul -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-19 Thread Paul Menage
On Feb 19, 2008 7:12 AM, Nick Andrew <[EMAIL PROTECTED]> wrote: > config CGROUPS > bool "Control Group support" > help > - This option will let you use process cgroup subsystems > - such as Cpusets > + Control Groups enables processes to be tracked and group

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-19 Thread Paul Menage
On Feb 19, 2008 1:57 PM, Paul Jackson <[EMAIL PROTECTED]> wrote: > > Finally, it goes against the one thingie per file (at most, one scalar > vector) that has worked well for us when tried. Right, I like the idea of keeping things simple. But if you're going to accept that a vector is useful, then

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-19 Thread Paul Menage
On Feb 18, 2008 1:45 AM, Li Zefan <[EMAIL PROTECTED]> wrote: > > > > But we don't have /proc/proc.api or /sys/sysfs.api ... True. And /proc is a bit of a mess. Having a similar API file for sysfs sounds like a good idea to me. > > And is it better to describe the debug subsystem too? > Yes, prob

Re: [PATCH 3/7] cgroup: clean up cgroup.h

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > - replace old name 'cont' with 'cgrp' (Paul Menage did this cleanup for > cgroup.c in commit bd89aabc6761de1c35b154fe6f914a445d301510) > - remove a duplicate declaration of cgroup_path() > >

Re: [PATCH 5/7] cgroup: fix subsys bitops

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > Cgroup uses unsigned long for subsys bitops, not unsigned long long. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> > --- > kernel/cgroup.c |4 ++--

Re: [PATCH 4/7] cgroup: fix memory leak in cgroup_get_sb()

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > opts.release_agent is not kfree()ed in all necessary places. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> Good catch, although hopefully something that would be

Re: [PATCH 1/7] cgroup: fix and update documentation

2008-02-19 Thread Paul Menage
On Feb 18, 2008 12:39 AM, Li Zefan <[EMAIL PROTECTED]> wrote: > Misc fixes and updates, make the doc consistent with current > cgroup implementation. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> Thanks for these cleanups.

Re: Improve init/Kconfig help descriptions [PATCH 6/9]

2008-02-19 Thread Paul Menage
On Feb 19, 2008 6:54 PM, Nick Andrew <[EMAIL PROTECTED]> wrote: > > config CGROUPS > bool "Control Group support" > help > Control Groups enables processes to be tracked and grouped > into "cgroups". This enables you, for example, to associate > cgroups

Re: [PATCH 6/7] cgroup: remove duplicate code in find_css_set()

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > The list head res->tasks gets initialized twice in find_css_set(). > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> Acked-by: Paul Menage <[EMAIL PROTECTED]> > --- > kernel/cgroup.c |1 - &g

Re: [PATCH 2/7] cgroup: fix comments

2008-02-19 Thread Paul Menage
On Feb 17, 2008 9:49 PM, Li Zefan <[EMAIL PROTECTED]> wrote: > fix: > - comments about need_forkexit_callback > - comments about release agent > - typo and comment style, etc. > > Signed-off-by: Li Zefan <[EMAIL PROTECTED]> > --- > include/linux/cgroup.h |2 +- > kernel/cgroup.c| 44

[PATCH 2/2] Cpusets API: Update cpusets to use cgroup structured file API

2008-02-19 Thread Paul Menage
"u64" rather than "string" in the cgroup.api file. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/cpuset.c | 156 +--- 1 file changed, 82 insertions(+), 74 deletions(-) Index: cpusets

[PATCH 1/2] Cpusets API: From: Paul Jackson <[EMAIL PROTECTED]>

2008-02-19 Thread Paul Menage
Strip all trailing whitespace in cgroup_write_uint This removes the need for people to remember to pass the -n flag to echo when writing values to cgroup control files. Signed-off-by: Paul Menage <[EMAIL PROTECTED]> --- kernel/cgroup.c |5 + 1 file changed, 1 insertion(+), 4 del

[PATCH 0/2] Cpusets API: Update Cpusets control files

2008-02-19 Thread Paul Menage
This pair of patches simplifies the cpusets read/write path for the control files that consist of simple integers. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-in

Re: [RFC][PATCH 1/7] CGroup API: Add cgroup.api control file

2008-02-19 Thread Paul Menage
On Feb 19, 2008 9:17 PM, Paul Jackson <[EMAIL PROTECTED]> wrote: > > Perhaps my primary concern with these *.api files was that I did not > understand who or what the critical use or user was; who found this > essential, not just nice to have. > Right now, no-one would find it essential. If/when a

Re: [PATCH 0/2] cgroup map files: Add a key/value map file type to cgroups

2008-02-19 Thread Paul Menage
On Feb 19, 2008 9:48 PM, YAMAMOTO Takashi <[EMAIL PROTECTED]> wrote: > > it changes the format from "%s %lld" to "%s: %llu", right? > why? > The colon for consistency with maps in /proc. I think it also makes it slightly more readable. For %lld versus %llu - I think that cgroup resource APIs are

  1   2   3   4   5   >