Re: [PATCH v2 03/11] crypto: Documentation - RNG API documentation

Hi Stephan, Just one quick comment below... regards, Joy On Sun, 2014-11-02 at 21:36 +0100, Stephan Mueller wrote: > The API function calls exported by the kernel crypto API for RNGs to > be used by consumers are documented. > > Signed-off-by: Stephan Mueller > CC: Marek Vasut > --- > includ

[PATCH] i2c: rk3x: fix 0 length write transfers

: Alexandru M Stan --- drivers/i2c/busses/i2c-rk3x.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/i2c/busses/i2c-rk3x.c b/drivers/i2c/busses/i2c-rk3x.c index b41d979..f486d0e 100644 --- a/drivers/i2c/busses/i2c-rk3x.c +++ b/drivers/i2c/busses/i2c-rk3x.c @@ -238,7 +238,7

Re: [PATCH v2 05/11] crypto: Documentation - SHASH API documentation

Hi Stephan, On Sun, 2014-11-02 at 21:38 +0100, Stephan Mueller wrote: > The API function calls exported by the kernel crypto API for SHASHes > to be used by consumers are documented. > > Signed-off-by: Stephan Mueller > CC: Marek Vasut > --- > include/crypto/hash.h | 197 > +++

Re: [PATCH RT 0/7] Linux 3.18.18-rt16-rc1

Hi all, only after additionally installing my "3.18.17-rt14 locktorture: Do NOT include rwlock.h" patch I could build the kernel with CONFIG_PREEMPT_RT_FULL=y. So far kernel 3.18.18-rt16-rc1 runs fine on my lenovo notebook as well as on a server with (an already 5 year old) ASUS Z8NA-D6(C) mother

[PATCH] Staging: rtl8188eu/hal: Fixed code indentation warning detected with checkpatch.pl

>From : Mayank Bareja fixed code indentation warning as reported by checkpatch.pl. Replaced Spaces with Tabs. Signed-off-by: Mayank Bareja --- drivers/staging/rtl8188eu/hal/bb_cfg.c |6 +++--- drivers/staging/rtl8188eu/hal/rf.c |2 +- 2 files changed, 4 insertions(+), 4 deletions(-

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

> I don't have a device large enough to test for signedness errors, since > passing > huge values for start and len never make it past the i_size_read check. > However, I do see that I forgot to check the padding values, so I'll update > that. Then do you want to at least consider converting end

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

> which would make the other checks I suggested to ensure that neither start > or end were more than (uint64_t)LLONG_MAX unnecessary. My apologies I was wrong about what I said above - after thinking about it for longer you still need to make sure that at least len is not greater than (uint64_t)

RE: [PATCH] block: create ioctl to discard-or-zeroout a range of blocks

> I don't have a device large enough to test for signedness errors, since > passing > huge values for start and len never make it past the i_size_read check. If you have someone trying to bypass your sanity checks then if start=18446744073709551104 and len=1024 the result of adding them togethe

RE: [PATCHv2] pci: Update VPD size with correct length

> The only 'error' cases I've encountered so far is a read of all zeroes (and a > halting the machine once you've read beyond a certain point) or a read of > 0xff throughout the entire area. So that approach would work for both of them. I should add that I'd tested the previous patch and this patc

RE: [PATCH 1/2] pci: Update VPD definitions

> The 'end' tag is actually 0x0f, it's the representation as a > small resource data type tag that's 0x78 (ie shifted by 3). > This patch also adds helper functions to extract the resource > data type tags for both large and small resource data types. > > Cc: Alexander Duyck > Cc: Bjorn Helgaas >

RE: [PATCH 2/2] pci: Update VPD size with correct length

Tested with a HP AE311-60001 PCIe card. It used to repeat the same VPD every 4k for 32k now only the 154 bytes are returned and lspci - reports that the data up to and including the end and that the check sum is good: ... Capabilities: [74] Vital Product Data Product N

RE: [PATCH v5 1/2] block: invalidate the page cache when issuing BLKZEROOUT.

Thank you for taking the issues I raised about converting unsigned to signed into account. Reviewed-by: Shane Seymour

[PATCH 2/2] staging: lustre: Use __user for a pointer to a user space address

third argument to a helper function (libcfs_ioctl_popdata) which also has a __user annotation for its corresponding argument. Signed-off-by: M. Vefa Bicakci --- drivers/staging/lustre/lustre/libcfs/module.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/staging/lustre

[PATCH 1/2] staging: lustre: Use const static file_operations struct

This commit corrects the following sparse warning regarding a file_operations structure being non-static and constifies the structure in question as well. warning: symbol 'lprocfs_stats_seq_fops' was not declared. Should it be static? Signed-off-by: M. Vefa Bicakci --- drive

[PATCH 0/2] staging: lustre: Correct two minor issues found by sparse

eturn variables") which points to the tip of the staging-next and staging-testing branches as of now. M. Vefa Bicakci (2): staging: lustre: Use const static file_operations struct staging: lustre: Use __user for a pointer to a user space address drivers/staging/lustre/lustre/libcf

RE: [PATCH] snic: correctly check for array overrun on overly long version number

Reviewed-by: Shane Seymour

RE: [PATCH] qlogicpti: Return correct error code

Reviewed-by: Shane Seymour

[PATCH 0/2] For now all I have is the getter and setter for the phase, nothing that uses it

new clocks, and eventually mmc code will be changed to tune with these clocks. Alexandru M Stan (2): clk: rockchip: add bindings for the mmc clock phases clk: rockchip: Add support for the mmc clock phases using the framework drivers/clk/rockchip/Makefile | 1 + drivers/clk

[PATCH 1/2] clk: rockchip: add bindings for the mmc clock phases

This will be used in a later patch for clock phase tuning. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- include/dt-bindings/clock/rk3288-cru.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/dt-bindings/clock/rk3288-cru.h b/include/dt-bindings/clock

[PATCH 2/2] clk: rockchip: Add support for the mmc clock phases using the framework

s long) to generate a rough 45deg (which might be from 33deg to 66deg) setting. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- drivers/clk/rockchip/Makefile| 1 + drivers/clk/rockchip/clk-mmc-phase.c | 150 +++ drivers/clk/rockchip/cl

[PATCH v2 2/2] clk: rockchip: Add support for the mmc clock phases using the framework

s long) to generate a rough 45deg (which might be from 33deg to 66deg) setting. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- Changes in v2: - fixed my cc/to list - removed dangling #DEFINE DEBUG drivers/clk/rockchip/Makefile| 1 + drivers/clk/rockchip/clk-mmc-pha

[PATCH v2 0/2] Add support for the rockchip mmc clock phases using the framework

180 Next thing that will come is some dts changes that will make use of these new clocks, and eventually mmc code will be changed to tune with these clocks. Changes in v2: - fixed my cc/to list - removed dangling #DEFINE DEBUG Alexandru M Stan (2): clk: rockchip: add bindings for the mmc clock

[PATCH v2 1/2] clk: rockchip: add bindings for the mmc clock phases

This will be used in a later patch for clock phase tuning. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- Changes in v2: None include/dt-bindings/clock/rk3288-cru.h | 10 ++ 1 file changed, 10 insertions(+) diff --git a/include/dt-bindings/clock/rk3288-cru.h b

[PATCH v4 1/2] clk: rockchip: add bindings for the mmc clocks

These clocks represent the physical clocks (including phases) and they will later be used for clock phase tuning. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- Changes in v4: None Changes in v3: None Changes in v2: None include/dt-bindings/clock/rk3288-cru.h | 10

[PATCH v4 0/2] Add support for the rockchip mmc clock phases using the framework

to just mmc_clock or mmc - added RK3288_MMC_CLKGEN_DIV instead of the magic number - added new paragraph to commit message Changes in v2: - fixed my cc/to list - removed dangling #DEFINE DEBUG Alexandru M Stan (2): clk: rockchip: add bindings for the mmc clocks clk: rockchip: Add support for

[PATCH v4 2/2] clk: rockchip: Add support for the mmc clock phases using the framework

ay elements are as big as 80 ps, so a finer division (smaller than 22.5) was not picked because the phase might not be monotonic anymore. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- Changes in v4: - Changed set_phase to 22.5 increments, it seems better for tuning, better at s

Re: [PATCH v2] staging: unisys: remove duplicate header

zZ+��+zf���h���~i���z��w���?�&�)ߢf��^jǫy�m��@A�a��� 0��h���i

[PATCH v3 0/2] Add support for the rockchip mmc clock phases using the framework

- added new paragraph to commit message Changes in v2: - fixed my cc/to list - removed dangling #DEFINE DEBUG Alexandru M Stan (2): clk: rockchip: add bindings for the mmc clocks clk: rockchip: Add support for the mmc clock phases using the framework drivers/clk/rockchip/Makefile

[PATCH v3 1/2] clk: rockchip: add bindings for the mmc clocks

These clocks represent the physical clocks (including phases) and they will later be used for clock phase tuning. Suggested-by: Heiko Stuebner Signed-off-by: Alexandru M Stan --- Changes in v3: None Changes in v2: None include/dt-bindings/clock/rk3288-cru.h | 10 ++ 1 file changed, 10

[PATCH v3 2/2] clk: rockchip: Add support for the mmc clock phases using the framework

ner Signed-off-by: Alexandru M Stan --- Changes in v3: - renamed everything internal from phase to just mmc_clock or mmc - added RK3288_MMC_CLKGEN_DIV instead of the magic number - added new paragraph to commit message Changes in v2: - fixed my cc/to list - removed dangling #DEFINE DEBUG drive

Re: [PATCH 0/2] block: loop: fix stacked loop and performance regression

> drivers/block/loop.c | 30 ++ > drivers/block/loop.h | 1 + > 2 files changed, 15 insertions(+), 16 deletions(-) > > > Thanks, > Ming Lei > Tested with Fedora 22 ISOs, these still solve the problem for us. Tested-by: Justin M. For

Re: [tpmdd-devel] [PATCH 1/3] vTPM: fixed the limit checking

a56a13..e77d8c1 100644 > > --- a/drivers/char/tpm/tpm_eventlog.c > > +++ b/drivers/char/tpm/tpm_eventlog.c > > @@ -116,11 +116,8 @@ static void *tpm_bios_measurements_next(struct > > seq_file *m, void *v, > > > > event = v; > > > > - if (event-

Re: [PATCH 3/3] vTPM: support little endian guests

Hi Ashley, On Fri, 2015-05-08 at 17:31 -0500, Ashley Lai wrote: > > The event log in ppc64 arch is always in big endian format. PowerPC > > supports both little endian and big endian guests. This patch converts > > the event log entries to guest format. > > I'm a little confused here. If this pat

[PATCH 01/16] staging: rtl8723au: Reformat whitespace to increase readability

Adjust the whitespace in the local variable declaration and initialization part of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 79 +-- 1 file change

[PATCH 13/16] staging: rtl8723au: suspect code indent for conditional statements

Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c

[PATCH 10/16] staging: rtl8723au: that open brace should be on the previous line

Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 6 ++ 1 file changed, 2

[PATCH 05/16] staging: rtl8723au: Reorganize a few functions to remove indentation

with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 178 +- 1 file changed, 88 insertions(+

[PATCH 14/16] staging: rtl8723au: Improve readability of two very long lines

Improve the readability of an if statement and its very long trace output line in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 18 +++--- 1 file changed, 15 insertions(+), 3 deletions(-) diff --git a/drivers/st

[PATCH 03/16] staging: rtl8723au: else should follow close brace

Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH 07/16] staging: rtl8723au: else is not generally useful after a return

d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 3e812a67e2..6d2f0

[PATCH 15/16] staging: rtl8723au: Correct a typo in a trace log line

Correct a typo in rtl8723au's rtw_security.c which was most likely caused by a copy and paste mistake. Prior to this commit, the TKIP decryption function referred to WEP in its trace log output. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 2 +- 1

[PATCH 08/16] staging: rtl8723au: Remove unneeded curly braces

Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH 12/16] staging: rtl8723au: Adjust whitespace in and around comments

As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/st

[PATCH 16/16] staging: rtl8723au: Remove unneeded comments

This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH 02/16] staging: rtl8723au: Fix "before/around/after" whitespace issues

Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 173 +- 1 file changed, 86 in

[PATCH 04/16] staging: rtl8723au: Fix the indentation of two lines

Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH 00/16] checkpatch clean-up of rtl8723au's rtw_security.c

nize a few functions to remove indentation" reworks two functions to make them more readable. All of the individual commits have been verified to compile successfully individually via the use of the interactive rebase feature of git. M. Vefa Bicakci (16): staging: rtl8723au: Reformat whitesp

[PATCH 11/16] staging: rtl8723au: No spaces at the start of a line

line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index e6b2f

[PATCH 09/16] staging: rtl8723au: trailing statements should be on next line

Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH 06/16] staging: rtl8723au: Do not initialize a static to 0

Prior to this commit, a static integer named bcrc32initialized in rtl8723au's rtw_security.c was explicitly initialized to zero, even though this is not necessary. Remove the unneeded initialization. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 2 +- 1

Re: [PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

On 26/03/15 08:18 AM, Greg KH wrote: > On Thu, Mar 19, 2015 at 12:39:04AM -0400, M. Vefa Bicakci wrote: >> Adjust the whitespace in the signature, local variable declaration and >> initialization parts of a number of functions to increase readability >> in rtl8723au'

[PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

v1. In summary, the following commits have been updated: - Reformat whitespace to increase readability - Fix "before/around/after" whitespace issues - Rework two byte array comparisons M. Vefa Bicakci (15): staging: rtl8723au: Reformat whitespace to increase readability staging:

[PATCH v4 10/15] staging: rtl8723au: No spaces at the start of a line

line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 0557a

[PATCH v4 01/15] staging: rtl8723au: Reformat whitespace to increase readability

Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Make sure that the arcfour_encrypt function's argument list is split

[PATCH v4 12/15] staging: rtl8723au: suspect code indent for conditional statements

Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters

[PATCH v4 15/15] staging: rtl8723au: Remove unneeded comments

This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v4 11/15] staging: rtl8723au: Adjust whitespace in and around comments

As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/st

[PATCH v4 04/15] staging: rtl8723au: Fix the indentation of two lines

Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v4 14/15] staging: rtl8723au: Use __func__ in trace logs

r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 49 --- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v4 07/15] staging: rtl8723au: Remove unneeded curly braces

Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v4 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Correct one more whitespace issue ("length-4") in rtw_tkip_decrypt23a. --- drive

[PATCH v4 13/15] staging: rtl8723au: Rework two byte array comparisons

s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. Signed-off-by: M. Vefa Bicakci --- v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. --- drivers/st

[PATCH v4 09/15] staging: rtl8723au: that open brace should be on the previous line

Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide

[PATCH v4 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 178 +- 1 file changed, 88 insertions(+

[PATCH v4 03/15] staging: rtl8723au: else should follow close brace

Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v4 08/15] staging: rtl8723au: trailing statements should be on next line

Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v4 06/15] staging: rtl8723au: else is not generally useful after a return

d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index f7b1d45981..f7571

Re: [PATCH v4 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

On Sat, March 28, 2015 12:52:54 Joe Perches wrote: > On Sat, 2015-03-28 at 08:52 -0400, M. Vefa Bicakci wrote: > > These commits address a number of checkpatch.pl warnings and errors > > in rtl8723au's rtw_security.c. > > Hello. > > This is one of those patchse

[PATCH v5 00/15] checkpatch clean-up of rtl8723au's rtw_security.c

ssages for the changes since v1. In summary, the following commits have been updated: - Reformat whitespace to increase readability - Fix "before/around/after" whitespace issues - Rework two byte array comparisons M. Vefa Bicakci (15): staging: rtl8723au: Reformat whi

[PATCH v5 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- v5: Move the "start to encrypt each fragment" and "start to decrypt recvframe" c

[PATCH v5 06/15] staging: rtl8723au: else is not generally useful after a return

d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index df7261c045fe..b85e5de

[PATCH v5 03/15] staging: rtl8723au: else should follow close brace

Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v5 12/15] staging: rtl8723au: suspect code indent for conditional statements

Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters

[PATCH v5 04/15] staging: rtl8723au: Fix the indentation of two lines

Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v5 08/15] staging: rtl8723au: trailing statements should be on next line

Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v5 14/15] staging: rtl8723au: Use __func__ in trace logs

r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 41 ++- 1 file changed, 22 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v5 15/15] staging: rtl8723au: Remove unneeded comments

This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v5 10/15] staging: rtl8723au: No spaces at the start of a line

line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 140 +- 1 file changed, 70 insertions(+), 70 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 2d50777

[PATCH v5 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v5: Correct even more whitespace issues. v2: Correct one more whitespace issue ("length-4") i

[PATCH v5 09/15] staging: rtl8723au: that open brace should be on the previous line

Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line Signed-off-by: M. Vefa Bicakci --- v3: Make sure that all edited lines are at most 80 characters wide

[PATCH v5 13/15] staging: rtl8723au: Rework two byte array comparisons

s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. Signed-off-by: M. Vefa Bicakci --- v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. --- drivers/st

[PATCH v5 11/15] staging: rtl8723au: Adjust whitespace in and around comments

As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 113 +- 1 file changed, 57 insertions(+), 56 deletions(-) diff --git a/drivers/st

[PATCH v5 01/15] staging: rtl8723au: Reformat whitespace to increase readability

Adjust the whitespace in the signature, local variable declaration and initialization parts of a number of functions to increase readability in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- v2: Make sure that the arcfour_encrypt function's argument list is split

[PATCH v5 07/15] staging: rtl8723au: Remove unneeded curly braces

Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

Attention User

Dear User, This message is from your Helpdesk Server. Please note that your mailbox account will be deactivated due to invalid profile update that appear on your account. In order to update your account please Click Here: P.S failure to do this

Re: [PATCH v2 00/16] checkpatch clean-up of rtl8723au's rtw_security.c

On 2015-03-16 12:01 PM, Jes Sorensen wrote: > "M. Vefa Bicakci" writes: >> [snip] >> >> I hope this clarifies my set-up. Is there something I am doing incorrectly? >> If there is anything I can assist with, please let me know. >> >> Thank you, &g

[PATCH v3 01/15] staging: rtl8723au: Reformat whitespace to increase readability

Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 79 +-- 1 file changed, 38 insertions(+), 41 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index 045a24c81b..088533c

[PATCH v3 09/15] staging: rtl8723au: that open brace should be on the previous line

Correct two instances of the checkpatch.pl error indicating that the opening curly braces should not be on new lines: ERROR: that open brace { should be on the previous line v3: Make sure that all edited lines are at most 80 characters wide. Signed-off-by: M. Vefa Bicakci --- drivers

[PATCH v3 14/15] staging: rtl8723au: Use __func__ in trace logs

r the suggestion to use __func__. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 49 --- 1 file changed, 30 insertions(+), 19 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_secur

[PATCH v3 03/15] staging: rtl8723au: else should follow close brace

Correct checkpatch.pl errors in rtl8723au's rtw_security.c indicating that an else statement should follow the closing brace of the previous if/else if code block: ERROR: else should follow close brace '}' Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

[PATCH v3 07/15] staging: rtl8723au: Remove unneeded curly braces

Correct a number of checkpatch.pl warnings in rtl8723au's rtw_security.c related to the existence of unnecessary curly braces around single statement blocks: WARNING: braces {} are not necessary for single statement blocks Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v3 08/15] staging: rtl8723au: trailing statements should be on next line

Correct a number of checkpatch.pl errors in rtl8723au's rtw_security.c related to trailing statements: ERROR: trailing statements should be on next line Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 25 + 1 file change

[PATCH v3 12/15] staging: rtl8723au: suspect code indent for conditional statements

Correct a number of indentation-with-spaces-and-tabs issues in rtl8723au's rtw_security.c, according to checkpatch.pl: WARNING: suspect code indent for conditional statements v3: Make sure that all edited lines are at most 80 characters wide. Signed-off-by: M. Vefa Bicakci --- dr

[PATCH v3 13/15] staging: rtl8723au: Rework two byte array comparisons

s for suggesting the use of 32-bit integer comparisons instead of byte array comparisons. v2: Correct code style issues and compare 32-bit integers instead of byte arrays. Update the commit message to better reflect the nature of the changes. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8

[PATCH v3 11/15] staging: rtl8723au: Adjust whitespace in and around comments

As the subject indicates, adjust whitespace in and around comments in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 114 +- 1 file changed, 57 insertions(+), 57 deletions(-) diff --git a/drivers/st

[PATCH v3 02/15] staging: rtl8723au: Fix "before/around/after" whitespace issues

Correct a number of "space(s) required before/around/after" checkpatch.pl issues in a number of functions in rtl8723au's rtw_security.c. v2: Correct one more whitespace issue ("length-4") in rtw_tkip_decrypt23a. Signed-off-by: M. Vefa Bicakci --- drive

[PATCH v3 04/15] staging: rtl8723au: Fix the indentation of two lines

Correct the indentation of two lines in rtw_tkip_encrypt23a function in rtl8723au's rtw_security.c. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8723au

[PATCH v3 05/15] staging: rtl8723au: Reorganize a few functions to remove indentation

with _FAIL, as expected by the calling code. This lets us remove two levels of indentation from the functions in question, making them more readable. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 178 +- 1 file changed, 88 insertions(+

[PATCH v3 06/15] staging: rtl8723au: else is not generally useful after a return

d-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core/rtw_security.c | 42 ++- 1 file changed, 22 insertions(+), 20 deletions(-) diff --git a/drivers/staging/rtl8723au/core/rtw_security.c b/drivers/staging/rtl8723au/core/rtw_security.c index f7b1d45981..f7571

[PATCH v3 15/15] staging: rtl8723au: Remove unneeded comments

This commit removes a number of unneeded comments. Two of the aforementioned comments were most likely meant to aid with version control, whereas the remaining two comments relate to (now unused) local variable names. Signed-off-by: M. Vefa Bicakci --- drivers/staging/rtl8723au/core

<    4   5   6   7   8   9   10   11   12   13   >