[PATCH v5 08/11] drivers: perf: hisi: use poll method to avoid L3C counter overflow

2017-03-02 Thread Anurup M
interval of 10 seconds is used for the hrtimer. Signed-off-by: Dikshit N Signed-off-by: Anurup M --- drivers/perf/hisilicon/hisi_uncore_l3c.c | 47 ++ drivers/perf/hisilicon/hisi_uncore_pmu.c | 82 drivers/perf/hisilicon/hisi_uncore_pmu.h | 17

[PATCH v5 00/11] perf: arm64: Support for Hisilicon SoC Hardware event counters

2017-03-02 Thread Anurup M
used to access registers of L3 cache and MN. Anurup M (8): arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting. drivers: perf: hisi

[PATCH v5 03/11] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2017-03-02 Thread Anurup M
1) Device tree bindings for Hisilicon SoC PMU. 2) Add example for Hisilicon L3 cache and MN PMU. 3) Add child nodes of L3C and MN in djtag bindings example. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- .../devicetree/bindings/arm/hisilicon/djtag.txt| 25 +++ .../devicetree

[PATCH v5 01/11] arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support

2017-03-02 Thread Anurup M
Add support for Hisilicon SoC hardware event counters for HiP05/06/07 chip versions. Signed-off-by: Anurup M --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d662a83..9bb2ddb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5875,6

[PATCH v5 11/11] dts: arm64: hip07: Add Hisilicon SoC PMU support

2017-03-02 Thread Anurup M
Add nodes for djtag, L3 cache and MN to support uncore events. Signed-off-by: Anurup M --- arch/arm64/boot/dts/hisilicon/hip07.dtsi | 79 1 file changed, 79 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon

[PATCH v5 09/11] drivers: perf: hisi: Miscellanous node(MN) event counting in perf

2017-03-02 Thread Anurup M
d_req/" Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_uncore_mn.c | 489 2 files changed, 490 insertions(+), 1 deletion(-) create mode 100644 drivers/perf/hisilicon/hisi_uncore_

[PATCH v5 10/11] drivers: perf: hisi: use poll method when no IRQ for MN counter overflow

2017-03-02 Thread Anurup M
When no IRQ is supported in hardware, use hrtimer to poll and update event counter and avoid overflow condition for MN PMU. An interval of 8 seconds is used for the hrtimer. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang Signed-off-by: Dikshit N --- drivers/perf/hisilicon

Re: Passionate Partner

2017-03-02 Thread M. G
Dear Sir, Did you recieved my mail? I have sent it twice without a response. Mr Masella Giuseppe

[RESEND PATCH v5 04/11 (Missed 04/11 in PATCH v5 series)] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

2017-03-02 Thread Anurup M
Documentation for perf usage and Hisilicon SoC PMU uncore events. The Hisilicon SOC has event counters for hardware modules like L3 cache, Miscellaneous node etc. These events are all uncore. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- Documentation/perf/hisi-pmu.txt | 76

Re: [PATCH v4 10/11] drivers: perf: hisi: Handle counter overflow IRQ in MN PMU

2017-02-21 Thread Anurup M
On Monday 20 February 2017 04:59 PM, Mark Rutland wrote: Hi, On Sun, Feb 19, 2017 at 01:51:22PM -0500, Anurup M wrote: +static irqreturn_t hisi_pmu_mn_isr(int irq, void *dev_id) +{ + struct hisi_pmu *mn_pmu = dev_id; + struct hisi_mn_data *mn_data = mn_pmu->hwmod_d

Re: [PATCH v4 10/11] drivers: perf: hisi: Handle counter overflow IRQ in MN PMU

2017-02-23 Thread Anurup M
Sorry for delay in reply. On Tuesday 21 February 2017 05:33 PM, Mark Rutland wrote: On Tue, Feb 21, 2017 at 05:19:58PM +0530, Anurup M wrote: On Monday 20 February 2017 04:59 PM, Mark Rutland wrote: On Sun, Feb 19, 2017 at 01:51:22PM -0500, Anurup M wrote: + /* Clear

Re: [PATCH v4 08/11] drivers: perf: hisi: use poll method to avoid L3C counter overflow

2017-02-23 Thread Anurup M
On Tuesday 21 February 2017 05:39 PM, Will Deacon wrote: On Mon, Feb 20, 2017 at 11:09:43AM +, Mark Rutland wrote: On Sun, Feb 19, 2017 at 01:51:03PM -0500, Anurup M wrote: The L3 cache PMU use N-N SPI interrupt which has no support in kernel mainline. Could you elaborate on what you

[PATCH v4 00/11] perf: arm64: Support for Hisilicon SoC Hardware event counters

2017-02-19 Thread Anurup M
M (8): arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting. drivers: perf: hisi: Update Kconfig for Hisilicon PMU support drivers: perf

[PATCH v4 01/11] arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support

2017-02-19 Thread Anurup M
Add support for Hisilicon SoC hardware event counters for HiP05/06/07 chip versions. Signed-off-by: Anurup M --- MAINTAINERS | 9 + 1 file changed, 9 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index d662a83..9bb2ddb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -5875,6

[PATCH v4 02/11] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Djtag dts bindings

2017-02-19 Thread Anurup M
From: Tan Xiaojun Add Hisilicon HiP05/06/07 Djtag dts bindings for CPU and IO Die Signed-off-by: Tan Xiaojun Signed-off-by: Anurup M --- .../devicetree/bindings/arm/hisilicon/djtag.txt| 51 ++ 1 file changed, 51 insertions(+) create mode 100644 Documentation

[PATCH v4 03/11] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2017-02-19 Thread Anurup M
1) Device tree bindings for Hisilicon SoC PMU. 2) Add example for Hisilicon L3 cache and MN PMU. 3) Add child nodes of L3C and MN in djtag bindings example. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- .../devicetree/bindings/arm/hisilicon/djtag.txt| 25 + .../devicetree

[PATCH v4 08/11] drivers: perf: hisi: use poll method to avoid L3C counter overflow

2017-02-19 Thread Anurup M
N Signed-off-by: Anurup M --- drivers/perf/hisilicon/hisi_uncore_l3c.c | 44 +++ drivers/perf/hisilicon/hisi_uncore_pmu.c | 95 drivers/perf/hisilicon/hisi_uncore_pmu.h | 17 ++ 3 files changed, 156 insertions(+) diff --git a/drivers/perf

[PATCH v4 05/11] drivers: perf: hisi: Update Kconfig for Hisilicon PMU support

2017-02-19 Thread Anurup M
Update Kconfig for HiP05/06/07 PMU support. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang Signed-off-by: John Garry --- drivers/perf/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index 4d5c5f9..5b988f5 100644 --- a

[PATCH v4 09/11] drivers: perf: hisi: Miscellanous node(MN) event counting in perf

2017-02-19 Thread Anurup M
d_req/" Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_uncore_mn.c | 490 2 files changed, 491 insertions(+), 1 deletion(-) create mode 100644 drivers/perf/hisilicon/hisi_uncore_

[PATCH v4 07/11] drivers: perf: hisi: Add support for Hisilicon SoC event counters

2017-02-19 Thread Anurup M
cache hardware events. Each L3 cache banks will be registered as separate PMU with perf. 5. L3C events will be listed at /sys/devices/hisi_l3cX_Y/events/ Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang Signed-off-by: John Garry --- drivers/perf/hisilicon/Makefile | 2 +- drivers

[PATCH v4 06/11] drivers: perf: hisi: Add support for Hisilicon Djtag driver

2017-02-19 Thread Anurup M
-by: John Garry Signed-off-by: Anurup M --- drivers/perf/Makefile | 1 + drivers/perf/hisilicon/Makefile | 1 + drivers/perf/hisilicon/djtag.c | 773 drivers/perf/hisilicon/djtag.h | 40 +++ 4 files changed, 815 insertions(+) create mode

[PATCH v4 10/11] drivers: perf: hisi: Handle counter overflow IRQ in MN PMU

2017-02-19 Thread Anurup M
MN1 support IRQ for counter overflow handling. MN1 use the index 26 of the Fabric Totem IRQ. The interrupt parent will be Hisilicon Mbigen-v2. The interrupt type is LPI. Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- drivers/perf/hisilicon/hisi_uncore_mn.c | 121

[PATCH v4 11/11] dts: arm64: hip07: Add Hisilicon SoC PMU support

2017-02-19 Thread Anurup M
1. Add nodes for hip07 L3 cache to support uncore events. 2. Add nodes for hip07 support uncore events. Signed-off-by: Shaokun Zhang Signed-off-by: Anurup M --- arch/arm64/boot/dts/hisilicon/hip07.dtsi | 94 ++-- 1 file changed, 64 insertions(+), 30 deletions

Re: [PATCH v4 08/11] drivers: perf: hisi: use poll method to avoid L3C counter overflow

2017-02-20 Thread Anurup M
Adding Marc. On Monday 20 February 2017 04:39 PM, Mark Rutland wrote: On Sun, Feb 19, 2017 at 01:51:03PM -0500, Anurup M wrote: The L3 cache PMU use N-N SPI interrupt which has no support in kernel mainline. Could you elaborate on what you mean by this? I don't understand what is meant

Re: [PATCH v3 04/10] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

2017-01-11 Thread Anurup M
On Tuesday 10 January 2017 11:25 PM, Mark Rutland wrote: On Mon, Jan 02, 2017 at 01:49:37AM -0500, Anurup M wrote: +The Hisilicon SoC HiP05/06/07 chips consist of various independent system +device PMU's such as L3 cache(L3C) and Miscellaneous Nodes(MN). +These PMU devices are independen

Re: [PATCH v3 00/10] perf: arm64: Support for Hisilicon SoC Hardware event counters

2017-01-11 Thread Anurup M
On Tuesday 10 January 2017 11:13 PM, Mark Rutland wrote: Hi, On Mon, Jan 02, 2017 at 01:47:52AM -0500, Anurup M wrote: ToDo: 1) The counter overflow handling is currently unsupported in this patch series. From a quick scan of the patches, I see mention of an interrupt in a comment the

Re: [PATCH 1/2] sc16is7xx: Do not handle irqs in endless loop

2016-08-09 Thread m . brock
On 2016-08-08 15:32, dirk.eib...@gdsys.cc wrote: From: Dirk Eibach sc16is7xx_port_irq() is laid out as an endless loop. It will exit only when there is no more interrupt left to service. This not common practice. In our case it lead to some strange hangup situation when there was an unexpected

[PATCH 1/5] drm: Add new DCS commands in the enum list

2016-03-28 Thread Deepak M
Adding new DCS commands which are specified in the DCS 1.3 spec related to CABC. v2: Sorted the Macro`s by value (Andrzej) Cc: Andrzej Hajda Cc: Thierry Reding Cc: David Airlie Cc: Ville Syrjälä Cc: Daniel Vetter Suggested-by: Jani Nikula Signed-off-by: Deepak M --- include/video

[PATCH] hwmon: (emc2103) fix unable to change fan pwm1_enable attribute

2020-07-07 Thread Vishwas M
ly. The driver thinks an error has occurred if the (result != 0). This has been fixed by changing the condition to (result < 0). Signed-off-by: Vishwas M --- drivers/hwmon/emc2103.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/hwmon/emc2103.c b/drivers/hwmo

Re: [PATCH v2] 9p/trans_fd: Fix concurrency del of req_list in p9_fd_cancelled/p9_read_work

2020-06-12 Thread wanghai (M)
在 2020/6/12 17:10, Dominique Martinet 写道: Wang Hai wrote on Fri, Jun 12, 2020: p9_read_work and p9_fd_cancelled may be called concurrently. In some cases, req->req_list may be deleted by both p9_read_work and p9_fd_cancelled. We can fix it by ignoring replies associated with a cancelled reque

Re: [PATCH RESEND 04/10] crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf'

2020-08-26 Thread shenyang (M)
On 2020/8/24 16:29, David Laight wrote: From: Yang Shen Sent: 24 August 2020 04:12 Replace 'sprintf' with 'scnprintf' to avoid overrun. Signed-off-by: Yang Shen Reviewed-by: Zhou Wang --- drivers/crypto/hisilicon/zip/zip_main.c | 11 +++ 1 file changed, 7 insertions(+), 4 deletio

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Thanks for another completion of the exception handling. Would an other patch subject be a bit nicer? Thanks for the guidance, I will perfect this description and send a

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the error path of kobject_init_and_add(). Thanks for another completion of the exception handling. Would an

Re: [PATCH] cxl: Fix kobject memory leak in cxl_sysfs_afu_new_cr()

2020-06-02 Thread wanghai (M)
在 2020/6/3 14:50, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 02:34:07PM +0800, wanghai (M) wrote: 在 2020/6/3 14:14, Greg Kroah-Hartman 写道: On Wed, Jun 03, 2020 at 09:42:41AM +0800, wanghai (M) wrote: 在 2020/6/3 1:20, Markus Elfring 写道: Fix it by adding a call to kobject_put() in the

Re: [PATCH] cxl: Fix kobject memleak

2020-06-03 Thread wanghai (M)
在 2020/6/3 19:33, Andrew Donnellan 写道: On 2/6/20 10:07 pm, Wang Hai wrote: Currently the error return path from kobject_init_and_add() is not followed by a call to kobject_put() - which means we are leaking the kobject. Fix it by adding a call to kobject_put() in the error path of kobject_ini

Re: [PATCH RESEND 04/10] crypto: hisilicon/zip - replace 'sprintf' with 'scnprintf'

2020-09-04 Thread shenyang (M)
On 2020/9/4 15:40, Herbert Xu wrote: On Wed, Aug 26, 2020 at 04:56:40PM +0800, shenyang (M) wrote: @@ -514,13 +514,16 @@ static int hisi_zip_core_debug_init(struct hisi_qm *qm) struct debugfs_regset32 *regset; struct dentry *tmp_d; char buf[HZIP_BUF_SIZE

Re: [PATCH RESEND 00/10] crypto: hisilicon/zip - misc clean up

2020-09-02 Thread shenyang (M)
any comment? Thanks, Yang On 2020/8/24 11:11, Yang Shen wrote: This patchset make some clean up: patch 1:remove useless parameters patch 4:replace 'sprintf' with 'scnprintf' patch 7:fix static check warning and the rest patch fix some coding style Resend this patch series because it depends on

Re: [PATCH net-next] net/packet: Remove unused macro BLOCK_PRIV

2020-09-04 Thread wanghai (M)
在 2020/9/4 21:26, Willem de Bruijn 写道: On Fri, Sep 4, 2020 at 3:09 PM Wang Hai wrote: BPDU_TYPE_TCN is never used after it was introduced. So better to remove it. This comment does not cover the patch contents. Otherwise the patch looks good to me. Thanks for your review, I will revise this

Re: [PATCH v4 01/10] crypto: hisilicon/qm - fix wrong release after using strsep

2020-08-04 Thread shenyang (M)
On 2020/8/5 2:34, Markus Elfring wrote: … +++ b/drivers/crypto/hisilicon/qm.c @@ -1420,16 +1420,17 @@ static int qm_dbg_help(struct hisi_qm *qm, char *s) … + s_tmp = s; presult = strsep(&s, " "); if (!presult) { - kfree(s); + kfree(s_tmp);

Re: [PATCH 3/3] PM: runtime: Resume the device earlier in __device_release_driver()

2020-10-22 Thread chenxiang (M)
Hi Rafael, 在 2020/10/22 3:14, Rafael J. Wysocki 写道: From: Rafael J. Wysocki Since the device is resumed from runtime-suspend in __device_release_driver() anyway, it is better to do that before looking for busy managed device links from it to consumers, because if there are any, device_links_un

Re: [PATCH net] devlink: Add missing genlmsg_cancel() in devlink_nl_sb_port_pool_fill()

2020-11-13 Thread wanghai (M)
在 2020/11/13 1:51, Jakub Kicinski 写道: On Wed, 11 Nov 2020 21:58:53 +0800 Wang Hai wrote: If sb_occ_port_pool_get() failed in devlink_nl_sb_port_pool_fill(), msg should be canceled by genlmsg_cancel(). +++ b/net/core/devlink.c @@ -1447,8 +1447,10 @@ static int devlink_nl_sb_port_pool_fill(struc

Re: [PATCH] PCI: dwc: fix error return code in dw_pcie_host_init()

2020-11-16 Thread wanghai (M)
在 2020/11/17 9:49, Jisheng Zhang 写道: On Mon, 16 Nov 2020 21:50:23 +0800 Wang Hai wrote: Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function. good catch. Fixes: 07940c369a6b ("PCI: dwc: Fix MSI page leakage in suspend/resume") R

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-17 Thread xuqiang (M)
在 2020/11/10 17:09, xuqiang (M) 写道: 在 2020/11/9 18:43, Marc Zyngier 写道: On 2020-11-09 03:05, xuqiang (M) wrote: 在 2020/11/8 0:54, Marc Zyngier 写道: [dropping Jason, whose email address has been bouncing for weeks now] On 2020-11-07 10:42, Xu Qiang wrote: On my platform

REPOST: Questions abount driver development and Geniatech X9320 DVB-S/S2 PCIe Tuner

2020-11-05 Thread m . bertens
Original Message Subject: Questions abount driver development and Geniatech X9320 DVB-S/S2 PCIe Tuner Date: 2020-11-02 10:38 From: m.bert...@pe2mbs.nl To: Linux Media Hi, I'm trying to get Geniatech X9320 DVB-S/S2 PCIe Quad Tuner card working, but i'm new to linux kernel

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-05 Thread xuqiang (M)
t's something we need to fix. Thanks, M.

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-05 Thread xuqiang (M)
在 2020/11/5 21:12, Marc Zyngier 写道: Please don't top-post. On 2020-11-05 11:54, xuqiang (M) wrote: The kernel sends three commands in the following sequence: 1.mapd(deviceA, ITT_addr1, valid:1) 2.mapti(deviceA):ITS write ITT_addr1 memory; 3.mapd(deviceA, ITT_addr1, valid:0) and

Re: [PATCH bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-09 Thread wanghai (M)
在 2020/11/9 18:51, Michal Rostecki 写道: On 11/9/20 8:04 AM, Wang Hai wrote: progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai ---   to

Re: [PATCH v2 bpf] tools: bpftool: Add missing close before bpftool net attach exit

2020-11-10 Thread wanghai (M)
在 2020/11/10 12:33, John Fastabend 写道: Wang Hai wrote: progfd is created by prog_parse_fd(), before 'bpftool net attach' exit, it should be closed. Fixes: 04949ccc273e ("tools: bpftool: add net attach command to attach XDP on interface") Signed-off-by: Wang Hai --- v1->v2: use cleanup tag i

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-10 Thread xuqiang (M)
在 2020/11/9 18:43, Marc Zyngier 写道: On 2020-11-09 03:05, xuqiang (M) wrote: 在 2020/11/8 0:54, Marc Zyngier 写道: [dropping Jason, whose email address has been bouncing for weeks now] On 2020-11-07 10:42, Xu Qiang wrote: On my platform, ITS_FLAGS_SAVE_SUSPEND_STATE is not set,thus do nothing

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-06 Thread xuqiang (M)
在 2020/11/5 22:24, Marc Zyngier 写道: On 2020-11-05 14:06, xuqiang (M) wrote: 在 2020/11/5 21:12, Marc Zyngier 写道: Please don't top-post. On 2020-11-05 11:54, xuqiang (M) wrote: The kernel sends three commands in the following sequence: 1.mapd(deviceA, ITT_addr1, valid:1) 2.mapti(de

Re: [PATCH -next] irq-chip/gic-v3-its: Fixed an issue where the ITS executes the residual commands in the queue again when the ITS wakes up from sleep mode.

2020-11-08 Thread xuqiang (M)
e, its); if (err) goto out_free_tables; I'm OK with the patch itself, but I don't want to paper over broken firmware. I'll get TF-A fixed one way or another, but I want to be sure yours is too. If firmware does its job correctly, we shouldn't have to do all of this.     M. Thanks         Xu.

Re: [PATCH v2 07/15] scsi: hisi_sas_v3_hw: use generic power management

2020-07-20 Thread chenxiang (M)
在 2020/7/20 21:34, Vaibhav Gupta 写道: With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-specific ope

Re: [PATCH] net: cxgb3: add missed destroy_workqueue in cxgb3 probe failure

2020-07-18 Thread wanghai (M)
在 2020/7/18 9:39, David Miller 写道: From: Wang Hai Date: Fri, 17 Jul 2020 14:21:17 +0800 The driver forgets to call destroy_workqueue when cxgb3 probe fails. Add the missed calls to fix it. Fixes: 4d22de3e6cc4 ("Add support for the latest 1G/10G Chelsio adapter, T3.") Reported-by: Hulk Robot

Re: [PATCH] net: dsa: felix: Make some symbols static

2020-07-18 Thread wanghai (M)
Thanks for reminding me, I'll do it. 在 2020/7/18 18:40, Vladimir Oltean 写道: On Sat, Jul 18, 2020 at 06:01:58PM +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/dsa/ocelot/felix_vsc9959.c:560:19: warning: symbol 'vsc9959_vcap_is2_keys' was not declared. Should it be static? driver

Re: [PATCH -next] net: ena: use NULL instead of zero

2020-07-19 Thread wanghai (M)
在 2020/7/18 23:06, Joe Perches 写道: On Sat, 2020-07-18 at 19:56 +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer Better to remove the initialization altogether and move the declaration into th

Re: [PATCH v1 07/15] scsi: hisi_sas_v3_hw: use generic power management

2020-07-19 Thread chenxiang (M)
Hi Vaibhav, 在 2020/7/17 14:34, Vaibhav Gupta 写道: With legacy PM, drivers themselves were responsible for managing the device's power states and takes care of register states. After upgrading to the generic structure, PCI core will take care of required tasks and drivers should do only device-sp

Re: [PATCH net-next v2] net: ena: Fix using plain integer as NULL pointer in ena_init_napi_in_range

2020-07-20 Thread wanghai (M)
在 2020/7/20 11:15, Joe Perches 写道: On Mon, 2020-07-20 at 10:53 +0800, Wang Hai wrote: Fix sparse build warning: drivers/net/ethernet/amazon/ena/ena_netdev.c:2193:34: warning: Using plain integer as NULL pointer [] diff --git a/drivers/net/ethernet/amazon/ena/ena_netdev.c b/drivers/net/et

Re: [PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-07-28 Thread wanghai (M)
在 2020/7/25 5:29, Joe Perches 写道: On Fri, 2020-07-24 at 21:00 +0800, Wang Hai wrote: Remove casting the values returned by memory allocation function. Coccinelle emits WARNING: ./drivers/net/ethernet/cavium/liquidio/octeon_device.c:1155:14-36: WARNING: casting value returned by memory allo

Re: [PATCH net-next] liquidio: Remove unneeded cast from memory allocation

2020-07-28 Thread wanghai (M)
在 2020/7/28 17:11, Joe Perches 写道: On Tue, 2020-07-28 at 16:42 +0800, wanghai (M) wrote: 在 2020/7/25 5:29, Joe Perches 写道: On Fri, 2020-07-24 at 21:00 +0800, Wang Hai wrote: Remove casting the values returned by memory allocation function. Coccinelle emits WARNING: ./drivers/net/ethernet

Re: [PATCH] net: cxgb3: add missed destroy_workqueue in nci_register_device

2020-07-17 Thread wanghai (M)
subject msg was wrong. "net: cxgb3:" should be "nfc: nci:".  v2 patch has been sent. ("[PATCH v2] nfc: nci: add missed destroy_workqueue in nci_register_device") 在 2020/7/17 14:18, Wang Hai 写道: When nfc_register_device fails in nci_register_device, destroy_workqueue() shouled be called to dest

Re: [PATCH net-next 0/3] Fix some kernel-doc warnings for e1000/e1000e

2020-09-10 Thread wanghai (M)
在 2020/9/11 3:38, Jakub Kicinski 写道: On Thu, 10 Sep 2020 12:38:00 -0700 Jakub Kicinski wrote: On Thu, 10 Sep 2020 23:04:26 +0800 Wang Hai wrote: Wang Hai (3): e1000e: Fix some kernel-doc warnings in ich8lan.c e1000e: Fix some kernel-doc warnings in netdev.c e1000: Fix a bunch of kern

[PATCH v7 0/9] perf: arm64: Support for Hisilicon SoC Hardware event counters

2017-04-04 Thread Anurup M
hw version. - use devm_kzalloc. - Remove DDRC changes in this series. As the DDRC PMU doesnot depend on djtag it will be send separately. v1 -- -Initial version with support for L3C, MN and DDRC event counters -Djtag driver is used to access registers of L3 cache and MN. Anurup M (6): arm64

[PATCH v7 2/9] dt-bindings: hisi: Add Hisilicon HiP05/06/07 Djtag dts bindings

2017-04-04 Thread Anurup M
From: Tan Xiaojun Add Hisilicon HiP05/06/07 Djtag dts bindings for CPU and IO Die Signed-off-by: Tan Xiaojun Signed-off-by: Anurup M Acked-by: Rob Herring --- .../devicetree/bindings/arm/hisilicon/djtag.txt| 51 ++ 1 file changed, 51 insertions(+) create mode 100644

[PATCH v7 3/9] dt-bindings: perf: hisi: Add Devicetree bindings for Hisilicon SoC PMU

2017-04-04 Thread Anurup M
1) Device tree bindings for Hisilicon SoC PMU. 2) Add example for Hisilicon L3 cache and MN PMU. 3) Add child nodes of L3C and MN in djtag bindings example. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- .../devicetree/bindings/arm/hisilicon/djtag.txt| 29 +++ .../devicetree

[PATCH v7 4/9] Documentation: perf: hisi: Documentation for HiP05/06/07 PMU event counting.

2017-04-04 Thread Anurup M
Documentation for perf usage and Hisilicon SoC PMU uncore events. The Hisilicon SOC has event counters for hardware modules like L3 cache, Miscellaneous node etc. These events are all uncore. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- Documentation/perf/hisi-pmu.txt | 75

[PATCH v7 5/9] drivers: perf: hisi: Update Kconfig for Hisilicon PMU support

2017-04-04 Thread Anurup M
Update Kconfig for HiP05/06/07 PMU support. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang Signed-off-by: John Garry --- drivers/perf/Kconfig | 8 1 file changed, 8 insertions(+) diff --git a/drivers/perf/Kconfig b/drivers/perf/Kconfig index 9365190..248d730 100644 --- a

[PATCH v7 6/9] drivers: perf: hisi: Add support for Hisilicon Djtag driver

2017-04-04 Thread Anurup M
-by: John Garry Signed-off-by: Anurup M --- drivers/perf/Makefile | 1 + drivers/perf/hisilicon/Makefile | 1 + drivers/perf/hisilicon/djtag.c | 684 drivers/perf/hisilicon/djtag.h | 47 +++ 4 files changed, 733 insertions(+) create mode

[PATCH v7 1/9] arm64: MAINTAINERS: hisi: Add hisilicon SoC PMU support

2017-04-04 Thread Anurup M
Add support for Hisilicon SoC hardware event counters for HiP05/06/07 chip versions. Signed-off-by: Anurup M Signed-off-by: Shaokun Zhang --- MAINTAINERS | 10 ++ 1 file changed, 10 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6d7b7a7..4a95977 100644 --- a/MAINTAINERS

[PATCH v7 7/9] drivers: perf: hisi: Add support for Hisilicon SoC event counters

2017-04-04 Thread Anurup M
cache hardware events. Each L3 cache banks will be registered as separate PMU with perf. 5. L3C events will be listed at /sys/devices/hisi_l3cX_Y/events/ 6. L3C PMU in HiP05/06/07 does not support counter overflow IRQ. So hrtimer is used to poll and avoid overflow. Signed-off-by: Anurup M Signed

[PATCH v7 9/9] dts: arm64: hip07: Add Hisilicon SoC PMU support

2017-04-04 Thread Anurup M
Add nodes for djtag, L3 cache and MN to support uncore events. Signed-off-by: Anurup M --- arch/arm64/boot/dts/hisilicon/hip07.dtsi | 87 1 file changed, 87 insertions(+) diff --git a/arch/arm64/boot/dts/hisilicon/hip07.dtsi b/arch/arm64/boot/dts/hisilicon

[PATCH v7 8/9] drivers: perf: hisi: Miscellanous node(MN) event counting in perf

2017-04-04 Thread Anurup M
uot; 3. MN PMU doesnot support counter overflow IRQ in HiP05/06/07, So use hrtimer to poll and avoid counter overflow. Signed-off-by: Shaokun Zhang Signed-off-by: Dikshit N Signed-off-by: Anurup M --- drivers/perf/hisilicon/Makefile | 2 +- drivers/perf/hisilicon/hisi_uncore_

Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon SoC event counters

2017-03-30 Thread Anurup M
On Tuesday 21 March 2017 10:22 PM, Mark Rutland wrote: +static int hisi_hw_perf_event_init(struct perf_event *event) >+{ >+ struct hw_perf_event *hwc = &event->hw; >+ struct hisi_pmu *hisi_pmu = to_hisi_pmu(event->pmu); >+ struct device *dev = hisi_pmu->dev; + >+ /* >+* We must NOT

Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon SoC event counters

2017-03-31 Thread Anurup M
On Thursday 30 March 2017 04:16 PM, Mark Rutland wrote: + /* > >>>+ * We must NOT create groups containing mixed PMUs, although > >>>+ * software events are acceptable > >>>+ */ > >>>+ if (event->group_leader->pmu != event->pmu && > >>>+ !is_software_event(

Re: [PATCH v6 07/11] drivers: perf: hisi: Add support for Hisilicon SoC event counters

2017-03-31 Thread Anurup M
On Friday 31 March 2017 07:53 PM, Mark Rutland wrote: On Fri, Mar 31, 2017 at 07:43:20PM +0530, Anurup M wrote: On Thursday 30 March 2017 04:16 PM, Mark Rutland wrote: + /* +* We must NOT create groups containing mixed PMUs, although +* software events are acceptable

[PATCH 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is automatically freed on driver

[PATCH 0/3] staging: ccree: Employ devm_* functions, remove redundant code

2017-07-15 Thread sunil . m
From: Suniel Mahesh Hi This patch series replaces the current API's which request for device resources in driver probe, with devm_*() functions of the kernel framework as recommended by the kernel community. Doing so simplifies driver cleanup paths and code organization. The current set of A

[PATCH 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with devm_ioremap_resource(). (b) remove struct

[PATCH 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

2017-07-15 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with platform_get_irq() and devm_request_irq(

[PATCH v2 1/3] staging: ccree: Replace kzalloc with devm_kzalloc

2017-07-18 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_kzalloc, which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace kzalloc with devm_kzalloc. (b) drop kfree(), because memory allocated with devm_kzalloc() is automatically freed on driver

[PATCH v2 3/3] staging: ccree: Use platform_get_irq and devm_request_irq

2017-07-18 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_request_irq(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace platform_get_resource(), request_irq() and corresponding error handling with platform_get_irq() and devm_request_irq(

[PATCH v2 2/3] staging: ccree: Convert to devm_ioremap_resource for map, unmap

2017-07-18 Thread sunil . m
From: Suniel Mahesh It is recommended to use managed function devm_ioremap_resource(), which simplifies driver cleanup paths and driver code. This patch does the following: (a) replace request_mem_region(), ioremap() and corresponding error handling with devm_ioremap_resource(). (b) remove struct

[PATCH] staging: ccree: Fix unnecessary NULL check before kfree'ing it

2017-07-20 Thread sunil . m
From: Suniel Mahesh kfree(NULL) is safe and their is no need for a NULL check. Pointed out by checkpatch. Signed-off-by: Suniel Mahesh --- Note: - Patch was compile tested and built(ARCH=arm) on next-20170719. No build issues reported. --- drivers/staging/ccree/ssi_hash.c | 25 --

Re: linux-next: Signed-off-by missing for commit in the scsi tree

2017-12-18 Thread chenxiang (M)
在 2017/12/19 12:27, Martin K. Petersen 写道: Stephen, 9188808c7760 ("scsi: hisi_sas: fix SAS_QUEUE_FULL problem while running IO") is missing a Signed-off-by from its author. John? Hi Stephen and Martin, John is on vacation. I have checked it and please add a "Signed-off-by: Xiang Chen "

[PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics

2017-08-22 Thread sunil . m
From: Suniel Mahesh Linux bus numbers should match the numbers defined by the chip manufacturer. This patch add's spi aliases to acheive that bus naming convention. Signed-off-by: Suniel Mahesh Signed-off-by: Karthik Tummala Tested-by: Karthik Tummala --- Note: - Patch was compile tested and

[PATCH] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-16 Thread sunil . m
From: Suniel Mahesh ti-cpufreq.c and cpufreq-dt-platdev.c are registering platform device with same name "cpufreq-dt" using platform_device_register_*() routines. This is leading to build warnings appended below. This patch does the following: (a) Remove platform-device registration routine from

[PATCH v2] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-18 Thread sunil . m
From: Suniel Mahesh ti-cpufreq and cpufreq-dt-platdev drivers are registering platform-device with same name "cpufreq-dt" using platform_device_register_*() routines. This is leading to build warnings appended below. Providing hardware information to OPP framework along with the platform- device

[RESEND PATCH] arm: dts: am33xx: Add spi alias to match SOC schematics

2017-09-10 Thread sunil . m
From: Suniel Mahesh Linux bus numbers should match the numbers defined by the chip manufacturer. This patch add's spi aliases to acheive that bus naming convention. Signed-off-by: Suniel Mahesh Signed-off-by: Karthik Tummala Tested-by: Karthik Tummala --- Note: - Patch was compile tested and

Re: [Linux-graphics-maintainer] No mouse cursor since 36cc79bc9077319c04bd3b132edcacaa9a0d9f2b

2017-05-10 Thread m . t
t master from > > https://urldefense.proofpoint.com/v2/url?u=https-3A__git.kernel.org_pub_scm_linux_&d=DwICAg&c=uilaK90D4TOVoH58JNXRgQ&r=j2ey7nuAQ5d6NbMmCOnRsTIJfmv7blo3UCKagbsM9o2-No8JdlhkKK3ty481ErVu&m=DWnNRbcrxMhc78PIvembLdV3OsJi3vPwcdG03kqVpJo&s=mc7-KF2t4BktXs11MShGZB

Re: [Linux-graphics-maintainer] No mouse cursor since 36cc79bc9077319c04bd3b132edcacaa9a0d9f2b

2017-05-10 Thread m . t
2017 09:17 AM, m.t wrote: > > > > Hi, > > > > I don't have a mouse cursor in my virtual machine (vmware workstation > > > > 12.5.5 > > > > build-5234757) with latest master from > > > > https://urldefense.proofpoint.

Re: [Linux-graphics-maintainer] No mouse cursor since 36cc79bc9077319c04bd3b132edcacaa9a0d9f2b

2017-05-31 Thread m . t
> m...@ox.io hat am 11. Mai 2017 um 07:38 geschrieben: > > > > > Sinclair Yeh hat am 10. Mai 2017 um 18:46 geschrieben: > > > > > > Hi, > > Hi, > > > On Wed, May 10, 2017 at 12:31:39PM +0200, m.t wrote: > > > >

[PATCH] arm: dts: am33xx: Remove redundant interrupt-parent property

2017-06-05 Thread sunil . m
From: Suniel Mahesh Interrupt-parent property is defined in the root node as "interrupt-parent = <&intc>". This interrupt-parent value becomes the default for the system, so removed redundant "interrupt-parent" property from mmc, mac, lcdc and tscadc nodes. Signed-off-by: Suniel Mahesh --- arc

[PATCH] staging: wlan-ng: Amend type mismatch warnings

2017-06-12 Thread sunil . m
From: Suniel Mahesh The following type mismatch warnings reported by sparse have been amended: warning: cast to restricted __le16 warning: incorrect type in assignment (different base types) Signed-off-by: Suniel Mahesh --- drivers/staging/wlan-ng/prism2mgmt.c | 22 +++--- 1 fi

[PATCH v3] staging: ccree: Convert to platform_{get,set}_drvdata()

2017-10-04 Thread sunil . m
From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using &plat_dev->dev. For wrapper functions we can directly pass a struct platform_device

[PATCH] staging: ccree: local variable "dev" not required

2017-10-04 Thread sunil . m
From: Suniel Mahesh There is no need to create a local pointer variable "dev" and pass it various API's, instead use plat_dev which is enumerated by platform core on successful probe. Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and built(ARCH=arm) on staging-testing. - No build is

[PATCH] staging: ccree: Convert to platform_{get,set}_drvdata()

2017-09-21 Thread sunil . m
From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using &plat_dev->dev. For wrapper functions we can directly pass a struct platform_device

[PATCH v2] staging: ccree: Convert to platform_{get,set}_drvdata()

2017-09-21 Thread sunil . m
From: Suniel Mahesh Platform devices are expected to use wrapper functions, platform_{get,set}_drvdata() with platform_device as argument, for getting and setting the driver data. dev_{get,set}_drvdata() are using &plat_dev->dev. For wrapper functions we can directly pass a struct platform_device

[PATCH v3] drivers: cpufreq: Fix sysfs duplicate filename creation for platform-device

2017-09-21 Thread sunil . m
From: Suniel Mahesh ti-cpufreq and cpufreq-dt-platdev drivers are registering platform-device with same name "cpufreq-dt" using platform_device_register_*() routines. This is leading to build warnings appended below. Providing hardware information to OPP framework along with the platform- device

[PATCH] staging: ccree: else is not generally useful after a break or return

2017-09-21 Thread sunil . m
From: Suniel Mahesh Fixes checkpatch warnings: WARNING: else is not generally useful after a break or return Signed-off-by: Suniel Mahesh --- Note: - Patch was tested and built(ARCH=arm) on next-20170921. No build issues reported. --- drivers/staging/ccree/ssi_request_mgr.c | 5 ++--- 1 fil

[PATCH] drivers: spi: Pick spi bus number from Linux idr or spi alias

2017-08-02 Thread sunil . m
From: Suniel Mahesh Modify existing code, for automatically picking the spi bus number based on Linux idr scheme as mentioned in FIXME. This patch does the following: (a) Remove the now unnecessary code which was allocating bus numbers using ATOMIC_INIT and atomic_dec_return macro's. (b) If we ha

[PATCH v2] staging: wlan-ng: Amend type mismatch warnings

2017-06-14 Thread sunil . m
From: Suniel Mahesh le16_to_cpu() accepts argument of type __le16 and cpu_to_le16() returns an argument of type __le16. This patch fixes warnings related to incorrect type in assignment and changes the types in the corresponding header file. The following type mismatch warnings reported by sparse

<    1   2   3   4   5   6   7   8   9   10   >