RE: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.

2014-09-03 Thread li.xi...@freescale.com
Hi Thomas, Thanks very much for your comments. Firstly I must tell the true that English is not my mother language. > Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler > calculation. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > We should minus one after calculatin

RE: [PATCH 5/5] Clocksource: Flextimer: Use Macro for clock source selection.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 5/5] Clocksource: Flextimer: Use Macro for clock source > selection. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > FTM source clock is selectable: > > Source clock can be the system clock, the fixed frequency clock, > > or an external clock. > > Fixed frequency clock is an ad

RE: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler calculation.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 4/5] Clocksource: Flextimer: Fix counter clock prescaler > calculation. > > On Tue, 26 Aug 2014, Xiubo Li wrote: > > > We should minus one after calculating the counter input clock's > > prescaler. > > > > Signed-off-by: Xiubo Li > > Signed-off-by: Jingchang Lu > > --- > >

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
> > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > On LS2 platform. > > > > And ftm_clocksource_read_up() will adapt to this different. > > You are missing the point. Why do you want a conditional in a hot > path? You know at init time whether the thing is BE or L

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE mode > > > > On LS2 platform. > > > > > > > > And ftm_clocksource_read_up() will adapt to this different. > > > > > > You are missing the point. Why do you want a conditional in a hot > > > path? You know at ini

RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read API.

2014-09-04 Thread li.xi...@freescale.com
Hi Thomas, > Subject: RE: [PATCH 2/5] Clocksource: Flextimer: Use internal clocksource read > API. > > Hi Thomas, > > > > > > Since the FTM will be in BE mode on LS1 platform, but will be in LE > mode > > > > > On LS2 platform. > > > > > > > > > > And ftm_clocksource_read_up() will adapt to this

RE: [PATCHv2] watchdog: imx2_wdt: Convert to use regmap framework's endianness method.

2014-09-05 Thread li.xi...@freescale.com
Hi, Ping :) Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, August 25, 2014 3:55 PM > To: w...@iguana.be; li...@roeck-us.net; m...@pengutronix.de; linux- > watch...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; devicet...@vg

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-08-31 Thread li.xi...@freescale.com
Hi Mark, Kuninori-san, Very sorry, I just missed that patch series. See the next version. Thanks, BRs Xiubo > -Original Message- > From: Mark Brown [mailto:broo...@kernel.org] > Sent: Friday, August 29, 2014 8:01 PM > To: Xiubo Li-B47053 > Cc: alsa-de...@alsa-project.org; linux-kern

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-08-31 Thread li.xi...@freescale.com
> > --- > > > > Hi, > > > > This patch will break the old DT, so i just send one RFC version, and > > will add the old DT patches in next version if this patch can work > > well. > > > > Any comments and advices are welcome. > > Hi Xiubo, > > My DT is > > sound { > compatible

RE: [PATCHv2 1/2] ASoC: simple-card: Fix bug of forgetting decrement DT node's refcount

2014-08-31 Thread li.xi...@freescale.com
> > Signed-off-by: Xiubo Li > > --- > > sound/soc/generic/simple-card.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple- > card.c > > index fd8b045..9e170fe 100644 > > --- a/sound/soc/generic/simple-card.c > > +++ b/sound/

RE: [PATCHv2 2/2] ASoC: simple-card: Fix bug of wrong decrement DT node's refcount

2014-09-01 Thread li.xi...@freescale.com
> > DAI links's cpu_of_node's and codec_of_node's refcounts shouldn't > > be decremented immediately at the end of the probe() fucntion. > > Because we will still use them before the audio card is removed. > > Right, but your patch seems a bit complicated. See below. > > > > > Signed-off-by: Xiub

RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
> Hi Xiubo > > Thank you for your patch. > This clean-up is very nice for me. > But, I have 1 small comment > > > asoc_simple_card_sub_parse_of(struct device_node *np, > > struct asoc_simple_dai *dai, > > struct device_node **p_node, > > -

RE: [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-01 Thread li.xi...@freescale.com
> > On Mon, Sep 01, 2014 at 03:34:12PM +0200, Andrew Lunn wrote: > > On Mon, Sep 01, 2014 at 12:29:35PM +0800, Xiubo Li wrote: > > > This patch merge single DAI link and muti-DAI links code together, > > > and simply the simple-card driver code. > > > It would be good to note that this breaks the

RE: [RFC][PATCH] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-02 Thread li.xi...@freescale.com
Hi Jyri, I'll follow Mark's advice of maintaining compatibility with the old DTs. Thanks very much for your comments, and this is very important for me. And I will also update the binding documet for simple card, please help me review it, any comment and advice are welcome. The goal is to simpl

RE: [PATCHv1 4/7] ASoC: dts: kirkwood-t5325: To support simple card newest style.

2014-09-02 Thread li.xi...@freescale.com
Hi Andrew, Thanks very much for you comment and advice. I will resend this patch series to compatibility with the old DTs, and it will Up to the owners to update the DTs to support the new style of DTs. BRs Xiubo > -Original Message- > From: Andrew Lunn [mailto:and...@lunn.ch] > Sent

RE: [alsa-devel] [PATCHv1 1/7] ASoC: simple-card: Merge single and muti DAI link code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san This patch series will break the old DTs, and I will follow Mark's Advice to maintain compatibility with the old DTs. I will send another version, please help me to review it. And I will also split the update patch series to many small ones. Thanks very much, BRs Xiubo > -O

RE: [PATCHv2 4/4] ASoC: simple-card: binding: update binding to support the new style.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 4/4] ASoC: simple-card: binding: update binding to > support the new style. > > On Tue, 2 Sep 2014 17:26:09 +0800 > Xiubo Li wrote: > > > +Example 4 - many DAI links: > > sound { > > compatible = "simple-audio-card"; > > simple-audio-card,name = "Cubox Audio"; >

RE: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple > card. > > On Tue, 2 Sep 2014 17:26:08 +0800 > Xiubo Li wrote: > > > @@ -285,11 +287,11 @@ static int asoc_simple_card_dai_link_of(struct > device_node *node, > > dai_props->codec_dai.sysclk); > > > >

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san, Yes, I think it make sense to set all fmt in one function, and will Be more readable. I agree with you, could you please just wait, because there has many Replications and good Ideas about this patch, and I will revise it. Then you can improve it as your patch blow. Thanks, BR

RE: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments of simple card.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 3/4] ASoC: simple-card: Adjust the comments > of simple card. > > > Hi Xiubo > > > > > /* > > > > -* soc_bind_dai_link() will check cpu name > > > > -* after of_node matching if dai_link has cpu_dai_name. > > > > -* but, it wil

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/02/2014 12:26 PM, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > --- > > sound/soc/generic/simple-card.c | 61 - > > > 1 file changed

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
Hi Kuninori-san, Yes your patch has fixed the bug Jyri has pointed out. So I has discard my [PATCHv2 1/4] patch. Please send your patch out to replace this one. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li-B47053 > Sent: Wednesday, September 03, 2014 10:22 AM > To: 'Kunin

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() to simplify the code. > > > Hi Xiubo > > > Yes, I think it make sense to set all fmt in one function, and will > > Be more readable. > > > > I agree with you, could you please just wait, because ther

RE: [PATCH 0/5] Clocksource: Flextimer: Merged to LS1

2014-09-02 Thread li.xi...@freescale.com
Ping :) Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, August 26, 2014 1:46 PM > To: daniel.lezc...@linaro.org; t...@linutronix.de > Cc: Wang Dongsheng-B40534; linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH 0/5

RE: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [alsa-devel] [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() to simplify the code. > > > Hi Xiubo > > > Yes your patch has fixed the bug Jyri has pointed out. > > > > So I has discard my [PATCHv2 1/4] patch. > > > > Please send your patch out to replace this o

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: > >> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > ... > &

RE: [PATCHv6 0/2] add DT endianness binding support for regmap

2014-08-05 Thread li.xi...@freescale.com
Hi, I'd like to know the status about this patch series, there are many patches Based the Regmap still waiting for these. Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Tuesday, July 15, 2014 12:23 PM > To: broo...@kernel.org; mark.rutl..

RE: [PATCH] i2c: i2c-imx: Fix format warning for dev_dbg

2014-08-05 Thread li.xi...@freescale.com
> > drivers/i2c/busses/i2c-imx.c: In function i2c_imx_probe() > > drivers/i2c/busses/i2c-imx.c:689:2: warning: format 0x%x expects argument > > of type unsigned int, but argument 4 has type resource_size_t [-Wformat=] > > dev_dbg(&i2c_imx->adapter.dev, "device resources from 0x%x to 0x%x\n", > []

RE: [PATCHv2] i2c: i2c-imx: Fix format warning for dev_dbg

2014-08-05 Thread li.xi...@freescale.com
Hi Jingoo, Thanks for your advice. This patch is mainly resolving the warning issue. And some thing like : 'i2c: i2c-imx: Fix format warning for dev_db' Could be more obvious. I think adding 'printf extension %pR for struct resource' to the commit comment will better. BRs Xiubo > -Orig

RE: [PATCH] audio: sai: Add Power Management support

2014-10-29 Thread li.xi...@freescale.com
Hi, > -Original Message- > From: linux-arm-kernel [mailto:linux-arm-kernel-boun...@lists.infradead.org] > On Behalf Of Mark Brown > Sent: Wednesday, October 29, 2014 7:37 PM > To: Wang Huan-B18965 > Cc: alsa-de...@alsa-project.org; ti...@suse.de; linux-kernel@vger.kernel.org; > lgirdw...@

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-10-27 Thread li.xi...@freescale.com
Hi Thierry, Ping... Thanks, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, October 15, 2014 1:22 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH v2 0

RE: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init().

2014-10-13 Thread li.xi...@freescale.com
Hi Mark, > Subject: Re: [PATCH 2/6] regmap: cache: cleanup regcache_hw_init(). > > On Thu, Oct 09, 2014 at 05:02:53PM +0800, Xiubo Li wrote: > > Remove the redundant code for regmap cache. > > Applied, thanks. With changes like this it is much better if the > changelog explains why the code is

RE: [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer dereferencing error.

2014-10-13 Thread li.xi...@freescale.com
> Subject: Re: [PATCH 6/6] regmap: cache: Fix possible ZERO_SIZE_PTR pointer > dereferencing error. > > On Thu, Oct 09, 2014 at 05:02:57PM +0800, Xiubo Li wrote: > > When all the registers are volatile(unlikely, but logically and mostly > > will happen for some 'device' who has very few registers)

RE: [PATCH] mfd: syscon: binding: Add syscon endianness support.

2014-10-13 Thread li.xi...@freescale.com
Hi DT guys, Could someone help me review or ack this patch? Thanks very much. BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Thursday, September 18, 2014 3:27 PM > To: Dong Aisheng-B29396; pankaj.du...@samsung.com; robh...@kernel.org; > pawel.m

RE: [PATCH v3] ARM: ls1021a: add gating clocks to IP blocks.

2014-10-15 Thread li.xi...@freescale.com
Hi Shawn, [...] > > + DCFG_CCSR_DEVDISR1, > > + ls1021a_clk_shift(0)); > > I think we can ignore the 80 columns warning and put these on one line > to make the code a bit easier to read. > Yes, it looks better,

RE: [PATCH 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-11-30 Thread li.xi...@freescale.com
Hi, I'd like to know the status of this patches for internal release needed. Thanks very much, BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Monday, November 24, 2014 6:21 PM > To: plagn...@jcrosoft.com; tomi.valkei...@ti.com > Cc: shawn@li

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-11-30 Thread li.xi...@freescale.com
Ping :) . Thanks very much. BRs Xiubo > -Original Message- > From: Xiubo Li [mailto:li.xi...@freescale.com] > Sent: Wednesday, October 15, 2014 1:22 PM > To: thierry.red...@gmail.com; linux-...@vger.kernel.org > Cc: linux-kernel@vger.kernel.org; Xiubo Li-B47053 > Subject: [PATCH v2 0/3

RE: [PATCH v2 0/3] pwm: ftm: add Power Management support

2014-12-01 Thread li.xi...@freescale.com
> Subject: Re: [PATCH v2 0/3] pwm: ftm: add Power Management support > > On Mon, Dec 01, 2014 at 03:25:02AM +0000, li.xi...@freescale.com wrote: > > Ping :) . > > > > Thanks very much. > > Applied with a few whitespace cleanups. > Hi Thierry, Thanks verrr

RE: [PATCH 1/4] video: fsl-dcfb: Add dcfb framebuffer driver for LS1021A platform

2014-12-01 Thread li.xi...@freescale.com
Hi Alexander, Thanks very much for your comments. > On Monday 24 November 2014 18:20:51, Xiubo Li wrote: > > [...] > > +static int fsl_dcfb_init_fbinfo(struct fb_info *info) > > +{ > > + struct fsl_dcfb_mfb_info *mfbi = info->par; > > + struct fb_var_screeninfo *var = &info->var; > > + stru

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-03 Thread li.xi...@freescale.com
Hi Arnd, Thanks for you advice. Because this is very emergency for customers and have delayed for monthes, and the DRM/KMS will have a little long time to be supported. So I'd like to add this first and will add DRM/KMS version later. Thanks very much, BRs Xiubo > -Original Message-

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
awn@linaro.org; alexander.stein@systec- > electronic.com > Subject: Re: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support. > > Hi Xiubo, > > On 04/12/14 03:56, li.xi...@freescale.com wrote: > > Hi Arnd, > > > > Thanks for you advice. > > > >

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
Hi Tomi, Thanks for your information very much. > > Sorry for confusing, it was delayed for other reasons internal. > > > > I am not familiar about the DRM, and I'd like to know if the DRM driver will > be > > support, should I also develop the libdrm too ? Or just coding in kernel > level ? > >

RE: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support.

2014-12-04 Thread li.xi...@freescale.com
t.com; linux-fb...@vger.kernel.org; linux- > ker...@vger.kernel.org; shawn@linaro.org; alexander.stein@systec- > electronic.com > Subject: Re: [PATCHv2 0/4] LS1021A: Add dcfb framebuffer driver support. > > On 04/12/14 11:54, li.xi...@freescale.com wrote: > > Hi Tomi, > >

<    1   2   3