Re: [PATCH 0/5] mt8173 spi multiple devices support

2015-10-25 Thread lei liu
Hi Mark, On Mon, 2015-10-19 at 20:27 +0100, Mark Brown wrote: > On Wed, Oct 14, 2015 at 11:23:30AM +0800, Leilk Liu wrote: > > This series are based on 4.3-rc1 and provide 5 patches to support > > mt8173 spi multiple devices. > > This doesn't apply against current code, please check and resend.

Re: [PATCH 5/5] arm64: dts: spi bus dts support multiple devices

2015-10-25 Thread lei liu
Hi Sascha, On Wed, 2015-10-14 at 07:58 +0200, Sascha Hauer wrote: > On Wed, Oct 14, 2015 at 11:23:35AM +0800, Leilk Liu wrote: > > This patch support multiple devices for MT8173. > > The subject of this patch and also the above sentence should contain the > board name this patch is changing so th

Re: [PATCH v3 1/3] spis: mediatek: add bindings for Mediatek MT2712 soc platform

2018-09-26 Thread lei liu
On Wed, 2018-09-26 at 17:33 -0500, Rob Herring wrote: > On Mon, Sep 17, 2018 at 10:19:20AM +0800, Leilk Liu wrote: > > This patch adds a DT binding documentation for the MT2712 soc. > > > > Signed-off-by: Leilk Liu > > --- > > .../devicetree/bindings/spi/spi-slave-mt27xx.txt | 32 > > ++

Re: [PATCH 1/2] spi: mediatek: Add bindings for mediatek MT7629 soc platform

2018-11-22 Thread lei liu
On Tue, 2018-11-20 at 11:28 +0100, Matthias Brugger wrote: > > On 20/11/2018 09:41, Leilk Liu wrote: > > This patch adds a DT binding documentation for the MT7629 soc. > > > > Signed-off-by: Leilk Liu > > --- > > .../devicetree/bindings/spi/spi-mt65xx.txt |1 + > > 1 file changed, 1

Re: [PATCH 19/24] dt-bindings: spi: spi-mt65xx: add support for MT8516

2019-04-16 Thread lei liu
On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote: > > On 23/03/2019 22:16, Fabien Parent wrote: > > Add binding documentation of spi-mt65xx for MT8516 SoC. > > > > Signed-off-by: Fabien Parent > > --- > > Documentation/devicetree/bindings/spi/spi-mt65xx.txt | 1 + > > 1 file changed, 1

Re: [PATCH 19/24] dt-bindings: spi: spi-mt65xx: add support for MT8516

2019-04-18 Thread lei liu
On Thu, 2019-04-18 at 10:05 +0200, Fabien Parent wrote: > On Tue, Apr 16, 2019 at 10:25 AM lei liu wrote: > > > > On Tue, 2019-04-16 at 09:55 +0200, Matthias Brugger wrote: > > > > > > On 23/03/2019 22:16, Fabien Parent wrote: > > > > Add bindi

Re: [PATCH] spi: mediatek: fix spi incorrect endian usage and remove redundant clock

2015-08-18 Thread lei liu
On Tue, 2015-08-18 at 14:19 +0200, Jonas Gorski wrote: > Hi, > > On Tue, Aug 18, 2015 at 12:53 PM, Leilk Liu wrote: > > This patch fixes incorrect endian usage, removes redundant > > clock in prepare_hardware/unprepare_hardware and revises > > coding styles. > > > > Signed-off-by: Leilk Liu > >

Re: [PATCH] spi: Mediatek: fix endian warnings

2015-08-12 Thread lei liu
Hello Mark, This patch is applied, should I append a new patch or you rollback it? Thanks. On Wed, 2015-08-12 at 16:45 +0200, Jonas Gorski wrote: > Hi, > > On Tue, Aug 11, 2015 at 12:43 PM, Leilk Liu wrote: > > This patch fixes endian warnings detected by sparse: > > - sparse: incorrect type i

Re: [PATCH v5 3/3] arm64: dts: Add spi bus dts

2015-08-12 Thread lei liu
> > + spi: spi@1100a000 { > > + compatible = "mediatek,mt8173-spi"; > > + #address-cells = <1>; > > + #size-cells = <0>; > > + reg = <0 0x1100a000 0 0x1000>; > > + interrupts

Re: [v5,2/3] spi: mediatek: Add spi bus for Mediatek MT8173

2015-08-12 Thread lei liu
Hi, > > +#include > > +#include > > +#include > > +#include > > Since you are using readl/writel, please import linux/io.h as well (it > is implicitly imported by spi/spi.h, but better be safe...) > OK, I'll fix it. > > +#include > > +#include > > +#include > > + > > +#define SPI_CMD_AC

Re: [PATCH v2] spi: mediatek: single device does not require cs_gpios

2015-11-13 Thread lei liu
On Mon, 2015-11-09 at 12:14 +0800, Nicolas Boichat wrote: > When only one device is present, it is not necessary to specify > cs_gpios, as the CS line can be controlled by the hardware > module. > > Without this patch, older device tree bindings used before > 37457607 "spi: mediatek: mt8173 spi mu

Re: [PATCH v2] spi: mediatek: revise mtk_spi_probe() failure flow

2015-11-25 Thread lei liu
On Tue, 2015-11-24 at 19:12 +0100, Matthias Brugger wrote: > > On 24/11/15 03:38, Leilk Liu wrote: > > This patch revises failure flow while pm_runtime_enable(). > > Please write a proper commit message explaining what this patch does. > OK, thanks! > > > > Signed-off-by: Leilk Liu > > --- > >

Re: [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow

2015-11-25 Thread lei liu
On Tue, 2015-11-24 at 13:04 +, Mark Brown wrote: > On Tue, Nov 24, 2015 at 10:33:24AM +0800, lei liu wrote: > > On Sat, 2015-11-21 at 13:39 +, Mark Brown wrote: > > > On Fri, Nov 20, 2015 at 10:21:19AM +0800, Leilk Liu wrote: > > > > > This

Re: [PATCH 4/4] spi: mediatek: revise mtk_spi_probe() failure flow

2015-11-23 Thread lei liu
On Sat, 2015-11-21 at 13:39 +, Mark Brown wrote: > On Fri, Nov 20, 2015 at 10:21:19AM +0800, Leilk Liu wrote: > > This patch revises failure flow while pm_runtime_enable(). > > Why? This also doesn't apply against current code, please check and > resend. I don't know. I can git am this patch

Re: [PATCH v3 2/3] spis: mediatek: add spi slave for Mediatek MT2712

2018-09-18 Thread lei liu
Hi Mark, Thanks for your comments. On Tue, 2018-09-18 at 09:30 -0700, Mark Brown wrote: > On Mon, Sep 17, 2018 at 10:19:21AM +0800, Leilk Liu wrote: > > This looks overall pretty good, a few smallish comments below: > > Please use subject lines matching the style for the subsystem. This > mak

Re: [spi:topic/mtk 2/2] drivers/spi/spi-mt65xx.c:362:24: sparse: incorrect type in argument 1 (different base types)

2015-08-10 Thread lei liu
Hello Mark, On Fri, 2015-08-07 at 22:33 +0800, kbuild test robot wrote: > tree: git://git.kernel.org/pub/scm/linux/kernel/git/broonie/spi topic/mtk > head: a568231f463225eb31593f71446a267a03ae0528 > commit: a568231f463225eb31593f71446a267a03ae0528 [2/2] spi: mediatek: Add spi > bus for Mediat

Re: [PATCH] dt-bindings: spi: update bindings for MT8192 SoC

2020-07-21 Thread lei liu
On Tue, 2020-07-21 at 10:48 +0100, Mark Brown wrote: > On Tue, Jul 21, 2020 at 10:48:19AM +0800, Leilk Liu wrote: > > From: "leilk.liu" > > > > Add a DT binding documentation for the MT8192 soc. > > I'd expect to see a matching driver patch. OK,I'll send patch v2. Thanks.

Re: [PATCH 2/3] spi: mediatek: support adjust register define

2017-06-07 Thread lei liu
On Tue, 2017-06-06 at 19:57 +0100, Mark Brown wrote: > On Fri, Jun 02, 2017 at 03:18:42PM +0800, Leilk Liu wrote: > > > + /* some IC design adjust register define */ > > + bool adjust_reg; > > Can we have a name that's more specific to the particular quirk please? > The current name will get