From: Laurentiu Tudor
Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc
From: Laurentiu Tudor
dpni.c is using byte order macros and error codes but does
not explicitly include the required kernel header, so add it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-dpaa2/ethernet/dpni.c | 2 ++
1 file changed, 2 insertions(+)
diff --git a/drivers/staging/fsl-
From: Laurentiu Tudor
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 -
2
From: Laurentiu Tudor
Mixing two memory management systems, in this case
managed device resource api and refcounted objects
is a bad idea. Lifetime of an object is controlled
by its refcount so allocating it with other apis
that have their own lifetime control is not ok.
Drop devm_*() apis in fav
From: Laurentiu Tudor
It was used just to sanity check some obscure
cases that are unlikely to ever happen.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/staging/
From: Laurentiu Tudor
These APIs are not used yet, so drop the dead code.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
Also in this patch, add missing prototype for
From: Laurentiu Tudor
When hot unplugging a mc-bus device the kernel displays
this pertinent message, followed by a stack dump:
"Device 'foo.N' does not have a release() function,
it is broken and must be fixed."
Add the required callback to fix.
Signed-off-by: Laurentiu Tudor
---
dri
From: Laurentiu Tudor
First 4 patches fix several driver model related
issues and drop an useless atomic global.
The rest of the patches are cleanups mostly
consisting in removing dead code.
For context, see these threads:
https://lkml.org/lkml/2016/12/7/382
https://lkml.org/lkml/2017/1/3/437
L
From: Laurentiu Tudor
Leave only APIs that area actually used in the bus driver.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed
From: Laurentiu Tudor
The implementation was removed in commit:
decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x)
but the prototype was left behind.
Also fix a message that was wrongly mentioning it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bu
From: Laurentiu Tudor
Leave only APIs that will be used in upcomming drivers.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed ba
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c
b/drivers/staging/fsl-mc/bus/dpbp.c
index 1fa7257..d9e450a 100644
--- a/drivers/staging/fsl-mc/bus/dpbp.c
+++ b/dr
From: Laurentiu Tudor
The implementation was removed in commit:
decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x)
but the prototype was left behind.
Also fix a message that was wrongly mentioning it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bu
From: Laurentiu Tudor
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 1 -
2
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c
b/drivers/staging/fsl-mc/bus/dpbp.c
index 1fa7257..d9e450a 100644
--- a/drivers/staging/fsl-mc/bus/dpbp.c
+++ b/dr
From: Laurentiu Tudor
First 4 patches fix several driver model related
issues and drop an useless atomic global.
The rest of the patches are cleanups mostly
consisting in removing dead code.
v2:
- split slab cache removal in distinct patch
- redundant deallocation dropped in patch that adds re
From: Laurentiu Tudor
Let's drop the slab cache for objects
until we actually have proof that it improves
performance. This makes the code cleaner.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 17 +++--
1 file changed, 3 insertions(+), 14 deletions(-
From: Laurentiu Tudor
When hot unplugging a mc-bus device the kernel displays
this pertinent message, followed by a stack dump:
"Device 'foo.N' does not have a release() function,
it is broken and must be fixed."
Add the required callback to fix and drop the now
uneeded explicit freeing.
From: Laurentiu Tudor
Mixing two memory management systems, in this case
managed device resource api and refcounted objects
is a bad idea. Lifetime of an object is controlled
by its refcount so allocating it with other apis
that have their own lifetime control is not ok.
Drop devm_*() apis in fav
From: Laurentiu Tudor
Leave only APIs that area actually used in the bus driver.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed
From: Laurentiu Tudor
These APIs are not used yet, so drop the dead code.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
Also in this patch, add missing prototype for
From: Laurentiu Tudor
Leave only APIs that will be used in upcomming drivers.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed ba
From: Laurentiu Tudor
It was used just to sanity check some obscure
cases that are unlikely to ever happen.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git a/drivers/staging/
From: Laurentiu Tudor
First 4 patches fix several driver model related
issues and drop an useless atomic global.
The rest of the patches are cleanups mostly
consisting in removing dead code.
Only patch 3, 4, 5 and 10 changed. See individual patch notes for
details.
Laurentiu Tudor (10):
stagi
From: Laurentiu Tudor
Mixing two memory management systems, in this case
managed device resource api and refcounted objects
is a bad idea. Lifetime of an object is controlled
by its refcount so allocating it with other apis
that have their own lifetime control is not ok.
Drop devm_*() apis in fav
From: Laurentiu Tudor
It was used just to sanity check some obscure
cases that are unlikely to ever happen.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 26 +-
1 file changed, 1 insertion(+), 25 deletions(-)
diff --git
From: Laurentiu Tudor
Let's drop the slab cache for objects
until we actually have proof that it improves
performance. This makes the code cleaner.
Signed-off-by: Laurentiu Tudor
---
v3:
- made distinct patch with slab cache removal
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 17 +++---
From: Laurentiu Tudor
Leave only APIs that will be used in upcomming drivers.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed ba
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/dpbp.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/staging/fsl-mc/bus/dpbp.c
b/drivers/staging/fsl-mc/bus/dpbp.c
index 1fa7257..d9e450a 100644
--- a/drivers/staging/fsl-mc/
From: Laurentiu Tudor
Drop unneeded get_device() call at device creation
and, as per documentation, drop reference count
after using device_find_child() return.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 +
drivers/staging/fsl-mc/bus/fsl-
From: Laurentiu Tudor
The implementation was removed in commit:
decd3d0cf (staging: fsl-mc: uprev binary interface to match MC v10.x)
but the prototype was left behind.
Also fix a message that was wrongly mentioning it.
Signed-off-by: Laurentiu Tudor
---
v3:
- no changes
drivers/staging/f
From: Laurentiu Tudor
When hot unplugging a mc-bus device the kernel displays
this pertinent message, followed by a stack dump:
"Device 'foo.N' does not have a release() function,
it is broken and must be fixed."
Add the required callback to fix and drop the now
uneeded explicit freeing.
From: Laurentiu Tudor
These APIs are not used yet, so drop the dead code.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
Also in this patch, add missing prototype for
From: Laurentiu Tudor
Leave only APIs that area actually used in the bus driver.
The patch is mostly mechanical, with a couple exceptions:
- getters/setters were not removed even if only one of
them is being used
- versioning API was also left in place
They will be added back on an as-needed
From: Laurentiu Tudor
Stick to one way of checking the return code of strcmp(): use '!'.
This was suggested in a review comment.
Signed-off-by: Laurentiu Tudor
---
v2:
- new patch
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff
From: Laurentiu Tudor
Move comparison before the strcmp() in this if statement, and slightly
increase efficiency by not making the strcmp() each time the if gets
evaluated but only when the comparison is true.
This was suggested in a review comment.
Signed-off-by: Laurentiu Tudor
---
v2:
- new
From: Laurentiu Tudor
This patch series contain mainly clean-ups of the mc-bus header files
with the final goal of reorganizing them in just 2 files: a public
and a private one, as per GregKH suggestion [1].
Here's a summary of the header reorganizing:
- existing mc.h used as public header (cont
From: Laurentiu Tudor
These couple of header files are not needed in the source
so remove them.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/fsl-mc-allocator.c
From: Laurentiu Tudor
They are never used outside the source they are implemented in and very
likely never will, so it's safe to make them static.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++-
drivers/staging/fsl-mc/bus/fsl-mc-bus.
From: Laurentiu Tudor
In its current form, the public headers of the mc-bus depend only on a
structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public
header together with its associated defines and, in order to keep the
naming prefixes consistent rename it to "fsl_mc_obj_desc".
This
From: Laurentiu Tudor
The function fsl_mc_bus_exists() has a prototype but is never
implemented so delete it from the header file.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/include/mc-bus.h | 2 --
1 file changed, 2 deletions(-)
diff --git a/drivers/staging/
From: Laurentiu Tudor
fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code
so it needs to be in the public headers.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/include/mc-bus.h | 7 ---
drivers/staging/fsl-mc/include/mc.h | 7 +++
From: Laurentiu Tudor
These functions already have their prototypes in fsl-mc-private.h
header file so delete them from mc-bus.h.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/include/mc-bus.h | 8
1 file changed, 8 deletions(-)
diff --git a/drivers/sta
From: Laurentiu Tudor
dprc.h is only used in the mc bus driver so move it together with the
sources thus making it private.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/bus/dprc.c | 2 +-
drivers/staging/fsl-mc/{include => bus}/dprc.h | 0
drivers/s
From: Laurentiu Tudor
mc-cmd.h contains some low level functions used to encode and decode
commands to the MC. They are used by the drivers so move them to the
public headers and get rid of the mc-cmd.h header.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-dpaa2/eth
From: Laurentiu Tudor
mc-sys.h contains the API to send commands to the MC and is used
by drivers. Move it to the public headers and get rid of the mc-sys.h
header.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-dpaa2/ethernet/dpaa2-eth.c | 1 -
drivers/staging/fsl-
From: Laurentiu Tudor
dpmng.h & dpmng.c files expose an API of just one function which is only
used by the bus driver. Move that single API in the bus source as static
and remove the two files.
Signed-off-by: Laurentiu Tudor
---
v2:
- fix compile error by removing dpmng.c from Makefile
drive
From: Laurentiu Tudor
All the mc-bus.h contents is only used privately in the bus driver so
move everything to the private header and get rid of the mc-bus.h
header file.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/bus/dprc-driver.c | 1 -
drivers/st
From: Laurentiu Tudor
Few files using byte order macros but did not explicitly
included the required kernel header, so add it.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/bus/dpbp.c | 1 +
drivers/staging/fsl-mc/bus/dpcon.c | 1 +
drivers/staging/fsl-m
From: Laurentiu Tudor
Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type)
are used externally so move them to the public header.
Signed-off-by: Laurentiu Tudor
---
v2:
- no changes
drivers/staging/fsl-mc/include/mc-bus.h | 9 -
drivers/staging/fsl-mc/include/mc.h
From: Laurentiu Tudor
Now that there is a functional ethernet driver probed on the
mc bus this patch series requests that the fsl-mc bus driver
be moved out of staging.
The proposed destination for the bus driver is drivers/bus.
Proposed location for global header files for fsl-mc and dpaa2
is t
From: Laurentiu Tudor
Remove several unneeded #includes, forward
declarations and fix several issues reported
by checkpatch.pl --strict, such as:
- kfree(NULL) is safe and check is not required
- macro argument reuse may cause possible side effects
- enclose macro params in parens to avoid pre
From: Laurentiu Tudor
Signed-off-by: Laurentiu Tudor
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index f7d568b..50b3c36 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -10542,6 +10542,7 @@ M: Laurentiu Tudor
L: linux-kernel@vger.kernel.
From: Stuart Yoder
Move the source files out of staging into their final locations:
-include files in drivers/staging/fsl-mc/include go to include/linux/fsl
-irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
-source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
-README.txt, p
From: Laurentiu Tudor
Apart from a small change (first patch) which adds a missing comment,
this series make the bus driver compile on other architectures, as per
GregKH comment [1].
Compiled tested on:
- booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2]
- x86 (i386_defconfig
From: Laurentiu Tudor
No need to use arch-specific memory barriers; switch to using generic
ones. The rmb()s were useless so drop them.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++
1 file changed, 2 insertions(+), 4 deletions(-)
diff --git a/drivers/stagi
From: Laurentiu Tudor
The mc-bus specific field, fsl_mc in struct msi_desc is missing its
comment so add it.
Signed-off-by: Laurentiu Tudor
---
include/linux/msi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/msi.h b/include/linux/msi.h
index df6d592..80e3b56 100644
--- a/
From: Laurentiu Tudor
The bus driver relies on generic msi domain ops.
Fix compilation for architectures that don't provide it (e.g. x86_64).
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 4
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi
From: Laurentiu Tudor
Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64),
thus leaving this driver compile on other architectures.
Also, other drivers depending on the bus are updated to depend
on ARCH_LAYERSCAPE until they'll also be made multi-arch.
This was compiled tested on:
From: Laurentiu Tudor
Split the 64-bit accesses in 32-bit accesses because there's no real
constrain in MC to do only atomic 64-bit. There's only one place
where ordering is important: when writing the MC command header the
first 32-bit part of the header must be written last.
We do this switch i
From: Laurentiu Tudor
Use correct format specifier for phys_addr_t variables (%pa) instead
of %llx. This fixes these warnings on 32 bit targets:
"format '%llx' expects argument of type 'long long unsigned int',
but argument 4 has type 'phys_addr_t' [-Wformat=]"
Signed-off-by: Laurentiu Tudor
From: Laurentiu Tudor
Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be
safely dropped.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 -
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.c | 1 -
2 files changed, 2 deleti
From: Laurentiu Tudor
The bus driver relies on generic msi domain ops.
Fix compilation for architectures that don't provide it (e.g. x86_64).
Signed-off-by: Laurentiu Tudor
---
Notes:
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 4
drivers/staging/fs
From: Laurentiu Tudor
Apart from a small change (first patch) which adds a missing comment,
this series make the bus driver compile on other architectures, as per
GregKH comment [1].
Compiled tested on:
- booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2]
- x86 (i386_defconfig
From: Laurentiu Tudor
As raw device io functions are not portable and don't handle byte-order
(triggering suspicion that endianness isn't handled well) switch to
using the standard api.
Since MC expects LE byte-order and the upper layers already take care
of that, we need to trick the device io a
From: Laurentiu Tudor
Drop dependency on ARCH_LAYERSCAPE (which in turn depends on ARM64),
thus leaving this driver compile on other architectures.
Also, other drivers depending on the bus are updated to depend
on ARCH_LAYERSCAPE until they'll also be made multi-arch.
This was compiled tested on:
From: Laurentiu Tudor
Since there's no real constrain in MC to do only atomic 64-bit we can
enable this driver on 32-bit platforms too.
Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used
in the driver available on 32-bit platforms.
Signed-off-by: Laurentiu Tudor
---
Notes:
From: Laurentiu Tudor
Use correct format specifier for phys_addr_t variables (%pa) instead
of %llx. This fixes these warnings on 32 bit targets:
"format '%llx' expects argument of type 'long long unsigned int',
but argument 4 has type 'phys_addr_t' [-Wformat=]"
Signed-off-by: Laurentiu Tudor
From: Laurentiu Tudor
The mc-bus specific field, fsl_mc in struct msi_desc is missing its
comment so add it.
Signed-off-by: Laurentiu Tudor
---
Notes:
-v2
-no changes
include/linux/msi.h | 1 +
1 file changed, 1 insertion(+)
diff --git a/include/linux/msi.h b/include/linux/msi.h
in
From: Laurentiu Tudor
Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be
safely dropped.
Signed-off-by: Laurentiu Tudor
---
Notes:
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 -
drivers/staging/fsl-mc/bus/irq-gic-v3-its-fsl-mc-msi.
From: Laurentiu Tudor
No need to use arch-specific memory barriers; switch to using generic
ones. The rmb()s were useless so drop them.
Signed-off-by: Laurentiu Tudor
---
Notes:
-v2
-no changes
drivers/staging/fsl-mc/bus/mc-sys.c | 6 ++
1 file changed, 2 insertions(+), 4 deleti
From: Laurentiu Tudor
The mc-bus specific field, fsl_mc in struct msi_desc is missing its
comment so add it.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
include/linux/msi.h | 1 +
1 file changed, 1 insertion(+)
diff -
From: Laurentiu Tudor
Apart from a small change (first patch) which adds a missing comment,
this series make the bus driver compile on other architectures, as per
GregKH comment [1].
Compiled tested on:
- booke powerpc (corenet{32,64}_smp_defconfig) with this ppc patch [2]
- x86 (i386_defconfig
From: Laurentiu Tudor
Use correct format specifier for phys_addr_t variables (%pa) instead
of %llx. This fixes these warnings on 32 bit targets:
"format '%llx' expects argument of type 'long long unsigned int',
but argument 4 has type 'phys_addr_t' [-Wformat=]"
Signed-off-by: Laurentiu Tudor
From: Laurentiu Tudor
Since there's no real constrain in MC to do only atomic 64-bit we can
enable this driver on 32-bit platforms too.
Include linux/io-64-nonatomic-hi-lo.h to make quad device io apis used
in the driver available on 32-bit platforms.
Signed-off-by: Laurentiu Tudor
Acked-by: Ar
From: Laurentiu Tudor
Add an alternate dependency on COMPILE_TEST, thus leaving
this driver compile on other architectures.
Also, other drivers depending on the bus are updated to depend
on ARCH_LAYERSCAPE until they'll also be made multi-arch.
This was compiled tested on:
- booke powerpc (coren
From: Laurentiu Tudor
As raw device io functions are not portable and don't handle byte-order
(triggering suspicion that endianness isn't handled well) switch to
using the standard api.
Since MC expects LE byte-order and the upper layers already take care
of that, we need to trick the device io a
From: Laurentiu Tudor
The bus driver relies on generic msi domain ops.
Fix compilation for architectures that don't provide it (e.g. x86_64).
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-m
From: Laurentiu Tudor
Nothing from linux/irqchip/arm-gic-v3.h is used, so the #include can be
safely dropped.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/fsl-mc-msi.c| 1 -
dr
From: Laurentiu Tudor
No need to use arch-specific memory barriers; switch to using generic
ones. The rmb()s were useless so drop them.
Signed-off-by: Laurentiu Tudor
Acked-by: Arnd Bergmann
---
Notes:
-v3
-no changes
-v2
-no changes
drivers/staging/fsl-mc/bus/mc-sys.c |
From: Laurentiu Tudor
Couple of API functions are not used so lets drop them together with
the associated structures and defines.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpcon-cmd.h | 6 ---
drivers/staging/fsl-mc/bus/dpcon.c | 69 --
From: Laurentiu Tudor
There's an unfinished implementation of reference counting for dpaa2_io
structure using atomics. Since it's unused lets remove it for now and,
if needed at a later time, make use of krefs instead of rolling our
own refcounting.
Signed-off-by: Laurentiu Tudor
---
drivers/s
From: Laurentiu Tudor
These functions are only used within this driver so no need for
EXPORT_SYMBOL().
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 3 ---
1 file changed, 3 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-service.c
b/drive
From: Laurentiu Tudor
These WARN_ONs shouldn't trigger unless something went very wrong.
Since the driver is in a stable state let's remove these debug
WARN_ONs.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 8
drivers/staging/fsl-mc/bus/f
From: Laurentiu Tudor
The bus driver is mixing EXPORT_SYMBOL()/EXPORT_SYMBOL_GPL() usage.
Change it to consistently use EXPORT_SYMBOL_GPL().
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpbp.c | 16
drivers/staging/fsl-mc/bus/dpcon.c | 14 +++---
dr
From: Laurentiu Tudor
The MC bus has different types of devices and this is supported by
device model. This patch adds initial support for device types
(defines them, adds helpers and sets the device type).
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 67 +++
From: Laurentiu Tudor
These couple of functions are not yet used so lets remove them
for now and add them back when/if needed.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 58 --
drivers/staging/fsl-mc/include/dpaa2-io.h | 4
From: Laurentiu Tudor
No need to use EXPORT_SYMBOL() so switch to the GPL variant.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpio/dpio-service.c | 20 ++--
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/staging/fsl-mc/bus/dpio/dpio-s
From: Laurentiu Tudor
A lot of error checks are doubled by debug WARN_ONs. Given that the
driver was thoroughly debugged and is in a stable state, it's time to
drop them.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 20 ++---
drivers/staging/fsl-mc/bu
From: Laurentiu Tudor
Replace strcmp() based device type checks with the standard device
model type.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 4 ++--
drivers/staging/fsl-mc/bus/fsl-mc-allocator.c | 20 ++--
drivers/staging/fsl-mc/bus/f
From: Laurentiu Tudor
Throughout the driver we use == 0 / != 0 to check strcmp() returns except
this place, so fix it.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/fsl-mc/bus/dprc
From: Stuart Yoder
Move the source files out of staging into their final locations:
-include files in drivers/staging/fsl-mc/include go to include/linux/fsl
-irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
-source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
-README.txt, p
From: Stuart Yoder
Move the source files out of staging into their final locations:
-include files in drivers/staging/fsl-mc/include go to include/linux/fsl
-irq-gic-v3-its-fsl-mc-msi.c goes to drivers/irqchip
-source in drivers/staging/fsl-mc/bus goes to drivers/bus/fsl-mc
-README.txt, p
From: Laurentiu Tudor
This patch series contain mainly clean-ups of the mc-bus header files
with the final goal of reorganizing them in just 2 files: a public
and a private one, as per GregKH suggestion [1].
Here's a summary of the header reorganizing:
- existing mc.h used as public header (cont
From: Laurentiu Tudor
Several macros were triggering this checkpatch.pl warning:
"Macro argument reuse '$arg' - possible side-effects?"
Fix the warning by turning them into real functions.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 15 +--
From: Laurentiu Tudor
In its current form, the public headers of the mc-bus depend only on a
structure "dprc_obj_desc" defined in dprc.h. Move it to the bus public
header together with its associated defines and, in order to keep the
naming prefixes consistent rename it to "fsl_mc_obj_desc".
This
From: Laurentiu Tudor
They are never used outside the source they are implemented in and very
likely never will, so it's safe to make them static.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dprc-driver.c | 8 +++-
drivers/staging/fsl-mc/bus/fsl-mc-bus.c | 5 ++---
drive
From: Laurentiu Tudor
fsl_mc_msi_create_irq_domain() will is used from the irqchip glue code
so it needs to be in the public headers.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 7 ---
drivers/staging/fsl-mc/include/mc.h | 7 +++
2 files changed, 7
From: Laurentiu Tudor
dpmng.h & dpmng.c files expose an API of just one function which is only
used by the bus driver. Move that single API in the bus source as static
and remove the two files.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/bus/dpmng.c | 74
From: Laurentiu Tudor
Define dev_is_fsl_mc() and the bus type definition (fsl_mc_bus_type)
are used externally so move them to the public header.
Signed-off-by: Laurentiu Tudor
---
drivers/staging/fsl-mc/include/mc-bus.h | 9 -
drivers/staging/fsl-mc/include/mc.h | 9 +
2 f
1 - 100 of 140 matches
Mail list logo
