Re: [PATCH 1/7] ARM: tegra: finalize USB EHCI and PHY bindings

2013-03-20 Thread kishon
- - phy_type : Should be one of "ulpi" or "utmi". + - reg : Defines the following set of registers, in the order listed: + - The PHY's own register set. + Always present. + - The register set of the PHY containing the UTMI pad control registers. + Present if-and-only

Re: [PATCH 2/7] ARM: tegra: update device trees for USB binding rework

2013-03-20 Thread kishon
s which doesn't have *reg* property. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/5] usb: musb/otg: cleanup and fixes

2013-03-20 Thread kishon
Felipe, On Wednesday 20 March 2013 06:42 PM, Felipe Balbi wrote: On Wed, Mar 13, 2013 at 02:17:05PM +0530, Kishon Vijay Abraham I wrote: This series has some misc cleanup and fixes. The fix solves the cold plug issue in omap3 which some have reported. Developed these patches on Linux 3.9-rc2

Re: [PATCH v3 1/6] drivers: phy: add generic PHY framework

2013-03-20 Thread kishon
Hi, On Thursday 21 March 2013 04:06 AM, Sylwester Nawrocki wrote: Hi Kishon, On 03/20/2013 10:12 AM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without

Re: [PATCH v3 4/6] ARM: OMAP: USB: Add phy binding information

2013-03-20 Thread kishon
Hi, On Wednesday 20 March 2013 10:21 PM, Tony Lindgren wrote: * Kishon Vijay Abraham I [130320 02:17]: --- a/arch/arm/mach-omap2/board-2430sdp.c +++ b/arch/arm/mach-omap2/board-2430sdp.c @@ -265,6 +266,7 @@ static void __init omap_2430sdp_init(void) omap_mux_init_signal("usb0h

Re: [PATCH v3 5/6] ARM: dts: omap: update usb_otg_hs data

2013-03-20 Thread kishon
Hi, On Thursday 21 March 2013 02:29 AM, Stephen Warren wrote: On 03/20/2013 03:12 AM, Kishon Vijay Abraham I wrote: Updated the usb_otg_hs dt data to include the *phy* and *phy-names* binding in order for the driver to use the new generic PHY framework. Also updated the Documentation to

Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data

2013-02-05 Thread kishon
On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote: Hello. On 25-01-2013 15:11, Kishon Vijay Abraham I wrote: Add dwc3 omap glue data to the omap5 dt data file. The information about the dt node added here is available @ Documentation/devicetree/bindings/usb/omap-usb.txt Signed-off

Re: [PATCH v2 4/6] ARM: dts: omap5: add dwc3 omap dt data

2013-02-05 Thread kishon
Hi, On Tuesday 05 February 2013 02:08 PM, Felipe Balbi wrote: On Tue, Feb 05, 2013 at 01:59:26PM +0530, kishon wrote: On Sunday 27 January 2013 01:17 AM, Sergei Shtylyov wrote: Hello. On 25-01-2013 15:11, Kishon Vijay Abraham I wrote: Add dwc3 omap glue data to the omap5 dt data file. The

[GIT PULL] ARM part of USB patches

2013-02-05 Thread kishon
n usb-next. Thanks Kishon The following changes since commit 88b62b915b0b7e25870eb0604ed9a92ba4bfc9f7: Linux 3.8-rc6 (2013-02-01 12:08:14 +1100) are available in the git repository at: git://gitorious.org/linux-usb/linux-usb.git arm-usb-dt for you to fetch changes

Re: [GIT PULL] ARM part of USB patches

2013-02-05 Thread kishon
Hi Tony, Greg, On Tuesday 05 February 2013 08:54 PM, kishon wrote: Hi Tony, As discussed, I'm sending a pull request for the arch/arm part of my USB patches. These patches are necessary to get MUSB functional in both dt and non-dt boot. Also added dt data for dwc3 present in OMAP. This

Re: [PATCH 3/8] ARM: dts: omap: Add usb_otg and glue data

2013-02-06 Thread kishon
t = <1>; +num_eps = <16>; +ram_bits = <12>; Where are these bindings documented? The general convention is to use a '-' for property names and not '_' It's documented in Documentation/devicetree/bindings/usb/omap-usb.txt Actually

Re: [PATCH v3] usb: phy: moving all PHY API definitions to usb/phy directory

2013-02-07 Thread kishon
nd when the controller + * requests this phy. + * + * To be used by platform specific initialization code. + */ +int __init usb_bind_phy(const char *dev_name, u8 index, + const char *phy_dev_name) +{ + struct usb_phy_bind *phy_bind; + unsigned long flags; + +

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread kishon
dt. I think, instead you can have a patch to use devm_usb_get_phy_dev() here and in exynos platform specific code use usb_bind_phy() to bind the phy and controller till you change it to dt. In such cases, dwc3 should expect PHYs from its parent's node. NAK. Thanks Kishon -- To unsubscribe

Re: [PATCH RFC] usb: dwc3: Get PHY from platform specific dwc3 dt node.

2013-01-31 Thread kishon
;m not sure if there is any other better way to achieve the same (without patching of.c ;-)) Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/major

Re: [PATCH v2 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-02-02 Thread kishon
Hi, On Saturday 02 February 2013 02:43 AM, Marc Kleine-Budde wrote: On 01/25/2013 03:33 AM, Kishon Vijay Abraham I wrote: In order to support platforms which has multiple PHY's (of same type) and which has multiple USB controllers, a new design is adopted wherin the binding inform

Re: [PATCH v1 4/6] drivers: usb: musb: omap: make use of the new PHY lib APIs

2013-01-24 Thread kishon
Hi, On Tuesday 22 January 2013 07:39 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: New PHY lib APIs like usb_add_phy_dev() and devm_usb_get_phy_dev() are used in MUSB (OMAP), in order to make use of the binding information provided in the board file (of OMAP

Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread kishon
On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote: On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote: On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to

Re: [PATCH v1 1/8] usb: otg: palmas-usb: make palmas-usb as a comparator driver

2013-01-25 Thread kishon
On Friday 25 January 2013 01:13 PM, Felipe Balbi wrote: Hi, On Fri, Jan 25, 2013 at 08:42:24AM +0530, Kishon Vijay Abraham I wrote: palmas-usb is made as a comparator driver to omap usb2 phy, so that omap usb can make use of palmas for srp and also to set vbus. Signed-off-by: Kishon Vijay

Re: [PATCH v3 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-25 Thread kishon
On Friday 25 January 2013 02:15 PM, Felipe Balbi wrote: hi, On Fri, Jan 25, 2013 at 02:12:41PM +0530, kishon wrote: On Friday 25 January 2013 01:18 PM, Felipe Balbi wrote: On Thu, Jan 24, 2013 at 09:32:46PM -0800, Stephen Warren wrote: On 01/24/2013 06:19 PM, Kishon Vijay Abraham I wrote

Re: [PATCH v4 4/4] drivers: usb: start using the control module driver

2013-01-25 Thread kishon
On Friday 25 January 2013 03:57 PM, Felipe Balbi wrote: Hi, On Fri, Jan 25, 2013 at 03:54:00PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-24 Thread kishon
Hi, On Sunday 24 February 2013 04:14 AM, Rob Landley wrote: On 02/18/2013 11:53:14 PM, Kishon Vijay Abraham I wrote: The PHY framework provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or without using phandle

Re: [PATCH v2 0/5] Generic PHY Framework

2013-02-19 Thread kishon
Hi, On Tuesday 19 February 2013 04:14 PM, Arnd Bergmann wrote: On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: Added a generic PHY framework that provides a set of APIs for the PHY drivers to create/destroy a PHY and APIs for the PHY users to obtain a reference to the PHY with or

Re: [PATCH v2 1/5] drivers: phy: add generic PHY framework

2013-02-19 Thread kishon
Hi, On Tuesday 19 February 2013 06:26 PM, Arnd Bergmann wrote: On Tuesday 19 February 2013, Kishon Vijay Abraham I wrote: +static struct class *phy_class; +static LIST_HEAD(phy_list); +static DEFINE_MUTEX(phy_list_mutex); +static LIST_HEAD(phy_bind_list); Hmm, so you actually do have a

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-13 Thread kishon
Benoit, Will you be queuing this patch series? Thanks Kishon On Thursday 07 March 2013 07:05 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies

Re: [PATCH 2/5] usb: musb: omap: always glue have the correct vbus/id status

2013-03-13 Thread kishon
On Thursday 14 March 2013 03:29 AM, Grazvydas Ignotas wrote: On Wed, Mar 13, 2013 at 10:47 AM, Kishon Vijay Abraham I wrote: In the case where omap glue is loaded and musb core is not, glue->status wont have a valid status if the phy drivers call omap_musb_mailbox. So fixed the conditions h

Re: [PATCH v2 0/4] usb: musb/otg: cleanup and fixes

2013-03-14 Thread kishon
On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote: On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote: This series has some misc cleanup and fixes. The fix solves the cold plug issue in omap3 which some have reported. Developed these patches on fixes-for-v3.9-rc3 after

Re: [PATCH v2 0/4] usb: musb/otg: cleanup and fixes

2013-03-14 Thread kishon
On Thursday 14 March 2013 08:17 PM, Felipe Balbi wrote: On Thu, Mar 14, 2013 at 08:15:00PM +0530, kishon wrote: On Thursday 14 March 2013 07:03 PM, Felipe Balbi wrote: On Thu, Mar 14, 2013 at 11:53:55AM +0530, Kishon Vijay Abraham I wrote: This series has some misc cleanup and fixes. The fix

Re: [PATCH v2 3/4] USB: Palmas OTG Transceiver Driver

2013-03-14 Thread kishon
On Thursday 14 March 2013 07:26 PM, Felipe Balbi wrote: On Thu, Mar 07, 2013 at 06:51:45PM +0530, Kishon Vijay Abraham I wrote: From: Graeme Gregory This is the driver for the OTG transceiver built into the Palmas chip. It handles the various USB OTG events that can be generated by cable

Re: [PATCH v3 0/7] ARM: dts: omap: Add dts data for USB

2013-03-15 Thread kishon
On Friday 15 March 2013 06:11 PM, Benoit Cousson wrote: + Jon Hi Kishon, On 03/07/2013 02:35 PM, Kishon Vijay Abraham I wrote: Hi Benoit, Here are the dt data patches to get usb device functional in OMAP platforms. All the patches deal with modifying arch/arm/boot except one which modifies

Re: [PATCH 1/4] usb: Fix linker errors during build

2013-03-15 Thread kishon
On Friday 15 March 2013 07:55 PM, Felipe Balbi wrote: On Fri, Mar 15, 2013 at 06:58:49PM +0530, Kishon Vijay Abraham I wrote: commit 63378a (usb: phy: remove CONFIG_USB_OTG_UTILS) removed CONFIG_USB_OTG_UTILS from Kconfig but failed to removed from Makefile. Fixed it here. Signed-off-by

Re: [PATCH v4 6/7] usb: dwc3-omap: Minor fixes to get dt working

2012-10-25 Thread kishon
Hi Benoit, On Thursday 25 October 2012 07:11 PM, Benoit Cousson wrote: Hi Kishon, On 10/15/2012 03:27 PM, Kishon Vijay Abraham I wrote: Includes few minor fixes in dwc3-omap like populating the compatible string in a correct way, extracting the utmi-mode property properly and changing the

Re: [PATCH v2 1/3] drivers: bus: ocp2scp: add pdata support

2012-10-27 Thread kishon
:07PM -0700, Tony Lindgren wrote: * Tony Lindgren [121016 09:53]: * Kishon Vijay Abraham I [121007 23:01]: ocp2scp was not having pdata support which makes *musb* fail for non-dt boot in OMAP platform. The pdata will have information about the devices that is connected to ocp2scp. ocp2scp

Re: [PATCH v2 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp

2012-10-27 Thread kishon
od data is only there for omap4. shouldn't that be fixed too ? I mean, if data isn't just return -ENODEV or something similar. Yes some kind of checking is needed here. Ok. I'll fix and send. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe lin

Re: [PATCH v2 1/3] drivers: bus: ocp2scp: add pdata support

2012-10-28 Thread kishon
Hi, On Monday 29 October 2012 11:40 AM, Felipe Balbi wrote: Hi, On Sat, Oct 27, 2012 at 05:57:48PM +0530, kishon wrote: Hi, On Saturday 27 October 2012 01:29 AM, Felipe Balbi wrote: Hi, On Fri, Oct 26, 2012 at 10:16:55AM -0700, Tony Lindgren wrote: * Felipe Balbi [121025 23:55]: On Thu

Re: [PATCH 3/3] ARM: OMAP: ocp2scp: create omap device for ocp2scp

2012-10-07 Thread kishon
Hi, On Saturday 06 October 2012 04:00 AM, Sergei Shtylyov wrote: Hello. On 05-10-2012 12:07, Kishon Vijay Abraham I wrote: Platfrom device for ocp2scp is created using omap_device_build in devices file. This is used for both omap4(musb) and omap5(dwc3). Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH 2/4] usb: dwc3: dwc3-omap: return -EPROBE_DEFER if probe has not yet executed

2013-03-05 Thread kishon
Hi, On Tuesday 05 March 2013 08:26 PM, Felipe Balbi wrote: On Tue, Mar 05, 2013 at 07:51:58PM +0530, Kishon Vijay Abraham I wrote: return -EPROBE_DEFER from dwc3_omap_mailbox in dwc3-omap.c, if the probe of dwc3-omap has not yet been executed or failed. Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH v2 7/8] ARM: dts: omap5: add dwc3 omap dt data

2013-03-05 Thread kishon
Hi, On Tuesday 05 March 2013 08:11 PM, Sergei Shtylyov wrote: Hello. On 05-03-2013 18:37, Kishon Vijay Abraham I wrote: Add dwc3 omap glue data to the omap5 dt data file. The information about the dt node added here is available @ Documentation/devicetree/bindings/usb/omap-usb.txt Signed

Re: [PATCH 1/4] usb: dwc3: dwc3-omap: set dma_mask for dwc3 inorder for host mode to work

2013-03-05 Thread kishon
Hi, On Tuesday 05 March 2013 08:24 PM, Felipe Balbi wrote: On Tue, Mar 05, 2013 at 07:51:57PM +0530, Kishon Vijay Abraham I wrote: While creating the child devices, *of_platform_populate* sets only coherent_dma_mask but USBHCD sets *uses_dma* (determines whether the controller is DMA'

Re: [PATCH 2/4] usb: dwc3: dwc3-omap: return -EPROBE_DEFER if probe has not yet executed

2013-03-05 Thread kishon
Hi, On Tuesday 05 March 2013 08:36 PM, Felipe Balbi wrote: On Tue, Mar 05, 2013 at 08:31:58PM +0530, kishon wrote: Hi, On Tuesday 05 March 2013 08:26 PM, Felipe Balbi wrote: On Tue, Mar 05, 2013 at 07:51:58PM +0530, Kishon Vijay Abraham I wrote: return -EPROBE_DEFER from dwc3_omap_mailbox

Re: [PATCH v2 8/8] ARM: dts: omap5: add dwc3 core dt data

2013-03-06 Thread kishon
Hi, On Tuesday 05 March 2013 08:09 PM, Felipe Balbi wrote: Hi, On Tue, Mar 05, 2013 at 08:07:03PM +0530, Kishon Vijay Abraham I wrote: Add dwc3 core dt data as a subnode to dwc3 omap glue data in omap5 dt data file. The information for the entered data node is available @ Documentation

Re: [PATCH v2 8/8] ARM: dts: omap5: add dwc3 core dt data

2013-03-06 Thread kishon
On Wednesday 06 March 2013 02:49 PM, Felipe Balbi wrote: Hi, On Wed, Mar 06, 2013 at 02:25:48PM +0530, kishon wrote: Hi, On Tuesday 05 March 2013 08:09 PM, Felipe Balbi wrote: Hi, On Tue, Mar 05, 2013 at 08:07:03PM +0530, Kishon Vijay Abraham I wrote: Add dwc3 core dt data as a subnode to

Re: [PATCH 12/12] USB: ehci-omap: Fix detection in HSIC mode

2013-03-12 Thread kishon
't HSIC supposed to be PHYless devices. Maybe a comment explaining it might be helpful. Thanks Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH 5/6] usb: otg: add device tree support to otg library

2013-01-21 Thread kishon
On Monday 21 January 2013 06:51 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: Added an API devm_usb_get_phy_by_phandle(), to get usb phy by passing a device node phandle value. This function will return a pointer to the phy on success, -EPROBE_DEFER if there is

Re: [RFC PATCH 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-21 Thread kishon
Hi, On Monday 21 January 2013 06:48 PM, Roger Quadros wrote: On 01/16/2013 05:01 PM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |7 ++- 1 file changed, 6

Re: [PATCH] usb: musb: core: Add missing newline character

2013-01-21 Thread kishon
Hi, On Monday 21 January 2013 10:52 PM, Sergei Shtylyov wrote: Hello. On 01/21/2013 05:52 PM, Kishon Vijay Abraham I wrote: No functional change. Just added a missing newline character. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/musb_core.c |2 +- 1 file changed, 1

Re: [PATCH v1 2/6] usb: otg: utils: add facilities in phy lib to support multiple PHYs of same type

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 07:37 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: In order to add support for multipe PHY's of the same type, new API's for adding PHY and getting PHY has been added. Now the binding information for the PHY and control

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by: Kishon Vijay Abraham I --- drivers/usb/musb/omap2430.c |7 ++- 1 file changed, 6

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
On Tuesday 22 January 2013 08:17 PM, Roger Quadros wrote: On 01/22/2013 04:37 PM, kishon wrote: On Tuesday 22 January 2013 07:47 PM, Roger Quadros wrote: On 01/22/2013 11:58 AM, Kishon Vijay Abraham I wrote: The OMAP glue has been modified to get PHY by phandle for dt boot. Signed-off-by

Re: [PATCH v1 5/6] usb: otg: add device tree support to otg library

2013-01-22 Thread kishon
spin_unlock_irqrestore(&phy_lock, flags); + + return phy; +} This means that on all of the exit paths, node's refcount is left incremented incorrectly. You'll need an of_node_put(node) on each exit path. Ok. Will fix it. Thanks Kishon -- To unsubscribe from this l

Re: [PATCH v1 6/6] USB: MUSB: OMAP: get PHY by phandle for dt boot

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 09:08 PM, Peter Ujfalusi wrote: On 01/22/2013 04:21 PM, kishon wrote: But it's better to check if deferred probing takes place whenever a new driver is bound to a device as you just mentioned. Whenever you load (might be also when you unload) a drive

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread kishon
On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding information has to be present in the PHY library (otg.c) in order f

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread kishon
Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het volgende geschreven: This patch series adds support for adding multiple PHY's (of same type). The binding informatio

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-22 Thread kishon
On Tuesday 22 January 2013 10:32 PM, Koen Kooi wrote: Op 22 jan. 2013, om 17:16 heeft kishon het volgende geschreven: Hi, On Tuesday 22 January 2013 09:15 PM, kishon wrote: On Tuesday 22 January 2013 09:11 PM, Koen Kooi wrote: Op 22 jan. 2013, om 10:58 heeft Kishon Vijay Abraham I het

Re: [PATCH v1 0/6] USB: Add support for multiple PHYs of same type

2013-01-23 Thread kishon
easy enough to patch in locally. USB first instance of am335x works in mainline as of now. Can you check if this series indeed breaks am335x? Thanks for your help. Regards Kishon -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-10-12 Thread kishon
Hi Tony, On Thursday 11 October 2012 06:29 AM, Tony Lindgren wrote: Hi, * Kishon Vijay Abraham I [120919 04:32]: Added a driver for usb3 phy that handles the interaction between usb phy device and dwc3 controller. This also includes device tree support for usb3 phy driver and the

Re: [RFC PATCH 1/7] drivers: usb: phy: add a new driver for usb part of control module

2013-01-15 Thread kishon
Hi Arnd, On Tuesday 15 January 2013 07:06 PM, Arnd Bergmann wrote: On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: +OMAP CONTROL USB + +Required properties: + - compatible: Should be "ti,omap-control-usb" + - reg : Address and length of the register set for the device. I

Re: [RFC PATCH 2/7] ARM: OMAP: devices: create device for usb part of control module

2013-01-15 Thread kishon
On Tuesday 15 January 2013 06:23 PM, Sergei Shtylyov wrote: Hello. On 15-01-2013 12:42, Kishon Vijay Abraham I wrote: A seperate driver has been added to handle the usb part of control module. A device for the above driver is created here, using the register address information to be used by

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread kishon
Hi Arnd, On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB has to act

Re: [RFC PATCH 0/7] usb: musb: add driver for control module

2013-01-15 Thread kishon
Hi Ravi, On Tuesday 15 January 2013 09:36 PM, B, Ravi wrote: Hi, On Tue, Jan 15, 2013 at 08:09:22PM +0530, kishon wrote: Hi Arnd, On Tuesday 15 January 2013 07:11 PM, Arnd Bergmann wrote: On Tuesday 15 January 2013, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 03:09 PM, Roger Quadros wrote: On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: This is in preparation for the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding information between the PHY

Re: [RFC PATCH 1/6] usb: otg: Add an API to bind the USB controller and PHY

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 03:07 PM, Roger Quadros wrote: On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: New platforms are added which has multiple PHY's (of same type) and which has multiple USB controllers. The binding information has to be present in the PHY library (otg.

Re: [RFC PATCH 2/6] ARM: OMAP: USB: Add phy binding information

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 05:41 PM, Vivek Gautam wrote: Hi Kishon, On Wed, Jan 16, 2013 at 8:30 PM, Kishon Vijay Abraham I wrote: This is in preparation for the changes in PHY library to support adding and getting multiple PHYs of the same type. In the new design, the binding

Re: [RFC PATCH 3/6] usb: otg: utils: change the phy lib to support multiple PHYs of same type

2013-01-17 Thread kishon
Hi, On Thursday 17 January 2013 09:37 PM, Roger Quadros wrote: On 01/16/2013 05:00 PM, Kishon Vijay Abraham I wrote: In order to add support for multipe PHY's of the same type, the API's for adding PHY and getting PHY has been changed. Now the binding information of the PHY and

Re: [RFC PATCH 0/6] USB: Add multiple PHYs of same type

2013-01-18 Thread kishon
On Friday 18 January 2013 05:18 PM, Felipe Balbi wrote: On Wed, Jan 16, 2013 at 08:30:56PM +0530, Kishon Vijay Abraham I wrote: New platforms are being added which has multiple PHY's (of same type) and which has multiple USB controllers. The binding information has to be present in th

Re: [PATCH 1/4] drivers: usb: phy: add a new driver for usb part of control module

2013-01-18 Thread kishon
Hi, On Friday 18 January 2013 05:29 PM, Felipe Balbi wrote: Hi, On Fri, Jan 18, 2013 at 03:10:42PM +0530, Kishon Vijay Abraham I wrote: Added a new driver for the usb part of control module. This has an API to power on the USB2 phy and an API to write to the mailbox depending on whether MUSB

Re: [PATCH 4/4] drivers: usb: start using the control module driver

2013-01-18 Thread kishon
On Friday 18 January 2013 05:32 PM, Felipe Balbi wrote: Hi, On Fri, Jan 18, 2013 at 03:10:45PM +0530, Kishon Vijay Abraham I wrote: Start using the control module driver for powering on the PHY and for writing to the mailbox instead of writing to the control module registers on their own

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-09 Thread kishon
On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote: Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: On 09/19/2012 11:32 AM, Kishon Vijay Abraham I wrote: This patch series adds dt data to get MUSB working in omap4 and omap3 Changes from v2: * Changes the subject of

Re: [PATCH 2/2] ARM: dts: omap: Add omap-usb2 dt data

2013-01-10 Thread kishon
Hi Benoit, On Wednesday 19 September 2012 04:02 PM, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt data is added as a child node of ocp2scp. Acked-by: Felipe Balbi Signed-off-by: Kishon Vijay Abraham I

Re: [PATCH 2/2] ARM: dts: omap: Add omap-usb2 dt data

2013-01-10 Thread kishon
Hi, On Thursday 10 January 2013 03:34 PM, Benoit Cousson wrote: On 01/10/2013 10:31 AM, kishon wrote: Hi Benoit, On Wednesday 19 September 2012 04:02 PM, Kishon Vijay Abraham I wrote: Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is connected to ocp2scp, omap-usb2 dt

Re: [PATCH v3 0/3] ARM: dts: omap: add dt data for MUSB

2013-01-10 Thread kishon
Hi, On Thursday 10 January 2013 03:28 PM, Benoit Cousson wrote: Hi Kishon, On 01/10/2013 07:19 AM, kishon wrote: On Friday 28 December 2012 12:05 AM, Aaro Koskinen wrote: Hi, On Thu, Sep 20, 2012 at 05:21:15AM +0200, Benoit Cousson wrote: On 09/19/2012 11:32 AM, Kishon Vijay Abraham I

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi Benoit, On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson wrote: > On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: >> No major change from the previous version. Just removed the >> omap-usb2 dt data and sent that as a separate patch. > > Well, I think you'd be

Re: [PATCH] arm/dts: omap: Add omap-usb2 dt data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 1:53 PM, Benoit Cousson wrote: > Hi Kishon, > > On 09/11/2012 08:12 AM, Kishon Vijay Abraham I wrote: >> Add omap-usb2 data node in omap4 device tree file. Since omap-usb2 is >> connected to ocp2scp, omap-usb2 dt data is added as a child node >

Re: [PATCH 1/3] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 10, 2012 at 10:13 PM, Felipe Balbi wrote: > Hi, > > On Mon, Sep 10, 2012 at 06:17:03PM +0200, Benoit Cousson wrote: >> >>>>> On 9/6/2012 8:25 PM, Kishon Vijay Abraham I wrote: >> >>>>>> The mailbox register for usb otg in oma

Re: [PATCH v2 0/3] arm/dts: omap: add dt data for MUSB

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 2:41 PM, Benoit Cousson wrote: > On 09/11/2012 10:44 AM, ABRAHAM, KISHON VIJAY wrote: >> Hi Benoit, >> >> On Tue, Sep 11, 2012 at 1:55 PM, Benoit Cousson wrote: >>> On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: >>>>

Re: [PATCH v2 1/3] arm/dts: Add twl6030-usb data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 2:56 PM, Benoit Cousson wrote: > On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: >> Add twl6030-usb data node in twl6030 device tree file >> >> Acked-by: Felipe Balbi >> Signed-off-by: Kishon Vijay Abraham I >> --- >> a

Re: [PATCH v2 2/3] arm/dts: Add twl4030-usb data

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 3:39 PM, Benoit Cousson wrote: > On 09/11/2012 08:36 AM, Kishon Vijay Abraham I wrote: >> Add twl4030-usb data node in twl4030 device tree file. > > IIRC, the usb part on twl4030 was doing more than it does on twl6030. Indeed. twl4030 is the usb phy

Re: [PATCH v2 3/3] usb: musb: omap: Add device tree support for omap musb glue

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Sep 11, 2012 at 3:23 PM, Vaibhav Hiremath wrote: > > > On 9/11/2012 2:39 PM, Kishon Vijay Abraham I wrote: >> Added device tree support for omap musb driver and updated the >> Documentation with device tree binding information. >> >> Sign

Re: [PATCH v2] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-11 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 12, 2012 at 3:58 AM, Paul Walmsley wrote: > Hi Kishon, BenoƮt, > > On Fri, 7 Sep 2012, Kishon Vijay Abraham I wrote: > >> Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. Since this >> ocp2scp module does not have any fck but does have a si

Re: [PATCH v2] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-13 Thread ABRAHAM, KISHON VIJAY
< 0) > +#define USB1_VBUS_SENSE_CTL_MASK (3 << 1) > +#define USB1_VBUS_SENSE_CTL_VBUS_WAKEUP (0 << 1) > +#define USB1_VBUS_SENSE_CTL_AB_SESS_VLD_OR_VBUS_WAKEUP \ > + (1 << 1) > +#define USB1_VB

Re: [RFC PATCH] drivers: phy: add generic PHY framework

2012-09-14 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Sep 14, 2012 at 5:58 PM, Marc Kleine-Budde wrote: > On 09/14/2012 01:58 PM, Kishon Vijay Abraham I wrote: >> The PHY framework provides a set of API's for the PHY drivers to >> create/remove a PHY and the PHY users to obtain a reference to the PHY >> usin

Re: [PATCHv3 1/4] mfd: smsc: Add support for smsc gpio io/keypad driver

2012-10-02 Thread ABRAHAM, KISHON VIJAY
Hi, On Tue, Oct 2, 2012 at 6:08 PM, Mark Brown wrote: > On Mon, Oct 01, 2012 at 08:54:23PM +0530, ABRAHAM, KISHON VIJAY wrote: >> On Mon, Oct 1, 2012 at 5:39 PM, Mark Brown > >> > Why would that be helpful? Most platforms don't support DT at all, and > >> I

Re: [RFC PATCH] drivers: regulator: add error checks for exported APIs

2012-07-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Thu, Jul 26, 2012 at 4:40 PM, Mark Brown wrote: > On Thu, Jul 26, 2012 at 04:00:03PM +0530, Kishon Vijay Abraham I wrote: > >> Added error checks for exported APIs in regulator framework so that >> incorrect use of these APIs does not result in a crash. > > Th

Re: [RFC PATCH] drivers: regulator: add error checks for exported APIs

2012-07-26 Thread ABRAHAM, KISHON VIJAY
On Thu, Jul 26, 2012 at 4:52 PM, Mark Brown wrote: > On Thu, Jul 26, 2012 at 04:49:21PM +0530, ABRAHAM, KISHON VIJAY wrote: >> On Thu, Jul 26, 2012 at 4:40 PM, Mark Brown > >> > Also NULL is a valid regulator (though we don't use it right now). > >> I see a lo

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-07-30 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 30, 2012 at 3:07 PM, Shubhrajyoti wrote: > On Monday 30 July 2012 02:39 PM, Kishon Vijay Abraham I wrote: >> + writel(~PHY_PD, phy->control_dev); >> + /* XXX: add proper documentation for this delay */ >> +

Re: [PATCH 1/4] usb: phy: add a new driver for usb3 phy

2012-09-20 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 8:11 PM, Marc Kleine-Budde wrote: > On 09/19/2012 01:30 PM, Kishon Vijay Abraham I wrote: >> Added a driver for usb3 phy that handles the interaction between usb phy >> device and dwc3 controller. >> >> This also includes device tree supp

Re: [PATCH v3] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-21 Thread ABRAHAM, KISHON VIJAY
;= 0) > + params.type = TEGRA_USB_PHY_TYPE_ULPI; > + else > + params.type = TEGRA_USB_PHY_TYPE_INVALID; > + } > + } > + > + params.mode = TEGRA_USB_PHY_MODE_HOST; > + p

Re: [PATCH v3] USB: PHY: Re-organize Tegra USB PHY driver

2012-09-23 Thread ABRAHAM, KISHON VIJAY
Hi, On Sat, Sep 22, 2012 at 2:08 PM, Venu Byravarasu wrote: >> -Original Message- >> From: Stephen Warren [mailto:swar...@wwwdotorg.org] >> Sent: Friday, September 21, 2012 9:45 PM >> To: ABRAHAM, KISHON VIJAY >> Cc: Venu Byravarasu; ba...@ti.com; gre

Re: [PATCH 1/5] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 24, 2012 at 6:45 PM, Rob Herring wrote: > On 09/06/2012 09:57 AM, Kishon Vijay Abraham I wrote: >> All phy related programming like enabling/disabling the clocks, powering >> on/off the phy is taken care of by this driver. It is also used for OTG >> related f

Re: [PATCH 4/4] usb: phy: omap-usb2: enable 960Mhz clock for omap5

2012-09-25 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, Sep 19, 2012 at 5:26 PM, Felipe Balbi wrote: > On Wed, Sep 19, 2012 at 05:00:29PM +0530, Kishon Vijay Abraham I wrote: >> "usb_otg_ss_refclk960m" is needed by usb2 phy present in omap5. For >> omap4, the clk_get of this clock will fail since it do

Re: [RFC PATCH] drivers: phy: add generic PHY framework

2012-09-26 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Sep 17, 2012 at 3:03 PM, Marc Kleine-Budde wrote: > On 09/14/2012 03:06 PM, ABRAHAM, KISHON VIJAY wrote: > > [...] > >>>> diff --git a/drivers/phy/phy-core.c b/drivers/phy/phy-core.c >>>> new file mode 100644 >>>> index 000..c5544

Re: [PATCH v7 1/7] drivers: usb: phy: add a new driver for omap usb2 phy

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Aug 6, 2012 at 6:37 PM, Kishon Vijay Abraham I wrote: > All phy related programming like enabling/disabling the clocks, powering > on/off the phy is taken care of by this driver. It is also used for OTG > related functionality like srp. > > This also includes device t

Re: [PATCH] arm: omap: hwmod: make *phy_48m* as the main_clk of ocp2scp

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Mon, Jul 2, 2012 at 2:25 PM, Kishon Vijay Abraham I wrote: > Made *ocp2scp_usb_phy_phy_48m* as the main_clk for ocp2scp. > Since this ocp2scp module does not have any fck but does have a > single opt_clock, it is added as the main_clk for ocp2scp. Also > removed phy_48m as

Re: [RFC PATCH 2/5] arm: omap: remove ocp2scp_usb_phy_ick clock node

2012-09-06 Thread ABRAHAM, KISHON VIJAY
Hi, On Wed, May 30, 2012 at 4:26 PM, Kishon Vijay Abraham I wrote: > "ocp2scp_usb_phy_ick" clock node was a fake clock node created > to control MODULEMODE of ocp2scp. Since the hwmod for ocp2scp is now added > (which can be used to control MODULEMODE) this clock node is remo

Re: [PATCH v2 1/2] drivers: bus: add a new driver for omap-ocp2scp

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:50 PM, Felipe Balbi wrote: > Hi, > > On Wed, Jul 18, 2012 at 12:00:38PM +0530, Kishon Vijay Abraham I wrote: >> Adds a new driver *omap-ocp2scp*. This driver takes the responsibility of >> creating all the devices that is connected to OCP2SCP.

Re: [PATCH v6 01/11] drivers: usb: otg: add a new driver for omap usb2 phy

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:57 PM, Felipe Balbi wrote: > On Mon, Jul 30, 2012 at 02:39:50PM +0530, Kishon Vijay Abraham I wrote: >> All phy related programming like enabling/disabling the clocks, powering >> on/off the phy is taken care of by this driver. It is also used for

Re: [PATCH v6 03/11] drivers: usb: otg: make twl6030_usb as a comparator driver to omap_usb2

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:58 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:52PM +0530, Kishon Vijay Abraham I wrote: >> All the PHY configuration other than VBUS, ID GND and OTG SRP are removed >> from twl6030. The phy configurations are taken care by

Re: [PATCH v6 04/11] arm: omap: hwmod: add a new addr space in otg for writing to control module

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 6:59 PM, Felipe Balbi wrote: > On Mon, Jul 30, 2012 at 02:39:53PM +0530, Kishon Vijay Abraham I wrote: >> The mailbox register for usb otg in omap is present in control module. >> On detection of any events VBUS or ID, this register should be written

Re: [PATCH v6 05/11] drivers: usb: twl6030: Add dt support for twl6030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:01 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:54PM +0530, Kishon Vijay Abraham I wrote: >> Add device tree support for twl6030 usb driver. >> Update the Documentation with device tree binding information. >> >> Si

Re: [PATCH v6 07/11] drivers: usb: twl4030: Add device tree support for twl4030 usb

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:02 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:39:56PM +0530, Kishon Vijay Abraham I wrote: >> Add device tree support for twl4030 usb driver. >> Update the Documentation with device tree binding information. >> >> Si

Re: [PATCH v6 11/11] arm: omap: phy: remove unused functions from omap-phy-internal.c

2012-08-03 Thread ABRAHAM, KISHON VIJAY
Hi, On Fri, Aug 3, 2012 at 7:06 PM, Felipe Balbi wrote: > Hi, > > On Mon, Jul 30, 2012 at 02:40:00PM +0530, Kishon Vijay Abraham I wrote: >> All the unnessary functions in omap-phy-internal is removed. >> These functionality are now handled by omap-usb2 phy driver. &

  1   2   3   4   5   6   7   8   9   10   >