Re: [alsa-devel] [PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits

2014-12-23 Thread Jianqun
在 12/24/2014 07:06 AM, Dylan Reid 写道: > On Tue, Dec 23, 2014 at 1:08 AM, Jianqun Xu wrote: >> Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 bits. >> Without this setting, the TDL is default to be 0x00 (means 1 bit), >> and the RDL is default to be 0x1f (me

[PATCH] ASoC: max98090 not need to return fail if fail to request hpdet irq.

2014-07-29 Thread jianqun
From: xujianqun Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the driver can work well without it, can report jack trigger to CPU by a GPIO. But here driver will register fail caused by failed to request irq. Signed-off-by: xujianqun --- sound/soc/codecs/max98090.c |

[PATCH] ASoC: max98090 add irq valid check

2014-07-30 Thread jianqun
From: Jianqun Since IRQ pin from max98090 may NC, the irq number will be zero, that is invalid for request_threaded_irq, so just add irq valid check there. Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the driver can work well without it, can report jack trigger to CPU

Re: [PATCH] ASoC: max98090 not need to return fail if fail to request hpdet irq.

2014-07-30 Thread Jianqun
On 2014年07月30日 14:29, Jarkko Nikula wrote: > On 07/30/2014 04:50 AM, jianqun wrote: >> From: xujianqun >> >> Since hardware may not MUST to use IRQ pin of max98090 as jack detect, the >> driver can work well without it, can report jack trigger to CPU by a GPIO.

[PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090

2014-09-12 Thread Jianqun
This patch to add driver for rockchip board using a max98090. Tested on RK3288 using a max98090. Jianqun (2): ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver ASoC: rockchip-max98090: add driver for rockchip board using a max98090 .../sound/rockchip,rockchip

[PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-09-12 Thread Jianqun
Add documentation for rockchip-max98090 driver, which is need by rockchip board using a max98090. Signed-off-by: Jianqun Xu --- .../sound/rockchip,rockchip-audio-max98090.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings

[PATCH 2/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-09-12 Thread Jianqun
The driver is used for rockchip board using a max98090. Test on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/Kconfig | 9 + sound/soc/rockchip/Makefile| 5 +- sound/soc/rockchip/rockchip_max98090.c | 308 + 3

[PATCH] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-09-12 Thread Jianqun
The driver is used for rockchip board using a max98090. Test on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/Kconfig | 9 + sound/soc/rockchip/Makefile| 5 +- sound/soc/rockchip/rockchip_max98090.c | 326 + 3

[PATCH 2/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-09-12 Thread Jianqun
The driver is used for rockchip board using a max98090. Test on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/Kconfig | 9 + sound/soc/rockchip/Makefile| 5 +- sound/soc/rockchip/rockchip_max98090.c | 326 + 3

[PATCH] ARM: dts: add rk3288 i2s controller

2014-09-12 Thread Jianqun
Add dt for rk3288 i2s controller, since i2s clock pins and data pins default to be GPIO, this patch also add pinctrl to mux them. Tested on RK3288 board. Signed-off-by: Jianqun Xu --- arch/arm/boot/dts/rk3288.dtsi | 26 ++ 1 file changed, 26 insertions(+) diff --git a

[PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-09-12 Thread Jianqun
Add documentation for rockchip-max98090 driver, which is need by rockchip board using a max98090. Signed-off-by: Jianqun Xu --- changes since v1: - modify error text from "Tegra" to "rockchip" .../sound/rockchip,rockchip-audio-max98090.txt | 23 ++

Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-09-12 Thread Jianqun
在 09/12/2014 06:04 PM, Heiko Stübner 写道: > Hi Jianqun, > > Am Freitag, 12. September 2014, 17:10:55 schrieb Jianqun: >> Add documentation for rockchip-max98090 driver, which is need by rockchip >> board using a max98090. >> >> Signed-off-by: Jianqun Xu >&g

[PATCH v2] ARM: dts: add rk3288 i2s controller

2014-09-12 Thread Jianqun
Add dt for rk3288 i2s controller, since i2s clock pins and data pins default to be GPIO, this patch also add pinctrl to mux them. Tested on RK3288 board. Signed-off-by: Jianqun Xu --- change since v1: - move i2s relate codes later in order by CPU address map arch/arm/boot/dts/rk3288.dtsi | 26

[PATCH 2/5] ASoC: rockchip-i2s: fix master mode set bit error

2014-09-12 Thread Jianqun
Fix error format set to I2S master or slave mode. Test on RK3288 board with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/rockchip_i2s.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c

[PATCH 1/5] ASoC: rockchip-i2s: fix rockchip i2s defination more reasonable

2014-09-12 Thread Jianqun
Fix SND_ROCKCHIP_I2S to be more reasonable - SND_SOC_ROCKCHIP_I2S, SND_SOC_ROCKCHIP_I2S should select by audio driver, instead of SND_SOC_ROCKCHIP. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/Kconfig | 3 +-- sound/soc/rockchip/Makefile | 2 +- 2 files changed, 2 insertions(+), 3

[PATCH 3/5] ASoC: rockchip-i2s: add dma data to snd_soc_dai

2014-09-12 Thread Jianqun
Add playback/capture dma data to snd_soc_dai. Test on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/rockchip_i2s.c | 23 +-- 1 file changed, 13 insertions(+), 10 deletions(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip

[PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number

2014-09-12 Thread Jianqun
Reference to RK3288 TRM, fix an error channel id for i2s tx and rx Table 10-1 DMAC_BUS Request Mapping Table Req number Source Polarity 0 I2S tx High level 1 I2S rx High level Tested on RK3288 board. Signed-off-by: Jianqun --- Documentation/devicetree

[PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller

2014-09-12 Thread Jianqun
Reference rockchip I2S controller TRM, modify some registers' property I2S_FIFOLR: read / write, but not volatile, not precious I2S_INTSR: read / write I2S_CLR: volatile, register value will be cleared by read Test on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/roc

[PATCH 0/5] ASoC: rockchip-i2s: patches for rockchip i2s driver

2014-09-12 Thread Jianqun
These patches to fix rockchip i2s driver bugs, also make driver codes reasonable. Tested on RK3288 board. Jianqun (5): ASoC: rockchip-i2s: fix rockchip i2s defination more reasonable ASoC: rockchip-i2s: fix master mode set bit error ASoC: rockchip-i2s: add dma data to snd_soc_dai ASoC

[PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller

2014-09-12 Thread Jianqun
As "hclk" is used for rockchip I2S controller, driver must to enable it in probe. Tested on RK3288 with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/rockchip_i2s.c | 5 + 1 file changed, 5 insertions(+) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/so

Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-09-27 Thread Jianqun
在 09/12/2014 09:44 PM, Mark Brown 写道: > On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote: >> Add documentation for rockchip-max98090 driver, which is need by rockchip >> board using a max98090. > > Can this use simple-card (perhaps after a bit of extension)? I ha

Re: [PATCH 1/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-09-28 Thread Jianqun
在 09/28/2014 06:48 PM, Mark Brown 写道: > On Sun, Sep 28, 2014 at 08:54:27AM +0800, Jianqun wrote: > > Please fix your mailer to word wrap within paragraphs. > >> 在 09/12/2014 09:44 PM, Mark Brown 写道: >>> On Fri, Sep 12, 2014 at 03:30:36PM +0800, Jianqun wrote:

[PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

2014-09-29 Thread Jianqun
T for "i2s_frac", "i2s_pre", "i2s0_clkout" and "sclk_i2s0". Tested on rk3288 board using max98090, with command "aplay " Change-Id: I12faad082566532b65a7de8c0a6845e1c17870e6 Signed-off-by: Jianqun --- drivers/clk/rockchip/clk-rk3288.c | 8

Re: [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

2014-09-29 Thread Jianqun
在 09/30/2014 11:38 AM, Kever Yang 写道: > Hi Jianqun, > > pls add linux-rockc...@lists.infradead.org next time. > OK, thanks > On 09/30/2014 11:12 AM, Jianqun wrote: >> The relation of i2s nodes as follows: >>i2s_src 0

Re: [PATCH 2/5] ASoC: rockchip-i2s: fix master mode set bit error

2014-09-13 Thread Jianqun
在 09/14/2014 12:35 AM, Mark Brown 写道: > On Sat, Sep 13, 2014 at 08:41:03AM +0800, Jianqun wrote: >> Fix error format set to I2S master or slave mode. >> Test on RK3288 board with max98090. > > Applied. Since this is a bug fix it should be one of the first patches > in t

Re: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller

2014-09-13 Thread Jianqun
在 09/14/2014 12:36 AM, Mark Brown 写道: > On Sat, Sep 13, 2014 at 08:42:12AM +0800, Jianqun wrote: >> Reference rockchip I2S controller TRM, modify some registers' property >> I2S_FIFOLR: read / write, but not volatile, not precious >> I2S_INTSR: read / write >> I

Re: [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller

2014-09-13 Thread Jianqun
在 09/14/2014 12:36 AM, Mark Brown 写道: > On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote: >> As "hclk" is used for rockchip I2S controller, driver must to enable >> it in probe. > > Applied, again this is a bug fix. How did the original submissio

Re: [PATCH 5/5] ASoC: rockchip-i2s: enable "hclk" for rockchip I2S controller

2014-09-13 Thread Jianqun
在 09/14/2014 12:37 AM, Mark Brown 写道: > On Sat, Sep 13, 2014 at 08:43:13AM +0800, Jianqun wrote: > >> +++ b/sound/soc/rockchip/rockchip_i2s.c >> @@ -423,6 +423,11 @@ static int rockchip_i2s_probe(struct platform_device >> *pdev) >> dev_err(&pdev-&

Re: [PATCH 4/5] ASoC: rockchip-i2s: fix registers' property of rockchip i2s controller

2014-09-13 Thread Jianqun
在 09/14/2014 04:57 AM, Sergei Shtylyov 写道: > Hello. > > On 9/13/2014 3:42 AM, Jianqun wrote: > >> Reference rockchip I2S controller TRM, modify some registers' property >> I2S_FIFOLR: read / write, but not volatile, not precious >> I2S_INTSR: read / write &

Re: [PATCH] ASoC: rockchip-i2s: dt: swap tx and rx channed request number

2014-09-13 Thread Jianqun
在 09/14/2014 12:40 AM, Mark Brown 写道: > On Sat, Sep 13, 2014 at 09:04:41AM +0800, Jianqun wrote: >> Reference to RK3288 TRM, fix an error channel id for i2s tx and rx >> Table 10-1 DMAC_BUS Request Mapping Table >> Req number Source Polarity >> 0

Re: [PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090

2014-09-13 Thread Jianqun
在 09/12/2014 09:42 PM, Mark Brown 写道: > On Fri, Sep 12, 2014 at 03:26:46PM +0800, Jianqun wrote: >> This patch to add driver for rockchip board using a max98090. >> >> Tested on RK3288 using a max98090. > > This appears to have two slightly different copies of t

[PATCH v2] ASoC: rockchip-i2s: dt: fix an error in the example

2014-09-13 Thread Jianqun
Reference to RK3288 TRM, fix an error in the example by swap "tx" and "rx". Table 10-1 DMAC_BUS Request Mapping Table Req number Source Polarity 0 I2S tx High level 1 I2S rx High level Tested on RK3288 board. Signed-off-by: Jianqun

[PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings

2014-07-11 Thread jianqun
From: Jianqun Xu Add devicetree bindings for i2s controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Jianqun Xu --- .../devicetree/bindings/sound/rockchip-i2s.txt | 37 1 file changed, 37 insertions(+) create mode 100644

[PATCH 0/2] add rockchip i2s driver

2014-07-11 Thread jianqun
From: Jianqun Xu This patch is to add driver for I2S controller in RK3xxx SoCs. The only one change in this patch against which has been reviewed before is to fix randconfig build error with next-20140710 by add "#include ". Jianqun Xu (2): ASoC: dt-bindings: add rockchip i2

[PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-11 Thread jianqun
From: Jianqun Xu Add driver for i2s controller found on rk3066, rk3168 and rk3288 processors from rockchip. Tested on the RK3288 SDK board. Signed-off-by: Jianqun Xu --- sound/soc/Kconfig |1 + sound/soc/Makefile|1 + sound/soc/rockchip/Kconfig

[PATCH 0/2] add rockchip i2s driver

2014-07-01 Thread jianqun
From: Jianqun Xu This patch is to add driver for I2S controller in RK3xxx SoCs. Jianqun Xu (2): ASoC: dt-bindings: add rockchip i2s bindings ASoC: add driver for Rockchip RK3xxx I2S controller .../devicetree/bindings/sound/rockchip-i2s.txt | 45 ++ sound/soc/Kconfig

[PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings

2014-07-01 Thread jianqun
From: Jianqun Xu Add devicetree bindings for i2s controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Jianqun Xu --- .../devicetree/bindings/sound/rockchip-i2s.txt | 45 1 file changed, 45 insertions(+) create mode 100644

[PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-01 Thread jianqun
From: Jianqun Xu Add driver for I2S controller in Rockchip RK3xxx SoCs. This driver patch has been tested on the RK3288 SDK board. Signed-off-by: Jianqun Xu --- sound/soc/Kconfig |1 + sound/soc/Makefile|1 + sound/soc/rockchip/Kconfig| 16

[PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-01 Thread jianqun
From: Jianqun Xu Add driver for I2S controller in Rockchip RK3xxx SoCs. This driver patch has been tested on the RK3288 SDK board. Signed-off-by: Jianqun Xu --- sound/soc/Kconfig |1 + sound/soc/Makefile|1 + sound/soc/rockchip/Kconfig| 16

[PATCH 1/2] ASoC: dt-bindings: add rockchip i2s bindings

2014-07-01 Thread jianqun
From: Jianqun Xu Add devicetree bindings for i2s controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Jianqun Xu --- Changes since v1: - dt-bindings: change dmas and clocks description, adviced by mark.rutland .../devicetree/bindings/sound/rockchip-i2s.txt

Re: [PATCH 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-02 Thread Jianqun
Hi Mark: Since regmap_update_bits is int style, I have to error check every time after call it. Also I find that the tegra_i2s.c call the function without error checking, Could you tell me the right way to handle the regmap_update_bits ? Best Regards On 2014年07月02日 09:01, Huang Tao wrote: > H

Re: randconfig build error with next-20140710, in sound/soc/rockchip/rockchip_i2s.c

2014-07-10 Thread Jianqun
ockchip_i2s.c:526:20: error: expected declaration > specifiers > or ‘...’ before string constant > MODULE_DESCRIPTION("ROCKCHIP IIS ASoC Interface"); > ^ > sound/soc/rockchip/rockchip_i2s.c:527:15: error: expected declaration > specifiers > or ‘...’

Re: randconfig build error with next-20140710, in sound/soc/rockchip/rockchip_i2s.c

2014-07-10 Thread Jianqun
Dear Heiko: FYI On 2014年07月11日 08:07, Jianqun wrote: > Hi Heiko: > > Is it caused by the headfile ? > #include > > Adviced by the maintainers, I tried not to include the headfile one by one, > then to compile > driver each time, I found that is success to compile

[PATCH v2 1/2] ASoC: dt-bindings: add rockchip i2s bindings

2014-07-04 Thread jianqun
From: Jianqun Xu Add devicetree bindings for i2s controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Jianqun Xu --- Changes since v1: - modify the description of clock-names property, adviced by Mark Rutland. - modify the example to fit for rk3288

[PATCH v2 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-04 Thread jianqun
From: Jianqun Xu Add driver for i2s controller found on rk3066, rk3168 and rk3288 processors from rockchip. Tested on the RK3288 SDK board. Signed-off-by: Jianqun Xu --- Changes since v1: Adviced by Varka Bhadram

[PATCH v3 1/2] ASoC: dt-bindings: add rockchip i2s bindings

2014-07-05 Thread jianqun
From: Jianqun Xu Add devicetree bindings for i2s controller found on rk3066, rk3188 and rk3288 processors from rockchip. Signed-off-by: Jianqun Xu --- changes since v2: - change the description of dma-names, adviced by Mark - change the description of interrupts, adviced by Mark - list clock

[PATCH v3 2/2] ASoC: add driver for Rockchip RK3xxx I2S controller

2014-07-05 Thread jianqun
From: Jianqun Xu Add driver for i2s controller found on rk3066, rk3168 and rk3288 processors from rockchip. Tested on the RK3288 SDK board. Signed-off-by: Jianqun Xu --- changes since v2: - replace 4 with DMA_SLAVE_BUSWIDTH_4_BYTES - modify supported rate to SNDRV_PCM_RATE_8000_192000

[PATCH] Rockchip: RK3288: CRU: swap value of bit for CORE clock pll source selection

2014-09-04 Thread jianqun
From: xujianqun For RK3288, core clock pll source select APLL when bit value is 1, select GPLL when bit value is 0; CRU_CLKSEL0_CON [15] - core_clk_pll_sel - CORE clock pll source selection -- 1'b1: select ARM PLL -- 1'b0: select GENERAL PLL BUG=none TEST= "cat /sys/kernel/debug/clk/clk_summary

Re: [PATCH] Rockchip: RK3288: CRU: swap value of bit for CORE clock pll source selection

2014-09-05 Thread Jianqun
OK thanks 在 09/05/2014 03:32 PM, Heiko Stübner 写道: > Hi Jianqun, > > Am Freitag, 5. September 2014, 13:49:26 schrieb jianqun: >> From: xujianqun >> >> For RK3288, core clock pll source select APLL when bit value is 1, select >> GPLL when bit valu

[PATCH 0/2] rockchip-i2s: add power setting for I2S controller and fix some critical bugs

2014-08-29 Thread Jianqun
Add optional power setting for i2s controller found on rk3066, rk3168 and rk3288 processors from rockchip, should according to hardware design. Default setting for I2S controller is powered by 3.3V, there needs this patch if it's powered by 1.8V by hardware design. Jianqun (2): rockchi

[PATCH 1/2] rockchip-i2s: dt: add grf requested properties to set power of I2S controller

2014-08-29 Thread Jianqun
369326653d8a450bae19 Signed-off-by: Jianqun --- Documentation/devicetree/bindings/sound/rockchip-i2s.txt | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/Documentation/devicetree/bindings/sound/rockchip-i2s.txt b/Documentation/devicetree/bindings/sound/rockchip-i2s.txt index 6c5

[PATCH 2/2] rockchip-i2s: add power setting for I2S controller, also fix some bugs

2014-08-29 Thread Jianqun
ky board. Change-Id: If17b8022a38c2974f32bfb2dd4b8d16644ec57ac Signed-off-by: Jianqun --- sound/soc/rockchip/rockchip_i2s.c | 93 +++ sound/soc/rockchip/rockchip_i2s.h | 13 +++--- 2 files changed, 63 insertions(+), 43 deletions(-) diff --git a/sound/soc/rockchip/roc

Re: [PATCH 1/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-10-20 Thread Jianqun
Hi , could someone help to review my patch ? 在 10/07/2014 09:43 AM, Jianqun 写道: > The driver is used for rockchip board using a max98090. > Test on RK3288 board with max98090. > > Signed-off-by: Jianqun Xu > --- > sound/soc/rockchip/Kconfig | 9 + > sound/

[PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

2014-10-21 Thread Jianqun
This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file. Tested on rockchip board based on rk3288. Signed-off-by: Jianqun --- sound/soc/rockchip/Kconfig | 13 + 1 file changed, 13 insertions(+) diff --git a/sound/soc/rockchip

[PATCH] ASoC: rockchip-i2s: add rockchip-max98090 driver support

2014-10-21 Thread Jianqun
This patch is to add support for rockchip board with max98090 codec. It also needs sound node in dt file. Tested on rockchip board based on rk3288. Signed-off-by: Jianqun --- change since v1: -Just make the max98090 driver directly selectable, suggested by Lars sound/soc/rockchip/Kconfig | 12

[PATCH v3] ASoC: rockchip-i2s: add MAX98090 support to Kconfig

2014-10-21 Thread Jianqun
Add SND_SOC_MAX98090 to Kconfig of rockchip ASoC, to support rockchip board using a max98090 codec. Tested on rockchip board based on rk3288. Signed-off-by: Jianqun --- changes since v1: --make the max98090 driver directly selectable, suggested by Lars changes since v2: --modify tristate

[PATCH v2] ASoC: rockchip: i2s: add text after tristate for SND_SOC_ROCKCHIP_I2S

2014-10-31 Thread Jianqun
For SND_SOC_ROCKCHIP_I2S, adding some text after the tristate to make this directly user selectable. Signed-off-by: Jianqun --- changes since v1: -to make this directlyuser selectable by adding some text after the tristate as well as the rest, suggested by Mark -to use the existing MAX98090

[PATCH] ASoC: simple-card: add "invert" property for detect GPIOs

2014-10-31 Thread Jianqun
Since hardware may invert detect GPIO of headphone or mic, add one property to support software invert. Signed-off-by: Jianqun --- sound/soc/generic/simple-card.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc

[PATCH] ASoC: rockchip-i2s: fix infinite loop in rockchip_snd_rxctrl

2014-10-29 Thread Jianqun
We can get into an infinite loop if the I2S_CLR register fails to clear due to a missing break statement, so add that. Signed-off-by: Jianqun --- sound/soc/rockchip/rockchip_i2s.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound

Re: [PATCH] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

2014-10-12 Thread Jianqun
在 10/12/2014 02:54 AM, Heiko Stübner 写道: > Hi Jianqun, > > Am Dienstag, 30. September 2014, 11:12:04 schrieb Jianqun: >> The relation of i2s nodes as follows: >> i2s_src 0 059400 0 >> i2s_f

[PATCH v2] clk: rockchip: rk3288: i2s_frac adds flag to set parent's rate

2014-10-12 Thread Jianqun
frac", "i2s_pre" and "sclk_i2s0". Tested on rk3288 board using max98090, with command "aplay " and cat /sys/kernel/debug/clk/clk_summary |grep i2s Signed-off-by: Jianqun --- change since v1: - no "Change-Id"s in upstream patches, suggested by Heiko - to limi

[PATCH 0/2] rockchip-max98090: add driver for rockchip board with max98090

2014-10-06 Thread Jianqun
This patches add driver for rockchip board using a max98090. This could be replaced with simple-card driver but it not work well now. Tested on RK3288 using a max98090. Jianqun (2): ASoC: rockchip-max98090: add driver for rockchip board using a max98090 ASoC: rockchip-max98090: add

[PATCH 1/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-10-06 Thread Jianqun
The driver is used for rockchip board using a max98090. Test on RK3288 board with max98090. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/Kconfig | 9 + sound/soc/rockchip/Makefile| 5 +- sound/soc/rockchip/rockchip_max98090.c | 346

[PATCH 2/2] ASoC: rockchip-max98090: add documentation for rockchip-max98090 driver

2014-10-06 Thread Jianqun
Add documentation for rockchip-max98090 driver, which is need by rockchip board using a max98090. Signed-off-by: Jianqun Xu --- .../sound/rockchip,rockchip-audio-max98090.txt | 23 ++ 1 file changed, 23 insertions(+) create mode 100644 Documentation/devicetree/bindings

Re: [PATCH] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-10-02 Thread Jianqun
Hi Mark: I'm still try to use simple-card driver but it hasn't do work from now on, could I to update rockchip-max98090.c at the same time ? 在 09/12/2014 09:52 PM, Mark Brown 写道: > On Fri, Sep 12, 2014 at 03:39:48PM +0800, Jianqun wrote: > >> +#define RK_PLAT_CLK_12M 1

[PATCH v2 2/2] ASoC: rockchip-max98090: add driver for rockchip board using a max98090

2014-10-02 Thread Jianqun
The driver is used for rockchip board using a max98090. Test on RK3288 board with max98090. Signed-off-by: Jianqun Xu --- changes since v1: - remove unused defination RK_PLAT_CLK_12M, suggested by Mark - set master clock according to sample rate, suggested by Mark - set i2s as master mode for

Re: [PATCH 2/2] rockchip: efuse: add efuse driver for rk3288 efuse

2014-12-02 Thread Jianqun
Hi Heiko 在 12/01/2014 10:10 PM, Heiko Stübner 写道: > Hi Jianqun, > > Am Montag, 1. Dezember 2014, 15:34:41 schrieb Jianqun Xu: >> Add driver for efuse found on rk3288 board based on rk3288 SoC. >> Driver will read fuse information of chip at the boot stage of >> kern

Re: [PATCH 2/2] ASoC: rockchip: i2s: add support for grabbing output clock to codec

2014-12-02 Thread Jianqun
Hi Doug: 在 12/03/2014 01:54 AM, Doug Anderson 写道: > Jianqun, > > This ought to be a "v3" patch and ideally ought to describe > differences from v2 (after the cut). Please have Kever or Chris > review your next patch before sending it out since I think they are &g

[PATCH] clk: rockchip: rk3288: removing the CLK_SET_RATE_PARENT from i2s_clkout

2014-10-20 Thread Jianqun
Removing the CLK_SET_RATE_PARENT from i2s_clkout, to limit i2s0_clkout to select between its two parent without being able influence the core i2s clock. Tested on rk3288 board, suggested by Heiko. Signed-off-by: Jianqun --- drivers/clk/rockchip/clk-rk3288.c | 2 +- 1 file changed, 1 insertion

Re: [PATCH v6 10/10] ASoC: rockchip_i2s: modify DMA max burst to 1

2015-10-15 Thread Jianqun Xu
his is not possible? Agree with Lars, it's better to fix on DMA driver side since issue caused by dma-controller instead of i2s controller - Lars -- Jianqun Xu | Software engineer | 18750760928 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel

[PATCH 1/2] ASoC: rockchip: i2s: fix error defination of transmit data level

2014-12-23 Thread Jianqun Xu
if CSR=00 TXFIFO1 if CSR=01 TXFIFO2 if CSR=10 TXFIFO3 if CSR=11) is equal to or below this field value. Different to receive data level, transmit data level does not need to "-1". Signed-off-by: Jianqun Xu --- sound/soc/rockchip/rockchip_i2s.h | 2 +- 1 file changed, 1 insertion(+),

[PATCH 0/2] ASoC: rockchip: i2s: fix TDL and RDL to 16 bits

2014-12-23 Thread Jianqun Xu
To make Bus DMA works more efficiency, DMA may work in burst mode, we set the watermark of transmit and receive reach to 16 bits. Jianqun Xu (2): ASoC: rockchip: i2s: fix error defination of transmit data level ASoC: rockchip: i2s: set TDL and RDL to 16 bits sound/soc/rockchip

[PATCH 2/2] ASoC: rockchip: i2s: set TDL and RDL to 16 bits

2014-12-23 Thread Jianqun Xu
Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 bits. Without this setting, the TDL is default to be 0x00 (means 1 bit), and the RDL is default to be 0x1f (means 16 bits). This patch is helpful to fix pop sound, tested on rk3288 board. Signed-off-by: Jianqun Xu --- sound/soc

[PATCH v2 2/3] ASoC: rockchip: i2s: set TDL and RDL to 16 samples

2014-12-24 Thread Jianqun Xu
Set Transmit Data Level(TDL) and Receive Data Level(RDL) to 16 samples. Without this setting, the TDL is default to be 0x00 (means 0 sample), and the RDL is default to be 0x1f (means 32 samples). Signed-off-by: Jianqun Xu --- changes since v1: - modify commit message "bit" to "sam

[PATCH v2 0/3] ASoC: rockchip: i2s: fix watermark to 16 and maxburst to 4

2014-12-24 Thread Jianqun Xu
To make Bus DMA works more efficiency, DMA may work in burst mode, we set the watermark of transmit and receive reach to 16 bits. Jianqun Xu (3): ASoC: rockchip: i2s: fix error defination of transmit data level ASoC: rockchip: i2s: set TDL and RDL to 16 samples ASoC: rockchip: i2s: fix

[PATCH v2 1/3] ASoC: rockchip: i2s: fix error defination of transmit data level

2014-12-24 Thread Jianqun Xu
if CSR=00 TXFIFO1 if CSR=01 TXFIFO2 if CSR=10 TXFIFO3 if CSR=11) is equal to or below this field value. Different to receive data level, transmit data level does not need to "-1". Signed-off-by: Jianqun Xu --- changes since v1: - none sound/soc/rockchip/rockchip_i2s.h | 2 +- 1 file

[PATCH v2 3/3] ASoC: rockchip: i2s: fix maxburst of dma data to 4

2014-12-24 Thread Jianqun Xu
Since RK3288 DMAC's burst length only support max to 4, here set maxburst of playback and capture dma data to 4. Signed-off-by: Jianqun Xu --- changes since v1: - new patch since v1 sound/soc/rockchip/rockchip_i2s.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[PATCH] ASoC: rockchip: i2s: applys rate symmetry for CPU DAI

2015-01-07 Thread Jianqun Xu
This patch applys rate symmetry for rockchip i2s DAI. Signed-off-by: Jianqun Xu --- sound/soc/rockchip/rockchip_i2s.c | 1 + 1 file changed, 1 insertion(+) diff --git a/sound/soc/rockchip/rockchip_i2s.c b/sound/soc/rockchip/rockchip_i2s.c index 59aeec4..abd7cdd 100644 --- a/sound/soc/rockchip

[PATCH] ASoC: rockchip: i2s: add rockchip_dmaengine_pcm_config

2015-01-08 Thread Jianqun Xu
y changing burst length to 1 in the i2s driver. This fix would always work as long as we're sending a multiple of 4 bytes (which so far seems to be the case)" This patch can make the length of dma buffer is aligned to a multiple of burst size and burst length. Signed-off-by: Jianqu

[PATCH 2/7] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct

2021-03-23 Thread Jianqun Xu
Store a pointer from the pinctrl device for the gpio bank. Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h index ba4afab2845f..20f734ce3933 100644

[PATCH RESEND 0/7] gpio-rockchip driver

2021-03-23 Thread Jianqun Xu
Separate gpio driver from pinctrl driver, and support v2 controller. Jianqun Xu (7): pinctrl/rockchip: separate struct rockchip_pin_bank to a head file pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct gpio: separate gpio driver from pinctrl-rockchip driver gpio/rockchip

[PATCH 3/7] gpio: separate gpio driver from pinctrl-rockchip driver

2021-03-23 Thread Jianqun Xu
Separate the gpio driver from the pinctrl driver. Signed-off-by: Jianqun Xu --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-rockchip.c | 657 +++ drivers/pinctrl/pinctrl-rockchip.c | 685

[PATCH 1/7] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file

2021-03-23 Thread Jianqun Xu
Separate struct rockchip_pin_bank to pinctrl-rockchip.h file, which will be used by gpio-rockchip driver in the future. Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.c | 224 +- drivers/pinctrl/pinctrl-rockchip.h | 244 + 2

[PATCH 4/7] gpio/rockchip: use struct rockchip_gpio_regs for gpio controller

2021-03-23 Thread Jianqun Xu
Store register offsets in the struct rockchip_gpio_regs, this patch prepare for the driver update for new gpio controller. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 85 -- drivers/pinctrl/pinctrl-rockchip.h | 38 + 2 files changed

[PATCH 6/7] gpio/rockchip: always enable clock for gpio controller

2021-03-23 Thread Jianqun Xu
Since gate and ungate pclk of gpio has very litte benifit for system power consumption, just keep it always ungate. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 68 +--- 1 file changed, 9 insertions(+), 59 deletions(-) diff --git a/drivers/gpio

[PATCH 5/7] gpio/rockchip: support next version gpio controller

2021-03-23 Thread Jianqun Xu
The next version gpio controller on SoCs like rk3568 have more write mask bits for registers. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 280 ++--- drivers/pinctrl/pinctrl-rockchip.h | 2 + 2 files changed, 215 insertions(+), 67 deletions

[PATCH 7/7] gpio/rockchip: drop irq_gc_lock/irq_gc_unlock for irq set type

2021-03-23 Thread Jianqun Xu
There has spin lock for irq set type already, so drop irq_gc_lock and irq_gc_unlock. Signed-off-by: Jianqun Xu --- drivers/gpio/gpio-rockchip.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/drivers/gpio/gpio-rockchip.c b/drivers/gpio/gpio-rockchip.c index 048e7eecddba..c9c55614bbef

[PATCH] kernel/irq: export irq_gc_set_wake

2021-03-05 Thread Jianqun Xu
Module driver may use irq_gc_set_wake. Signed-off-by: Jianqun Xu --- kernel/irq/generic-chip.c | 1 + 1 file changed, 1 insertion(+) diff --git a/kernel/irq/generic-chip.c b/kernel/irq/generic-chip.c index a23ac2bbf433..f8f23af6ab0d 100644 --- a/kernel/irq/generic-chip.c +++ b/kernel/irq

[PATCH 0/3] gpio-rockchip driver

2021-03-22 Thread Jianqun Xu
Separate gpio driver from pinctrl driver. Jianqun Xu (3): pinctrl/rockchip: separate struct rockchip_pin_bank to a head file pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct gpio: separate gpio driver from pinctrl-rockchip driver drivers/gpio/Kconfig | 8

[PATCH 1/3] pinctrl/rockchip: separate struct rockchip_pin_bank to a head file

2021-03-22 Thread Jianqun Xu
Separate struct rockchip_pin_bank to pinctrl-rockchip.h file, which will be used by gpio-rockchip driver in the future. Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.c | 224 +- drivers/pinctrl/pinctrl-rockchip.h | 244 + 2

[PATCH 3/3] gpio: separate gpio driver from pinctrl-rockchip driver

2021-03-22 Thread Jianqun Xu
Separate the gpio driver from the pinctrl driver. Signed-off-by: Jianqun Xu --- drivers/gpio/Kconfig | 8 + drivers/gpio/Makefile | 1 + drivers/gpio/gpio-rockchip.c | 650 +++ drivers/pinctrl/pinctrl-rockchip.c | 685

[PATCH 2/3] pinctrl/pinctrl-rockchip.h: add pinctrl device to gpio bank struct

2021-03-22 Thread Jianqun Xu
Store a pointer from the pinctrl device for the gpio bank. Signed-off-by: Jianqun Xu --- drivers/pinctrl/pinctrl-rockchip.h | 2 ++ 1 file changed, 2 insertions(+) diff --git a/drivers/pinctrl/pinctrl-rockchip.h b/drivers/pinctrl/pinctrl-rockchip.h index 69e4639214b5..0a816e256ae6 100644

[PATCH v2] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Jianqun Xu
print:]]*\)),\n/\tRK_MUXROUTE_SAME(\2), \1\n/g s/[[:blank:]]*\(\/\*[[:print:]]*\*\/\)\n[[:blank:]]*RK_MUXROUTE_SAME(\([[:print:]]*\)),/\tRK_MUXROUTE_SAME(\2), \1\n/g " drivers/pinctrl/pinctrl-rockchip.c Signed-off-by: Jianqun Xu Reviewed-by: Heiko Stuebner

[PATCH v3] pinctrl: rockchip: do coding style for mux route struct

2021-04-20 Thread Jianqun Xu
print:]]*\)),\n/\tRK_MUXROUTE_SAME(\2), \1\n/g s/[[:blank:]]*\(\/\*[[:print:]]*\*\/\)\n[[:blank:]]*RK_MUXROUTE_SAME(\([[:print:]]*\)),/\tRK_MUXROUTE_SAME(\2), \1\n/g " drivers/pinctrl/pinctrl-rockchip.c Reviewed-by: Heiko Stuebner Signed-off-by: Jianqun Xu --- v3: - remove change-id v2: - ad

[PATCH] pinctrl: rockchip: do coding style for mux route struct

2021-04-05 Thread Jianqun Xu
print:]]*\)),\n/\tRK_MUXROUTE_SAME(\2), \1\n/g s/[[:blank:]]*\(\/\*[[:print:]]*\*\/\)\n[[:blank:]]*RK_MUXROUTE_SAME(\([[:print:]]*\)),/\tRK_MUXROUTE_SAME(\2), \1\n/g " drivers/pinctrl/pinctrl-rockchip.c Signed-off-by: Jianqun Xu Change-Id: Ifc823d9557605b9dfcc9c0455a739f04f3fce5be --- drive

[PATCH] mm/slab: kmalloc with GFP_DMA32 allocate from SLAB_CACHE_DMA32

2021-03-12 Thread Jianqun Xu
The flag GFP_DMA32 only effect in kmalloc_large currently. This patch will create caches with GFP_DMA32 to support kmalloc with size under KMALLOC_MAX_CACHE_SIZE. Signed-off-by: Jianqun Xu --- include/linux/slab.h | 7 +++ mm/slab_common.c | 14 ++ 2 files changed, 21

[PATCH v4 4/4] ARM64: dts: rockchip: add dts file for RK3399 evaluation board

2016-04-27 Thread Jianqun Xu
This patch add rk3399-evb.dts for RK3399 evaluation board. Tested on RK3399 evb. Signed-off-by: Jianqun Xu --- changes in v4: - add google,rk3399evb-rev2 compatible (Doug, Heiko) changes in v3: - add more compatible (Doug) - add modle arch/arm64/boot/dts/rockchip/Makefile | 1 + arch

[PATCH v4 1/4] Documentation: rockchip-dw-mshc: add description for rk3399

2016-04-27 Thread Jianqun Xu
From: Shawn Lin Add "rockchip,rk3399-dw-mshc", "rockchip,rk3288-dw-mshc" for dwmmc on rk3399 platform. Acked-by: Rob Herring Signed-off-by: Shawn Lin Signed-off-by: Jianqun Xu --- Documentation/devicetree/bindings/mmc/rockchip-dw-mshc.txt | 1 + 1 file changed, 1 insert

[PATCH v4 2/4] ARM64: dts: rockchip: add core dtsi file for RK3399 SoCs

2016-04-27 Thread Jianqun Xu
/182 and on the following branch: git://git.kernel.org/pub/scm/linux/kernel/git/maz/arm-platforms.git irq/percpu-partition And it has been tested on RK3399 evb and works well. Tested-by: Brian Norris Signed-off-by: Jianqun Xu --- changes in v4: - none changes in v3: - tested irq/percpu-partition

[PATCH v4 3/4] Documentation: devicetree: rockchip: Document rk3399-evb

2016-04-27 Thread Jianqun Xu
Use "rockchip,rk3399-evb" compatible string for Rockchip RK3399 evaluation board. Acked-by: Rob Herring Signed-off-by: Jianqun Xu --- changes in v4: - none changes in v3: - modify title (Rob) Documentation/devicetree/bindings/arm/rockchip.txt | 6 +- 1 file changed, 5 insert

  1   2   3   >