Re: [net-next RFC V5 4/5] virtio_net: multiqueue support

2012-07-22 Thread Jason Wang
On 07/21/2012 08:02 PM, Sasha Levin wrote: On 07/20/2012 03:40 PM, Michael S. Tsirkin wrote: - err = init_vqs(vi); + if (virtio_has_feature(vdev, VIRTIO_NET_F_CTRL_VQ)) + vi->has_cvq = true; + How about we disable multiqueue if there's no cvq? Will make logic a bit si

Re: [PATCH 1/3] drivers-core: make structured logging play nice with dynamic-debug

2012-07-23 Thread Jason Baron
dds "[tid] module:func:line:" to the string, > those additions all got lost. > > Signed-off-by: Jim Cromie > --- > drivers/base/core.c |9 +++-- > 1 file changed, 7 insertions(+), 2 deletions(-) > Acked-by: Jason Baron > diff --git a/drivers/base/core.c b/d

[PATCH] hv: fail the probing immediately when we are not in hyperv platform

2012-08-17 Thread Jason Wang
c: Haiyang Zhang Signed-off-by: Jason Wang --- drivers/hv/hv.c| 25 - drivers/hv/vmbus_drv.c | 25 + 2 files changed, 25 insertions(+), 25 deletions(-) diff --git a/drivers/hv/hv.c b/drivers/hv/hv.c index 86f8885..a18ee5d 100644 --- a/

Re: [RFC PATCH 1/1] trace: Move trace event enable from fs_initcall to early_initcall

2012-08-17 Thread Jason Baron
acepoints and in turn this tracepoints > > depend on kmalloc and friends. So, right now is a chicken-egg problem. > > I don't think kmalloc is the issue. The big problem in front of you is > jump labels. That's what enables and disables trace points, and it gets > initia

Re: [Xen-devel] [V2] xen-netback notify DomU to send ARP.

2013-01-21 Thread Jason Luan
} + + return; ... nor this "return". Agreed on all counts. Jason, when you resend with these fixes please CC the netdev list and folks listed by ./scripts/get-maintainers.pl for the patch. Ian. Thank you for your notifying. ___ Xen

Re: [PATCH 10/14] PCI: tegra: Move PCIe driver to drivers/pci/host

2013-01-22 Thread Jason Gunthorpe
7;t fit 100% perfectly with the standard PCI MSI stuff, and the hardware has funny needs.. So an 'allocate a MSI interrupt' API would be snazzy too :) Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger

Re: [PATCH v2 3/3] timekeeping: Add CONFIG_HAS_PERSISTENT_CLOCK option

2013-01-22 Thread Jason Gunthorpe
check in timekeeping_init(). > > > >Cc: Thomas Gleixner > >Suggested-by: John Stultz > >Signed-off-by: Feng Tang > > Applied. I also added a dependency for Jason's CONFIG_RTC_SYSTOHC. Sort of an ugly config name, since I gather ARM should always set this to 'n&#

Re: [RFC PATCH 0/5] Add support for S3 non-stop TSC support.

2013-01-22 Thread Jason Gunthorpe
the RTC driver being available (after > interrupts are enabled), where we'd have an incorrect system clock. > So we may want to preserve something like the existing > read_persistent_clock() interface, but as Jason suggested, we could > push that access into the RTC driver it

Re: [RFC PATCH 0/5] Add support for S3 non-stop TSC support.

2013-01-22 Thread Jason Gunthorpe
pend' type of call. Take the highest priority clock source that survived suspend and use that delta to update the realtime clock. - If no clock sources survived then attempt to read without interrupts from the RTC driver - If you couldn't read without interrupts from the RT

Re: [PATCH v3] clk: mvebu/clk-cpu.c: fix memory leakage

2013-01-22 Thread Jason Cooper
On Tue, Jan 15, 2013 at 07:44:26PM +0100, Cong Ding wrote: > the variable cpuclk and clk_name should be properly freed when error happens. > > Signed-off-by: Cong Ding > Acked-by: Jason Cooper > --- > drivers/clk/mvebu/clk-cpu.c |9 ++--- > 1 file changed, 6 inser

Re: [PATCH] ARM: kirkwood: fix missing #interrupt-cells property

2013-01-22 Thread Jason Cooper
> Cc: Russell King > Cc: Andrew Lunn > Cc: Jason Cooper > Cc: Arnd Bergmann > Cc: Sebastian Hesselbarth > Cc: Jamie Lentin > Cc: Jean-Francois Moine > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/kirk

Re: [RFC PATCH 0/5] Add support for S3 non-stop TSC support.

2013-01-22 Thread Jason Gunthorpe
d_persistent_clock API then they are already seperate?? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [RFC PATCH 0/5] Add support for S3 non-stop TSC support.

2013-01-22 Thread Jason Gunthorpe
during the last suspend/resume cycle, false otherwise. Ditto for that ARM case. This seems reasonably simple, compared to adding a new API, new drivers, new function pointer multiplexors to arches... Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

[PATCH 1/2] tuntap: reduce memory using of queues

2013-01-23 Thread Jason Wang
userspace only use one queue and also reduce MAX_TAP_QUEUES to DEFAULT_MAX_NUM_RSS_QUEUES which can guarantee the success of the allocation. Reported-by: Dirk Hohndel Cc: Eric Dumazet Cc: David Woodhouse Cc: Michael S. Tsirkin Signed-off-by: Jason Wang --- drivers/net/tun.c | 15

[PATCH 2/2] tuntap: limit the number of flow caches

2013-01-23 Thread Jason Wang
this by introducing a limit of total number of flow caches. Cc: Stephen Hemminger Signed-off-by: Jason Wang --- drivers/net/tun.c |7 ++- 1 files changed, 6 insertions(+), 1 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 8939d21..cc09b67 100644 --- a/drivers/net

Re: [RFC PATCH 0/5] Add support for S3 non-stop TSC support.

2013-01-23 Thread Jason Gunthorpe
of his patch with some of these ideas? He has hardware to test it :) I agree it would be clearer to see with code!! > I appreciate your persistence here, and apologies for my thick-headed-ness. NP Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-ker

Re: [PATCH 2/2] tuntap: limit the number of flow caches

2013-01-23 Thread Jason Wang
On 01/24/2013 02:50 AM, David Miller wrote: > From: Jason Wang > Date: Wed, 23 Jan 2013 21:59:13 +0800 > >> We create new flow caches when a new flow is identified by tuntap, This may >> lead >> some issues: >> >> - userspace may produce a huge amo

Re: [PATCH] ARM: Dove: convert usb host controller to DT

2013-02-15 Thread Jason Cooper
ently. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Thomas Petazzoni > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/dove.dtsi | 1

Re: [PATCH v3 3/3] arm: mvebu: enable gpio expander over i2c on Mirabox platform

2013-02-16 Thread Jason Cooper
: 89f5df0 gpio: pca953x: add support for pca9505 f5f0b7a gpio: pca953x: make the register access by GPIO bank thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at ht

Re: [PATCH] ARM: dove: convert serial DT nodes to clocks property

2013-02-16 Thread Jason Cooper
ian Hesselbarth > --- > Cc: Russell King > Cc: Sebastian Hesselbarth > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Thomas Petazzoni > Cc: linux-arm-ker...@lists.infradead.org > Cc: linux-kernel@vger.kernel.org > --- > arch/arm/boot/dts/dove.dtsi |8 &g

[GIT PULL] KGDB/KDB fixes for 3.7

2012-10-12 Thread Jason Wessel
Linus, Please pull the kgdb tree's usual minor fixes/improvements. git://git.kernel.org/pub/scm/linux/kernel/git/jwessel/kgdb.git tags/for_linus-3.7 Thanks, Jason. - The following changes since c

Re: [PATCH v2] TPM: Provide a tpm_tis OF driver

2012-10-12 Thread Jason Gunthorpe
removes the ifdef around of_match_table, which now generates > an error: Yes, this update was following the style of other drivers. Obviously I never thought to try this on x86 (only PPC), so I will try to setup a compile for that as well and send v3. I suspect this is simply a missing

Re: [PATCH] TPM: Let the tpm char device be openable multiple times

2012-10-12 Thread Jason Gunthorpe
On Wed, Oct 10, 2012 at 11:33:24AM -0500, Kent Yoder wrote: > On Sun, Sep 30, 2012 at 05:33:45PM -0600, Jason Gunthorpe wrote: > > How to use the TPM is really a user space policy choice, if the > > environment wants to use middleware then fine, but it is possible to > >

Re: [PATCH] [ARM] Use AT() in the linker script to create correct program headers

2012-10-12 Thread Jason Gunthorpe
est, simplest boot loader possible so I want to push this into the kernel to lighten my development load. > Your problem is unlikely to affect people outside the embedded space > too much, but it doesn't sound likely to be unique. Agreed.. This thread has left the original topi

Re: [tpmdd-devel] [PATCH] TPM: Let the tpm char device be openable multiple times

2012-10-15 Thread Jason Gunthorpe
On Mon, Oct 15, 2012 at 08:35:09AM +, peter.hu...@infineon.com wrote: > > From: Jason Gunthorpe [mailto:jguntho...@obsidianresearch.com] > > > Using open/close is an interesting idea, but it wouldn't work. open() > > is coded to return EBUSY if another proces

Re: [tpmdd-devel] [PATCH] TPM: Let the tpm char device be openable multiple times

2012-10-15 Thread Jason Gunthorpe
. We have here a situation where there is no kernel or hardware requirement for exclusivity, but the current driver enforces it, for userspace only. Today the kernel and user space can access the TPM device concurrently. So, I would like to migrate the userspace interface to allow non-exclusivity

Re: [PATCH 0/3] Drivers: hv: vmbus

2012-10-16 Thread Jason Wang
On 10/13/2012 04:22 AM, K. Y. Srinivasan wrote: Fix a bug in the error path of vmbus_open(). As part of this also get rid of some unnecessary forward declarations as well as empty functions. I would like to thank Jason Wang for reporting the issues. K. Y. Srinivasan (3): Drivers: hv: Get rid

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2012-11-20 Thread Jason Cooper
to make sure such the * allocations won't fail. */ init_dma_coherent_pool_size(SZ_1M); We have a pending patch to do the same for mvebu (new armv7 Marvell SoCs). There is at least one reported real world case where even the above isn't sufficient [1]. thx, Jason. [1] http://www.spinics.

[PATCH] lib/vsprintf.c: Fix handling of %zd when using ssize_t

2012-11-20 Thread Jason Gunthorpe
signed. Tested on PPC32. Signed-off-by: Jason Gunthorpe --- lib/vsprintf.c |5 - 1 files changed, 4 insertions(+), 1 deletions(-) diff --git a/lib/vsprintf.c b/lib/vsprintf.c index 39c99fe..41da074 100644 --- a/lib/vsprintf.c +++ b/lib/vsprintf.c @@ -1485,7 +1485,10 @@ int vsnprintf

[PATCH v3] TPM: Provide a tpm_tis OF driver

2012-11-20 Thread Jason Gunthorpe
This provides an open firwmare driver binding for tpm_tis. OF is useful on arches where PNP is not used. Allow the tpm_tis driver to be selected if PNP or OF are compiled in. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/Kconfig |2 +- drivers/char/tpm/tpm_tis.c | 76

[PATCH resend] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-11-20 Thread Jason Gunthorpe
The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if TPM_STARTUP has not been issued. Detect this and automatically issue TPM_STARTUP. This is for embedded applications where the kernel is the first thing to touch the TPM. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm

[PATCH] of: Have of_device_add call platform_device_add rather than device_add

2012-11-20 Thread Jason Gunthorpe
This allows platform_device_add a chance to call insert_resource on all of the resources from OF. At a minimum this fills in proc/iomem and presumably makes resource tracking and conflict detection work better. Signed-off-by: Jason Gunthorpe --- drivers/of/device.c |2 +- 1 files changed, 1

Re: [PATCH 0/4] Dove pinctrl fixes and DT enabling

2012-11-21 Thread Jason Cooper
gt; > >> Sounds like a plan. So you have some commit history pulled > >> in from the pinctrl tree in the MVEBU tree? > > > > I am referring to patches for a pinctrl/mvebu subfolder. IIRC Thomas > > posted that patch a while ago. Jason is currently sorting things o

Re: [PATCH resend] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-11-21 Thread Jason Gunthorpe
her user > __attribute__((packed)); > Care to change to be consistent? I used to __packed to avoid a checkpatch warning, they should probably all be changed? Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] of: Have of_device_add call platform_device_add rather than device_add

2012-11-21 Thread Jason Gunthorpe
On Wed, Nov 21, 2012 at 03:51:04PM +, Grant Likely wrote: > On Wed, 21 Nov 2012 00:24:48 -0700, Jason Gunthorpe > wrote: > > This allows platform_device_add a chance to call insert_resource > > on all of the resources from OF. At a minimum this fills in proc/iomem > &

Re: [PATCH] of: Have of_device_add call platform_device_add rather than device_add

2012-11-21 Thread Jason Gunthorpe
<0x0200 0x0 0x10 0x0 4>; }; Non-conformant yes, but it is the simplest way to get linux to bind two drivers to the same memory space. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the b

Re: [PATCH v4] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-11-21 Thread Jason Gunthorpe
The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if TPM_STARTUP has not been issued. Detect this and automatically issue TPM_STARTUP. This is for embedded applications where the kernel is the first thing to touch the TPM. Signed-off-by: Jason Gunthorpe Tested-by: Peter Huewe

Re: [PATCH v4] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-11-21 Thread Jason Gunthorpe
ke this in my tree because of: http://permalink.gmane.org/gmane.linux.kernel/1397887 I should really get sparse setup here... Never enough hours. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info

[PATCH v5] TPM: Issue TPM_STARTUP at driver load if the TPM has not been started

2012-11-21 Thread Jason Gunthorpe
The TPM will respond to TPM_GET_CAP with TPM_ERR_INVALID_POSTINIT if TPM_STARTUP has not been issued. Detect this and automatically issue TPM_STARTUP. This is for embedded applications where the kernel is the first thing to touch the TPM. Signed-off-by: Jason Gunthorpe Tested-by: Peter Huewe

[PATCH] TPM: Switch to __packed instead of __attribute__((packed))

2012-11-21 Thread Jason Gunthorpe
This seems to be preferred these days. Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/tpm.h | 34 +- 1 files changed, 17 insertions(+), 17 deletions(-) As discussed with Peter. diff --git a/drivers/char/tpm/tpm.h b/drivers/char/tpm/tpm.h index c20fa8d

[PATCH] of: When constructing the bus id consider assigned-addresses as well

2012-11-21 Thread Jason Gunthorpe
'assigned-addresses' is used for certain PCI device type nodes in lieu of 'reg', since this is enforced by of/address.c, have of_device_make_bus_id look there as well. Signed-off-by: Jason Gunthorpe --- drivers/of/platform.c |2 ++ 1 files changed, 2 insert

[PATCH] TPM: Work around buggy TPMs that block during continue self test

2012-11-21 Thread Jason Gunthorpe
continue self test The other TPM vendor we use doesn't show this wonky behaviour: tpm_tis 7003.tpm_tis: 1.2 TPM (device-id 0xFE, rev-id 70) Signed-off-by: Jason Gunthorpe --- drivers/char/tpm/tpm.c | 10 +- 1 files changed, 9 insertions(+), 1 deletions(-) diff --git a/driv

Re: [PATCH] of: Have of_device_add call platform_device_add rather than device_add

2012-11-22 Thread Jason Gunthorpe
}; f1010100-f101013f : /internal@f100/gpio@10100 f1010100-f1010103 : /internal@f1000000/chip_cfg@0 What did you try? Maybe order matters? Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord.

Re: [PATCH 0/4] Dove pinctrl fixes and DT enabling

2012-11-23 Thread Jason Cooper
On Fri, Nov 23, 2012 at 08:49:04AM +0100, Linus Walleij wrote: > On Wed, Nov 21, 2012 at 4:52 PM, Jason Cooper wrote: > > On Wed, Nov 21, 2012 at 03:45:42PM +0100, Linus Walleij wrote: > > >> So what I mean is that the patches creating pinctrl/mvebu is in the > >>

Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl

2012-11-23 Thread Jason Cooper
> Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Linus Walleij > Cc: Sebastian Hesselbarth > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Thomas Petazzoni > Cc: Gregory CLEMENT > Cc: Axel Lin > Cc: linux-arm-ker...@lists.infradead.org > Cc

Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl

2012-11-24 Thread Jason Cooper
On Sat, Nov 24, 2012 at 08:02:40AM +0100, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Fri, 23 Nov 2012 21:39:42 -0500, Jason Cooper wrote: > > > + pinctrl: pinctrl@d0200 { > > > + compatible = "marvell,dove-pinctrl"; > &

Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl

2012-11-24 Thread Jason Cooper
On Sat, Nov 24, 2012 at 07:10:24PM +0100, Thomas Petazzoni wrote: > Dear Jason Cooper, > > On Sat, 24 Nov 2012 10:00:04 -0500, Jason Cooper wrote: > > > Yes, so that's what I thought happened. This would have made orion/dt > > depend upon mvebu/everything. It alrea

Re: [PATCH 3/4] ARM: Dove: Convert to DT GPIO and pinctrl

2012-11-25 Thread Jason Cooper
On Sun, Nov 25, 2012 at 11:51:46AM +0100, Sebastian Hesselbarth wrote: > On 11/24/2012 07:59 PM, Jason Cooper wrote: > >On Sat, Nov 24, 2012 at 07:10:24PM +0100, Thomas Petazzoni wrote: > >>On Sat, 24 Nov 2012 10:00:04 -0500, Jason Cooper wrote: > >>>Yes, so that&#x

Re: [PATCH 05/14] lib: Add I/O map cache implementation

2013-01-10 Thread Jason Gunthorpe
On Thu, Jan 10, 2013 at 11:25:44AM +0100, Thierry Reding wrote: > On Thu, Jan 10, 2013 at 09:17:19AM +, Arnd Bergmann wrote: > > On Thursday 10 January 2013, Thierry Reding wrote: > > > On Wed, Jan 09, 2013 at 04:17:58PM -0700, Jason Gunthorpe wrote: > > > > On W

Re: [PATCH 05/14] lib: Add I/O map cache implementation

2013-01-10 Thread Jason Gunthorpe
memory area and splitting it up versus remapping each chunk separately? Not alot, really, but it saves you from the pointer array and associated overhead. IIRC it is fairly easy to do in the kernel. Arnd's version is good too, but you would be restricted to aligned powers of two for the bus

Re: [PATCH 05/14] lib: Add I/O map cache implementation

2013-01-10 Thread Jason Gunthorpe
ould only access bus numbers that are in the range of the subordinate busses of the bridges. So if you establish a mapping on a bus-by-bus basis at first access, it should be fine and very close to minimal.. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&q

Re: [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

2013-01-10 Thread Jason Wang
On 01/11/2013 06:39 AM, David Miller wrote: > From: Stefan Hajnoczi > Date: Thu, 10 Jan 2013 08:59:48 +0100 > >> Multiqueue tun devices support detaching a tun_file from its tun_struct >> and re-attaching at a later point in time. This allows users to disable >> a specific queue temporarily. >> >

Re: [PATCH V3 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-11 Thread Jason Wang
On 01/11/2013 03:12 AM, Ben Hutchings wrote: > On Thu, 2013-01-10 at 11:19 +1030, Rusty Russell wrote: >> Wanlong Gao writes: >>> On 01/09/2013 07:31 AM, Rusty Russell wrote: Wanlong Gao writes: > */ > static u16 virtnet_select_queue(struct net_device *dev, struct sk_buff > *

Re: [PATCH 3.8-rc] tuntap: refuse to re-attach to different tun_struct

2013-01-11 Thread Jason Wang
On 01/11/2013 01:12 PM, David Miller wrote: > From: Jason Wang > Date: Fri, 11 Jan 2013 09:29:20 +0800 > >> On 01/11/2013 06:39 AM, David Miller wrote: >>> From: Stefan Hajnoczi >>> Date: Thu, 10 Jan 2013 08:59:48 +0100 >>> >>>> Multiq

Re: [PATCH V4 1/2] virtio-net: fix the set affinity bug when CPU IDs are not consecutive

2013-01-11 Thread Jason Wang
from CPU to the preferable virtual-queue. Looks like ixgbe is trying to handling a similar issue recently by trying to reuse XPS when the channels and cpus are not equal. I wonder whether we can use the same method. > > Cc: Rusty Russell > Cc: "Michael S. Tsirkin" > Cc: Ja

[PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

2013-01-11 Thread Jason Wang
o need to do the check again in tun_set_iff(), so this patch removes it. Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi Signed-off-by: Jason Wang --- drivers/net/tun.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index 99b58d8..9a46

[PATCH 2/2] tuntap: fix leaking reference count

2013-01-11 Thread Jason Wang
times, we need unset it for another N times. Solving this by only hold or drop an reference when there's a flag change and also drop the reference count when the persist device is deleted. Signed-off-by: Jason Wang --- drivers/net/tun.c | 12 +--- 1 files changed, 9 insertions(

Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

2013-01-11 Thread Jason Wang
On 01/11/2013 10:42 PM, Stefan Hajnoczi wrote: > On Fri, Jan 11, 2013 at 04:50:41PM +0800, Jason Wang wrote: >> @@ -1546,6 +1544,9 @@ static int tun_set_iff(struct net *net, struct file >> *file, struct ifreq *ifr) >> struct net_device *dev; >>

Re: [PATCH 1/2] tuntap: forbid calling TUNSETIFF when detached

2013-01-11 Thread Jason Wang
On 01/11/2013 10:55 PM, Eric Dumazet wrote: > On Fri, 2013-01-11 at 16:50 +0800, Jason Wang wrote: > >> >> +if (rcu_dereference_protected(tfile->detached, lockdep_rtnl_is_held())) >> +return -EINVAL; >> + > Thats an open coded rtnl_derefer

[PATCH V2 0/3] some fixes of tuntap

2013-01-11 Thread Jason Wang
om v1: - don't use rcu to dereference tfile->detached as it was already protected by rtnl lock. - add a patch of switching to use rtnl_dereference(). Jason Wang (3): tuntap: switch to use rtnl_dereference() tuntap: forbid calling TUNSETIFF when detached tuntap: fix leaking reference co

[PATCH V2 2/3] tuntap: forbid calling TUNSETIFF when detached

2013-01-11 Thread Jason Wang
o need to do the check again in tun_set_iff(), so this patch removes it. Cc: Michael S. Tsirkin Cc: Stefan Hajnoczi Signed-off-by: Jason Wang --- drivers/net/tun.c |5 +++-- 1 files changed, 3 insertions(+), 2 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index aa963c4..a36b

[PATCH V2 3/3] tuntap: fix leaking reference count

2013-01-11 Thread Jason Wang
times, we need unset it for another N times. Solving this by only hold or drop an reference when there's a flag change and also drop the reference count when the persist device is deleted. Signed-off-by: Jason Wang --- drivers/net/tun.c | 12 +--- 1 files changed, 9 insertions(

[PATCH V2 1/3] tuntap: switch to use rtnl_dereference()

2013-01-11 Thread Jason Wang
Switch to use rtnl_dereference() instead of the open code, suggested by Eric. Cc: Eric Dumazet Signed-off-by: Jason Wang --- drivers/net/tun.c | 27 ++- 1 files changed, 10 insertions(+), 17 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c index

Re: [PATCH v2 2/3] ARM: use clockevents_config_and_register() where possible

2013-01-12 Thread Jason Cooper
ter function where possible to make the codes less error prone > and gain some positive diff stat. > > Signed-off-by: Shawn Guo > Cc: Nicolas Ferre > Reviewed-by: Anton Vorontsov > Acked-by: Kukjin Kim > Cc: Russell King > Cc: Sascha Hauer > Cc: Jason Cooper >

Re: [PATCH] ARM: Dove: move CuBox led pinctrl to gpio-leds node

2013-01-12 Thread Jason Cooper
Sebastian, On Thu, Dec 27, 2012 at 11:21:10PM +0100, Sebastian Hesselbarth wrote: > gpio-leds has support for pinctrl allocation, make use of it. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Sebastian

Re: [PATCH] ARM: Dove: move CuBox led pinctrl to gpio-leds node

2013-01-12 Thread Jason Cooper
On Sat, Jan 12, 2013 at 10:51:35PM +0100, Sebastian Hesselbarth wrote: > On 01/12/2013 10:42 PM, Jason Cooper wrote: > >On Thu, Dec 27, 2012 at 11:21:10PM +0100, Sebastian Hesselbarth wrote: > >>gpio-leds has support for pinctrl allocation, make use of it. > >> &

Re: [PATCH] ARM: Dove: add fixed regulator for CuBox USB power

2013-01-12 Thread Jason Cooper
On Thu, Dec 27, 2012 at 11:21:59PM +0100, Sebastian Hesselbarth wrote: > CuBox needs to enable USB power on a gpio pin. Add a fixed regulator > to always enable usb power on boot. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper &g

Re: [PATCH] ARM: Dove: move CuBox led pinctrl to gpio-leds node

2013-01-12 Thread Jason Cooper
On Thu, Dec 27, 2012 at 11:21:10PM +0100, Sebastian Hesselbarth wrote: > gpio-leds has support for pinctrl allocation, make use of it. > > Signed-off-by: Sebastian Hesselbarth > --- > Cc: Russell King > Cc: Jason Cooper > Cc: Andrew Lunn > Cc: Sebastian Hesselba

Re: [PATCH V3 2/2] vhost: handle polling errors

2013-01-13 Thread Jason Wang
On 01/13/2013 07:10 PM, Michael S. Tsirkin wrote: > On Mon, Jan 07, 2013 at 11:04:32PM +0800, Jason Wang wrote: >> On 01/07/2013 10:55 PM, Michael S. Tsirkin wrote: >>> On Mon, Jan 07, 2013 at 12:38:17PM +0800, Jason Wang wrote: >>>> On 01/06/2013 09:22 PM, Michael

Re: [PATCH V3 2/2] vhost: handle polling errors

2013-01-13 Thread Jason Wang
On 01/14/2013 02:57 PM, Michael S. Tsirkin wrote: > On Mon, Jan 14, 2013 at 10:59:02AM +0800, Jason Wang wrote: >> On 01/13/2013 07:10 PM, Michael S. Tsirkin wrote: >>> On Mon, Jan 07, 2013 at 11:04:32PM +0800, Jason Wang wrote: >>>> On 01/07/2013 10:55 PM, Michael

[PATCH V4 0/3] handle polling erros in vhost/vhost_net

2013-01-15 Thread Jason Wang
drop the buggy tuntap patch Changes from v1: - restore the state before the ioctl when vhost_init_used() fails - log the error when meet polling errors in the data path - don't put into waitqueue when tun_chr_poll() return POLLERR Jason Wang (3): vhost_net: correct error handling in vhost_ne

[PATCH V4 2/3] vhost_net: handle polling errors when setting backend

2013-01-15 Thread Jason Wang
fix, there still could be a polling failure after backend is set, it will addressed by the next patch. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 27 ++- drivers/vhost/vhost.c | 18 +++--- drivers/vhost/vhost.h |2 +- 3 files changed, 34 inserti

[PATCH V4 3/3] tuntap: allow polling/writing/reading when detached

2013-01-15 Thread Jason Wang
still write to an disabled queue to handle this. And user can still do read but just nothing returned. - align the polling behavior with macvtap which never fails when the queue is created. this can simplify the polling errors handling of its user (e.g vhost) Signed-off-by: Jason Wang --- drivers

[PATCH V4 1/3] vhost_net: correct error handling in vhost_net_set_backend()

2013-01-15 Thread Jason Wang
Currently, when vhost_init_used() fails the sock refcnt and ubufs were leaked. Correct this by calling vhost_init_used() before assign ubufs and restore the oldsock when it fails. Signed-off-by: Jason Wang --- drivers/vhost/net.c | 16 +++- 1 files changed, 11 insertions(+), 5

Re: [PATCH 3/4] Enable ecc-mode selection in the driver

2013-01-15 Thread Jason Cooper
patch. As a general note (this series shouldn't be a problem), please sort the series so that you add the driver feature first, then enable it in defconfig, then use it in DT. This way, a future bisection won't run into any nasty surprises, other than what they're looking f

Re: [PATCH v2] clk: mvebu/clk-cpu.c: fix memory leakage

2013-01-15 Thread Jason Cooper
puclk and clk_name should be properly freed when error happens. > > Signed-off-by: Cong Ding > --- > drivers/clk/mvebu/clk-cpu.c | 15 ++- > 1 file changed, 10 insertions(+), 5 deletions(-) Do you want to take this fix through the clock tree? If so, Acked-by: Jaso

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
erent pool is too small! > Please increase it with coherent_pool= kernel parameter! > > after several hours of runtime under heavy load with SATA and > DVB-Sticks (em28xx / drxk and dib0700). Could you try running the system w/o the em28xx stick and see how it goes with v3.7.1? thx, J

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:50:20AM -0800, Greg KH wrote: > On Tue, Jan 15, 2013 at 11:56:42AM -0500, Jason Cooper wrote: > > Greg, > > > > I've added you to the this thread hoping for a little insight into USB > > drivers and their use of coherent and GFP_ATOMIC

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
re are many heavy users of it without error reports. The only thing different here are the three usb dvb dongles. thx, Jason. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger

Re: [PATCH v3] clk: mvebu/clk-cpu.c: fix memory leakage

2013-01-15 Thread Jason Cooper
On Tue, Jan 15, 2013 at 09:46:03PM +0100, Gregory CLEMENT wrote: > If you prefer, Jason agrees to take it, but you probably didn't notice it, > because he uses your former(and no more valid) email when he wrote this. Actually, I caught that after I hit send. I resent (just to him), s

Re: [PATCH v2] mm: dmapool: use provided gfp flags for all dma_alloc_coherent() calls

2013-01-15 Thread Jason Cooper
Soeren, On Tue, Jan 15, 2013 at 03:16:17PM -0500, Jason Cooper wrote: > If my understanding is correct, one of the drivers (most likely one) > either asks for too small of a dma buffer, or is not properly > deallocating blocks from the per-device pool. Either case leads to > exh

Re: [PATCH] NTP: Add a CONFIG_RTC_SYSTOHC configuration

2012-12-12 Thread Jason Gunthorpe
Convert GENERIC_CMOS_UPDATE into SUPPORTS_UPDATE_PERSISTENT_CLOCK. > 2) Add RTC_SYSTOHC but make it depend on !SUPPORTS_UPDATE_PERSISTENT_CLOCK This would only work for ARM, not PPC.. Ultimately I suspect the clean up needed is to convert more things to class rtc drivers and remove update_pers

Re: [PATCH] NTP: Add a CONFIG_RTC_SYSTOHC configuration

2012-12-12 Thread Jason Gunthorpe
ugh rtc_update_persistent_clock or through rtc_hctosys. Basically, as far as I can tell, if rtc_update_persistent_clock succeeds then update_persistent_clock is a nop. I can't find any case where *both* could succeed. Thus trying rtc_update_persistent_clock first is OK. Jason -- To unsubscrib

Re: [PATCH 1/1] Drivers: hv: balloon: Fix a memory leak

2012-12-12 Thread Jason Wang
On 12/12/2012 03:07 AM, K. Y. Srinivasan wrote: > The send buffer was being leaked; fix it. > > Signed-off-by: K. Y. Srinivasan > Reviewed-by: Haiyang Zhang > Reported-by: Jason Wang > --- > drivers/hv/hv_balloon.c | 23 +-- > 1 files chang

DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-13 Thread Jason Gao
Dear List: Description of problem: After installed Centos 6.3(RHEL6.3) on my Dell R710(lastest bios:Version: 6.3.0,Release Date: 07/24/2012) server,and updated lastest kernel "2.6.32-279.14.1.el6.x86_64",I want to use the Intel 82576 ET Dual Port nic's SR-IOV feature,assigning VFs to kvm guest ap

Re: DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-13 Thread Jason Gao
On Fri, Dec 14, 2012 at 12:23 AM, Alex Williamson wrote: > > Device 03:00.0 is your raid controller: > > 03:00.0 RAID bus controller: LSI Logic / Symbios Logic MegaRAID SAS 1078 (rev > 04) > > For some reason it's trying to read from ffe65000, ffe8a000, ffe89000, > ffe86000, ffe87000, ffe84000.

Re: [PATCH 1/3] timekeeping: Add persistent_clock_exist flag

2012-12-13 Thread Jason Gunthorpe
g it - I don't mean to put words in his mouth - Please do > correct me here Jason. :). In other words, we probably should avoid > configurations where both the rtc hctosys and persistent_clock > interfaces are both active. I only studied update_persistent_clock, read_persistent_clock

Re: [PATCH 1/3] timekeeping: Add persistent_clock_exist flag

2012-12-13 Thread Jason Gunthorpe
is used for arch's without the functionality, mach's are arch specific things. ARM provides a function pointer indirection for it's read_persistent_clock implementation. Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a m

Re: DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-13 Thread Jason Gao
On Fri, Dec 14, 2012 at 12:45 PM, Alex Williamson wrote: > Is the MegaRAID firmware and system management firmware the same as > well? Thanks. I'v updated all the firmware using Dell's firmware-tools: # inventory_firmware Wait while we inventory system: System inventory: BIOS = 6.3.0

Re: DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-13 Thread Jason Gao
On Fri, Dec 14, 2012 at 2:56 PM, Jason Gao wrote: > On Fri, Dec 14, 2012 at 12:45 PM, Alex Williamson > wrote: >> Is the MegaRAID firmware and system management firmware the same as >> well? Thanks. > > I'v updated all the firmware using Dell's firmware-tool

[PATCH] tuntap: fix ambigious multiqueue API

2012-12-14 Thread Jason Wang
r LSM/SELinux, the things left is to do proper check during tun_set_queue() if needed. Signed-off-by: Jason Wang --- drivers/net/tun.c | 86 ++-- 1 files changed, 63 insertions(+), 23 deletions(-) diff --git a/drivers/net/tun.c b/drivers/net/tun.c

Re: [PATCH 1/3] timekeeping: Add persistent_clock_exist flag

2012-12-14 Thread Jason Gunthorpe
attery selection and battery life time. Even the presence of a RTC block in a SOC is not a guarentee it will be used universally. Regards, Jason -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] of: Support a PCI device that is compatible with 'simple-bus'

2012-12-14 Thread Jason Gunthorpe
BAR. The DTS has three levels of translation: - platform device child - 0 is the start of a BAR in the pci device - pci device - 0 is the start of the host bridge memory window for the BAR's type - pci controller - 0 is the start of physical memory Thanks, Jason -- To unsubscribe from this l

[PATCH v2] NTP: Add a CONFIG_RTC_SYSTOHC configuration

2012-12-14 Thread Jason Gunthorpe
n ARM kirkwood and PPC405 Signed-off-by: Jason Gunthorpe --- arch/powerpc/kernel/time.c |2 +- drivers/rtc/Kconfig|9 + drivers/rtc/Makefile |1 + drivers/rtc/systohc.c | 44 include/linux/time.h |1 + k

Re: DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-15 Thread Jason Gao
On Sat, Dec 15, 2012 at 5:54 AM, Don Dutile wrote: > mptsas or smi fw has to be different this server: # inventory_firmware Wait while we inventory system: System inventory: BIOS = 6.3.0 SAS/SATA Backplane 0:0 Backplane Firmware = 1.07 PERC 6/i Integrated Controller 0 F

Re: DMAR and DRHD errors[DMAR:[fault reason 06] PTE Read access is not set] Vt-d & intel_iommu

2012-12-15 Thread Jason Gao
On Sat, Dec 15, 2012 at 5:55 AM, Don Dutile wrote: > forgot: did you check that all the bios settings are the same btwn > the 710 systems? Bios settings should be the same between servers, I'v ignored these errors and run KVM on this server,deployed non-critical java production applicati

Re: [PATCH] tuntap: fix ambigious multiqueue API

2012-12-16 Thread Jason Wang
belongs to when it was disabled. > > After the change, the isolation between management and application > could be done > through: TUNSETIFF were only called by management software and > TUNSETQUEUE were > only called by application.For LSM/SELinux, the thi

Re: [PATCH 1/3] timekeeping: Add persistent_clock_exist flag

2012-12-17 Thread Jason Gunthorpe
the case where the RTC was turned on and read_persistent_clock was also turned on. Having a flag in the RTC and disabling read_persistent_clock for that situation would help you avoid the double code path to the same hardware. What is motivating having a RTC but not using RTC lib? Embedded doesn

[PATCH v3] NTP: Add a CONFIG_RTC_SYSTOHC configuration

2012-12-17 Thread Jason Gunthorpe
n ARM kirkwood and PPC405 Signed-off-by: Jason Gunthorpe --- arch/powerpc/kernel/time.c |2 +- drivers/rtc/Kconfig| 10 +- drivers/rtc/Makefile |1 + drivers/rtc/systohc.c | 44 include/linux/rtc.h|1 + k

Re: [PATCH 09/12] tty/console: fix warnings in drivers/tty/serial/kgdboc.c

2012-09-28 Thread Jason Wessel
r': > drivers/tty/serial/kgdboc.c:293:3: warning: statement with no effect > [-Wunused-value] Thanks Arnd! I'll put this in kgdb-next for the upcoming merge window, unless Greg pulls it into his queue first. Acked-by: Jason Wessel Cheers, Jason. -- To unsubscribe from this list: s

<    5   6   7   8   9   10   11   12   13   14   >