Re: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

2020-11-30 Thread ivanhu
Hi Heinrich, Thanks for the patch. It looks good to me, but I noticed that the runtime_supported_mask was introduced after 5.7-rc1. Maybe we should add the kernel version checking for the old kernels. Cheers, Ivan On 11/28/20 3:20 AM, Heinrich Schuchardt wrote: > Since the UEFI 2.8A specificatio

Re: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

2020-11-30 Thread ivanhu
On 11/30/20 5:17 PM, Heinrich Schuchardt wrote: > On 11/30/20 9:16 AM, ivanhu wrote: >> Hi Heinrich, >> >> Thanks for the patch. >> It looks good to me, but I noticed that the runtime_supported_mask was >> introduced after 5.7-rc1. >> Maybe we should add

Re: [PATCH 1/1] efi/efi_test: read RuntimeServicesSupported

2020-12-02 Thread ivanhu
On 12/2/20 7:38 PM, Heinrich Schuchardt wrote: > On 11/30/20 11:38 AM, ivanhu wrote: >> >> >> On 11/30/20 5:17 PM, Heinrich Schuchardt wrote: >>> On 11/30/20 9:16 AM, ivanhu wrote: >>>> Hi Heinrich, >>>> >>>> Than

Re: [PATCH 1/2] efi/efi_test: use memdup_user

2017-05-08 Thread ivanhu
On 05/06/2017 04:53 AM, Matt Fleming wrote: On Sat, 29 Apr, at 09:42:52AM, Geliang Tang wrote: Use memdup_user() helper instead of open-coding to simplify the code. Signed-off-by: Geliang Tang --- drivers/firmware/efi/test/efi_test.c | 11 +++ 1 file changed, 3 insertions(+), 8 dele

Re: [PATCH 2/2] efi/efi_test: drop useless kfree

2017-05-02 Thread ivanhu
On 04/29/2017 09:42 AM, Geliang Tang wrote: Drop useless kfree when memdup_user() failed, since we have already called kfree in memdup_user(). Signed-off-by: Geliang Tang --- drivers/firmware/efi/test/efi_test.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/drivers