Re: [PATCH -next] ext4: fix error return code in ext4_fc_perform_commit()

Thanks, this looks good. Reviewed-by: Harshad Shirwadkar On Thu, Apr 8, 2021 at 12:00 AM Xu Yihang wrote: > > In case of if not ext4_fc_add_tlv branch, an error return code is missing. > > Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") > Reported-by: Hulk R

Re: [PATCH] ext4: Change list_for_each to list_for_each_entry

Hey Daejun, I was taking a look at this again, and just noticed one quick thing: On Tue, Jan 5, 2021 at 1:56 PM harshad shirwadkar wrote: > > Looks good to me, thanks! > > Reviewed-by: Harshad Shirwadkar > > On Wed, Dec 30, 2020 at 5:56 PM Daejun Park wrote: > > > &

Re: KCSAN: data-race in ext4_fc_commit / ext4_fc_commit

Thanks for the report Hao! I think following lines in fast_commit.c are the culprit: if (likely(sbi->s_fc_avg_commit_time)) sbi->s_fc_avg_commit_time = (commit_time + sbi->s_fc_avg_commit_time * 3) / 4; else sbi->s_fc_

Re: possible deadlock in start_this_handle (2)

On Fri, Feb 19, 2021 at 2:20 AM Tetsuo Handa wrote: > > On 2021/02/15 23:29, Jan Kara wrote: > > On Mon 15-02-21 23:06:15, Tetsuo Handa wrote: > >> On 2021/02/15 21:45, Jan Kara wrote: > >>> On Sat 13-02-21 23:26:37, Tetsuo Handa wrote: > Excuse me, but it seems to me that nothing prevents >

Re: [PATCH] ext4: Don't leak old mountpoint samples

Thanks for the patch Richard, it looks good to me. Reviewed-by: Harshad Shirwadkar On Tue, Dec 1, 2020 at 7:29 AM Richard Weinberger wrote: > > As soon the first file is opened, ext4 samples the mountpoint > of the filesystem in 64 bytes of the super block. > It does so using str

Re: [PATCH] ext4: stop update inode before return

Thanks Pan for the fix. Looks good to me. Reviewed-by: Harshad Shirwadkar On Tue, Jan 19, 2021 at 3:04 AM Pan Bian wrote: > > Stop inode updating before returning the error code. > > Fixes: aa75f4d3daae ("ext4: main fast-commit commit path") > Signed-off-by: Pan Bian

Re: [RFC PATCH 1/4] jbd2: make jdb2_debug module parameter per device

I wonder if we should retain the existing module param as well apart from the new device specific logging switch? If that switch is enabled, we'll get jbd2 logs for all the devices. Given that the old jbd2_debug interface was a module param, I wonder somebody somewhere might have infrastructure on

Re: [RFC PATCH v2 1/4] jbd2: make jdb2_debug module parameter per device

gs of a certain disk. > > Signed-off-by: Chunguang Xu > Reviewed-by: Harshad Shirwadkar > --- > fs/jbd2/journal.c | 55 --- > fs/jbd2/transaction.c | 2 +- > include/linux/jbd2.h | 7 ++ > 3 files changed, 60 insertions(

Re: [PATCH] ext4: Change list_for_each to list_for_each_entry

Looks good to me, thanks! Reviewed-by: Harshad Shirwadkar On Wed, Dec 30, 2020 at 5:56 PM Daejun Park wrote: > > list_for_each + list_entry can be changed to list_for_each_entry > It reduces number of variables and lines. > > Signed-off-by: Daejun Park > --- > fs/e

Re: [PATCH] ext4: Fix wrong list_splice in ext4_fc_cleanup

Thanks, that's a good catch! Reviewed-by: Harshad Shirwadkar On Wed, Dec 30, 2020 at 1:53 AM Daejun Park wrote: > > After full/fast commit, entries in staging queue are promoted to main > queue. In ext4_fs_cleanup function, it splice to staging queue to > staging queue.

Re: [PATCH] ext4: Remove expensive flush on fast commit

Thanks Daejun! This looks good. Reviewed-by: Harshad Shirwadkar On Tue, Jan 5, 2021 at 5:32 PM Daejun Park wrote: > > In the fast commit, it adds REQ_FUA and REQ_PREFLUSH on each fast commit > block when barrier is enabled. However, in recovery phase, ext4 compares > CRC value in

[PATCH] blk-wbt: fix performance regression in wbt scale_up/scale_down

fdatasync and dd conv=sync are performed in parallel on 4.19 compared to 4.14. This bug was introduced during refactoring of blk-wbt code. Fixes: a79050434b45 ("blk-rq-qos: refactor out common elements of blk-wbt") Cc: Josef Bacik Signed-off-by: Harshad Shirwadkar --- block/blk-rq-

Re: [PATCH] blk-wbt: fix performance regression in wbt scale_up/scale_down

On Fri, Oct 4, 2019 at 11:09 AM Harshad Shirwadkar wrote: > > scale_up wakes up waiters after scaling up. But after scaling max, it > should not wake up more waiters as waiters will not have anything to > do. This patch fixes this by making scale_up (and also scale_down) > return

Re: [PATCH] ext4: properly check for dirty state in ext4_inode_datasync_dirty()

mplify the logic here and then we can probably get rid of i_fc_committed_subtid field altogether. I'll test this and send out a patch. Thanks, Harshad On Tue, Oct 27, 2020 at 8:27 PM Ritesh Harjani wrote: > > > > On 10/27/20 3:58 AM, harshad shirwadkar wrote: > > Thanks Andr

Re: [PATCH] ext4: properly check for dirty state in ext4_inode_datasync_dirty()

Thanks Andrea for catching and sending out a fix for this. On Sat, Oct 24, 2020 at 7:01 AM Andrea Righi wrote: > > ext4_inode_datasync_dirty() needs to return 'true' if the inode is > dirty, 'false' otherwise, but the logic seems to be incorrectly changed > by commit aa75f4d3daae ("ext4: main fas