From: Hans Holmberg
Ever since '07173c3ec276 ("block: enable multipage bvecs")' we
need to handle bios with multipage bvecs in pblk.
Currently, a multipage bvec results in a crash[1].
Fix this by using bvec iterators in stead of direct bvec indexing.
Also add a dcache
From: Hans Holmberg
pblk_line_meta_free might sleep (it can end up calling vfree, depending
on how we allocate lba lists), and this can lead to a BUG()
if we wake up on a different cpu and release the lock.
As there is no point of grabbing the free lock when pblk has shut down,
remove the lock
From: Hans Holmberg
As chunk metadata is allocated using vmalloc, we need to free it
using vfree.
Fixes: 090ee26fd512 ("lightnvm: use internal allocation for chunk log page")
Signed-off-by: Hans Holmberg
---
drivers/lightnvm/pblk-core.c | 2 +-
1 file changed, 1 insertion(+),
From: Hans Holmberg
pblk stripes writes of minimal write size across all non-offline chunks
in a line, which means that the maximum write pointer delta should not
exceed the minimal write size. Extend the line write pointer balance check
to cover this case.
Signed-off-by: Hans Holmberg
From: Hans Holmberg
pblk stripes writes of minimal write size across all non-offline chunks
in a line, which means that the maximum write pointer delta should not
exceed the minimal write size.
Extend the line write pointer balance check to cover this case, and
ignore the offline chunk wps
n the circumstances.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
> On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
> > Em Wed, 28 Nov 2012 12:56:10 +0100
> > Hans Verkuil escreveu:
> >
> > > On Wed 28 November 2012 12:45:37 Dan Carpenter wrote:
ose cases where you're told to get feature A in the kernel
> release X and it is already late in the development cycle... But it
> might just be a matter of planning the work adequately with proper
> understanding of the whole process.
Well, it would work if you can rely on patch
On Wed November 28 2012 20:30:21 Greg Kroah-Hartman wrote:
> On Wed, Nov 28, 2012 at 08:18:20PM +0100, Hans Verkuil wrote:
> > On Wed November 28 2012 18:22:48 Greg Kroah-Hartman wrote:
> > > On Wed, Nov 28, 2012 at 10:18:02AM -0200, Mauro Carvalho Chehab wrote:
> > >
On Fri November 30 2012 10:47:39 Sakari Ailus wrote:
> On Wed, Nov 28, 2012 at 04:12:00PM +0530, Prabhakar Lad wrote:
> > From: Manjunath Hadli
> >
> > Mauro/Greg,
> > The below series of patches have gone through good amount of reviews, and
> > agreed by Laure
t;smi2021 internal",
> +};
> +
> +int smi2021_i2c_register(struct smi2021_dev *dev)
> +{
> + int rc;
> +
> + id_ptr = 0;
> +
> + dev->i2c_adap = adap_template;
> + dev->i2c_adap.dev.parent = dev->dev;
> + strcpy(dev->i2c_adap.name,
Hi Jon Arne,
Here is my review of this driver.
Regards,
Hans
On Thu March 14 2013 15:06:58 Jon Arne Jørgensen wrote:
> This is the core of the smi2021 module.
> It will register the module with the kernel, and register the
> usb probe function.
>
> Signed-off-by: Jon
ase_empty,
> +};
> +
> +/* Must be called with both v4l2_lock and vb_queue_lock hold */
> +void smi2021_clear_queue(struct smi2021_dev *dev)
> +{
> + struct smi2021_buffer *buf;
> + unsigned long flags;
> +
> + spin_lock_irqsave(&dev->buf_lock, flags);
&
(max_packets, GFP_KERNEL);
> + if (!urb) {
> + smi2021_err("connot allocate urb[%d]\n", i);
> + goto free_i_bufs;
> + }
> + dev->isoc_ctl.urb[i] = urb;
> +#ifndef CONFIG_DMA_NONCOHERENT
> + dev->isoc_ctl.transfer_buffer[i] = usb_alloc_coherent(
> + dev->udev, sb_size, GFP_KERNEL,
> + &urb->transfer_dma);
> +#else
> + dev->isoc_ctl.transfer_buffer[i] = kmalloc(sb_size,
> + GFP_KERNEL);
> +#endif
> + if (!dev->isoc_ctl.transfer_buffer[i]) {
> + smi2021_err("cannot alloc %d bytes for tx[%d] buffer",
> + sb_size, i);
> + goto free_i_bufs;
> + }
> + /* Do not leak kernel data */
> + memset(dev->isoc_ctl.transfer_buffer[i], 0, sb_size);
> +
> + urb->dev = dev->udev;
> + urb->pipe = usb_rcvisocpipe(dev->udev, SMI2021_ISOC_EP);
> + urb->transfer_buffer = dev->isoc_ctl.transfer_buffer[i];
> + urb->transfer_buffer_length = sb_size;
> + urb->complete = smi2021_isoc_isr;
> + urb->context = dev;
> + urb->interval = 1;
> + urb->start_frame = 0;
> + urb->number_of_packets = max_packets;
> +#ifndef CONFIG_DMA_NONCOHERENT
> + urb->transfer_flags = URB_ISO_ASAP | URB_NO_TRANSFER_DMA_MAP;
> +#else
> + urb->transfer_flags = URB_ISO_ASAP;
> +#endif
> + k = 0;
> + for (j = 0; j < max_packets; j++) {
> + urb->iso_frame_desc[j].offset = k;
> + urb->iso_frame_desc[j].length =
> + dev->isoc_ctl.max_pkt_size;
> + k += dev->isoc_ctl.max_pkt_size;
> + }
> + }
> + smi2021_dbg("urbs allocated\n");
> + dev->isoc_ctl.num_bufs = num_bufs;
> + return 0;
> +
> +free_i_bufs:
> + dev->isoc_ctl.num_bufs = i+1;
> + smi2021_free_isoc(dev);
> + return -ENOMEM;
> +}
>
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
em_ops = &vb2_vmalloc_memops;
q->timestamp_type isn't filled in.
For that matter, neither the sequence number nor the timestamp are filled in
in v4l2_buffer during capturing.
You need to add a buf_finish op to fill those in (use v4l2_timestamp() for the
timestamp).
Regards,
Ha
; + "2nd pass failing to read reg 0x%x, usb-errno: %d\n",
> + reg, rc);
> + return rc;
> + }
> +
> + rc = usb_control_msg(dev->udev,
> + usb_rcvctrlpipe(dev->udev, 0x80), 0x01,
> + USB_DIR_IN | USB_TYPE_VENDOR | USB_RECIP_DEVICE,
> + 0x0b, 0x00, rcv_data, 13, 1000);
> + if (rc < 0) {
> + smi2021_warn("Failed to read reg 0x%x, usb-errno: %d\n",
> + reg, rc);
> + return rc;
> + }
> +
> + *val = rcv_data[SMI2021_CTRL_I2C_RCV_VAL];
> + return 0;
> +}
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote:
> > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> > > This file is responsible for registering the device with the v4l2
> > > subsystem,
On Wed 20 March 2013 10:43:26 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:12:31AM +0100, Hans Verkuil wrote:
> > On Thu March 14 2013 15:07:00 Jon Arne Jørgensen wrote:
> > > This file is responsible for registering the device with the v4l2
> > > subsystem,
On Wed 20 March 2013 11:06:36 Jon Arne Jørgensen wrote:
> On Mon, Mar 18, 2013 at 09:58:32AM +0100, Bjørn Mork wrote:
> > Hans Verkuil writes:
> >
> > >> +/*
> > >> + *
> > >> + * The device delivers data in chunks of 0x400 bytes.
> > >
On Wed 20 March 2013 11:16:26 Jon Arne Jørgensen wrote:
> On Wed, Mar 20, 2013 at 11:10:57AM +0100, Hans Verkuil wrote:
> > On Wed 20 March 2013 10:48:42 Jon Arne Jørgensen wrote:
> > > On Mon, Mar 18, 2013 at 09:29:07AM +0100, Hans Verkuil wrote:
> > > > On Thu M
t.pix.pixelformat)
> - return -EINVAL;
> + v4l2_warn(&vip->v4l2_dev, "Invalid format, only UYVY
> supported\n");
As mentioned in my v4 review, keep the return -EINVAL here. As long as it is
uncertain what try_fmt should do with unsupported pixelfor
gt; Signed-off-by: Lad, Prabhakar
> Signed-off-by: Hans Verkuil
> Signed-off-by: Martin Bugge
> Cc: Chaithrika U S
> ---
> Changes for v2:
> 1: Merged the driver in existing ths7303 driver.
> 2: Merged the patch which adds the chip indent in same patch.
>
> dr
I reviewed the code (as well as I could) and didn't see any problems, I'm
giving my ack anyway:
Acked-by: Hans Verkuil
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kern
This patch fixes four foo * bar errors, and one trailing whitespace
complaint from checkpatch.pl
Signed-off-by: Hans Grob
---
drivers/char/mem.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/char/mem.c b/drivers/char/mem.c
index 34e7cb1..3b9f289 100644
On Sun February 10 2013 11:34:11 Knut Petersen wrote:
> Maybe somebody could have at that old locking warning:
It's a false warning. If someone can point me to some documentation on how to
tell lockdep that it isn't a deadlock, then that would be appreciated.
Regards,
On Mon 1 April 2013 08:36:50 Prabhakar lad wrote:
> From: Lad, Prabhakar
>
> Add pm_runtime support to the TI Davinci VPIF driver.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Sakari Ailus
> Cc:
On Tue 2 April 2013 15:41:30 Prabhakar lad wrote:
> From: Lad, Prabhakar
>
> Add pm_runtime support to the TI Davinci VPIF driver.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Mauro Carvalho Chehab
> Cc: Hans Verkuil
Acked-by: Hans Verkuil
Regards,
Hans
> Cc
d ths7353_id[] = {
> + {"ths7353", 0},
> + {},
> +};
> +
> +MODULE_DEVICE_TABLE(i2c, ths7353_id);
> +
> +static struct i2c_driver ths7353_driver = {
> + .driver = {
> + .owner = THIS_MODULE,
> + .name = "ths7353",
> + },
> + .probe = ths7353_probe,
> + .remove = ths7353_remove,
> + .id_table = ths7353_id,
> +};
> +
> +module_i2c_driver(ths7353_driver);
> +
> +MODULE_DESCRIPTION("TI THS7353 video amplifier driver");
> +MODULE_AUTHOR("Muralidharan Karicheri");
> +MODULE_LICENSE("GPL");
>
FYI: Cisco has made drivers for the ths7353 and ths8200 as well. While the
ths7353 is pretty complete it needs some tidying up and the ths8200 still
needs more work.
I don't have time to do that, but I will post our ths7353 driver so you
can take the best bits of both.
Ping me when you start working on the ths8200 (or anyone else who is interested
in that driver) and I can mail it.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
> (V4L2_CID_FM_TX_CLASS_BASE + 114)
> @@ -825,4 +830,10 @@ enum v4l2_dv_rgb_range {
> #define V4L2_CID_DV_RX_POWER_PRESENT(V4L2_CID_DV_CLASS_BASE
> + 100)
> #define V4L2_CID_DV_RX_RGB_RANGE (V4L2_CID_DV_CLASS_BASE + 101)
>
> +#define V4L2_CID_FM_RX_CLASS_
ntrols, try control
> + Get or set the value of several controls, try control
Spurious whitespace change, just revert this to the original.
> values
>
>
> @@ -319,6 +319,15 @@ These controls are described inprocessing controls. These controls are described i
_USER_SI476X_BASE(V4L2_CID_USER_BASE + 0x2000)
Please make this consecutive to MEYE_BASE, so '+ 0x1010'. That makes it easy
to keep track of these control ranges.
Regards,
Hans
> +
> /* MPEG-class control IDs */
>
> #define V4L2_CID_MPEG_BASE
gt; + * - #SI476X_IDX_PHDIV_SECONDARY_COMBINING diversity mode is
> + * on, secondary tuner's antenna is the main one.
> + */
> + [SI476X_IDX_DIVERSITY_MODE] = {
> + .ops= &si476x_ctrl_ops,
> + .id = V4L2_CID_SI476X_DIVERSITY_M
as base
> - Added documentation with controls description
Reviewed this. Found some small stuff, although I need a bit more info
regarding the diversity mode (see my question in the review of patch 8/8).
Depending on that you can likely make a v6 which I can ack.
Regards,
Hans
ic
> functionality and locking scheme.
> 2. Radio device that translates between V4L2 subsystem requests into
> Core device commands.
> 3. Codec device that does similar to the earlier described task, but
> for ALSA SoC subsystem.
>
> v6 of this driver has following changes:
>
r fix in si476x_radio_fops_poll
> - DBG_BUFFER is removed
> - Tested for compilation w/o debugfs enabled
>
> This version still has all the radio controls being private. The
> reason for that is because I am not sure how that should be handled.
>
> Hans, do you want me to mov
; simple or advanced.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Sakari Ailus
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Sylwester Nawrocki
> Cc: Hans de Goede
> Cc: Kyungmin Park
> ---
> This patches
y: Manjunath Hadli
> Cc: Sakari Ailus
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Sylwester Nawrocki
> Cc: Hans de Goede
> Cc: Kyungmin Park
> Cc: Rob Landley
> Cc: HeungJun Kim
> ---
> This patches has one checkpatch warning
On Mon September 3 2012 11:16:17 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc:
-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Sylwester Nawrocki
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Hans de Goede
> Cc: Kyungmin Park
> Cc: Guennadi Liakhovetski
> Cc: Rob Landley
> --
On Tue 11 September 2012 16:23:38 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> Add a helper function to modify the menu, max and default value
> to set.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
>
19:53:38 Prabhakar Lad wrote:
> >> From: Lad, Prabhakar
> >>
> >> Add a helper function to modify the menu, max and default value
> >> to set.
> >>
> >> Signed-off-by: Lad, Prabhakar
> >> Signed-off-by: Manjunath Hadli
> >
(sizeof *conf, GFP_KERNEL);
> + if (!conf)
> + return ERR_PTR(-ENOMEM);
> +
> + conf->dev = dev;
> +
> + return conf;
> +}
> +EXPORT_SYMBOL_GPL(vb2_dma_streaming_init_ctx);
> +
> +void vb2_dma_streaming_cleanup_ctx(void *alloc_ctx)
> +{
&g
Hi Andrey!
Thanks for posting this driver. One request for the future: please split this
patch up in smaller pieces: one for each c source for example. That makes it
easier to review.
On Fri September 14 2012 00:40:11 Andrey Smirnov wrote:
> This patch adds a core driver for Silicon Laboratories
.seek_start = si476x_core_cmd_fm_seek_start,
> + .rsq_status = si476x_core_cmd_fm_rsq_status,
> + .rds_blckcnt= si476x_core_cmd_fm_rds_blockcount,
> + .phase_diversity= si476x_core_cmd_fm_phase_diversity,
> +
2_rect *' but argument is of
> type 'const struct v4l2_rect *'
> make[4]: *** [drivers/media/platform/davinci/vpfe_capture.o] Error 1
Acked-by: Hans Verkuil
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> dr
':
> vpbe_display.c:640: warning: initialization discards qualifiers from pointer
> target type
>
> This patch fixes the above build warning.
Acked-by: Hans Verkuil
Prabhaker, can you make a pull request for this patch, the "CUSTOM_TIMINGS"
rename patch and the earlier
gt;
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> drivers/media/platform/davinci/vpif_capture.c |8 ++--
> drivers/media/platform/davinci/vpif_display.c |8 ++--
> 2 files changed, 12 insertions(+), 4 deletions(-)
On Tue 25 September 2012 16:21:55 Prabhakar wrote:
> From: Lad, Prabhakar
>
> set device_caps and also change the driver and
> bus_info to proper values as per standard.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
>
On Thu 4 October 2012 11:29:57 Prabhakar wrote:
> From: Lad, Prabhakar
>
> from commit with id 896f38f582730a19eb49677105b4fe4c0270b82e
> it's mandatory to check the return code of vb2_queue_init().
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
On Thu 4 October 2012 11:29:58 Prabhakar wrote:
> From: Lad, Prabhakar
>
> set device_caps and also change the driver and
> bus_info to proper values as per standard.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
Acked-by
There seems to be a bug in the PM_SPECIAL macro for /proc/pid/pagemap.
I think masking out those other bits makes more sense then setting all
those mask bits.
Signed-off-by: Hans Rosenfeld <[EMAIL PROTECTED]>
---
fs/proc/task_mmu.c |2 +-
1 files changed, 1 insertions(+), 1 del
On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote:
> On 09/13/2012 11:44 PM, Hans Verkuil wrote:
> > Hi Andrey!
> >
> > Thanks for posting this driver. One request for the future: please split
> > this
> > patch up in smaller pieces:
On Fri September 21 2012 11:21:35 Federico Vaga wrote:
> This patch adds support for prepare/finish callbacks in VB2 allocators.
> These callback are used for buffer flushing.
>
> Signed-off-by: Marek Szyprowski
> Acked-by: Laurent Pinchart
> Acked-by: Federico Vaga
> ---
> drivers/media/v4l2-
On Fri September 21 2012 11:21:37 Federico Vaga wrote:
> This patch re-write the driver and use the videobuf2
> interface instead of the old videobuf. Moreover, it uses also
> the control framework which allows the driver to inherit
> controls from its subdevice (ADV7180)
Some more comments below,
On Fri September 21 2012 18:33:45 andrey.smir...@convergeddevices.net wrote:
> On 09/21/2012 12:31 AM, Hans Verkuil wrote:
> > On Fri September 21 2012 03:05:41 andrey.smir...@convergeddevices.net wrote:
> >> On 09/13/2012 11:44 PM, Hans Verkuil wrote:
> >>> Hi
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
> Signed-off-by: Lad, Prabhakar
> Signed-o
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
> Signed-off-by: Lad, Prabhakar
> Signed-o
On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> On Mon September 24 2012 12:44:11 Prabhakar wrote:
> > From: Lad, Prabhakar
> >
> > vpif_display relied on a 1-1 mapping of output and subdev. This is not
> > necessarily the case. Separate the two. So there is
On Mon September 24 2012 13:50:00 Hans Verkuil wrote:
> On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> > On Mon September 24 2012 12:44:11 Prabhakar wrote:
> > > From: Lad, Prabhakar
> > >
> > > vpif_display relied on a 1-1 mapping of output and subde
On Mon September 24 2012 14:53:40 Prabhakar wrote:
> From: Lad, Prabhakar
>
> Add helper function v4l2_ctrl_new_std_menu_items(), which adds
> a standard menu control, with driver specific menu.
Acked-by: Hans Verkuil
Regards,
Hans
>
> Signed-off-by: Lad, Prabhaka
On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil wrote:
> > On Mon September 24 2012 12:59:11 Hans Verkuil wrote:
> >> On Mon September 24 2012 12:44:11 Prabhakar wrote:
> >> > From: Lad, P
On Mon September 24 2012 14:53:41 Prabhakar wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Acked-by:
On Tue September 25 2012 07:38:12 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Sep 24, 2012 at 7:02 PM, Hans Verkuil wrote:
> > On Mon September 24 2012 15:21:44 Prabhakar Lad wrote:
> >> Hi Hans,
> >>
> >> On Mon, Sep 24, 2012 at 5:20 PM, Hans Verkuil
On Tue September 25 2012 08:09:05 Prabhakar wrote:
> From: Lad, Prabhakar
>
> add V4L2_CID_TEST_PATTERN of type menu, which determines
> the internal test pattern selected by the device.
Acked-by: Hans Verkuil
Regards,
Hans
>
> Signed-off-by: Lad, Prabhaka
and has routing
> information. An output does not have to have a subdev.
>
> The initial output for each channel is set to the fist output.
>
> Currently missing is support for associating multiple subdevs with
> an output.
>
Acked-by: Hans Verkuil
Looks good!
Regards,
On Tue 25 September 2012 13:16:24 Prabhakar wrote:
> From: Lad, Prabhakar
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> ---
> drivers/media/platform/davinci/vpif_capture.c |4 +++-
> drivers/media/platform/davinci/vpif_di
On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
> Hi Hans,
>
> On Tuesday 25 September 2012 13:43:36 Hans Verkuil wrote:
> > On Tue 25 September 2012 13:16:24 Prabhakar wrote:
> > > From: Lad, Prabhakar
> > >
> > > Signed-off-by: Lad, Prabh
On Tue 25 September 2012 15:26:11 Prabhakar Lad wrote:
> Hi Hans/Laurent
>
> On Tue, Sep 25, 2012 at 5:24 PM, Hans Verkuil wrote:
> > On Tue 25 September 2012 13:49:16 Laurent Pinchart wrote:
> >> Hi Hans,
> >>
> >> On Tuesday 25 September 2012 13:
ter kernel 3.10.
> If necessary I can bisect.
Can you try this patch? I'm pretty sure this will fix it.
Regards,
Hans
diff --git a/drivers/media/pci/cx88/cx88.h b/drivers/media/pci/cx88/cx88.h
index afe0eae..28893a6 100644
--- a/drivers/media/pci/cx88/cx88.h
+++ b/drivers
On 08/27/2013 11:35 AM, Knut Petersen wrote:
> On 27.08.2013 09:26, Hans Verkuil wrote:
>> On 08/25/2013 05:45 PM, Knut Petersen wrote:
>>> Booting current git kernel dmesg shows a set of new warnings:
>>>
>>> "wm8775 9-001b: I2C: cannot write ??? t
ore efficient than read() anyway.
Unless there is a very good use-case, I don't see a good reason for mixing
file I/O with streaming I/O ioctls.
Regards,
Hans
>
> Signed-off-by: Ricardo Ribalda Delgado
> ---
> drivers/media/v4l2-core/videobuf2-core.c | 11 ++
al, so replace all occurrences of the
> former with the later.
>
> Signed-off-by: Lars-Peter Clausen
Acked-by: Hans Verkuil
Regards,
Hans
> ---
> drivers/media/v4l2-core/tuner-core.c | 6 +++---
> drivers/media/v4l2-core/v4l2-common.c | 10 +-
> includ
the device.
> >
> > Signed-off-by: Lad, Prabhakar
> > Signed-off-by: Manjunath Hadli
> > Cc: Sakari Ailus
> > Cc: Hans Verkuil
> > Cc: Laurent Pinchart
> > Cc: Mauro Carvalho Chehab
> > Cc: Sylwester Nawrocki
> > Cc: Hans de Goede
> > C
On Mon September 10 2012 13:57:36 Prabhakar Lad wrote:
> From: Lad, Prabhakar
>
> Signed-off-by: Lad, Prabhakar
> Signed-off-by: Manjunath Hadli
> Cc: Hans Verkuil
> Cc: Sakari Ailus
> Cc: Sylwester Nawrocki
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
; + __s8 snr;
> + __s8 issi;
> + __s8 lassi, hassi;
> + __s8 mult;
> + __u8 dev;
> + __u16 readantcap;
> + __s8 assi;
> + __s8 usn;
> +
> + __u8 pilotdev;
> + __u8 rdsdev;
> + __u8 assidev;
> + __u8 strongd
On Sat October 6 2012 03:54:59 Andrey Smirnov wrote:
> This patch adds all the functions used for exchanging commands with
> the chip.
>
> Signed-off-by: Andrey Smirnov
> ---
> drivers/mfd/si476x-cmd.c | 1493
> ++
> 1 file changed, 1493 insertions(+)
Hi Manjunatha,
Can you make a v8? The tuner band issues have been settled and are now merged,
so it would be good to finalize this.
On Mon May 21 2012 19:12:01 manjunatha_ha...@ti.com wrote:
> From: Manjunatha Halli
>
> Mauro and the list,
>
> This version 7 of patchset resolves the comments r
> + args.freq = v4l2_to_si476x(radio->core,
> +92 * FREQ_MUL);
> + retval = radio->ops->tune_freq(radio->core, &args);
> + break;
> + case SI476X_FUNC_AM_RECEIVER:
> + radio-
st is concerned following criteria should be
> satisfied: 2b, 3, 5, 7, 9, 10
>
>
> Now it is made against git.linuxtv.org/media_tree.git repository
> instead of linux-stable.
>
> I tried to take into account all the flaws pointed by Mark and Hans,
> but since the amount of cha
Note: I'm CC-ing Halli. Halli, can you take a look at the proposed controls?
On Mon 8 October 2012 19:57:17 Andrey Smirnov wrote:
> On 10/08/2012 02:30 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:55:01 Andrey Smirnov wrote:
> >> This commit adds a driver tha
On Mon 8 October 2012 22:06:29 Andrey Smirnov wrote:
> On 10/08/2012 01:56 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:54:59 Andrey Smirnov wrote:
> >> This patch adds all the functions used for exchanging commands with
> >> the chip.
> >>
On Mon 8 October 2012 20:38:01 Andrey Smirnov wrote:
> On 10/08/2012 01:43 AM, Hans Verkuil wrote:
> > On Sat October 6 2012 03:54:57 Andrey Smirnov wrote:
> >> This patch adds all necessary header files and Kbuild plumbing for the
> >> core driver for Silicon Laborato
d, Prabhakar
> Cc: Sakari Ailus
> Cc: Laurent Pinchart
> Cc: Kyungmin Park
> Cc: Guennadi Liakhovetski
> Cc: Sylwester Nawrocki
> Cc: Hans Verkuil
> Cc: Hans de Goede
> Cc: Chris MacGregor
> Cc: Rob Landley
> Cc: Jeongtae Park
> Cc: Mauro Carvalho Chehab
&
se driver
> resources not to be released.
Acked-by: Hans Verkuil
Thanks!
Hans
> This was found using the following semantic patch
> (http://coccinelle.lip6.fr/):
>
>
> @r@
> identifier fops;
> identifier release_func;
> @@
> static const struct v4l2_file_operat
On Thu 6 December 2012 10:54:32 Sakari Ailus wrote:
> Hi Prabhakar and Hans,
>
> On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote:
> > Hi Hans,
> >
> > On Wed, Dec 5, 2012 at 5:38 PM, Hans Verkuil wrote:
> > > (resend without HTML formatting)
&
On Tue 11 December 2012 09:56:42 Hans Verkuil wrote:
> On Thu 6 December 2012 10:54:32 Sakari Ailus wrote:
> > Hi Prabhakar and Hans,
> >
> > On Thu, Dec 06, 2012 at 10:24:18AM +0530, Prabhakar Lad wrote:
> > > Hi Hans,
> > >
> > > On
oid *priv,
>struct v4l2_frmivalenum *fival)
> {
> - struct vivi_fmt *fmt;
> + struct vivi_fmt const *fmt;
Ditto.
>
> if (fival->index)
> return -EINVAL;
> @@ -1330,7 +1330,7 @@ static const struct v4l
On Fri December 28 2012 14:12:56 Kirill Smelkov wrote:
> On Thu, Dec 27, 2012 at 12:55:11PM +0100, Hans Verkuil wrote:
> > On Wed December 26 2012 16:29:43 Kirill Smelkov wrote:
> > > Most of *_ops and other structures in vivi.c were already declared const
> > > but
o create sysfs attributes\n");
> + goto free_kfifo;
> + }
> +
> + if (client->irq) {
> + rval = devm_request_threaded_irq(&client->dev,
> + client->irq, NULL,
> si476x_core_interrupt,
Hi Andrey,
Some more comments...
On Tue October 23 2012 20:44:31 Andrey Smirnov wrote:
> This commit adds a driver that exposes all the radio related
> functionality of the Si476x series of chips via the V4L2 subsystem.
>
> Signed-off-by: Andrey Smirnov
> ---
> drivers/media/radio/Kconfig
On Wed 17 April 2013 14:22:15 Mauro Carvalho Chehab wrote:
> videobuf_queue_dma_contig_init_cached() is not used anywhere.
> Drop support for it, cleaning up the code a little bit.
>
> Signed-off-by: Mauro Carvalho Chehab
Nice!
Acked-by: Hans Verkuil
> ---
> drivers/media/
hree and
> don't
> support the audio device.
Looks great. I've got two remaining issues: replace strncpy with the safer
strlcpy
and a small problem in usbtv_queue_setup.
After fixing that you can add my
Acked-by: Hans Verkuil
to the patch.
Regards,
Hans
>
&
On Thu June 6 2013 12:05:38 Prabhakar Lad wrote:
> Hi Hans,
>
> On Sun, May 26, 2013 at 6:50 AM, Laurent Pinchart
> wrote:
> > On Saturday 25 May 2013 23:09:32 Prabhakar Lad wrote:
> >> From: Lad, Prabhakar
> >>
> >> Trivial cleanup of the driver.
o if the user calls S_STD, then the bridge should always be
certain it gets whatever std was specified.
I'm not sure whether this patch puts the gm7113c in such a mode, but if it
does, then it should be redone.
Regards,
Hans
>
> Signed-off-by: Jon Arne Jørgensen
> ---
&g
tform_data {
> + bool vref_len;
> + bool adc_lsb;
> + enum saa7113_output_format output_format;
> + enum saa7113_horizontal_time_const horizontal_time_const;
> + enum saa7113_rt_signal_cntl rt_signal0;
> + enum saa7113_rt_signal_cntl rt_signal1;
> +};
Pleas
t; >>
> >> Both synchronous and asynchronous tvp514x subdevice probing is supported by
> >> this patch.
> >>
> >> Signed-off-by: Prabhakar Lad
> >> Cc: Guennadi Liakhovetski
> >> Cc: Laurent Pinchart
> >> C
ies have been approved?
Hans
>
> Signed-off-by: Lad, Prabhakar
> Cc: Hans Verkuil
> Cc: Laurent Pinchart
> Cc: Mauro Carvalho Chehab
> Cc: Guennadi Liakhovetski
> Cc: Sylwester Nawrocki
> Cc: Sakari Ailus
> Cc: linux-kernel@vger.kernel.org
> Cc: davinci-lin
Hi Prabhakar,
On Sat June 22 2013 17:03:03 Prabhakar Lad wrote:
> From: "Lad, Prabhakar"
>
> This patch adds video sync properties as part of endpoint
> properties and also support to parse them in the parser.
>
> Signed-off-by: Lad, Prabhakar
> Cc: Hans Verkui
On Mon June 24 2013 10:24:02 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
> > On Sun June 23 2013 17:48:20 Prabhakar Lad wrote:
> >> Hi Guennadi,
> >>
> >> Thanks for the review.
> >>
> >
On Mon June 24 2013 10:53:37 Prabhakar Lad wrote:
> Hi Hans,
>
> On Mon, Jun 24, 2013 at 2:09 PM, Hans Verkuil wrote:
> > On Mon June 24 2013 10:24:02 Prabhakar Lad wrote:
> >> Hi Hans,
> >>
> >> On Mon, Jun 24, 2013 at 12:41 PM, Hans Verkuil wrote:
>
1 - 100 of 3372 matches
Mail list logo
