Re: [PATCH 5/8] gpio: omap: convert gpio irq functions to use GPIO offset

2015-03-20 Thread grygorii.stras...@linaro.org
On 03/20/2015 01:03 AM, Tony Lindgren wrote: * grygorii.stras...@linaro.org [150319 10:26]: From: Grygorii Strashko Convert GPIO IRQ functions to use GPIO offset instead of system GPIO numbers. This allows to drop unneeded conversations between system GPIO <-> GPIO offset which are d

Re: [PATCH 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations

2015-03-20 Thread grygorii.stras...@linaro.org
On 03/20/2015 01:00 AM, Tony Lindgren wrote: > * grygorii.stras...@linaro.org [150319 10:26]: >> From: Grygorii Strashko >> >> Now in TI OMAP GPIO driver there are a lot of places where >> System GPIO number calculated and then converted to GPIO offset. >> Wh

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-03-20 Thread grygorii.stras...@linaro.org
Hi, On 03/18/2015 10:31 PM, Wolfram Sang wrote: > Hi, > > so, the bus recovery patches look fine to me in general. > > It is only this one question left which I always had with bus recovery. > Maybe you guys can join me thinking about it. Ok. Thanks and sorry for delayed reply - missed your e-ma

Re: [RFT OMAP1 PATCH 7/8] gpio: omap: get rid of omap_irq_to_gpio()

2015-03-20 Thread grygorii.stras...@linaro.org
On 03/20/2015 08:56 PM, Javier Martinez Canillas wrote: > Hello Grygorii, > > On Thu, Mar 19, 2015 at 6:25 PM, wrote: >> From: Grygorii Strashko >> >> Now OMAP GPIO driver prepared for omap_irq_to_gpio() removing. >> Do it ;) >> >> Signed-off-by: Grygorii Strashko > > I don't have access to O

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-06 Thread grygorii.stras...@linaro.org
On 04/03/2015 11:18 PM, Wolfram Sang wrote: > >>> The I2C specs say in 3.1.16 that the recovery procedure should be used >>> when SDA is stuck low. So, I do wonder if we should apply the recovery >>> after a timeout. Stuck SDA might be one reason for timeout, but there >>> may be others... >> >> T

Re: [PATCH v3 4/5] i2c: davinci: use bus recovery infrastructure

2015-04-06 Thread grygorii.stras...@linaro.org
On 04/06/2015 07:09 PM, Wolfram Sang wrote: Of course, i2c_davinci_wait_bus_not_busy() has to be fixed first as proposed by Alexander Sverdlin here: https://patchwork.ozlabs.org/patch/448994/. Okay, good that you said it. So I'll give his patch series priority over this one. Sorry, but

Re: [PATCH 2/2] gpio: max732x: Fix irq-events handler

2015-04-22 Thread grygorii.stras...@linaro.org
On 04/21/2015 08:28 PM, Semen Protsenko wrote: > MAX732X doesn't support edge type interrupt. So replace > handle_edge_irq() with handle_level_irq(), which uses > irq_mask/irq_unmask callbacks instead of irq_ack(). > > This wrong handler may lead to NULL pointer dereference in some cases. > E.g. t

Re: [PATCH V2] drivers/rtc/rtc-ds1307.c: Enable the mcp794xx alarm after programming time

2015-04-22 Thread grygorii.stras...@linaro.org
Hi, On 04/21/2015 03:51 AM, Nishanth Menon wrote: > Alarm interrupt enable register is at offset 0x7, while the time > registers for the alarm follow that. When we program Alarm interrupt > enable prior to programming the time, it is possible that previous > time value could be close or match at t

Re: [PATCH V2] drivers/rtc/rtc-ds1307.c: Enable the mcp794xx alarm after programming time

2015-04-23 Thread grygorii.stras...@linaro.org
On 04/23/2015 03:00 AM, Nishanth Menon wrote: > On 04/22/2015 08:26 AM, grygorii.stras...@linaro.org wrote: >> Hi, >> >> On 04/21/2015 03:51 AM, Nishanth Menon wrote: >>> Alarm interrupt enable register is at offset 0x7, while the time >>> registers for the a

Re: [PATCH V2] drivers/rtc/rtc-ds1307.c: Enable the mcp794xx alarm after programming time

2015-04-23 Thread grygorii.stras...@linaro.org
On 04/23/2015 04:11 PM, Nishanth Menon wrote: On 04/23/2015 05:17 AM, grygorii.stras...@linaro.org wrote: On 04/23/2015 03:00 AM, Nishanth Menon wrote: On 04/22/2015 08:26 AM, grygorii.stras...@linaro.org wrote: Hi, On 04/21/2015 03:51 AM, Nishanth Menon wrote: Alarm interrupt enable

Re: [PATCH v4 0/3] i2c: davinci improvements and fixes

2015-04-17 Thread grygorii.stras...@linaro.org
On 04/10/2015 06:59 PM, Wolfram Sang wrote: On Mon, Apr 06, 2015 at 03:38:38PM +0300, grygorii.stras...@linaro.org wrote: From: Grygorii Strashko This series converts driver to use I2C bus recovery infrastructure and adds Davinci I2C bus recovery mechanizm based on using ICPFUNC registers

Re: [RFC v1] clk: Add Suspend/Resume Callbacks in Clock

2015-05-28 Thread grygorii.stras...@linaro.org
On 05/27/2015 02:11 PM, Pankaj Dev wrote: > Currently the CCF doesnt have any interface with the system when it > goes into suspend state. This patch, on similar lines of syscore, > adds clk_suspend/clk_resume functions before system enters suspend state > Also there are suspend/resume hooks added

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-06-02 Thread grygorii.stras...@linaro.org
Hi Linus, On 06/01/2015 04:09 PM, Linus Walleij wrote: On Mon, May 25, 2015 at 8:54 PM, grygorii.stras...@linaro.org wrote: .. Looks like it's time to drop this stuff :,,( Ooops missed this part of the discussion. Indeed it will call accessors on non-requested GPIO lines. Damned. T

Re: [PATCH 00/21] On-demand device registration

2015-06-03 Thread grygorii.stras...@linaro.org
Hi Tomeu, On 05/28/2015 07:33 AM, Rob Herring wrote: > On Mon, May 25, 2015 at 9:53 AM, Tomeu Vizoso > wrote: >> I have a problem with the panel on my Tegra Chromebook taking longer than >> expected to be ready during boot (Stéphane Marchesin reported what is >> basically the same issue in [0]),

Re: [PATCH 00/21] On-demand device registration

2015-06-04 Thread grygorii.stras...@linaro.org
On 06/04/2015 11:39 AM, Tomeu Vizoso wrote: > On 3 June 2015 at 21:57, grygorii.stras...@linaro.org > wrote: >> On 05/28/2015 07:33 AM, Rob Herring wrote: >>> On Mon, May 25, 2015 at 9:53 AM, Tomeu Vizoso >>> wrote: >>>> I have a problem with the panel

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-05-21 Thread grygorii.stras...@linaro.org
On 05/21/2015 05:25 PM, Johan Hovold wrote: > On Tue, May 19, 2015 at 04:28:55PM +0200, Linus Walleij wrote: >> On Mon, May 18, 2015 at 1:02 PM, Johan Hovold wrote: >>> On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.stras...@linaro.org >>> wrote: >> >>&

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-05-25 Thread grygorii.stras...@linaro.org
On 05/24/2015 08:12 PM, Johan Hovold wrote: > On Thu, May 21, 2015 at 11:33:01PM +0300, grygorii.stras...@linaro.org wrote: >> On 05/21/2015 05:25 PM, Johan Hovold wrote: >>> On Tue, May 19, 2015 at 04:28:55PM +0200, Linus Walleij wrote: > >>>> I introduced the gp

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-05-18 Thread grygorii.stras...@linaro.org
Hi Johan, On 05/18/2015 02:02 PM, Johan Hovold wrote: > On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.stras...@linaro.org wrote: >> From: Grygorii Strashko >> >> Now GPIOs, wich are requested as IRQ only, will not be displayed >> through GPIO debugfs. For example:

Re: Calling irq_set_irq_wake() from .set_irq_wake()?

2015-05-18 Thread grygorii.stras...@linaro.org
On 05/18/2015 05:31 PM, Thomas Gleixner wrote: > On Sun, 17 May 2015, Geert Uytterhoeven wrote: > At least the recursive locking message no longer appears after the revert. > > [ 30.591905] PM: Syncing filesystems ... done. > [ 30.623060] Freezing user space processes ... (elaps

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-05-18 Thread grygorii.stras...@linaro.org
On 05/18/2015 06:08 PM, Johan Hovold wrote: > On Mon, May 18, 2015 at 04:06:08PM +0300, grygorii.stras...@linaro.org wrote: >> On 05/18/2015 02:02 PM, Johan Hovold wrote: >>> On Fri, May 15, 2015 at 04:25:21PM +0300, grygorii.stras...@linaro.org >>> wrote: &

Re: [PATCH] gpiolib: debugfs: display gpios requested as irq only

2015-05-19 Thread grygorii.stras...@linaro.org
Hi Linus, On 05/19/2015 05:12 PM, Linus Walleij wrote: > On Mon, May 18, 2015 at 5:17 PM, grygorii.stras...@linaro.org > wrote: >> On 05/18/2015 06:08 PM, Johan Hovold wrote: > >>>GPIOs 160-191, platform/4805d000.gpio, gpio: >>>gpio-171 (

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread grygorii.stras...@linaro.org
Hi Dmitry, On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: > On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: >> On Fri, May 8, 2015 at 7:19 PM, Dmitry Torokhov >> wrote: >>> On Fri, May 08, 2015 at 10:47:43AM +0200, Geert Uytterhoeven wrote: In the final iteration of commit

Re: [PATCH] PM / clock_ops: Fix clock error check in __pm_clk_add()

2015-05-12 Thread grygorii.stras...@linaro.org
On 05/12/2015 07:42 PM, Dmitry Torokhov wrote: > On Tue, May 12, 2015 at 04:55:39PM +0300, grygorii.stras...@linaro.org wrote: >> On 05/09/2015 12:05 AM, Dmitry Torokhov wrote: >>> On Fri, May 08, 2015 at 10:59:04PM +0200, Geert Uytterhoeven wrote: >>>> On Fri,

Re: [PATCH] gpio: pcf875x: Revert "gpio: pcf857x: Propagate wake-up setting to parent irq controller"

2015-05-14 Thread grygorii.stras...@linaro.org
Hi, On 05/11/2015 08:36 PM, Geert Uytterhoeven wrote: > On Mon, May 11, 2015 at 4:13 PM, Roger Quadros wrote: >> commit b80eef95beb0 ('gpio: pcf857x: Propagate wake-up setting to parent irq >> controller') >> introduces the following recursive locking warning while suspending dra7-evm. >> >> The

Re: [PATCH v2] leds: fix hibernation on arm when gpio-led used with CPU led trigger

2015-02-24 Thread grygorii.stras...@linaro.org
Hi Bryan, all, On 02/05/2015 04:37 PM, grygorii.stras...@linaro.org wrote: > From: Grygorii Strashko > > Setting a dev_pm_ops suspend/resume pair of callbacks but not a set of > hibernation callbacks means those pm functions will not be > called upon hibernation - that leads to

Re: ARM: OMPA4+: is it expected dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64)); to fail?

2015-03-10 Thread grygorii.stras...@linaro.org
Hi Russell, On 03/10/2015 01:05 PM, Russell King - ARM Linux wrote: > On Fri, Mar 06, 2015 at 11:47:48PM +0200, grygorii.stras...@linaro.org wrote: >> On 03/05/2015 10:17 PM, Russell King - ARM Linux wrote: >>> On Thu, Mar 05, 2015 at 08:55:07PM +0200, grygorii.stras...@lin

Re: ARM: OMPA4+: is it expected dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64)); to fail?

2015-03-10 Thread grygorii.stras...@linaro.org
Hi Arnd, On 03/09/2015 11:33 PM, Arnd Bergmann wrote: > On Thursday 05 March 2015 20:55:07 grygorii.stras...@linaro.org wrote: >> Hi All, >> >> Now I can see very interesting behavior related to >> dma_coerce_mask_and_coherent() >> and friends which I'd li

Re: [PATCH v2 0/8] gpio: omap: cleanup: get rid of system GPIO <-> GPIO offset converseations

2015-03-27 Thread grygorii.stras...@linaro.org
On 03/23/2015 02:18 PM, grygorii.stras...@linaro.org wrote: From: Grygorii Strashko Now in TI OMAP GPIO driver there are a lot of places where System GPIO number calculated and then converted to GPIO offset. What is worse is that in many place such conversation performed twice or even three

ARM: OMPA4+: is it expected dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64)); to fail?

2015-03-05 Thread grygorii.stras...@linaro.org
Hi All, Now I can see very interesting behavior related to dma_coerce_mask_and_coherent() and friends which I'd like to explain and clarify. Below is set of questions I have (why - I explained below): - Is expected dma_coerce_mask_and_coherent(DMA_BIT_MASK(64)) and friends to fail on 32 bits HW

Re: ARM: OMPA4+: is it expected dma_coerce_mask_and_coherent(dev, DMA_BIT_MASK(64)); to fail?

2015-03-06 Thread grygorii.stras...@linaro.org
Hi Russell, On 03/05/2015 10:17 PM, Russell King - ARM Linux wrote: > On Thu, Mar 05, 2015 at 08:55:07PM +0200, grygorii.stras...@linaro.org wrote: >> Now I can see very interesting behavior related to >> dma_coerce_mask_and_coherent() >> and friends which I'd l

Re: [PATCH v2] leds: fix hibernation on arm when gpio-led used with CPU led trigger

2015-03-18 Thread grygorii.stras...@linaro.org
Hi All, On 02/24/2015 06:12 PM, grygorii.stras...@linaro.org wrote: On 02/05/2015 04:37 PM, grygorii.stras...@linaro.org wrote: From: Grygorii Strashko Setting a dev_pm_ops suspend/resume pair of callbacks but not a set of hibernation callbacks means those pm functions will not be called

Re: [PATCH v3 3/5] i2c: recovery: change input parameter to i2c_adapter for prepare/unprepare_recovery

2015-03-13 Thread grygorii.stras...@linaro.org
Hi Wolfram, On 03/12/2015 01:32 PM, Alexander Sverdlin wrote: > On 01/12/14 16:34, Grygorii Strashko wrote: >> This patch changes type of input parameter for .prepare/unprepare_recovery() >> callbacks from struct i2c_bus_recovery_info * to struct i2c_adapter *. >> This allows to simplify implement