set?
Thanks in advance.
Green
Hello!
In article <[EMAIL PROTECTED]> you wrote:
> > TCP: peer xxx.xxx.1.11:41154/80 shrinks window 2442047470:1072:2442050944.
> > Bad, what else can I say?
> We need desperately to know exactly what OS the xxx.xxx.1.14 machine
> is running. Because you've commented out the first two octets,
.
Should I add a CONFIG_PCMCIA label to the
.config file and enable this config ?
Which file should I trace and modify?
Any reply is appreciated.
Best regards,
Green
I skip /sbin/init program.
Green
From: Oleg Drokin
A couple of memory leaks found by smatch.
Oleg Drokin (2):
drm/qlx: Fix a memory leak on error path
drm: fix a memleak on mutex failure path
drivers/gpu/drm/drm_modeset_lock.c | 4 +++-
drivers/gpu/drm/qxl/qxl_fb.c | 7 +--
2 files changed, 8 insertions(+), 3 de
From: Oleg Drokin
shadow allocation could be leaked if framebuffer allocation failed,
so need to free it.
Also added handling for shadow allocation failure itself instead
of causing a crash.
Found with smatch.
Signed-off-by: Oleg Drokin
---
drivers/gpu/drm/qxl/qxl_fb.c | 7 +--
1 file cha
From: Oleg Drokin
Need to free just allocated ctx allocation if we cannot
get our config mutex.
This one has been flagged by kbuild bot all the way back in August,
but somehow nobody picked it up:
https://lists.01.org/pipermail/kbuild/2014-August/001691.html
Found with smatch.
Signed-off-by: O
From: Oleg Drokin
new_disk_conf could be leaked if the follow on checks fail,
so make sure to free it on error if it was not assigned yet.
Found with smatch.
Signed-off-by: Oleg Drokin
---
I thought about just moving the allocation around so that
there is is no failure path after allocation, b
From: Oleg Drokin
Need to free just allocated ctx allocation if we cannot
get our config mutex.
This one has been flagged by kbuild bot all the way back in August,
but somehow nobody picked it up:
https://lists.01.org/pipermail/kbuild/2014-August/001691.html
In addition there is another failure
From: Oleg Drokin
This helps to avoid use after free on unmount.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_obd.c | 7 ---
1 file changed, 4 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_obd.c
b/drivers/staging/lustre/lustre/lo
From: Oleg Drokin
lustre_dlm_flags.h was autogenerated with a wrong script that
mistakenly stated it is GPLv3 when in fact it should be GPLv2.
Also since we are no longer autogenerating this header, drop
all such mentionings.
Reported by: George G. Davis
Signed-off-by: Oleg Drokin
Intel-bug-
From: Oleg Drokin
Due to a patch naming error this remainder of patches did not merge.
Fixed the commit message to resolve this.
lustresysctl code still stays in place and would be removed in a
separate patch series.
Additionally resolved a merge conflict with some other patch
that touched lproc
From: Oleg Drokin
This code only made sense on servers.
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/include/lprocfs_status.h | 2 -
drivers/staging/lustre/lustre/include/obd.h| 1 -
.../lustre/lustre/obdclass/lprocfs_status.c| 182
From: Dmitry Eremin
Signed-off-by: Dmitry Eremin
---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 3 ---
.../lustre/lustre/obdclass/linux/linux-module.c| 18 --
2 files changed, 21 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/lprocfs_stat
From: Oleg Drokin
Signed-off-by: Dmitry Eremin
---
drivers/staging/lustre/lustre/include/lprocfs_status.h | 12 ++--
drivers/staging/lustre/lustre/obdclass/lprocfs_status.c | 16 +---
2 files changed, 11 insertions(+), 17 deletions(-)
diff --git a/drivers/staging/lustre/lu
From: Oleg Drokin
This moves all remaining procfs handling in llite layer to debugfs.
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/llite/llite_internal.h | 27 +++-
drivers/staging/lustre/lustre/llite/llite_lib.c| 13 +++---
drivers/stagi
From: Oleg Drokin
This nid_stats tracking only makes sense on the server side,
on the client there are no other clients to keep track of anyway.
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/dt_object.h | 1 -
.../staging/lustre/lustre/inc
From: Dmitry Eremin
Signed-off-by: Dmitry Eremin
Signed-off-by: Oleg Drokin
---
.../lustre/include/linux/libcfs/linux/libcfs.h | 1 -
drivers/staging/lustre/lustre/fid/Makefile | 3 +-
drivers/staging/lustre/lustre/fld/Makefile | 3 +-
drivers/staging/lustre/lustre/in
From: Oleg Drokin
The store method defined by LDLM_POOL_SYSFS_WRITER_STORE and
LDLM_POOL_SYSFS_WRITER_NOLOCK_STORE defines should
use size_t count, not unsigned long.
This produced a warning on i386 (and other 32bit architectures too,
I guess) where unsigned long is not 32 bit.
Reported by kbui
From: Oleg Drokin
strncpy_from_user could return negative values on error,
so need to take those into account.
Since ll_getname is used to get a single component name from userspace
to transfer to server as-is, there's no need to allocate 4k buffer
as done by __getname. Allocate NAME_MAX+1 buffer
From: Oleg Drokin
It uses getname in unsafe manner and since it's to deal with corrupted
or inconsistent filesystem, we are probably better to deal with
it from lfsck anyway.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/dir.c | 29 -
1 file cha
From: Oleg Drokin
Some time ago Al Viro noticed that lustre ll_getname is broken.
At the time a patch was submitted to convert lustre to use
exported getname, that was rejected by hch on the grounds that
filesystem code sould not really be reimplementing their own
lookups which kind of made sense
From: Oleg Drokin
It uses getname in unsafe manner and since it's to deal with corrupted
or inconsistent filesystem, we are probably better to deal with
it from lfsck anyway.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_user.h | 1 -
drivers/staging/lustre/lustre
From: Oleg Drokin
Some time ago Al Viro noticed that lustre ll_getname is broken.
At the time a patch was submitted to convert lustre to use
exported getname, that was rejected by hch on the grounds that
filesystem code sould not really be reimplementing their own
lookups which kind of made sense
From: Oleg Drokin
strncpy_from_user could return negative values on error,
so need to take those into account.
Since ll_getname is used to get a single component name from userspace
to transfer to server as-is, there's no need to allocate 4k buffer
as done by __getname. Allocate NAME_MAX+1 buffer
From: Oleg Drokin
cfs_daemonize was removed long ago, but I just stumbled upon
a couple of instances where it was still referenced in the comments,
so here are the patches to clean it up and not cause any unnecessary
confusion.
Oleg Drokin (2):
staging/lustre/ptlrpc: Remove stray daemonize com
From: Oleg Drokin
Ever since daemonize was removed in 3.18, there are no longer
any flags passed to kthread_run.
Most of the comments were deleted, but this one lingered on
until now.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/pinger.c | 2 --
1 file changed, 2 deletio
From: Oleg Drokin
cfs_daemonize is long gone and replaced by a proper call to kthread_run,
so update the comment to reflect that fact.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/s
From: Oleg Drokin
Also while we are at it, drop all cfs_bio_* wrappers.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 3 ---
drivers/staging/lustre/lustre/llite/lloop.c | 4 ++--
2 files changed, 2 insertions(+), 5 deletions(-)
From: Oleg Drokin
SEEK_DATA and SEEK_HOLE are always defined in the kernel,
drop the definition checks
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/linux/lustre_compat25.h | 38 --
1 file changed, 38 deletions(-)
diff --git a/drivers/staging/lustre/lustre/incl
From: Oleg Drokin
Get rid of ll_d_hlist* compat defines.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 9 -
drivers/staging/lustre/lustre/llite/dcache.c | 3 +--
drivers/staging/lustre/lustre/llite/namei.c
From: Oleg Drokin
This replaces cfs_bio_io_error with direct calls to bio_io_error
and cfs_bio_end_io with bio_end_io
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 4
drivers/staging/lustre/lustre/llite/lloop.c | 4 ++--
2
From: Oleg Drokin
These primitives are long deprecated and unused.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/llite/llite_lib.c | 5 +
drivers/staging/lustre/lustre/llite/vvp_io.c
From: Oleg Drokin
ATTR_RAW is unused.
No point in redefining ATTR_OPEN as ATTR_FROM_OPEN
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/linux/lustre_patchless_compat.h| 12
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 2 +-
2 files changed, 1 inser
From: Oleg Drokin
Remove ATTR_TIMES_SET check as it's always present, move
the mask of times define close to where it's used.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
drivers/staging/lustre/lustre/llite/llite_lib.c |
From: Oleg Drokin
They are noop anyways.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/llite/dir.c | 4
2 files changed, 9 deletions(-)
diff --git a/drivers/staging/lustre/lustre/i
From: Oleg Drokin
umode_t is what we need anyway, so replace all users
and drop the define.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
drivers/staging/lustre/lustre/llite/namei.c | 2 +-
2 files changed, 1 insertio
From: Oleg Drokin
queue_max_phys_segments, queue_max_hw_segments and bio_hw_segments
are not used anywhere in the client code, so remove them
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/dr
From: Oleg Drokin
It's not really used anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 4
1 file changed, 4 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/linux/lustre_compat25.h
b/drivers/staging/lustre/lustre/in
From: Oleg Drokin
SLAB_DESTROY_BY_RCU is always defined in kernel slab.h, so
no point in checking for it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 6 --
1 file changed, 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/
From: Oleg Drokin
FS_HAS_FIEMAP was some sort of old RHEL5 construct that's not
really important anymore
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/linux/lustre_compat25.h | 5 -
drivers/staging/lustre/lustre/obdclass/obd_mount.c| 2 +-
2 files changed
From: Oleg Drokin
Lustre defines quite a bit of those compatibility defines
duplicating kernel vfs api, but they are not actually used
in the client so remove them all and also ll_dirty_inode,
ll_security_inode_unlink and cfs_path_put
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/li
From: Oleg Drokin
This patchset is a stroll through lustre/include/linux/lustre_compat25.h
that houses a bunch of our "compatibility with old/new kernels"
code and gettign rid of everything that we know for granted is available
because we are part of the tree.
These are the low hanging fruit, th
From: Oleg Drokin
New writeback changes in 4.2-RC1 have exposed that we incorrectly
set page_writeback on a page that is being written synchronously,
which aside from this new crash (dereference of NULL inode->i_wb
from set_page_writeback) likely threw off some related page
statistics in the past
From: Oleg Drokin
ll_super_blocks became unused quite a while ago with switch
to the new CLIO code.
So this patch removes the list, ll_sb_lock spinlock that guards it
and superblock info ll_list linkage.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/llite_internal.h | 1 -
From: Oleg Drokin
Removed references to ib_reg_phsy_mr() and PMR which was added
to deal with some Chelsio specific scenario, but no longer needed
now.
Signed-off-by: Amir Shehata
Signed-off-by: Oleg Drokin
---
This fixes a build failure in Lustre due to ib_reg_phys_mr being removed.
.../sta
From: James Simmons
The ioctl IOC_LIBCFS_PING_TEST has not been used in
ages. The recent nidstring changes which moved all
the nidstring operations from libcfs to the LNet
layer but this ioctl code was still using an
nidstring operation that was causing a circular
dependency loop between libcfs a
From: Oleg Drokin
They make checkpatch unhappy, and I guess overall might confuse
people too.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/libcfs_mem.c| 7 ---
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 6 --
2 files changed, 8 insertions(+), 5 de
From: Oleg Drokin
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 4 ++--
drivers/staging/lustre/lustre/libcfs/module.c| 4
drivers/staging/lustre/lustr
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also removed some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 +-
drivers/staging/lustre/lustre/libcfs/hash.c| 104 ++-
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/obdecho/echo_client.c| 61 ++
1 file changed, 29 insertions(+), 32 deletions(-)
di
From: Oleg Drokin
Does not appear to be used anywhere.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 10 --
drivers/staging/lustre/lustre/libcfs/tracefile.h | 3 ---
2 files changed, 13 deletions(-)
diff --git a/drivers/stag
From: Oleg Drokin
simple_strtoul is obsolete
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/tracefile.c | 15 +--
1 file changed, 9 insertions(+), 6 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.c
b/drivers/staging/lustre/lustre/lib
From: Oleg Drokin
checkpatch complains that the trailing */ on the multiline comments
should be on it's own line.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 18 +-
drivers/staging/lustre/lustre/libcfs/fail.c| 3 ++-
driv
From: Oleg Drokin
lock_lock_multi_match stayed commented out unused for ages now,
so let's just remove it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_lock.c | 39
1 file changed, 39 deletions(-)
diff --git a/drivers/staging/lustre/lustre/
From: Oleg Drokin
In client_obd_setup references to LUSTRE_OSP_NAME could only
happen on metadata servers, so remove them as never true
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 16
1 file changed, 16 deletions(-)
diff --git a/drivers/stag
From: Oleg Drokin
Majority of this patch is Lustre code style cleanups.
NULL comparison style is adjusted for the whole lustre tree
(but not lnet not to interfere with James patches in flight).
Some server-only code was removed in the process.
lustre/libcfs in addition was processed to remove a
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/acl.c | 10 +--
drivers/staging/lustre/lustre/obdclass/cl_io.c | 83 +---
From: Oleg Drokin
the struct page_collection, struct cfs_trace_page and
struct tracefiled_ctl are only used by tracefile.c, so move them
there.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/tracefile.c | 45 +
drivers/staging/lustre/lustre/libcfs/trace
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c | 14 +++---
drivers/staging/lustre/lustre/fid/lproc_fid.c | 14 ++
2 files changed, 9 insertions(+), 1
From: Oleg Drokin
This is against kernel-code style.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c
b/drivers/staging/lustre/
From: Oleg Drokin
simple_strtoul is obsolete
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/libcfs_string.c | 11 +++
1 file changed, 3 insertions(+), 8 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/libcfs_string.c
b/drivers/staging/lustre/lustre
From: Oleg Drokin
We do really mean to fall through to that default case statement from
all previous ones, so add a comment to unconfuse verious tools
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/drive
From: Oleg Drokin
Replace it with enum cfs_trace_buf_type
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-tracefile.c | 2 +-
drivers/staging/lustre/lustre/libcfs/tracefile.h | 6 +++---
2 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/
From: Oleg Drokin
Return at the end of a void function does not serve any particular
purpose and makes checkpatch unhappy, so eliminate them.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-cpu.c | 2 --
drivers/staging/lustre/lustre/libcfs/linux/linux-cry
From: Oleg Drokin
This pacifies checkpatch amongst other things, also is shorter to write
and avoiding calls to printk_ratelimit() is also good.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/libcfs/linux/linux-tracefile.c | 10 ++--
drivers/staging/lustre/lustre/libcfs/tracefile.c | 53
From: Oleg Drokin
No need for an empty line after opening curvy brace and no need
for an empty line before the closing one too.
Remove them.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-crypto.c| 2 --
drivers/staging/lustre/lustre/libcfs/linux/linux-trac
From: Oleg Drokin
Adjust alignment of argments that were pushed to next lines
to conform to kernel code style.
Found with checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c| 3 +--
drivers/staging/lustre/lustre/libcfs/hash.c | 18 +-
From: Oleg Drokin
Lines that were too long for not good reason were shortened in this patch.
Found with checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 6 --
drivers/staging/lustre/lustre/libcfs/tracefile.c | 6 +++---
drivers/s
From: Oleg Drokin
Found with checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 4 ++--
drivers/staging/lustre/lustre/libcfs/hash.c| 1 -
drivers/staging/lustre/lustre/libcfs/linux/linux-curproc.c | 7 +++
drivers/staging/
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ptlrpc/client.c | 75 +--
drivers/staging/lustre/lustre/ptlrpc/connection.c | 2
From: Oleg Drokin
Problem highlighted by checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/linux/linux-debug.c | 2 +-
drivers/staging/lustre/lustre/libcfs/tracefile.c | 2 +-
drivers/staging/lustre/lustre/libcfs/tracefile.h | 3 +--
drivers/stagin
From: Oleg Drokin
This fixes checkpatch messages about
"spaces preferred around that '-' (ctx:VxV)"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/debug.c | 2 +-
drivers/staging/lustre/lustre/libcfs/linux/linux-mem.c | 2 +-
drivers/staging/lustre/lu
From: Oleg Drokin
Avoid using leading spaces that make checkpatch unhappy.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/libcfs/tracefile.h | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/staging/lustre/lustre/libcfs/tracefile.h
b/drivers/stagi
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/lproc_osc.c | 4 +-
drivers/staging/lustre/lustre/osc/osc_cache.c | 120 ++-
From: Oleg Drokin
Checkpatch highlighted that some of our Lustre files carry this
extra paragraph and indeed it does seem somewhat redundant, so remove it.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/include/linux/lnet/lnetctl.h | 4
drivers/staging/lustre/lnet/klnds/s
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 41 -
1 file changed, 20 insertions(+), 21 deletions(-)
di
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 12 +--
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 47 +-
drivers/
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 6 +--
drivers/staging/lustre/lustre/include/lclient.h| 4 +-
drivers/stag
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
The only exception is ll_update_inode where dropping != NULL
in the construction below would break the logic.
I guess we could change lsm != NULL to !!lsm, but that's uglier.
(lsm != NULL) == ((body->valid
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 32 +++---
1 file changed, 16 insertions(+), 16 deletions(-)
diff --git a/drivers/staging/lustre/lustre
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lmv/lmv_intent.c | 11 +--
drivers/staging/lustre/lustre/lmv/lmv_internal.h | 6 +-
drivers/stagin
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also remove some redundant assertions.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/ldlm/interval_tree.c | 2 -
drivers/staging/lustre/lustre/ldlm/ldlm_extent.c | 9 ++-
drivers/stagi
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fld/fld_cache.c| 10 +++-
drivers/staging/lustre/lustre/fld/fld_internal.h | 2 +-
drivers/staging/lustre/lustre/fld/fld_request.c |
From: Oleg Drokin
All instances of "x == NULL" are changed to "!x" and
"x != NULL" to "x"
Also removed some redundant assertions.
Signed-off-by: Oleg Drokin
---
.../staging/lustre/lustre/lov/lov_cl_internal.h| 6 +--
drivers/staging/lustre/lustre/lov/lov_dev.c| 40
From: Oleg Drokin
class_get_type has some references to various server modules
that could not exist on the server, so get rid of them.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/obdclass/genops.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/drivers/staging/lust
From: Oleg Drokin
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/llite/lproc_llite.c | 2 +-
drivers/staging/lustre/lustre/llite/vvp_io.c | 2 +-
2 files changed, 2 insertions(+), 2 deletions(
From: Oleg Drokin
The complicated version of osc_page_protected and osc_page_is_dlocked
are unsafe and were commented out for ages, so probably no point in
carrying them on.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/osc/osc_page.c | 99
1 file ch
From: Oleg Drokin
All the users seems to have disappeared.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 28
1 file changed, 28 deletions(-)
diff --git a/drivers/staging/lustre/lustre/include/obd.h
b/drivers/staging/lustre/lustre/in
From: Oleg Drokin
This only makes sense on metadata server, so get rid of it.
Also remove now unused MDS_OSC_MAX_RIF_DEFAULT define
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/obd.h | 1 -
drivers/staging/lustre/lustre/ldlm/ldlm_lib.c | 28 +
From: Oleg Drokin
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_pool.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lustre/lov/lov_pool.c
From: Oleg Drokin
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/lustre_dlm.h | 2 +-
drivers/staging/lustre/lustre/include/lustre_net.h | 2 +-
drivers/staging/lustre/lustre/ptlrpc/recover
From: Oleg Drokin
Now that the sysfs conversion is complete, also convert all the
remaining comments
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/include/cl_object.h | 2 +-
drivers/staging/lustre/lustre/include/lprocfs_status.h | 2 +-
drivers/staging/lustre/lustre/incl
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lov/lov_ea.c | 3 +-
drivers/staging/lustre/lustre/lov/lov_internal.h | 6 +-
drivers/staging/lustre/lustre/lo
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mdc/mdc_lib.c | 3 +-
drivers/staging/lustre/lustre/mdc/mdc_locks.c | 87 -
drivers/stag
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lmv/lmv_fld.c| 3 ++-
drivers/staging/lustre/lustre/lmv/lmv_intent.c | 9 ---
drivers/staging/lustre/lustre/
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/mgc/mgc_request.c | 71 -
1 file changed, 46 insertions(+), 25 deletions(-)
diff --git a/drive
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/lclient/glimpse.c| 3 ++-
drivers/staging/lustre/lustre/lclient/lcommon_cl.c | 24 ++
.../sta
From: Oleg Drokin
This patch fixes "Block comments use a trailing */ on a separate line"
warnings from checkpatch.
Signed-off-by: Oleg Drokin
---
drivers/staging/lustre/lustre/fid/fid_request.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/lustre/lus
From: Oleg Drokin
This file mostly contains various on the wire data and got
significantly mangled in transition.
This patch rectifies the situation somewhat. Also fixes the
comment style for block comments.
Signed-off-by: Oleg Drokin
---
.../lustre/lustre/include/lustre/lustre_idl.h | 28
1 - 100 of 1193 matches
Mail list logo
