From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after this commit.
Before this commit:
Console error message near end of unittest:
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a problem discovered while de
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to the live tree
The foll
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after this commit.
Before this commit:
Console e
From: Frank Rowand
Add overlay __symbols__ properties to live tree when an overlay
is added to the live tree so that the symbols are available to
subsequent overlays.
Expected test result is new __symbols__ entries for labels from
the overlay after this commit.
Before this commit:
Console e
From: Frank Rowand
Symbols in a loaded overlay are not currently available to subsequently
loaded overlays because the properties in the overlay's __symbols__
node are not loaded into the live device tree.
Patch 1 is unittests to test patches 2 and 3.
Patch 2 fixes a problem discovered while de
From: Frank Rowand
Add nodes and properties to overlay_base and overlay dts files to
test for
- incorrect existing node name detection when overlay node name
has a unit-address
- adding overlay __symbols__ properties to live tree when an
overlay is added to the live tree
The foll
From: Frank Rowand
Correct existing node name detection when overlay node name has
a unit-address.
Expected test result is overlay will update the nodes and properties
for /testcase-data-2/fairway-1/ride@100/ after this commit.
Before this commit:
Console error message near end of unittest:
From: Frank Rowand
Update the cpp include flags for compiling device tree dts files
to match the changes made to the kernel build process in
commit d5d332d3f7e8 ("devicetree: Move include prefixes from arch
to separate directory").
Cc: # 4.12
Signed-off-by: Frank Rowand
---
scripts/dtc/dtx_di
From: Frank Rowand
Device tree is impacted by changes to fwnode.h, add a file entry
to OPEN FIRMWARE AND FLATTENED DEVICE TREE
Signed-off-by: Frank Rowand
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index c0ac362e850a..cb58c20b1ef8 100644
--- a
From: Frank Rowand
Rafael, can you please take patch 1?
Rob, can you please take patch 2?
Several maintainers are impacted by changes to fwnode.h, add a
file entry for those maintainers.
Frank Rowand (2):
MAINTAINERS: device property: acpi: add fwnode.h
MAINTAINERS: device property: of: ad
From: Frank Rowand
ACPI is impacted by changes to fwnode.h, add a file entry
to ACPI
Signed-off-by: Frank Rowand
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINERS b/MAINTAINERS
index 205d3977ac46..c0ac362e850a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -302,6 +
From: Frank Rowand
Documentation/process/submitting-patches.rst contains a non-ascii
character. Change it to the ascii equivalent.
Signed-off-by: Frank Rowand
---
Documentation/process/submitting-patches.rst | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/Documentation/pro
From: Frank Rowand
The initial implementation of the of_find_node_by_phandle() cache
allocates the cache using kcalloc(). Add an early boot allocation
of the cache so it will be usable during early boot. Switch over
to the kcalloc() based cache once normal memory allocation
becomes available.
From: Frank Rowand
Create a cache of the nodes that contain a phandle property. Use this
cache to find the node for a given phandle value instead of scanning
the devicetree to find the node. If the phandle value is not found
in the cache, of_find_node_by_phandle() will fall back to the tree
sca
From: Frank Rowand
The unittest-data overlays have been pulled into proper overlay
devicetree source files without changing their format. The
next step is to convert them to use sugar syntax instead of
hand coding overlay fragments structure.
A few of the overlays can not be converted because t
From: Frank Rowand
Move duplicating and unflattening of an overlay flattened devicetree
(FDT) into the overlay application code. To accomplish this,
of_overlay_apply() is replaced by of_overlay_fdt_apply().
The copy of the FDT (aka "duplicate FDT") now belongs to devicetree
code, which is thus
From: Frank Rowand
Signed-off-by: Frank Rowand
---
Documentation/devicetree/overlay-notes.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/overlay-notes.txt
b/Documentation/devicetree/overlay-notes.txt
index c4aa0adf13ec..5175a24d387e 100644
From: Frank Rowand
Move duplicating and unflattening of an overlay flattened devicetree
(FDT) into the overlay application code. To accomplish this,
of_overlay_apply() is replaced by of_overlay_fdt_apply().
The copy of the FDT (aka "duplicate FDT") now belongs to devicetree
code, which is thus
From: Frank Rowand
Errors while developing the patch to create of_overlay_fdt_apply()
exposed inadequate error messages to debug problems when overlay
devicetree fragment nodes contain an invalid target path. Improve
the messages in find_target_node() to remedy this.
Signed-off-by: Frank Rowand
From: Frank Rowand
Create a cache of the nodes that contain a phandle property. Use this
cache to find the node for a given phandle value instead of scanning
the devicetree to find the node. If the phandle value is not found
in the cache, of_find_node_by_phandle() will fall back to the tree
sca
From: Frank Rowand
Move duplicating and unflattening of an overlay flattened devicetree
(FDT) into the overlay application code. To accomplish this,
of_overlay_apply() is replaced by of_overlay_fdt_apply().
The copy of the FDT (aka "duplicate FDT") now belongs to devicetree
code, which is thus
From: Frank Rowand
Signed-off-by: Frank Rowand
---
Changes from v1:
- new patch
Documentation/devicetree/overlay-notes.txt | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/Documentation/devicetree/overlay-notes.txt
b/Documentation/devicetree/overlay-notes.txt
index c
From: Frank Rowand
The unittest-data overlays have been pulled into proper overlay
devicetree source files without changing their format. The
next step is to convert them to use sugar syntax instead of
hand coding overlay fragments structure.
A few of the overlays can not be converted because t
From: Frank Rowand
Move duplicating and unflattening of an overlay flattened devicetree
(FDT) into the overlay application code. To accomplish this,
of_overlay_apply() is replaced by of_overlay_fdt_apply().
The copy of the FDT (aka "duplicate FDT") now belongs to devicetree
code, which is thus
From: Frank Rowand
Errors while developing the patch to create of_overlay_fdt_apply()
exposed inadequate error messages to debug problems when overlay
devicetree fragment nodes contain an invalid target path. Improve
the messages in find_target_node() to remedy this.
Signed-off-by: Frank Rowand
From: Frank Rowand
struct device_node full_name has been changed to include the
basename instead of the full path. kbasename() is no longer
needed to extract the basename from full_name.
Signed-off-by: Frank Rowand
---
drivers/of/base.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-
From: Frank Rowand
Struct device_node full_name no longer includes the full path
name.
Fix some broken overlay code that was not updated to reflect this.
Clean up the unittest changeset test that calls into this
overlay code.
kbasename(->full_name) is no longer needed, so remove kbasename()
fr
From: Frank Rowand
struct device_node full_name has been changed to include the
basename instead of the full path. kbasename() is no longer
needed to extract the basename from full_name.
Signed-off-by: Frank Rowand
---
drivers/of/of_reserved_mem.c | 4 +---
1 file changed, 1 insertion(+), 3 d
From: Frank Rowand
Struct device_node full_name no longer includes the full path
name. The overlay node creation code was not modified to
reflect this change. Fix the node names generate by overlay
code to contain only the basename.
Unittests call an overlay internal function to create new nod
From: Frank Rowand
struct device_node full_name has been changed to include the
basename instead of the full path. kbasename() is no longer
needed to extract the basename from full_name.
Signed-off-by: Frank Rowand
---
drivers/of/platform.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-
From: Frank Rowand
In preparation for fixing __of_node_dup(), clean up the unittest
function that calls it.
Devicetree nodes created from a flattened device tree have a name
property. Follow this convention for nodes added by a changeset.
For node added by changeset, remove incorrect initializ
From: Frank Rowand
struct device_node full_name has been changed to include the
basename instead of the full path. kbasename() is no longer
needed to extract the basename from full_name.
Signed-off-by: Frank Rowand
---
drivers/of/kobj.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
d
From: Frank Rowand
kbuild test robot reported a new warning for a recent patch:
>> drivers/of/overlay.c:832:2: error: implicit declaration of function
>> 'of_fdt_unflatten_tree' [-Werror=implicit-function-declaration]
of_fdt_unflatten_tree(new_fdt, NULL, &overlay_root);
The cause is that t
From: Frank Rowand
(One line description of patch 0/2 is now misleading, but leaving
intact to make it easier to find v1. One line description of other
patches updated as they will be part of the git commit record.)
Struct device_node full_name no longer includes the full path
name.
Fix some b
From: Frank Rowand
In preparation for fixing __of_node_dup(), clean up the unittest
function that calls it.
Devicetree nodes created from a flattened device tree have a name
property. Follow this convention for nodes added by a changeset.
For node added by changeset, remove incorrect initializ
From: Frank Rowand
Struct device_node full_name no longer includes the full path name
when the devicetree is created from a flattened device tree (FDT).
The overlay node creation code was not modified to reflect this
change. Fix the node full_name generated by overlay code to contain
only the ba
From: Frank Rowand
Update dtx_diff include paths in the same manner as:
commit b12869a8d519 ("of: remove drivers/of/testcase-data from
include search path for CPP"), commit 5ffa2aed389c ("of: remove
arch/$(SRCARCH)/boot/dts from include search path for CPP"), and
commit 50f9ddaf64e1 ("of: search
From: Frank Rowand
Update dtx_diff include paths in the same manner as:
commit b12869a8d519 ("of: remove drivers/of/testcase-data from
include search path for CPP"), commit 5ffa2aed389c ("of: remove
arch/$(SRCARCH)/boot/dts from include search path for CPP"), and
commit 50f9ddaf64e1 ("of: search
From: Frank Rowand
Update dtx_diff include paths in the same manner as:
commit b12869a8d519 ("of: remove drivers/of/testcase-data from
include search path for CPP"), commit 5ffa2aed389c ("of: remove
arch/$(SRCARCH)/boot/dts from include search path for CPP"), and
commit 50f9ddaf64e1 ("of: search
From: Frank Rowand
The Devicetree Specification has superseded the ePAPR as the
base specification for bindings. Update files in Documentation
to reference the new document.
First reference to ePAPR in Documentation/devicetree/bindings/arm/cci.txt
is generic, remove it.
Some files are not upda
From: Frank Rowand
Fix boot warning 'Trying to vfree() nonexistent vm area'
from arch_timer_mem_of_init().
Refactored code attempts to read and iounmap using address frame
instead of address ioremap(frame->cntbase).
Fixes: c389d701dfb70 ("clocksource: arm_arch_timer: split MMIO timer probing.")
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to const void
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
---
drivers/of/base.c | 2 +-
1 file cha
From: Frank Rowand
Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
the internal device tree. The phandle will still be in the struct
device_node phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup of
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 4
1 file changed, 4 in
From: Frank Rowand
sysfs-firmware-ofw describes the /sys/firmware/devicetree/ hierarchy
and /proc/device-tree so add a file line for it to the entry
OPEN FIRMWARE AND FLATTENED DEVICE TREE
Signed-off-by: Frank Rowand
---
MAINTAINERS | 1 +
1 file changed, 1 insertion(+)
diff --git a/MAINTAINE
From: Frank Rowand
The Devicetree Specification has superseded the ePAPR as the
base specification for bindings. Update files in Documentation
to reference the new document.
Some files are not updated because there is no hypervisor chapter
in the Devicetree Specification:
Documentation/devic
From: Frank Rowand
Add ABI documentation for /sys/firmware/fdt
Update contact for /sys/firmware/devicetree/* to include mail list
Signed-off-by: Frank Rowand
---
Documentation/ABI/testing/sysfs-firmware-ofw | 27 ++-
1 file changed, 26 insertions(+), 1 deletion(-)
dif
From: Frank Rowand
An undeclared variable was used in a macro that evaluates to nothing
when CONFIG_DEBUG_LOCK_ALLOC is not defined. Change to use the correct
variable that does exist.
---
reported by kbuild test robot on on robh/for-next
https://lkml.org/lkml/2017/4/29/134
drivers/of/b
From: Frank Rowand
Remove "phandle" and "linux,phandle" properties from the internal
device tree. The phandle will still be in the struct device_node
phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void * to const void
From: Frank Rowand
Overlays are not allowed to modify phandle values of previously existing
nodes because there is no information available to allow fixup up
properties that use the previously existing phandle.
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 4
1 file changed, 4 in
From: Frank Rowand
checkpatch whined about using S_IRUGO instead of octal equivalent
when adding phandle sysfs code, so used octal in that patch.
Change other instances of the S_* constants in the same file to
the octal form.
Signed-off-by: Frank Rowand
---
drivers/of/base.c | 2 +-
1 file cha
From: Frank Rowand
Remove "phandle", "linux,phandle", and "ibm,phandle" properties from
the internal device tree. The phandle will still be in the struct
device_node phandle field.
This is to resolve the issue found by Stephen Boyd [1] when he changed
the type of struct property.value from void
From: Frank Rowand
__of_attach_node() is not used outside of drivers/of/dynamic.c. Make
it static and remove it from drivers/of/of_private.h.
Signed-off-by: Frank Rowand
---
drivers/of/dynamic.c| 2 +-
drivers/of/of_private.h | 1 -
2 files changed, 1 insertion(+), 2 deletions(-)
diff --
From: Frank Rowand
Move more code into of_overlay_apply() so that it does not have
to be duplicated by each caller of of_overlay_apply().
The test in of_resolve_phandles() that the overlay tree is detached is
temporarily disabled so that old style overlay unittests do not fail.
Signed-off-by: F
From: Frank Rowand
Continue improving the readability of overlay.c. The previous patches
renamed identifiers. This patch is split out from the previous patches
to make the previous patches easier to review.
Changes are:
- minor code restructuring
- some initialization of an overlay changes
From: Frank Rowand
The process of applying an overlay consists of:
- unflatten an overlay FDT (flattened device tree) into an
EDT (expanded device tree)
- fixup the phandle values in the overlay EDT to fit in a
range above the phandle values in the live device tree
- create the over
From: Frank Rowand
kbasename() will not return NULL if passed a valid string. If
the parameter passed to kbasename() in this case is already NULL
then the devicetree has been corrupted.
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/d
From: Frank Rowand
The code to apply symbols from an overlay to the live device tree
was implemented with the intent to be minimally intrusive on the
existing code. After recent restructuring of the overlay apply
code, it is easier to disintangle the code that applies the
symbols, and to make th
From: Frank Rowand
The "%pOF" printf format was recently added to print the
full name of a device tree node, with the intent of changing
the node full_name field to contain only the node name instead
of the full path of the node.
dup_and_fixup_symbol_prop() duplicates a property from the
"/__sym
From: Frank Rowand
Use normal shorthand for comparing a variable to zero.
For variable "XXX":
convert (XXX == 0) to (!XXX)
convert (XXX != 0) to (XXX)
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 36 ++--
1 file changed, 18 insertions(+), 18 dele
From: Frank Rowand
When an overlay contains a node that already exists in
the live device tree, the overlay node is not allowed
to change the phandle of the existing node.
The existing check refused to allow an overlay node to
set the node phandle even when the existing node did
not have a phand
From: Frank Rowand
The test of whether it is safe to remove an overlay changeset
looked at whether any node in the overlay changeset was in a
subtree rooted at any more recently applied overlay changeset
node.
The test failed to determine whether any node in the overlay
changeset was the root of
From: Frank Rowand
When an attempt to apply an overlay changeset fails, an effort
is made to revert any partial application of the changeset.
When an attempt to remove an overlay changeset fails, an effort
is made to re-apply any partial reversion of the changeset.
The existing code does not che
From: Frank Rowand
More renaming of identifiers to better reflect what they do.
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 24 ++--
1 file changed, 18 insertions(+), 6 deletions(-)
diff --git a/drivers/of/overlay.c b/drivers/of/overlay.c
index 397ef10d1f26..c35
From: Frank Rowand
I have found the device tree overlay code to be difficult to read and
maintain. This patch series attempts to improve that situation.
The cleanup includes some changes visible to users of overlays. The
only in kernel user of overlays is fixed up for those changes. The
in ke
From: Frank Rowand
This patch is aimed primarily at drivers/of/overlay.c, but those
changes also have a small impact in a few other files.
overlay.c is difficult to read and maintain. Improve readability:
- Rename functions, types and variables to better reflect what
they do and to be con
From: Frank Rowand
Follows recommendations in Documentation/process/coding-style.rst,
section 8, Commenting.
Some in function comments are promoted to function header comments.
Signed-off-by: Frank Rowand
---
drivers/of/overlay.c | 53
1 fi
From: Frank Rowand
Make pr_fmt() in fdt.c consistent with all other files in drivers/of/
Signed-off-by: Frank Rowand
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index c89d5d231a0e..9f98e437e1f1 100644
--- a/driver
From: Frank Rowand
of_device_make_bus_id() was changed to non-static by commit c66012253800
("of/device: Make of_device_make_bus_id() usable by other code") more than
6 years ago, but there are no users of it outside of platform.c. Make the
function static again.
Signed-off-by: Frank Rowand
--
From: Frank Rowand
of_device_make_bus_id() was changed to non-static by commit c66012253800
("of/device: Make of_device_make_bus_id() usable by other code") more than
6 years ago, but there are no users of it outside of platform.c. Make the
function static again.
Signed-off-by: Frank Rowand
--
From: Frank Rowand
Make pr_fmt() in fdt.c consistent with all other files in drivers/of/
Signed-off-by: Frank Rowand
---
drivers/of/fdt.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/of/fdt.c b/drivers/of/fdt.c
index c89d5d231a0e..9f98e437e1f1 100644
--- a/driver
201 - 274 of 274 matches
Mail list logo
