[PATCH] tracing: initialize variable in create_dyn_event()

2019-01-24 Thread frowand . list
From: Frank Rowand Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized]. Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework") Signed-off-by: Frank Rowand --- Compile and boot tested only. Please verify the initializatio

[PATCH v2] tracing: initialize variable in create_dyn_event()

2019-03-21 Thread frowand . list
From: Frank Rowand Fix compile warning in create_dyn_event(): 'ret' may be used uninitialized in this function [-Wuninitialized]. Fixes: 5448d44c3855 ("tracing: Add unified dynamic event framework") Signed-off-by: Frank Rowand --- changes since v1: - initialize to -ENODEV instead of 0, as s

[PATCH] ARM: qcom_defconfig: Enable MAILBOX

2018-09-06 Thread frowand . list
From: Frank Rowand Problem: ab460a2e72da ("rpmsg: qcom_smd: Access APCS through mailbox framework" added a "depends on MAILBOX") to RPMSG_QCOM_SMD, thus RPMSG_QCOM_SMD becomes unset since MAILBOX was not enabled in qcom_defconfig and is not otherwise selected for the dragonboard. When the result

[PATCH 4/6] ARM: dts: qcom-msm8974: use named constant for interrupt flag LEVEL HIGH

2018-09-06 Thread frowand . list
From: Frank Rowand Cosmetic change of integer value "4" in the third field of the "interrupts" property to the correct named constant. Signed-off-by: Frank Rowand --- arch/arm/boot/dts/qcom-msm8974.dtsi | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/a

[PATCH 6/6] ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value

2018-09-06 Thread frowand . list
From: Frank Rowand Change the third field of the "interrupts" property from IRQ_TYPE_NONE to the correct value. I do not have hardware documentation for these devices, so I followed a mail list suggestion to copy the flag values from the same type of node in arch/arm64/boot/dts/qcom/msm8916.dtsi

[PATCH 2/6] ARM: dts: qcom-msm8974: use named constant for interrupt type GIC_SPI

2018-09-06 Thread frowand . list
From: Frank Rowand Cosmetic change of integer value "0" in the first field of the "interrupts" property to the correct named constant. Signed-off-by: Frank Rowand --- arch/arm/boot/dts/qcom-msm8974.dtsi | 56 +++-- 1 file changed, 29 insertions(+), 27 deletions(

[PATCH 1/6] ARM: dts: qcom-msm8974: use named constant for interrupt type GIC_PPI

2018-09-06 Thread frowand . list
From: Frank Rowand Cosmetic change of integer value "1" in the first field of the "interrupts" property to the correct named constant. Signed-off-by: Frank Rowand --- arch/arm/boot/dts/qcom-msm8974.dtsi | 12 ++-- 1 file changed, 6 insertions(+), 6 deletions(-) diff --git a/arch/arm/b

[PATCH 0/6] ARM: dts: qcom-msm8974: change invalid flag IRQ NONE to valid value

2018-09-06 Thread frowand . list
From: Frank Rowand A boot time warning of devicetree interrupts types set to the invalid value of none was added by 83a86fbb5b56 ("irqchip/gic: Loudly complain about the use of IRQ_TYPE_NONE"). This patch series fixes the devicetree source to replace IRQ_TYPE_NONE with the appropriate value. So

[PATCH 5/6] ARM: dts: qcom-msm8974: use named constant for interrupt flag NONE

2018-09-06 Thread frowand . list
From: Frank Rowand Cosmetic change of integer value "0" in the third field of the "interrupts" property to the correct named constant. Signed-off-by: Frank Rowand --- arch/arm/boot/dts/qcom-msm8974.dtsi | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/arch/a

[PATCH 3/6] ARM: dts: qcom-msm8974: use named constant for interrupt flag EDGE RISING

2018-09-06 Thread frowand . list
From: Frank Rowand Cosmetic change of integer value "1" in the third field of the "interrupts" property to the correct named constant. Signed-off-by: Frank Rowand --- arch/arm/boot/dts/qcom-msm8974.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/arch/arm/boot/dts/qcom-

[PATCH v6 2/4] of: Documentation: of_overlay_apply() replaced by of_overlay_fdt_apply()

2018-03-02 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- Documentation/devicetree/overlay-notes.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/overlay-notes.txt b/Documentation/devicetree/overlay-notes.txt index c4aa0adf13ec..5175a24d387e 100644

[PATCH v6 1/4] of: change overlay apply input data from unflattened to FDT

2018-03-02 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH v6 0/4] of: change overlay apply input data from unflattened

2018-03-02 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH v6 3/4] of: convert unittest overlay devicetree source to sugar syntax

2018-03-02 Thread frowand . list
From: Frank Rowand The unittest-data overlays have been pulled into proper overlay devicetree source files without changing their format. The next step is to convert them to use sugar syntax instead of hand coding overlay fragments structure. A few of the overlays can not be converted because t

[PATCH v6 4/4] of: improve reporting invalid overlay target path

2018-03-02 Thread frowand . list
From: Frank Rowand Errors while developing the patch to create of_overlay_fdt_apply() exposed inadequate error messages to debug problems when overlay devicetree fragment nodes contain an invalid target path. Improve the messages in find_target_node() to remedy this. Signed-off-by: Frank Rowand

[PATCH] x86: devicetree: fix config option around x86_flattree_get_config()

2018-03-02 Thread frowand . list
From: Frank Rowand x86_flattree_get_config() is incorrectly protected by ifdef CONFIG_OF_FLATTREE. It uses of_get_flat_dt_size(), which only exists if CONFIG_OF_EARLY_FLATTREE. This issue has not been exposed previously because OF_FLATTREE did not occur unless it was selected by OF_EARLY_FLATTR

[PATCH v7 5/5] of: improve reporting invalid overlay target path

2018-03-03 Thread frowand . list
From: Frank Rowand Errors while developing the patch to create of_overlay_fdt_apply() exposed inadequate error messages to debug problems when overlay devicetree fragment nodes contain an invalid target path. Improve the messages in find_target_node() to remedy this. Signed-off-by: Frank Rowand

[PATCH v7 0/5] of: change overlay apply input data from unflattened

2018-03-03 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH v7 4/5] of: convert unittest overlay devicetree source to sugar syntax

2018-03-03 Thread frowand . list
From: Frank Rowand The unittest-data overlays have been pulled into proper overlay devicetree source files without changing their format. The next step is to convert them to use sugar syntax instead of hand coding overlay fragments structure. A few of the overlays can not be converted because t

[PATCH v7 1/5] x86: devicetree: fix config option around x86_flattree_get_config()

2018-03-03 Thread frowand . list
From: Frank Rowand x86_flattree_get_config() is incorrectly protected by ifdef CONFIG_OF_FLATTREE. It uses of_get_flat_dt_size(), which only exists if CONFIG_OF_EARLY_FLATTREE. This issue has not been exposed previously because OF_FLATTREE did not occur unless it was selected by OF_EARLY_FLATTR

[PATCH v7 3/5] of: Documentation: of_overlay_apply() replaced by of_overlay_fdt_apply()

2018-03-03 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- Documentation/devicetree/overlay-notes.txt | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/Documentation/devicetree/overlay-notes.txt b/Documentation/devicetree/overlay-notes.txt index c4aa0adf13ec..5175a24d387e 100644

[PATCH v7 2/5] of: change overlay apply input data from unflattened to FDT

2018-03-03 Thread frowand . list
From: Frank Rowand Move duplicating and unflattening of an overlay flattened devicetree (FDT) into the overlay application code. To accomplish this, of_overlay_apply() is replaced by of_overlay_fdt_apply(). The copy of the FDT (aka "duplicate FDT") now belongs to devicetree code, which is thus

[PATCH v5 0/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

2018-03-04 Thread frowand . list
From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree sca

[PATCH v5 3/3] of: add early boot allocation of of_find_node_by_phandle() cache

2018-03-04 Thread frowand . list
From: Frank Rowand The initial implementation of the of_find_node_by_phandle() cache allocates the cache using kcalloc(). Add an early boot allocation of the cache so it will be usable during early boot. Switch over to the kcalloc() based cache once normal memory allocation becomes available.

[PATCH v5 1/3] of: cache phandle nodes to reduce cost of of_find_node_by_phandle()

2018-03-04 Thread frowand . list
From: Frank Rowand Create a cache of the nodes that contain a phandle property. Use this cache to find the node for a given phandle value instead of scanning the devicetree to find the node. If the phandle value is not found in the cache, of_find_node_by_phandle() will fall back to the tree sca

[PATCH v5 2/3] memblock: add memblock_free() alloc when CONFIG_HAVE_MEMBLOCK is not set

2018-03-04 Thread frowand . list
From: Frank Rowand When CONFIG_HAVE_MEMBLOCK is not set, an error version of memblock_alloc() exists. Add the matching memblock_free(). Signed-off-by: Frank Rowand --- Andrew or Michal, can you please ack this patch to be accepted by Rob? With "of: add early boot allocation of of_find_node_

[RFC PATCH 0/1] Portable Device Tree Connector -- conceptual

2016-07-02 Thread frowand . list
From: Frank Rowand Hi All, This is version 2 of this email. Changes from version 1: - some rewording of the text - removed new (theoretical) dtc directive "/connector/" - added compatibility between mother board and daughter board - added info on applying a single .dtbo to different co

[RFC PATCH 1/1] device tree connectors, using plugs and sockets.

2016-07-02 Thread frowand . list
From: Frank Rowand This patch has been compiled but has not been booted. It is likely to contain bugs. Problem: mother boards may contain multiple connectors that daughter boards may be attached to. If two of the daughter boards can be described by the same .dtsi file, then it should be possib

[PATCH 00/12] of: Make drivers/of/resolver.c more readable

2016-10-28 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a functional change are: Remove

[PATCH 09/12] of: Update comments to reflect changes and increase clarity

2016-10-28 Thread frowand . list
From: Frank Rowand Update comments to better explain what functions are doing. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 66 --- 1 file changed, 47 insertions(+), 19 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/reso

[PATCH 06/12] of: Rename variables to better reflect purpose or follow convention

2016-10-28 Thread frowand . list
From: Frank Rowand Rename variables to better reflect what their purpose is. As a side effect, this reduces the need for some of the comments previously removed in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 172 +- 1 fi

[PATCH 05/12] of: Remove prefix "__of_" from local function names

2016-10-28 Thread frowand . list
From: Frank Rowand Remove "__of_" prefix from local function names. The pattern of a leading "__" is used in drivers/of/ to signify a function that must be called with a lock held. These functions do not fit that pattern. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 10 +-

[PATCH 12/12] of: Remove unused variable overlay_symbols

2016-10-28 Thread frowand . list
From: Frank Rowand Remove unused pointer to node "__symbols__". Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 53353cc8f2bb..783bd09463b5 100644 --- a/drivers/of/r

[PATCH 02/12] of: Remove excessive printks to reduce clutter.

2016-10-28 Thread frowand . list
From: Frank Rowand Remove extra debug and error printks. A single pr_err() will be added at the end of this series to replace many of these error messages. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 53 --- 1 file changed, 8 inserti

[PATCH 01/12] of: Remove comments that state the obvious, to reduce clutter

2016-10-28 Thread frowand . list
From: Frank Rowand Remove comments that report what is obvious from the code. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 46325d639

[PATCH 07/12] of: Update structure of code to be clearer, also remove BUG_ON()

2016-10-28 Thread frowand . list
From: Frank Rowand Remove BUG_ON(), which is frowned upon and not needed here. Restructure to remove some excessive complexity. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 48 +--- 1 file changed, 17 insertions(+), 31 deletions(-) diff -

[PATCH 04/12] of: Rename functions to more accurately reflect what they do

2016-10-28 Thread frowand . list
From: Frank Rowand Some function names are misleading or do not provide a good sense of what they do. Rename the functions to ne more informative. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a

[PATCH 03/12] of: Convert comparisons to zero or NULL to logical expressions

2016-10-28 Thread frowand . list
From: Frank Rowand Convert comparisons to zero or NULL to logical expressions. A small number of such comparisons remain where they provide more clarity of the numeric nature of a variable. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 42 --

[PATCH 08/12] of: Remove redundant size check

2016-10-28 Thread frowand . list
From: Frank Rowand Remove a redundant check of buffer size. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 --- a/drivers/of/resolver.

[PATCH 11/12] of: Move setting of pointer to beside test for non-null

2016-10-28 Thread frowand . list
From: Frank Rowand Value of pointer was calculated in an earlier block than where it was used. Move it down into the block where it is used, immediately before where is is checked to be valid. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 3 +-- 1 file changed, 1 insertion(+), 2 del

[PATCH 10/12] of: Add back an error message, restructured

2016-10-28 Thread frowand . list
From: Frank Rowand Add a single pr_err() to cover a range of errors that were reported by several pr_err() that were removed earlier in this series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/dri

[RFC PATCH 12/13] of: Move setting of pointer to beside test for non-null

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 664c97e1ecb4..3f7cf569c7ea 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -305,8

[RFC PATCH 13/13] of: Remove unused variable overlay_symbols

2016-10-25 Thread frowand . list
From: Frank Rowand This unused variable is a reminder that symbols in overlays are not available to subsequent overlays. If such a feature is desired then there are several ways it could be implemented. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 5 + 1 file changed, 1 inserti

[RFC PATCH 04/13] of: Convert comparisons to zero or NULL to simplify logical expressions

2016-10-25 Thread frowand . list
From: Frank Rowand A small number of such comparisons remain where they provide more clarity of the numeric nature of a variable. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 42 -- 1 file changed, 20 insertions(+), 22 deletions(-) diff --git

[RFC PATCH 06/13] of: Remove prefix "__of_" and prefix "__" from local function names

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 3d123b612789..0ce38aa0ed3c 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @

[RFC PATCH 11/13] of: Add back an error message, restructured

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 18 -- 1 file changed, 12 insertions(+), 6 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4e6df385118b..664c97e1ecb4 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/res

[RFC PATCH 10/13] of: Update comments to reflect changes and increase clarity

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 51 --- 1 file changed, 32 insertions(+), 19 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 76c09cb57eae..4e6df385118b 100644 --- a/drivers/

[RFC PATCH 07/13] of: Rename variables to better reflect purpose or follow convention

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 172 +- 1 file changed, 85 insertions(+), 87 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 0ce38aa0ed3c..0778747cdd58 100644 --- a/drivers/

[RFC PATCH 08/13] of: Update structure of code, remove BUG_ON()

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 48 +--- 1 file changed, 17 insertions(+), 31 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 0778747cdd58..708daca1d522 100644 --- a/drivers/of/

[RFC PATCH 01/13] of: Remove comments that state the obvious

2016-10-25 Thread frowand . list
From: Frank Rowand Remove comments that state the obvious, to reduce clutter Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 31 ++- 1 file changed, 2 insertions(+), 29 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 46325d6394

[RFC PATCH 05/13] of: Rename functions to more accurately reflect what they do

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 22 +++--- 1 file changed, 11 insertions(+), 11 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 31fd3800787a..3d123b612789 100644 --- a/drivers/of/resolver.c +++ b/drivers/o

[RFC PATCH 09/13] of: Remove redundant size check

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 708daca1d522..76c09cb57eae 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c @@ -216,7 +2

[RFC PATCH 02/13] of: Remove excessive printks to reduce clutter

2016-10-25 Thread frowand . list
From: Frank Rowand Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 28 1 file changed, 28 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 4ff0220d7aa2..93a7ca0bf98c 100644 --- a/drivers/of/resolver.c +++ b/drivers/of/resolver.c

[RFC PATCH 03/13] of: Remove braces around single line blocks.

2016-10-25 Thread frowand . list
From: Frank Rowand The single line blocks were created by previous patches in the series. Signed-off-by: Frank Rowand --- drivers/of/resolver.c | 25 - 1 file changed, 8 insertions(+), 17 deletions(-) diff --git a/drivers/of/resolver.c b/drivers/of/resolver.c index 93a

[RFC PATCH 00/13] of: Make drivers/of/resolver.c more readable

2016-10-25 Thread frowand . list
From: Frank Rowand drivers/of/resolve.c is a bit difficult to read. Clean it up so that review of future overlay related patches will be easier. Most of the patches are intended to be reformatting, with no functional change. Patches that are expected to have a functional change are: Remove

[PATCH 3/4] of: be consistent in form of file mode

2017-04-14 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file cha

[PATCH 0/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void

[PATCH 2/4] of: make __of_attach_node() static

2017-04-14 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH 4/4] of: detect invalid phandle in overlay

2017-04-14 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH 1/4] of: remove *phandle properties from expanded device tree

2017-04-14 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void

[PATCH v3 2/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH v3 1/2] of: support dtc compiler flags for overlays

2017-04-25 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib b/

[PATCH v3 0/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v2: - of_private.h: move __unflatten_device_tree() outside #ifdef CONFIG_OF_UNITTEST - unittest.c: move overlay decl

[PATCH v4 2/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH v4 1/2] of: per-file dtc compiler flags

2017-04-25 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set an additional dtc compiler flag is needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Mak

[PATCH v4 0/2] of: Add unit tests for applying overlays

2017-04-25 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v3: - make subject line of patch 1 more generic Changes from v2: - of_private.h: move __unflatten_device_tree() outside

[PATCH] of: unittest, fix possible use of unitialized variable

2017-04-27 Thread frowand . list
From: Frank Rowand Fix problem reported in the linux-next build. last_sibling may be unitialized in of_unittest() if the device tree is empty. Signed-off-by: Frank Rowand --- drivers/of/unittest.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/of/unittest.c b/driv

[PATCH] of: change fixup of dma-ranges size to error

2017-04-05 Thread frowand . list
From: Frank Rowand of_dma_get_range() has workaround code to fixup a device tree that incorrectly specified a mask instead of a size for property dma-ranges. That device tree was fixed a year ago in v4.6, so the workaround is no longer needed. Leave a data validation check in place, but no long

[PATCH 0/3] of: fix overlay modification of const variable

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void *. As a result

[PATCH 1/3] of: overlay_adjust_phandles() - do not modify const field

2017-04-23 Thread frowand . list
From: Frank Rowand When adjusting overlay phandles to apply to the live device tree, can not modify the property value because it is type const. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void *. As a result of t

[PATCH 2/3] of: make __of_attach_node() static

2017-04-23 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH 3/3] of: detect invalid phandle in overlay

2017-04-23 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up of properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4

[PATCH 2/2] of: Add unit tests for applying overlays.

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH 1/2] of: add support of dtc compiler flags for device tree overlays

2017-04-23 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib b/

[PATCH 0/2] of: Add unit tests for applying overlays

2017-04-23 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Frank Rowand (2): of: add support of dtc compiler flags for device tree overlays of: Add unit tests for applying overlays. drivers/

[PATCH v2 0/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Changes from v1: - Move overlay base dtb unflattening into unittest.c. Call from fdt.c. - Clarify file and variable names, 'overlay_

[PATCH v2 2/2] of: Add unit tests for applying overlays

2017-04-24 Thread frowand . list
From: Frank Rowand Existing overlay unit tests examine individual pieces of the overlay code. The new tests target the entire process of applying an overlay. Signed-off-by: Frank Rowand --- There are checkpatch warnings. I have reviewed them and feel they can be ignored. drivers/of/fdt.c

[PATCH v2 1/2] of: support dtc compiler flags for overlays

2017-04-24 Thread frowand . list
From: Frank Rowand The dtc compiler version that adds initial support was available in 4.11-rc1. Add the ability to set the dtc compiler flags needed by overlays. Signed-off-by: Frank Rowand --- scripts/Makefile.lib | 2 ++ 1 file changed, 2 insertions(+) diff --git a/scripts/Makefile.lib b/

[PATCH v2 3/4] of: be consistent in form of file mode

2017-04-24 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file cha

[PATCH v2 2/4] of: make __of_attach_node() static

2017-04-24 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH v2 0/4] of: remove *phandle properties from expanded device tree

2017-04-24 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void

[PATCH v2 1/4] of: remove *phandle properties from expanded device tree

2017-04-24 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void

[PATCH v2 4/4] of: detect invalid phandle in overlay

2017-04-24 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH v3 1/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle", "linux,phandle", and "ibm,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void

[PATCH v3 0/4] of: remove *phandle properties from expanded device tree

2017-04-25 Thread frowand . list
From: Frank Rowand Remove "phandle" and "linux,phandle" properties from the internal device tree. The phandle will still be in the struct device_node phandle field. This is to resolve the issue found by Stephen Boyd [1] when he changed the type of struct property.value from void * to const void

[PATCH v3 3/4] of: be consistent in form of file mode

2017-04-25 Thread frowand . list
From: Frank Rowand checkpatch whined about using S_IRUGO instead of octal equivalent when adding phandle sysfs code, so used octal in that patch. Change other instances of the S_* constants in the same file to the octal form. Signed-off-by: Frank Rowand --- drivers/of/base.c | 2 +- 1 file cha

[PATCH v3 2/4] of: make __of_attach_node() static

2017-04-25 Thread frowand . list
From: Frank Rowand __of_attach_node() is not used outside of drivers/of/dynamic.c. Make it static and remove it from drivers/of/of_private.h. Signed-off-by: Frank Rowand --- drivers/of/dynamic.c| 2 +- drivers/of/of_private.h | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --

[PATCH v3 4/4] of: detect invalid phandle in overlay

2017-04-25 Thread frowand . list
From: Frank Rowand Overlays are not allowed to modify phandle values of previously existing nodes because there is no information available to allow fixup up properties that use the previously existing phandle. Signed-off-by: Frank Rowand --- drivers/of/overlay.c | 4 1 file changed, 4 in

[PATCH v2] of: document /sys/firmware/fdt

2017-06-28 Thread frowand . list
From: Frank Rowand Add ABI documentation for /sys/firmware/fdt Change obsolete contact for /sys/firmware/devicetree/* to mail list Signed-off-by: Frank Rowand --- changes from v1: - Remove obsolete email address as contact for /sys/firmware/devicetree/* - For newly documented /sys/firmwar

[PATCH v3] of: document /sys/firmware/fdt

2017-06-28 Thread frowand . list
From: Frank Rowand Add ABI documentation for /sys/firmware/fdt Update contact email for /sys/firmware/devicetree/* and add mail list Signed-off-by: Frank Rowand --- changes from v2: - ignore v2, v3 is based on v1 changes from v1: - updated Grant's email address - updated Frank's email

[PATCH 0/3] of: overlay: load overlay symbols into live device tree

2017-07-07 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-07 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after the patch is applied. Before this patch is applied: Console error message ne

[PATCH 3/3] of: overlay: add overlay symbols to live device tree

2017-07-07 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after the patch is applied. Before this patch is app

[PATCH 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-07 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree Expected

[PATCH v2 2/3] of: overlay: correctly apply overlay node with unit-address

2017-07-10 Thread frowand . list
From: Frank Rowand Correct existing node name detection when overlay node name has a unit-address. Expected test result is overlay will update the nodes and properties for /testcase-data-2/fairway-1/ride@100/ after the patch is applied. Before this patch is applied: Console error message ne

[PATCH v2 0/3] of: overlay: load overlay symbols into live device tree

2017-07-10 Thread frowand . list
From: Frank Rowand Symbols in a loaded overlay are not currently available to subsequently loaded overlays because the properties in the overlay's __symbols__ node are not loaded into the live device tree. Patch 1 is unittests to test patches 2 and 3. Patch 2 fixes a problem discovered while de

[PATCH v2 1/3] of: overlay: add overlay unittest data for node names and symbols

2017-07-10 Thread frowand . list
From: Frank Rowand Add nodes and properties to overlay_base and overlay dts files to test for - incorrect existing node name detection when overlay node name has a unit-address - adding overlay __symbols__ properties to live tree when an overlay is added to the live tree Expected

[PATCH v2 3/3] of: overlay: add overlay symbols to live device tree

2017-07-10 Thread frowand . list
From: Frank Rowand Add overlay __symbols__ properties to live tree when an overlay is added to the live tree so that the symbols are available to subsequent overlays. Expected test result is new __symbols__ entries for labels from the overlay after the patch is applied. Before this patch is app

[PATCH] usb: chipidea: msm: ci_hdrc_msm_probe() missing of_node_get()

2017-07-18 Thread frowand . list
From: Frank Rowand Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: OF: ERROR: Bad of_node_put() on /soc/usb@f9a55000 The error will occur if the configuration is set to: CONFIG_OF_OVERLAY y CONFIG_OF_UNITTEST y CONFIG_OF_DYNAMIC y CONFIG_OF_RESOLVE y If CONFIG_OF_DYN

[PATCH] regulator: of: regulator_of_get_init_data() missing of_node_get()

2017-07-18 Thread frowand . list
From: Frank Rowand Boot fails for qcom-apq8074-dragonboard on 4.13-rc1 with error: OF: ERROR: Bad of_node_put() on /soc/spmi@fc4cf000/pm8941@1/regulators The error will occur if the configuration is set to: CONFIG_OF_OVERLAY y CONFIG_OF_UNITTEST y CONFIG_OF_DYNAMIC y CONFIG_OF_RESOLV

<    1   2   3   >