I've noticed that my Linux boxes take quite a hit in terms of
packets per second rate when I define ipchains rules with
2.2.X kernels. Does the netfilter replacement found in 2.4
kernels improve this performance?
11101101 (Ed)
-
To unsubscribe from this list: send the line "unsubsc
Does anyone remember the reason why SCSI drives were limited to
15 partitions?
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
Please read the FAQ at http://www.tux.org/lkml/
First, I wrote your attached patch, but then I thought zeroing other
/proc/iomem values would be better. So I changed it.
Most distros don't use KASLR, but they use kptr_restrict. Without KASLR,
kptr_restirct most likely useless. As you said these things should be
done long ago
Emra
On Nov 28, 2012, at 6:42 PM, Andrew Morton wrote:
> On Wed, 21 Nov 2012 19:52:41 -0500
> Ed Cashin wrote:
>
>> This patch series applies to today's linux-next/akpm, commit
>> d3faae60d84f586ff8937b77c8476bca1b5f8ec6.
>>
>> Ed L. Cashin (8):
>&g
f the patch that puts bi_sector/bi_size/bi_idx
> into a struct bvec_iter.
>
> Signed-off-by: Kent Overstreet
> CC: Jens Axboe
> CC: "Ed L. Cashin"
> CC: Nick Piggin
> CC: Jiri Kosina
> CC: Jim Paris
> CC: Geoff Levand
> CC: Alasdair Kergon
> CC:
ith a minimal
and progressive first patchset.
Ed L. Cashin (14):
aoe: for performance support larger packet payloads
aoe: kernel thread handles I/O completions for simple locking
aoe: become I/O request queue handler for increased user control
aoe: use a kernel thread for transmissions
aoe
place, transmits always linearize sg AoE
packets, but in-kernel users did not have this patch. Before 2.6.38,
though, these changes were working to allow sg to increase
performance.
1. http://www.spinics.net/lists/linux-mm/msg15184.html
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|
AC address
becoming unusable.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h | 33 ++-
drivers/block/aoe/aoechr.c |3 +-
drivers/block/aoe/aoecmd.c | 729 ---
drivers/block/aoe/aoedev.c | 84 +++--
drivers/block/aoe/aoemain.c |8 +-
dri
hasn't finished yet and cap the resources we
use with a "pool" of skbs.[2]
Now that the block layer maintains the disk stats, the aoe driver's
diskstats function can go away.
1. https://lkml.org/lkml/2007/3/1/374
2. https://lkml.org/lkml/2007/7/6/241
Signed-off-by: Ed Cashin
The dev_queue_xmit function needs to have interrupts enabled, so the
most simple way to get the locking right but still fulfill that
requirement is to use a process that can call dev_queue_xmit serially
over queued transmissions.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|2
MTU of all those local interfaces greatly
simplifies the driver, especially in failure scenarios.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|7 +-
drivers/block/aoe/aoecmd.c | 151
2 files changed, 87 insertions(+), 71 deletions
et" in the driver
code and comments means a {major, minor, MAC address} tuple, as in
"somewhere to send packets".
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|1 -
drivers/block/aoe/aoecmd.c |8 +++-
2 files changed, 3 insertions(+), 6 deletions(-)
diff --git
to go out first, reflecting the
normal discovery sequence. The responses could come back in any
order, so this change is fairly cosmetic.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoechr.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoechr.c
prevents unexpected targets from being used by the
driver when AoE targets with high minor numbers are on the AoE
network.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |7 +++
1 files changed, 7 insertions(+), 0 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers
AC address becomes unusable.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|8 +++---
drivers/block/aoe/aoecmd.c | 65 +++-
drivers/block/aoe/aoedev.c | 30 +++-
3 files changed, 49 insertions(+), 54 deletions(-)
diff --git
This change eliminates the danger that the user could rmmod the driver
for a network interface that is being used for AoE by the aoe driver.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |4
drivers/block/aoe/aoedev.c |7 +++
2 files changed, 11 insertions(+), 0
This change removes some unused code and attempts to increase code
consistency.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h| 10 +++---
drivers/block/aoe/aoechr.c |1 +
drivers/block/aoe/aoecmd.c | 13 -
drivers/block/aoe/aoenet.c |3 ++-
4 files changed
coraid.com website, it is a
form of version 49.
1. http://aoetools.sourceforge.net/
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index eb41fc5..32aede9 100644
--- a
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
drivers/block/aoe/aoeblk.c |2 +-
drivers/block/aoe/aoechr.c |2 +-
drivers/block/aoe/aoecmd.c |2 +-
drivers/block/aoe/aoedev.c |2 +-
drivers/block/aoe/aoemain.c |2 +-
drivers/block/aoe/aoenet.c
The old area has a new URL. Also, now that the driver can perform
better, it is worth mentioning the VM settings that help aoe to sink
dirty pages out early, avoiding unecessary memory pressure when much
I/O is going on.
Signed-off-by: Ed Cashin
---
Documentation/aoe/aoe.txt |9
There's a patch in the mm tree that already makes this change, thanks.
Sent from my iPhone
On Sep 12, 2012, at 5:08 AM, "Peter Senna Tschudin"
wrote:
> From: Peter Senna Tschudin
>
> Remove useless kfree() and clean up code related to the removal.
>
> The semantic patch that finds this prob
users commonly
use slot numbers much greater than that.
The AoE shelf and slot address space is often used sparsely.
Instead of using a static mapping between AoE addresses and the
block device minor number, the block device minor numbers are now
allocated on demand.
Signed-off-by: Ed Cashin
The old mapping between AoE target shelf and slot addresses and
the block device minor number is retained as a
backwards-compatible feature, with a new "aoe_dyndevs" module
parameter available for enabling dynamic block device minor
numbers.
Signed-off-by: Ed Cashin
---
drivers
In general, specific is better when it comes to messages about
AoE usage problems. Also, explicit checks for the AoE broadcast
addresses are added.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|2 --
drivers/block/aoe/aoecmd.c | 17 +++--
2 files changed, 11
minor number in sysfs and the
minor number in a special device file.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoedev.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index 3d494fd..90e5b53 100644
--- a/drivers
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |4
1 files changed, 0 insertions(+), 4 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 4ae2468..c2bf797 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -10,9 +10,6 @@
#define
Signed-off-by: Ed Cashin
---
Documentation/aoe/aoe.txt| 49 +++--
Documentation/aoe/mkdevs.sh | 41 ---
Documentation/aoe/mkshelf.sh | 28
Documentation/aoe/status.sh |3 ++
4 files
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index c2bf797..d2ed7f1 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -1,5 +1,5 @@
/* Copyright
I should have mentioned that these seven patches were made for linux-next/akpm,
which contains the last 14-patch series for aoe.
On Oct 1, 2012, at 9:59 PM, "Ed Cashin" wrote:
> The ATA over Ethernet protocol uses a major (shelf) and
> minor (slot) address to identify a pa
expect them to read
the git logs, and I wanted to leave a paper trail there for anyone reading
later.
--
Ed Cashin
ecas...@coraid.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo inf
27;re returning an error.
Yes. The only caller of aoedev.c:minor_get() handles that correctly. Again,
just let me know if you think this is worth a resubmission of the patch.
Otherwise I'll just make a note to myself to try to avoid setting output
parameters on error in the fut
The current text of SubmittingPatches recommends asking permission
before using "Reported-By:" even when the report was made to a
public forum. This patch updates the text to better reflect the
current convention of including the tag when the report was public.
Signed-off-by:
On Oct 24, 2012, at 10:36 AM, Jonathan Corbet wrote:
> On Wed, 24 Oct 2012 10:22:02 -0400
> Ed Cashin wrote:
>
>> +contribution. Please note that this tag should not be added without
>> +the reporter's permission unless the problem was reported in a public
&g
After calling dev_queue_xmit it is no longer safe to access the
members of the skb.
Reported-by: Dan Carpenter
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoenet.c |4 +++-
1 files changed, 3 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe
On Oct 25, 2012, at 2:33 AM, Dan Carpenter wrote:
> On Wed, Oct 24, 2012 at 03:08:07PM -0700, Andrew Morton wrote:
>> On Wed, 24 Oct 2012 14:26:13 -0400
>> Ed Cashin wrote:
>>
>>> After calling dev_queue_xmit it is no longer safe to access the
>>> member
On Sep 24, 2012, at 6:34 PM, Kent Overstreet wrote:
> Bunch of places in the code weren't using it where they could be -
> this'll reduce the size of the patch that puts bi_sector/bi_size/bi_idx
> into a struct bvec_iter.
The aoe changes look fine to me, thanks.
--
struct aoetgt *t;
> ^
Looks good, thanks.
--
Ed Cashin
ecas...@coraid.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.ht
If the system has trouble allocating memory for the creation of the
aoe debugfs directory or of a file inside it, the debugfs member of
an aoedev can be NULL.
Do not treat a NULL debugfs pointer as a BUG on aoedev shutdown,
avoiding the user impact of an unecessary panic.
Signed-off-by: Ed
This patch series applies to linux-next/akpm fetched 22 August, commit
a187db44dd9b24a9eed2141af962306a36935423. Yesterday's linux-next/akpm
has no updates to the aoe files that could conflict, though.
Ed L. Cashin (2):
aoe: do not BUG if memory pressure prevented debugfs file creation
/etc/udev/rules.d/60-aoe.rules:26
Removing the term does not cause any problems with the creation
of the special character and block device nodes.
Signed-off-by: Ed Cashin
---
Documentation/aoe/udev.txt |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/Documentation/aoe/
Looks OK to me, thanks.
On Sep 7, 2012, at 11:59 PM, "Dan Carpenter" wrote:
> We changed this recently so we can just use kzalloc() here instead of
> kcalloc(1, ...). Kernel style prefers sizeof(*t) over sizeof *t. The
> kfree(t) is a no-op now as well so that can be removed.
>
> Signed-off-b
rief mention in
Documentation/sparse.txt of the relationship between the
sparse "context" feature and the locking annotations like
__acquires and __must_hold would be a nice addition.
I can take a stab at it if folks agree.
--
Ed Cashin
ecas...@coraid.com
--
To unsubscribe fr
This patch series applies to today's linux-next/akpm, commit
a5944abc848a1b8e5329a631a84e35a3b0249ecb.
Ed L. Cashin (7):
aoe: improve handling of misbehaving network paths
aoe: avoid races between device destruction and discovery
aoe: use dynamic number of remote ports for AoE st
es,
then the path is "redeemed", and its taint is removed.
This mechanism has been shown to be helpful in transparently
handling and recovering from real-world network "brown outs" in
ways that the earlier "shoot the help-needing target in the head"
mechanism could not.
or a bad aoedev pointer remains from a time when about
half of this patch was done, and it was possible for the
bdev->bd_disk->private_data to become corrupted. The check
should be removed eventually, but it is not expected to add
significant overhead, occurring in the aoeblk_open routin
many AoE targets with fewer
than eight MAC addresses each.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|6 ++--
drivers/block/aoe/aoeblk.c |2 +-
drivers/block/aoe/aoecmd.c | 50 ++-
drivers/block/aoe/aoedev.c | 12 -
4
marks the aoe
device as "down" and fails all I/O.
The new meaning of an aoe_deadsecs of zero is for the driver to
retransmit commands indefinitely.
Signed-off-by: Ed Cashin
---
Documentation/aoe/aoe.txt |4 +++-
drivers/block/aoe/aoecmd.c |4 +++-
2 files changed, 6 insert
,
modprobe aoe aoe_iflist=eth2,eth3
Before, it was inconvenient to get the quoting right in shell
scripts when setting aoe_iflist to have more than one network
interface.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|2 +-
drivers/block/aoe/aoenet.c |2 +-
2 files changed, 2
This change only affects experimental AoE storage networks.
It modifies the console message about runt packets detected so
that the AoE major and minor addresses of the AoE target that
generated the runt are mentioned.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c | 10
This version number is printed to the console on module
initialization and is available in sysfs, which is where the
userland aoe-version tool looks for it.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers
Change since first submission:
Go ahead and use the __must_hold() annotation provided
recently by Josh Triplett, already in mm.
This patch series is based on linux-next/akpm from 11 Oct.
Ed L. Cashin (9):
aoe: describe the behavior of the "err" character device
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoechr.c |5 +
1 files changed, 5 insertions(+), 0 deletions(-)
diff --git a/drivers/block/aoe/aoechr.c b/drivers/block/aoe/aoechr.c
index ed57a89..2bf6273 100644
--- a/drivers/block/aoe/aoechr.c
+++ b/drivers/block/aoe/aoechr.c
@@ -39,6
Dropped transmits are not common, but when they do occur, increasing
the transmit queue length often helps.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoenet.c |7 +--
1 files changed, 5 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoenet.c b/drivers/block/aoe
as increased or decreased, respectively.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|6 +++---
drivers/block/aoe/aoecmd.c |6 +-
2 files changed, 8 insertions(+), 4 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index d2ed7f1..52f75c0 10064
ned-off-by: Ed Cashin
---
drivers/block/aoe/aoedev.c | 44 ++--
1 files changed, 38 insertions(+), 6 deletions(-)
diff --git a/drivers/block/aoe/aoedev.c b/drivers/block/aoe/aoedev.c
index 90e5b53..63b2660 100644
--- a/drivers/block/aoe/aoedev.c
+++ b/dri
The GPFS filesystem is an example of an aoe user that requires the
aoe driver to support I/O request sizes larger than the default.
Most users will not need large I/O request sizes, because they would
need to be split up into multiple AoE commands anyway.
Signed-off-by: Ed Cashin
---
drivers
The userland aoetools package includes an "aoe-stat" command that
can display a "payload size" column when the aoe driver exports
this information. Users can quickly see what amount of user data
is transferred inside each AoE command on the network, network
headers excluded
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c | 10 --
1 files changed, 0 insertions(+), 10 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 2bb8c7d..82e16c4 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
drivers/block/aoe/aoechr.c |2 +-
drivers/block/aoe/aoecmd.c |6 +++---
drivers/block/aoe/aoemain.c |2 +-
drivers/block/aoe/aoenet.c |4 ++--
5 files changed, 8 insertions(+), 8 deletions(-)
diff --git a
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 8e8da1c..536942b 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -1,5 +1,5 @@
/* Copyright
The context feature of sparse is used with the Linux kernel
sources to check for imbalanced uses of locks. Document the
annotations defined in include/linux/compiler.h that tell sparse
what to expect when a lock is held on function entry, exit, or
both.
Signed-off-by: Ed Cashin
0,7 +439,6 @@ resend(struct aoedev *d, struct frame *f)
> return;
> }
> h = (struct aoe_hdr *) skb_mac_header(skb);
> - ah = (struct aoe_atahdr *) (h+1);
>
> snprintf(buf, sizeof buf,
> "%15s e%ld.%d oldtag=%08x@%08lx newta
On Dec 4, 2012, at 6:39 PM, Andrew Morton wrote:
> On Mon, 3 Dec 2012 20:40:55 -0500
> Ed Cashin wrote:
...
>> +static void
>> +ata_rw_frameinit(struct frame *f)
>> +{
>> +struct aoetgt *t;
>> +struct aoe_hdr *h;
>> +struct aoe_atahdr *ah;
On Dec 4, 2012, at 6:45 PM, Andrew Morton wrote:
> On Mon, 3 Dec 2012 20:42:56 -0500
> Ed Cashin wrote:
>
>> This change avoids a race that could result in a NULL pointer
>> derference following a WARNing from kobject_add_internal, "don't
>> try to register
+ d = NULL;
> goto out;
> }
> d->ntargets = NTARGETS;
That looks good, thanks.
If smatch found that, then I have to figure out what I'm doing wrong, because
I ran sparse and smatch on the latest patch series until they were clean. :/
--
Ed Cashin
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index c491fba..3ce01f6 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -925,7
This patch makes the aoe driver follow expected behavior when
the user uses ioctl to get the ATA device identify information.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|1 +
drivers/block/aoe/aoeblk.c | 30 ++
drivers/block/aoe/aoecmd.c | 16
he failover
case when AoE commands being retransmitted are transferred from
one retransmit queue to another.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h| 16 +++--
drivers/block/aoe/aoecmd.c | 173 +++-
drivers/block/aoe/aoedev.c |6
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index f849fa2..6ea27fd 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index 6ea27fd..9aefbe3 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -603,14
ce is
relatively large.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|9 ---
drivers/block/aoe/aoecmd.c | 57 ++-
2 files changed, 55 insertions(+), 11 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 9e
e for
retransmits that need to be done are updated to use the new
destination, so that retransmits will be sent through a working
network path.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|1 +
drivers/block/aoe/aoecmd.c | 75 +++-
dr
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index c253cca..9655ce3 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -1,5 +1,6
On Nov 8, 2012, at 2:26 PM, Andrew Morton wrote:
> On Thu, 8 Nov 2012 11:29:32 -0500
> Ed Cashin wrote:
>
>> Signed-off-by: Ed Cashin
>
> Could you please prepare decent changelogs for the patches? Several of
> these appear to be bugfixes but we have no descripti
This patch series is based on linux-next/akpm from 8 Nov, commit
db3846344ad57222.
Ed L. Cashin (8):
aoe: avoid running request handler on plugged queue
aoe: provide ATA identify device content to user on request
aoe: improve network congestion handling
aoe: err device: include MAC
e.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoecmd.c
index c491fba..3ce01f6 100644
--- a/drivers/block/aoe/aoecmd.c
+++ b/drivers/block/aoe/aoecmd.c
@@ -92
This patch makes the aoe driver follow expected behavior when the
user uses ioctl to get the ATA device identify information,
allowing access to model, serial number, etc.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|1 +
drivers/block/aoe/aoeblk.c | 30
he failover
case when AoE commands being retransmitted are transferred from
one retransmit queue to another. Another upcoming patch
increases the timing accuracy.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h| 16 +++--
drivers/block/aoe/aoecmd.c | 173 +++-
unexpected
responses, so that when they occur, it's more easy to determine
the network paths to which they belong.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |6 --
1 files changed, 4 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe
n would be calculated.
Without this change, the effect of the bug would be rare
unecessary but benign retransmissions.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c |4 ++--
1 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block/aoe/aoec
ce is
relatively large. Otherwise the AoE targets could be considered
failed inappropriately.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|9 ---
drivers/block/aoe/aoecmd.c | 57 ++-
2 files changed, 55 insertions(+), 11 deletions(-)
arget failure before there's time
for the retransmit timer to run again, decide to retransmit
again, and finally update the destination to a working MAC
address on the AoE target.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|1 +
drivers/block/aoe/aoecm
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index c253cca..9655ce3 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -1,5 +1,6
On Nov 8, 2012, at 7:40 PM, Jeff Garzik wrote:
> On 11/08/2012 11:32 AM, Ed Cashin wrote:
>> This patch makes the aoe driver follow expected behavior when
>> the user uses ioctl to get the ATA device identify information.
>>
>> Signed-off-by: Ed Cashin
>>
st_del+0x81/0x90
[] percpu_counter_destroy+0x28/0x50
[] bdi_destroy+0xf9/0x150
[] blk_release_queue+0x60/0x80
[] kobject_release+0x8d/0x240
[] ? kobject_release+0x0/0x240
[] kref_put+0x37/0x70
[] kobject_put+0x27/0x60
[] blk_cleanup_queue+0x57/0x70
[] aoedev_freedev+0x125/0x140 [aoe]
[] aoedev_exit+0x6d/0
On Jan 3, 2013, at 9:12 AM, Jens Axboe wrote:
> On 2013-01-03 15:09, Jens Axboe wrote:
>> On 2013-01-03 15:02, Ed Cashin wrote:
>>> On Jan 3, 2013, at 8:25 AM, Josh Boyer wrote:
>>>
>>>> Hello,
>>>>
>>>> We have a user that has re
On Jan 3, 2013, at 10:34 AM, Jens Axboe wrote:
> On 2013-01-03 16:28, Ed Cashin wrote:
>> On Jan 3, 2013, at 9:12 AM, Jens Axboe wrote:
>>
>>> On 2013-01-03 15:09, Jens Axboe wrote:
>>>> On 2013-01-03 15:02, Ed Cashin wrote:
>>>>> On Jan 3, 2013
Lines: 75
On Thu, Jan 03, 2013 at 12:15:35PM -0600, Ed Cashin wrote:
...
> >>>>> On Jan 3, 2013, at 8:25 AM, Josh Boyer wrote:
...
> >>>>>> [699170.611997] aoe: AoE v47 initialised.
...
> >>>>>> [699231.308319] WARNING:
On Jan 3, 2013, at 2:45 PM, Jens Axboe wrote:
> On 2013-01-03 20:28, Ed Cashin wrote:
>> Lines: 75
>>
>> On Thu, Jan 03, 2013 at 12:15:35PM -0600, Ed Cashin wrote:
>> ...
>>>>>>>> On Jan 3, 2013, at 8:25 AM, Josh Boyer wrote:
>&g
On Jan 3, 2013, at 2:57 PM, Ed Cashin wrote:
> On Jan 3, 2013, at 2:45 PM, Jens Axboe wrote:
>
>> On 2013-01-03 20:28, Ed Cashin wrote:
>>> Lines: 75
>>>
>>> On Thu, Jan 03, 2013 at 12:15:35PM -0600, Ed Cashin wrote:
>>> ...
>&g
On Jan 3, 2013, at 3:50 PM, Ed Cashin wrote:
> On Jan 3, 2013, at 2:57 PM, Ed Cashin wrote:
>
>> On Jan 3, 2013, at 2:45 PM, Jens Axboe wrote:
>>
>>> On 2013-01-03 20:28, Ed Cashin wrote:
>>>> Lines: 75
>>>>
>>>> On Thu, Jan 03, 20
e from-in-changelog trick, thanks.
--
Ed Cashin
ecas...@coraid.com
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h |2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
index 2284f89..025c41d 100644
--- a/drivers/block/aoe/aoe.h
+++ b/drivers/block/aoe/aoe.h
@@ -1,5 +1,5 @@
/* Copyright
This patch series applies to today's linux-next/akpm, commit
cbbc4a736dfca9a1ade0b13219d98d12601c1c06.
This second submission includes a comment in the first patch
suggested by Andrew Morton.
Ed L. Cashin (3):
aoe: perform I/O completions in parallel
aoe: update copyright date
aoe: u
roughly doubles, for example, with these changes in place.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|7 ++-
drivers/block/aoe/aoecmd.c | 152
drivers/block/aoe/aoedev.c |1 -
drivers/block/aoe/aoenet.c |5 +-
4 files changed
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoe.h|2 +-
drivers/block/aoe/aoecmd.c |2 +-
drivers/block/aoe/aoedev.c |2 +-
drivers/block/aoe/aoenet.c |2 +-
4 files changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/block/aoe/aoe.h b/drivers/block/aoe/aoe.h
street wrote:
> Now that we've got a mechanism for immutable biovecs -
> bi_iter.bi_bvec_done - we need to convert drivers to use primitives that
> respect it instead of using the bvec array directly.
>
> Signed-off-by: Kent Overstreet
> Cc: Jens Axboe
> Cc: NeilBr
char *p;
> size_t lim;
>
> if (!d->gd)
> return 0;
> - p = strrchr(d->gd->disk_name, '/');
> - if (!p)
> - p = d->gd->disk_name;
> - else
> - p += 1;
> + p = kbasename(d->gd->
if (!d->gd)
> return 0;
> p = kbasename(d->gd->disk_name);
> - lim = sizeof(d->gd->disk_name);
> - lim -= p - d->gd->disk_name;
> - if (slen < lim)
> - lim = slen;
> + lim = min(sizeof(d->gd-&
head alone for the duration between
the submission of the bio and its completion, whether successful
or not.
Signed-off-by: Ed Cashin
---
drivers/block/aoe/aoecmd.c | 17 +++--
1 files changed, 7 insertions(+), 10 deletions(-)
diff --git a/drivers/block/aoe/aoecmd.c b/drivers/block
1 - 100 of 599 matches
Mail list logo
