Re: [PATCH-RFC 6/7] drivers: of: ifdef out cmdline section

2015-10-07 Thread dwalker
On Tue, Oct 06, 2015 at 12:14:43PM -0500, Rob Herring wrote: > On Tue, Oct 6, 2015 at 10:47 AM, Daniel Walker wrote: > > It looks like there's some seepage of cmdline stuff into > > the generic device tree code. This conflicts with the > > generic cmdline implementation so I remove it in the case

ktest reboot on each test

2015-09-01 Thread dwalker
Steven, I was playing with ktest.pl and I found that it reboots after each test. What I wanted to do was to boot the system with one TEST_START section, then leave it booted. I would have additional TEST_START sections which would run on the already booted target. The only way I see to do that

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-09 Thread dwalker
Seems ok to me. These files, and functions, are also in drivers/staging/dream/ are you removing them there also ? On Sun, Dec 07, 2014 at 02:12:20AM +0100, Rickard Strandqvist wrote: > Removes some functions that are not used anywhere: > smsm_set_sleep_duration() smsm_get_state() smd_wait_until_

Re: [PATCH] printk: add per console loglevel

2015-01-04 Thread dwalker
On Tue, Dec 23, 2014 at 10:13:24PM +0100, Bruno Prémont wrote: > On Tue, 23 December 2014 dwal...@fifo99.com wrote: > > On Sun, Dec 21, 2014 at 07:47:53PM +0100, Bruno Prémont wrote: > > > On Sat, 20 December 2014 dwal...@fifo99.com wrote: > > > > This adds to to the console= command line options a

Re: [PATCH] printk: add per console loglevel

2014-12-23 Thread dwalker
On Sun, Dec 21, 2014 at 11:03:24AM -0800, Joe Perches wrote: > On Sun, 2014-12-21 at 19:47 +0100, Bruno Prémont wrote: > > On Sat, 20 December 2014 dwal...@fifo99.com wrote: > > > This adds to to the console= command line options allowing the > > > addition of a per console log level setting. > > >

Re: [PATCH] printk: add per console loglevel

2014-12-23 Thread dwalker
On Sun, Dec 21, 2014 at 07:47:53PM +0100, Bruno Prémont wrote: > On Sat, 20 December 2014 dwal...@fifo99.com wrote: > > This adds to to the console= command line options allowing the > > addition of a per console log level setting. > > > > examples, > > > > console=ttyS0,ll4 > > console=t

Re: kexec crash kernel running with watchdog enabled

2015-06-24 Thread dwalker
On Wed, Jun 24, 2015 at 03:52:48PM +0900, Masami Hiramatsu wrote: > Hi, > > On 2015/06/23 23:05, dwal...@fifo99.com wrote: > > > > Hi, > > > > There was a commit in kernel/panic.c which altered when the kexec crash > > kernel is executed, > > > > commit f06e5153f4ae2e2f3b0300f0e260e40cb7fefd45

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-19 Thread dwalker
On Mon, May 19, 2014 at 01:53:28PM +0200, Paul Bolle wrote: > Daniel, > > On Thu, 2014-05-15 at 21:57 +, dwal...@fifo99.com wrote: > > On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: > > > This is not something I get to decide. Nevertheless, given that this > > > file shouldn't hav

Re: [PATCH] arm: msm: remove MACH_MSM7X30_SURF

2014-02-16 Thread dwalker
On Sun, Feb 16, 2014 at 06:34:40PM +0100, Paul Bolle wrote: > The Kconfig symbol MACH_MSM7X30_SURF was added in v2.6.35. It has never > been used. Setting it has no effect. There are no calls for > machine_is_mach_msm7x30(). This symbol can safely be removed. > > Signed-off-by: Paul Bolle > --- >

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > mahimahi)") added just board-mahimahi.c. It did not add > board-mahimahi.h, Makefile changes or Kconfig changes. > > Four years have passed and this file is still dangl

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: > Daniel, > > On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: > > On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > > > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > > > mahimahi)") added jus

Re: [PATCH] tty: serial: msm_serial.c: Cleaning up uninitialized variables

2014-06-02 Thread dwalker
On Sun, Jun 01, 2014 at 03:38:24PM +0200, Rickard Strandqvist wrote: > There is a risk that the variable will be used without being initialized. > > This was largely found by using a static code analysis program called > cppcheck. > > Signed-off-by: Rickard Strandqvist > --- > drivers/tty/seri

Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-18 Thread dwalker
On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: > Hi > > My script looks for the same function name, so if they then would be > named exactly the same, they would come up. > > But I can not even find drivers/staging/dream/ or is this really new code? Maybe it was deleted a

Re: ***UNCHECKED*** Re: [PATCH] arch: arm: mach-msm: smd.c: Remove some unused functions

2014-12-20 Thread dwalker
On Thu, Dec 18, 2014 at 11:35:04PM +0100, Arnd Bergmann wrote: > On Thursday 18 December 2014 22:01:28 dwal...@fifo99.com wrote: > > On Tue, Dec 16, 2014 at 12:20:43AM +0100, Rickard Strandqvist wrote: > > > Hi > > > > > > My script looks for the same function name, so if they then would be > > >

[PATCH] printk: add per console loglevel

2014-12-20 Thread dwalker
This adds to to the console= command line options allowing the addition of a per console log level setting. examples, console=ttyS0,ll4 console=tty0,ll6 This can be used on systems which have multiple serial consoles, but it's desired for logging to be light on one and heavy on

Re: [RFC PATCH 00/18] ARM: msm multiplatform support

2015-03-06 Thread dwalker
On Wed, Mar 04, 2015 at 08:32:54PM +0100, Arnd Bergmann wrote: > This is my final piece of the puzzle for ARMv6/v7 multiplatform > support. In combination with the other patches that are now > at git://kernel.org/pub/scm/linux/kernel/git/arnd/playground.git > multiplatform-4.0-rc2 and the at91 and

Re: [PATCH 00/12] Remove mach-msm and associated code

2015-03-17 Thread dwalker
On Fri, Mar 13, 2015 at 01:45:36PM -0700, Stephen Boyd wrote: > On 03/13/15 12:55, Arnd Bergmann wrote: > > On Friday 13 March 2015 11:09:33 Stephen Boyd wrote: > >> The maintainers for mach-msm no longer have any plans to support > >> or test the platforms supported by this architecture[1]. Most l

Re: [RFC PATCH 00/18] ARM: msm multiplatform support

2015-03-04 Thread dwalker
On Wed, Mar 04, 2015 at 08:32:54PM +0100, Arnd Bergmann wrote: > This is my final piece of the puzzle for ARMv6/v7 multiplatform > support. In combination with the other patches that are now > at git://kernel.org/pub/scm/linux/kernel/git/arnd/playground.git > multiplatform-4.0-rc2 and the at91 and

Re: linux-next: commits in the cisco tree

2018-10-01 Thread dwalker
On Sun, Sep 30, 2018 at 11:24:19AM +1000, Stephen Rothwell wrote: > Hi Daniel, > > I noticed that you have added some commits to the cisco tree today. Just a > couple of comments: > > Fristly, commits > > 734245aec283 ("This code allows architectures to use a generic builtin > command line.

Re: kexec crash kernel running with watchdog enabled

2015-06-25 Thread dwalker
On Wed, Jun 24, 2015 at 12:06:03PM -0500, Eric W. Biederman wrote: > dwal...@fifo99.com writes: > > > On Wed, Jun 24, 2015 at 03:52:48PM +0900, Masami Hiramatsu wrote: > >> Hi, > >> > >> On 2015/06/23 23:05, dwal...@fifo99.com wrote: > >> > > >> > Hi, > >> > > >> > There was a commit in kernel/

Re: kexec crash kernel running with watchdog enabled

2015-06-26 Thread dwalker
On Fri, Jun 26, 2015 at 10:02:00AM +0900, Hidehiro Kawai wrote: > Hi, > > (2015/06/25 1:31), dwal...@fifo99.com wrote: > > On Wed, Jun 24, 2015 at 03:52:48PM +0900, Masami Hiramatsu wrote: > >> Hi, > >> > >> On 2015/06/23 23:05, dwal...@fifo99.com wrote: > >>> > >>> Hi, > >>> > >>> There was a com

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread dwalker
On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: > dwal...@fifo99.com writes: > > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: > >> Hidehiro Kawai writes: > >> > >> > You can call panic notifiers and kmsg dumpers before kdump by > >> > specifying "crash_

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread dwalker
On Tue, Jul 14, 2015 at 11:02:08AM -0400, Vivek Goyal wrote: > On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: > > On Mon, Jul 13, 2015 at 08:19:45PM -0500, Eric W. Biederman wrote: > > > dwal...@fifo99.com writes: > > > > > > > On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W.

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread dwalker
On Tue, Jul 14, 2015 at 11:40:40AM -0400, Vivek Goyal wrote: > On Tue, Jul 14, 2015 at 03:34:30PM +, dwal...@fifo99.com wrote: > > On Tue, Jul 14, 2015 at 11:02:08AM -0400, Vivek Goyal wrote: > > > On Tue, Jul 14, 2015 at 01:59:19PM +, dwal...@fifo99.com wrote: > > > > On Mon, Jul 13, 2015

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-14 Thread dwalker
On Tue, Jul 14, 2015 at 12:06:15PM -0500, Eric W. Biederman wrote: > Vivek Goyal writes: > > > On Tue, Jul 14, 2015 at 03:48:33PM +, dwal...@fifo99.com wrote: > >> On Tue, Jul 14, 2015 at 11:40:40AM -0400, Vivek Goyal wrote: > >> > On Tue, Jul 14, 2015 at 03:34:30PM +, dwal...@fifo99.com

Re: [PATCH 1/3] panic: Disable crash_kexec_post_notifiers if kdump is not available

2015-07-13 Thread dwalker
On Fri, Jul 10, 2015 at 08:41:28AM -0500, Eric W. Biederman wrote: > Hidehiro Kawai writes: > > > You can call panic notifiers and kmsg dumpers before kdump by > > specifying "crash_kexec_post_notifiers" as a boot parameter. > > However, it doesn't make sense if kdump is not available. In that >