Re: A problem about DIRECT IO on ext3

2005-08-29 Thread colin
Hi all, Sorry, ignore this mail. I found that I didn't align the block size when doing direct io... :-( Regards, Colin - Original Message - From: "colin" <[EMAIL PROTECTED]> To: Sent: Monday, August 29, 2005 8:15 PM Subject: A problem about DIRECT IO on ext3

Re: [PATCH v2 0/2] clk: add clk accuracy support

2013-11-27 Thread colin
Um, do you have a definition somewhere (like in comments) of the definition of the accuracy you're using? So multiple people can add consistent values? Is this the standard deviation (67% confidence), 2 standard deviations (95%), 3 (99%), or something else? What averaging time is this computed o

Re: [PATCH v3 00/15] PCI/iommu: Fix DMA alias problems

2014-05-15 Thread colin
Alex Williamson wrote: > Wow, I didn't think that kind of broken was possible. Maybe instead of > a bitmap of function aliases we could have a single devfn alias for a > device. That means we'd only be able to support a single alias for a > device, but since I don't think we've seen devices that

[PATCH RESEND] PCI: Allow pcie_aspm=force to work even when FADT indicates it is unsupported

2012-11-27 Thread Colin King
From: Colin Ian King BugLink: http://bugs.launchpad.net/bugs/962038 Right now using pcie_aspm=force will not enable ASPM if the FADT indicates ASPM is unsupported. However, the semantics of force should probably allow for this, especially as they did before the ASPM disable rework with commit

[PATCH 2/5] ACPI video: remove unnecessary newline from error messages

2012-11-29 Thread Colin King
From: Colin Ian King ACPI_ERROR() already appends a newline, so there is no need for the error messages to include one too. Signed-off-by: Colin Ian King --- drivers/acpi/video.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/acpi/video.c b/drivers/acpi

[PATCH 3/5] ACPI sysfs: remove unnecessary newline from exception

2012-11-29 Thread Colin King
From: Colin Ian King ACPI_EXCEPTION() already appends a newline, so there is no need for the invalid GPE message to include one too. Signed-off-by: Colin Ian King --- drivers/acpi/sysfs.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/sysfs.c b/drivers/acpi

[PATCH 5/5] ACPI thermal: remove unnecessary newline from exception message

2012-11-29 Thread Colin King
From: Colin Ian King ACPI_EXCEPTION() already appends a newline, so there is no need for the thermal trip point message to include one too. Signed-off-by: Colin Ian King --- drivers/acpi/thermal.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/thermal.c b

[PATCH 4/5] ACPICA: GPE support: remove unnecessary newline from error messages

2012-11-29 Thread Colin King
From: Colin Ian King ACPI_ERROR() already appends a newline, so there is no need for the error messages to include one too. Signed-off-by: Colin Ian King --- drivers/acpi/acpica/hwgpe.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/acpica/hwgpe.c b/drivers

[PATCH 0/5] remove some unnecessary newline from error messages

2012-11-29 Thread Colin King
From: Colin Ian King The ACPI_EXCEPTION and ACPI_ERROR macros already emit a newline after the message, so remove the unnecessary newlines from a bunch of messages. Colin Ian King (5): ACPI dock: remove unnecessary newline from exception message ACPI video: remove unnecessary newline from

[PATCH 1/5] ACPI dock: remove unnecessary newline from exception message

2012-11-29 Thread Colin King
From: Colin Ian King ACPI_EXCEPTION() already appends a newline, so there is no need for the failed _DCK messaged to include one too. Signed-off-by: Colin Ian King --- drivers/acpi/dock.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/acpi/dock.c b/drivers/acpi

Re: [PATCH v2] drivers/tty: Folding Android's keyreset driver in sysRQ

2012-09-01 Thread Colin Cross
On Fri, Aug 31, 2012 at 2:52 PM, Mathieu Poirier wrote: > On 12-08-30 05:01 PM, Dmitry Torokhov wrote: >> Hi Matthieu, >> >> On Thu, Aug 30, 2012 at 04:30:54PM -0600, mathieu.poir...@linaro.org wrote: >>> From: "Mathieu J. Poirier" >>> >>> This patch adds keyreset functionality to the sysrq drive

Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback

2012-09-11 Thread Colin Cross
On Tue, Sep 11, 2012 at 8:32 PM, Anton Vorontsov wrote: > On Tue, Sep 11, 2012 at 03:15:40PM +0100, Alan Cox wrote: >> Anton Vorontsov wrote: >> > This patch implements a new callback: clear_irqs. It is used for the >> >> This bit I still really don't like. I would like to know what the generic >

Re: [RFC] tty/serial/kgdboc: Add and wire up clear_irqs callback

2012-09-11 Thread Colin Cross
On Tue, Sep 11, 2012 at 9:06 PM, Anton Vorontsov wrote: > On Tue, Sep 11, 2012 at 08:42:46PM -0700, Colin Cross wrote: > [...] >> > The "problem" is in the last step. If we exit NMI without making UART >> > know that we're done with the interrupt, we will

Re: [PATCH] pinctrl: use kasprintf() in pinmux_request_gpio()

2012-09-14 Thread Colin Cross
On Thu, Sep 13, 2012 at 10:19 PM, Joe Perches wrote: > On Thu, 2012-09-13 at 21:49 +0200, Thomas Petazzoni wrote: >> Instead of using a temporary buffer, snprintf() and kstrdup(), just >> use kasprintf() that does the same thing in just oneline. >> >> Signed-off-by: Thomas Petazzoni >> --- >> dr

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-03 Thread Colin Cross
On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman wrote: > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: "Dae S. Kim" > > commit 6bd4a5d96c08dc2380f8053b1bd4f879f55cd3c9 upstream. > > Fixed a bug. Data was being written to user spac

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-03 Thread Colin Cross
On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman wrote: > 3.4-stable review patch. If anyone has any objections, please let me know. > > -- > > From: Heiko Stuebner > > commit 308b3afb97dc342e9c4f958d8b4c459ae0e22bd7 upstream. > > Commit a5238e360b71 (spi: s3c64xx: move contro

Re: [ 35/54] ARM: SAMSUNG: Add naming of s3c64xx-spi devices

2012-11-04 Thread Colin Cross
On Sun, Nov 4, 2012 at 11:51 PM, Greg Kroah-Hartman wrote: > On Sat, Nov 03, 2012 at 11:17:57PM -0700, Colin Cross wrote: >> On Mon, Oct 29, 2012 at 2:40 PM, Greg Kroah-Hartman >> wrote: >> > 3.4-stable review patch. If anyone has any object

Re: [ 044/218] Staging: Android alarm: IOCTL command encoding fix

2012-11-05 Thread Colin Cross
On Mon, Nov 5, 2012 at 12:22 AM, Greg Kroah-Hartman wrote: > On Sat, Nov 03, 2012 at 12:33:07AM -0700, Colin Cross wrote: >> On Fri, Sep 28, 2012 at 1:14 PM, Greg Kroah-Hartman >> wrote: >> > 3.4-stable review patch. If anyone has any object

Re: [PATCH] cpuidle: coupled: fix sleeping while atomic in cpu notifier

2012-07-26 Thread Colin Cross
On Thu, Jul 26, 2012 at 12:55 PM, Rafael J. Wysocki wrote: > On Wednesday, July 25, 2012, Colin Cross wrote: >> The cpu hotplug notifier gets called in both atomic and non-atomic >> contexts, it is not always safe to lock a mutex. Filter out all events >> except the six nece

Re: [PATCH 0/7] KDB: Kiosk (reduced capabilities) mode

2012-07-27 Thread Colin Cross
On Thu, Jul 26, 2012 at 7:25 AM, Anton Vorontsov wrote: > Hi all, > > Here is a patchset that implements "kiosk" mode for KDB debugger. The > mode provides reduced set of features, so that it is no longer possible > to leak sensitive data via the debugger, and not possible to change > program flow

Re: [PATCH 0/3] add new API to sysfs and device core code

2012-07-27 Thread Colin Cross
On Fri, Jul 27, 2012 at 8:50 AM, Greg KH wrote: > On Fri, Jul 27, 2012 at 12:02:40PM +0800, Bryan Wu wrote: >> Send out a uevent when create file in sysfs, which is required by userspace >> application such udev in Android > > There is no such thing as "udev in Android" the last time I looked. > >

Re: [RFC v2] ARM: sched_clock: update epoch_cyc on resume

2012-07-27 Thread Colin Cross
On Fri, Jul 27, 2012 at 4:38 PM, Russell King - ARM Linux wrote: > On Sat, Jul 28, 2012 at 01:32:50AM +0200, Linus Walleij wrote: >> On Wed, Jul 25, 2012 at 4:49 AM, Colin Cross wrote: >> >> > Many clocks that are used to provide sched_clock will reset during >> &

Re: [PATCH 0/7] KDB: Kiosk (reduced capabilities) mode

2012-07-27 Thread Colin Cross
On Fri, Jul 27, 2012 at 6:26 PM, Anton Vorontsov wrote: > But if you say that it wasn't the case, and no one thought about the > reducing the debugger in the "evil" way, so be it, I trust you. But I > still don't trust the phone vendors. They showed their bad attitude > in many ways towards hack

Re: [RFC v2] ARM: sched_clock: update epoch_cyc on resume

2012-07-27 Thread Colin Cross
On Fri, Jul 27, 2012 at 6:15 PM, Colin Cross wrote: > On Fri, Jul 27, 2012 at 4:38 PM, Russell King - ARM Linux > wrote: >> On Sat, Jul 28, 2012 at 01:32:50AM +0200, Linus Walleij wrote: >>> On Wed, Jul 25, 2012 at 4:49 AM, Colin Cross wrote: >>> >>>

Re: [PATCH 03/11] kdb: Implement disable_nmi command

2012-07-30 Thread Colin Cross
On Mon, Jul 30, 2012 at 4:58 AM, Anton Vorontsov wrote: > This command disables NMI-entry. If NMI source was previously shared with > a serial console ("debug port"), this effectively releases the port from > KDB exclusive use, and makes the console available for normal use. > > Of course, NMI can

Re: [PATCH] cpuidle: coupled: fix sleeping while atomic in cpu notifier

2012-07-31 Thread Colin Cross
On Tue, Jul 31, 2012 at 8:43 AM, Srivatsa S. Bhat wrote: > On 07/26/2012 02:50 AM, Colin Cross wrote: >> The cpu hotplug notifier gets called in both atomic and non-atomic >> contexts, it is not always safe to lock a mutex. Filter out all events >> except the six necessar

Re: [PATCH] leds: triggers: send uevent when changing triggers

2012-07-31 Thread Colin Cross
On Thu, Jul 26, 2012 at 9:04 PM, Bryan Wu wrote: > On Fri, Jul 27, 2012 at 12:51 AM, Greg KH wrote: >> On Thu, Jul 26, 2012 at 01:03:11PM +0800, Bryan Wu wrote: >>> Just one quick patch for my idea: emitting a uevent in sysfs_create_file(). >>> >>> -- >>> diff --git a/fs/sysfs/file.c b/fs/sysfs/f

[PATCH] pstore: fix NULL pointer dereference in console writes

2012-10-30 Thread Colin King
From: Colin Ian King Passing a NULL id causes a NULL pointer deference in writers such as erst_writer and efi_pstore_write because they expect to update this id. Pass a dummy id instead. This avoids a cascade of oopses caused when the initial pstore_console_write passes a null which in turn

Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-28 Thread Colin Cross
On Wed, Aug 28, 2013 at 2:28 PM, Rafael J. Wysocki wrote: > On Friday, August 23, 2013 12:45:10 PM Colin Cross wrote: >> Calling cpuidle_enter_state is expected to return with interrupts >> enabled, but interrupts must be disabled before starting the >> ready loop synchro

Re: [RFC PATCHv3] drivers: power: Detect device suspend/resume lockup and log event in pstore.

2013-08-28 Thread Colin Cross
On Wed, Aug 28, 2013 at 3:36 PM, John Stultz wrote: > On 08/28/2013 01:52 PM, Rafael J. Wysocki wrote: >> On Wednesday, August 28, 2013 10:45:45 AM Zoran Markovic wrote: >>> Hi Rafael, It doesn't look too bad from a quick look, but there's a couple of things I don't like in it still (rel

[PATCH v2] cpuidle: coupled: abort idle if pokes are pending

2013-08-28 Thread Colin Cross
enters the waiting loop and when it moves on to the ready loop. Reported-by: Joseph Lo Tested-by: Stephen Warren Tested-by: Joseph Lo Signed-off-by: Colin Cross --- drivers/cpuidle/coupled.c | 107 +++--- 1 file changed, 82 insertions(+), 25 deletions

Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-29 Thread Colin Cross
On Wed, Aug 28, 2013 at 11:50 PM, Prashant Gaikwad wrote: > On Saturday 24 August 2013 01:15 AM, Colin Cross wrote: >> >> Calling cpuidle_enter_state is expected to return with interrupts >> enabled, but interrupts must be disabled before starting the >> ready loop s

[PATCHv2 1/2] mm: rearrange madvise code to allow for reuse

2013-10-01 Thread Colin Cross
function called madvise_update_vma. The next patch will add support for updating a new anon_name field as well. Signed-off-by: Colin Cross --- mm/madvise.c | 272 +-- 1 file changed, 151 insertions(+), 121 deletions(-) diff --git a/mm/madvise.c

Re: [PATCH v2] cpuidle: coupled: abort idle if pokes are pending

2013-08-29 Thread Colin Cross
On Thu, Aug 29, 2013 at 1:28 PM, Rafael J. Wysocki wrote: > On Wednesday, August 28, 2013 06:41:47 PM Colin Cross wrote: >> Joseph Lo reported a lockup on Tegra20 caused >> by a race condition in coupled cpuidle. When two or more cpus >> enter idle at the same time, the fir

Re: [PATCH 14/21] cpuidle: coupled: don't compare cpu masks unnecessarily

2013-09-25 Thread Colin Cross
On Sat, Sep 21, 2013 at 6:21 PM, Viresh Kumar wrote: > In cpuidle_coupled_register_device() we do following: > if (WARN_ON(!cpumask_equal(&dev->coupled_cpus, > &coupled->coupled_cpus))) > coupled->prevent++; > > This is only required to be done when we are using 'coupled'

Re: [RFC PATCH] freezer: allow killing of frozen tasks

2013-09-25 Thread Colin Cross
On Wed, Sep 25, 2013 at 1:07 AM, Rafael J. Wysocki wrote: > On Wednesday, September 25, 2013 02:52:26 PM Kyungmin Park wrote: >> On Tue, Aug 20, 2013 at 9:41 PM, Rafael J. Wysocki wrote: >> > On Tuesday, August 20, 2013 08:27:27 AM Tejun Heo wrote: >> >> On Tue, Aug 20, 2013 at 02:34:14PM +0200,

Re: [PATCH 14/21] cpuidle: coupled: don't compare cpu masks unnecessarily

2013-09-25 Thread Colin Cross
On Thu, Sep 26, 2013 at 1:36 AM, Viresh Kumar wrote: > On 26 September 2013 05:55, Colin Cross wrote: >> I don't agree with this. This patch is a tiny optimization in code >> that is rarely called, and it moves a final sanity check somewhere >> that it might get mis

[PATCH RESEND] pstore: fix NULL pointer dereference in console writes

2012-11-14 Thread Colin King
From: Colin Ian King Passing a NULL id causes a NULL pointer deference in writers such as erst_writer and efi_pstore_write because they expect to update this id. Pass a dummy id instead. This avoids a cascade of oopses caused when the initial pstore_console_write passes a null which in turn

[PATCH] Revert "Staging: Android alarm: IOCTL command encoding fix"

2012-11-07 Thread Colin Cross
. Cc: stable Cc: Dae S. Kim Signed-off-by: Colin Cross --- drivers/staging/android/android_alarm.h |4 +--- 1 files changed, 1 insertions(+), 3 deletions(-) diff --git a/drivers/staging/android/android_alarm.h b/drivers/staging/android/android_alarm.h index f2ffd96..d0cafd6 100644 --- a

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 11:21 AM, Linus Torvalds wrote: >> What I meant is IF is included by userspace (it sure is >> meant to be included and *is* included by libfuse and other stuff) >> THEN using instead of is fine regardless of >> whether __linux__ is defined or not. > > That's probably tru

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-16 Thread Colin Cross
On Tue, Apr 16, 2013 at 12:11 PM, Miklos Szeredi wrote: > On Tue, Apr 16, 2013 at 8:29 PM, Colin Cross wrote: >> Dropping __linux__ causes a make headers_check warning, which the >> kbuild test robot reported this morning: >> usr/include/linux/fuse.h:99: found __[us]{8,1

Re: [PATCH] fuse: use kernel headers when __KERNEL__ is set

2013-04-17 Thread Colin Cross
On Wed, Apr 17, 2013 at 2:57 AM, Miklos Szeredi wrote: > On Tue, Apr 16, 2013 at 01:00:37PM -0700, Colin Cross wrote: > >> Every other uapi header includes linux/types.h to get its type >> definitions, and fuse.h should do the same when compiling for >> userspace

[PATCH] ARM: convert max_pfn and max_low_pfn to be relative to PFN0

2013-06-12 Thread Colin Cross
ice performance where the bounce limit was set to BLK_BOUNCE_HIGH, which was bouncing unnecessarily for the top PHYS_PFN_OFFSET pages of low memory. Signed-off-by: Colin Cross --- arch/arm/mm/init.c | 21 ++--- 1 file changed, 6 insertions(+), 15 deletions(-) Boot tested on 3.4 and filled

Re: [PATCH] ARM: convert max_pfn and max_low_pfn to be relative to PFN0

2013-06-13 Thread Colin Cross
On Thu, Jun 13, 2013 at 7:37 AM, Russell King - ARM Linux wrote: > On Wed, Jun 12, 2013 at 07:13:23PM -0700, Colin Cross wrote: >> >From code inspection, I believe this will also improve block device >> performance where the bounce limit was set to BLK_BOUNCE_HIGH, whi

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-14 Thread Colin Cross
On Fri, Jun 14, 2013 at 11:42 AM, Zoran Markovic wrote: >> I am not sure I understand why this patch is needed. When a new card >> is inserted/removed and the upper levels gets notification about the >> new card, triggering the mounting/un-mounting of the file system, why >> should it be the lowes

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-17 Thread Colin Cross
On Mon, Jun 17, 2013 at 7:22 AM, Ulf Hansson wrote: > On 14 June 2013 22:52, Colin Cross wrote: >> On Fri, Jun 14, 2013 at 11:42 AM, Zoran Markovic >> wrote: >>>> I am not sure I understand why this patch is needed. When a new card >>>> is inserted/removed

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-18 Thread Colin Cross
On Tue, Jun 18, 2013 at 6:17 AM, Ulf Hansson wrote: > On 17 June 2013 20:33, Colin Cross wrote: >> This is a generic requirement for using a kernel with autosleep >> enabled. Autosleep will enter suspend whenever there is no wakeup >> source/wakelock held. Consider t

Re: [RFC PATCH] mmc: Enable wakeup_sources for mmc core

2013-06-19 Thread Colin Cross
On Wed, Jun 19, 2013 at 7:21 AM, Ulf Hansson wrote: > It seems like a bad idea that an insertion of an SD card should > trigger the display to be light up. That is indirectly in principle > what you suggest should happen from user space once a new SD card is > found. Right? Most likely what will

RFC: named anonymous vmas

2013-06-21 Thread Colin Cross
One of the features of ashmem (drivers/staging/android/ashmem.c) that hasn't gotten much discussion about moving out of staging is named anonymous memory. In Android, ashmem is used for three different features, and most users of it only care about one feature at a time. One is volatile ranges, w

Re: RFC: named anonymous vmas

2013-06-21 Thread Colin Cross
On Fri, Jun 21, 2013 at 10:12 PM, Kyungmin Park wrote: > On Sat, Jun 22, 2013 at 8:42 AM, Colin Cross wrote: >> One of the features of ashmem (drivers/staging/android/ashmem.c) that >> hasn't gotten much discussion about moving out of staging is named >> anonymou

Re: RFC: named anonymous vmas

2013-06-22 Thread Colin Cross
On Sat, Jun 22, 2013 at 3:31 AM, Christoph Hellwig wrote: > On Fri, Jun 21, 2013 at 04:42:41PM -0700, Colin Cross wrote: >> ranges, which John Stultz has been implementing. The second is >> anonymous shareable memory without having a world-writable tmpfs that >> untrusted

Re: RFC: named anonymous vmas

2013-06-24 Thread Colin Cross
On Mon, Jun 24, 2013 at 4:48 AM, Christoph Hellwig wrote: > On Sat, Jun 22, 2013 at 12:47:29PM -0700, Alex Elsayed wrote: >> Couldn't this be done by having a root-only tmpfs, and having a userspace >> component that creates per-app directories with restrictive permissions on >> startup/app instal

Re: [RFC PATCHv2 1/2] drivers: power: Add watchdog timer to catch drivers which lockup during suspend/resume.

2013-06-10 Thread Colin Cross
On Thu, Jun 6, 2013 at 7:12 AM, Alan Stern wrote: > On Wed, 5 Jun 2013, Zoran Markovic wrote: > >> > It does block in my environment, AFAICS. Looking a bit further in the >> > code, it looks like dpm_suspend() does an async_synchronize_full() >> > which would wait for all async tasks to complete.

Re: [PATCH 1/1] clk: Add notifier support in clk_prepare/clk_unprepare

2013-03-21 Thread Colin Cross
On Thu, Mar 21, 2013 at 3:36 PM, Mike Turquette wrote: > To my knowledge, devfreq performs one task: implements an algorithm > (typically one that loops/polls) and applies this heuristic towards a > dvfs transition. > > It is a policy layer, a high level layer. It should not be used as a > lower-

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-19 Thread Colin Cross
On Mon, Aug 19, 2013 at 6:16 PM, Leon Ma wrote: > From: Leon Ma > Date: Mon, 19 Aug 2013 14:22:38 +0800 > Subject: [PATCH] LMK: Optimize lowmem_shrink. > > By comparing with selected_oom_score_adj instead of min_score_adj, > we may do less calculation. > > Signed-off-by: Leon Ma > --- > drivers

Re: [PATCH] LMK: Optimize lowmem_shrink

2013-08-19 Thread Colin Cross
On Mon, Aug 19, 2013 at 7:23 PM, Colin Cross wrote: > On Mon, Aug 19, 2013 at 6:16 PM, Leon Ma wrote: >> From: Leon Ma >> Date: Mon, 19 Aug 2013 14:22:38 +0800 >> Subject: [PATCH] LMK: Optimize lowmem_shrink. >> >> By comparing with selected_oom_score_adj inste

Re: [PATCH] cpuidle: coupled: fix dead loop corner case

2013-08-22 Thread Colin Cross
On Mon, Aug 19, 2013 at 10:17 PM, Neil Zhang wrote: > There is a corener case when no peripheral irqs route to secondary > cores. > Let's take dual core system for example, the sequence is as following: > > Core 0 Core1 > 1.

[PATCH 2/3] cpuidle: coupled: abort idle if pokes are pending

2013-08-23 Thread Colin Cross
enters the waiting loop and when it moves on to the ready loop. Reported-by: Joseph Lo CC: sta...@vger.kernel.org Signed-off-by: Colin Cross --- drivers/cpuidle/coupled.c | 107 +++--- 1 file changed, 82 insertions(+), 25 deletions(-) diff --git a/drivers

[PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-23 Thread Colin Cross
Calling cpuidle_enter_state is expected to return with interrupts enabled, but interrupts must be disabled before starting the ready loop synchronization stage. Call local_irq_disable after each call to cpuidle_enter_state for the safe state. CC: sta...@vger.kernel.org Signed-off-by: Colin Cross

[PATCH 3/3] cpuidle: coupled: fix race condition between pokes and safe state

2013-08-23 Thread Colin Cross
() checks into the callers. In the waiting loop, if a poke was cleared restart the loop to repeat the while condition checks. Reported-by: Neil Zhang CC: sta...@vger.kernel.org Signed-off-by: Colin Cross --- drivers/cpuidle/coupled.c | 20 ++-- 1 file changed, 14 insertions(+), 6

Re: [PATCH 1/3] cpuidle: coupled: disable interrupts after entering safe state

2013-08-23 Thread Colin Cross
On Fri, Aug 23, 2013 at 4:09 PM, Stephen Warren wrote: > On 08/23/2013 01:45 PM, Colin Cross wrote: >> Calling cpuidle_enter_state is expected to return with interrupts >> enabled, but interrupts must be disabled before starting the >> ready loop synchronization stage. C

Re: linux-next: Tree for Aug 7 [ call-trace on suspend: ext4 | pm related ? ]

2013-08-07 Thread Colin Cross
Can you try add a call to show_state_filter(TASK_UNINTERRUPTIBLE) in the error path of try_to_freeze_tasks(), where it prints the "refusing to freeze" message? It will print the stack trace of every thread since they are all in the freezer, so the output will be very long. On Wed, Aug 7, 2013 at

Re: linux-next: Tree for Aug 7 [ call-trace on suspend: ext4 | pm related ? ]

2013-08-07 Thread Colin Cross
On Wed, Aug 7, 2013 at 4:15 PM, Sedat Dilek wrote: > On Thu, Aug 8, 2013 at 12:58 AM, Colin Cross wrote: >> Can you try add a call to show_state_filter(TASK_UNINTERRUPTIBLE) in >> the error path of try_to_freeze_tasks(), where it prints the "refusing >> to freeze&qu

Re: linux-next: Tree for Aug 7 [ call-trace on suspend: ext4 | pm related ? ]

2013-08-07 Thread Colin Cross
On Wed, Aug 7, 2013 at 6:01 PM, Sedat Dilek wrote: > On Thu, Aug 8, 2013 at 1:34 AM, Colin Cross wrote: >> On Wed, Aug 7, 2013 at 4:15 PM, Sedat Dilek wrote: >>> On Thu, Aug 8, 2013 at 12:58 AM, Colin Cross wrote: >>>> Can you try add a call to show_state_f

Re: Linux apanic mechanism and difference from newer ram_console/persistent_ram mechanism

2013-08-08 Thread Colin Cross
On Thu, Aug 8, 2013 at 4:50 AM, Yuva Raj wrote: > On Thu, Aug 8, 2013 at 3:03 PM, Vijay wrote: >> >> Hello, >> >> >> I am new to the Kernel-Mailing list. I am not subscribed at the moment >> and would really appreciate it, if I can be CC'd in the >> reply/responses for my question. >> >> I am stu

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-22 Thread Colin Cross
On Mon, Jul 22, 2013 at 4:02 PM, Michael Leun wrote: > On Mon, 6 May 2013 16:50:18 -0700 > Colin Cross wrote: > >> Avoid waking up every thread sleeping in a futex_wait call during > [...] > > With 3.11-rc s2disk from suspend-utils stopped working: Frozen at > displ

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-22 Thread Colin Cross
On Mon, Jul 22, 2013 at 5:32 PM, Linus Torvalds wrote: > On Mon, Jul 22, 2013 at 4:55 PM, Colin Cross wrote: >> >> I think the right solution is to add a flag to the freezing task that >> marks it unfreezable. I think PF_NOFREEZE would work, although it is >> norm

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-22 Thread Colin Cross
On Mon, Jul 22, 2013 at 6:41 PM, Rafael J. Wysocki wrote: > On Monday, July 22, 2013 05:42:49 PM Colin Cross wrote: >> On Mon, Jul 22, 2013 at 5:32 PM, Linus Torvalds >> wrote: >> > On Mon, Jul 22, 2013 at 4:55 PM, Colin Cross wrote: >> >> >> >>

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-23 Thread Colin Cross
On Tue, Jul 23, 2013 at 11:08 AM, Michael Leun wrote: > On Mon, 22 Jul 2013 16:55:58 -0700 > Colin Cross wrote: > >> On Mon, Jul 22, 2013 at 4:02 PM, Michael Leun >> wrote: >> > On Mon, 6 May 2013 16:50:18 -0700 >> > Colin Cross wrote: >> >

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-23 Thread Colin Cross
On Tue, Jul 23, 2013 at 12:16 PM, Michael Leun wrote: > On Tue, 23 Jul 2013 11:29:57 -0700 > Colin Cross wrote: > >> On Tue, Jul 23, 2013 at 11:08 AM, Michael Leun >> wrote: >> > On Mon, 22 Jul 2013 16:55:58 -0700 >> > Colin Cross wrote: >> > >

Re: 3.11-rc regression bisected: s2disk does not work (was Re: [PATCH v3 13/16] futex: use freezable blocking call)

2013-07-23 Thread Colin Cross
On Mon, Jul 22, 2013 at 11:28 PM, Colin Cross wrote: > On Mon, Jul 22, 2013 at 6:41 PM, Rafael J. Wysocki wrote: >> On Monday, July 22, 2013 05:42:49 PM Colin Cross wrote: >>> On Mon, Jul 22, 2013 at 5:32 PM, Linus Torvalds >>> wrote: >>> > On Mon, Jul

[PATCH] power: set PF_SUSPEND_TASK flag on tasks that call freeze_processes

2013-07-24 Thread Colin Cross
by the time suspend is triggered, otherwise they may run when userspace is expected to be frozen. Add a WARN_ON in thaw_processes if more than one thread has the PF_SUSPEND_TASK flag set. Reported-by: Michael Leun Tested-by: Michael Leun Signed-off-by: Colin Cross --- Resending not as an

Need for llistxattrat()/lgetxattrat()/lsetxattrat()

2013-07-26 Thread Colin Walters
Hi, So at the moment the kernel has pretty comprehensive support for the *at() variants of file API calls, and at one point I was rewriting my app to be a modern Unix citizen and use the *at variants, but I ran into one admittedly obscure corner case, which is the lack of API calls to manipulate t

Re: [RFC PATCHv2 1/2] drivers: power: Add watchdog timer to catch drivers which lockup during suspend/resume.

2013-05-10 Thread Colin Cross
ttle context as to why. > The patch hence uses system timer and assumes it is still active while the > devices are suspended/resumed. > > Cc: Android Kernel Team > Cc: Colin Cross > Cc: Todd Poynor > Cc: San Mehat > Cc: Benoit Goby > Cc: John Stultz > Cc: Pavel M

Re: [RFC PATCHv2 2/2] PM: compile-time configuration of device suspend/resume watchdogs.

2013-05-10 Thread Colin Cross
hdog(s). > > Minor changes were made to watchdog code to accommodate this feature. > > Cc: Android Kernel Team > Cc: Colin Cross > Cc: Todd Poynor > Cc: San Mehat > Cc: Benoit Goby > Cc: John Stultz > Cc: Pavel Machek > Cc: Rafael J. Wysocki > Cc: Len Br

Re: [RFC PATCHv2 2/2] PM: compile-time configuration of device suspend/resume watchdogs.

2013-05-11 Thread Colin Cross
On Sat, May 11, 2013 at 2:28 AM, Pavel Machek wrote: > Hi! > >> Power management debug option to configure device suspend/resume watchdogs. >> Available options are: >> 1. Enable/disable the feature. >> 2. Select triggered watchdog action between: >> - system panic (default) >>

Re: [RFC PATCHv2 1/2] drivers: power: Add watchdog timer to catch drivers which lockup during suspend/resume.

2013-05-12 Thread Colin Cross
On Sat, May 11, 2013 at 5:39 PM, Rafael J. Wysocki wrote: > On Friday, May 10, 2013 11:13:27 PM Colin Cross wrote: >> On Fri, May 10, 2013 at 2:28 PM, Zoran Markovic >> wrote: >> > From: Benoit Goby >> > >> > Below is a patch from android kernel that d

Re: [RFC] teach argv_split() to ignore the spaces surrounded by \e

2013-05-13 Thread Colin Walters
On Mon, 2013-05-13 at 16:35 +0200, Oleg Nesterov wrote: > Yes, we can change format_corename() to construct "argv" by hand, and > this was my iniital plan. But perhaps it would be better to not uglify > this code even more? Sure this \e is less code, but it seems pretty ugly to me. Maybe a way t

Re: [RFC PATCH 1/3] pstore-ram: use write-combine mappings

2013-04-09 Thread Colin Cross
Also, isn't this patch unnecessary after patch 3 in this set? > Signed-off-by: Rob Herring > Cc: Anton Vorontsov > Cc: Colin Cross > Cc: Kees Cook > Cc: Tony Luck > Cc: linux-kernel@vger.kernel.org > --- > fs/pstore/ram_core.c |4 ++-- > 1 file changed, 2

Re: [RFC PATCH 3/3] pstore/ram: avoid atomic accesses for ioremapped regions

2013-04-09 Thread Colin Cross
On Tue, Apr 9, 2013 at 8:08 PM, Rob Herring wrote: > From: Rob Herring > > For persistent RAM outside of main memory, the memory may have limitations > on supported accesses. For internal RAM on highbank platform exclusive > accesses are not supported and will hang the system. So atomic_cmpxchg >

Re: [PATCH 09/10] sigtimedwait: use freezable blocking call

2013-04-30 Thread Colin Cross
On Tue, Apr 30, 2013 at 9:38 AM, Oleg Nesterov wrote: > On 04/29, Colin Cross wrote: >> >> Avoid waking up every thread sleeping in a sigtimedwait call during >> suspend and resume by calling a freezable blocking call. > > This doesn't explain why do want this cha

Re: [RFC PATCH] power: Add option to log time spent in suspend

2013-04-30 Thread Colin Cross
On Tue, Apr 30, 2013 at 5:29 PM, Pavel Machek wrote: > Hi! > >> From: Colin Cross >> >> Below is a patch from android kernel that maintains a histogram of >> suspend times. Please review and provide feedback. >> >> Prints the time spent in suspend in

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-04-30 Thread Colin Cross
On Tue, Apr 30, 2013 at 4:30 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 30, 2013 at 03:28:33PM -0700, Zoran Markovic wrote: >> From: Benoit Goby >> >> Below is a patch from android kernel that detects a driver suspend >> lockup and captures dump in the kernel log. Please review and provide >> co

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-04-30 Thread Colin Cross
nd time every device, whether or not they >> resumed synchronously. >> >> Cc: Android Kernel Team >> Cc: Colin Cross >> Cc: Todd Poynor >> Cc: San Mehat >> Cc: Benoit Goby >> Cc: John Stultz >> Cc: Pavel Machek >> Cc: Rafael J. Wysoc

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-04-30 Thread Colin Cross
On Tue, Apr 30, 2013 at 9:17 PM, Greg Kroah-Hartman wrote: > On Tue, Apr 30, 2013 at 08:36:21PM -0700, Colin Cross wrote: >> On Tue, Apr 30, 2013 at 4:30 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Apr 30, 2013 at 03:28:33PM -0700, Zoran Markovic wrote:

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-04-30 Thread Colin Cross
On Tue, Apr 30, 2013 at 9:57 PM, anish singh wrote: > > > > On Wed, May 1, 2013 at 10:09 AM, Colin Cross wrote: >> >> On Tue, Apr 30, 2013 at 9:17 PM, Greg Kroah-Hartman >> wrote: >> > On Tue, Apr 30, 2013 at 08:36:21PM -0700, Colin Cross wrote: >> &

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-05-01 Thread Colin Cross
On Wed, May 1, 2013 at 3:56 AM, Pavel Machek wrote: > Hi! > >> >> @@ -663,6 +671,30 @@ static bool is_async(struct device *dev) >> >> } >> >> >> >> /** >> >> + * dpm_drv_timeout - Driver suspend / resume watchdog handler >> >> + * @data: struct device which timed out >> >> + * >> >> + *

[PATCH v2 09/10] sigtimedwait: use freezable blocking call

2013-05-01 Thread Colin Cross
freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- kernel/signal.c | 2 +- 1 file ch

[PATCH v2 02/10] freezer: skip waking up tasks with PF_FREEZER_SKIP set

2013-05-01 Thread Colin Cross
nergy required to suspend and resume. Signed-off-by: Colin Cross --- v2: move check to freeze_task() kernel/freezer.c | 12 1 file changed, 12 insertions(+) diff --git a/kernel/freezer.c b/kernel/freezer.c index c38893b..8b2afc1 100644 --- a/kernel/freezer.c +++ b/kernel/free

[PATCH v2 03/10] freezer: add new freezable helpers using freezer_do_not_count()

2013-05-01 Thread Colin Cross
(). Additional patches will convert the most common locations that userspace blocks in to use freezable helpers. Signed-off-by: Colin Cross --- include/linux/freezer.h | 72 +++-- 1 file changed, 58 insertions(+), 14 deletions(-) diff --git a/include/linux

[PATCH v2 10/10] af_unix: use freezable blocking calls in read

2013-05-01 Thread Colin Cross
to a freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- net/unix/af_unix.c | 3 +

[PATCH v2 08/10] nanosleep: use freezable blocking call

2013-05-01 Thread Colin Cross
call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- kernel/hrtimer.c | 3 ++- 1 file chang

[PATCH v2 05/10] epoll: use freezable blocking call

2013-05-01 Thread Colin Cross
freezable call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- fs/eventpoll.c | 4 +++- 1 file ch

[PATCH v2 06/10] select: use freezable blocking call

2013-05-01 Thread Colin Cross
call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- fs/select.c | 4 +++- 1 file chang

[PATCH v2 04/10] binder: use freezable blocking calls

2013-05-01 Thread Colin Cross
call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- drivers/staging/android/binder.c | 5 +++

[PATCH v2 07/10] futex: use freezable blocking call

2013-05-01 Thread Colin Cross
call because it doesn't hold any locks or release any resources when interrupted that might be needed by another freezing task or a kernel driver during suspend, and is a common site where idle userspace tasks are blocked. Signed-off-by: Colin Cross --- kernel/futex.c | 3 ++- 1 file chang

[PATCH v2 01/10] freezer: shorten freezer sleep time using exponential backoff

2013-05-01 Thread Colin Cross
All tasks can easily be frozen in under 10 ms, switch to using an initial 1 ms sleep followed by exponential backoff until 8 ms. Also convert the printed time to ms instead of centiseconds. Signed-off-by: Colin Cross --- kernel/power/process.c | 23 +-- 1 file changed, 13

[PATCH v2 00/10] optimize freezing tasks by reducing task wakeups

2013-05-01 Thread Colin Cross
On slow cpus the large number of task wakeups and context switches triggered by freezing and thawing tasks can take a significant amount of cpu time. This patch series reduces the amount of work done during freezing tasks by avoiding waking up tasks that are already in a freezable state. The firs

Re: [PATCH 03/10] freezer: add new freezable helpers using freezer_do_not_count()

2013-05-02 Thread Colin Cross
On Thu, May 2, 2013 at 5:48 AM, Pavel Machek wrote: > On Mon 2013-04-29 14:45:39, Colin Cross wrote: >> Freezing tasks will wake up almost every userspace task from >> where it is blocking and force it to run until it hits a >> call to try_to_sleep(), generally on the exit

Re: [RFC PATCH] drivers: power: Add watchdog timer to catch drivers which lockup during suspend.

2013-05-02 Thread Colin Cross
On Thu, May 2, 2013 at 5:30 AM, Pavel Machek wrote: > Hi! > >> >> > do BUG which >> >> >dumps stack of current task >> >> >kills current task >> >> > >> >> > Current task may very well be idle task; in such case you kill the >> >> > machine. Sounds like you should be doing something else,

  1   2   3   4   5   6   7   8   9   10   >