Re: Memory leak in 2.6.11-rc1?

2005-02-07 Thread axboe
> Linus Torvalds wrote: > : Jan - can you give Jens a bit of an idea of what drivers and/or > schedulers > : you're using? > > I have a Tyan S2882 dual Opteron, network is on-board tg3, > there are 8 P-ATA HDDs hooked on 3ware 7506-8 controller (no HW RAID > there, but the drives are partitio

Re: [PATCH 3/3] md/raid5: For stripe with R5_ReadNoMerge, we replace REQ_FLUSH with REQ_NOMERGE.

2013-10-31 Thread axboe
bi->bi_io_vec[0].bv_len = STRIPE_SIZE; > > Thanks. > > I've queued this up pending Jens' acceptance of the other patches. I've queued up the other two for 3.13. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Recent kernel "mount" slow

2012-11-26 Thread Jens Axboe
x27;t acceptable. Fixing an obscure issue like block sizes changing while O_DIRECT is in flight definitely does NOT warrant a mount slow down. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More

Re: Recent kernel "mount" slow

2012-11-26 Thread Jens Axboe
On 2012-11-27 08:38, Jens Axboe wrote: > On 2012-11-27 06:57, Jeff Chua wrote: >> On Sun, Nov 25, 2012 at 7:23 AM, Jeff Chua wrote: >>> On Sun, Nov 25, 2012 at 5:09 AM, Mikulas Patocka >>> wrote: >>>> So it's better to slow down mount. >>>

Re: Alignment Issue with Direct IO to NVMe Drive

2012-11-27 Thread Jens Axboe
t is > 2.6.32-220 from CentOS, but we have observed similar behavior from a > vanilla 3.3 kernel as well. Any help would be greatly appreciated. I'm assuming you set the hardware sector size to 4k as well? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscri

Re: Recent kernel "mount" slow

2012-11-27 Thread Jens Axboe
On 2012-11-27 11:06, Jeff Chua wrote: > On Tue, Nov 27, 2012 at 3:38 PM, Jens Axboe wrote: >> On 2012-11-27 06:57, Jeff Chua wrote: >>> On Sun, Nov 25, 2012 at 7:23 AM, Jeff Chua >>> wrote: >>>> On Sun, Nov 25, 2012 at 5:09 AM, Mikulas Patocka >&g

Re: Recent kernel "mount" slow

2012-11-28 Thread Jens Axboe
On 2012-11-28 04:57, Mikulas Patocka wrote: > > > On Tue, 27 Nov 2012, Jens Axboe wrote: > >> On 2012-11-27 11:06, Jeff Chua wrote: >>> On Tue, Nov 27, 2012 at 3:38 PM, Jens Axboe wrote: >>>> On 2012-11-27 06:57, Jeff Chua wrote: >>>>> On

Re: [PATCH 07/62] block: convert to idr_alloc()

2013-02-04 Thread Jens Axboe
On Sat, Feb 02 2013, Tejun Heo wrote: > Convert to the much saner new idr interface. Both bsg and genhd > protect idr w/ mutex making preloading unnecessary. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > --- > This patch depends on an earlier idr changes and I think

Re: [PATCH 08/62] block/loop: convert to idr_alloc()

2013-02-04 Thread Jens Axboe
On Sat, Feb 02 2013, Tejun Heo wrote: > Convert to the much saner new idr interface. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > --- > This patch depends on an earlier idr changes and I think it would be > best to route these together through -mm. Please holler if th

Re: [PATCHv2 1/1] block: IBM RamSan 70/80 device driver.

2013-02-05 Thread Jens Axboe
scard supported' if > statement. > o Changed email address to linux.vnet.ibm.com Tentatively applied for 3.9. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at

Re: [GIT PULL] drbd build fix in case CONFIG_CRYPTO_HMAC is not set

2013-02-05 Thread Jens Axboe
he below into that, I don't get a small patch, I get all changes from 3.7 to 3.8-rc5. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordom

Re: For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF.

2013-02-05 Thread Jens Axboe
numbe". There are some places where > returned EBADF like, > >if (!f.file) > > return -EBADF; > > So i think for checking file->f_mode when failed, it should return EACCESS. But that would break the ABI at this point. I agree with you, though, EBADF is

Re: Re: For the condition "file->f_mode", when it failed, it should return EACCES rather than EBADF.

2013-02-05 Thread Jens Axboe
return -EBADF; > >> > >> So i think for checking file->f_mode when failed, it should return EACCESS. > > > >But that would break the ABI at this point. I agree with you, though, > >EBADF is not the right error for this case. > > > >-- > >Jens

Re: linux-next: build failure after merge of the block tree

2013-02-06 Thread Jens Axboe
.c:219:13: warning: 'card_event_handler' defined but > not used [-Wunused-function] > drivers/block/rsxx/core.c:311:12: warning: 'rsxx_compatibility_check' defined > but not used [-Wunused-function] > > Caused by commit 8722ff8cdbfa ("block: IBM RamSan 70/8

Re: [PATCH 06/62] block: fix synchronization and limit check in blk_alloc_devt()

2013-02-06 Thread Jens Axboe
AX_EXT_DEVT to NR_EXT_DEVT and fix limit > checking. > > Signed-off-by: Tejun Heo > Cc: Jens Axboe > Cc: sta...@vger.kernel.org Acked-by: Jens Axboe -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message

[GIT PULL] Block bits for 3.8 final

2013-02-06 Thread Jens Axboe
ce/cleanup Jens Axboe (2): Merge branch 'stable/for-jens-3.8' of git://git.kernel.org/.../konrad/xen into for-linus Merge branch 'for-jens' of git://git.drbd.org/linux-drbd into for-linus Lars Ellenberg (1): drbd: fix potential protocol error and resulting d

Re: [PATCH 04/15] drivers/block/mtip32xx: add missing GENERIC_HARDIRQS dependency

2013-02-06 Thread Jens Axboe
On Wed, Feb 06 2013, Heiko Carstens wrote: > The MTIP32XX driver calls devm_request_irq() and therefore needs a > GENERIC_HARDIRQS dependency to prevent building it on s390. I'll queue this up for 3.9, thanks Heiko. -- Jens Axboe -- To unsubscribe from this list: send the line &

Re: [RFC PATCH 5/8] scatterlist: introduce sg_unmark_end

2013-02-07 Thread Jens Axboe
On Thu, Feb 07 2013, Paolo Bonzini wrote: > This is useful in places that recycle the same scatterlist multiple > times, and do not want to incur the cost of sg_init_table every > time in hot paths. Looks fine to me. Acked-by: Jens Axboe -- Jens Axboe -- To unsubscribe from this l

Re: [RFC PATCH 0/8] virtio: new API for addition of buffers, scatterlist changes

2013-02-08 Thread Jens Axboe
th your workaround, but if other subsystems have > the same problem we do, perhaps we should consider a broader solution? Do other use cases actually exist? I don't think I've come across this requirement before, since it was introduced (6 years ago, from a cursory look at the git logs

Re: [PATCH 23/32] Generic dynamic per cpu refcounting

2013-02-08 Thread Jens Axboe
eview and the merge window is opening up pretty soon. > Kent, Andrew? I'd feel a lot better deferring the whole aio/dio performance series for one merge window. There's very little point in rushing it, and I don't think it's been reviewed/tested enough yet. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Jens Axboe
On Tue, Apr 02 2013, Dave Chinner wrote: > [Added jens Axboe to CC] > > On Tue, Apr 02, 2013 at 02:08:49AM -0400, CAI Qian wrote: > > Saw on almost all the servers range from x64, ppc64 and s390x with kernel > > 3.9-rc5 and xfsprogs-3.1.10. Never caught this in 3

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Jens Axboe
On Tue, Apr 02 2013, Jens Axboe wrote: > On Tue, Apr 02 2013, Dave Chinner wrote: > > [Added jens Axboe to CC] > > > > On Tue, Apr 02, 2013 at 02:08:49AM -0400, CAI Qian wrote: > > > Saw on almost all the servers range from x64, ppc64 and s390x with kernel > >

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Jens Axboe
On Tue, Apr 02 2013, CAI Qian wrote: > > > - Original Message - > > From: "Jens Axboe" > > To: "Dave Chinner" > > Cc: "CAI Qian" , x...@oss.sgi.com, "LKML" > > > > Sent: Tuesday, April 2, 2013 3:30:35 PM

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-02 Thread Jens Axboe
On Tue, Apr 02 2013, CAI Qian wrote: > > > - Original Message - > > From: "Jens Axboe" > > To: "CAI Qian" > > Cc: "Dave Chinner" , x...@oss.sgi.com, "LKML" > > > > Sent: Tuesday, April 2, 2013 5:00:47 PM

Re: [GIT PULL] writeback: convert writeback to unbound workqueue

2013-04-02 Thread Jens Axboe
hey make code simpler > and even have, while minute, measureable performance gain[3] even on a > workload which isn't particularly favorable to showing the benefits of > this conversion. Thanks, pulled in for testing. We'll need the debug change in before sending this upstream, tho

Re: Loopback device hung [was Re: xfs deadlock on 3.9-rc5 running xfstests case #78]

2013-04-03 Thread Jens Axboe
On Tue, Apr 02 2013, Jens Axboe wrote: > On Tue, Apr 02 2013, CAI Qian wrote: > > > > > > - Original Message ----- > > > From: "Jens Axboe" > > > To: "CAI Qian" > > > Cc: "Dave Chinner" , x...@oss.sgi.com,

Re: [GIT PULL] writeback: convert writeback to unbound workqueue

2013-04-03 Thread Jens Axboe
On Tue, Apr 02 2013, Tejun Heo wrote: > Hello, Jens. > > On Tue, Apr 2, 2013 at 2:53 AM, Jens Axboe wrote: > > Thanks, pulled in for testing. We'll need the debug change in before > > sending this upstream, though. I agree with Jan/Dave that this is > > requi

Re: [PATCH] block: avoid using uninitialized value in from queue_var_store

2013-04-03 Thread Jens Axboe
, rather than returning an error. Huh indeed, thanks Arnd. Queued up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/3] mtip32xx: recovery improvement and fix for a crash

2013-04-03 Thread Jens Axboe
s' > > > Asai Thambi S P (3): > mtip32xx: recovery from command timeout > mtip32xx: return 0 from pci probe in case of rebuild > mtip32xx: Add debugfs entry device_status Thanks Asai, applied for current series. -- Jens Axboe -- To unsubscribe from this list: send

[GIT PULL] Block IO core bits for 3.9

2013-02-28 Thread Jens Axboe
lock imbalance with failed allocations Guo Chao (2): block: use i_size_write() in bd_set_size() block: remove redundant check to bd_openers() Jens Axboe (1): Merge branch 'blkcg-cfq-hierarchy' of git://git.kernel.org/.../tj/cgroup into for-3.9/core Jianpeng Ma (

[GIT PULL] Block driver bits for 3.9

2013-02-28 Thread Jens Axboe
endency Jan Beulich (1): xen-blkback: do not leak mode property Jens Axboe (3): rsxx: add slab.h include to dma.c Merge branch 'delete-xt-disk' of git://git.kernel.org/.../paulg/linux into for-3.9/drivers Merge branch 'stable/for-jens-3.9' of git://git

Re: [GIT PULL] (xen) stable/for-jens-3.9

2013-02-19 Thread Jens Axboe
he tree is against 3.8, so I'm pulling it into my for-linus branch which will be pushed a bit after the initial for-3.9/drivers goes out. I can't pull it into the latter without getting a whole lot of extra changes too. -- Jens Axboe -- To unsubscribe from this list: send the line &qu

Re: [PATCHSET] writeback: convert writeback to unbound workqueue

2013-03-12 Thread Jens Axboe
ue: implement workqueue > with custom worker attributes" patchset[1] and available in the > following git branch. > > git://git.kernel.org/pub/scm/linux/kernel/git/tj/wq.git > review-writeback-conversion I like it, diffstat looks nice too :-) Have you done any performance testi

Re: [Patch 01/02v2] block: IBM FlashSystem 70/80 EEH Support.

2013-03-16 Thread Jens Axboe
es in v2 include: > o Fixed spelling of guarantee. > o Fixed potential memory leak if slot reset fails out. > o Changed list_for_each_entry_safe with list_for_each_entry. Applied, thanks Philip. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&

Re: [PATCH] block: Fix bad range check in bio_sector_offset

2012-08-29 Thread Jens Axboe
> - if (index >= bio->bi_idx) > - index = bio->bi_vcnt - 1; > + if (index > bio->bi_vcnt) > + return 0; > > __bio_for_each_segment(bv, bio, i, 0) { > if (i == index) { Good catch, merged. -- Jens Axboe -- To

Re: [PATCH] mtip32xx: fix user_buffer check in exec_drive_command

2012-09-12 Thread Jens Axboe
if (!user_buffer) > return -EFAULT; > > buf = dmam_alloc_coherent(&port->dd->pdev->dev, Thanks, that's clearly a bug. Applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [PATCH 2/9] block/blk-tag.c: Remove useless kfree

2012-09-12 Thread Jens Axboe
On 2012-09-12 17:06, Peter Senna Tschudin wrote: > From: Peter Senna Tschudin > > Remove useless kfree() and clean up code related to the removal. Thanks, nice cleanup! Applied to for-3.7/core -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-

Re: [2.6 patch] unexport add_disk_randomness

2008-01-30 Thread Jens Axboe
On Wed, Jan 30 2008, Adrian Bunk wrote: > This patch removes the no longer used EXPORT_SYMBOL(add_disk_randomness). > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> Thanks, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kern

Re: [BUG] io-scheduler : spinlock deadlock

2008-01-31 Thread Jens Axboe
On Thu, Jan 31 2008, Dave Young wrote: > While building kernel, lockdep detected spinlock deaklock and after a > while the system hung. > > Attached is the screenshot. Fixed by commit 149a051f82d2b3860fe32fa182dbc83a66274894 yesterday, just updated your kernel. -- Jens Axboe -- To

Re: [PATCH retry] bluetooth : add conn add/del workqueues to avoid connection fail

2008-01-31 Thread Jens Axboe
d(&conn->dev) < 0) { > BT_ERR("Failed to register connection device"); > return; > @@ -313,6 +316,7 @@ void hci_conn_add_sysfs(struct hci_conn > > INIT_WORK(&conn->work, add_conn); > > + queue_work(btaddconn, &

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Jens Axboe
s); - if (__blk_end_request(rq, 0, 0)) + if (__blk_end_request(rq, 0, rq->data_len)) BUG(); HWGROUP(drive)->rq = NULL; spin_unlock_irqrestore(&ide_lock, flags); -- Jens Axboe -- To unsubscribe from this l

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Jens Axboe
On Thu, Jan 31 2008, Florian Lohoff wrote: > On Thu, Jan 31, 2008 at 02:05:58PM +0100, Jens Axboe wrote: > > The below fix should be enough. It's perfectly legal to have leftover > > byte counts when the drive signals completion, happens all the time for > > eg user issue

Re: kernel BUG at ide-cd.c:1726 in 2.6.24-03863-g0ba6c33 && -g8561b089

2008-01-31 Thread Jens Axboe
On 31/01/2008, at 18.04, Kiyoshi Ueda <[EMAIL PROTECTED]> wrote: Hi Jens, On Thu, 31 Jan 2008 14:05:58 +0100, Jens Axboe wrote: On Thu, Jan 31 2008, Nai Xia wrote: My dmesg relevant info is quite similar: [6.875041] Freeing unused kernel memory: 320k freed [8.143120] ide-

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
nlock+0x9/0xb > [] ? __mutex_unlock_slowpath+0x10e/0x139 > [] ? trace_hardirqs_on+0xfe/0x128 > [] vfs_read+0xa4/0xe3 > [] sys_read+0x47/0x6f > [] system_call_after_swapgs+0x8a/0x8f Are you sure this triggered with the as fixup in place? It looks like the same bug. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Ingo Molnar wrote: > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > Are you sure this triggered with the as fixup in place? It looks like > > the same bug. > > most definitely a separate bug. yeah, I didn't read it carefully enoug

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
hanged; > + (*ioc2)->last_waited = (temp)->last_waited; > + (*ioc2)->nr_batch_requests = (temp)->nr_batch_requests; > + (*ioc2)->aic = (temp)->aic; > + (*ioc2)->radix_root = (temp)->radix_root; > + (*ioc2)->ioc_data = (temp)->ioc_data; > } > EXPOR

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Jens Axboe wrote: > On Fri, Feb 01 2008, Nikanth Karthikesan wrote: > > On Thu, 2008-01-31 at 23:14 +0100, Ingo Molnar wrote: > > > > > > Jens, > > > > > > AS still has some locking issues - see the lockdep warning below that

Re: [bug] as_merged_requests(): possible recursive locking detected

2008-02-01 Thread Jens Axboe
On Fri, Feb 01 2008, Ingo Molnar wrote: > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > On Fri, Feb 01 2008, Ingo Molnar wrote: > > > > > > * Jens Axboe <[EMAIL PROTECTED]> wrote: > > > > > > > Are you sure this trigger

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Jens Axboe
ng blk_cpu_done into a structure with a lock and list_head instead of just being a list head, and intercepted at blk_complete_request() time instead of waiting for an already raised softirq on that CPU. Didn't get around to any performance testing yet, though. Will try and clean it up a bit and do that. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Jens Axboe
On Mon, Feb 04 2008, Nick Piggin wrote: > On Mon, Feb 04, 2008 at 11:12:44AM +0100, Jens Axboe wrote: > > On Sun, Feb 03 2008, Nick Piggin wrote: > > > On Fri, Jul 27, 2007 at 06:21:28PM -0700, Suresh B wrote: > > > > > > Hi guys, > > > > > &

Re: soft lock failure on FC8

2008-02-04 Thread Jens Axboe
13 @@ call_for_each_cic(struct io_context *ioc > break; > > called += nr; > - index = 1 + (unsigned long) cics[nr - 1]->key; > - > + next_index = 1 + (unsigned long) cics[nr - 1]->key; > + if (next_index &l

Re: [rfc] direct IO submission and completion scalability issues

2008-02-04 Thread Jens Axboe
seems pretty straight forward. > > We might need some logic for noticing that the desired cpu has been > hot-plugged away while the IO was in flight, it occurs to me. the softirq completion stuff already handles cpus going away, at least with my patch that stuff works fine (with a dead flag

Re: [rfc] direct IO submission and completion scalability issues

2008-02-05 Thread Jens Axboe
On Mon, Feb 04 2008, Arjan van de Ven wrote: > Jens Axboe wrote: > >>I was imagining the patch a little bit differently (per-cpu tasks, do a > >>wake_up from the driver instead of cpu nr testing up in blk, work > >>queues, whatever), but we know how to i

Re: [PATCH 0/7] blk_end_request: full I/O completion handler

2008-02-05 Thread Jens Axboe
On Tue, Feb 05 2008, S, Chandrakala (STSD) wrote: > Hello, > > We would like to know in which kernel version these patches are > available. They were merged after 2.6.24 was released, so they will show up in the 2.6.25 kernel. -- Jens Axboe -- To unsubscribe from this list: s

Re: [GIT PULL] drbd-8.3 updates

2012-10-03 Thread Jens Axboe
ot pulled. Two reasons: - It's late (in the merge window) - and it's not based off my for-3.7/drivers branch, hence I get a ton of unrelated changes with a pull into that branch. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in th

Re: [GIT PULL] drbd-8.3 updates

2012-10-03 Thread Jens Axboe
one question before this is pulled in: > Philipp Reisner (6): > drbd: Add a drbd directory to sysfs > drbd: expose the data generation identifiers via sysfs What are these? It's sitting in /sys/block//drbd/, I don't see any documentation or justification for th

Re: [GIT PULL] drbd-8.3 updates

2012-10-03 Thread Jens Axboe
ware raid > as example. Software raid is different, though, in that it's a class/type of device. So for drbd, I'd still recommend you look outside of the regular /sys/block hierarchy for adding something like this. > I have removed it from this pull-request, so that there is more

Re: [patch/rfc/rft] sd: allocate request_queue on device's local numa node

2012-10-23 Thread Jens Axboe
from the last few years works, so the kernel parts should be updated to at least allow it to be a mask. How to get this information is a separate problem. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 033/193] block: remove CONFIG_EXPERIMENTAL

2012-10-23 Thread Jens Axboe
On 2012-10-23 22:01, Kees Cook wrote: > This config item has not carried much meaning for a while now and is > almost always enabled by default. As agreed during the Linux kernel > summit, remove it. > > CC: Jens Axboe > Signed-off-by: Kees Cook > --- > block/Kco

Re: [PATCH 1/2] block: move blk_queue_bypass_{start,end} to include/linux/blkdev.h

2012-10-25 Thread Jens Axboe
: stay in blk_queue_bypass until queue becomes initialized Applied. The previous state of private blk.h declaration but the symbols exported was wrong, too. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vg

Re: linux-next: manual merge of the block tree with Linus' tree

2012-10-31 Thread Jens Axboe
33d002f4b6b ("genhd: Make put_disk() safe for disks that have > not been registered") was supposed to be dropped or reverted; I don't > why it's hanging around. It's my for-next branch that wasn't updated yet. Will do that now. -- Jens Axboe -- To unsubscr

Re: [GIT PULL] 4 fixes for drbd

2012-11-01 Thread Jens Axboe
gt; drbd: check return of kmalloc in receive_uuids (2012-10-29 13:18:13 +0100) Can you rebase this against for-3.8/drivers? Thanks. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More m

Re: [GIT PULL] 4 fixes for drbd

2012-11-05 Thread Jens Axboe
base the other 3 commit on for-3.8/drivers) > > > The following changes since commit a13c29ddf73d3be4fbb2b1bbced64014986cd87a: > Jens Axboe (1): > Merge branch 'for-jens' of > git://git.kernel.org/pub/scm/linux/kernel/git/jikos/linux-block into > for-3.7/dr

Re: drbd-8.3 fixes

2012-07-30 Thread Jens Axboe
> drivers/block/drbd/drbd_nl.c | 36 +++- > drivers/block/drbd/drbd_proc.c |3 ++ > drivers/block/drbd/drbd_receiver.c | 38 +++-- > drivers/block/drbd/drbd_req.c |9 +++-- > drivers/block/drbd/drbd_worker.c | 12

Re: [PATCH 1/1] block/nbd: micro-optimization in nbd request completion

2012-07-30 Thread Jens Axboe
gt;> Add in-flight cmds to the tail. That way while searching(during request >>> completion),we will always get a hit on the first element. >>> > > Paul/Jens, > > Looks like this one isn't merged yet. I've merged it now. -- Jens Axboe -- To unsubscri

Re: [GIT] floppy

2012-07-31 Thread Jens Axboe
asynchronous > > Fengguang Wu (1): > floppy: remove duplicated flag FD_RAW_NEED_DISK I have pulled, it's in my for-3.6/drivers branch since I sent my reply. Updated now with Wu's patch too. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscrib

Re: [PATCH v5 1/3] block: Add test-iosched scheduler

2012-07-31 Thread Jens Axboe
om userspace with bsg and block tracing? IOW, I'm dubious as to whether a new _io scheduler_ is the correct solution to the problem you have at hand. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vge

Re: [PATCH 01/14] userns: Convert loop to use kuid_t instead of uid_t

2012-09-20 Thread Jens Axboe
On 2012-09-21 02:28, Eric W. Biederman wrote: > From: "Eric W. Biederman" > > Cc: Signed-off-by: Jens Axboe > Acked-by: Serge Hallyn > Signed-off-by: Eric W. Biederman > --- > drivers/block/loop.c |4 ++-- > include/linux/loop.h |2 +- > ini

Re: [PATCH 01/14] userns: Convert loop to use kuid_t instead of uid_t

2012-09-21 Thread Jens Axboe
On 2012-09-21 09:07, Eric W. Biederman wrote: > Jens Axboe writes: > >> On 2012-09-21 02:28, Eric W. Biederman wrote: >>> From: "Eric W. Biederman" >>> >>> Cc: Signed-off-by: Jens Axboe >>> Acked-by: Serge Hallyn >>> Signed-

Re: [PATCH 1/2] block: lift the initial queue bypass mode on blk_register_queue() instead of blk_init_allocated_queue()

2012-09-21 Thread Jens Axboe
t; different solution. > > Signed-off-by: Tejun Heo > Reported-by: Joseph Glanville > Cc: Vivek Goyal > Cc: sta...@vger.kernel.org > --- > Jens, while these are fixes, I think it isn't extremely urgent and > routing these through 3.7-rc1 should be enough. Agree, I

Re: Query of zram/zsmalloc promotion

2012-09-21 Thread Jens Axboe
tion, now zcache use it, too so it's rather awkward if we put it >> under dirver/blocks/zram/. >> >> So questions. >> >> To Andrew: >> Is it okay to put it under mm/ ? Or /lib? >> >> To Jens: >> Is it okay to put zram under drvier/block/ If

Re: [PATCH] block: export trace_block_unplug

2012-09-25 Thread Jens Axboe
On 09/25/2012 01:57 AM, NeilBrown wrote: > > Hi Jens, > is there any chance this can be in the next merge window? I'm > adding block tracing to md and found I need another export. No problem, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "un

Re: [PATCH] block: makes bio_split support bio without data

2012-09-25 Thread Jens Axboe
core as-is... Shaohua, could you resend an updated variant? -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time

2012-09-25 Thread Jens Axboe
look at the patch set? We are seeing problem > reports of this in the wild[1][2]. I'll queue it up for 3.7. I can run my regular testing on the 8-way, it has a nack for showing scaling problems very nicely in aio/dio. As long as we're not adding per-inode cache line dirtying per IO (

Re: [PATCH 0/4] Fix a crash when block device is read and block size is changed at the same time

2012-09-25 Thread Jens Axboe
On 2012-09-25 19:59, Jens Axboe wrote: > On 2012-09-25 19:49, Jeff Moyer wrote: >> Jeff Moyer writes: >> >>> Mikulas Patocka writes: >>> >>>> Hi Jeff >>>> >>>> Thanks for testing. >>>> >>>> It would be

Re: [PATCH 1/2] Fix a crash when block device is read and block size is changed at the same time

2012-09-25 Thread Jens Axboe
ying to some email in the middle of an existing thread. It all becomes very messy pretty quickly. Patch #2 had a botched subject line, so that didn't help either :-) -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a messa

Re: [GIT PULL] (xen) stable/for-jens-3.7

2012-09-26 Thread Jens Axboe
> > and has this tiny patch: > > Oliver Chick (1): > xen/blkback: Change xen_vbd's flush_support and discard_secure to have > type unsigned int, rather than bool Pulled. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel&qu

[GIT PULL] block driver bits for 3.7

2012-10-29 Thread Jens Axboe
ppy: properly handle failure on add_disk loop floppy: use common function to check if floppies can be registered floppy: remove dr, reuse drive on do_floppy_init Jens Axboe (6): Merge branch 'stable/for-jens-3.7' of git://git.kernel.org/.../konrad/xen into for-3.7/drivers

Re: [GIT PULL] block driver bits for 3.7

2012-10-29 Thread Jens Axboe
On 2012-10-29 19:35, Linus Torvalds wrote: > On Mon, Oct 29, 2012 at 11:21 AM, Jens Axboe wrote: >> >> Later than I would have liked, but I was traveling around the merge >> window and then a fixes snuck in past that and I wanted to ensure that >> everything was fully

[GIT PULL] block driver bits for 3.7

2012-10-30 Thread Jens Axboe
nbus.c | 9 ++-- fs/bio.c | 6 ++- 13 files changed, 113 insertions(+), 68 deletions(-) -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http:/

Re: [PATCH] percpu_counter: fix irq restore in __percpu_counter_add

2013-10-03 Thread Jens Axboe
> > Signed-off-by: Christoph Hellwig Thanks Christoph, merge issue I'm assuming. I'll fix it up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo i

Re: [PATCH 0/5] blk-mq fixes and improvements

2013-10-04 Thread Jens Axboe
stoph, applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH 0/5] blk-mq updates

2013-10-06 Thread Jens Axboe
ot;blk-mq: blk-mq should free bios in pass through case", and the last two > are minor cleanups. Looks good, applied! Thanks Christoph. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kern

Re: [PATCH] blk-mq: fix blk_mq_start_stopped_hw_queues from irq context

2013-10-06 Thread Jens Axboe
plied. Might not be a bad idea to just mimic the run queue API, and provide a blk_mq_start_hw_queue(hctx, is_async) instead. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More maj

Re: [PATCH, RFC] block: use a separate plug list for blk-mq requests

2013-10-06 Thread Jens Axboe
e revisited. So definitely room for improvement there. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

[GIT PULL] Block IO core bits for 3.11

2013-07-08 Thread Jens Axboe
r.c | 25 +- block/noop-iosched.c | 17 +- fs/block_dev.c |9 +- include/linux/cgroup.h |2 + include/linux/elevator.h |6 +- 12 files changed, 905 insertions(+), 434 deletio

Re: [PATCH] block: trace all devices plug operation.

2013-09-15 Thread Jens Axboe
On Mon, Sep 02 2013, majianpeng wrote: > Hi axboe: > How about this patch? Applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kern

Re: BLK_TN_PROCESS events not delivered for all devices

2013-09-17 Thread Jens Axboe
t doesn't seem to be > possible without tracking with each block trace which tasks it has been > notified about. And that is relatively expensive... It is unfortunately a known issue... I have not come up with a good way to fix it either, while keeping it cheap. So if you think of somethi

Re: BLK_TN_PROCESS events not delivered for all devices

2013-09-17 Thread Jens Axboe
On 09/17/2013 11:10 AM, Jan Kara wrote: > On Tue 17-09-13 08:29:07, Jens Axboe wrote: >> On 09/16/2013 03:23 AM, Jan Kara wrote: >>> Hi, >>> >>> I've been looking into a problem where BLK_TN_PROCESS events are not >>> delivered to all devic

Re: [PATCH] mtip32xx: dynamically allocate buffer in debugfs functions

2013-09-17 Thread Jens Axboe
t;>> >>> Signed-off-by: David Milburn >> >> Acked-by: Asai Thambi S P >> > Jens, > > Please include this patch too for 3.12. Queued up. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] bio-integrity: Fix use of bs->bio_integrity_pool after free

2013-09-17 Thread Jens Axboe
mething and we should teach Coverity to >>> shut up about it. >> >> Sorry - no, this is definitely a bug: >> >> Acked-by: Kent Overstreet > > From my v3.12-rc1 reminder list: what's going on with this patch? > > It's been acked, G

Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card.

2013-09-17 Thread Jens Axboe
On 09/17/2013 01:04 PM, Olof Johansson wrote: > On Thu, Sep 5, 2013 at 7:12 AM, Jens Axboe wrote: >> On 09/05/2013 06:00 AM, Jeff Moyer wrote: >>> OS Engineering writes: >>> >>>> Hi Jeff, >>>> >>>> Thank you for reviewing the patc

Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq'

2013-09-18 Thread Jens Axboe
s well, we do have debug facilities in place you can use for printing. And as mentioned a week or so ago, readq() isn't even used. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel

Re: [PATCH] block: Device driver for sTec's PCIe Kronos Card.

2013-09-05 Thread Jens Axboe
n it comes to new drivers. So no, I'd be surprised if we can't queue this up for 3.12. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [GIT PULL] (xen) stable/for-jens-3.12 for Jens Axboe

2013-09-06 Thread Jens Axboe
it://git.kernel.org/pub/scm/linux/kernel/git/xen/tip.git > stable/for-jens-3.12 > > which will give you bug-fixes to Xen blkfront and backend driver: Thanks, I'll get the 3.12 branch set up and pulled in. I'm behind on a lot of other drivers, too. -- Jens Axboe -- To unsubscr

Re: [PATCH] block: Convert kmalloc_node(...GFP_ZERO...) to kzalloc_node(...)

2013-09-11 Thread Jens Axboe
On Thu, Aug 29 2013, Joe Perches wrote: > Use the helper function instead of __GFP_ZERO. Applied. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vg

Re: [PATCH 0/3] blk-mq: Avoid effects of a weird queue depth

2013-09-12 Thread Jens Axboe
On 09/12/2013 01:42 AM, Alexander Gordeev wrote: > Hi Jens, > > Could you consider patches 4 and 5, please? Added. Really should be re-folded since the previous patches were broken, but I'll do that some time anyway for parts of the series again. -- Jens Axboe -- To unsubscribe

Re: [block:for-next 5/6] drivers/block/skd_main.c:441:3: error: implicit declaration of function 'readq'

2013-09-13 Thread Jens Axboe
he driver. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [patch 1/4] skd: use regular version of copy_from_user()

2013-09-13 Thread Jens Axboe
On 09/13/2013 01:55 AM, Dan Carpenter wrote: > The other __copy_from_user() calls have access_ok() checks so they are > fine, but these two don't have the check. Thanks Dan, applied this one and the other two. Did you miss sending one out? I don't see a 3/4 patch. -- J

Re: [PATCH RFC 0/2] Convert from bio-based to blk-mq

2013-10-08 Thread Jens Axboe
ed drivers with lots of duplicated code and mechanisms. We need to move away from that. -- Jens Axboe -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

  1   2   3   4   5   6   7   8   9   10   >