Re: [PATCH V2 1/3] perf,tools: get correct cpu id for print_aggr

2015-08-28 Thread a...@kernel.org
Em Fri, Aug 28, 2015 at 01:33:22PM +, Liang, Kan escreveu: > > On Thu, Jul 02, 2015 at 03:08:43AM -0400, kan.li...@intel.com wrote: > > > From: Kan Liang > > > print_aggr fails to print per-core/per-socket statistics after commit > > > 582ec0829b3d ("perf stat: Fix per-socket output bug for un

Re: [PATCH 2/2] perf probe: Support probing at absolute address

2015-08-26 Thread a...@kernel.org
Em Wed, Aug 26, 2015 at 12:02:40AM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: > > From: Wang Nan [mailto:wangn...@huawei.com] > > > > It should be useful to allow 'perf probe' probe at absolute offset of > > a target. For example, when (u)probing at a instruction of a shared > > object in a embedded

Re: [PATCH 2/2] perf probe: Support probing at absolute address

2015-08-26 Thread a...@kernel.org
Em Wed, Aug 26, 2015 at 10:38:18AM +0800, Wangnan (F) escreveu: > > On 2015/8/26 8:02, 平松雅巳 / HIRAMATU,MASAMI wrote: > >>From: Wang Nan [mailto:wangn...@huawei.com] > >> > >>It should be useful to allow 'perf probe' probe at absolute offset of > >>a target. For example, when (u)probing at a instru

Re: [PATCH V7 1/1] perf tool:perf diff support for different binaries

2015-02-25 Thread a...@kernel.org
Em Wed, Feb 25, 2015 at 03:14:06PM +, Liang, Kan escreveu: > Hi Arnaldo, > > Could you please review the patch? > I've already updated the patch description to try to address your concern. > Please let me know if you have any questions. Just out of time, sorry, will get to it eventually. - A

Re: [PATCH V2 1/1] perf/core: don't find side-band event from all pmus

2016-03-31 Thread a...@kernel.org
Em Thu, Mar 31, 2016 at 02:05:46PM +, Liang, Kan escreveu: > > > > > +static void perf_event_sb_mask(unsigned int sb_mask, > > > +perf_event_aux_output_cb output, > > > +void *data) > > > +{ > > > + int sb; > > > + > > > + for (sb = 0; sb < sb_n

Re: [PATCH 2/2] perf tools: Fix find_perf_probe_point_from_map() which incorrectly returns success

2015-11-05 Thread a...@kernel.org
Em Thu, Nov 05, 2015 at 02:08:48PM +, 平松雅巳 / HIRAMATU,MASAMI escreveu: > From: Wang Nan [mailto:wangn...@huawei.com] > > > >It is possible that find_perf_probe_point_from_map() fails to find > >symbol but still returns 0 because of an small error when coding: > >find_perf_probe_point_from_map()

Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps

2015-06-30 Thread a...@kernel.org
Em Tue, Jun 30, 2015 at 03:54:49PM +0200, Jiri Olsa escreveu: > On Tue, Jun 30, 2015 at 01:42:49PM +, Liang, Kan wrote: > > > > +static int perf_evlist__check_evsel_cpus(struct perf_evlist *evlist, > > > > +struct perf_evsel *evsel) { > > > > + const struct cpu_map *cpus = evlist->cpus; >

Re: [PATCH v3 0/4] perf script python: add Python3 support

2019-03-11 Thread a...@kernel.org
Em Mon, Mar 11, 2019 at 09:27:07AM +, Hunter, Adrian escreveu: > > From: Tony Jones [mailto:to...@suse.de] > > Once these are applied I believe this is everything needed to run on a > > system > > without Python2. > All look fine to me. Here is my ack as needed: > Acked-by: Adrian Hunter

Re: [PATCH] perf diff: bug fix, donot overwrite valid build id

2016-12-19 Thread a...@kernel.org
Em Mon, Dec 19, 2016 at 02:53:30PM +, Liang, Kan escreveu: > Hi Arnaldo, > > Ping > > Are you OK with the fix? Yeah, looks ok, will merge it. - Arnaldo > Thanks, > Kan > > > > > From: Kan Liang > > > > Fixes a perf diff regression issue which was introduced by commit > > 5baecbcd9c9a

Re: [PATCH] perf tools: ignore zombie process for user profile

2016-12-14 Thread a...@kernel.org
Em Wed, Dec 14, 2016 at 06:26:02PM +, Liang, Kan escreveu: > > On Wed, Dec 14, 2016 at 12:48:05PM -0500, kan.li...@intel.com wrote: > > > From: Kan Liang > > > Zombie process is dead process. It is meaningless to profile it. > > > It's better to ignore it for user profile. > > I recently post

Re: [PATCH v1] perf vendor events: Add mapping for KnightsMill PMU events

2017-03-01 Thread a...@kernel.org
Em Wed, Mar 01, 2017 at 09:58:41AM +, Wachowski, Karol escreveu: > On Monday, February 20, 2017 12:51 PM +0100, Karol Wachowski wrote: > > Reuse events from KnightsLanding for KnightsMill > > +++ b/tools/perf/pmu-events/arch/x86/mapfile.csv > > @@ -17,6 +17,7 @@ GenuineIntel-6-3A,v18,ivybridge

Re: [PATCH] Revert "perf tools: Allow to specify custom linker command"

2015-07-14 Thread a...@kernel.org
Em Tue, Jul 14, 2015 at 02:00:05PM +, Alexey Brodkin escreveu: > On Tue, 2015-07-14 at 10:46 -0300, Arnaldo Carvalho de Melo wrote: > > Em Mon, Jul 13, 2015 at 11:24:06PM +0300, Aaro Koskinen escreveu: > > > > But for now to fix cross-building of perf this revert is enough. > > > Hmm. You are

Re: [PATCH RFC V4 5/6] perf top: switch to backward overwrite mode

2017-10-02 Thread a...@kernel.org
Em Mon, Oct 02, 2017 at 05:19:41PM +, Liang, Kan escreveu: > > > > On Fri, Sep 29, 2017 at 07:47:56AM -0700, kan.li...@intel.com wrote: > > > From: Kan Liang > > > > > > perf_top__mmap_read has severe performance issue in Knights > > > Landing/Mill, when monitoring in heavy load system. It c

Re: [PATCH V3 0/6] event synthesization multithreading for perf record

2017-10-23 Thread a...@kernel.org
Em Mon, Oct 23, 2017 at 01:43:39PM +, Liang, Kan escreveu: > The plan is to do the multithreading step by step from the simplest case. > Synthesizing stage is just a start. > Only for synthesizing stage, I think the patch series should already cover > all the > 'synthesizing' steps which can