Re: [PATCH] iwlwifi3945/4965 - fix rate control algo reference leak

2007-12-06 Thread Zhu Yi
On Thu, 2007-12-06 at 12:39 +0300, Cyrill Gorcunov wrote: > From: Cyrill Gorcunov <[EMAIL PROTECTED]> > Subject: [PATCH] iwlwifi3945/4965 - fix rate control algo reference leak > > This patch does fix rate control algo reference leak in case > if network device has been failed to register. In thi

Re: [PATCH] iwlwifi3945/4965 - fix rate control algo reference leak

2007-12-09 Thread Zhu Yi
On Sat, 2007-12-08 at 09:56 -0500, Mark Lord wrote: > > Any chance of getting LEDs support re-added to this driver, > perhaps in the 2.6.25 timeframe? I'd also like to see it happen. Stay tuned. Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body o

Re: [2.6 patch] wireless/ipw2200.c: add __dev{init,exit} annotations

2007-12-11 Thread Zhu Yi
On Tue, 2007-12-11 at 23:20 +0100, Adrian Bunk wrote: > This patch adds __dev{init,exit} annotations. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ACK. Thanks, -yi -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More

Re: [PATCH 1/2] [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic.

2007-11-28 Thread Zhu Yi
On Wed, 2007-11-28 at 19:41 +0900, Joonwoo Park wrote: > [net/wireless/iwlwifi] : iwlwifi 3945 Fix race conditional panic. > > Signed-off-by: Joonwoo Park <[EMAIL PROTECTED]> > --- > diff --git a/drivers/net/wireless/iwlwifi/iwl3945-base.c > b/drivers/net/wireless/iwlwifi/iwl3945-base.c > index 4

Re: [PATCH] iwlwifi: remove redundant declaration of 'iwl3945_priv' and 'iwl4965_priv' structs

2007-11-25 Thread Zhu Yi
On Sun, 2007-11-25 at 15:58 +0100, Miguel Botón wrote: > This patch removes a redundant declaration of 'iwl3945_priv' and > 'iwl4965_priv' structs. > > Signed-off-by: Miguel Boton <[EMAIL PROTECTED]> ACK. Thanks, -yi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in t

Re: [ipw3945-devel] [PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-10 Thread Zhu Yi
Hi Joonwoo, We already did something similiar in our code base. Could you please take a look at this patch? http://intellinuxwireless.org/repos/?p=iwlwifi.git;a=commitdiff;h=57aa02255e9d7be5e2494683fc2793bd1d0707e2 Thanks, -yi On Wed, 2008-01-09 at 20:02 +0900, Joonwoo Park wrote: > Eleminiate t

Re: [ipw3945-devel] [PATCH 4/5] iwlwifi: iwl3945 eliminate sleepable task queue from context

2008-01-10 Thread Zhu Yi
On Fri, 2008-01-11 at 10:38 +0900, Joonwoo Park wrote: > I should have checked code base, it's my fault. > it's seems very similar, but I could not made build unfortunately. > Can you introduce to me how to build it please? > > my build error is here: > [EMAIL PROTECTED] ~/SRC/DRIVERS/iwlwifi $ >

Re: [PATCH] iwlwifi: fix typo in 'drivers/net/wireless/iwlwifi/Kconfig'

2007-12-18 Thread Zhu Yi
-help--- > This option will enable spectrum measurement for the iwl4965 driver. Thanks, but there is another one. Signed-off-by: Zhu Yi <[EMAIL PROTECTED]> diff --git a/drivers/net/wireless/iwlwifi/Kconfig b/drivers/net/wireless/iwlwifi/Kconfig index c91e5f9..66ca942 100644 ---

Re: [ipw3945-devel] 2.6.24-rc5-mm1 -- INFO: possible circular locking dependency detected -- pm-suspend/5800 is trying to acquire lock

2007-12-18 Thread Zhu Yi
On Tue, 2007-12-18 at 15:57 +0100, Johannes Berg wrote: > Thanks. This is a bug in iwlwifi. > > The problem is actually another case where my workqueue debugging with > lockdep is triggering a warning :)) > > Here's the thing: > > iwl3945_cancel_deferred_work does > > cancel_delayed_work_sync

Re: [PATCH] iwlwifi: Remove unnecessary code in iwl3945 and iwl4965 drivers

2007-11-11 Thread Zhu Yi
On Sat, 2007-11-10 at 20:49 +0100, Miguel Botón wrote: > Remove unnecesary code in iwl3945 and iwl4965 drivers. > > "final_mode" variable is already initialized with the value of the > "mode" variable. > > Signed-off-by: Miguel Boton <[EMAIL PROTECTED]> ACK. Or you can do "u32 uninitialized_var

Re: iwl3945 in 2.6.24-rc1 dies under load

2007-10-30 Thread Zhu Yi
On Wed, 2007-10-31 at 01:52 +0100, Pavel Machek wrote: > tcpspray -n 1 -b 1000 10.0.0.2 > > Oct 31 01:42:56 amd kernel: iwl3945: Microcode SW error detected. > Restarting 0x8208. > Oct 31 01:42:56 amd kernel: iwl3945: Error Reply type 0x0005 cmd > REPLY_TX (0x1C) seq 0x02C7 ser 0x

Re: iwl3945 in 2.6.24-rc1 dies under load

2007-10-31 Thread Zhu Yi
On Thu, 2007-11-01 at 01:12 +0100, Pavel Machek wrote: > iwl3945: Microcode SW error detected. Restarting 0x8208. > iwl3945: Start IWL Error Log Dump: > iwl3945: Status: 0x00010172, Config: count: 1 > iwl3945: Desc Time asrtPC blink2 ilink1 nmiPC Line > iwl3945: SYSAS

Re: [PATCH 1/3] iwl3945 & iwl4965: mark more functions/variables static

2007-10-24 Thread Zhu Yi
On Fri, 2007-10-12 at 14:32 +0200, Christoph Hellwig wrote: > int iwl_param_disable; /* def: enable radio */ > int iwl_param_antenna; /* def: 0 = both antennas (use diversity) > */ > int iwl_param_hwcrypto; /* def: using software encryption */ > -int iwl_param_qos_enable = 1; > +s

Re: [PATCH] iwl3945: cleanup namespace

2007-10-25 Thread Zhu Yi
On Fri, 2007-10-12 at 15:05 +0200, Christoph Hellwig wrote: > prefix all symbols with iwl3945_ and thus allow building the driver > into the kernel. Also remove all the useless default statements in > Kconfig while we're at it. > > > Signed-off-by: Christoph Hellwig <[EMAIL PROTECTED]> Did you

Re: [PATCH] jiffies_round -> jiffies_round_relative conversion - ipw2100/ipw2200

2007-10-16 Thread Zhu Yi
On Mon, 2007-10-15 at 00:38 -0500, Anton Blanchard wrote: > > When rounding a relative timeout we need to use > round_jiffies_relative(). ACK. John, please apply this patch to wireless-2.6. Thanks. -yi - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a

Re: [2.6 patch] iwl4965-base.c: fix off-by-one errors

2007-10-17 Thread Zhu Yi
On Sun, 2007-10-14 at 19:51 +0200, Adrian Bunk wrote: > This patch fixes two off-by-one errors resulting in array overflows > spotted by the Coverity checker. > > Signed-off-by: Adrian Bunk <[EMAIL PROTECTED]> ACK. John, please apply. Thanks, -yi - To unsubscribe from this list: send the line

Re: [PATCH 1/3] iwl3945 & iwl4965: mark more functions/variables static

2007-10-18 Thread Zhu Yi
On Thu, 2007-10-18 at 09:26 +0100, Christoph Hellwig wrote: > ping. Pong. Sorry for the late response, I just come back from vacation. I'm looking at your patches. Basically I agree with them. But I also have some other patches pending. So I need to merge them together into one patch series and

Re: [PATCH] NET: [UPDATED] Multiqueue network device support implementation.

2007-04-11 Thread Zhu Yi
On Wed, 2007-04-11 at 19:03 +0200, Patrick McHardy wrote: > > You bring up a good point, it would be good to hear the opinion from > one of the wireless people on this since they have their own > multiqueue scheduler in the wireless-dev tree. The one in the wireless-dev is pretty much like this

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-28 Thread Zhu, Yi Xin
On 8/28/2018 3:09 AM, Stephen Boyd wrote: Quoting yixin zhu (2018-08-08 01:52:20) On 8/8/2018 1:50 PM, Stephen Boyd wrote: Quoting Songjun Wu (2018-08-02 20:02:21) + struct clk *clk; + int idx; + + for (idx = 0; idx < nr_clks; idx++, osc++) { + if (!osc->dt_fr

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-08-29 Thread Zhu, Yi Xin
+} + +CLK_OF_DECLARE(intel_grx500_cgu, "intel,grx500-cgu", grx500_clk_init); Any reason a platform driver can't be used instead of CLK_OF_DECLARE()? It provides CPU clock which is used in early boot stage. Ok. What is the CPU clock doing in early boot stage? Some sort of timer frequency? If th

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-09-03 Thread Zhu, Yi Xin
On 9/1/2018 1:10 AM, Stephen Boyd wrote: Quoting Zhu, Yi Xin (2018-08-28 23:56:22) On 8/28/2018 3:09 AM, Stephen Boyd wrote: Quoting yixin zhu (2018-08-08 01:52:20) On 8/8/2018 1:50 PM, Stephen Boyd wrote: +/* clock flags definition */ +#define CLOCK_FLAG_VAL_INITBIT(16) +#define

Re: [PATCH v2 02/18] clk: intel: Add clock driver for Intel MIPS SoCs

2018-09-03 Thread Zhu, Yi Xin
On 9/1/2018 1:13 AM, Stephen Boyd wrote: Quoting Zhu, Yi Xin (2018-08-29 03:34:26) +} + +CLK_OF_DECLARE(intel_grx500_cgu, "intel,grx500-cgu", grx500_clk_init); Any reason a platform driver can't be used instead of CLK_OF_DECLARE()? It provides CPU clock which is used in e